ipv6: sr: introduce seg6local End.BPF action
Subsystems (8)
v4 cover ipv6: sr: introduce seg6local End.BPF action
As of Linux 4.14, it is possible to define advanced local processing for IPv6 packets with a Segment Routing Header through the seg6local LWT infrastructure. This LWT implements the network programming principles defined in the IETF “SRv6 Network Programming” draft.
The implemented operations are generic, and it would be very interesting to be able to implement user-specific seg6local actions, without having to modify the kernel directly. To do so, this patchset adds an End.BPF action to seg6local, powered by some specific Segment Routing-related helpers, which provide SR functionalities that can be applied on the packet. This BPF hook would then allow to implement specific actions at native kernel speed such as OAM features, advanced SR SDN policies, SRv6 actions like Segment Routing Header (SRH) encapsulation depending on the content of the packet, etc.
This patchset is divided in 6 patches, whose main features are :
- A new seg6local action End.BPF with the corresponding new BPF program type BPF_PROG_TYPE_LWT_SEG6LOCAL. Such attached BPF program can be passed to the LWT seg6local through netlink, the same way as the LWT BPF hook operates.
- 3 new BPF helpers for the seg6local BPF hook, allowing to edit/grow/ shrink a SRH and apply on a packet some of the generic SRv6 actions.
- 1 new BPF helper for the LWT BPF IN hook, allowing to add a SRH through encapsulation (via IPv6 encapsulation or inlining if the packet contains already an IPv6 header).
As this patchset adds a new LWT BPF hook, I took into account the result of the discussions when the LWT BPF infrastructure got merged. Hence, the seg6local BPF hook doesn’t allow write access to skb->data directly, only the SRH can be modified through specific helpers, which ensures that the integrity of the packet is maintained.
More details are available in the related patches messages.
The performances of this BPF hook have been assessed with the BPF JIT enabled on a Intel Xeon X3440 processors with 4 cores and 8 threads clocked at 2.53 GHz. No throughput losses are noted with the seg6local BPF hook when the BPF program does nothing (440kpps). Adding a 8-bytes TLV (1 call each to bpf_lwt_seg6_adjust_srh and bpf_lwt_seg6_store_bytes) drops the throughput to 410kpps, and inlining a SRH via bpf_lwt_seg6_action drops the throughput to 420kpps.
All throughputs are stable.
-------
v2: move the SRH integrity state from skb->cb to a per-cpu buffer
v3: - document helpers in man-page style
- fix kbuild bugs
- un-break BPF LWT out hook
- bpf_push_seg6_encap is now static
- preempt_enable is now called when the packet is dropped in input_action_end_bpf
v4: fix kbuild bugs when CONFIG_IPV6=m
Thanks.
Mathieu Xhonneux (6):
ipv6: sr: make seg6.h includable without IPv6
ipv6: sr: export function lookup_nexthop
bpf: Add IPv6 Segment Routing helpers
bpf: Split lwt inout verifier structures
ipv6: sr: Add seg6local action End.BPF selftests/bpf: test for seg6local End.BPF action
include/linux/bpf_types.h | 7 +- include/net/seg6.h | 7 +- include/net/seg6_local.h | 32 ++ include/uapi/linux/bpf.h | 96 ++++- include/uapi/linux/seg6_local.h | 3 + kernel/bpf/verifier.c | 1 + net/core/filter.c | 390 ++++++++++++++++--- net/ipv6/Kconfig | 5 + net/ipv6/seg6_local.c | 180 ++++++++- tools/include/uapi/linux/bpf.h | 97 ++++- tools/testing/selftests/bpf/Makefile | 5 +- tools/testing/selftests/bpf/bpf_helpers.h | 12 + tools/testing/selftests/bpf/test_lwt_seg6local.c | 438 ++++++++++++++++++++++ tools/testing/selftests/bpf/test_lwt_seg6local.sh | 140 +++++++ 14 files changed, 1340 insertions(+), 73 deletions(-) create mode 100644 include/net/seg6_local.h create mode 100644 tools/testing/selftests/bpf/test_lwt_seg6local.c create mode 100755 tools/testing/selftests/bpf/test_lwt_seg6local.sh
Signature · 1 line
2.16.1
PATCH v4 1/6 ipv6: sr: make seg6.h includable without IPv6
include/net/seg6.h cannot be included in a source file if CONFIG_IPV6 is not enabled:
include/net/seg6.h: In function 'seg6_pernet':
Quoted 1 line
Quoted 1 line
include/net/seg6.h:52:14: error: 'struct net' has no member named
'ipv6'; did you mean 'ipv4'?
return net->ipv6.seg6_data;
^~~~
ipv4This commit makes seg6_pernet return NULL if IPv6 is not compiled, hence allowing seg6.h to be included regardless of the configuration.
--- include/net/seg6.h | 4 ++++ 1 file changed, 4 insertions(+)
include/net/seg6.h +4 -0
@@ -49,7 +49,11 @@ struct seg6_pernet_data {static inline struct seg6_pernet_data *seg6_pernet (struct net *net) { +#if IS_ENABLED (CONFIG_IPV6 )return net->ipv6.seg6_data; +#else +return NULL ; +#endif }extern int seg6_init (void );
Signature · 1 line
2.16.1
PATCH v4 2/6 ipv6: sr: export function lookup_nexthop
In reply to Mathieu XhonneuxThe function lookup_nexthop is essential to implement most of the seg6local actions. As we want to provide a BPF helper allowing to apply some of these actions on the packet being processed, the helper should be able to call this function, hence the need to make it public.
Moreover, if one argument is incorrect or if the next hop can not be found, an error should be returned by the BPF helper so the BPF program can adapt its processing of the packet (return an error, properly force the drop, ...). This patch hence makes this function return dst->error to indicate a possible error.
--- include/net/seg6.h | 3 ++- include/net/seg6_local.h | 24 ++++++++++++++++++++++++ net/ipv6/seg6_local.c | 20 +++++++++++--------- 3 files changed, 37 insertions(+), 10 deletions(-) create mode 100644 include/net/seg6_local.h
include/net/seg6.h +2 -1
@@ -67,5 +67,6 @@ extern bool seg6_validate_srh(struct ipv6_sr_hdr *srh, int len);extern int seg6_do_srh_encap (struct sk_buff *skb,struct ipv6_sr_hdr *osrh,int proto);extern int seg6_do_srh_inline (struct sk_buff *skb,struct ipv6_sr_hdr *osrh); - +extern int seg6_lookup_nexthop (struct sk_buff *skb,struct in6_addr *nhaddr, +u32 tbl_id);#endif
include/net/seg6_local.h new file +24 -0
@@ -0,0 +1,24 @@ +/* +* SR-IPv6 implementation +* +* Authors: +* David Lebrun <[email protected]> +* eBPF support: Mathieu Xhonneux <[email protected]> +* +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License +* as published by the Free Software Foundation; either version +* 2 of the License, or (at your option) any later version. +*/ + +#ifndef _NET_SEG6_LOCAL_H +#define _NET_SEG6_LOCAL_H + +#include <linux/net.h> +#include <linux/ipv6.h> + +extern int seg6_lookup_nexthop (struct sk_buff *skb,struct in6_addr *nhaddr, +u32 tbl_id); + +#endif
net/ipv6/seg6_local.c +11 -9
@@ -30,6 +30,7 @@#ifdef CONFIG_IPV6_SEG6_HMAC #include <net/seg6_hmac.h> #endif +#include <net/seg6_local.h> #include <linux/etherdevice.h> struct seg6_local_lwt ;
@@ -140,8 +141,8 @@ static void advance_nextseg(struct ipv6_sr_hdr *srh, struct in6_addr *daddr) *daddr = *addr; } -static void lookup_nexthop (struct sk_buff *skb,struct in6_addr *nhaddr, -u32 tbl_id) +int seg6_lookup_nexthop (struct sk_buff *skb,struct in6_addr *nhaddr, +u32 tbl_id) {struct net *net =dev_net (skb->dev);struct ipv6hdr *hdr =ipv6_hdr (skb);
@@ -187,6 +188,7 @@ static void lookup_nexthop(struct sk_buff *skb, struct in6_addr *nhaddr,skb_dst_drop (skb);skb_dst_set (skb, dst); +return dst->error; }/* regular endpoint function */
@@ -200,7 +202,7 @@ static int input_action_end(struct sk_buff *skb, struct seg6_local_lwt *slwt)advance_nextseg (srh, &ipv6_hdr (skb)->daddr); -lookup_nexthop (skb,NULL ,0 ); +seg6_lookup_nexthop (skb,NULL ,0 );return dst_input (skb);
@@ -220,7 +222,7 @@ static int input_action_end_x(struct sk_buff *skb, struct seg6_local_lwt *slwt)advance_nextseg (srh, &ipv6_hdr (skb)->daddr); -lookup_nexthop (skb, &slwt->nh6,0 ); +seg6_lookup_nexthop (skb, &slwt->nh6,0 );return dst_input (skb);
@@ -239,7 +241,7 @@ static int input_action_end_t(struct sk_buff *skb, struct seg6_local_lwt *slwt)advance_nextseg (srh, &ipv6_hdr (skb)->daddr); -lookup_nexthop (skb,NULL , slwt->table); +seg6_lookup_nexthop (skb,NULL , slwt->table);return dst_input (skb);
@@ -331,7 +333,7 @@ static int input_action_end_dx6(struct sk_buff *skb,if (!ipv6_addr_any (&slwt->nh6)) nhaddr = &slwt->nh6; -lookup_nexthop (skb, nhaddr,0 ); +seg6_lookup_nexthop (skb, nhaddr,0 );return dst_input (skb); drop:
@@ -380,7 +382,7 @@ static int input_action_end_dt6(struct sk_buff *skb,if (!pskb_may_pull (skb,sizeof (struct ipv6hdr ))) goto drop; -lookup_nexthop (skb,NULL , slwt->table); +seg6_lookup_nexthop (skb,NULL , slwt->table);return dst_input (skb);
@@ -406,7 +408,7 @@ static int input_action_end_b6(struct sk_buff *skb, struct seg6_local_lwt *slwt)ipv6_hdr (skb)->payload_len =htons (skb->len -sizeof (struct ipv6hdr ));skb_set_transport_header (skb,sizeof (struct ipv6hdr )); -lookup_nexthop (skb,NULL ,0 ); +seg6_lookup_nexthop (skb,NULL ,0 );return dst_input (skb);
@@ -438,7 +440,7 @@ static int input_action_end_b6_encap(struct sk_buff *skb,ipv6_hdr (skb)->payload_len =htons (skb->len -sizeof (struct ipv6hdr ));skb_set_transport_header (skb,sizeof (struct ipv6hdr )); -lookup_nexthop (skb,NULL ,0 ); +seg6_lookup_nexthop (skb,NULL ,0 );return dst_input (skb);
Signature · 1 line
2.16.1
PATCH v4 3/6 bpf: Add IPv6 Segment Routing helpers
In reply to Mathieu XhonneuxThe BPF seg6local hook should be powerful enough to enable users to implement most of the use-cases one could think of. After some thinking, we figured out that the following actions should be possible on a SRv6 packet, requiring 3 specific helpers :
- bpf_lwt_seg6_store_bytes: Modify non-sensitive fields of the SRH
- bpf_lwt_seg6_adjust_srh: Allow to grow or shrink a SRH (to add/delete TLVs)
- bpf_lwt_seg6_action: Apply some SRv6 network programming actions (specifically End.X, End.T, End.B6 and End.B6.Encap)
The specifications of these helpers are provided in the patch (see include/uapi/linux/bpf.h).
The non-sensitive fields of the SRH are the following : flags, tag and TLVs. The other fields can not be modified, to maintain the SRH integrity. Flags, tag and TLVs can easily be modified as their validity can be checked afterwards via seg6_validate_srh. It is not allowed to modify the segments directly. If one wants to add segments on the path, he should stack a new SRH using the End.B6 action via bpf_lwt_seg6_action.
Growing, shrinking or editing TLVs via the helpers will flag the SRH as invalid, and it will have to be re-validated before re-entering the IPv6 layer. This flag is stored in a per-CPU buffer, along with the current header length in bytes.
Storing the SRH len in bytes in the control block is mandatory when using bpf_lwt_seg6_adjust_srh. The Header Ext. Length field contains the SRH len rounded to 8 bytes (a padding TLV can be inserted to ensure the 8-bytes boundary). When adding/deleting TLVs within the BPF program, the SRH may temporary be in an invalid state where its length cannot be rounded to 8 bytes without remainder, hence the need to store the length in bytes separately. The caller of the BPF program can then ensure that the SRH's final length is valid using this value. Again, a final SRH modified by a BPF program which doesn’t respect the 8-bytes boundary will be discarded as it will be considered as invalid.
Finally, a fourth helper is provided, bpf_lwt_push_encap, which is available from the LWT BPF IN hook, but not from the seg6local BPF one. This helper allows to encapsulate a Segment Routing Header (either with a new outer IPv6 header, or by inlining it directly in the existing IPv6 header) into a non-SRv6 packet. This helper is required if we want to offer the possibility to dynamically encapsulate a SRH for non-SRv6 packet, as the BPF seg6local hook only works on traffic already containing a SRH. This is the BPF equivalent of the seg6 LWT infrastructure, which achieves the same purpose but with a static SRH per route.
--- include/net/seg6_local.h | 8 ++ include/uapi/linux/bpf.h | 95 +++++++++++++++- net/core/filter.c | 282 +++++++++++++++++++++++++++++++++++++++++++---- net/ipv6/Kconfig | 5 + net/ipv6/seg6_local.c | 2 + 5 files changed, 368 insertions(+), 24 deletions(-)
include/net/seg6_local.h +8 -0
@@ -15,10 +15,18 @@#ifndef _NET_SEG6_LOCAL_H#define _NET_SEG6_LOCAL_H +#include <linux/percpu.h> #include <linux/net.h> #include <linux/ipv6.h> extern int seg6_lookup_nexthop (struct sk_buff *skb,struct in6_addr *nhaddr,u32 tbl_id); +struct seg6_bpf_srh_state { +bool valid; +u16 hdrlen; +}; + +DECLARE_PER_CPU(struct seg6_bpf_srh_state, seg6_bpf_srh_states); +#endif
include/uapi/linux/bpf.h +94 -1
113 lines not on this page · raw message
net/core/filter.c +259 -23
306 lines not on this page · raw message
net/ipv6/Kconfig +5 -0
@@ -330,4 +330,9 @@ config IPV6_SEG6_HMAC If unsure, say N. +config IPV6_SEG6_BPF + def_bool y + depends on IPV6_SEG6_LWTUNNEL + depends on IPV6 = y + endif # IPV6
net/ipv6/seg6_local.c +2 -0
@@ -449,6 +449,8 @@ static int input_action_end_b6_encap(struct sk_buff *skb,return err; } +DEFINE_PER_CPU(struct seg6_bpf_srh_state, seg6_bpf_srh_states); +static struct seg6_action_desc seg6_action_table[] = { { .action =SEG6_LOCAL_ACTION_END ,
Signature · 1 line
2.16.1
PATCH v4 4/6 bpf: Split lwt inout verifier structures
In reply to Mathieu XhonneuxThe new bpf_lwt_push_encap helper should only be accessible within the LWT BPF IN hook, and not the OUT one, as this may lead to a skb under panic.
At the moment, both LWT BPF IN and OUT share the same list of helpers, whose calls are authorized by the verifier. This patch separates the verifier ops for the IN and OUT hooks, and allows the IN hook to call the bpf_lwt_push_encap helper.
This patch is also the occasion to put all lwt_*_func_proto functions together for clarity. At the moment, socks_op_func_proto is in the middle of lwt_inout_func_proto and lwt_xmit_func_proto.
--- include/linux/bpf_types.h | 4 +-- net/core/filter.c | 83 +++++++++++++++++++++++++++++------------------ 2 files changed, 54 insertions(+), 33 deletions(-)
include/linux/bpf_types.h +2 -2
@@ -9,8 +9,8 @@ BPF_PROG_TYPE(BPF_PROG_TYPE_XDP, xdp) BPF_PROG_TYPE(BPF_PROG_TYPE_CGROUP_SKB, cg_skb) BPF_PROG_TYPE(BPF_PROG_TYPE_CGROUP_SOCK, cg_sock) BPF_PROG_TYPE(BPF_PROG_TYPE_CGROUP_SOCK_ADDR, cg_sock_addr) -BPF_PROG_TYPE(BPF_PROG_TYPE_LWT_IN, lwt_inout) -BPF_PROG_TYPE(BPF_PROG_TYPE_LWT_OUT, lwt_inout) +BPF_PROG_TYPE(BPF_PROG_TYPE_LWT_IN, lwt_in) +BPF_PROG_TYPE(BPF_PROG_TYPE_LWT_OUT, lwt_out) BPF_PROG_TYPE(BPF_PROG_TYPE_LWT_XMIT, lwt_xmit) BPF_PROG_TYPE(BPF_PROG_TYPE_SOCK_OPS, sock_ops)BPF_PROG_TYPE (BPF_PROG_TYPE_SK_SKB , sk_skb)
net/core/filter.c +52 -31
111 lines not on this page · raw message
Signature · 1 line
2.16.1
PATCH v4 5/6 ipv6: sr: Add seg6local action End.BPF
In reply to Mathieu XhonneuxThis patch adds the End.BPF action to the LWT seg6local infrastructure. This action works like any other seg6local End action, meaning that an IPv6 header with SRH is needed, whose DA has to be equal to the SID of the action. It will also advance the SRH to the next segment, the BPF program does not have to take care of this.
Since the BPF program may not be a source of instability in the kernel, it is important to ensure that the integrity of the packet is maintained before yielding it back to the IPv6 layer. The hook hence keeps track if the SRH has been altered through the helpers, and re-validates its content if needed with seg6_validate_srh. The state kept for validation is stored in a per-CPU buffer. The BPF program is not allowed to directly write into the packet, and only some fields of the SRH can be altered through the helper bpf_lwt_seg6_store_bytes.
Performances profiling has shown that the SRH re-validation does not induce a significant overhead. If the altered SRH is deemed as invalid, the packet is dropped.
This validation is also done before executing any action through bpf_lwt_seg6_action, and will not be performed again if the SRH is not modified after calling the action.
The BPF program may return 3 types of return codes:
- BPF_OK: the End.BPF action will look up the next destination through seg6_lookup_nexthop.
- BPF_REDIRECT: if an action has been executed through the bpf_lwt_seg6_action helper, the BPF program should return this value, as the skb's destination is already set and the default lookup should not be performed.
- BPF_DROP : the packet will be dropped.
This action requires CONFIG_IPV6=y (and not =m).
--- include/linux/bpf_types.h | 3 + include/uapi/linux/bpf.h | 1 + include/uapi/linux/seg6_local.h | 3 + kernel/bpf/verifier.c | 1 + net/core/filter.c | 25 +++++++ net/ipv6/seg6_local.c | 158 +++++++++++++++++++++++++++++++++++++++- 6 files changed, 188 insertions(+), 3 deletions(-)
include/linux/bpf_types.h +3 -0
@@ -12,6 +12,9 @@ BPF_PROG_TYPE(BPF_PROG_TYPE_CGROUP_SOCK_ADDR, cg_sock_addr) BPF_PROG_TYPE(BPF_PROG_TYPE_LWT_IN, lwt_in) BPF_PROG_TYPE(BPF_PROG_TYPE_LWT_OUT, lwt_out) BPF_PROG_TYPE(BPF_PROG_TYPE_LWT_XMIT, lwt_xmit) +#ifdef CONFIG_IPV6_SEG6_BPF +BPF_PROG_TYPE(BPF_PROG_TYPE_LWT_SEG6LOCAL, lwt_seg6local) +#endif BPF_PROG_TYPE(BPF_PROG_TYPE_SOCK_OPS, sock_ops) BPF_PROG_TYPE(BPF_PROG_TYPE_SK_SKB, sk_skb)BPF_PROG_TYPE (BPF_PROG_TYPE_SK_MSG , sk_msg)
include/uapi/linux/bpf.h +1 -0
@@ -140,6 +140,7 @@ enum bpf_prog_type {BPF_PROG_TYPE_SK_MSG ,BPF_PROG_TYPE_RAW_TRACEPOINT ,BPF_PROG_TYPE_CGROUP_SOCK_ADDR , + BPF_PROG_TYPE_LWT_SEG6LOCAL, }; enum bpf_attach_type {
include/uapi/linux/seg6_local.h +3 -0
@@ -25,6 +25,7 @@ enum {SEG6_LOCAL_NH6 ,SEG6_LOCAL_IIF ,SEG6_LOCAL_OIF , +SEG6_LOCAL_BPF , __SEG6_LOCAL_MAX, };#define SEG6_LOCAL_MAX (__SEG6_LOCAL_MAX - 1)
@@ -59,6 +60,8 @@ enum {SEG6_LOCAL_ACTION_END_AS =13 ,/* forward to SR-unaware VNF with masquerading */ SEG6_LOCAL_ACTION_END_AM =14 , +/* custom BPF action */ +SEG6_LOCAL_ACTION_END_BPF =15 , __SEG6_LOCAL_ACTION_MAX, };
kernel/bpf/verifier.c +1 -0
@@ -1262,6 +1262,7 @@ static bool may_access_direct_pkt_data(struct bpf_verifier_env *env,switch (env->prog->type) {case BPF_PROG_TYPE_LWT_IN :case BPF_PROG_TYPE_LWT_OUT : +case BPF_PROG_TYPE_LWT_SEG6LOCAL :/* dst_input() and dst_output() can't write for now */ if (t ==BPF_WRITE )return false;
net/core/filter.c +25 -0
@@ -4580,6 +4580,21 @@ lwt_xmit_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog) } } +static const struct bpf_func_proto * +lwt_seg6local_func_proto (enum bpf_func_id func_id,const struct bpf_prog *prog) +{ +switch (func_id) { +case BPF_FUNC_lwt_seg6_store_bytes: +return &bpf_lwt_seg6_store_bytes_proto; +case BPF_FUNC_lwt_seg6_action: +return &bpf_lwt_seg6_action_proto; +case BPF_FUNC_lwt_seg6_adjust_srh: +return &bpf_lwt_seg6_adjust_srh_proto; +default : +return lwt_out_func_proto (func_id, prog); + } +} +static bool bpf_skb_is_valid_access (int off,int size,enum bpf_access_type type,const struct bpf_prog *prog,struct bpf_insn_access_aux *info)
@@ -6180,6 +6195,16 @@ const struct bpf_prog_ops lwt_xmit_prog_ops = { .test_run = bpf_prog_test_run_skb, }; +const struct bpf_verifier_ops lwt_seg6local_verifier_ops = { + .get_func_proto = lwt_seg6local_func_proto, + .is_valid_access = lwt_is_valid_access, + .convert_ctx_access = bpf_convert_ctx_access, +}; + +const struct bpf_prog_ops lwt_seg6local_prog_ops = { + .test_run = bpf_prog_test_run_skb, +}; +const struct bpf_verifier_ops cg_sock_verifier_ops = { .get_func_proto = sock_filter_func_proto, .is_valid_access = sock_filter_is_valid_access,
net/ipv6/seg6_local.c +155 -3
225 lines not on this page · raw message
Signature · 1 line
2.16.1
kbuild test robot
build bot[RFC PATCH] ipv6: sr: lwt_seg6local_verifier_ops can be static
Fixes: e7d82c64d15a ("ipv6: sr: Add seg6local action End.BPF")
--- filter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
net/core/filter.c +2 -2
@@ -6195,13 +6195,13 @@ const struct bpf_prog_ops lwt_xmit_prog_ops = { .test_run = bpf_prog_test_run_skb, }; -const struct bpf_verifier_ops lwt_seg6local_verifier_ops = { +static const struct bpf_verifier_ops lwt_seg6local_verifier_ops = { .get_func_proto = lwt_seg6local_func_proto, .is_valid_access = lwt_is_valid_access, .convert_ctx_access = bpf_convert_ctx_access, }; -const struct bpf_prog_ops lwt_seg6local_prog_ops = { +static const struct bpf_prog_ops lwt_seg6local_prog_ops = { .test_run = bpf_prog_test_run_skb, };
kbuild test robot
build botRe: [PATCH bpf-next v4 5/6] ipv6: sr: Add seg6local action End.BPF
In reply to Mathieu XhonneuxThank you for the patch! Perhaps something to improve:
Hi Mathieu,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Mathieu-Xhonneux/ipv6-sr-introduce-seg6local-End-BPF-action/20180511-032546 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
net/core/filter.c:112:48: sparse: expression using sizeof(void) net/core/filter.c:112:48: sparse: expression using sizeof(void) net/core/filter.c:206:32: sparse: cast to restricted __be16 net/core/filter.c:206:32: sparse: cast to restricted __be16 net/core/filter.c:206:32: sparse: cast to restricted __be16 net/core/filter.c:206:32: sparse: cast to restricted __be16 net/core/filter.c:206:32: sparse: cast to restricted __be16 net/core/filter.c:206:32: sparse: cast to restricted __be16 net/core/filter.c:206:32: sparse: cast to restricted __be16 net/core/filter.c:206:32: sparse: cast to restricted __be16 net/core/filter.c:233:32: sparse: cast to restricted __be32 net/core/filter.c:233:32: sparse: cast to restricted __be32 net/core/filter.c:233:32: sparse: cast to restricted __be32 net/core/filter.c:233:32: sparse: cast to restricted __be32 net/core/filter.c:233:32: sparse: cast to restricted __be32 net/core/filter.c:233:32: sparse: cast to restricted __be32 net/core/filter.c:233:32: sparse: cast to restricted __be32 net/core/filter.c:233:32: sparse: cast to restricted __be32 net/core/filter.c:233:32: sparse: cast to restricted __be32 net/core/filter.c:233:32: sparse: cast to restricted __be32 net/core/filter.c:233:32: sparse: cast to restricted __be32 net/core/filter.c:233:32: sparse: cast to restricted __be32 net/core/filter.c:406:33: sparse: subtraction of functions? Share your drugs net/core/filter.c:409:33: sparse: subtraction of functions? Share your drugs net/core/filter.c:412:33: sparse: subtraction of functions? Share your drugs net/core/filter.c:415:33: sparse: subtraction of functions? Share your drugs net/core/filter.c:418:33: sparse: subtraction of functions? Share your drugs net/core/filter.c:481:27: sparse: subtraction of functions? Share your drugs net/core/filter.c:484:27: sparse: subtraction of functions? Share your drugs net/core/filter.c:487:27: sparse: subtraction of functions? Share your drugs include/linux/filter.h:615:16: sparse: expression using sizeof(void) include/linux/filter.h:615:16: sparse: expression using sizeof(void) include/linux/filter.h:615:16: sparse: expression using sizeof(void) include/linux/filter.h:615:16: sparse: expression using sizeof(void)
net/core/filter.c:1368:39: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct sock_filter const *filter @@ got struct sockstruct sock_filter const *filter @@
net/core/filter.c:1368:39: expected struct sock_filter const *filter
net/core/filter.c:1368:39: got struct sock_filter [noderef] <asn:1>*filter
include/linux/filter.h:615:16: sparse: expression using sizeof(void) include/linux/filter.h:615:16: sparse: expression using sizeof(void)
net/core/filter.c:1470:39: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct sock_filter const *filter @@ got struct sockstruct sock_filter const *filter @@
net/core/filter.c:1470:39: expected struct sock_filter const *filter
net/core/filter.c:1470:39: got struct sock_filter [noderef] <asn:1>*filter
include/linux/filter.h:615:16: sparse: expression using sizeof(void)
net/core/filter.c:1772:43: sparse: incorrect type in argument 2 (different base types) @@ expected restricted __wsum [usertype] diff @@ got unsigned lonrestricted __wsum [usertype] diff @@
net/core/filter.c:1772:43: expected restricted __wsum [usertype] diff
net/core/filter.c:1772:43: got unsigned long long [unsigned] [usertype] to
net/core/filter.c:1775:36: sparse: incorrect type in argument 2 (different base types) @@ expected restricted __be16 [usertype] old @@ got unsigned lonrestricted __be16 [usertype] old @@
net/core/filter.c:1775:36: expected restricted __be16 [usertype] old
net/core/filter.c:1775:36: got unsigned long long [unsigned] [usertype] from
net/core/filter.c:1775:42: sparse: incorrect type in argument 3 (different base types) @@ expected restricted __be16 [usertype] new @@ got unsigned lonrestricted __be16 [usertype] new @@
net/core/filter.c:1775:42: expected restricted __be16 [usertype] new
net/core/filter.c:1775:42: got unsigned long long [unsigned] [usertype] to
net/core/filter.c:1778:36: sparse: incorrect type in argument 2 (different base types) @@ expected restricted __be32 [usertype] from @@ got unsigned lonrestricted __be32 [usertype] from @@
net/core/filter.c:1778:36: expected restricted __be32 [usertype] from
net/core/filter.c:1778:36: got unsigned long long [unsigned] [usertype] from
net/core/filter.c:1778:42: sparse: incorrect type in argument 3 (different base types) @@ expected restricted __be32 [usertype] to @@ got unsigned lonrestricted __be32 [usertype] to @@
net/core/filter.c:1778:42: expected restricted __be32 [usertype] to
net/core/filter.c:1778:42: got unsigned long long [unsigned] [usertype] to
net/core/filter.c:1823:59: sparse: incorrect type in argument 3 (different base types) @@ expected restricted __wsum [usertype] diff @@ got unsigned lonrestricted __wsum [usertype] diff @@
net/core/filter.c:1823:59: expected restricted __wsum [usertype] diff
net/core/filter.c:1823:59: got unsigned long long [unsigned] [usertype] to
net/core/filter.c:1826:52: sparse: incorrect type in argument 3 (different base types) @@ expected restricted __be16 [usertype] from @@ got unsigned lonrestricted __be16 [usertype] from @@
net/core/filter.c:1826:52: expected restricted __be16 [usertype] from
net/core/filter.c:1826:52: got unsigned long long [unsigned] [usertype] from
net/core/filter.c:1826:58: sparse: incorrect type in argument 4 (different base types) @@ expected restricted __be16 [usertype] to @@ got unsigned lonrestricted __be16 [usertype] to @@
net/core/filter.c:1826:58: expected restricted __be16 [usertype] to
net/core/filter.c:1826:58: got unsigned long long [unsigned] [usertype] to
net/core/filter.c:1829:52: sparse: incorrect type in argument 3 (different base types) @@ expected restricted __be32 [usertype] from @@ got unsigned lonrestricted __be32 [usertype] from @@
net/core/filter.c:1829:52: expected restricted __be32 [usertype] from
net/core/filter.c:1829:52: got unsigned long long [unsigned] [usertype] from
net/core/filter.c:1829:58: sparse: incorrect type in argument 4 (different base types) @@ expected restricted __be32 [usertype] to @@ got unsigned lonrestricted __be32 [usertype] to @@
net/core/filter.c:1829:58: expected restricted __be32 [usertype] to
net/core/filter.c:1829:58: got unsigned long long [unsigned] [usertype] to
net/core/filter.c:1875:28: sparse: incorrect type in return expression (different base types) @@ expected unsigned long long @@ got nsigned long long @@
net/core/filter.c:1875:28: expected unsigned long long
net/core/filter.c:1875:28: got restricted __wsum
net/core/filter.c:1897:35: sparse: incorrect type in return expression (different base types) @@ expected unsigned long long @@ got restricted unsigned long long @@
net/core/filter.c:1897:35: expected unsigned long long
net/core/filter.c:1897:35: got restricted __wsum [usertype] csum
net/core/filter.c:3708:41: sparse: expression using sizeof(void) net/core/filter.c:3712:41: sparse: expression using sizeof(void) net/core/filter.c:3716:46: sparse: expression using sizeof(void) net/core/filter.c:3716:46: sparse: expression using sizeof(void) net/core/filter.c:3784:47: sparse: expression using sizeof(void)
net/core/filter.c:3990:17: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [unsigned] [usertype] spi @@ got unsigned int [unsigned] [usertype] spi @@
net/core/filter.c:3990:17: expected unsigned int [unsigned] [usertype] spi
net/core/filter.c:3990:17: got restricted __be32 const [usertype] spi
net/core/filter.c:3996:33: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [unsigned] [usertype] remote_ipv4 @@ got unsigned int [unsigned] [usertype] remote_ipv4 @@
net/core/filter.c:3996:33: expected unsigned int [unsigned] [usertype] remote_ipv4
net/core/filter.c:3996:33: got restricted __be32 const [usertype] a4
net/core/filter.c:4835:27: sparse: subtraction of functions? Share your drugs net/core/filter.c:4838:27: sparse: subtraction of functions? Share your drugs net/core/filter.c:4841:27: sparse: subtraction of functions? Share your drugs
>> net/core/filter.c:6198:31: sparse: symbol 'lwt_seg6local_verifier_ops' was not declared. Should it be static? >> net/core/filter.c:6204:27: sparse: symbol 'lwt_seg6local_prog_ops' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
PATCH v4 6/6 selftests/bpf: test for seg6local End.BPF action
In reply to Mathieu XhonneuxAdd a new test for the seg6local End.BPF action. The following helpers are also tested :
- bpf_lwt_push_encap within the LWT BPF IN hook
- bpf_lwt_seg6_action
- bpf_lwt_seg6_adjust_srh
- bpf_lwt_seg6_store_bytes
A chain of End.BPF actions is built. The SRH is injected through a LWT BPF IN hook before the chain. Each End.BPF action validates the previous one, otherwise the packet is dropped.
The test succeeds if the last node in the chain receives the packet and the UDP datagram contained can be retrieved from userspace.
--- tools/include/uapi/linux/bpf.h | 97 ++++- tools/testing/selftests/bpf/Makefile | 5 +- tools/testing/selftests/bpf/bpf_helpers.h | 12 + tools/testing/selftests/bpf/test_lwt_seg6local.c | 438 ++++++++++++++++++++++ tools/testing/selftests/bpf/test_lwt_seg6local.sh | 140 +++++++ 5 files changed, 689 insertions(+), 3 deletions(-) create mode 100644 tools/testing/selftests/bpf/test_lwt_seg6local.c create mode 100755 tools/testing/selftests/bpf/test_lwt_seg6local.sh
tools/include/uapi/linux/bpf.h +96 -1
@@ -117,6 +117,7 @@ enum bpf_map_type {BPF_MAP_TYPE_DEVMAP ,BPF_MAP_TYPE_SOCKMAP ,BPF_MAP_TYPE_CPUMAP , + BPF_MAP_TYPE_XSKMAP, }; enum bpf_prog_type {
@@ -139,6 +140,7 @@ enum bpf_prog_type {BPF_PROG_TYPE_SK_MSG ,BPF_PROG_TYPE_RAW_TRACEPOINT ,BPF_PROG_TYPE_CGROUP_SOCK_ADDR , + BPF_PROG_TYPE_LWT_SEG6LOCAL, }; enum bpf_attach_type {
@@ -1827,6 +1829,89 @@ union bpf_attr {* Return * 0 on success, or a negative error in case of failure. * +* int bpf_lwt_push_encap(struct sk_buff *skb, u32 type, void *hdr, u32 len) +* Description +* Encapsulate the packet associated to *skb* within a Layer 3 +* protocol header. This header is provided in the buffer at +* address *hdr*, with *len* its size in bytes. *type* indicates +* the protocol of the header and can be one of: +* +* **BPF_LWT_ENCAP_SEG6** +* IPv6 encapsulation with Segment Routing Header +* (**struct ipv6_sr_hdr**). *hdr* only contains the SRH, +* the IPv6 header is computed by the kernel. +* **BPF_LWT_ENCAP_SEG6_INLINE** +* Only works if *skb* contains an IPv6 packet. Insert a +* Segment Routing Header (**struct ipv6_sr_hdr**) inside +* the IPv6 header. +* +* A call to this helper is susceptible to change the underlaying +* packet buffer. Therefore, at load time, all checks on pointers +* previously done by the verifier are invalidated and must be +* performed again, if the helper is used in combination with +* direct packet access. +* Return +* 0 on success, or a negative error in case of failure. +* +* int bpf_lwt_seg6_store_bytes(struct sk_buff *skb, u32 offset, const void *from, u32 len) +* Description +* Store *len* bytes from address *from* into the packet +* associated to *skb*, at *offset*. Only the flags, tag and TLVs +* inside the outermost IPv6 Segment Routing Header can be +* modified through this helper. +* +* A call to this helper is susceptible to change the underlaying +* packet buffer. Therefore, at load time, all checks on pointers +* previously done by the verifier are invalidated and must be +* performed again, if the helper is used in combination with +* direct packet access. +* Return +* 0 on success, or a negative error in case of failure. +* +* int bpf_lwt_seg6_adjust_srh(struct sk_buff *skb, u32 offset, s32 delta) +* Description +* Adjust the size allocated to TLVs in the outermost IPv6 +* Segment Routing Header contained in the packet associated to +* *skb*, at position *offset* by *delta* bytes. Only offsets +* after the segments are accepted. *delta* can be as well +* positive (growing) as negative (shrinking). +* +* A call to this helper is susceptible to change the underlaying +* packet buffer. Therefore, at load time, all checks on pointers +* previously done by the verifier are invalidated and must be +* performed again, if the helper is used in combination with +* direct packet access. +* Return +* 0 on success, or a negative error in case of failure. +* +* int bpf_lwt_seg6_action(struct sk_buff *skb, u32 action, void *param, u32 param_len) +* Description +* Apply an IPv6 Segment Routing action of type *action* to the +* packet associated to *skb*. Each action takes a parameter +* contained at address *param*, and of length *param_len* bytes. +* *action* can be one of: +* +* **SEG6_LOCAL_ACTION_END_X** +* End.X action: Endpoint with Layer-3 cross-connect. +* Type of *param*: **struct in6_addr**. +* **SEG6_LOCAL_ACTION_END_T** +* End.T action: Endpoint with specific IPv6 table lookup. +* Type of *param*: **int**. +* **SEG6_LOCAL_ACTION_END_B6** +* End.B6 action: Endpoint bound to an SRv6 policy. +* Type of param: **struct ipv6_sr_hdr**. +* **SEG6_LOCAL_ACTION_END_B6_ENCAP** +* End.B6.Encap action: Endpoint bound to an SRv6 +* encapsulation policy. +* Type of param: **struct ipv6_sr_hdr**. +* +* A call to this helper is susceptible to change the underlaying +* packet buffer. Therefore, at load time, all checks on pointers +* previously done by the verifier are invalidated and must be +* performed again, if the helper is used in combination with +* direct packet access. +* Return +* 0 on success, or a negative error in case of failure. */ #define __BPF_FUNC_MAPPER (FN ) \ FN(unspec), \
@@ -1897,7 +1982,11 @@ union bpf_attr {FN (xdp_adjust_tail), \FN (skb_get_xfrm_state), \FN (get_stack), \ -FN (skb_load_bytes_relative), +FN (skb_load_bytes_relative), \ +FN (lwt_push_encap), \ +FN (lwt_seg6_store_bytes), \ +FN (lwt_seg6_adjust_srh), \ +FN (lwt_seg6_action),/* integer value in 'imm' field of BPF_CALL instruction selects which helper * function eBPF program intends to call
@@ -1964,6 +2053,12 @@ enum bpf_hdr_start_off { BPF_HDR_START_NET, }; +/* Encapsulation type for BPF_FUNC_lwt_push_encap helper. */ +enum bpf_lwt_encap_mode { +BPF_LWT_ENCAP_SEG6 , +BPF_LWT_ENCAP_SEG6_INLINE +}; +/* user accessible mirror of in-kernel sk_buff. * new fields can only be added to the end of this structure */
tools/testing/selftests/bpf/Makefile +3 -2
@@ -33,7 +33,7 @@ TEST_GEN_FILES = test_pkt_access.o test_xdp.o test_l4lb.o test_tcp_estats.o test sample_map_ret0.o test_tcpbpf_kern.o test_stacktrace_build_id.o \ sockmap_tcp_msg_prog.o connect4_prog.o connect6_prog.o test_adjust_tail.o \ test_btf_haskv.o test_btf_nokv.o test_sockmap_kern.o test_tunnel_kern.o \ - test_get_stack_rawtp.o + test_get_stack_rawtp.o test_lwt_seg6local.o # Order correspond to 'make run_tests' order TEST_PROGS := test_kmod.sh \
@@ -42,7 +42,8 @@ TEST_PROGS := test_kmod.sh \ test_xdp_meta.sh \ test_offload.py \ test_sock_addr.sh \ - test_tunnel.sh + test_tunnel.sh \ + test_lwt_seg6local.sh # Compile but not part of 'make run_tests' TEST_GEN_PROGS_EXTENDED = test_libbpf_open test_sock_addr
tools/testing/selftests/bpf/bpf_helpers.h +12 -0
@@ -103,6 +103,18 @@ static int (*bpf_skb_get_xfrm_state)(void *ctx, int index, void *state, (void *) BPF_FUNC_skb_get_xfrm_state;static int (*bpf_get_stack)(void *ctx,void *buf,int size,int flags) = (void *) BPF_FUNC_get_stack; +static int (*bpf_lwt_push_encap)(void *ctx,unsigned int type,void *hdr, +unsigned int len) = + (void *) BPF_FUNC_lwt_push_encap; +static int (*bpf_lwt_seg6_store_bytes)(void *ctx,unsigned int offset, +void *from,unsigned int len) = + (void *) BPF_FUNC_lwt_seg6_store_bytes; +static int (*bpf_lwt_seg6_action)(void *ctx,unsigned int action,void *param, +unsigned int param_len) = + (void *) BPF_FUNC_lwt_seg6_action; +static int (*bpf_lwt_seg6_adjust_srh)(void *ctx,unsigned int offset, +unsigned int len) = + (void *) BPF_FUNC_lwt_seg6_adjust_srh;/* llvm builtin functions that eBPF C program may use to * emit BPF_LD_ABS and BPF_LD_IND instructions
tools/testing/selftests/bpf/test_lwt_seg6local.c new file +438 -0
438 lines not on this page · raw message
tools/testing/selftests/bpf/test_lwt_seg6local.sh new file +140 -0
140 lines not on this page · raw message
Signature · 1 line
2.16.1
@Alexei: I created the CONFIG_IPV6_SEG6_BPF symbol, fearing that using ipv6_bpf_stub would be detrimental for the bpf_lwt_seg6_action helper, since all the calls to seg6_* are in the critical path.
2018-05-09 22:16 GMT+01:00 Mathieu Xhonneux <[email protected]>:
Quoted 86 lines
As of Linux 4.14, it is possible to define advanced local processing for IPv6 packets with a Segment Routing Header through the seg6local LWT infrastructure. This LWT implements the network programming principles defined in the IETF “SRv6 Network Programming” draft.
The implemented operations are generic, and it would be very interesting to be able to implement user-specific seg6local actions, without having to modify the kernel directly. To do so, this patchset adds an End.BPF action to seg6local, powered by some specific Segment Routing-related helpers, which provide SR functionalities that can be applied on the packet. This BPF hook would then allow to implement specific actions at native kernel speed such as OAM features, advanced SR SDN policies, SRv6 actions like Segment Routing Header (SRH) encapsulation depending on the content of the packet, etc.
This patchset is divided in 6 patches, whose main features are :
- A new seg6local action End.BPF with the corresponding new BPF program type
BPF_PROG_TYPE_LWT_SEG6LOCAL. Such attached BPF program can be passed to the LWT seg6local through netlink, the same way as the LWT BPF hook operates.
- 3 new BPF helpers for the seg6local BPF hook, allowing to edit/grow/ shrink a SRH and apply on a packet some of the generic SRv6 actions.
- 1 new BPF helper for the LWT BPF IN hook, allowing to add a SRH through encapsulation (via IPv6 encapsulation or inlining if the packet contains already an IPv6 header).As this patchset adds a new LWT BPF hook, I took into account the result of the discussions when the LWT BPF infrastructure got merged. Hence, the seg6local BPF hook doesn’t allow write access to
skb->datadirectly, only the SRH can be modified through specific helpers, which ensures that the integrity of the packet is maintained.
More details are available in the related patches messages.The performances of this BPF hook have been assessed with the BPF JIT enabled on a Intel Xeon X3440 processors with 4 cores and 8 threads clocked at 2.53 GHz. No throughput losses are noted with the seg6local BPF hook when the BPF program does nothing (440kpps). Adding a 8-bytes TLV (1 call each to
bpf_lwt_seg6_adjust_srhandbpf_lwt_seg6_store_bytes) drops the throughput to 410kpps, and inlining a SRH viabpf_lwt_seg6_actiondrops the throughput to 420kpps.
All throughputs are stable.-------
v2: move the SRH integrity state fromskb->cbto a per-cpu buffer
v3: - document helpers in man-page style
- fix kbuild bugs
- un-break BPF LWT out hook
-bpf_push_seg6_encapis now static
-preempt_enableis now called when the packet is dropped ininput_action_end_bpf
v4: fix kbuild bugs whenCONFIG_IPV6=mThanks.
Mathieu Xhonneux (6):
ipv6: sr: makeseg6.hincludable without IPv6
ipv6: sr: export functionlookup_nexthop
bpf: Add IPv6 Segment Routing helpers
bpf: Split lwt inout verifier structures
ipv6: sr: Add seg6local action End.BPF selftests/bpf: test for seg6local End.BPF actioninclude/linux/bpf_types.h | 7 +- include/net/seg6.h | 7 +- include/net/seg6_local.h | 32 ++ include/uapi/linux/bpf.h | 96 ++++- include/uapi/linux/seg6_local.h | 3 + kernel/bpf/verifier.c | 1 + net/core/filter.c | 390 ++++++++++++++++--- net/ipv6/Kconfig | 5 + net/ipv6/seg6_local.c | 180 ++++++++- tools/include/uapi/linux/bpf.h | 97 ++++- tools/testing/selftests/bpf/Makefile | 5 +- tools/testing/selftests/bpf/bpf_helpers.h | 12 + tools/testing/selftests/bpf/test_lwt_seg6local.c | 438 ++++++++++++++++++++++ tools/testing/selftests/bpf/test_lwt_seg6local.sh | 140 +++++++ 14 files changed, 1340 insertions(+), 73 deletions(-) create mode 100644 include/net/seg6_local.h create mode 100644 tools/testing/selftests/bpf/test_lwt_seg6local.c create mode 100755 tools/testing/selftests/bpf/test_lwt_seg6local.sh--
2.16.1