Skip to contentSkip to conversation

diffstat: fix wrong evaluation of CC

PATCH New [email protected] 1 participant 2 messages May 15, 2018

lore
Share & tools
lore
#0 lore raw

cover diffstat: fix wrong evaluation of CC

From: Kai Kang <[email protected]>

The following changes since commit 5479654eeaaa0f81bfff54ca49369c87f1658705:

rm_work: Stop appending _setscene to do_image_complete_setscene stamps (2018-05-11 07:49:38 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib kangkai/diffstat
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=kangkai/diffstat

Kai Kang (1):
diffstat: fix wrong evaluation of CC

 .../diffstat/avoid-check-user-break-cc.patch       | 26 ++++++++++++++++++++++
 meta/recipes-devtools/diffstat/diffstat_1.61.bb    |  1 +
 2 files changed, 27 insertions(+)
 create mode 100644 meta/recipes-devtools/diffstat/diffstat/avoid-check-user-break-cc.patch
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 diffstat: fix wrong evaluation of CC

From: Kai Kang <[email protected]>

diffstat checks variable CC. If options '-I', '-U' or '-D' is included in CC, variable CC will be wrongly filtered and only such as 'mips64-wrsmllibn32-linux-gnun32-gcc' left. It shows warning message during configure:

| checking $CC variable...broken
| configure: WARNING: your environment misuses the CC variable to hold CFLAGS/CPPFLAGS options

Disable such check for OE.

---
 .../diffstat/avoid-check-user-break-cc.patch       | 26 ++++++++++++++++++++++
 meta/recipes-devtools/diffstat/diffstat_1.61.bb    |  1 +
 2 files changed, 27 insertions(+)
 create mode 100644 meta/recipes-devtools/diffstat/diffstat/avoid-check-user-break-cc.patch
meta/recipes-devtools/diffstat/diffstat/avoid-check-user-break-cc.patch new file +26 -0
new file mode 100644
index 00000000000..2df2d001855
@@ -0,0 +1,26 @@
+Upstream-Status: Inappropriate [oe specific]
+
+m4 function CF_CC_ENV_FLAGS checks whether variable CC contains options '-I', '-U'
+and '-D'. It is not suitable for oe that option such as '-D_FORTIFY_SOURCE=2' may
+be included in CC. And then CC will be wrongly filtered.
+
+So comment out CF_CC_ENV_FLAGS from function CF_PROG_CC.
+
+Signed-off-by: Kai Kang <[email protected]>
+---
+ aclocal.m4 | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/aclocal.m4 b/aclocal.m4
+index 420fe83..eb73ea9 100644
+--- a/aclocal.m4
++++ b/aclocal.m4
+@@ -1114,7 +1114,7 @@ CF_GCC_VERSION
+ CF_ACVERSION_CHECK(2.52,
+ 	[AC_PROG_CC_STDC],
+ 	[CF_ANSI_CC_REQD])
+-CF_CC_ENV_FLAGS
++dnl CF_CC_ENV_FLAGS
+ ])dnl
+ dnl ---------------------------------------------------------------------------
+ dnl CF_PROG_GROFF version: 2 updated: 2015/07/04 11:16:27
meta/recipes-devtools/diffstat/diffstat_1.61.bb +1 -0
index f8b7b06cf24..1a76e78c15c 100644
@@ -9,6 +9,7 @@ LIC_FILES_CHKSUM = "file://install-sh;endline=42;md5=b3549726c1022bee09c174c72a0
 
 SRC_URI = "http://invisible-mirror.net/archives/${BPN}/${BP}.tgz \
            file://run-ptest \
+           file://avoid-check-user-break-cc.patch \
 "
 
 SRC_URI[md5sum] = "c048a32d55d8bd6724f382baf41f325f"
Signature · 1 line
2.14.1