oeqa/runtime/cases/selftest.py: rename to _selftest.py
v3 cover oeqa/runtime/cases/selftest.py: rename to _selftest.py
Changes in V3:
* Also rename selftest.json to _selftest.json to avoid runtime_test.py failure in oe-selftest.
* Fixed a typo (sato -> full-cmdline)
Changes in V2:
* Fix to depend on _selftest.Selftest.test_install_package.
The following changes since commit fe6e6231441188c3ffe52ef5811a8f30d29ea952:
local.conf.sample: update libsdl mentions to libsdl2 (2018-06-07 08:53:19 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib ChenQi/rename_selftest
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/rename_selftest
Chen Qi (1):
oeqa/runtime/cases/selftest.py: rename to _selftest.py
.../lib/oeqa/runtime/cases/{selftest.json => _selftest.json} | 0
meta-selftest/lib/oeqa/runtime/cases/{selftest.py => _selftest.py} | 2 +-
meta/lib/oeqa/selftest/cases/runtime_test.py | 4 ++--
3 files changed, 3 insertions(+), 3 deletions(-)
rename meta-selftest/lib/oeqa/runtime/cases/{selftest.json => _selftest.json} (100%)
rename meta-selftest/lib/oeqa/runtime/cases/{selftest.py => _selftest.py} (94%)Signature · 1 line
1.9.1
PATCH v3 1/1 oeqa/runtime/cases/selftest.py: rename to _selftest.py
This test modules is designed to be invoked only by selftest. It's not meant to be tested by normal runtime test. So it should be renamed with '_' prefix, so that it will not be automatically loaded by normal runtime tests when 'auto' is in TEST_SUITES.
The failure message is as below.
RESULTS - selftest.Selftest.test_install_package - Testcase -1: FAILED
Change selftest/cases/runtime_test.py to use '_selftest' accordingly. Rename selftest.json to _selftest.json accordingly.
Also, fix a typo in runtime_test.py.
---
.../lib/oeqa/runtime/cases/{selftest.json => _selftest.json} | 0
meta-selftest/lib/oeqa/runtime/cases/{selftest.py => _selftest.py} | 2 +-
meta/lib/oeqa/selftest/cases/runtime_test.py | 4 ++--
3 files changed, 3 insertions(+), 3 deletions(-)
rename meta-selftest/lib/oeqa/runtime/cases/{selftest.json => _selftest.json} (100%)
rename meta-selftest/lib/oeqa/runtime/cases/{selftest.py => _selftest.py} (94%)meta-selftest/lib/oeqa/runtime/cases/_selftest.json renamed from meta-selftest/lib/oeqa/runtime/cases/selftest.json +0 -0
meta-selftest/lib/oeqa/runtime/cases/_selftest.py renamed from meta-selftest/lib/oeqa/runtime/cases/selftest.py +1 -1
@@ -17,7 +17,7 @@ class Selftest(OERuntimeTestCase): (status, output) = self.target.run("socat -V") self.assertEqual(status, 0, msg="socat is not installed") - @OETestDepends(['selftest.Selftest.test_install_package']) + @OETestDepends(['_selftest.Selftest.test_install_package']) def test_verify_uninstall(self): """ Summary: Check basic package installation functionality.
meta/lib/oeqa/selftest/cases/runtime_test.py +2 -2
@@ -122,10 +122,10 @@ class TestImage(OESelftestTestCase): self.skipTest('core-image-full-cmdline not buildable for poky-tiny') features = 'INHERIT += "testimage"\n' - features += 'TEST_SUITES = "ping ssh selftest"\n' + features += 'TEST_SUITES = "ping ssh _selftest"\n' self.write_config(features) - # Build core-image-sato and testimage + # Build core-image-full-cmdline and testimage bitbake('core-image-full-cmdline socat') bitbake('-c testimage core-image-full-cmdline')
Signature · 1 line
1.9.1
ping
I've tested this patch with `oe-selftest -r runtime_test', and the result is correct.
Best Regards,
Chen Qi
Quoted 27 lines · Chen Qi
Changes in V3:
* Also rename selftest.json to _selftest.json to avoidruntime_test.pyfailure in oe-selftest.
* Fixed a typo (sato -> full-cmdline)Changes in V2:
* Fix to depend on _selftest.Selftest.test_install_package.The following changes since commit
fe6e6231441188c3ffe52ef5811a8f30d29ea952:local.conf.sample: update libsdl mentions to libsdl2 (2018-06-07 08:53:19 +0100)are available in the git repository at:
git://git.pokylinux.org/poky-contribChenQi/rename_selftest
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/rename_selftestChen Qi (1):
oeqa/runtime/cases/selftest.py: rename to_selftest.py.../lib/oeqa/runtime/cases/{selftest.json => _selftest.json} | 0 meta-selftest/lib/oeqa/runtime/cases/{selftest.py => _selftest.py} | 2 +- meta/lib/oeqa/selftest/cases/runtime_test.py | 4 ++-- 3 files changed, 3 insertions(+), 3 deletions(-)rename
meta-selftest/lib/oeqa/runtime/cases/{selftest.json=> _selftest.json} (100%) renamemeta-selftest/lib/oeqa/runtime/cases/{selftest.py=>_selftest.py} (94%)