Skip to contentSkip to conversation

da7280: haptic driver submission

PATCH Superseded Roy Im 3 participants 8 messages Aug 21, 2018 – Aug 27, 2018

Subsystems (4)
Device tree bindings HID Input drivers Dialog semiconductor drivers

v4 of 7 Superseded Latest is v7 →

lore
Share & tools
lore

Roy Im

author
#0 lore raw

v4 cover da7280: haptic driver submission

From: Roy Im <[email protected]>

This patch adds support for the Dialog DA7280 Haptic driver IC.

In this patch set the following is provided:

[PATCH V2 1/3] MAINTAINERS file update for DA7280
[PATCH V2 2/3] DA7280 DT Binding
[PATCH V2 3/3] DA7280 Driver

This patch applies against linux-next and v4.18

Thank you,
Roy Im, Dialog Semiconductor Ltd.

Roy Im (3):
MAINTAINERS: da7280 updates to the Dialog Semiconductor search terms
dt-bindings: input: Add document bindings for DA7280
Input: new da7280 haptic driver

 .../devicetree/bindings/input/dlg,da7280.txt       |  101 ++
 MAINTAINERS                                        |    2 +
 drivers/input/misc/Kconfig                         |   12 +
 drivers/input/misc/Makefile                        |    1 +
 drivers/input/misc/da7280.c                        | 1438 ++++++++++++++++++++
 drivers/input/misc/da7280.h                        |  412 ++++++
 6 files changed, 1966 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/dlg,da7280.txt
 create mode 100644 drivers/input/misc/da7280.c
 create mode 100644 drivers/input/misc/da7280.h
Signature · 1 line
end-of-patch for PATCH V4
author
#1 lore raw

PATCH v4 1/3 MAINTAINERS: da7280 updates to the Dialog Semiconductor search terms

This patch adds the da7280 bindings doc and driver to the Dialog Semiconductor support list.

Signed-off-by Roy Im <[email protected]>

---
v4: No changes.
v3: No changes.
v2: No changes.

 MAINTAINERS |    2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
index 544cac8..720f9fe 100644
@@ -4221,6 +4221,7 @@ S:	Supported
 F:	Documentation/hwmon/da90??
 F:	Documentation/devicetree/bindings/mfd/da90*.txt
 F:	Documentation/devicetree/bindings/input/da90??-onkey.txt
+F:	Documentation/devicetree/bindings/input/dlg,da72??.txt
 F:	Documentation/devicetree/bindings/thermal/da90??-thermal.txt
 F:	Documentation/devicetree/bindings/regulator/da92*.txt
 F:	Documentation/devicetree/bindings/watchdog/da90??-wdt.txt

@@ -4229,6 +4230,7 @@ F:	drivers/gpio/gpio-da90??.c
 F:	drivers/hwmon/da90??-hwmon.c
 F:	drivers/iio/adc/da91??-*.c
 F:	drivers/input/misc/da90??_onkey.c
+F:	drivers/input/misc/da72??.[ch]
 F:	drivers/input/touchscreen/da9052_tsi.c
 F:	drivers/leds/leds-da90??.c
 F:	drivers/mfd/da903x.c
Signature · 1 line
end-of-patch for PATCH V4
author
#2 lore raw

PATCH v4 2/3 dt-bindings: input: Add document bindings for DA7280

In reply to Roy Im

Add device tree binding information for DA7280 haptic driver. Example bindings for DA7280 are added.

Signed-off-by Roy Im <[email protected]>

---
v4: Fixed commit message, properties.

v3: Fixed subject format.

v2: No changes

 .../devicetree/bindings/input/dlg,da7280.txt       |  101 ++++++++++++++++++++
 1 file changed, 101 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/dlg,da7280.txt
Documentation/devicetree/bindings/input/dlg,da7280.txt new file +101 -0
new file mode 100644
index 0000000..a61e9f0
@@ -0,0 +1,101 @@
+Dialog Semiconductor DA7280 Haptics bindings
+
+Required properties:
+- compatible: Should be "dlg,da7280".
+- reg: Specifies the I2C slave address.
+
+- interrupt-parent : Specifies the phandle of the interrupt controller to
+  which the IRQs from DA7280 are delivered to.
+
+- dlg,vib-mode:
+  "LRA-MODE" - Linear Resonance Actuator mode.
+  "ERM-BAR" - Bar type Eccentric Rotating Mass mode.
+  "ERM-COIN" - Coin type Eccentric Rotating Mass mode.
+
+- dlg,op-mode: Haptic operation mode.
+  Possible values:
+	1 - Direct register override mode triggered by i2c(default),
+	2 - PWM data source mode setting duty to 0 - 0xffff(0% - 100%),
+	3 - Register triggered waveform memory mode, the pattern assigned
+	    to the PS_SEQ_ID played as much times as PS_SEQ_LOOP,
+	4 - Edge triggered waveform memory mode, external GPI(N) condtrol
+	    are required to enable/disable and it needs to keep
+	    device enabled by sending magnitude (X > 0),
+	    the pattern is assigned to the GPI(N)_SEQUENCE_ID below
+	    For more details, please see the datasheet.
+
+- dlg,nom-microvolt: Nominal actuator voltage rating.
+  Valid values: 0 - 6000000.
+- dlg,abs-max-microvolt: Absolute actuator maximum voltage rating.
+  Valid values: 0 - 6000000.
+- dlg,imax-microamp: Actuator max current rating.
+  Valid values: 0 - 252000.
+  Default: 130000.
+- dlg,impd-micro-ohms: the impedance of the actuator in micro ohm,
+  as read from its datasheet.
+  Valid values: 0 - 1500000000.
+
+Optional properties:
+- pwms : phandle to the physical PWM(Pulse Width Modulation) device.
+  PWM properties should be named "pwms". And number of cell is different
+  for each pwm device.
+  (See Documentation/devicetree/bindings/pwm/pwm.txt
+   for further information relating to pwm properties)
+
+- dlg,ps-seq-id: the PS_SEQ_ID(pattern ID in waveform memory inside chip)
+  to play back when RTWM-MODE is enabled.
+  Valid range: 0 - 15.
+- dlg,ps-seq-loop: the PS_SEQ_LOOP, Number of times the pre-stored sequence
+  pointed to by PS_SEQ_ID or GPI(N)_SEQUENCE_ID is repeated.
+  Valid range: 0 - 15.
+- dlg,gpiN-seq-id: the GPI(N)_SEQUENCE_ID, pattern to play
+  when gpi0 is triggered, 'N' must be 0 - 2.
+  Valid range: 0 - 15.
+- dlg,gpiN-mode: the pattern mode which can select either
+  "Single-pattern" or "Multi-pattern", 'N' must be 0 - 2.
+- dlg,gpiN-polarity: gpiN polarity which can be chosen among
+  "Rising-edge", "Falling-edge" and "Both-edge",
+  'N' must be 0 - 2
+  Haptic will work by this edge option in case of ETWM-MODE.
+
+- dlg,resonant-freq-hz: use in case of LRA-MODE.
+  the frequency range: 50 - 300.
+  Default: 205.
+
+- dlg,bemf-sens-enable: Enable for internal loop computations.
+- dlg,freq-track-enable: Enable for resonant frequency tracking.
+- dlg,acc-enable: Enable for active acceleration.
+- dlg,rapid-stop-enable: Enable for rapid stop.
+- dlg,amp-pid-enable: Enable for the amplitude PID.
+- dlg,mem-array: use in case that memory registers should be updated,
+  Please fill the whole buffers(100 bytes) to avoid any error in driver.
+  For example,
+	dlg,mem-array = <
+		0x01 0x02 0x03 0x04 0x05 0x06 0x07 0x08 0x09 0x0A
+		...
+		0x71 0x72 0x73 0x74 0x75 0x76 0x77 0x78 0x79 0x7A
+		0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
+		0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
+	>;
+
+For further information, see device datasheet.
+
+======
+
+Example:
+
+	haptics: da7280-haptics@4a {
+		compatible = "dlg,da7280";
+		reg = <0x4a>;
+		interrupt-parent = <&gpio6>;
+		interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
+		dlg,vib-mode = "LRA-MODE";
+		dlg,op-mode = <1>;
+		dlg,nom-microvolt = <2000000>;
+		dlg,abs-max-microvolt = <2000000>;
+		dlg,imax-microamp = <170000>;
+		dlg,resonant-freq-hz = <180>;
+		dlg,impd-micro-ohms = <10500000>;
+		dlg,freq-track-enable;
+		dlg,rapid-stop-enable;
+	};
Signature · 1 line
end-of-patch for PATCH V4
#3 lore raw

Re: [PATCH V4 2/3] dt-bindings: input: Add document bindings for DA7280

Hi!

Quoted 5 lines

+++ b/Documentation/devicetree/bindings/input/dlg,da7280.txt

Documentation/devicetree/bindings/input/dlg,da7280.txt new file +3 -0
@@ -0,0 +1,101 @@
+Dialog Semiconductor DA7280 Haptics bindings
+
+Required properties:

Documentation/devicetree/bindings/input/dlg,da7280.txt line 13

Quoted 10 lines
Documentation/devicetree/bindings/input/dlg,da7280.txt new file +10 -0
+- compatible: Should be "dlg,da7280".
+- reg: Specifies the I2C slave address.
+
+- interrupt-parent : Specifies the phandle of the interrupt controller to
+  which the IRQs from DA7280 are delivered to.
+
+- dlg,vib-mode:
+  "LRA-MODE" - Linear Resonance Actuator mode.
+  "ERM-BAR" - Bar type Eccentric Rotating Mass mode.
+  "ERM-COIN" - Coin type Eccentric Rotating Mass mode.

So this is some kind of "vibration motor" on steroids)?

Documentation/devicetree/bindings/input/dlg,da7280.txt line 18

Quoted 4 lines
Documentation/devicetree/bindings/input/dlg,da7280.txt new file +4 -0
+- dlg,op-mode: Haptic operation mode.
+  Possible values:
+	1 - Direct register override mode triggered by i2c(default),
+	2 - PWM data source mode setting duty to 0 - 0xffff(0% - 100%),

Space after 0xffff?

Documentation/devicetree/bindings/input/dlg,da7280.txt line 21

Quoted 3 lines
Documentation/devicetree/bindings/input/dlg,da7280.txt new file +3 -0
+	3 - Register triggered waveform memory mode, the pattern assigned
+	    to the PS_SEQ_ID played as much times as PS_SEQ_LOOP,
+	4 - Edge triggered waveform memory mode, external GPI(N) condtrol

"control"

Documentation/devicetree/bindings/input/dlg,da7280.txt line 24

Quoted 3 lines
Documentation/devicetree/bindings/input/dlg,da7280.txt new file +3 -0
+	    are required to enable/disable and it needs to keep
+	    device enabled by sending magnitude (X > 0),
+	    the pattern is assigned to the GPI(N)_SEQUENCE_ID below

"below."

Documentation/devicetree/bindings/input/dlg,da7280.txt line 34

Quoted 4 lines
Documentation/devicetree/bindings/input/dlg,da7280.txt new file +4 -0
+- dlg,imax-microamp: Actuator max current rating.
+  Valid values: 0 - 252000.
+  Default: 130000.
+- dlg,impd-micro-ohms: the impedance of the actuator in micro ohm,

"ohms"

Documentation/devicetree/bindings/input/dlg,da7280.txt line 35

Quoted 1 line
Documentation/devicetree/bindings/input/dlg,da7280.txt new file +1 -0
+  as read from its datasheet.

"as read" does not sound english.

Documentation/devicetree/bindings/input/dlg,da7280.txt line 79

Quoted 10 lines
Documentation/devicetree/bindings/input/dlg,da7280.txt new file +10 -0
+- dlg,mem-array: use in case that memory registers should be updated,
+  Please fill the whole buffers(100 bytes) to avoid any error in driver.
+  For example,
+	dlg,mem-array = <
+		0x01 0x02 0x03 0x04 0x05 0x06 0x07 0x08 0x09 0x0A
+		...
+		0x71 0x72 0x73 0x74 0x75 0x76 0x77 0x78 0x79 0x7A
+		0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
+		0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
+	>;

I'd not understand what this is from this description. (And I'd put example below... in the exampls section).

Quoted 21 lines
Documentation/devicetree/bindings/input/dlg,da7280.txt new file +21 -0
+For further information, see device datasheet.
+
+======
+
+Example:
+
+	haptics: da7280-haptics@4a {
+		compatible = "dlg,da7280";
+		reg = <0x4a>;
+		interrupt-parent = <&gpio6>;
+		interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
+		dlg,vib-mode = "LRA-MODE";
+		dlg,op-mode = <1>;
+		dlg,nom-microvolt = <2000000>;
+		dlg,abs-max-microvolt = <2000000>;
+		dlg,imax-microamp = <170000>;
+		dlg,resonant-freq-hz = <180>;
+		dlg,impd-micro-ohms = <10500000>;
+		dlg,freq-track-enable;
+		dlg,rapid-stop-enable;
+	};
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
author
#4 lore raw

RE: [PATCH V4 2/3] dt-bindings: input: Add document bindings for DA7280

Hi Pavel,

Quoted 11 lines · Pavel Machek
Quoted 11 lines

+++ b/Documentation/devicetree/bindings/input/dlg,da7280.txt

Documentation/devicetree/bindings/input/dlg,da7280.txt new file +8 -0
@@ -0,0 +1,101 @@
+Dialog Semiconductor DA7280 Haptics bindings
+
+Required properties:
+- compatible: Should be "dlg,da7280".
+- reg: Specifies the I2C slave address.
+
+- interrupt-parent : Specifies the phandle of the interrupt
+controller to
Quoted 8 lines

Documentation/devicetree/bindings/input/dlg,da7280.txt line 13

Quoted 6 lines
Documentation/devicetree/bindings/input/dlg,da7280.txt new file +6 -0
+  which the IRQs from DA7280 are delivered to.
+
+- dlg,vib-mode:
+  "LRA-MODE" - Linear Resonance Actuator mode.
+  "ERM-BAR" - Bar type Eccentric Rotating Mass mode.
+  "ERM-COIN" - Coin type Eccentric Rotating Mass mode.

So this is some kind of "vibration motor" on steroids)?

I will add some descriptions more here in v5.

Quoted 6 lines

Documentation/devicetree/bindings/input/dlg,da7280.txt line 18

Quoted 4 lines
Documentation/devicetree/bindings/input/dlg,da7280.txt new file +4 -0
+- dlg,op-mode: Haptic operation mode.
+  Possible values:
+	1 - Direct register override mode triggered by i2c(default),
+	2 - PWM data source mode setting duty to 0 - 0xffff(0% - 100%),

Space after 0xffff?

I will remove this in v5.

Quoted 6 lines

Documentation/devicetree/bindings/input/dlg,da7280.txt line 21

Quoted 4 lines
Documentation/devicetree/bindings/input/dlg,da7280.txt new file +3 -0
+	3 - Register triggered waveform memory mode, the pattern assigned
+	    to the PS_SEQ_ID played as much times as PS_SEQ_LOOP,
+	4 - Edge triggered waveform memory mode, external GPI(N) condtrol

"control"

I will fix this in v5

Quoted 6 lines

Documentation/devicetree/bindings/input/dlg,da7280.txt line 24

Quoted 4 lines
Documentation/devicetree/bindings/input/dlg,da7280.txt new file +3 -0
+	    are required to enable/disable and it needs to keep
+	    device enabled by sending magnitude (X > 0),
+	    the pattern is assigned to the GPI(N)_SEQUENCE_ID below

"below."

I will fix this in v5

Quoted 7 lines

Documentation/devicetree/bindings/input/dlg,da7280.txt line 34

Quoted 5 lines
Documentation/devicetree/bindings/input/dlg,da7280.txt new file +4 -0
+- dlg,imax-microamp: Actuator max current rating.
+  Valid values: 0 - 252000.
+  Default: 130000.
+- dlg,impd-micro-ohms: the impedance of the actuator in micro ohm,

"ohms"

I will fix this in v5.

Quoted 4 lines

Documentation/devicetree/bindings/input/dlg,da7280.txt line 35

Quoted 2 lines
Documentation/devicetree/bindings/input/dlg,da7280.txt new file +1 -0
+  as read from its datasheet.

"as read" does not sound english.

I will correct this in v5.

Quoted 14 lines

Documentation/devicetree/bindings/input/dlg,da7280.txt line 79

Quoted 11 lines
Documentation/devicetree/bindings/input/dlg,da7280.txt new file +10 -0
+- dlg,mem-array: use in case that memory registers should be updated,
+  Please fill the whole buffers(100 bytes) to avoid any error in driver.
+  For example,
+	dlg,mem-array = <
+		0x01 0x02 0x03 0x04 0x05 0x06 0x07 0x08 0x09 0x0A
+		...
+		0x71 0x72 0x73 0x74 0x75 0x76 0x77 0x78 0x79 0x7A
+		0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
+		0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
+	>;

I'd not understand what this is from this description. (And I'd put example below... in the exampls section).

I will improve and update the description including the example section in v5.

Regards,
Roy

Quoted 27 lines
Quoted 12 lines
Documentation/devicetree/bindings/input/dlg,da7280.txt new file +11 -0
+For further information, see device datasheet.
+
+======
+
+Example:
+
+	haptics: da7280-haptics@4a {
+		compatible = "dlg,da7280";
+		reg = <0x4a>;
+		interrupt-parent = <&gpio6>;
+		interrupts = <11 IRQ_TYPE_LEVEL_LOW>;

Documentation/devicetree/bindings/input/dlg,da7280.txt line 101

Quoted 10 lines
Documentation/devicetree/bindings/input/dlg,da7280.txt new file +10 -0
+		dlg,vib-mode = "LRA-MODE";
+		dlg,op-mode = <1>;
+		dlg,nom-microvolt = <2000000>;
+		dlg,abs-max-microvolt = <2000000>;
+		dlg,imax-microamp = <170000>;
+		dlg,resonant-freq-hz = <180>;
+		dlg,impd-micro-ohms = <10500000>;
+		dlg,freq-track-enable;
+		dlg,rapid-stop-enable;
+	};

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

author
#5 lore raw

PATCH v4 3/3 Input: new da7280 haptic driver

In reply to Roy Im

Adds support for the Dialog DA7280 LRA/ERM Haptic Driver with multiple mode and integrated waveform memory and wideband support. It communicates via an I2C bus to the device.

Signed-off-by Roy Im <[email protected]>

---
v4: Updated code as dt-bindings are changed.

v3: No changes.

v2: Fixed kbuild error/warning

 drivers/input/misc/Kconfig  |   12 +
 drivers/input/misc/Makefile |    1 +
 drivers/input/misc/da7280.c | 1438 +++++++++++++++++++++++++++++++++++++++++++
 drivers/input/misc/da7280.h |  412 +++++++++++++
 4 files changed, 1863 insertions(+)
 create mode 100644 drivers/input/misc/da7280.c
 create mode 100644 drivers/input/misc/da7280.h
drivers/input/misc/Kconfig +12 -0
index ca59a2b..6e0de69 100644
@@ -851,4 +851,16 @@ config INPUT_SC27XX_VIBRA
 	  To compile this driver as a module, choose M here. The module will
 	  be called sc27xx_vibra.
 
+config INPUT_DA7280_HAPTICS
+	tristate "Dialog Semiconductor DA7280 haptics support"
+	depends on (INPUT && I2C && SYSFS) || PWM
+	select INPUT_FF_MEMLESS
+	select REGMAP_I2C
+	help
+	  Say Y to enable support for the haptics controller on
+	  Dialog DA7280 chip.
+
+	  To compile this driver as a module, choose M here: the
+	  module will be called da7280-haptic.
+
 endif
drivers/input/misc/Makefile +1 -0
index 9d0f9d1..d941348 100644
@@ -25,6 +25,7 @@ obj-$(CONFIG_INPUT_CMA3000)		+= cma3000_d0x.o
 obj-$(CONFIG_INPUT_CMA3000_I2C)		+= cma3000_d0x_i2c.o
 obj-$(CONFIG_INPUT_COBALT_BTNS)		+= cobalt_btns.o
 obj-$(CONFIG_INPUT_CPCAP_PWRBUTTON)	+= cpcap-pwrbutton.o
+obj-$(CONFIG_INPUT_DA7280_HAPTICS)	+= da7280.o
 obj-$(CONFIG_INPUT_DA9052_ONKEY)	+= da9052_onkey.o
 obj-$(CONFIG_INPUT_DA9055_ONKEY)	+= da9055_onkey.o
 obj-$(CONFIG_INPUT_DA9063_ONKEY)	+= da9063_onkey.o
drivers/input/misc/da7280.c new file +1438 -0

1,438 lines not on this page · raw message

drivers/input/misc/da7280.h new file +412 -0

412 lines not on this page · raw message

Signature · 1 line
end-of-patch for PATCH V4
#6 lore raw

Re: [PATCH V4 3/3] Input: new da7280 haptic driver

drivers/input/misc/Kconfig config INPUT_SC27XX_VIBRA · line 853

Quoted 8 lines · Roy Im
drivers/input/misc/Kconfig +0 -0
index ca59a2b..6e0de69 100644
@@ -851,4 +851,16 @@ config INPUT_SC27XX_VIBRA
 	  To compile this driver as a module, choose M here. The module will
 	  be called sc27xx_vibra.

Hi,
Can you explain the "depends on" below, please.

drivers/input/misc/Kconfig config INPUT_SC27XX_VIBRA · line 858

Quoted 5 lines
drivers/input/misc/Kconfig +5 -0
+config INPUT_DA7280_HAPTICS
+	tristate "Dialog Semiconductor DA7280 haptics support"
+	depends on (INPUT && I2C && SYSFS) || PWM
+	select INPUT_FF_MEMLESS
+	select REGMAP_I2C

If INPUT is disabled, and I2C is disabled, and SYSFS is disabled, but PWM=y, then the "select"s will have problems with unmet dependencies.

drivers/input/misc/Kconfig config INPUT_SC27XX_VIBRA · line 864

Quoted 6 lines
drivers/input/misc/Kconfig +6 -0
+	help
+	  Say Y to enable support for the haptics controller on
+	  Dialog DA7280 chip.
+
+	  To compile this driver as a module, choose M here: the
+	  module will be called da7280-haptic.

That module name doesn't match what's in the Makefile (below).

Quoted 14 lines
drivers/input/misc/Kconfig +1 -0
+
 endif
drivers/input/misc/Makefile +1 -0
index 9d0f9d1..d941348 100644
@@ -25,6 +25,7 @@ obj-$(CONFIG_INPUT_CMA3000)		+= cma3000_d0x.o
 obj-$(CONFIG_INPUT_CMA3000_I2C)		+= cma3000_d0x_i2c.o
 obj-$(CONFIG_INPUT_COBALT_BTNS)		+= cobalt_btns.o
 obj-$(CONFIG_INPUT_CPCAP_PWRBUTTON)	+= cpcap-pwrbutton.o
+obj-$(CONFIG_INPUT_DA7280_HAPTICS)	+= da7280.o
 obj-$(CONFIG_INPUT_DA9052_ONKEY)	+= da9052_onkey.o
 obj-$(CONFIG_INPUT_DA9055_ONKEY)	+= da9055_onkey.o
 obj-$(CONFIG_INPUT_DA9063_ONKEY)	+= da9063_onkey.o
Signature · 1 line
~Randy
author
#7 lore raw

RE: [PATCH V4 3/3] Input: new da7280 haptic driver

Hi Randy,

Quoted 14 lines · Randy Dunlap

drivers/input/misc/Kconfig config INPUT_SC27XX_VIBRA · line 851

Quoted 6 lines · Roy Im
drivers/input/misc/Kconfig +0 -0
index ca59a2b..6e0de69 100644
@@ -851,4 +851,16 @@ config INPUT_SC27XX_VIBRA
 	  To compile this driver as a module, choose M here. The module

will

drivers/input/misc/Kconfig config INPUT_SC27XX_VIBRA · line 853

Quoted 2 lines
drivers/input/misc/Kconfig +0 -0
 	  be called sc27xx_vibra.

Hi,
Can you explain the "depends on" below, please.

Quoted 9 lines

drivers/input/misc/Kconfig config INPUT_SC27XX_VIBRA · line 858

Quoted 5 lines
drivers/input/misc/Kconfig +5 -0
+config INPUT_DA7280_HAPTICS
+	tristate "Dialog Semiconductor DA7280 haptics support"
+	depends on (INPUT && I2C && SYSFS) || PWM
+	select INPUT_FF_MEMLESS
+	select REGMAP_I2C

If INPUT is disabled, and I2C is disabled, and SYSFS is disabled, but PWM=y,
then the "select"s will have problems with unmet dependencies.

I will fix this in v5.

Quoted 9 lines

drivers/input/misc/Kconfig config INPUT_SC27XX_VIBRA · line 864

Quoted 7 lines
drivers/input/misc/Kconfig +6 -0
+	help
+	  Say Y to enable support for the haptics controller on
+	  Dialog DA7280 chip.
+
+	  To compile this driver as a module, choose M here: the
+	  module will be called da7280-haptic.

That module name doesn't match what's in the Makefile (below).

I will fix this as well in v5.

Quoted 18 lines

drivers/input/misc/Makefile obj-$(CONFIG_INPUT_CMA3000) +=

Quoted 8 lines
drivers/input/misc/Kconfig +1 -0
+
 endif
drivers/input/misc/Makefile +0 -0
index 9d0f9d1..d941348 100644
@@ -25,6 +25,7 @@ obj-$(CONFIG_INPUT_CMA3000)		+=

cma3000_d0x.o

drivers/input/misc/Makefile obj-$(CONFIG_INPUT_CMA3000) += cma3000_d0x.o · line 31

Quoted 7 lines
drivers/input/misc/Makefile +1 -0
 obj-$(CONFIG_INPUT_CMA3000_I2C)		+= cma3000_d0x_i2c.o
 obj-$(CONFIG_INPUT_COBALT_BTNS)		+= cobalt_btns.o
 obj-$(CONFIG_INPUT_CPCAP_PWRBUTTON)	+= cpcap-pwrbutton.o
+obj-$(CONFIG_INPUT_DA7280_HAPTICS)	+= da7280.o
 obj-$(CONFIG_INPUT_DA9052_ONKEY)	+= da9052_onkey.o
 obj-$(CONFIG_INPUT_DA9055_ONKEY)	+= da9055_onkey.o
 obj-$(CONFIG_INPUT_DA9063_ONKEY)	+= da9063_onkey.o
Quoted 2 lines

--
~Randy

Regards,
Roy