Skip to contentSkip to conversation

net: fix warnings in include/net/af_unix.h

PATCH Applied Bo YU 2 participants 5 messages Oct 30, 2018 – Nov 1, 2018

Subsystems (3)
Networking Network drivers Networking unix sockets
lore
Share & tools
lore

Bo YU

author
#0 lore raw

cover net: fix warnings in include/net/af_unix.h

Fix two warnings from checkpatch.pl.

Bo YU (2):
net: add an identifier name for 'struct sock *'
net: drop a space before tabs

 include/net/af_unix.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
author
#1 lore raw

PATCH 1/2 net: add an identifier name for 'struct sock *'

Fix a warning from checkpatch:
function definition argument 'struct sock *' should also have an identifier name in include/net/af_unix.h.

Signed-off-by Bo YU <[email protected]>
---
 include/net/af_unix.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/net/af_unix.h +1 -1
index e2695c4bf358..d53aea859a76 100644
@@ -13,7 +13,7 @@ void unix_notinflight(struct user_struct *user, struct file *fp);
 void unix_gc(void);
 void wait_for_unix_gc(void);
 struct sock *unix_get_socket(struct file *filp);
-struct sock *unix_peer_get(struct sock *);
+struct sock *unix_peer_get(struct sock *sk);
 
 #define UNIX_HASH_SIZE	256
 #define UNIX_HASH_BITS	8
Signature · 1 line
2.11.0
maintainer Applied
#2 lore raw

Re: [PATCH 1/2] net: add an identifier name for 'struct sock *'

From: Bo YU <[email protected]>
Date: Mon, 29 Oct 2018 23:42:09 -0400

Quoted 5 lines

Fix a warning from checkpatch:
function definition argument 'struct sock *' should also have an identifier name in include/net/af_unix.h.

Signed-off-by Bo YU <[email protected]>

Applied.

author
#3 lore raw

PATCH 2/2 net: drop a space before tabs

In reply to Bo YU

Fix a warning from checkpatch.pl:'please no space before tabs' in include/net/af_unix.h

Signed-off-by Bo YU <[email protected]>
---
 include/net/af_unix.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/net/af_unix.h +1 -1
index d53aea859a76..ddbba838d048 100644
@@ -40,7 +40,7 @@ struct unix_skb_parms {
 	u32			consumed;
 } __randomize_layout;
 
-#define UNIXCB(skb) 	(*(struct unix_skb_parms *)&((skb)->cb))
+#define UNIXCB(skb)	(*(struct unix_skb_parms *)&((skb)->cb))
 
 #define unix_state_lock(s)	spin_lock(&unix_sk(s)->lock)
 #define unix_state_unlock(s)	spin_unlock(&unix_sk(s)->lock)
Signature · 1 line
2.11.0
maintainer Applied
#4 lore raw

Re: [PATCH 2/2] net: drop a space before tabs

From: Bo YU <[email protected]>
Date: Mon, 29 Oct 2018 23:42:10 -0400

Quoted 4 lines

Fix a warning from checkpatch.pl:'please no space before tabs' in include/net/af_unix.h

Signed-off-by Bo YU <[email protected]>

Applied.