Skip to contentSkip to conversation

package.bbclass: Don not hide cpio's error

PATCH In review Robert Yang 2 participants 5 messages Dec 18, 2018 – Jan 10, 2019

lore
Share & tools
lore
#0 lore raw

cover package.bbclass: Don not hide cpio's error

The following changes since commit 20aea61385e1a53ac245353899277ba20104ed2f:

gcc: Drop 7.3 since 8.2 is working fine for us (2018-12-15 17:10:44 +0000)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/package
http://cgit.openembedded.org/openembedded-core-contrib/log/?h=rbt/package

Robert Yang (1):
package.bbclass: Don not hide cpio's error

 meta/classes/package.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 package.bbclass: Don not hide cpio's error

We use subprocess.check_output() to run the command, which means that we need care about the error, so the 2>/dev/null should not be used, otherwise it is hard to debug when the error happens.

I guess it was copied from previous lines, but that command's error can be ignored (excpet: pass):
try:
subprocess.check_output(cmd, shell=True, stderr=subprocess.STDOUT)
except subprocess.CalledProcessError:
# Can "fail" if internal headers/transient sources are attempted pass

But we don't do this in the current location, so remove "2>/dev/null"

---
 meta/classes/package.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/classes/package.bbclass +2 -1
index d1e9138..525d1c4 100644
@@ -470,7 +470,8 @@ def copydebugsources(debugsrcdir, d):
 
         # cpio seems to have a bug with -lL together and symbolic links are just copied, not dereferenced.
         # Work around this by manually finding and copying any symbolic links that made it through.
-        cmd = "find %s%s -type l -print0 -delete | sed s#%s%s/##g | (cd '%s' ; cpio -pd0mL --no-preserve-owner '%s%s' 2>/dev/null)" % (dvar, debugsrcdir, dvar, debugsrcdir, workparentdir, dvar, debugsrcdir)
+        cmd = "find %s%s -type l -print0 -delete | sed s#%s%s/##g | (cd '%s' ; cpio -pd0mL --no-preserve-owner '%s%s')" % \
+                (dvar, debugsrcdir, dvar, debugsrcdir, workparentdir, dvar, debugsrcdir)
         subprocess.check_output(cmd, shell=True, stderr=subprocess.STDOUT)
 
         # The copy by cpio may have resulted in some empty directories!  Remove these
Signature · 1 line
2.7.4
#2 lore raw
In reply to Robert Yang

Sorry, the subject should be:

package.bbclass: Do not hide cpio's error

Fixed it in the repo.

// Robert

Quoted 15 lines · Robert Yang

The following changes since commit 20aea61385e1a53ac245353899277ba20104ed2f:

gcc: Drop 7.3 since 8.2 is working fine for us (2018-12-15 17:10:44 +0000)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/package
http://cgit.openembedded.org/openembedded-core-contrib/log/?h=rbt/package

Robert Yang (1):
package.bbclass: Don not hide cpio's error

  meta/classes/package.bbclass | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
#3 lore raw
Quoted 16 lines · Robert Yang

Sorry, the subject should be:

package.bbclass: Do not hide cpio's error

Fixed it in the repo.

// Robert

Quoted 7 lines · Robert Yang

The following changes since commit 20aea61385e1a53ac245353899277ba20104ed2f:

   gcc: Drop 7.3 since 8.2 is working fine for us (2018-12-15 17:10:44 +0000)

are available in the git repository at:

   git://git.openembedded.org/openembedded-core-contrib rbt/package

Ping.

// Robert

Quoted 8 lines
Quoted 8 lines

   http://cgit.openembedded.org/openembedded-core-contrib/log/?h=rbt/package

Robert Yang (1):
   package.bbclass: Don not hide cpio's error

  meta/classes/package.bbclass | 3 ++-

  1 file changed, 2 insertions(+), 1 deletion(-)
#4 lore raw

Queued in mut already.

Ross

Quoted 41 lines · Robert Yang
Quoted 10 lines · Robert Yang

Sorry, the subject should be:

package.bbclass: Do not hide cpio's error

Fixed it in the repo.

// Robert

Quoted 1 line · Robert Yang

The following changes since commit

20aea61385e1a53ac245353899277ba20104ed2f:

Quoted 2 lines
Quoted 2 lines

gcc: Drop 7.3 since 8.2 is working fine for us (2018-12-15 17:10:44

+0000)

Quoted 4 lines
Quoted 4 lines

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib rbt/package

Ping.

// Robert

Quoted 1 line
Quoted 1 line

http://cgit.openembedded.org/openembedded-core-contrib/log/?h=rbt/package

Quoted 7 lines
Quoted 7 lines

Robert Yang (1):
package.bbclass: Don not hide cpio's error

  meta/classes/package.bbclass | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core