create-pull-request: fix sed command for SUBJECT
cover create-pull-request: fix sed command for SUBJECT
The following changes since commit 14c291e1fb6324da46885b69fbd7f01b3c6b053e:
gcc-runtime: Add missing libc dependency (2018-12-18 16:19:30 +0000)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib rbt/cpr
http://cgit.openembedded.org/openembedded-core-contrib/log/?h=rbt/cpr
Robert Yang (1):
create-pull-request: fix sed command for SUBJECT
scripts/create-pull-request | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
2.10.2
PATCH 1/1 create-pull-request: fix sed command for SUBJECT
Fixed when SUBJECT contains slash(/):
sed: -e expression #1, char 35: unknown option to `s'
Use '#' as separator to fix the problem.
--- scripts/create-pull-request | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/create-pull-request +1 -1
@@ -278,7 +278,7 @@ fi # Replace the SUBJECT token with it. if [ -n "$SUBJECT" ]; then - sed -i -e "s/\*\*\* SUBJECT HERE \*\*\*/$SUBJECT/" "$CL" + sed -i -e "s#\*\*\* SUBJECT HERE \*\*\*#$SUBJECT#" "$CL" fi
Signature · 1 line
2.10.2
So if I sent a patch with the subject "Fix #1234" it fails?
Sounds like a good reason to rewrite create-pull-request in Python to avoid this nonsense.
Ross
Quoted 32 lines · Robert Yang
Fixed when SUBJECT contains slash(/):
sed: -e expression #1, char 35: unknown option to `s'Use '#' as separator to fix the problem.
Signed-off-by Robert Yang <[email protected]>--- scripts/create-pull-request | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scripts/create-pull-request +1
-2@@ -278,7 +278,7 @@ fi # Replace the SUBJECT token with it. if [ -n "$SUBJECT" ]; then - sed -i -e "s/\*\*\* SUBJECT HERE \*\*\*/$SUBJECT/" "$CL" + sed -i -e "s#\*\*\* SUBJECT HERE \*\*\*#$SUBJECT#" "$CL" fi --2.10.2
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 4 lines · Ross
So if I sent a patch with the subject "Fix #1234" it fails?
Sounds like a good reason to rewrite create-pull-request in Python to avoid this nonsense.
Yes, that's a good idea, and we can improve it a little, such as:
* Check SOB, Upstream-Status and so on.
* Make it can check the patches on patchwork/patchtest if possible.
Our team can work on it if no objections.
// Robert
Quoted 36 lines
Ross
Quoted 32 lines · Robert Yang
Fixed when SUBJECT contains slash(/):
sed: -e expression #1, char 35: unknown option to `s'Use '#' as separator to fix the problem.
Signed-off-by Robert Yang <[email protected]>--- scripts/create-pull-request | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scripts/create-pull-request +1
-2@@ -278,7 +278,7 @@ fi # Replace the SUBJECT token with it. if [ -n "$SUBJECT" ]; then - sed -i -e "s/\*\*\* SUBJECT HERE \*\*\*/$SUBJECT/" "$CL" + sed -i -e "s#\*\*\* SUBJECT HERE \*\*\*#$SUBJECT#" "$CL" fi --2.10.2
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core