tracing: Hist trigger snapshot and onchange additions
Subsystems (4)
v15 cover tracing: Hist trigger snapshot and onchange additions
From: Tom Zanussi <[email protected]>
Hi,
This is v15 of the hist trigger snapshot and onchange additions patchset.
This version addresses several comments from Steve Rostedt (thanks, Steve!) in the snapshot and snapshot command patches. Everything else remains the same.
Thanks,
Tom
v14->v15 changes:
- Fixed return-with-mutex-held errors in tracing_snapshot_cond_enable() and simplified the error return handling.
- Simplified error return handling in update_max_tr().
- Simplified the -EBUSY cond_snapshot checks in tracing_set_tracer() and tracing_snapshot_write().
- Removed ifdef around cond_snapshot struct in trace.h.
- Introduced tracing_snapshot_instance_cond(), defined tracing_snapshot_instance() in terms of that, and changed the more numerous calls to that simpler function instead.
- Removed the unnecessary size param in track_data_alloc() and use TASK_COMM_LEN directly instead.
v13->v14 changes:
- Added CONFIG_TRACER_SNAPSHOT ifdefs as appropriate to partition out snapshot code.
- Changed tracing_snapshot_cond_enable() to return -ENODEV to the user if CONFIG_TRACER_SNAPSHOT isn't on.
- Made sure only the trigger that enabled the snapshot can disable it in track_data_destroy().
v12->v13 changes:
- Added -EBUSY checks to tracing_snapshot_cond_enable() tracing_snapshot_cond(), tracing_set_tracer() and tracing_snapshot_write().
- Introduced snapshot_context for passing key/elt pair to tracing_snapshot_cond().
- Removed key and cond_snapshot from action_data and cur_elt from track_data.
- Added updated flag to track_data and test for it in hist_trigger_print_key().
- Removed cond_snapshot_update_track_data() and simplified cond_snapshot_update().
- Removed get/save_track_val_fn_t and corresponding get_val/save_val() members from action_data.
- Moved code from get/save_val functions to save_data instead.
v11->v12 changes:
- Removed parens from the param list specification in the trace() command description
- Changed the Documentation for synthetic event generation to emphasize the trace() form over the function-call form.
v10->v11 changes:
- Updated to use str_has_prefix() for static strings
v9->v10 changes:
- Updated to use strncmp_prefix() for static strings
v8->v9 changes:
- Moved v8 patches 17-22 to a separate series
- Moved track_data.var_ref_idx removal into 'tracing: Generalize hist trigger onmax and save action'
- Merged 'tracing: Add hist trigger handler.action documentation' into 'tracing: Refactor hist trigger action code'
- Updated patches to change all strlen() to sizeof() for string constants
- Moved test cases to the end of the series
v7->v8 changes:
- Removed /dev/null redirection from test cases
- Replaced event disable with tracing_on disable instead
- New patch to remove hist_field.var_idx and track_data.var_ref_idx
- New patch to use var_refs[] array for reference checking
- New patch to remove open-coding of var_ref count manipulation
- New patch to use var_refs[] array to destroy var_refs
- New patch to remove synth_var_refs[] now that var_refs[] is used
- New patch to add comments to variable-related fields
- Added various new comments in the patches to clarify other things
- Replaced the convoluted logic mentioned by Namhyung in update_track_val with wrappers and simpler check/save logic as suggested
- Rebased to latest ftrace/core including Masami's dynamic event framework changes
v6->v7 changes:
- Removed unnecessary HANDLER_ONMAX checks from onmax_print()/create()
- Moved handler assignment to acion_parse()
- Changed goto in ATION_TRACE case in action_create() to return
- Changed EINVAL to EEXIST in action_create() ACTION_SAVE case
- Made the return logic in create_actions() more consistent
- Merged 'tracing: Move hist trigger key printing into a separate function' into 'tracing: Add hist trigger snapshot() action'
- Updated the new snapshot, onchange, and trace test cases to match 4.20 kselftest changes.
- Added new xfail test case that make sure certain unsupported handler/action combinations fail as expected.
- While updating the test cases, realized that the other testcases in the inter-event subdir needed SPDX license updates, so added them.
v5->v6 changes:
- Added new Documentation patch explaining handler.action
- Added new README patch explaining handler.action
- Added separate snapshot() Documentation
- Added new snapshot() test case
- Updated README with snapshote()
- Added separate onchange() Documentation
- Added separate onchange() test case
- Updated README with onchange()
- Added separate trace() test case
- Updated README with trace() and <synthetic_event>() syntax
v4->v5 changes:
- added 'trace' keyword test case
- added 'onchange' handler test case
v3->v4 changes:
- added 'trace' keyword for generating synthetic events
- fix elt_data leak
- changed cond_update to cond_update_fn_t
v2->v3 changes:
- fixed problem where trace actions were only being allowed for onmatch handlers - now trace actions can be used with any handler.
- fixed problem where no action was being assigned to onmatch handlers if save or snapshot actions were specified.
v1->v2 changes:
- added missing tracing_cond_snapshot_data() definition for when CONFIG_TRACER_SNAPSHOT not defined
- removed an unnecessary WARN_ON() in track_data_snapshot_print()
Original text:
This patchset adds some useful new functions to the hist trigger code: a snapshot action and an onchange handler.
In order to make it easier to add these and in the process make the code more generic, I separated the code into explicit 'handlers' and 'actions', handlers being things like 'onmax' and 'onchange', and 'actions' being things like 'take a snapshot' or 'save some fields'.
The first few patches do that basic refactoring, which make it easier to add the subsequent changes that arbitrarily combine actions and handlers.
The fourth patch adds a 'conditional snapshot' capability that via a new tracing_snaphot_cond() function extends the existing snapshot code. It allows the caller to associate some user data with the snapshot that can be checked and saved in an update() callback whose return value determines whether the snapshot should be taken or not.
The remaining patches finally add the new snapshot action and onchange handler functionality - please see those patches for details and some examples.
Thanks,
Tom
The following changes since commit 50c35ae1267d64eee975b8125e151e600071d4dc:
tracing: Use strncpy instead of memcpy for string keys in hist triggers (2019-02-04 08:45:50 -0600)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-trace.git ftrace/hist-snapshot-onchange-v15
Tom Zanussi (15):
tracing: Refactor hist trigger action code
tracing: Make hist trigger Documentation better reflect
actions/handlers
tracing: Split up onmatch action data
tracing: Generalize hist trigger onmax and save action
tracing: Add conditional snapshot
tracing: Add hist trigger snapshot() action
tracing: Add hist trigger snapshot() action Documentation
tracing: Add hist trigger onchange() handler
tracing: Add hist trigger onchange() handler Documentation
tracing: Add alternative synthetic event trace action syntax
tracing: Add SPDX license GPL-2.0 license identifier to inter-event
testcases
tracing: Add hist trigger snapshot() action test case
tracing: Add hist trigger onchange() handler test case
tracing: Add alternative synthetic event trace action test case
tracing: Add hist trigger action 'expected fail' test case
Documentation/trace/histogram.rst | 316 +++++- kernel/trace/trace.c | 208 +++- kernel/trace/trace.h | 56 +- kernel/trace/trace_events_hist.c | 1048 ++++++++++++++------ kernel/trace/trace_sched_wakeup.c | 2 +- .../inter-event/trigger-action-hist-xfail.tc | 30 + .../inter-event/trigger-extended-error-support.tc | 1 + .../inter-event/trigger-field-variable-support.tc | 1 + .../trigger-inter-event-combined-hist.tc | 1 + .../inter-event/trigger-multi-actions-accept.tc | 1 + .../inter-event/trigger-onchange-action-hist.tc | 28 + .../inter-event/trigger-onmatch-action-hist.tc | 1 + .../trigger-onmatch-onmax-action-hist.tc | 1 + .../inter-event/trigger-onmax-action-hist.tc | 1 + .../inter-event/trigger-snapshot-action-hist.tc | 43 + .../trigger-synthetic-event-createremove.tc | 1 + .../inter-event/trigger-trace-action-hist.tc | 42 + 17 files changed, 1459 insertions(+), 322 deletions(-) create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-action-hist-xfail.tc create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onchange-action-hist.tc create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-snapshot-action-hist.tc create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-trace-action-hist.tc
Signature · 1 line
2.14.1
PATCH v15 1/15 tracing: Refactor hist trigger action code
From: Tom Zanussi <[email protected]>
The hist trigger action code currently implements two essentially hard-coded pairs of 'actions' - onmax(), which tracks a variable and saves some event fields when a max is hit, and onmatch(), which is hard-coded to generate a synthetic event.
These hardcoded pairs (track max/save fields and detect match/generate synthetic event) should really be decoupled into separate components that can then be arbitrarily combined. The first component of each pair (track max/detect match) is called a 'handler' in the new code, while the second component (save fields/generate synthetic event) is called an 'action' in this scheme.
This change refactors the action code to reflect this split by adding two handlers, HANDLER_ONMATCH and HANDLER_ONMAX, along with two actions, ACTION_SAVE and ACTION_TRACE.
The new code combines them to produce the existing ONMATCH/TRACE and ONMAX/SAVE functionality, but doesn't implement the other combinations now possible. Future patches will expand these to further useful cases, such as ONMAX/TRACE, as well as add additional handlers and actions such as ONCHANGE and SNAPSHOT.
Also, add abbreviated documentation for handlers and actions to README.
--- kernel/trace/trace_events_hist.c | 407 +++++++++++++++++++++++---------------- 1 file changed, 238 insertions(+), 169 deletions(-)
kernel/trace/trace_events_hist.c +238 -169
@@ -313,9 +313,9 @@ struct hist_trigger_data {struct field_var_hist *field_var_hists[SYNTH_FIELDS_MAX ];unsigned int n_field_var_hists; -struct field_var *max_vars[SYNTH_FIELDS_MAX ]; -unsigned int n_max_vars; -unsigned int n_max_var_str; +struct field_var *save_vars[SYNTH_FIELDS_MAX ]; +unsigned int n_save_vars; +unsigned int n_save_var_str; };static int synth_event_create (int argc,const char **argv);
@@ -383,11 +383,25 @@ struct action_data;typedef void (*action_fn_t ) (struct hist_trigger_data *hist_data,struct tracing_map_elt *elt,void *rec, -struct ring_buffer_event *rbe, +struct ring_buffer_event *rbe,void *key,struct action_data *data,u64 *var_ref_vals); +enum handler_id { +HANDLER_ONMATCH =1 , +HANDLER_ONMAX , +}; + +enum action_id { +ACTION_SAVE =1 , +ACTION_TRACE , +}; +struct action_data { +enum handler_id handler; +enum action_id action; +char *action_name;action_fn_t fn; +unsigned int n_params;char *params[SYNTH_FIELDS_MAX ];
@@ -404,13 +418,11 @@ struct action_data {unsigned int var_ref_idx;char *match_event;char *match_event_system; -char *synth_event_name;struct synth_event *synth_event; } onmatch;struct {char *var_str; -char *fn_name;unsigned int max_var_ref_idx;struct hist_field *max_var;struct hist_field *var;
@@ -1078,7 +1090,7 @@ static struct synth_event *alloc_synth_event(const char *name, int n_fields,static void action_trace (struct hist_trigger_data *hist_data,struct tracing_map_elt *elt,void *rec, -struct ring_buffer_event *rbe, +struct ring_buffer_event *rbe,void *key,struct action_data *data,u64 *var_ref_vals) {struct synth_event *event = data->onmatch.synth_event;
@@ -1644,7 +1656,7 @@ find_match_var(struct hist_trigger_data *hist_data, char *var_name)for (i =0 ; i < hist_data->n_actions; i++) {struct action_data *data = hist_data->actions[i]; -if (data->fn == action_trace) { +if (data->handler ==HANDLER_ONMATCH ) {char *system = data->onmatch.match_event_system;char *event_name = data->onmatch.match_event;
@@ -2076,7 +2088,7 @@ static int hist_trigger_elt_data_alloc(struct tracing_map_elt *elt) } } - n_str = hist_data->n_field_var_str + hist_data->n_max_var_str; + n_str = hist_data->n_field_var_str + hist_data->n_save_var_str; size =STR_VAR_LEN_MAX ;
@@ -3050,7 +3062,7 @@ create_field_var_hist(struct hist_trigger_data *target_hist_data,int ret;if (target_hist_data->n_field_var_hists >=SYNTH_FIELDS_MAX ) { -hist_err_event ("onmatch: Too many field variables defined: " , +hist_err_event ("trace action: Too many field variables defined: " , subsys_name, event_name, field_name);return ERR_PTR (-EINVAL ); }
@@ -3058,7 +3070,7 @@ create_field_var_hist(struct hist_trigger_data *target_hist_data, file =event_file (tr, subsys_name, event_name);if (IS_ERR (file)) { -hist_err_event ("onmatch: Event file not found: " , +hist_err_event ("trace action: Event file not found: " , subsys_name, event_name, field_name); ret =PTR_ERR (file);return ERR_PTR (ret);
@@ -3072,7 +3084,7 @@ create_field_var_hist(struct hist_trigger_data *target_hist_data,*/ hist_data =find_compatible_hist (target_hist_data, file);if (!hist_data) { -hist_err_event ("onmatch: Matching event histogram not found: " , +hist_err_event ("trace action: Matching event histogram not found: " , subsys_name, event_name, field_name);return ERR_PTR (-EINVAL ); }
@@ -3134,7 +3146,7 @@ create_field_var_hist(struct hist_trigger_data *target_hist_data,kfree (cmd);kfree (var_hist->cmd);kfree (var_hist); -hist_err_event ("onmatch: Couldn't create histogram for field: " , +hist_err_event ("trace action: Couldn't create histogram for field: " , subsys_name, event_name, field_name);return ERR_PTR (ret); }
@@ -3147,7 +3159,7 @@ create_field_var_hist(struct hist_trigger_data *target_hist_data,if (IS_ERR_OR_NULL (event_var)) {kfree (var_hist->cmd);kfree (var_hist); -hist_err_event ("onmatch: Couldn't find synthetic variable: " , +hist_err_event ("trace action: Couldn't find synthetic variable: " , subsys_name, event_name, field_name);return ERR_PTR (-EINVAL ); }
@@ -3230,8 +3242,8 @@ static void update_max_vars(struct hist_trigger_data *hist_data,struct ring_buffer_event *rbe, void *rec) { - __update_field_vars(elt, rbe, rec, hist_data->max_vars, - hist_data->n_max_vars, hist_data->n_field_var_str); + __update_field_vars(elt, rbe, rec, hist_data->save_vars, + hist_data->n_save_vars, hist_data->n_field_var_str); } static struct hist_field *create_var(struct hist_trigger_data *hist_data,
@@ -3375,9 +3387,9 @@ static void onmax_print(struct seq_file *m,seq_printf (m,"\n\tmax: %10llu" ,tracing_map_read_var (elt, max_idx)); -for (i =0 ; i < hist_data->n_max_vars; i++) { -struct hist_field *save_val = hist_data->max_vars[i]->val; -struct hist_field *save_var = hist_data->max_vars[i]->var; +for (i =0 ; i < hist_data->n_save_vars; i++) { +struct hist_field *save_val = hist_data->save_vars[i]->val; +struct hist_field *save_var = hist_data->save_vars[i]->var;u64 val; save_var_idx = save_var->var.idx;
@@ -3394,7 +3406,7 @@ static void onmax_print(struct seq_file *m,static void onmax_save (struct hist_trigger_data *hist_data,struct tracing_map_elt *elt,void *rec, -struct ring_buffer_event *rbe, +struct ring_buffer_event *rbe,void *key,struct action_data *data,u64 *var_ref_vals) {unsigned int max_idx = data->onmax.max_var->var.idx;
@@ -3421,7 +3433,7 @@ static void onmax_destroy(struct action_data *data)destroy_hist_field (data->onmax.var,0 );kfree (data->onmax.var_str); -kfree (data->onmax.fn_name); +kfree (data->action_name);for (i =0 ; i < data->n_params; i++)kfree (data->params[i]);
@@ -3429,15 +3441,16 @@ static void onmax_destroy(struct action_data *data)kfree (data); } +static int action_create (struct hist_trigger_data *hist_data, +struct action_data *data); +static int onmax_create (struct hist_trigger_data *hist_data,struct action_data *data) { +struct hist_field *var_field, *ref_field, *max_var =NULL ;struct trace_event_file *file = hist_data->event_file; -struct hist_field *var_field, *ref_field, *max_var;unsigned int var_ref_idx = hist_data->n_var_refs; -struct field_var *field_var; -char *onmax_var_str, *param; -unsigned int i; +char *onmax_var_str;int ret =0 ; onmax_var_str = data->onmax.var_str;
@@ -3459,8 +3472,8 @@ static int onmax_create(struct hist_trigger_data *hist_data, data->onmax.var = ref_field; - data->fn = onmax_save; data->onmax.max_var_ref_idx = var_ref_idx; + max_var =create_var (hist_data, file,"max" ,sizeof (u64),"u64" );if (IS_ERR (max_var)) {hist_err ("onmax: Couldn't create onmax variable: " ,"max" );
@@ -3469,27 +3482,7 @@ static int onmax_create(struct hist_trigger_data *hist_data, } data->onmax.max_var = max_var; -for (i =0 ; i < data->n_params; i++) { - param =kstrdup (data->params[i],GFP_KERNEL ); -if (!param) { - ret = -ENOMEM ; - goto out; - } - - field_var =create_target_field_var (hist_data,NULL ,NULL , param); -if (IS_ERR (field_var)) { -hist_err ("onmax: Couldn't create field variable: " , param); - ret =PTR_ERR (field_var); -kfree (param); - goto out; - } - - hist_data->max_vars[hist_data->n_max_vars++] = field_var; -if (field_var->val->flags &HIST_FIELD_FL_STRING ) - hist_data->n_max_var_str++; - -kfree (param); - } + ret =action_create (hist_data, data); out:return ret; }
@@ -3500,11 +3493,14 @@ static int parse_action_params(char *params, struct action_data *data)int ret =0 ;while (params) { -if (data->n_params >=SYNTH_FIELDS_MAX ) +if (data->n_params >=SYNTH_FIELDS_MAX ) { +hist_err ("Too many action params" ,"" ); goto out; + } param =strsep (¶ms,"," );if (!param) { +hist_err ("No action param found" ,"" ); ret = -EINVAL ; goto out; }
@@ -3528,10 +3524,71 @@ static int parse_action_params(char *params, struct action_data *data)return ret; } -static struct action_data *onmax_parse (char *str) +static int action_parse (char *str,struct action_data *data, +enum handler_id handler) +{ +char *action_name; +int ret =0 ; + +strsep (&str,"." ); +if (!str) { +hist_err ("action parsing: No action found" ,"" ); + ret = -EINVAL ; + goto out; + } + + action_name =strsep (&str,"(" ); +if (!action_name || !str) { +hist_err ("action parsing: No action found" ,"" ); + ret = -EINVAL ; + goto out; + } + +if (str_has_prefix (action_name,"save" )) { +char *params =strsep (&str,")" ); + +if (!params) { +hist_err ("action parsing: No params found for %s" ,"save" ); + ret = -EINVAL ; + goto out; + } + + ret =parse_action_params (params, data); +if (ret) + goto out; + +if (handler ==HANDLER_ONMAX ) + data->fn = onmax_save; + + data->action =ACTION_SAVE ; + }else { +char *params =strsep (&str,")" ); + +if (params) { + ret =parse_action_params (params, data); +if (ret) + goto out; + } + + data->fn = action_trace; + data->action =ACTION_TRACE ; + } + + data->action_name =kstrdup (action_name,GFP_KERNEL ); +if (!data->action_name) { + ret = -ENOMEM ; + goto out; + } + + data->handler = handler; + out: +return ret; +} + +static struct action_data *onmax_parse (char *str,enum handler_id handler) { -char *onmax_fn_name, *onmax_var_str;struct action_data *data; +char *onmax_var_str;int ret = -EINVAL ; data =kzalloc (sizeof (*data),GFP_KERNEL );
@@ -3550,33 +3607,9 @@ static struct action_data *onmax_parse(char *str) goto free; } -strsep (&str,"." ); -if (!str) - goto free; - - onmax_fn_name =strsep (&str,"(" ); -if (!onmax_fn_name || !str) - goto free; - -if (str_has_prefix (onmax_fn_name,"save" )) { -char *params =strsep (&str,")" ); - -if (!params) { - ret = -EINVAL ; - goto free; - } - - ret =parse_action_params (params, data); -if (ret) - goto free; - }else - goto free; - - data->onmax.fn_name =kstrdup (onmax_fn_name,GFP_KERNEL ); -if (!data->onmax.fn_name) { - ret = -ENOMEM ; + ret =action_parse (str, data, handler); +if (ret) goto free; - } out:return data; free:
@@ -3593,7 +3626,7 @@ static void onmatch_destroy(struct action_data *data)kfree (data->onmatch.match_event);kfree (data->onmatch.match_event_system); -kfree (data->onmatch.synth_event_name); +kfree (data->action_name);for (i =0 ; i < data->n_params; i++)kfree (data->params[i]);
@@ -3651,8 +3684,9 @@ static int check_synth_field(struct synth_event *event, }static struct hist_field * -onmatch_find_var (struct hist_trigger_data *hist_data,struct action_data *data, -char *system,char *event,char *var) +trace_action_find_var (struct hist_trigger_data *hist_data, +struct action_data *data, +char *system,char *event,char *var) {struct hist_field *hist_field;
@@ -3660,7 +3694,7 @@ onmatch_find_var(struct hist_trigger_data *hist_data, struct action_data *data, hist_field =find_target_event_var (hist_data, system, event, var);if (!hist_field) { -if (!system) { +if (!system && data->handler ==HANDLER_ONMATCH ) { system = data->onmatch.match_event_system; event = data->onmatch.match_event; }
@@ -3669,15 +3703,15 @@ onmatch_find_var(struct hist_trigger_data *hist_data, struct action_data *data, }if (!hist_field) -hist_err_event ("onmatch: Couldn't find onmatch param: $" , system, event, var); +hist_err_event ("trace action: Couldn't find param: $" , system, event, var);return hist_field; }static struct hist_field * -onmatch_create_field_var (struct hist_trigger_data *hist_data, -struct action_data *data,char *system, -char *event,char *var) +trace_action_create_field_var (struct hist_trigger_data *hist_data, +struct action_data *data,char *system, +char *event,char *var) {struct hist_field *hist_field =NULL ;struct field_var *field_var;
@@ -3700,7 +3734,7 @@ onmatch_create_field_var(struct hist_trigger_data *hist_data,* looking for fields on the onmatch(system.event.xxx) * event. */ -if (!system) { +if (!system && data->handler ==HANDLER_ONMATCH ) { system = data->onmatch.match_event_system; event = data->onmatch.match_event; }
@@ -3724,9 +3758,8 @@ onmatch_create_field_var(struct hist_trigger_data *hist_data, goto out; } -static int onmatch_create (struct hist_trigger_data *hist_data, -struct trace_event_file *file, -struct action_data *data) +static int trace_action_create (struct hist_trigger_data *hist_data, +struct action_data *data) {char *event_name, *param, *system =NULL ;struct hist_field *hist_field, *var_ref;
@@ -3737,11 +3770,12 @@ static int onmatch_create(struct hist_trigger_data *hist_data,lockdep_assert_held (&event_mutex); - event =find_synth_event (data->onmatch.synth_event_name); + event =find_synth_event (data->action_name);if (!event) { -hist_err ("onmatch: Couldn't find synthetic event: " , data->onmatch.synth_event_name); +hist_err ("trace action: Couldn't find synthetic event: " , data->action_name);return -EINVAL ; } + event->ref++; var_ref_idx = hist_data->n_var_refs;
@@ -3769,13 +3803,15 @@ static int onmatch_create(struct hist_trigger_data *hist_data, }if (param[0 ] =='$' ) - hist_field =onmatch_find_var (hist_data, data, system, - event_name, param); + hist_field =trace_action_find_var (hist_data, data, + system, event_name, + param);else - hist_field =onmatch_create_field_var (hist_data, data, - system, - event_name, - param); + hist_field =trace_action_create_field_var (hist_data, + data, + system, + event_name, + param);if (!hist_field) {kfree (p);
@@ -3797,7 +3833,7 @@ static int onmatch_create(struct hist_trigger_data *hist_data,continue ; } -hist_err_event ("onmatch: Param type doesn't match synthetic event field type: " , +hist_err_event ("trace action: Param type doesn't match synthetic event field type: " , system, event_name, param);kfree (p); ret = -EINVAL ;
@@ -3805,12 +3841,11 @@ static int onmatch_create(struct hist_trigger_data *hist_data, }if (field_pos != event->n_fields) { -hist_err ("onmatch: Param count doesn't match synthetic event field count: " , event->name); +hist_err ("trace action: Param count doesn't match synthetic event field count: " , event->name); ret = -EINVAL ; goto err; } - data->fn = action_trace; data->onmatch.synth_event = event; data->onmatch.var_ref_idx = var_ref_idx; out:
@@ -3821,10 +3856,58 @@ static int onmatch_create(struct hist_trigger_data *hist_data, goto out; } +static int action_create (struct hist_trigger_data *hist_data, +struct action_data *data) +{ +struct field_var *field_var; +unsigned int i; +char *param; +int ret =0 ; + +if (data->action ==ACTION_TRACE ) +return trace_action_create (hist_data, data); + +if (data->action ==ACTION_SAVE ) { +if (hist_data->n_save_vars) { + ret = -EEXIST ; +hist_err ("save action: Can't have more than one save() action per hist" ,"" ); + goto out; + } + +for (i =0 ; i < data->n_params; i++) { + param =kstrdup (data->params[i],GFP_KERNEL ); +if (!param) { + ret = -ENOMEM ; + goto out; + } + + field_var =create_target_field_var (hist_data,NULL ,NULL , param); +if (IS_ERR (field_var)) { +hist_err ("save action: Couldn't create field variable: " , param); + ret =PTR_ERR (field_var); +kfree (param); + goto out; + } + + hist_data->save_vars[hist_data->n_save_vars++] = field_var; +if (field_var->val->flags &HIST_FIELD_FL_STRING ) + hist_data->n_save_var_str++; +kfree (param); + } + } + out: +return ret; +} + +static int onmatch_create (struct hist_trigger_data *hist_data, +struct action_data *data) +{ +return action_create (hist_data, data); +} +static struct action_data *onmatch_parse (struct trace_array *tr,char *str) {char *match_event, *match_event_system; -char *synth_event_name, *params;struct action_data *data;int ret = -EINVAL ;
@@ -3862,31 +3945,7 @@ static struct action_data *onmatch_parse(struct trace_array *tr, char *str) goto free; } -strsep (&str,"." ); -if (!str) { -hist_err ("onmatch: Missing . after onmatch(): " , str); - goto free; - } - - synth_event_name =strsep (&str,"(" ); -if (!synth_event_name || !str) { -hist_err ("onmatch: Missing opening paramlist paren: " , synth_event_name); - goto free; - } - - data->onmatch.synth_event_name =kstrdup (synth_event_name,GFP_KERNEL ); -if (!data->onmatch.synth_event_name) { - ret = -ENOMEM ; - goto free; - } - - params =strsep (&str,")" ); -if (!params || !str || (str &&strlen (str))) { -hist_err ("onmatch: Missing closing paramlist paren: " , params); - goto free; - } - - ret =parse_action_params (params, data); + ret =action_parse (str, data,HANDLER_ONMATCH );if (ret) goto free; out:
@@ -4326,9 +4385,9 @@ static void destroy_actions(struct hist_trigger_data *hist_data)for (i =0 ; i < hist_data->n_actions; i++) {struct action_data *data = hist_data->actions[i]; -if (data->fn == action_trace) +if (data->handler ==HANDLER_ONMATCH )onmatch_destroy (data); -else if (data->fn == onmax_save) +else if (data->handler ==HANDLER_ONMAX )onmax_destroy (data);else kfree (data);
@@ -4355,16 +4414,14 @@ static int parse_actions(struct hist_trigger_data *hist_data) ret =PTR_ERR (data);break ; } - data->fn = action_trace; }else if ((len =str_has_prefix (str,"onmax(" ))) {char *action_str = str + len; - data =onmax_parse (action_str); + data =onmax_parse (action_str,HANDLER_ONMAX );if (IS_ERR (data)) { ret =PTR_ERR (data);break ; } - data->fn = onmax_save; }else { ret = -EINVAL ;break ;
@@ -4376,8 +4433,7 @@ static int parse_actions(struct hist_trigger_data *hist_data)return ret; } -static int create_actions (struct hist_trigger_data *hist_data, -struct trace_event_file *file) +static int create_actions (struct hist_trigger_data *hist_data) {struct action_data *data;unsigned int i;
@@ -4386,14 +4442,17 @@ static int create_actions(struct hist_trigger_data *hist_data,for (i =0 ; i < hist_data->attrs->n_actions; i++) { data = hist_data->actions[i]; -if (data->fn == action_trace) { - ret =onmatch_create (hist_data, file, data); +if (data->handler ==HANDLER_ONMATCH ) { + ret =onmatch_create (hist_data, data);if (ret) -return ret; - }else if (data->fn == onmax_save) { +break ; + }else if (data->handler ==HANDLER_ONMAX ) { ret =onmax_create (hist_data, data);if (ret) -return ret; +break ; + }else { + ret = -EINVAL ; +break ; } }
@@ -4409,26 +4468,42 @@ static void print_actions(struct seq_file *m,for (i =0 ; i < hist_data->n_actions; i++) {struct action_data *data = hist_data->actions[i]; -if (data->fn == onmax_save) +if (data->handler ==HANDLER_ONMAX )onmax_print (m, hist_data, elt, data); } } +static void print_action_spec (struct seq_file *m, +struct hist_trigger_data *hist_data, +struct action_data *data) +{ +unsigned int i; + +if (data->action ==ACTION_SAVE ) { +for (i =0 ; i < hist_data->n_save_vars; i++) { +seq_printf (m,"%s" , hist_data->save_vars[i]->var->var.name); +if (i < hist_data->n_save_vars -1 ) +seq_puts (m,"," ); + } + }else if (data->action ==ACTION_TRACE ) { +for (i =0 ; i < data->n_params; i++) { +if (i) +seq_puts (m,"," ); +seq_printf (m,"%s" , data->params[i]); + } + } +} +static void print_onmax_spec (struct seq_file *m,struct hist_trigger_data *hist_data,struct action_data *data) { -unsigned int i; -seq_puts (m,":onmax(" );seq_printf (m,"%s" , data->onmax.var_str); -seq_printf (m,").%s(" , data->onmax.fn_name); +seq_printf (m,").%s(" , data->action_name); + +print_action_spec (m, hist_data, data); -for (i =0 ; i < hist_data->n_max_vars; i++) { -seq_printf (m,"%s" , hist_data->max_vars[i]->var->var.name); -if (i < hist_data->n_max_vars -1 ) -seq_puts (m,"," ); - }seq_puts (m,")" ); }
@@ -4436,18 +4511,12 @@ static void print_onmatch_spec(struct seq_file *m, struct hist_trigger_data *hist_data, struct action_data *data) { - unsigned int i; - seq_printf(m, ":onmatch(%s.%s).", data->onmatch.match_event_system, data->onmatch.match_event); -seq_printf (m,"%s(" , data->onmatch.synth_event->name); +seq_printf (m,"%s(" , data->action_name); -for (i =0 ; i < data->n_params; i++) { -if (i) -seq_puts (m,"," ); -seq_printf (m,"%s" , data->params[i]); - } +print_action_spec (m, hist_data, data);seq_puts (m,")" ); }
@@ -4464,7 +4533,9 @@ static bool actions_match(struct hist_trigger_data *hist_data,struct action_data *data = hist_data->actions[i];struct action_data *data_test = hist_data_test->actions[i]; -if (data->fn != data_test->fn) +if (data->handler != data_test->handler) +return false; +if (data->action != data_test->action)return false;if (data->n_params != data_test->n_params)
@@ -4475,23 +4546,20 @@ static bool actions_match(struct hist_trigger_data *hist_data,return false; } -if (data->fn == action_trace) { -if (strcmp (data->onmatch.synth_event_name, - data_test->onmatch.synth_event_name) !=0 ) -return false; +if (strcmp (data->action_name, data_test->action_name) !=0 ) +return false; + +if (data->handler ==HANDLER_ONMATCH ) {if (strcmp (data->onmatch.match_event_system, data_test->onmatch.match_event_system) !=0 )return false;if (strcmp (data->onmatch.match_event, data_test->onmatch.match_event) !=0 )return false; - }else if (data->fn == onmax_save) { + }else if (data->handler ==HANDLER_ONMAX ) {if (strcmp (data->onmax.var_str, data_test->onmax.var_str) !=0 )return false; -if (strcmp (data->onmax.fn_name, - data_test->onmax.fn_name) !=0 ) -return false; } }
@@ -4507,9 +4575,9 @@ static void print_actions_spec(struct seq_file *m,for (i =0 ; i < hist_data->n_actions; i++) {struct action_data *data = hist_data->actions[i]; -if (data->fn == action_trace) +if (data->handler ==HANDLER_ONMATCH )print_onmatch_spec (m, hist_data, data); -else if (data->fn == onmax_save) +else if (data->handler ==HANDLER_ONMAX )print_onmax_spec (m, hist_data, data); } }
@@ -4704,14 +4772,15 @@ static inline void add_to_key(char *compound_key, void *key,static void hist_trigger_actions (struct hist_trigger_data *hist_data,struct tracing_map_elt *elt,void *rec, -struct ring_buffer_event *rbe,u64 *var_ref_vals) +struct ring_buffer_event *rbe,void *key, +u64 *var_ref_vals) {struct action_data *data;unsigned int i;for (i =0 ; i < hist_data->n_actions; i++) { data = hist_data->actions[i]; - data->fn (hist_data, elt, rec, rbe, data, var_ref_vals); + data->fn (hist_data, elt, rec, rbe, key, data, var_ref_vals); } }
@@ -4772,7 +4841,7 @@ static void event_hist_trigger(struct event_trigger_data *data, void *rec,hist_trigger_elt_update (hist_data, elt, rec, rbe, var_ref_vals);if (resolve_var_refs (hist_data, key, var_ref_vals, true)) -hist_trigger_actions (hist_data, elt, rec, rbe, var_ref_vals); +hist_trigger_actions (hist_data, elt, rec, rbe, key, var_ref_vals); } static void hist_trigger_stacktrace_print(struct seq_file *m,
@@ -5684,7 +5753,7 @@ static int event_hist_trigger_func(struct event_command *cmd_ops,if (has_hist_vars (hist_data))save_hist_vars (hist_data); - ret =create_actions (hist_data, file); + ret =create_actions (hist_data);if (ret) goto out_unreg;
Signature · 1 line
2.14.1
PATCH v15 2/15 tracing: Make hist trigger Documentation better reflect actions/handlers
In reply to Tom ZanussiFrom: Tom Zanussi <[email protected]>
The action/handler code refactoring didn't change the action/handler syntax, but did generalize it - the Documentation should reflect that.
--- Documentation/trace/histogram.rst | 56 ++++++++++++++++++++++++++++++--------- 1 file changed, 43 insertions(+), 13 deletions(-)
Documentation/trace/histogram.rst +43 -13
@@ -25,7 +25,7 @@ Documentation written by Tom Zanussi hist:keys=<field1[,field2,...]>[:values=<field1[,field2,...]>] [:sort=<field1[,field2,...]>][:size=#entries][:pause][:continue] - [:clear][:name=histname1] [if <filter>] + [:clear][:name=histname1][:<handler>.<action>] [if <filter>] When a matching event is hit, an entry is added to a hash table using the key(s) and value(s) named. Keys and values correspond to
@@ -1831,21 +1831,51 @@ and looks and behaves just like any other event:: Like any other event, once a histogram is enabled for the event, the output can be displayed by reading the event's 'hist' file. -2.2.3 Hist trigger 'actions' ----------------------------- +2.2.3 Hist trigger 'handlers' and 'actions' +------------------------------------------- -A hist trigger 'action' is a function that's executed whenever a -histogram entry is added or updated. +A hist trigger 'action' is a function that's executed (in most cases +conditionally) whenever a histogram entry is added or updated. -The default 'action' if no special function is explicitly specified is -as it always has been, to simply update the set of values associated -with an entry. Some applications, however, may want to perform -additional actions at that point, such as generate another event, or -compare and save a maximum. +When a histogram entry is added or updated, a hist trigger 'handler' +is what decides whether the corresponding action is actually invoked +or not. -The following additional actions are available. To specify an action -for a given event, simply specify the action between colons in the -hist trigger specification. +Hist trigger handlers and actions are paired together in the general +form: + + <handler>.<action> + +To specify a handler.action pair for a given event, simply specify +that handler.action pair between colons in the hist trigger +specification. + +In theory, any handler can be combined with any action, but in +practice, not every handler.action combination is currently supported; +if a given handler.action combination isn't supported, the hist +trigger will fail with -EINVAL; + +The default 'handler.action' if none is explicity specified is as it +always has been, to simply update the set of values associated with an +entry. Some applications, however, may want to perform additional +actions at that point, such as generate another event, or compare and +save a maximum. + +The supported handlers and actions are listed below, and each is +described in more detail in the following paragraphs, in the context +of descriptions of some common and useful handler.action combinations. + +The available handlers are: + + - onmatch(matching.event) - invoke action on any addition or update + - onmax(var) - invoke action if var exceeds current max + +The available actions are: + + - <synthetic_event_name>(param list) - generate synthetic event + - save(field,...) - save current event fields + +The following commonly-used handler.action pairs are available: - onmatch(matching.event).<synthetic_event_name>(param list)
Signature · 1 line
2.14.1
PATCH v15 3/15 tracing: Split up onmatch action data
In reply to Tom ZanussiFrom: Tom Zanussi <[email protected]>
Currently, the onmatch action data binds the onmatch action to data related to synthetic event generation. Since we want to allow the onmatch handler to potentially invoke a different action, and because we expect other handlers to generate synthetic events, we need to separate the data related to these two functions.
Also rename the onmatch data to something more descriptive, and create and use common action data destroy function.
--- kernel/trace/trace.c | 12 ++++- kernel/trace/trace_events_hist.c | 103 ++++++++++++++++++++------------------- 2 files changed, 63 insertions(+), 52 deletions(-)
kernel/trace/trace.c +11 -1
@@ -4700,6 +4700,7 @@ static const char readme_msg[] ="\t [:size=#entries]\n" "\t [:pause][:continue][:clear]\n" "\t [:name=histname1]\n" +"\t [:<handler>.<action>]\n" "\t [if <filter>]\n\n" "\t When a matching event is hit, an entry is added to a hash\n" "\t table using the key(s) and value(s) named, and the value of a\n"
@@ -4741,7 +4742,16 @@ static const char readme_msg[] ="\t The enable_hist and disable_hist triggers can be used to\n" "\t have one event conditionally start and stop another event's\n" "\t already-attached hist trigger. The syntax is analagous to\n" - "\t the enable_event and disable_event triggers.\n" +"\t the enable_event and disable_event triggers.\n\n" +"\t Hist trigger handlers and actions are executed whenever a\n" +"\t a histogram entry is added or updated. They take the form:\n\n" +"\t <handler>.<action>\n\n" +"\t The available handlers are:\n\n" +"\t onmatch(matching.event) - invoke on addition or update\n" +"\t onmax(var) - invoke if var exceeds current max\n\n" +"\t The available actions are:\n\n" +"\t <synthetic_event>(param list) - generate synthetic event\n" + "\t save(field,...) - save current event fields\n"#endif ;
kernel/trace/trace_events_hist.c +52 -51
190 lines not on this page · raw message
Signature · 1 line
2.14.1
PATCH v15 4/15 tracing: Generalize hist trigger onmax and save action
In reply to Tom ZanussiFrom: Tom Zanussi <[email protected]>
The action refactor code allowed actions and handlers to be separated, but the existing onmax handler and save action code is still not flexible enough to handle arbitrary coupling. This change generalizes them and in the process makes additional handlers and actions easier to implement.
The onmax action can be broken up and thought of as two separate components - a variable to be tracked (the parameter given to the onmax($var_to_track) function) and an invisible variable created to save the ongoing result of doing something with that variable, such as saving the max value of that variable so far seen.
Separating it out like this and renaming it appropriately allows us to use the same code for similar tracking functions such as onchange($var_to_track), which would just track the last value seen rather than the max seen so far, which is useful in some situations.
Additionally, because different handlers and actions may want to save and access data differently e.g. save and retrieve tracking values as local variables vs something more global, save_val() and get_val() interface functions are introduced and max-specific implementations are used instead.
The same goes for the code that checks whether a maximum has been hit
- a generic check_val() interface and max-checking implementation is used instead, which allows future patches to make use of he same code using their own implemetations of similar functionality.
--- kernel/trace/trace_events_hist.c | 236 ++++++++++++++++++++++++++------------- 1 file changed, 160 insertions(+), 76 deletions(-)
kernel/trace/trace_events_hist.c +160 -76
@@ -386,6 +386,8 @@ typedef void (*action_fn_t) (struct hist_trigger_data *hist_data, struct ring_buffer_event *rbe, void *key, struct action_data *data, u64 *var_ref_vals); +typedef bool (*check_track_val_fn_t ) (u64 track_val,u64 var_val); +enum handler_id {HANDLER_ONMATCH =1 ,HANDLER_ONMAX ,
@@ -423,15 +425,35 @@ struct action_data { } match_data;struct { +/* +* var_str contains the $-unstripped variable +* name referenced by var_ref, and used when +* printing the action. Because var_ref +* creation is deferred to create_actions(), +* we need a per-action way to save it until +* then, thus var_str. +*/ char *var_str; -unsigned int max_var_ref_idx; -struct hist_field *max_var; -struct hist_field *var; - } onmax; + +/* +* var_ref refers to the variable being +* tracked e.g onmax($var). +*/ +struct hist_field *var_ref; + +/* +* track_var contains the 'invisible' tracking +* variable created to keep the current +* e.g. max value. +*/ +struct hist_field *track_var; + +check_track_val_fn_t check_val; +action_fn_t save_data; + } track_data; }; }; -static char last_hist_cmd[MAX_FILTER_STR_VAL ];static char hist_err_str[MAX_FILTER_STR_VAL ];
@@ -3238,10 +3260,10 @@ static void update_field_vars(struct hist_trigger_data *hist_data, hist_data->n_field_vars, 0); } -static void update_max_vars (struct hist_trigger_data *hist_data, -struct tracing_map_elt *elt, -struct ring_buffer_event *rbe, -void *rec) +static void save_track_data_vars (struct hist_trigger_data *hist_data, +struct tracing_map_elt *elt,void *rec, +struct ring_buffer_event *rbe,void *key, +struct action_data *data,u64 *var_ref_vals) {__update_field_vars (elt, rbe, rec, hist_data->save_vars, hist_data->n_save_vars, hist_data->n_field_var_str);
@@ -3379,14 +3401,67 @@ create_target_field_var(struct hist_trigger_data *target_hist_data,return create_field_var (target_hist_data, file, var_name); } -static void onmax_print (struct seq_file *m, -struct hist_trigger_data *hist_data, -struct tracing_map_elt *elt, -struct action_data *data) +static bool check_track_val_max (u64 track_val,u64 var_val) +{ +if (var_val <= track_val) +return false; + +return true; +} + +static u64 get_track_val (struct hist_trigger_data *hist_data, +struct tracing_map_elt *elt, +struct action_data *data) { -unsigned int i, save_var_idx, max_idx = data->onmax.max_var->var.idx; +unsigned int track_var_idx = data->track_data.track_var->var.idx; +u64 track_val; + + track_val =tracing_map_read_var (elt, track_var_idx); -seq_printf (m,"\n\tmax: %10llu" ,tracing_map_read_var (elt, max_idx)); +return track_val; +} + +static void save_track_val (struct hist_trigger_data *hist_data, +struct tracing_map_elt *elt, +struct action_data *data,u64 var_val) +{ +unsigned int track_var_idx = data->track_data.track_var->var.idx; + +tracing_map_set_var (elt, track_var_idx, var_val); +} + +static void save_track_data (struct hist_trigger_data *hist_data, +struct tracing_map_elt *elt,void *rec, +struct ring_buffer_event *rbe,void *key, +struct action_data *data,u64 *var_ref_vals) +{ +if (data->track_data.save_data) + data->track_data.save_data (hist_data, elt, rec, rbe, key, data, var_ref_vals); +} + +static bool check_track_val (struct tracing_map_elt *elt, +struct action_data *data, +u64 var_val) +{ +struct hist_trigger_data *hist_data; +u64 track_val; + + hist_data = data->track_data.track_var->hist_data; + track_val =get_track_val (hist_data, elt, data); + +return data->track_data.check_val (track_val, var_val); +} + +static void track_data_print (struct seq_file *m, +struct hist_trigger_data *hist_data, +struct tracing_map_elt *elt, +struct action_data *data) +{ +u64 track_val =get_track_val (hist_data, elt, data); +unsigned int i, save_var_idx; + +if (data->handler ==HANDLER_ONMAX ) +seq_printf (m,"\n\tmax: %10llu" , track_val);for (i =0 ; i < hist_data->n_save_vars; i++) {struct hist_field *save_val = hist_data->save_vars[i]->val;
@@ -3405,25 +3480,17 @@ static void onmax_print(struct seq_file *m, } } -static void onmax_save (struct hist_trigger_data *hist_data, -struct tracing_map_elt *elt,void *rec, -struct ring_buffer_event *rbe,void *key, -struct action_data *data,u64 *var_ref_vals) +static void ontrack_action (struct hist_trigger_data *hist_data, +struct tracing_map_elt *elt,void *rec, +struct ring_buffer_event *rbe,void *key, +struct action_data *data,u64 *var_ref_vals) { -unsigned int max_idx = data->onmax.max_var->var.idx; -unsigned int max_var_ref_idx = data->onmax.max_var_ref_idx; +u64 var_val = var_ref_vals[data->track_data.var_ref->var_ref_idx]; -u64 var_val, max_val; - - var_val = var_ref_vals[max_var_ref_idx]; - max_val =tracing_map_read_var (elt, max_idx); - -if (var_val <= max_val) -return ; - -tracing_map_set_var (elt, max_idx, var_val); - -update_max_vars (hist_data, elt, rbe, rec); +if (check_track_val (elt, data, var_val)) { +save_track_val (hist_data, elt, data, var_val); +save_track_data (hist_data, elt, rec, rbe, key, data, var_ref_vals); + } }static void action_data_destroy (struct action_data *data)
@@ -3443,12 +3510,13 @@ static void action_data_destroy(struct action_data *data)kfree (data); } -static void onmax_destroy (struct action_data *data) +static void track_data_destroy (struct hist_trigger_data *hist_data, +struct action_data *data) { -destroy_hist_field (data->onmax.max_var,0 ); -destroy_hist_field (data->onmax.var,0 ); +destroy_hist_field (data->track_data.track_var,0 ); +destroy_hist_field (data->track_data.var_ref,0 ); -kfree (data->onmax.var_str); +kfree (data->track_data.var_str);action_data_destroy (data); }
@@ -3456,25 +3524,24 @@ static void onmax_destroy(struct action_data *data)static int action_create (struct hist_trigger_data *hist_data,struct action_data *data); -static int onmax_create (struct hist_trigger_data *hist_data, -struct action_data *data) +static int track_data_create (struct hist_trigger_data *hist_data, +struct action_data *data) { -struct hist_field *var_field, *ref_field, *max_var =NULL ; +struct hist_field *var_field, *ref_field, *track_var =NULL ;struct trace_event_file *file = hist_data->event_file; -unsigned int var_ref_idx = hist_data->n_var_refs; -char *onmax_var_str; +char *track_data_var_str;int ret =0 ; - onmax_var_str = data->onmax.var_str; -if (onmax_var_str[0 ] !='$' ) { -hist_err ("onmax: For onmax(x), x must be a variable: " , onmax_var_str); + track_data_var_str = data->track_data.var_str; +if (track_data_var_str[0 ] !='$' ) { +hist_err ("For onmax(x), x must be a variable: " , track_data_var_str);return -EINVAL ; } - onmax_var_str++; + track_data_var_str++; - var_field =find_target_event_var (hist_data,NULL ,NULL , onmax_var_str); + var_field =find_target_event_var (hist_data,NULL ,NULL , track_data_var_str);if (!var_field) { -hist_err ("onmax: Couldn't find onmax variable: " , onmax_var_str); +hist_err ("Couldn't find onmax variable: " , track_data_var_str);return -EINVAL ; }
@@ -3482,17 +3549,16 @@ static int onmax_create(struct hist_trigger_data *hist_data,if (!ref_field)return -ENOMEM ; - data->onmax.var = ref_field; + data->track_data.var_ref = ref_field; - data->onmax.max_var_ref_idx = var_ref_idx; - - max_var =create_var (hist_data, file,"max" ,sizeof (u64),"u64" ); -if (IS_ERR (max_var)) { -hist_err ("onmax: Couldn't create onmax variable: " ,"max" ); - ret =PTR_ERR (max_var); +if (data->handler ==HANDLER_ONMAX ) + track_var =create_var (hist_data, file,"__max" ,sizeof (u64),"u64" ); +if (IS_ERR (track_var)) { +hist_err ("Couldn't create onmax variable: " ,"__max" ); + ret =PTR_ERR (track_var); goto out; } - data->onmax.max_var = max_var; + data->track_data.track_var = track_var; ret =action_create (hist_data, data); out:
@@ -3570,8 +3636,15 @@ static int action_parse(char *str, struct action_data *data, goto out;if (handler ==HANDLER_ONMAX ) - data->fn = onmax_save; + data->track_data.check_val = check_track_val_max; +else { +hist_err ("action parsing: Handler doesn't support action: " , action_name); + ret = -EINVAL ; + goto out; + } + data->track_data.save_data = save_track_data_vars; + data->fn = ontrack_action; data->action =ACTION_SAVE ; }else {char *params =strsep (&str,")" );
@@ -3582,7 +3655,15 @@ static int action_parse(char *str, struct action_data *data, goto out; } - data->fn = action_trace; +if (handler ==HANDLER_ONMAX ) + data->track_data.check_val = check_track_val_max; + +if (handler !=HANDLER_ONMATCH ) { + data->track_data.save_data = action_trace; + data->fn = ontrack_action; + }else + data->fn = action_trace; + data->action =ACTION_TRACE ; }
@@ -3597,24 +3678,25 @@ static int action_parse(char *str, struct action_data *data,return ret; } -static struct action_data *onmax_parse (char *str,enum handler_id handler) +static struct action_data *track_data_parse (struct hist_trigger_data *hist_data, +char *str,enum handler_id handler) {struct action_data *data; -char *onmax_var_str;int ret = -EINVAL ; +char *var_str; data =kzalloc (sizeof (*data),GFP_KERNEL );if (!data)return ERR_PTR (-ENOMEM ); - onmax_var_str =strsep (&str,")" ); -if (!onmax_var_str || !str) { + var_str =strsep (&str,")" ); +if (!var_str || !str) { ret = -EINVAL ; goto free; } - data->onmax.var_str =kstrdup (onmax_var_str,GFP_KERNEL ); -if (!data->onmax.var_str) { + data->track_data.var_str =kstrdup (var_str,GFP_KERNEL ); +if (!data->track_data.var_str) { ret = -ENOMEM ; goto free; }
@@ -3625,7 +3707,7 @@ static struct action_data *onmax_parse(char *str, enum handler_id handler) out:return data; free: -onmax_destroy (data); +track_data_destroy (hist_data, data); data =ERR_PTR (ret); goto out; }
@@ -4389,7 +4471,7 @@ static void destroy_actions(struct hist_trigger_data *hist_data)if (data->handler ==HANDLER_ONMATCH )onmatch_destroy (data);else if (data->handler ==HANDLER_ONMAX ) -onmax_destroy (data); +track_data_destroy (hist_data, data);else kfree (data); }
@@ -4418,7 +4500,8 @@ static int parse_actions(struct hist_trigger_data *hist_data) }else if ((len =str_has_prefix (str,"onmax(" ))) {char *action_str = str + len; - data =onmax_parse (action_str,HANDLER_ONMAX ); + data =track_data_parse (hist_data, action_str, +HANDLER_ONMAX );if (IS_ERR (data)) { ret =PTR_ERR (data);break ;
@@ -4448,7 +4531,7 @@ static int create_actions(struct hist_trigger_data *hist_data)if (ret)break ; }else if (data->handler ==HANDLER_ONMAX ) { - ret =onmax_create (hist_data, data); + ret =track_data_create (hist_data, data);if (ret)break ; }else {
@@ -4470,7 +4553,7 @@ static void print_actions(struct seq_file *m,struct action_data *data = hist_data->actions[i];if (data->handler ==HANDLER_ONMAX ) -onmax_print (m, hist_data, elt, data); +track_data_print (m, hist_data, elt, data); } }
@@ -4495,12 +4578,13 @@ static void print_action_spec(struct seq_file *m, } } -static void print_onmax_spec (struct seq_file *m, -struct hist_trigger_data *hist_data, -struct action_data *data) +static void print_track_data_spec (struct seq_file *m, +struct hist_trigger_data *hist_data, +struct action_data *data) { -seq_puts (m,":onmax(" ); -seq_printf (m,"%s" , data->onmax.var_str); +if (data->handler ==HANDLER_ONMAX ) +seq_puts (m,":onmax(" ); +seq_printf (m,"%s" , data->track_data.var_str);seq_printf (m,").%s(" , data->action_name);print_action_spec (m, hist_data, data);
@@ -4558,8 +4642,8 @@ static bool actions_match(struct hist_trigger_data *hist_data, data_test->match_data.event) != 0)return false; }else if (data->handler ==HANDLER_ONMAX ) { -if (strcmp (data->onmax.var_str, - data_test->onmax.var_str) !=0 ) +if (strcmp (data->track_data.var_str, + data_test->track_data.var_str) !=0 )return false; } }
@@ -4579,7 +4663,7 @@ static void print_actions_spec(struct seq_file *m,if (data->handler ==HANDLER_ONMATCH )print_onmatch_spec (m, hist_data, data);else if (data->handler ==HANDLER_ONMAX ) -print_onmax_spec (m, hist_data, data); +print_track_data_spec (m, hist_data, data); } }
Signature · 1 line
2.14.1
PATCH v15 5/15 tracing: Add conditional snapshot
In reply to Tom ZanussiFrom: Tom Zanussi <[email protected]>
Currently, tracing snapshots are context-free - they capture the ring buffer contents at the time the tracing_snapshot() function was invoked, and nothing else. Additionally, they're always taken unconditionally - the calling code can decide whether or not to take a snapshot, but the data used to make that decision is kept separately from the snapshot itself.
This change adds the ability to associate with each trace instance some user data, along with an 'update' function that can use that data to determine whether or not to actually take a snapshot. The update function can then update that data along with any other state (as part of the data presumably), if warranted.
Because snapshots are 'global' per-instance, only one user can enable and use a conditional snapshot for any given trace instance. To enable a conditional snapshot (see details in the function and data structure comments), the user calls tracing_snapshot_cond_enable(). Similarly, to disable a conditional snapshot and free it up for other users, tracing_snapshot_cond_disable() should be called.
To actually initiate a conditional snapshot, tracing_snapshot_cond() should be called. tracing_snapshot_cond() will invoke the update() callback, allowing the user to decide whether or not to actually take the snapshot and update the user-defined data associated with the snapshot. If the callback returns 'true', tracing_snapshot_cond() will then actually take the snapshot and return.
This scheme allows for flexibility in snapshot implementations - for example, by implementing slightly different update() callbacks, snapshots can be taken in situations where the user is only interested in taking a snapshot when a new maximum in hit versus when a value changes in any way at all. Future patches will demonstrate both cases.
--- kernel/trace/trace.c | 192 +++++++++++++++++++++++++++++++++++++- kernel/trace/trace.h | 56 ++++++++++- kernel/trace/trace_sched_wakeup.c | 2 +- 3 files changed, 244 insertions(+), 6 deletions(-)
kernel/trace/trace.c +188 -4
@@ -894,7 +894,7 @@ int __trace_bputs(unsigned long ip, const char *str)EXPORT_SYMBOL_GPL (__trace_bputs);#ifdef CONFIG_TRACER_SNAPSHOT -void tracing_snapshot_instance (struct trace_array *tr) +void tracing_snapshot_instance_cond (struct trace_array *tr,void *cond_data) {struct tracer *tracer = tr->current_trace;unsigned long flags;
@@ -920,10 +920,15 @@ void tracing_snapshot_instance(struct trace_array *tr) }local_irq_save (flags); -update_max_tr (tr, current,smp_processor_id ()); +update_max_tr (tr, current,smp_processor_id (), cond_data);local_irq_restore (flags); } +void tracing_snapshot_instance (struct trace_array *tr) +{ +tracing_snapshot_instance_cond (tr,NULL ); +} +/** * tracing_snapshot - take a snapshot of the current buffer. *
@@ -946,6 +951,54 @@ void tracing_snapshot(void) }EXPORT_SYMBOL_GPL (tracing_snapshot); +/** +* tracing_snapshot_cond - conditionally take a snapshot of the current buffer. +* @tr: The tracing instance to snapshot +* @cond_data: The data to be tested conditionally, and possibly saved +* +* This is the same as tracing_snapshot() except that the snapshot is +* conditional - the snapshot will only happen if the +* cond_snapshot.update() implementation receiving the cond_data +* returns true, which means that the trace array's cond_snapshot +* update() operation used the cond_data to determine whether the +* snapshot should be taken, and if it was, presumably saved it along +* with the snapshot. +*/ +void tracing_snapshot_cond (struct trace_array *tr,void *cond_data) +{ +tracing_snapshot_instance_cond (tr, cond_data); +} +EXPORT_SYMBOL_GPL (tracing_snapshot_cond); + +/** +* tracing_snapshot_cond_data - get the user data associated with a snapshot +* @tr: The tracing instance +* +* When the user enables a conditional snapshot using +* tracing_snapshot_cond_enable(), the user-defined cond_data is saved +* with the snapshot. This accessor is used to retrieve it. +* +* Should not be called from cond_snapshot.update(), since it takes +* the tr->max_lock lock, which the code calling +* cond_snapshot.update() has already done. +* +* Returns the cond_data associated with the trace array's snapshot. +*/ +void *tracing_cond_snapshot_data (struct trace_array *tr) +{ +void *cond_data =NULL ; + +arch_spin_lock (&tr->max_lock); + +if (tr->cond_snapshot) + cond_data = tr->cond_snapshot->cond_data; + +arch_spin_unlock (&tr->max_lock); + +return cond_data; +} +EXPORT_SYMBOL_GPL (tracing_cond_snapshot_data); +static int resize_buffer_duplicate_size (struct trace_buffer *trace_buf,struct trace_buffer *size_buf,int cpu_id);static void set_buffer_entries (struct trace_buffer *buf,unsigned long val);
@@ -1025,12 +1078,103 @@ void tracing_snapshot_alloc(void)tracing_snapshot (); }EXPORT_SYMBOL_GPL (tracing_snapshot_alloc); + +/** +* tracing_snapshot_cond_enable - enable conditional snapshot for an instance +* @tr: The tracing instance +* @cond_data: User data to associate with the snapshot +* @update: Implementation of the cond_snapshot update function +* +* Check whether the conditional snapshot for the given instance has +* already been enabled, or if the current tracer is already using a +* snapshot; if so, return -EBUSY, else create a cond_snapshot and +* save the cond_data and update function inside. +* +* Returns 0 if successful, error otherwise. +*/ +int tracing_snapshot_cond_enable (struct trace_array *tr,void *cond_data, +cond_update_fn_t update) +{ +struct cond_snapshot *cond_snapshot; +int ret =0 ; + + cond_snapshot =kzalloc (sizeof (*cond_snapshot),GFP_KERNEL ); +if (!cond_snapshot) +return -ENOMEM ; + + cond_snapshot->cond_data = cond_data; + cond_snapshot->update = update; + +mutex_lock (&trace_types_lock); + + ret =tracing_alloc_snapshot_instance (tr); +if (ret) + goto fail_unlock; + +if (tr->current_trace->use_max_tr) { + ret = -EBUSY ; + goto fail_unlock; + } + +if (tr->cond_snapshot) { + ret = -EBUSY ; + goto fail_unlock; + } + +arch_spin_lock (&tr->max_lock); + tr->cond_snapshot = cond_snapshot; +arch_spin_unlock (&tr->max_lock); + +mutex_unlock (&trace_types_lock); + +return ret; + + fail_unlock: +mutex_unlock (&trace_types_lock); +kfree (cond_snapshot); +return ret; +} +EXPORT_SYMBOL_GPL (tracing_snapshot_cond_enable); + +/** +* tracing_snapshot_cond_disable - disable conditional snapshot for an instance +* @tr: The tracing instance +* +* Check whether the conditional snapshot for the given instance is +* enabled; if so, free the cond_snapshot associated with it, +* otherwise return -EINVAL. +* +* Returns 0 if successful, error otherwise. +*/ +int tracing_snapshot_cond_disable (struct trace_array *tr) +{ +int ret =0 ; + +arch_spin_lock (&tr->max_lock); + +if (!tr->cond_snapshot) + ret = -EINVAL ; +else { +kfree (tr->cond_snapshot); + tr->cond_snapshot =NULL ; + } + +arch_spin_unlock (&tr->max_lock); + +return ret; +} +EXPORT_SYMBOL_GPL (tracing_snapshot_cond_disable);#else void tracing_snapshot (void ) {WARN_ONCE (1 ,"Snapshot feature not enabled, but internal snapshot used" ); }EXPORT_SYMBOL_GPL (tracing_snapshot); +void tracing_snapshot_cond (struct trace_array *tr,void *cond_data) +{ +WARN_ONCE (1 ,"Snapshot feature not enabled, but internal conditional snapshot used" ); +} +EXPORT_SYMBOL_GPL (tracing_snapshot_cond);int tracing_alloc_snapshot (void ) {WARN_ONCE (1 ,"Snapshot feature not enabled, but snapshot allocation used" );
@@ -1043,6 +1187,21 @@ void tracing_snapshot_alloc(void) tracing_snapshot(); }EXPORT_SYMBOL_GPL (tracing_snapshot_alloc); +void *tracing_cond_snapshot_data (struct trace_array *tr) +{ +return NULL ; +} +EXPORT_SYMBOL_GPL (tracing_cond_snapshot_data); +int tracing_snapshot_cond_enable (struct trace_array *tr,void *cond_data,cond_update_fn_t update) +{ +return -ENODEV ; +} +EXPORT_SYMBOL_GPL (tracing_snapshot_cond_enable); +int tracing_snapshot_cond_disable (struct trace_array *tr) +{ +return false; +} +EXPORT_SYMBOL_GPL (tracing_snapshot_cond_disable);#endif /* CONFIG_TRACER_SNAPSHOT */ void tracer_tracing_off (struct trace_array *tr)
@@ -1354,12 +1513,14 @@ __update_max_tr(struct trace_array *tr, struct task_struct *tsk, int cpu)* @tr: tracer * @tsk: the task with the latency * @cpu: The cpu that initiated the trace. +* @cond_data: User data associated with a conditional snapshot * * Flip the buffers between the @tr and the max_tr and record information * about which task was the cause of this latency. */ void -update_max_tr (struct trace_array *tr,struct task_struct *tsk,int cpu) +update_max_tr (struct trace_array *tr,struct task_struct *tsk,int cpu, +void *cond_data) {if (tr->stop_count)return ;
@@ -1380,9 +1541,15 @@ update_max_tr(struct trace_array *tr, struct task_struct *tsk, int cpu)else ring_buffer_record_off (tr->max_buffer.buffer); +#ifdef CONFIG_TRACER_SNAPSHOT +if (tr->cond_snapshot && !tr->cond_snapshot->update (tr, cond_data)) + goto out_unlock; +#endif swap (tr->trace_buffer.buffer, tr->max_buffer.buffer);__update_max_tr (tr, tsk, cpu); + + out_unlock:arch_spin_unlock (&tr->max_lock); }
@@ -5396,6 +5563,16 @@ static int tracing_set_tracer(struct trace_array *tr, const char *buf)if (t == tr->current_trace) goto out; +#ifdef CONFIG_TRACER_SNAPSHOT +if (t->use_max_tr) { +arch_spin_lock (&tr->max_lock); +if (tr->cond_snapshot) + ret = -EBUSY ; +arch_spin_unlock (&tr->max_lock); +if (ret) + goto out; + } +#endif /* Some tracers won't work on kernel command line */ if (system_state <SYSTEM_RUNNING && t->noboot) { pr_warn("Tracer '%s' is not allowed on command line, ignored\n",
@@ -6478,6 +6655,13 @@ tracing_snapshot_write(struct file *filp, const char __user *ubuf, size_t cnt, goto out; } +arch_spin_lock (&tr->max_lock); +if (tr->cond_snapshot) + ret = -EBUSY ; +arch_spin_unlock (&tr->max_lock); +if (ret) + goto out; +switch (val) {case 0 :if (iter->cpu_file !=RING_BUFFER_ALL_CPUS ) {
@@ -6503,7 +6687,7 @@ tracing_snapshot_write(struct file *filp, const char __user *ubuf, size_t cnt,local_irq_disable ();/* Now, we're going to swap */ if (iter->cpu_file ==RING_BUFFER_ALL_CPUS ) -update_max_tr (tr, current,smp_processor_id ()); +update_max_tr (tr, current,smp_processor_id (),NULL );else update_max_tr_single (tr, current, iter->cpu_file);local_irq_enable ();
kernel/trace/trace.h +55 -1
80 lines not on this page · raw message
kernel/trace/trace_sched_wakeup.c +1 -1
@@ -482,7 +482,7 @@ probe_wakeup_sched_switch(void *ignore, bool preempt,if (likely (!is_tracing_stopped ())) { wakeup_trace->max_latency = delta; -update_max_tr (wakeup_trace, wakeup_task, wakeup_cpu); +update_max_tr (wakeup_trace, wakeup_task, wakeup_cpu,NULL ); } out_unlock:
Signature · 1 line
2.14.1
Steven Rostedt
maintainerRe: [PATCH v15 05/15] tracing: Add conditional snapshot
Quoted 45 lines · On Wed, 13 Feb 2019 17:42:45 -0600 Tom Zanussi <[email protected]> wrote:
(quoted diff) +45
-0+ +/** + * tracing_snapshot_cond_enable - enable conditional snapshot for an instance + * @tr: The tracing instance + * @cond_data: User data to associate with the snapshot + * @update: Implementation of the cond_snapshot update function + * + * Check whether the conditional snapshot for the given instance has + * already been enabled, or if the current tracer is already using a + * snapshot; if so, return -EBUSY, else create a cond_snapshot and + * save the cond_data and update function inside. + * + * Returns 0 if successful, error otherwise. + */ +int tracing_snapshot_cond_enable(struct trace_array *tr, void *cond_data, + cond_update_fn_t update) +{ + struct cond_snapshot *cond_snapshot; + int ret = 0; + + cond_snapshot = kzalloc(sizeof(*cond_snapshot), GFP_KERNEL); + if (!cond_snapshot) + return -ENOMEM; + + cond_snapshot->cond_data = cond_data; + cond_snapshot->update = update; + + mutex_lock(&trace_types_lock); + + ret = tracing_alloc_snapshot_instance(tr); + if (ret) + goto fail_unlock; + + if (tr->current_trace->use_max_tr) { + ret = -EBUSY; + goto fail_unlock; + } + + if (tr->cond_snapshot) { + ret = -EBUSY; + goto fail_unlock; + } + + arch_spin_lock(&tr->max_lock); + tr->cond_snapshot = cond_snapshot;
Review
Quoted 10 lines
(quoted diff) +10
-0+ arch_spin_unlock(&tr->max_lock); + + mutex_unlock(&trace_types_lock); + + return ret; + + fail_unlock: + mutex_unlock(&trace_types_lock); + kfree(cond_snapshot); + return ret;
Some whitespace damage here. No need to resend, I fixed it.
Review
Quoted 3 lines
(quoted diff) +3
-0+} +EXPORT_SYMBOL_GPL(tracing_snapshot_cond_enable); +
I also added this change on top of your series.
kernel/trace/trace.c +8 -0
@@ -1116,6 +1116,14 @@ int tracing_snapshot_cond_enable(struct trace_array *tr, void *cond_data, goto fail_unlock; } +/* +* The cond_snapshot can only change to NULL without the +* trace_types_lock. We don't care if we race with it going +* to NULL, but we want to make sure that it's not set to +* something other than NULL when we get here, which we can +* do safely with only holding the trace_types_lock and not +* having to take the max_lock. +*/ if (tr->cond_snapshot) { ret = -EBUSY ; goto fail_unlock;
I'll start testing your series now.
Thanks!
-- Steve
Re: [PATCH v15 05/15] tracing: Add conditional snapshot
Hi Steve,
Quoted 58 lines · Steven Rostedt
Quoted 55 lines · On Wed, 13 Feb 2019 17:42:45 -0600 Tom Zanussi <[email protected]> wrote:
(quoted diff) +3
-0+ +/** + * tracing_snapshot_cond_enable - enable conditional snapshot foran instance
+ * @tr: The tracing instance
+ * @cond_data: User data to associate with the snapshot
+ * @update: Implementation of thecond_snapshotupdate
function
+ *
+ * Check whether the conditional snapshot for the given instance has
+ * already been enabled, or if the current tracer is already using a
+ * snapshot; if so, return-EBUSY, else create acond_snapshotand
+ * save thecond_dataand update function inside.
+ *
+ * Returns 0 if successful, error otherwise.
+ */
+int tracing_snapshot_cond_enable(structtrace_array*tr, void*cond_data,(quoted diff) +6
-0+ cond_update_fn_t update) +{ + struct cond_snapshot *cond_snapshot; + int ret = 0; + + cond_snapshot = kzalloc(sizeof(*cond_snapshot),
GFP_KERNEL);(quoted diff) +28
-0+ if (!cond_snapshot) + return -ENOMEM; + + cond_snapshot->cond_data = cond_data; + cond_snapshot->update = update; + + mutex_lock(&trace_types_lock); + + ret = tracing_alloc_snapshot_instance(tr); + if (ret) + goto fail_unlock; + + if (tr->current_trace->use_max_tr) { + ret = -EBUSY; + goto fail_unlock; + } + + if (tr->cond_snapshot) { + ret = -EBUSY; + goto fail_unlock; + } + + arch_spin_lock(&tr->max_lock); + tr->cond_snapshot = cond_snapshot; + arch_spin_unlock(&tr->max_lock); + + mutex_unlock(&trace_types_lock); +
Quoted 9 lines
Review
Quoted 6 lines
(quoted diff) +6
-0+ return ret; + + fail_unlock: + mutex_unlock(&trace_types_lock); + kfree(cond_snapshot); + return ret;Some whitespace damage here. No need to resend, I fixed it.
OK, thanks.
Quoted 26 lines
Review
Quoted 4 lines
(quoted diff) +3
-0+} +EXPORT_SYMBOL_GPL(tracing_snapshot_cond_enable); +I also added this change on top of your series.
kernel/trace/trace.c +8
-0@@ -1116,6 +1116,14 @@ int tracing_snapshot_cond_enable(struct trace_array *tr, void *cond_data, goto fail_unlock; } +/* +* The cond_snapshot can only change to NULL without the +* trace_types_lock. We don't care if we race with it going +* to NULL, but we want to make sure that it's not set to +* something other than NULL when we get here, which we can +* do safely with only holding the trace_types_lock and not +* having to take the max_lock. +*/ if (tr->cond_snapshot) { ret = -EBUSY ;
Quoted 2 lines
goto
fail_unlock;
Looks good, thanks for adding that back.
Tom
Quoted 6 lines
I'll start testing your series now.
Thanks!
-- Steve
PATCH v15 6/15 tracing: Add hist trigger snapshot() action
In reply to Tom ZanussiFrom: Tom Zanussi <[email protected]>
Add support for hist:handlerXXX($var).snapshot(), which will take a snapshot of the current trace buffer whenever handlerXXX is hit.
As a first user, this also adds snapshot() action support for the onmax() handler i.e. hist:onmax($var).snapshot().
Also, the hist trigger key printing is moved into a separate function so the snapshot() action can print a histogram key outside the histogram display - add and use hist_trigger_print_key() for that purpose.
--- kernel/trace/trace.c | 3 + kernel/trace/trace_events_hist.c | 266 +++++++++++++++++++++++++++++++++++++-- 2 files changed, 259 insertions(+), 10 deletions(-)
kernel/trace/trace.c +3 -0
@@ -4919,6 +4919,9 @@ static const char readme_msg[] ="\t The available actions are:\n\n" "\t <synthetic_event>(param list) - generate synthetic event\n" "\t save(field,...) - save current event fields\n" +#ifdef CONFIG_TRACER_SNAPSHOT + "\t snapshot() - snapshot the trace buffer\n" +#endif #endif ;
kernel/trace/trace_events_hist.c +256 -10
347 lines not on this page · raw message
Signature · 1 line
2.14.1
PATCH v15 7/15 tracing: Add hist trigger snapshot() action Documentation
In reply to Tom ZanussiFrom: Tom Zanussi <[email protected]>
Add Documentation for the hist:handlerXXX($var).snapshot() action.
--- Documentation/trace/histogram.rst | 110 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 110 insertions(+)
Documentation/trace/histogram.rst +110 -0
@@ -1874,6 +1874,7 @@ The available actions are: - <synthetic_event_name>(param list) - generate synthetic event - save(field,...) - save current event fields + - snapshot() - snapshot the trace buffer The following commonly-used handler.action pairs are available:
@@ -2030,6 +2031,115 @@ The following commonly-used handler.action pairs are available: Entries: 2 Dropped: 0 + - onmax(var).snapshot() + + The 'onmax(var).snapshot()' hist trigger action is invoked + whenever the value of 'var' associated with a histogram entry + exceeds the current maximum contained in that variable. + + The end result is that a global snapshot of the trace buffer will + be saved in the tracing/snapshot file if 'var' exceeds the current + maximum for any hist trigger entry. + + Note that in this case the maximum is a global maximum for the + current trace instance, which is the maximum across all buckets of + the histogram. The key of the specific trace event that caused + the global maximum and the global maximum itself are displayed, + along with a message stating that a snapshot has been taken and + where to find it. The user can use the key information displayed + to locate the corresponding bucket in the histogram for even more + detail. + + As an example the below defines a couple of hist triggers, one for + sched_waking and another for sched_switch, keyed on pid. Whenever + a sched_waking event occurs, the timestamp is saved in the entry + corresponding to the current pid, and when the scheduler switches + back to that pid, the timestamp difference is calculated. If the + resulting latency, stored in wakeup_lat, exceeds the current + maximum latency, a snapshot is taken. As part of the setup, all + the scheduler events are also enabled, which are the events that + will show up in the snapshot when it is taken at some point: + + # echo 1 > /sys/kernel/debug/tracing/events/sched/enable + + # echo 'hist:keys=pid:ts0=common_timestamp.usecs \ + if comm=="cyclictest"' >> \ + /sys/kernel/debug/tracing/events/sched/sched_waking/trigger + + # echo 'hist:keys=next_pid:wakeup_lat=common_timestamp.usecs-$ts0: \ + onmax($wakeup_lat).save(next_prio,next_comm,prev_pid,prev_prio, \ + prev_comm):onmax($wakeup_lat).snapshot() \ + if next_comm=="cyclictest"' >> \ + /sys/kernel/debug/tracing/events/sched/sched_switch/trigger + + When the histogram is displayed, for each bucket the max value + and the saved values corresponding to the max are displayed + following the rest of the fields. + + If a snaphot was taken, there is also a message indicating that, + along with the value and event that triggered the global maximum: + + # cat /sys/kernel/debug/tracing/events/sched/sched_switch/hist + { next_pid: 2101 } hitcount: 200 + max: 52 next_prio: 120 next_comm: cyclictest \ + prev_pid: 0 prev_prio: 120 prev_comm: swapper/6 + + { next_pid: 2103 } hitcount: 1326 + max: 572 next_prio: 19 next_comm: cyclictest \ + prev_pid: 0 prev_prio: 120 prev_comm: swapper/1 + + { next_pid: 2102 } hitcount: 1982 \ + max: 74 next_prio: 19 next_comm: cyclictest \ + prev_pid: 0 prev_prio: 120 prev_comm: swapper/5 + + Snapshot taken (see tracing/snapshot). Details: + triggering value { onmax($wakeup_lat) }: 572 \ + triggered by event with key: { next_pid: 2103 } + + Totals: + Hits: 3508 + Entries: 3 + Dropped: 0 + + In the above case, the event that triggered the global maximum has + the key with next_pid == 2103. If you look at the bucket that has + 2103 as the key, you'll find the additional values save()'d along + with the local maximum for that bucket, which should be the same + as the global maximum (since that was the same value that + triggered the global snapshot). + + And finally, looking at the snapshot data should show at or near + the end the event that triggered the snapshot (in this case you + can verify the timestamps between the sched_waking and + sched_switch events, which should match the time displayed in the + global maximum): + + # cat /sys/kernel/debug/tracing/snapshot + + <...>-2103 [005] d..3 309.873125: sched_switch: prev_comm=cyclictest prev_pid=2103 prev_prio=19 prev_state=D ==> next_comm=swapper/5 next_pid=0 next_prio=120 + <idle>-0 [005] d.h3 309.873611: sched_waking: comm=cyclictest pid=2102 prio=19 target_cpu=005 + <idle>-0 [005] dNh4 309.873613: sched_wakeup: comm=cyclictest pid=2102 prio=19 target_cpu=005 + <idle>-0 [005] d..3 309.873616: sched_switch: prev_comm=swapper/5 prev_pid=0 prev_prio=120 prev_state=S ==> next_comm=cyclictest next_pid=2102 next_prio=19 + <...>-2102 [005] d..3 309.873625: sched_switch: prev_comm=cyclictest prev_pid=2102 prev_prio=19 prev_state=D ==> next_comm=swapper/5 next_pid=0 next_prio=120 + <idle>-0 [005] d.h3 309.874624: sched_waking: comm=cyclictest pid=2102 prio=19 target_cpu=005 + <idle>-0 [005] dNh4 309.874626: sched_wakeup: comm=cyclictest pid=2102 prio=19 target_cpu=005 + <idle>-0 [005] dNh3 309.874628: sched_waking: comm=cyclictest pid=2103 prio=19 target_cpu=005 + <idle>-0 [005] dNh4 309.874630: sched_wakeup: comm=cyclictest pid=2103 prio=19 target_cpu=005 + <idle>-0 [005] d..3 309.874633: sched_switch: prev_comm=swapper/5 prev_pid=0 prev_prio=120 prev_state=S ==> next_comm=cyclictest next_pid=2102 next_prio=19 + <idle>-0 [004] d.h3 309.874757: sched_waking: comm=gnome-terminal- pid=1699 prio=120 target_cpu=004 + <idle>-0 [004] dNh4 309.874762: sched_wakeup: comm=gnome-terminal- pid=1699 prio=120 target_cpu=004 + <idle>-0 [004] d..3 309.874766: sched_switch: prev_comm=swapper/4 prev_pid=0 prev_prio=120 prev_state=S ==> next_comm=gnome-terminal- next_pid=1699 next_prio=120 + gnome-terminal--1699 [004] d.h2 309.874941: sched_stat_runtime: comm=gnome-terminal- pid=1699 runtime=180706 [ns] vruntime=1126870572 [ns] + <idle>-0 [003] d.s4 309.874956: sched_waking: comm=rcu_sched pid=9 prio=120 target_cpu=007 + <idle>-0 [003] d.s5 309.874960: sched_wake_idle_without_ipi: cpu=7 + <idle>-0 [003] d.s5 309.874961: sched_wakeup: comm=rcu_sched pid=9 prio=120 target_cpu=007 + <idle>-0 [007] d..3 309.874963: sched_switch: prev_comm=swapper/7 prev_pid=0 prev_prio=120 prev_state=S ==> next_comm=rcu_sched next_pid=9 next_prio=120 + rcu_sched-9 [007] d..3 309.874973: sched_stat_runtime: comm=rcu_sched pid=9 runtime=13646 [ns] vruntime=22531430286 [ns] + rcu_sched-9 [007] d..3 309.874978: sched_switch: prev_comm=rcu_sched prev_pid=9 prev_prio=120 prev_state=R+ ==> next_comm=swapper/7 next_pid=0 next_prio=120 + <...>-2102 [005] d..4 309.874994: sched_migrate_task: comm=cyclictest pid=2103 prio=19 orig_cpu=5 dest_cpu=1 + <...>-2102 [005] d..4 309.875185: sched_wake_idle_without_ipi: cpu=1 + <idle>-0 [001] d..3 309.875200: sched_switch: prev_comm=swapper/1 prev_pid=0 prev_prio=120 prev_state=S ==> next_comm=cyclictest next_pid=2103 next_prio=19 + 3. User space creating a trigger --------------------------------
Signature · 1 line
2.14.1
PATCH v15 8/15 tracing: Add hist trigger onchange() handler
In reply to Tom ZanussiFrom: Tom Zanussi <[email protected]>
Add support for a hist:onchange($var) handler, similar to the onmax() handler but triggering whenever there's any change in $var, not just a max.
--- kernel/trace/trace.c | 3 ++- kernel/trace/trace_events_hist.c | 58 ++++++++++++++++++++++++++++++++++------ 2 files changed, 52 insertions(+), 9 deletions(-)
kernel/trace/trace.c +2 -1
@@ -4915,7 +4915,8 @@ static const char readme_msg[] ="\t <handler>.<action>\n\n" "\t The available handlers are:\n\n" "\t onmatch(matching.event) - invoke on addition or update\n" -"\t onmax(var) - invoke if var exceeds current max\n\n" +"\t onmax(var) - invoke if var exceeds current max\n" +"\t onchange(var) - invoke action if var changes\n\n" "\t The available actions are:\n\n" "\t <synthetic_event>(param list) - generate synthetic event\n" "\t save(field,...) - save current event fields\n"
kernel/trace/trace_events_hist.c +50 -8
160 lines not on this page · raw message
Signature · 1 line
2.14.1
PATCH v15 9/15 tracing: Add hist trigger onchange() handler Documentation
In reply to Tom ZanussiFrom: Tom Zanussi <[email protected]>
Add Documentation for the hist:onchange($var) handler.
--- Documentation/trace/histogram.rst | 98 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 98 insertions(+)
Documentation/trace/histogram.rst +98 -0
@@ -1869,6 +1869,7 @@ The available handlers are: - onmatch(matching.event) - invoke action on any addition or update - onmax(var) - invoke action if var exceeds current max + - onchange(var) - invoke action if var changes The available actions are:
@@ -2140,6 +2141,103 @@ The following commonly-used handler.action pairs are available: <...>-2102 [005] d..4 309.875185: sched_wake_idle_without_ipi: cpu=1 <idle>-0 [001] d..3 309.875200: sched_switch: prev_comm=swapper/1 prev_pid=0 prev_prio=120 prev_state=S ==> next_comm=cyclictest next_pid=2103 next_prio=19 + - onchange(var).save(field,.. .) + + The 'onchange(var).save(field,...)' hist trigger action is invoked + whenever the value of 'var' associated with a histogram entry + changes. + + The end result is that the trace event fields specified as the + onchange.save() params will be saved if 'var' changes for that + hist trigger entry. This allows context from the event that + changed the value to be saved for later reference. When the + histogram is displayed, additional fields displaying the saved + values will be printed. + + - onchange(var).snapshot() + + The 'onchange(var).snapshot()' hist trigger action is invoked + whenever the value of 'var' associated with a histogram entry + changes. + + The end result is that a global snapshot of the trace buffer will + be saved in the tracing/snapshot file if 'var' changes for any + hist trigger entry. + + Note that in this case the changed value is a global variable + associated withe current trace instance. The key of the specific + trace event that caused the value to change and the global value + itself are displayed, along with a message stating that a snapshot + has been taken and where to find it. The user can use the key + information displayed to locate the corresponding bucket in the + histogram for even more detail. + + As an example the below defines a hist trigger on the tcp_probe + event, keyed on dport. Whenever a tcp_probe event occurs, the + cwnd field is checked against the current value stored in the + $cwnd variable. If the value has changed, a snapshot is taken. + As part of the setup, all the scheduler and tcp events are also + enabled, which are the events that will show up in the snapshot + when it is taken at some point: + + # echo 1 > /sys/kernel/debug/tracing/events/sched/enable + # echo 1 > /sys/kernel/debug/tracing/events/tcp/enable + + # echo 'hist:keys=dport:cwnd=snd_cwnd: \ + onchange($cwnd).save(snd_wnd,srtt,rcv_wnd): \ + onchange($cwnd).snapshot()' >> \ + /sys/kernel/debug/tracing/events/tcp/tcp_probe/trigger + + When the histogram is displayed, for each bucket the tracked value + and the saved values corresponding to that value are displayed + following the rest of the fields. + + If a snaphot was taken, there is also a message indicating that, + along with the value and event that triggered the snapshot: + + # cat /sys/kernel/debug/tracing/events/tcp/tcp_probe/hist + { dport: 1521 } hitcount: 8 + changed: 10 snd_wnd: 35456 srtt: 154262 rcv_wnd: 42112 + + { dport: 80 } hitcount: 23 + changed: 10 snd_wnd: 28960 srtt: 19604 rcv_wnd: 29312 + + { dport: 9001 } hitcount: 172 + changed: 10 snd_wnd: 48384 srtt: 260444 rcv_wnd: 55168 + + { dport: 443 } hitcount: 211 + changed: 10 snd_wnd: 26960 srtt: 17379 rcv_wnd: 28800 + + Snapshot taken (see tracing/snapshot). Details: + triggering value { onchange($cwnd) }: 10 + triggered by event with key: { dport: 80 } + + Totals: + Hits: 414 + Entries: 4 + Dropped: 0 + + In the above case, the event that triggered the snapshot has the + key with dport == 80. If you look at the bucket that has 80 as + the key, you'll find the additional values save()'d along with the + changed value for that bucket, which should be the same as the + global changed value (since that was the same value that triggered + the global snapshot). + + And finally, looking at the snapshot data should show at or near + the end the event that triggered the snapshot: + + # cat /sys/kernel/debug/tracing/snapshot + + gnome-shell-1261 [006] dN.3 49.823113: sched_stat_runtime: comm=gnome-shell pid=1261 runtime=49347 [ns] vruntime=1835730389 [ns] + kworker/u16:4-773 [003] d..3 49.823114: sched_switch: prev_comm=kworker/u16:4 prev_pid=773 prev_prio=120 prev_state=R+ ==> next_comm=kworker/3:2 next_pid=135 next_prio=120 + gnome-shell-1261 [006] d..3 49.823114: sched_switch: prev_comm=gnome-shell prev_pid=1261 prev_prio=120 prev_state=R+ ==> next_comm=kworker/6:2 next_pid=387 next_prio=120 + kworker/3:2-135 [003] d..3 49.823118: sched_stat_runtime: comm=kworker/3:2 pid=135 runtime=5339 [ns] vruntime=17815800388 [ns] + kworker/6:2-387 [006] d..3 49.823120: sched_stat_runtime: comm=kworker/6:2 pid=387 runtime=9594 [ns] vruntime=14589605367 [ns] + kworker/6:2-387 [006] d..3 49.823122: sched_switch: prev_comm=kworker/6:2 prev_pid=387 prev_prio=120 prev_state=R+ ==> next_comm=gnome-shell next_pid=1261 next_prio=120 + kworker/3:2-135 [003] d..3 49.823123: sched_switch: prev_comm=kworker/3:2 prev_pid=135 prev_prio=120 prev_state=T ==> next_comm=swapper/3 next_pid=0 next_prio=120 + <idle>-0 [004] ..s7 49.823798: tcp_probe: src=10.0.0.10:54326 dest=23.215.104.193:80 mark=0x0 length=32 snd_nxt=0xe3ae2ff5 snd_una=0xe3ae2ecd snd_cwnd=10 ssthresh=2147483647 snd_wnd=28960 srtt=19604 rcv_wnd=29312 + 3. User space creating a trigger --------------------------------
Signature · 1 line
2.14.1
PATCH v15 10/15 tracing: Add alternative synthetic event trace action syntax
In reply to Tom ZanussiFrom: Tom Zanussi <[email protected]>
Add a 'trace(synthetic_event_name, params)' alternative to synthetic_event_name(params).
Currently, the syntax used for generating synthetic events is to invoke synthetic_event_name(params) i.e. use the synthetic event name as a function call.
Users requested a new form that more explicitly shows that the synthetic event is in effect being traced. In this version, a new 'trace()' keyword is used, and the synthetic event name is passed in as the first argument.
In addition, for the sake of consistency with other actions, change the documention to emphasize the trace() form over the function-call form, which remains documented as equivalent.
--- Documentation/trace/histogram.rst | 54 +++++++++++++++++++++++++++------------ kernel/trace/trace.c | 2 +- kernel/trace/trace_events_hist.c | 42 +++++++++++++++++++++++++++--- 3 files changed, 76 insertions(+), 22 deletions(-)
Documentation/trace/histogram.rst +37 -17
@@ -1873,31 +1873,45 @@ The available handlers are: The available actions are: - - <synthetic_event_name>(param list) - generate synthetic event + - trace(<synthetic_event_name>,param list) - generate synthetic event - save(field,...) - save current event fields - snapshot() - snapshot the trace buffer The following commonly-used handler.action pairs are available: - - onmatch(matching.event).<synthetic_event_name>(param list) + - onmatch(matching.event).trace(<synthetic_event_name>,param list) - The 'onmatch(matching.event).<synthetic_event_name>(params)' hist - trigger action is invoked whenever an event matches and the - histogram entry would be added or updated. It causes the named - synthetic event to be generated with the values given in the + The 'onmatch(matching.event).trace(<synthetic_event_name>,param + list)' hist trigger action is invoked whenever an event matches + and the histogram entry would be added or updated. It causes the + named synthetic event to be generated with the values given in the 'param list'. The result is the generation of a synthetic event that consists of the values contained in those variables at the - time the invoking event was hit. - - The 'param list' consists of one or more parameters which may be - either variables or fields defined on either the 'matching.event' - or the target event. The variables or fields specified in the - param list may be either fully-qualified or unqualified. If a - variable is specified as unqualified, it must be unique between - the two events. A field name used as a param can be unqualified - if it refers to the target event, but must be fully qualified if - it refers to the matching event. A fully-qualified name is of the - form 'system.event_name.$var_name' or 'system.event_name.field'. + time the invoking event was hit. For example, if the synthetic + event name is 'wakeup_latency', a wakeup_latency event is + generated using onmatch(event).trace(wakeup_latency,arg1,arg2). + + There is also an equivalent alternative form available for + generating synthetic events. In this form, the synthetic event + name is used as if it were a function name. For example, using + the 'wakeup_latency' synthetic event name again, the + wakeup_latency event would be generated by invoking it as if it + were a function call, with the event field values passed in as + arguments: onmatch(event).wakeup_latency(arg1,arg2). The syntax + for this form is: + + onmatch(matching.event).<synthetic_event_name>(param list) + + In either case, the 'param list' consists of one or more + parameters which may be either variables or fields defined on + either the 'matching.event' or the target event. The variables or + fields specified in the param list may be either fully-qualified + or unqualified. If a variable is specified as unqualified, it + must be unique between the two events. A field name used as a + param can be unqualified if it refers to the target event, but + must be fully qualified if it refers to the matching event. A + fully-qualified name is of the form 'system.event_name.$var_name' + or 'system.event_name.field'. The 'matching.event' specification is simply the fully qualified event name of the event that matches the target event for the
@@ -1928,6 +1942,12 @@ The following commonly-used handler.action pairs are available: wakeup_new_test($testpid) if comm=="cyclictest"' >> \ /sys/kernel/debug/tracing/events/sched/sched_wakeup_new/trigger + Or, equivalently, using the 'trace' keyword syntax: + + # echo 'hist:keys=$testpid:testpid=pid:onmatch(sched.sched_wakeup_new).\ + trace(wakeup_new_test,$testpid) if comm=="cyclictest"' >> \ + /sys/kernel/debug/tracing/events/sched/sched_wakeup_new/trigger + Creating and displaying a histogram based on those events is now just a matter of using the fields and new synthetic event in the tracing/events/synthetic directory, as usual::
kernel/trace/trace.c +1 -1
@@ -4918,7 +4918,7 @@ static const char readme_msg[] ="\t onmax(var) - invoke if var exceeds current max\n" "\t onchange(var) - invoke action if var changes\n\n" "\t The available actions are:\n\n" -"\t <synthetic_event>(param list) - generate synthetic event\n" +"\t trace(<synthetic_event>,param list) - generate synthetic event\n" "\t save(field,...) - save current event fields\n" #ifdef CONFIG_TRACER_SNAPSHOT"\t snapshot() - snapshot the trace buffer\n"
kernel/trace/trace_events_hist.c +38 -4
102 lines not on this page · raw message
Signature · 1 line
2.14.1
PATCH v15 11/15 tracing: Add SPDX license GPL-2.0 license identifier to inter-event testcases
In reply to Tom ZanussiFrom: Tom Zanussi <[email protected]>
Apparently this directory was missed in the license cleanup process - add the missing identifiers to the trigger/inter-event test cases.
--- .../ftrace/test.d/trigger/inter-event/trigger-extended-error-support.tc | 1 + .../ftrace/test.d/trigger/inter-event/trigger-field-variable-support.tc | 1 + .../test.d/trigger/inter-event/trigger-inter-event-combined-hist.tc | 1 + .../ftrace/test.d/trigger/inter-event/trigger-multi-actions-accept.tc | 1 + .../ftrace/test.d/trigger/inter-event/trigger-onmatch-action-hist.tc | 1 + .../test.d/trigger/inter-event/trigger-onmatch-onmax-action-hist.tc | 1 + .../ftrace/test.d/trigger/inter-event/trigger-onmax-action-hist.tc | 1 + .../test.d/trigger/inter-event/trigger-synthetic-event-createremove.tc | 1 + 8 files changed, 8 insertions(+)
tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-extended-error-support.tc +1 -0
@@ -1,4 +1,5 @@ #!/bin/sh +# SPDX-License-Identifier: GPL-2.0 # description: event trigger - test extended error support
tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-field-variable-support.tc +1 -0
@@ -1,4 +1,5 @@ #!/bin/sh +# SPDX-License-Identifier: GPL-2.0 # description: event trigger - test field variable support fail() { #msg
tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-inter-event-combined-hist.tc +1 -0
@@ -1,4 +1,5 @@ #!/bin/sh +# SPDX-License-Identifier: GPL-2.0 # description: event trigger - test inter-event combined histogram trigger fail() { #msg
tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-multi-actions-accept.tc +1 -0
@@ -1,4 +1,5 @@ #!/bin/sh +# SPDX-License-Identifier: GPL-2.0 # description: event trigger - test multiple actions on hist trigger fail() { #msg
tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onmatch-action-hist.tc +1 -0
@@ -1,4 +1,5 @@ #!/bin/sh +# SPDX-License-Identifier: GPL-2.0 # description: event trigger - test inter-event histogram trigger onmatch action fail() { #msg
tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onmatch-onmax-action-hist.tc +1 -0
@@ -1,4 +1,5 @@ #!/bin/sh +# SPDX-License-Identifier: GPL-2.0 # description: event trigger - test inter-event histogram trigger onmatch-onmax action fail() { #msg
tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onmax-action-hist.tc +1 -0
@@ -1,4 +1,5 @@ #!/bin/sh +# SPDX-License-Identifier: GPL-2.0 # description: event trigger - test inter-event histogram trigger onmax action fail() { #msg
tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-event-createremove.tc +1 -0
@@ -1,4 +1,5 @@ #!/bin/sh +# SPDX-License-Identifier: GPL-2.0 # description: event trigger - test synthetic event create remove fail() { #msg
Signature · 1 line
2.14.1
PATCH v15 12/15 tracing: Add hist trigger snapshot() action test case
In reply to Tom ZanussiFrom: Tom Zanussi <[email protected]>
Add a test case verifying the basic functionality of the hist:snapshot() action.
--- .../inter-event/trigger-snapshot-action-hist.tc | 43 ++++++++++++++++++++++ 1 file changed, 43 insertions(+) create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-snapshot-action-hist.tc
tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-snapshot-action-hist.tc new file +43 -0
@@ -0,0 +1,43 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 +# description: event trigger - test inter-event histogram trigger snapshot action + +fail() { #msg + echo $1 + exit_fail +} + +if [ ! -f set_event ]; then + echo "event tracing is not supported" + exit_unsupported +fi + +if [ ! -f snapshot ]; then + echo "snapshot is not supported" + exit_unsupported +fi + +grep -q "onchange(var)" README || exit_unsupported # version issue + +grep -q "snapshot()" README || exit_unsupported # version issue + +echo "Test snapshot action" + +echo 1 > /sys/kernel/debug/tracing/events/sched/enable + +echo 'hist:keys=comm:newprio=prio:onchange($newprio).save(comm,prio):onchange($newprio).snapshot() if comm=="ping"' >> /sys/kernel/debug/tracing/events/sched/sched_waking/trigger + +ping $LOCALHOST -c 3 +nice -n 1 ping $LOCALHOST -c 3 + +echo 0 > tracing_on + +if ! grep -q "changed:" events/sched/sched_waking/hist; then + fail "Failed to create onchange action inter-event histogram" +fi + +if ! grep -q "comm=ping" snapshot; then + fail "Failed to create snapshot action inter-event histogram" +fi + +exit 0
Signature · 1 line
2.14.1
PATCH v15 13/15 tracing: Add hist trigger onchange() handler test case
In reply to Tom ZanussiFrom: Tom Zanussi <[email protected]>
Add a test case verifying the basic functionality of the hist:onchange($var) handler.
--- .../inter-event/trigger-onchange-action-hist.tc | 28 ++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onchange-action-hist.tc
tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onchange-action-hist.tc new file +28 -0
@@ -0,0 +1,28 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 +# description: event trigger - test inter-event histogram trigger onchange action + +fail() { #msg + echo $1 + exit_fail +} + +if [ ! -f set_event ]; then + echo "event tracing is not supported" + exit_unsupported +fi + +grep -q "onchange(var)" README || exit_unsupported # version issue + +echo "Test onchange action" + +echo 'hist:keys=comm:newprio=prio:onchange($newprio).save(comm,prio) if comm=="ping"' >> /sys/kernel/debug/tracing/events/sched/sched_waking/trigger + +ping $LOCALHOST -c 3 +nice -n 1 ping $LOCALHOST -c 3 + +if ! grep -q "changed:" events/sched/sched_waking/hist; then + fail "Failed to create onchange action inter-event histogram" +fi + +exit 0
Signature · 1 line
2.14.1
PATCH v15 14/15 tracing: Add alternative synthetic event trace action test case
In reply to Tom ZanussiFrom: Tom Zanussi <[email protected]>
Add a test case for the alternative trace(<synthetic_event, params) synthetic event generation syntax.
--- .../inter-event/trigger-trace-action-hist.tc | 42 ++++++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-trace-action-hist.tc
tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-trace-action-hist.tc new file +42 -0
@@ -0,0 +1,42 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 +# description: event trigger - test inter-event histogram trigger trace action + +fail() { #msg + echo $1 + exit_fail +} + +if [ ! -f set_event ]; then + echo "event tracing is not supported" + exit_unsupported +fi + +if [ ! -f synthetic_events ]; then + echo "synthetic event is not supported" + exit_unsupported +fi + +grep -q "trace(<synthetic_event>" README || exit_unsupported # version issue + +echo "Test create synthetic event" + +echo 'wakeup_latency u64 lat pid_t pid char comm[16]' > synthetic_events +if [ ! -d events/synthetic/wakeup_latency ]; then + fail "Failed to create wakeup_latency synthetic event" +fi + +echo "Test create histogram for synthetic event using trace action" +echo "Test histogram variables,simple expression support and trace action" + +echo 'hist:keys=pid:ts0=common_timestamp.usecs if comm=="ping"' > events/sched/sched_wakeup/trigger +echo 'hist:keys=next_pid:wakeup_lat=common_timestamp.usecs-$ts0:onmatch(sched.sched_wakeup).trace(wakeup_latency,$wakeup_lat,next_pid,next_comm) if next_comm=="ping"' > events/sched/sched_switch/trigger +echo 'hist:keys=comm,pid,lat:wakeup_lat=lat:sort=lat' > events/synthetic/wakeup_latency/trigger + +ping $LOCALHOST -c 5 + +if ! grep -q "ping" events/synthetic/wakeup_latency/hist; then + fail "Failed to create trace action inter-event histogram" +fi + +exit 0
Signature · 1 line
2.14.1
Re: [PATCH v15 14/15] tracing: Add alternative synthetic event trace action test case
Hi Tom,
Quoted 6 lines · On Wed, 13 Feb 2019 17:42:54 -0600 Tom Zanussi <[email protected]> wrote:
From: Tom Zanussi <[email protected]>
Add a test case for the alternative
trace(<synthetic_event, params)synthetic event generation syntax.Signed-off-by Tom Zanussi <[email protected]>
This looks good to me.
Thank you!
Quoted 56 lines
--- .../inter-event/trigger-trace-action-hist.tc | 42 ++++++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-trace-action-hist.tctools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-trace-action-hist.tc new file +42
-0@@ -0,0 +1,42 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 +# description: event trigger - test inter-event histogram trigger trace action + +fail() { #msg + echo $1 + exit_fail +} + +if [ ! -f set_event ]; then + echo "event tracing is not supported" + exit_unsupported +fi + +if [ ! -f synthetic_events ]; then + echo "synthetic event is not supported" + exit_unsupported +fi + +grep -q "trace(<synthetic_event>" README || exit_unsupported # version issue + +echo "Test create synthetic event" + +echo 'wakeup_latency u64 lat pid_t pid char comm[16]' > synthetic_events +if [ ! -d events/synthetic/wakeup_latency ]; then + fail "Failed to create wakeup_latency synthetic event" +fi + +echo "Test create histogram for synthetic event using trace action" +echo "Test histogram variables,simple expression support and trace action" + +echo 'hist:keys=pid:ts0=common_timestamp.usecs if comm=="ping"' > events/sched/sched_wakeup/trigger +echo 'hist:keys=next_pid:wakeup_lat=common_timestamp.usecs-$ts0:onmatch(sched.sched_wakeup).trace(wakeup_latency,$wakeup_lat,next_pid,next_comm) if next_comm=="ping"' > events/sched/sched_switch/trigger +echo 'hist:keys=comm,pid,lat:wakeup_lat=lat:sort=lat' > events/synthetic/wakeup_latency/trigger + +ping $LOCALHOST -c 5 + +if ! grep -q "ping" events/synthetic/wakeup_latency/hist; then + fail "Failed to create trace action inter-event histogram" +fi + +exit 0Signature · 1 line
2.14.1
Signature · 1 line
Masami Hiramatsu <[email protected]>
PATCH v15 15/15 tracing: Add hist trigger action 'expected fail' test case
In reply to Tom ZanussiFrom: Tom Zanussi <[email protected]>
Add a test case verifying that basic action combinations fail as expected.
--- .../inter-event/trigger-action-hist-xfail.tc | 30 ++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-action-hist-xfail.tc
tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-action-hist-xfail.tc new file +30 -0
@@ -0,0 +1,30 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 +# description: event trigger - test inter-event histogram trigger expected fail actions + +fail() { #msg + echo $1 + exit_fail +} + +if [ ! -f set_event ]; then + echo "event tracing is not supported" + exit_unsupported +fi + +if [ ! -f snapshot ]; then + echo "snapshot is not supported" + exit_unsupported +fi + +grep -q "snapshot()" README || exit_unsupported # version issue + +echo "Test expected snapshot action failure" + +echo 'hist:keys=comm:onmatch(sched.sched_wakeup).snapshot()' >> /sys/kernel/debug/tracing/events/sched/sched_waking/trigger && exit_fail + +echo "Test expected save action failure" + +echo 'hist:keys=comm:onmatch(sched.sched_wakeup).save(comm,prio)' >> /sys/kernel/debug/tracing/events/sched/sched_waking/trigger && exit_fail + +exit_xfail
Signature · 1 line
2.14.1
Re: [PATCH v15 15/15] tracing: Add hist trigger action 'expected fail' test case
Hi Tom,
Quoted 6 lines · On Wed, 13 Feb 2019 17:42:55 -0600 Tom Zanussi <[email protected]> wrote:
From: Tom Zanussi <[email protected]>
Add a test case verifying that basic action combinations fail as expected.
Signed-off-by Tom Zanussi <[email protected]>
This looks good to me.
Thank you!
Quoted 44 lines
--- .../inter-event/trigger-action-hist-xfail.tc | 30 ++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-action-hist-xfail.tctools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-action-hist-xfail.tc new file +30
-0@@ -0,0 +1,30 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 +# description: event trigger - test inter-event histogram trigger expected fail actions + +fail() { #msg + echo $1 + exit_fail +} + +if [ ! -f set_event ]; then + echo "event tracing is not supported" + exit_unsupported +fi + +if [ ! -f snapshot ]; then + echo "snapshot is not supported" + exit_unsupported +fi + +grep -q "snapshot()" README || exit_unsupported # version issue + +echo "Test expected snapshot action failure" + +echo 'hist:keys=comm:onmatch(sched.sched_wakeup).snapshot()' >> /sys/kernel/debug/tracing/events/sched/sched_waking/trigger && exit_fail + +echo "Test expected save action failure" + +echo 'hist:keys=comm:onmatch(sched.sched_wakeup).save(comm,prio)' >> /sys/kernel/debug/tracing/events/sched/sched_waking/trigger && exit_fail + +exit_xfailSignature · 1 line
2.14.1
Signature · 1 line
Masami Hiramatsu <[email protected]>
Steven Rostedt
maintainerRe: [PATCH v15 15/15] tracing: Add hist trigger action 'expected fail' test case
Quoted 7 lines · On Sat, 16 Feb 2019 00:08:14 +0900 Masami Hiramatsu <[email protected]> wrote:
Hi Tom,
Quoted 2 lines · On Wed, 13 Feb 2019 17:42:55 -0600 Tom Zanussi <[email protected]> wrote:
From: Tom Zanussi <[email protected]>
Quoted 9 lines
Quoted 4 lines
Add a test case verifying that basic action combinations fail as expected.
Signed-off-by Tom Zanussi <[email protected]>This looks good to me.
Acked-by Masami Hiramatsu <[email protected]>
Thanks Tom and Masami,
I'm currently in the process of testing these patches (I already reviewed them, they look good), and will post to linux-next when the tests are complete (if there's no issues found).
-- Steve
Steven Rostedt
maintainerRe: [PATCH v15 15/15] tracing: Add hist trigger action 'expected fail' test case
In reply to Tom ZanussiQuoted 5 lines · On Wed, 13 Feb 2019 17:42:55 -0600 Tom Zanussi <[email protected]> wrote:
From: Tom Zanussi <[email protected]>
Add a test case verifying that basic action combinations fail as expected.
Hi Tom,
This test appears to fail:
# echo 'hist:keys=comm:onmatch(sched.sched_wakeup).save(comm,prio)' >> /sys/kernel/debug/tracing/events/sched/sched_waking/trigger -bash: echo: write error: Invalid argument
# cat /sys/kernel/debug/tracing/events/sched/sched_waking/hist
ERROR: action parsing: Handler doesn't support action: save
Last command: keys=comm:onmatch(sched.sched_wakeup).save(comm,prio)
Is the "save" feature implemented here? It's in the README too. Should it be removed?
-- Steve
Quoted 42 lines
Signed-off-by Tom Zanussi <[email protected]>--- .../inter-event/trigger-action-hist-xfail.tc | 30 ++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-action-hist-xfail.tctools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-action-hist-xfail.tc new file +30
-0@@ -0,0 +1,30 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 +# description: event trigger - test inter-event histogram trigger expected fail actions + +fail() { #msg + echo $1 + exit_fail +} + +if [ ! -f set_event ]; then + echo "event tracing is not supported" + exit_unsupported +fi + +if [ ! -f snapshot ]; then + echo "snapshot is not supported" + exit_unsupported +fi + +grep -q "snapshot()" README || exit_unsupported # version issue + +echo "Test expected snapshot action failure" + +echo 'hist:keys=comm:onmatch(sched.sched_wakeup).snapshot()' >> /sys/kernel/debug/tracing/events/sched/sched_waking/trigger && exit_fail + +echo "Test expected save action failure" + +echo 'hist:keys=comm:onmatch(sched.sched_wakeup).save(comm,prio)' >> /sys/kernel/debug/tracing/events/sched/sched_waking/trigger && exit_fail + +exit_xfail
Re: [PATCH v15 15/15] tracing: Add hist trigger action 'expected fail' test case
Hi Steve,
Quoted 19 lines · Steven Rostedt
Quoted 5 lines · On Wed, 13 Feb 2019 17:42:55 -0600 Tom Zanussi <[email protected]> wrote:
From: Tom Zanussi <[email protected]>
Add a test case verifying that basic action combinations fail as expected.
Hi Tom,
This test appears to fail:
# echo 'hist:keys=comm:onmatch(sched.sched_wakeup).save(comm,prio)'Quoted 1 line
Quoted 1 line
/sys/kernel/debug/tracing/events/sched/sched_waking/trigger-bash: echo: write error: Invalid argument
# cat /sys/kernel/debug/tracing/events/sched/sched_waking/hist
Quoted 8 lines
ERROR: action parsing: Handler doesn't support action: save
Last command: keys=comm:onmatch(sched.sched_wakeup).save(comm,prio)Is the "save" feature implemented here? It's in the README too. Should
it be removed?
The "save" feature is implemented, but it's not currently supported with onmatch(), which is why it fails, and is used in the xfail test, since it's expected to. So, in this case, the command fails, which means the xfail test actually passed. ;-)
There are other tests in the inter-event testcases that use save() but with onmax() and onchange(), and they pass.
Hope that explains things in this case,
Tom
Quoted 58 lines
-- Steve
Quoted 54 lines
Signed-off-by Tom Zanussi <[email protected]>--- .../inter-event/trigger-action-hist-xfail.tc | 30 ++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644
tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-action-hist-xfail.tc(quoted diff) +0
-0event/trigger-action-hist-xfail.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter- event/trigger-action-hist-xfail.tc
new file mode 100644
index 000000000000..1221240f8cf6tools/testing/selftests/ftrace/test.d/trigger/inter- new file +0
-0event/trigger-action-hist-xfail.tc
tools/testing/selftests/ftrace/test.d/trigger/inter- new file +3
-0@@ -0,0 +1,30 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 +# description: event trigger - test inter-event histogram triggerexpected fail actions
tools/testing/selftests/ftrace/test.d/trigger/inter- new file +21
-0+ +fail() { #msg + echo $1 + exit_fail +} + +if [ ! -f set_event ]; then + echo "event tracing is not supported" + exit_unsupported +fi + +if [ ! -f snapshot ]; then + echo "snapshot is not supported" + exit_unsupported +fi + +grep -q "snapshot()" README || exit_unsupported # version issue + +echo "Test expected snapshot action failure" + +echo 'hist:keys=comm:onmatch(sched.sched_wakeup).snapshot()' >>
/sys/kernel/debug/tracing/events/sched/sched_waking/trigger&&exit_failtools/testing/selftests/ftrace/test.d/trigger/inter- new file +4
-0+ +echo "Test expected save action failure" + +echo 'hist:keys=comm:onmatch(sched.sched_wakeup).save(comm,prio)'Quoted 1 line
Quoted 1 line
/sys/kernel/debug/tracing/events/sched/sched_waking/trigger&&
exit_failtools/testing/selftests/ftrace/test.d/trigger/inter- new file +2
-0+ +exit_xfail
Steven Rostedt
maintainerRe: [PATCH v15 15/15] tracing: Add hist trigger action 'expected fail' test case
Quoted 31 lines · On Wed, 20 Feb 2019 11:38:22 -0600 Tom Zanussi <[email protected]> wrote:
Hi Steve,
Quoted 19 lines · Steven Rostedt
Quoted 5 lines · On Wed, 13 Feb 2019 17:42:55 -0600 Tom Zanussi <[email protected]> wrote:
From: Tom Zanussi <[email protected]>
Add a test case verifying that basic action combinations fail as expected.
Hi Tom,
This test appears to fail:
# echo 'hist:keys=comm:onmatch(sched.sched_wakeup).save(comm,prio)'Quoted 1 line
Quoted 1 line
/sys/kernel/debug/tracing/events/sched/sched_waking/trigger-bash: echo: write error: Invalid argument
# cat /sys/kernel/debug/tracing/events/sched/sched_waking/histQuoted 8 lines
ERROR: action parsing: Handler doesn't support action: save
Last command: keys=comm:onmatch(sched.sched_wakeup).save(comm,prio)Is the "save" feature implemented here? It's in the README too. Should
it be removed?
Quoted 7 lines
The "save" feature is implemented, but it's not currently supported with
onmatch(), which is why it fails, and is used in the xfail test, since it's expected to. So, in this case, the command fails, which means the xfail test actually passed. ;-)There are other tests in the inter-event testcases that use
save()but withonmax()andonchange(), and they pass.
So the test needs to pass on failure?
Because, it shouldn't be flagged as a failure in the test suite.
-- Steve
Quoted 63 lines
Hope that explains things in this case,
Tom
Quoted 58 lines
-- Steve
Quoted 54 lines
Signed-off-by Tom Zanussi <[email protected]>--- .../inter-event/trigger-action-hist-xfail.tc | 30 ++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644
tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-action-hist-xfail.tc(quoted diff) +0
-0event/trigger-action-hist-xfail.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter- event/trigger-action-hist-xfail.tc
new file mode 100644
index 000000000000..1221240f8cf6tools/testing/selftests/ftrace/test.d/trigger/inter- new file +0
-0event/trigger-action-hist-xfail.tc
tools/testing/selftests/ftrace/test.d/trigger/inter- new file +3
-0@@ -0,0 +1,30 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 +# description: event trigger - test inter-event histogram triggerexpected fail actions
tools/testing/selftests/ftrace/test.d/trigger/inter- new file +21
-0+ +fail() { #msg + echo $1 + exit_fail +} + +if [ ! -f set_event ]; then + echo "event tracing is not supported" + exit_unsupported +fi + +if [ ! -f snapshot ]; then + echo "snapshot is not supported" + exit_unsupported +fi + +grep -q "snapshot()" README || exit_unsupported # version issue + +echo "Test expected snapshot action failure" + +echo 'hist:keys=comm:onmatch(sched.sched_wakeup).snapshot()' >>
/sys/kernel/debug/tracing/events/sched/sched_waking/trigger&&exit_failtools/testing/selftests/ftrace/test.d/trigger/inter- new file +4
-0+ +echo "Test expected save action failure" + +echo 'hist:keys=comm:onmatch(sched.sched_wakeup).save(comm,prio)'Quoted 1 line
Quoted 1 line
/sys/kernel/debug/tracing/events/sched/sched_waking/trigger&&
exit_failtools/testing/selftests/ftrace/test.d/trigger/inter- new file +2
-0+ +exit_xfail
Re: [PATCH v15 15/15] tracing: Add hist trigger action 'expected fail' test case
Hi Steve,
Quoted 44 lines · Steven Rostedt
Quoted 41 lines · On Wed, 20 Feb 2019 11:38:22 -0600 Tom Zanussi <[email protected]> wrote:
Hi Steve,
Quoted 22 lines · Steven Rostedt
Quoted 6 lines · On Wed, 13 Feb 2019 17:42:55 -0600 Tom Zanussi <[email protected]> wrote:
From: Tom Zanussi <[email protected]>
Add a test case verifying that basic action combinations fail as
expected.Hi Tom,
This test appears to fail:
# echo 'hist:keys=comm:onmatch(sched.sched_wakeup).save(comm,prio)'Quoted 1 line
Quoted 1 line
/sys/kernel/debug/tracing/events/sched/sched_waking/trigger-bash: echo: write error: Invalid argument
# cat /sys/kernel/debug/tracing/events/sched/sched_waking/histQuoted 9 lines
ERROR: action parsing: Handler doesn't support action: save
Last command:
keys=comm:onmatch(sched.sched_wakeup).save(comm,prio)Is the "save" feature implemented here? It's in the README too. Should
it be removed?The "save" feature is implemented, but it's not currently supported with
onmatch(), which is why it fails, and is used in the xfail test,
since it's expected to. So, in this case, the command fails, which means the xfail test actually passed. ;-)
Quoted 8 lines
Quoted 3 lines
There are other tests in the inter-event testcases that use
save()but
withonmax()andonchange(), and they pass.So the test needs to pass on failure?
Because, it shouldn't be flagged as a failure in the test suite.
As far as I understand it (there's no other case of an xfail test in the testsuite, so nothing similar to compare it to), the test output is
correct - here we get the expected fail, XFAIL, and not a FAIL as any
test, xfail or normal, that failed would produce:
tools/testing/selftests/ftrace# ./ftracetest test.d/trigger/
=== Ftrace unit tests ===
[1] event trigger - test inter-event histogram trigger expected fail actions [XFAIL]
[2] event trigger - test extended error support
[PASS]
And here the summary shows none failed, while we did have one expected xfail, but that's what was expected, and not a failure:
# of passed: 31 # of failed: 0 # of unresolved: 0 # of untested: 0 # of unsupported: 0 # of xfailed: 1 # of undefined(test bug): 0
If that's not correct, I'll fix it but at this point I'm not sure what the output should be if not that.
Thanks,
Tom
Quoted 75 lines
-- Steve
Quoted 71 lines
Hope that explains things in this case,
Tom
Quoted 66 lines
-- Steve
Quoted 62 lines
Signed-off-by Tom Zanussi <[email protected]>--- .../inter-event/trigger-action-hist-xfail.tc | 30 ++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644
tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-
action-hist-xfail.tcdiff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter- event/trigger-action-hist-xfail.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter- event/trigger-action-hist-xfail.tc
new file mode 100644
index 000000000000..1221240f8cf6tools/testing/selftests/ftrace/test.d/trigger/inter- new file +0
-0event/trigger-action-hist-xfail.tc
tools/testing/selftests/ftrace/test.d/trigger/inter- new file +3
-0@@ -0,0 +1,30 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 +# description: event trigger - test inter-event histogramtrigger
expected fail actionstools/testing/selftests/ftrace/test.d/trigger/inter- new file +17
-0+ +fail() { #msg + echo $1 + exit_fail +} + +if [ ! -f set_event ]; then + echo "event tracing is not supported" + exit_unsupported +fi + +if [ ! -f snapshot ]; then + echo "snapshot is not supported" + exit_unsupported +fi + +grep -q "snapshot()" README || exit_unsupported # versionissue
tools/testing/selftests/ftrace/test.d/trigger/inter- new file +4
-0+ +echo "Test expected snapshot action failure" + +echo 'hist:keys=comm:onmatch(sched.sched_wakeup).snapshot()'Quoted 1 line
Quoted 1 line
/sys/kernel/debug/tracing/events/sched/sched_waking/trigger&&exit_failtools/testing/selftests/ftrace/test.d/trigger/inter- new file +4
-0+ +echo "Test expected save action failure" + +echo'hist:keys=comm:onmatch(sched.sched_wakeup).save(comm,prio)'
Quoted 2 lines
Quoted 2 lines
/sys/kernel/debug/tracing/events/sched/sched_waking/trigger&&
exit_failtools/testing/selftests/ftrace/test.d/trigger/inter- new file +2
-0+ +exit_xfail
Steven Rostedt
maintainerRe: [PATCH v15 15/15] tracing: Add hist trigger action 'expected fail' test case
Quoted 5 lines · On Wed, 20 Feb 2019 12:10:31 -0600 Tom Zanussi <[email protected]> wrote:
As far as I understand it (there's no other case of an xfail test in the testsuite, so nothing similar to compare it to), the test output is
correct - here we get the expected fail, XFAIL, and not a FAIL as any
test, xfail or normal, that failed would produce:
Yeah, I've been staring at the code, and commit:
915de2adb584a ftracetest: Add POSIX.3 standard and XFAIL result codes
Quoted 11 lines
tools/testing/selftests/ftrace# ./ftracetest test.d/trigger/
=== Ftrace unit tests ===
[1] event trigger - test inter-event histogram trigger expected fail actions [XFAIL]
[2] event trigger - test extended error support
[PASS]And here the summary shows none failed, while we did have one expected xfail, but that's what was expected, and not a failure:
Quoted 6 lines
# of passed: 31 # of failed: 0 # of unresolved: 0 # of untested: 0 # of unsupported: 0 # of xfailed: 1
Yeah, but it's marked as RED, which is why I thought it was a failure.
Quoted 4 lines
# of undefined(test bug): 0If that's not correct, I'll fix it but at this point I'm not sure what the output should be if not that.
OK, so this has nothing to do with your patch set. I've tested everything else, and I'm ready to finally push my tree to linux-next.
I'm thinking that we should get rid of xfail, as it's really confusing, and I don't understand its purpose. But that shouldn't stop pushing your patches.
Thanks,
-- Steve
Re: [PATCH v15 15/15] tracing: Add hist trigger action 'expected fail' test case
Quoted 46 lines · Steven Rostedt
Quoted 8 lines · On Wed, 20 Feb 2019 12:10:31 -0600 Tom Zanussi <[email protected]> wrote:
As far as I understand it (there's no other case of an xfail test in
the testsuite, so nothing similar to compare it to), the test output is
correct - here we get the expected fail, XFAIL, and not a FAIL as
any
test, xfail or normal, that failed would produce:Yeah, I've been staring at the code, and commit:
915de2adb584aftracetest: Add POSIX.3 standard and XFAIL result codesQuoted 13 lines
tools/testing/selftests/ftrace# ./ftracetest test.d/trigger/ === Ftrace unit tests ===
[1] event trigger - test inter-event histogram trigger expected fail actions
[XFAIL]
[2] event trigger - test extended error support [PASS]And here the summary shows none failed, while we did have one expected
xfail, but that's what was expected, and not a failure:Quoted 6 lines
# of passed: 31 # of failed: 0 # of unresolved: 0 # of untested: 0 # of unsupported: 0 # of xfailed: 1Yeah, but it's marked as RED, which is why I thought it was a failure.
Quoted 5 lines
# of undefined(test bug): 0If that's not correct, I'll fix it but at this point I'm not sure what
the output should be if not that.
Quoted 8 lines
OK, so this has nothing to do with your patch set. I've tested everything else, and I'm ready to finally push my tree to linux-next.
I'm thinking that we should get rid of xfail, as it's really confusing,
and I don't understand its purpose. But that shouldn't stop pushing your patches.
OK, I'm fine with removing it, if it's too confusing. IIRC Masami suggested it to highlight that not all actions and handlers can be used together, so I guess I'll hold off on a patch removing it until he can chime in...
Thanks,
Tom
Quoted 3 lines
Thanks,
-- Steve
Steven Rostedt
maintainerRe: [PATCH v15 15/15] tracing: Add hist trigger action 'expected fail' test case
Quoted 9 lines · On Wed, 20 Feb 2019 12:45:15 -0600 Tom Zanussi <[email protected]> wrote:
Quoted 8 lines
OK, so this has nothing to do with your patch set. I've tested everything else, and I'm ready to finally push my tree to linux-next.
I'm thinking that we should get rid of xfail, as it's really confusing,
and I don't understand its purpose. But that shouldn't stop pushing your patches.
Quoted 4 lines
OK, I'm fine with removing it, if it's too confusing. IIRC Masami suggested it to highlight that not all actions and handlers can be used together, so I guess I'll hold off on a patch removing it until he can chime in...
Yeah, its a different issue. At the very least, we should change the color of XFAIL to green.
-- Steve