Skip to contentSkip to conversation

Staging: vt6655: Fix comment style of SPDX-License

PATCH In review Madhumitha Prabakaran 2 participants 4 messages Mar 1, 2019 Staging

lore
Share & tools
lore
#0 lore raw

cover Staging: vt6655: Fix comment style of SPDX-License

This patchset fixes the comment styles of SPDX-License Identifier based on License Identifier syntax.

Madhumitha Prabakaran (2):
Staging: vt6655: Modify comment style of SPDX License Identifier
Staging: vt6655: Fix comment style of SPDX License Identifier

 drivers/staging/vt6655/channel.h | 2 +-
 drivers/staging/vt6655/desc.h    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/2 Staging: vt6655: Modify comment style of SPDX License Identifier

Fix warning by changing comment style based on header file type as per License identifier syntax.

---
 drivers/staging/vt6655/channel.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/channel.h +1 -1
index 53f623a4af65..0d2709607456 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
Signature · 1 line
2.17.1
#2 lore raw

PATCH 2/2 Staging: vt6655: Fix comment style of SPDX License Identifier

In reply to Madhumitha Prabakaran

Modify comment style of SPDX License Identifer based on header file type as per License identifer syntax.

---
 drivers/staging/vt6655/desc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/desc.h +1 -1
index b4a0037b40c1..d4572847b08a 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
Signature · 1 line
2.17.1
maintainer
#3 lore raw
In reply to Madhumitha Prabakaran
Quoted 8 lines · Madhumitha Prabakaran

This patchset fixes the comment styles of SPDX-License Identifier based on License Identifier syntax.

Madhumitha Prabakaran (2):
Staging: vt6655: Modify comment style of SPDX License Identifier
Staging: vt6655: Fix comment style of SPDX License Identifier

You really are doing the same thing to two different files, so this could be:

Staging: vt6655: channel.h: Fix comment style of SPDX License Identifier
Staging: vt6655: desc.h: Fix comment style of SPDX License Identifier

right? That makes it more obvious what is going on here, and you don't have to "reword" the subject lines to be different in tiny ways.

Also, this is a v2 series, right? Please make it v3 next time you resend it.

thanks,

greg k-h