Staging: vt6655: Fix checkpatch.pl issues
v2 cover Staging: vt6655: Fix checkpatch.pl issues
This patchset fix line over 80 characters, correct spelling error and fix space around binary operator.
Madhumitha Prabakaran (4):
Staging: vt6655: Modify line over 80 characters
Staging: vt6655: Fix line over 80 characters
Staging: vt6655: Fix spelling mistake
Staging: vt6655: Fix space around binary operator
---
Changes in v2:
- Dropped a patch
- Changed subject line for first patch in patchset
drivers/staging/vt6655/card.h | 6 ++++-- drivers/staging/vt6655/rf.c | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-)
Signature · 1 line
2.17.1
PATCH v2 1/4 Staging: vt6655: Modify line over 80 characters
Fix the warning issued by checkpatch.pl
WARNING: line over 80 characters
--- drivers/staging/vt6655/card.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/vt6655/card.h +2 -1
@@ -44,7 +44,8 @@ struct vnt_private;void CARDvSetRSPINF (struct vnt_private *priv,u8 bb_type);void CARDvUpdateBasicTopRate (struct vnt_private *priv);bool CARDbIsOFDMinBasicRate (struct vnt_private *priv); -void CARDvSetLoopbackMode (struct vnt_private *priv,unsigned short wLoopbackMode); +void CARDvSetLoopbackMode (struct vnt_private *priv, +unsigned short wLoopbackMode);bool CARDbSoftwareReset (struct vnt_private *priv);void CARDvSetFirstNextTBTT (struct vnt_private *priv,unsigned short wBeaconInterval);
Signature · 1 line
2.17.1
PATCH v2 2/4 Staging: vt6655: Fix line over 80 characters
In reply to Madhumitha PrabakaranFix the warning by checkpatch.pl
WARNING: line over 80 characters
--- drivers/staging/vt6655/card.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/vt6655/card.h +2 -1
@@ -62,6 +62,7 @@ bool CARDbRadioPowerOn(struct vnt_private *priv);bool CARDbSetPhyParameter (struct vnt_private *priv,u8 bb_type);bool CARDbUpdateTSF (struct vnt_private *priv,unsigned char byRxRate,u64 qwBSSTimestamp); -bool CARDbSetBeaconPeriod (struct vnt_private *priv,unsigned short wBeaconInterval); +bool CARDbSetBeaconPeriod (struct vnt_private *priv, +unsigned short wBeaconInterval);#endif /* __CARD_H__ */
Signature · 1 line
2.17.1
Greg KH
maintainerRe: [PATCH v2 2/4] Staging: vt6655: Fix line over 80 characters
Quoted 7 lines · Madhumitha Prabakaran
Fix the warning by checkpatch.pl
WARNING: line over 80 charactersSigned-off-by Madhumitha Prabakaran <[email protected]>--- drivers/staging/vt6655/card.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
This should be merged with patch 1/4 of this series. Don't do the same thing to the same file one line at a time. You can do the same single "type" of change to a whole file at once.
thanks,
greg k-h
PATCH v2 3/4 Staging: vt6655: Fix spelling mistake
In reply to Madhumitha PrabakaranFix the check for spelling mistake
CHECK: 'Regsiter' may be misspelled - perhaps 'Register'
--- drivers/staging/vt6655/rf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/rf.c +1 -1
@@ -163,7 +163,7 @@ static const unsigned long dwAL7230InitTable[CB_AL7230_INIT_SEQ] = {0x841FF200 + (BY_AL7230_REG_LEN <<3 ) +IFREGCTL_REGW ,/* Need modify for 11a: 451FE2 */ 0x3FDFA300 + (BY_AL7230_REG_LEN <<3 ) +IFREGCTL_REGW ,/* Need modify for 11a: 5FDFA3 */ 0x7FD78400 + (BY_AL7230_REG_LEN <<3 ) +IFREGCTL_REGW ,/* 11b/g // Need modify for 11a */ -/* RoberYu:20050113, Rev0.47 Regsiter Setting Guide */ +/* RoberYu:20050113, Rev0.47 Register Setting Guide */ 0x802B5500 + (BY_AL7230_REG_LEN <<3 ) +IFREGCTL_REGW ,/* Need modify for 11a: 8D1B55 */ 0x56AF3600 + (BY_AL7230_REG_LEN <<3 ) +IFREGCTL_REGW , 0xCE020700 + (BY_AL7230_REG_LEN << 3) + IFREGCTL_REGW, /* Need modify for 11a: 860207 */
Signature · 1 line
2.17.1
PATCH v2 4/4 Staging: vt6655: Fix space around binary operator
In reply to Madhumitha PrabakaranFix the check as per Linux kernel style for use of spaces
CHECK: spaces preferred around that '-'
--- drivers/staging/vt6655/rf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/rf.c +1 -1
@@ -792,7 +792,7 @@ bool RFbSetPower( byDec = byPwr +10 ;if (byDec >= priv->byMaxPwrLevel) - byDec = priv->byMaxPwrLevel-1 ; + byDec = priv->byMaxPwrLevel -1 ; byPwr = byDec;break ;
Signature · 1 line
2.17.1