Cleanups in rtl8723bs
cover Cleanups in rtl8723bs
Patch 1 and 2 remove typedef in structures. Patch 3 remove unused structure.
Madhumitha Prabakaran (3):
Staging: rtl8723bs: Remove typedef in struct ieee_param_ex
Staging: rtl8723bs: Remove typedef in struct ieee_param
Staging: rtl8723bs: Remove an unused struct tx_pending_t
drivers/staging/rtl8723bs/include/ieee80211.h | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-)
Signature · 1 line
2.17.1
PATCH 1/3 Staging: rtl8723bs: Remove typedef in struct ieee_param_ex
Remove typedef in struct ieee_param_ex, as the struct that has elements that can reasonably be directly accessed should never be a typedef.
--- drivers/staging/rtl8723bs/include/ieee80211.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/include/ieee80211.h +2 -2
@@ -242,11 +242,11 @@ typedef struct ieee_param { } u; }ieee_param; -typedef struct ieee_param_ex { +struct ieee_param_ex {u32 cmd;u8 sta_addr[ETH_ALEN ];u8 data[0 ]; -}ieee_param_ex ; +};struct sta_data {u16 aid;
Signature · 1 line
2.17.1
PATCH 2/3 Staging: rtl8723bs: Remove typedef in struct ieee_param
In reply to Madhumitha PrabakaranRemove typedef in struct ieee_param, as the struct that has elements that can reasonably be directly accessed should never be a typedef.
--- drivers/staging/rtl8723bs/include/ieee80211.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/include/ieee80211.h +2 -2
@@ -202,7 +202,7 @@ enum NETWORK_TYPE#define IsSupportedVHT (NetType) (((NetType) & (WIRELESS_11AC)) ? true : false) -typedef struct ieee_param { +struct ieee_param {u32 cmd;u8 sta_addr[ETH_ALEN ];union {
@@ -240,7 +240,7 @@ typedef struct ieee_param {u8 buf[0 ]; } bcn_ie; } u; -}ieee_param; +};struct ieee_param_ex {u32 cmd;
Signature · 1 line
2.17.1
PATCH 3/3 Staging: rtl8723bs: Remove an unused struct tx_pending_t
In reply to Madhumitha PrabakaranRemove an unused struct tx_pending_t, as it is never used in kernel tree.
--- drivers/staging/rtl8723bs/include/ieee80211.h | 7 ------- 1 file changed, 7 deletions(-)
drivers/staging/rtl8723bs/include/ieee80211.h +0 -7
@@ -870,13 +870,6 @@ static inline int is_zero_mac_addr(const u8 *addr)#define CFG_IEEE80211_RESERVE_FCS (1<<0)#define CFG_IEEE80211_COMPUTE_FCS (1<<1) -typedef struct tx_pending_t { -int frag; -struct ieee80211_txb *txb; -}tx_pending_t ; - - -#define MAXTID 16#define IEEE_A (1<<0)
Signature · 1 line
2.17.1