Skip to contentSkip to conversation

DTS: ARM: some minor updates and fixes for GTA04

PATCH In review H. Nikolaus Schaller 5 participants 20 messages Jul 8, 2019 – Sep 20, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover DTS: ARM: some minor updates and fixes for GTA04

We define define chosen/stdout-path chosen to remove the console= entry in the kernel command line.

And we fix the SPI definition to make the LCD panel work again.

H. Nikolaus Schaller (2):
DTS: ARM: gta04: define chosen/stdout-path
DTS: ARM: gta04: introduce legacy spi-cs-high to make display work
again

 Documentation/devicetree/bindings/spi/spi-bus.txt | 6 ++++++
 arch/arm/boot/dts/omap3-gta04.dtsi                | 5 +++++
 2 files changed, 11 insertions(+)
Signature · 1 line
2.19.1
#1 lore raw

PATCH 1/2 DTS: ARM: gta04: define chosen/stdout-path

This allows to remove the console= entry in the kernel command line.

---
 arch/arm/boot/dts/omap3-gta04.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/omap3-gta04.dtsi +4 -0
index 6473d8dfadc0..9a9a29fe88ec 100644
@@ -24,6 +24,10 @@
 		reg = <0x80000000 0x20000000>; /* 512 MB */
 	};
 
+	chosen {
+		stdout-path = &uart3;
+	};
+
 	aliases {
 		display0 = &lcd;
 		display1 = &tv0;
Signature · 1 line
2.19.1
#2 lore raw

Re: [PATCH 1/2] DTS: ARM: gta04: define chosen/stdout-path

Quoted 1 line · H. Nikolaus Schaller

This allows to remove the console= entry in the kernel command line.

Applying this patch into omap-for-v5.4/dt thanks.

Tony

#3 lore raw

PATCH 2/2 DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again

In reply to H. Nikolaus Schaller

commit 6953c57ab172 "gpio: of: Handle SPI chipselect legacy bindings"

did introduce logic to centrally handle the legacy spi-cs-high property in combination with cs-gpios. This assumes that the polarity of the CS has to be inverted if spi-cs-high is missing, even and especially if non-legacy GPIO_ACTIVE_HIGH is specified.

The DTS for the GTA04 was orginally introduced under the assumption that there is no need for spi-cs-high if the gpio is defined with proper polarity GPIO_ACTIVE_HIGH.

This was not a problem until gpiolib changed the interpretation of GPIO_ACTIVE_HIGH and missing spi-cs-high.

The effect is that the missing spi-cs-high is now interpreted as CS being low (despite GPIO_ACTIVE_HIGH) which turns off the SPI interface when the panel is to be programmed by the panel driver.

Therefore, we have to add the redundant and legacy spi-cs-high property to properly pass through the legacy handler.

Since this is nowhere documented in the bindings, we add some words of WARNING.

---
 Documentation/devicetree/bindings/spi/spi-bus.txt | 6 ++++++
 arch/arm/boot/dts/omap3-gta04.dtsi                | 1 +
 2 files changed, 7 insertions(+)
Documentation/devicetree/bindings/spi/spi-bus.txt +6 -0
index 1f6e86f787ef..982aa590058b 100644
@@ -47,6 +47,10 @@ cs1 : native
 cs2 : &gpio1 1 0
 cs3 : &gpio1 2 0
 
+WARNING: the polarity of cs-gpios may be inverted in some cases compared
+to what is specified in the third parameter. In that case the spi-cs-high
+property must be defined for slave nodes.
+
 
 SPI slave nodes must be children of the SPI controller node.
 
@@ -69,6 +73,8 @@ All slave nodes can contain the following optional properties:
 		    phase (CPHA) mode.
 - spi-cs-high     - Empty property indicating device requires chip select
 		    active high.
+                   WARNING: this is especially required even if the cs-gpios
+		    define the gpio as GPIO_ACTIVE_HIGH
 - spi-3wire       - Empty property indicating device requires 3-wire mode.
 - spi-lsb-first   - Empty property indicating device requires LSB first mode.
 - spi-tx-bus-width - The bus width (number of data wires) that is used for MOSI.
arch/arm/boot/dts/omap3-gta04.dtsi +1 -0
index 9a9a29fe88ec..47bab8e1040e 100644
@@ -124,6 +124,7 @@
 			spi-max-frequency = <100000>;
 			spi-cpol;
 			spi-cpha;
+			spi-cs-high;
 
 			backlight= <&backlight>;
 			label = "lcd";
Signature · 1 line
2.19.1
maintainer
#4 lore raw

Re: [PATCH 2/2] DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again

Quoted 10 lines · H. Nikolaus Schaller

commit 6953c57ab172 "gpio: of: Handle SPI chipselect legacy bindings"

did introduce logic to centrally handle the legacy spi-cs-high property in combination with cs-gpios. This assumes that the polarity of the CS has to be inverted if spi-cs-high is missing, even and especially if non-legacy GPIO_ACTIVE_HIGH is specified.

The DTS for the GTA04 was orginally introduced under the assumption that there is no need for spi-cs-high if the gpio is defined with proper polarity GPIO_ACTIVE_HIGH.

Given that spi-cs-high is called legacy, that would imply that DT's should not have to use spi-cs-high.

Quoted 2 lines

This was not a problem until gpiolib changed the interpretation of GPIO_ACTIVE_HIGH and missing spi-cs-high.

Then we should fix gpiolib...

Quoted 16 lines

The effect is that the missing spi-cs-high is now interpreted as CS being low (despite GPIO_ACTIVE_HIGH) which turns off the SPI interface when the panel is to be programmed by the panel driver.

Therefore, we have to add the redundant and legacy spi-cs-high property to properly pass through the legacy handler.

Since this is nowhere documented in the bindings, we add some words of WARNING.

---
 Documentation/devicetree/bindings/spi/spi-bus.txt | 6 ++++++
 arch/arm/boot/dts/omap3-gta04.dtsi                | 1 +
 2 files changed, 7 insertions(+)
#5 lore raw

Re: [PATCH 2/2] DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again

Hi Rob,

Quoted 10 lines

Am 24.07.2019 um 21:42 schrieb Rob Herring <[email protected]>:

Quoted 7 lines · H. Nikolaus Schaller

commit 6953c57ab172 "gpio: of: Handle SPI chipselect legacy bindings"

did introduce logic to centrally handle the legacy spi-cs-high property in combination with cs-gpios. This assumes that the polarity of the CS has to be inverted if spi-cs-high is missing, even and especially if non-legacy GPIO_ACTIVE_HIGH is specified.

Quoted 6 lines
Quoted 3 lines

The DTS for the GTA04 was orginally introduced under the assumption that there is no need for spi-cs-high if the gpio is defined with proper polarity GPIO_ACTIVE_HIGH.

Given that spi-cs-high is called legacy, that would imply that DT's should not have to use spi-cs-high.

Yes.

Quoted 5 lines
Quoted 3 lines

This was not a problem until gpiolib changed the interpretation of GPIO_ACTIVE_HIGH and missing spi-cs-high.

Then we should fix gpiolib...

I tried to convince Linus that this is the right way but he convinced me that a fix that handles all cases does not exist.

There seem to be embedded devices with older DTB (potentially in ROM) which provide a plain 0 value for a gpios definition. And either with or without spi-cs-high.

Since "0" is the same as "GPIO_ACTIVE_HIGH", the absence of spi-cs-high was and must be interpreted as active low for these devices. This leads to the inversion logic in code.

AFAIR it boils down to the question if gpiolib and the bindings should still support such legacy devices with out-of tree DTB, but force in-tree DTS to add the legacy spi-cs-high property.

Or if we should fix the 2 or 3 cases of in-tree legacy cases and potentially break out-of tree DTBs.

IMHO it is more general to keep the out-of-tree DTBs working and "fix" what we can control (in-tree DTS).

Quoted 11 lines
Quoted 11 lines

The effect is that the missing spi-cs-high is now interpreted as CS being low (despite GPIO_ACTIVE_HIGH) which turns off the SPI interface when the panel is to be programmed by the panel driver.

Therefore, we have to add the redundant and legacy spi-cs-high property to properly pass through the legacy handler.

Since this is nowhere documented in the bindings, we add some words of WARNING.

Quoted 6 lines
Quoted 6 lines

---
Documentation/devicetree/bindings/spi/spi-bus.txt | 6 ++++++
arch/arm/boot/dts/omap3-gta04.dtsi | 1 +

2 files changed, 7 insertions(+)

BR,
Nikolaus

maintainer
#6 lore raw

Re: [PATCH 2/2] DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again

Quoted 39 lines · H. Nikolaus Schaller

Hi Rob,

Quoted 10 lines

Am 24.07.2019 um 21:42 schrieb Rob Herring <[email protected]>:

Quoted 7 lines · H. Nikolaus Schaller

commit 6953c57ab172 "gpio: of: Handle SPI chipselect legacy bindings"

did introduce logic to centrally handle the legacy spi-cs-high property in combination with cs-gpios. This assumes that the polarity of the CS has to be inverted if spi-cs-high is missing, even and especially if non-legacy GPIO_ACTIVE_HIGH is specified.

Quoted 6 lines
Quoted 3 lines

The DTS for the GTA04 was orginally introduced under the assumption that there is no need for spi-cs-high if the gpio is defined with proper polarity GPIO_ACTIVE_HIGH.

Given that spi-cs-high is called legacy, that would imply that DT's should not have to use spi-cs-high.

Yes.

Quoted 5 lines
Quoted 3 lines

This was not a problem until gpiolib changed the interpretation of GPIO_ACTIVE_HIGH and missing spi-cs-high.

Then we should fix gpiolib...

I tried to convince Linus that this is the right way but he convinced me that a fix that handles all cases does not exist.

There seem to be embedded devices with older DTB (potentially in ROM) which provide a plain 0 value for a gpios definition. And either with or without spi-cs-high.

Since "0" is the same as "GPIO_ACTIVE_HIGH", the absence of spi-cs-high was and must be interpreted as active low for these devices. This leads to the inversion logic in code.

Quoted 6 lines

AFAIR it boils down to the question if gpiolib and the bindings should still support such legacy devices with out-of tree DTB, but force in-tree DTS to add the legacy spi-cs-high property.

Or if we should fix the 2 or 3 cases of in-tree legacy cases and potentially break out-of tree DTBs.

If it is small number of platforms, then the kernel could handle those cases explicitly as needed.

Quoted 2 lines

IMHO it is more general to keep the out-of-tree DTBs working and "fix" what we can control (in-tree DTS).

If we do this, then we need to not call spi-cs-high legacy because we're stuck with it forever.

Rob

#7 lore raw

Re: [PATCH 2/2] DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again

Quoted 20 lines · Rob Herring
Quoted 11 lines · H. Nikolaus Schaller

I tried to convince Linus that this is the right way but he convinced me that a fix that handles all cases does not exist.

There seem to be embedded devices with older DTB (potentially in ROM) which provide a plain 0 value for a gpios definition. And either with or without spi-cs-high.

Since "0" is the same as "GPIO_ACTIVE_HIGH", the absence of spi-cs-high was and must be interpreted as active low for these devices. This leads to the inversion logic in code.

Quoted 6 lines

AFAIR it boils down to the question if gpiolib and the bindings should still support such legacy devices with out-of tree DTB, but force in-tree DTS to add the legacy spi-cs-high property.

Or if we should fix the 2 or 3 cases of in-tree legacy cases and potentially break out-of tree DTBs.

Quoted 8 lines

If it is small number of platforms, then the kernel could handle those cases explicitly as needed.

Quoted 2 lines

IMHO it is more general to keep the out-of-tree DTBs working and "fix" what we can control (in-tree DTS).

If we do this, then we need to not call spi-cs-high legacy because we're stuck with it forever.

I agree. The background on it is here:
https://lkml.org/lkml/2019/4/2/4

Not using the negatively defined (i.e. if it is no there, the line is by default active low) spi-cs-high would break
PowerPC, who were AFAICT using this to ship devices.

Yours,
Linus Walleij

#8 lore raw

Re: [Letux-kernel] [PATCH 2/2] DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again

Hi,

Quoted 30 lines · On Mon, 5 Aug 2019 12:29:19 +0200 Linus Walleij <[email protected]>…
Quoted 20 lines · Rob Herring
Quoted 11 lines · H. Nikolaus Schaller

I tried to convince Linus that this is the right way but he convinced me that a fix that handles all cases does not exist.

There seem to be embedded devices with older DTB (potentially in ROM) which provide a plain 0 value for a gpios definition. And either with or without spi-cs-high.

Since "0" is the same as "GPIO_ACTIVE_HIGH", the absence of spi-cs-high was and must be interpreted as active low for these devices. This leads to the inversion logic in code.

Quoted 6 lines

AFAIR it boils down to the question if gpiolib and the bindings should still support such legacy devices with out-of tree DTB, but force in-tree DTS to add the legacy spi-cs-high property.

Or if we should fix the 2 or 3 cases of in-tree legacy cases and potentially break out-of tree DTBs.

Quoted 8 lines

If it is small number of platforms, then the kernel could handle those cases explicitly as needed.

Quoted 2 lines

IMHO it is more general to keep the out-of-tree DTBs working and "fix" what we can control (in-tree DTS).

If we do this, then we need to not call spi-cs-high legacy because we're stuck with it forever.

Quoted 7 lines

I agree. The background on it is here:
https://lkml.org/lkml/2019/4/2/4

Not using the negatively defined (i.e. if it is no there, the line is by default active low) spi-cs-high would break
PowerPC, who were AFAICT using this to ship devices.

is this thing now just waiting for someone to do a s/legacy//?

Regards,
Andreas

#9 lore raw

Re: [Letux-kernel] [PATCH 2/2] DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again

ping.

Device omap3-gta04 is neither working with v5.3 nor linux-next quite a while and we need a solution.

Quoted 49 lines

Am 31.08.2019 um 08:48 schrieb Andreas Kemnade <[email protected]>:

Hi,

Quoted 31 lines · On Mon, 5 Aug 2019 12:29:19 +0200 Linus Walleij <[email protected]>…
Quoted 23 lines · Rob Herring
Quoted 11 lines · H. Nikolaus Schaller

I tried to convince Linus that this is the right way but he convinced me that a fix that handles all cases does not exist.

There seem to be embedded devices with older DTB (potentially in ROM) which provide a plain 0 value for a gpios definition. And either with or without spi-cs-high.

Since "0" is the same as "GPIO_ACTIVE_HIGH", the absence of spi-cs-high was and must be interpreted as active low for these devices. This leads to the inversion logic in code.

Quoted 6 lines

AFAIR it boils down to the question if gpiolib and the bindings should still support such legacy devices with out-of tree DTB, but force in-tree DTS to add the legacy spi-cs-high property.

Or if we should fix the 2 or 3 cases of in-tree legacy cases and potentially break out-of tree DTBs.

If it is small number of platforms, then the kernel could handle those cases explicitly as needed.

Quoted 6 lines
Quoted 2 lines

IMHO it is more general to keep the out-of-tree DTBs working and "fix" what we can control (in-tree DTS).

If we do this, then we need to not call spi-cs-high legacy because we're stuck with it forever.

Quoted 7 lines

I agree. The background on it is here:
https://lkml.org/lkml/2019/4/2/4

Not using the negatively defined (i.e. if it is no there, the line is by default active low) spi-cs-high would break
PowerPC, who were AFAICT using this to ship devices.

is this thing now just waiting for someone to do a s/legacy//?

Regards,
Andreas

#10 lore raw

Re: [Letux-kernel] [PATCH 2/2] DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again

Quoted 3 lines · H. Nikolaus Schaller

ping.

Device omap3-gta04 is neither working with v5.3 nor linux-next quite a while and we need a solution.

Can't we just apply the last part of the patch in this thread:

(quoted diff) +0 -0

b/arch/arm/boot/dts/omap3-gta04.dtsi
index 9a9a29fe88ec..47bab8e1040e 100644

arch/arm/boot/dts/omap3-gta04.dtsi +1 -0
@@ -124,6 +124,7 @@
                        spi-max-frequency = <100000>;
                        spi-cpol;
                        spi-cpha;
+                       spi-cs-high;
 
                        backlight= <&backlight>;
                        label = "lcd";

Surely this fixes the problem?

Yours,
Linus Walleij

#11 lore raw

Re: [Letux-kernel] [PATCH 2/2] DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again

Hi Lunus,

Quoted 25 lines

Am 17.09.2019 um 00:52 schrieb Linus Walleij <[email protected]>:

Quoted 3 lines · H. Nikolaus Schaller

ping.

Device omap3-gta04 is neither working with v5.3 nor linux-next quite a while and we need a solution.

Can't we just apply the last part of the patch in this thread:

arch/arm/boot/dts/omap3-gta04.dtsi +1 -0
index 9a9a29fe88ec..47bab8e1040e 100644
@@ -124,6 +124,7 @@
                       spi-max-frequency = <100000>;
                       spi-cpol;
                       spi-cpha;
+                       spi-cs-high;
 
                       backlight= <&backlight>;
                       label = "lcd";
Quoted 1 line

Surely this fixes the problem?

yes, it is a workaround, but appears to violate some policies. E.g. the spi-cs-high; is undocumented but DT bindings maintainer seems to be against documenting it as I had proposed in my other patch.

Rather he seems to have proposed a white-list in the driver code. So that the legacy mode is only becoming active for those systems which really need the legacy mode instead of everyone.

Then, we do not need this patch for GTA04.

So its up to you to decide which way to go. We are happy with any one that makes mainline work again asap...

BR and thanks,
Nikolaus

#12 lore raw

Re: [Letux-kernel] [PATCH 2/2] DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again

Quoted 24 lines · H. Nikolaus Schaller
Quoted 24 lines

Am 17.09.2019 um 00:52 schrieb Linus Walleij <[email protected]>:

Quoted 3 lines · H. Nikolaus Schaller

ping.

Device omap3-gta04 is neither working with v5.3 nor linux-next quite a while and we need a solution.

Can't we just apply the last part of the patch in this thread:

arch/arm/boot/dts/omap3-gta04.dtsi +1 -0
index 9a9a29fe88ec..47bab8e1040e 100644
@@ -124,6 +124,7 @@
                       spi-max-frequency = <100000>;
                       spi-cpol;
                       spi-cpha;
+                       spi-cs-high;
 
                       backlight= <&backlight>;
                       label = "lcd";
Quoted 6 lines
Quoted 1 line

Surely this fixes the problem?

yes, it is a workaround, but appears to violate some policies. E.g. the spi-cs-high; is undocumented but DT bindings maintainer seems to be against documenting it as I had proposed in my other patch.

It is documented as a boolean in Documentation/devicetree/bindings/spi/spi-controller.yaml with the following description:

spi-cs-high:
$ref: /schemas/types.yaml#/definitions/flag description:
The device requires the chip select active high.

So I don't think it is about it being undocumented.

Quoted 3 lines

Rather he seems to have proposed a white-list in the driver code. So that the legacy mode is only becoming active for those systems which really need the legacy mode instead of everyone.

Yeah that seems like a plausible way forward if we want to move away from the legacy way of specifying polarity.

Quoted 1 line

Then, we do not need this patch for GTA04.

We don't need to implement the perfect solution up front. We can aim for that in the long run. I usually go by the IETF motto "rough consensus and running code".

Quoted 2 lines

So its up to you to decide which way to go. We are happy with any one that makes mainline work again asap...

I suggest to go both way:
apply this oneliner and tag for stable so that GTA04 works again.

Then for the next kernel think about a possible more abitious whitelist solution and after adding that remove *all* "spi-cs-high" flags from all device trees in the kernel after fixing them all up.

Yours,
Linus Walleij

#13 lore raw

Re: [Letux-kernel] [PATCH 2/2] DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again

Quoted 39 lines

Am 20.09.2019 um 10:55 schrieb Linus Walleij <[email protected]>:

Quoted 24 lines · H. Nikolaus Schaller
Quoted 24 lines

Am 17.09.2019 um 00:52 schrieb Linus Walleij <[email protected]>:

Quoted 3 lines · H. Nikolaus Schaller

ping.

Device omap3-gta04 is neither working with v5.3 nor linux-next quite a while and we need a solution.

Can't we just apply the last part of the patch in this thread:

arch/arm/boot/dts/omap3-gta04.dtsi +1 -0
index 9a9a29fe88ec..47bab8e1040e 100644
@@ -124,6 +124,7 @@
                      spi-max-frequency = <100000>;
                      spi-cpol;
                      spi-cpha;
+                       spi-cs-high;
 
                      backlight= <&backlight>;
                      label = "lcd";
Quoted 6 lines
Quoted 1 line

Surely this fixes the problem?

yes, it is a workaround, but appears to violate some policies. E.g. the spi-cs-high; is undocumented but DT bindings maintainer seems to be against documenting it as I had proposed in my other patch.

It is documented as a boolean in Documentation/devicetree/bindings/spi/spi-controller.yaml with the following description:

Quoted 6 lines

spi-cs-high:
$ref: /schemas/types.yaml#/definitions/flag description:
The device requires the chip select active high.

So I don't think it is about it being undocumented.

Yes, the basic property is documented. But incomplete.

The strange inversion side-effect on the third gpio parameter is undocumented and not understandable from this description alone.

Quoted 17 lines
Quoted 4 lines

Rather he seems to have proposed a white-list in the driver code. So that the legacy mode is only becoming active for those systems which really need the legacy mode instead of everyone.

Yeah that seems like a plausible way forward if we want to move away from the legacy way of specifying polarity.

Quoted 1 line

Then, we do not need this patch for GTA04.

We don't need to implement the perfect solution up front. We can aim for that in the long run. I usually go by the IETF motto "rough consensus and running code".

Quoted 2 lines

So its up to you to decide which way to go. We are happy with any one that makes mainline work again asap...

Quoted 8 lines

I suggest to go both way:
apply this oneliner and tag for stable so that GTA04 works again.

Then for the next kernel think about a possible more abitious whitelist solution and after adding that remove *all* "spi-cs-high" flags from all device trees in the kernel after fixing them all up.

Ok, that looks like a viable path.

BR and thanks,
Nikolaus

#14 lore raw

Re: [Letux-kernel] [PATCH 2/2] DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again

Quoted 11 lines · H. Nikolaus Schaller
Quoted 9 lines

Am 20.09.2019 um 10:55 schrieb Linus Walleij <[email protected]>:
I suggest to go both way:
apply this oneliner and tag for stable so that GTA04 works again.

Then for the next kernel think about a possible more abitious whitelist solution and after adding that remove *all* "spi-cs-high" flags from all device trees in the kernel after fixing them all up.

Ok, that looks like a viable path.

Please repost the oneline so people can ack easily. At least I've already lost track of this thread.

Regards,

Tony

#15 lore raw

Re: [Letux-kernel] [PATCH 2/2] DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again

Quoted 14 lines

Am 20.09.2019 um 16:20 schrieb Tony Lindgren <[email protected]>:

Quoted 10 lines · H. Nikolaus Schaller
Quoted 9 lines

Am 20.09.2019 um 10:55 schrieb Linus Walleij <[email protected]>:
I suggest to go both way:
apply this oneliner and tag for stable so that GTA04 works again.

Then for the next kernel think about a possible more abitious whitelist solution and after adding that remove *all* "spi-cs-high" flags from all device trees in the kernel after fixing them all up.

Quoted 4 lines
Quoted 1 line

Ok, that looks like a viable path.

Please repost the oneline so people can ack easily. At least I've already lost track of this thread.

It is all here:

https://patchwork.kernel.org/patch/11035253/

Best regards,
Nikolaus

#16 lore raw

Re: [Letux-kernel] [PATCH 2/2] DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again

Quoted 13 lines · On Fri, 20 Sep 2019 16:54:18 +0200 "H. Nikolaus Schaller" <[email protected]>…
Quoted 13 lines

Am 20.09.2019 um 16:20 schrieb Tony Lindgren <[email protected]>:

Quoted 10 lines · H. Nikolaus Schaller
Quoted 9 lines

Am 20.09.2019 um 10:55 schrieb Linus Walleij <[email protected]>:
I suggest to go both way:
apply this oneliner and tag for stable so that GTA04 works again.

Then for the next kernel think about a possible more abitious whitelist solution and after adding that remove *all* "spi-cs-high" flags from all device trees in the kernel after fixing them all up.

Quoted 9 lines
Quoted 4 lines
Quoted 1 line

Ok, that looks like a viable path.

Please repost the oneline so people can ack easily. At least I've already lost track of this thread.

It is all here:

https://patchwork.kernel.org/patch/11035253/

It is the full one (incl. documentation), not the oneline and does not apply. Now lets not discuss whether it is well documented or not. First get it fixed.

Regards,
Andreas

#17 lore raw

Re: [Letux-kernel] [PATCH 2/2] DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again

Quoted 24 lines

Am 20.09.2019 um 17:29 schrieb Andreas Kemnade <[email protected]>:

Quoted 18 lines · On Fri, 20 Sep 2019 16:54:18 +0200 "H. Nikolaus Schaller" <[email protected]>…
Quoted 17 lines

Am 20.09.2019 um 16:20 schrieb Tony Lindgren <[email protected]>:

Quoted 11 lines · H. Nikolaus Schaller
Quoted 9 lines

Am 20.09.2019 um 10:55 schrieb Linus Walleij <[email protected]>:
I suggest to go both way:
apply this oneliner and tag for stable so that GTA04 works again.

Then for the next kernel think about a possible more abitious whitelist solution and after adding that remove *all* "spi-cs-high" flags from all device trees in the kernel after fixing them all up.

Ok, that looks like a viable path.

Please repost the oneline so people can ack easily. At least I've already lost track of this thread.

Quoted 6 lines
Quoted 4 lines

It is all here:

https://patchwork.kernel.org/patch/11035253/

It is the full one (incl. documentation), not the oneline and does not apply.

Looks as if it was sitting too long in the queue and linux-next has changed the basis in the meantime, while v5.3 has not yet.

Documentation/devicetree/bindings/spi/spi-bus.txt -> spi-controller.yaml

So it should still apply for v5.3.1 and earlier and we need both versions. One for stable and one for linux-next. I don't know how to handle such cases.

BR,
Nikolaus

#18 lore raw

Re: [Letux-kernel] [PATCH 2/2] DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again

Quoted 31 lines · H. Nikolaus Schaller
Quoted 24 lines

Am 20.09.2019 um 17:29 schrieb Andreas Kemnade <[email protected]>:

Quoted 18 lines · On Fri, 20 Sep 2019 16:54:18 +0200 "H. Nikolaus Schaller" <[email protected]>…
Quoted 17 lines

Am 20.09.2019 um 16:20 schrieb Tony Lindgren <[email protected]>:

Quoted 11 lines · H. Nikolaus Schaller
Quoted 9 lines

Am 20.09.2019 um 10:55 schrieb Linus Walleij <[email protected]>:
I suggest to go both way:
apply this oneliner and tag for stable so that GTA04 works again.

Then for the next kernel think about a possible more abitious whitelist solution and after adding that remove *all* "spi-cs-high" flags from all device trees in the kernel after fixing them all up.

Ok, that looks like a viable path.

Please repost the oneline so people can ack easily. At least I've already lost track of this thread.

Quoted 6 lines
Quoted 4 lines

It is all here:

https://patchwork.kernel.org/patch/11035253/

It is the full one (incl. documentation), not the oneline and does not apply.

Quoted 7 lines

Looks as if it was sitting too long in the queue and linux-next has changed the basis in the meantime, while v5.3 has not yet.

Documentation/devicetree/bindings/spi/spi-bus.txt -> spi-controller.yaml

So it should still apply for v5.3.1 and earlier and we need both versions. One for stable and one for linux-next. I don't know how to handle such cases.

Please just repost a minimal dts one line fix. Then a separate patch for the documentation changes.

Regards,

Tony

#19 lore raw

Re: [Letux-kernel] [PATCH 2/2] DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again

In reply to H. Nikolaus Schaller
Quoted 34 lines

Am 20.09.2019 um 17:50 schrieb H. Nikolaus Schaller <[email protected]>:

Quoted 23 lines

Am 20.09.2019 um 17:29 schrieb Andreas Kemnade <[email protected]>:

Quoted 18 lines · On Fri, 20 Sep 2019 16:54:18 +0200 "H. Nikolaus Schaller" <[email protected]>…
Quoted 17 lines

Am 20.09.2019 um 16:20 schrieb Tony Lindgren <[email protected]>:

Quoted 11 lines · H. Nikolaus Schaller
Quoted 9 lines

Am 20.09.2019 um 10:55 schrieb Linus Walleij <[email protected]>:
I suggest to go both way:
apply this oneliner and tag for stable so that GTA04 works again.

Then for the next kernel think about a possible more abitious whitelist solution and after adding that remove *all* "spi-cs-high" flags from all device trees in the kernel after fixing them all up.

Ok, that looks like a viable path.

Please repost the oneline so people can ack easily. At least I've already lost track of this thread.

Quoted 6 lines
Quoted 4 lines

It is all here:

https://patchwork.kernel.org/patch/11035253/

It is the full one (incl. documentation), not the oneline and does not apply.

Quoted 7 lines

Looks as if it was sitting too long in the queue and linux-next has changed the basis in the meantime, while v5.3 has not yet.

Documentation/devicetree/bindings/spi/spi-bus.txt -> spi-controller.yaml

So it should still apply for v5.3.1 and earlier and we need both versions. One for stable and one for linux-next. I don't know how to handle such cases.

Ok, here is a correction of this statement:

It applies fine to v5.2 and v5.3 already uses the spi-controller.yaml