cooker.py: remove generation of recipe-depends.dot
v2 cover cooker.py: remove generation of recipe-depends.dot
Changes in V2:
* Remove the file to avoid misleading information
The following changes since commit 58ab85d3e005476ab5bcc288ad421c0c5d1e0582:
systemd: add PACKAGECONFIG for gnu-efi (2019-08-21 21:52:59 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib ChenQi/recipe-depends
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/recipe-depends
Chen Qi (1):
cooker.py: remove generation of recipe-depends.dot
bitbake/lib/bb/cooker.py | 25 ++++--------------------- 1 file changed, 4 insertions(+), 21 deletions(-)
Signature · 1 line
1.9.1
PATCH v2 1/1 cooker.py: remove generation of recipe-depends.dot
The information of recipe-depends.dot is misleading.
e.g.
$ grep xz recipe-depends.dot | grep bzip2 "bzip2" -> "xz" "xz" -> "bzip2"
Users would wonder why they get some circular dependency.
The information is derived from removing the task names of task-depends.dot. It's not giving people any additonal information, and it's misleading.
So we remove the generation of this file.
--- bitbake/lib/bb/cooker.py | 25 ++++--------------------- 1 file changed, 4 insertions(+), 21 deletions(-)
bitbake/lib/bb/cooker.py +4 -21
@@ -919,6 +919,10 @@ class BBCooker: os.unlink('package-depends.dot') except FileNotFoundError: pass + try: + os.unlink('recipe-depends.dot') + except FileNotFoundError: + pass with open('task-depends.dot', 'w') as f: f.write("digraph depends {\n")
@@ -932,27 +936,6 @@ class BBCooker: f.write("}\n") logger.info("Task dependencies saved to 'task-depends.dot'") - with open('recipe-depends.dot', 'w') as f: - f.write("digraph depends {\n") - pndeps = {} - for task in sorted(depgraph["tdepends"]): - (pn, taskname) = task.rsplit(".", 1) - if pn not in pndeps: - pndeps[pn] = set() - for dep in sorted(depgraph["tdepends"][task]): - (deppn, deptaskname) = dep.rsplit(".", 1) - pndeps[pn].add(deppn) - for pn in sorted(pndeps): - fn = depgraph["pn"][pn]["filename"] - version = depgraph["pn"][pn]["version"] - f.write('"%s" [label="%s\\n%s\\n%s"]\n' % (pn, pn, version, fn)) - for dep in sorted(pndeps[pn]): - if dep == pn: - continue - f.write('"%s" -> "%s"\n' % (pn, dep)) - f.write("}\n") - logger.info("Flattened recipe dependencies saved to 'recipe-depends.dot'") - def show_appends_with_no_recipes(self): # Determine which bbappends haven't been applied
Signature · 1 line
1.9.1