Declare device little or big endian
Subsystems (7)
cover Declare device little or big endian
This series is an attempt to re-declare devices with DEVICE_NATIVE_ENDIAN as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN.
This clean up was split out from an earlier series which collapsed byte swaps along the I/O path.
Quoted 11 lines · Paolo Bonzini
Quoted 7 lines · On 07/08/19 10:31, tony.nguyen@bt wrote:
Device realizing code with MemorRegionOps endianness as
DEVICE_NATIVE_ENDIANis not common code.Corrected devices were identified by making the declaration of
DEVICE_NATIVE_ENDIANconditional uponNEED_CPU_Hand then listing what failed to compile.The general approach makes sense. However, most of these should not be
DEVICE_NATIVE_ENDIAN. I can help with some of them.
An RFC as most devices I have never heard of... a collective effort is needed =)
Quoted 4 lines · Peter Maydell
OTOH it's worth noting that it's quite likely that most of the implementations of these
DEVICE_NATIVE_ENDIANdevices picked it in an equally naive way, by just copying some other device's code...
I am starting off with the following *naive* approach.
For each device declared with DEVICE_NATIVE_ENDIAN, find the set of targets from the set of target/hw/*/device.o.
If the set of targets are all little or all big endian, re-declare the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN respectively.
This *naive* deduction may result in genuinely native endian devices being incorrectly declared as little or big endian, but should not introduce regressions for current targets.
Please help spot devices which are genuinely native endian.
Thanks!
Tony Nguyen (17):
hw/audio: Declare device little or big endian hw/block: Declare device little or big endian hw/char: Declare device little or big endian hw/display: Declare device little or big endian hw/dma: Declare device little or big endian hw/gpio: Declare device little or big endian hw/i2c: Declare device little or big endian hw/input: Declare device little or big endian hw/intc: Declare device little or big endian hw/isa: Declare device little or big endian hw/misc: Declare device little or big endian hw/net: Declare device little or big endian hw/pci-host: Declare device little or big endian hw/sd: Declare device little or big endian hw/ssi: Declare device little or big endian hw/timer: Declare device little or big endian
build: Correct non-common common-obj-* to obj-*
hw/audio/Makefile.objs | 3 ++- hw/audio/cs4231.c | 2 +- hw/audio/marvell_88w8618.c | 2 +- hw/audio/milkymist-ac97.c | 2 +- hw/audio/pl041.c | 2 +- hw/block/Makefile.objs | 6 +++--- hw/block/onenand.c | 2 +- hw/char/Makefile.objs | 4 ++-- hw/char/cadence_uart.c | 2 +- hw/char/escc.c | 2 +- hw/char/etraxfs_ser.c | 2 +- hw/char/grlib_apbuart.c | 2 +- hw/char/imx_serial.c | 2 +- hw/char/lm32_uart.c | 2 +- hw/char/milkymist-uart.c | 2 +- hw/char/pl011.c | 2 +- hw/core/Makefile.objs | 2 +- hw/display/Makefile.objs | 6 +++--- hw/display/pl110.c | 2 +- hw/display/tc6393xb.c | 2 +- hw/dma/Makefile.objs | 6 +++--- hw/dma/bcm2835_dma.c | 4 ++-- hw/dma/etraxfs_dma.c | 2 +- hw/dma/pl080.c | 2 +- hw/dma/pl330.c | 2 +- hw/dma/puv3_dma.c | 2 +- hw/dma/sparc32_dma.c | 2 +- hw/gpio/Makefile.objs | 2 +- hw/gpio/pl061.c | 2 +- hw/gpio/zaurus.c | 2 +- hw/i2c/Makefile.objs | 2 +- hw/i2c/imx_i2c.c | 2 +- hw/i2c/mpc_i2c.c | 2 +- hw/i2c/versatile_i2c.c | 2 +- hw/input/Makefile.objs | 2 +- hw/input/pl050.c | 2 +- hw/intc/Makefile.objs | 6 +++--- hw/intc/arm_gic.c | 12 ++++++------ hw/intc/arm_gicv3.c | 4 ++-- hw/intc/etraxfs_pic.c | 2 +- hw/intc/imx_avic.c | 2 +- hw/intc/imx_gpcv2.c | 2 +- hw/intc/pl190.c | 2 +- hw/intc/puv3_intc.c | 2 +- hw/ipack/Makefile.objs | 2 +- hw/isa/vt82c686.c | 2 +- hw/misc/Makefile.objs | 10 +++++----- hw/misc/a9scu.c | 2 +- hw/misc/applesmc.c | 6 +++--- hw/misc/arm11scu.c | 2 +- hw/misc/arm_l2x0.c | 2 +- hw/misc/puv3_pm.c | 2 +- hw/net/Makefile.objs | 2 +- hw/net/allwinner_emac.c | 2 +- hw/net/imx_fec.c | 2 +- hw/net/lan9118.c | 4 ++-- hw/net/lance.c | 2 +- hw/net/smc91c111.c | 2 +- hw/net/stellaris_enet.c | 2 +- hw/pci-host/Makefile.objs | 2 +- hw/pci-host/q35.c | 2 +- hw/pci-host/versatile.c | 4 ++-- hw/scsi/Makefile.objs | 2 +- hw/sd/pl181.c | 2 +- hw/ssi/Makefile.objs | 2 +- hw/ssi/mss-spi.c | 2 +- hw/ssi/pl022.c | 2 +- hw/ssi/stm32f2xx_spi.c | 2 +- hw/ssi/xilinx_spips.c | 2 +- hw/timer/Makefile.objs | 6 +++--- hw/timer/a9gtimer.c | 4 ++-- hw/timer/arm_mptimer.c | 4 ++-- hw/timer/arm_timer.c | 4 ++-- hw/timer/armv7m_systick.c | 2 +- hw/timer/aspeed_rtc.c | 2 +- hw/timer/cadence_ttc.c | 2 +- hw/timer/grlib_gptimer.c | 2 +- hw/timer/hpet.c | 2 +- hw/timer/imx_epit.c | 2 +- hw/timer/imx_gpt.c | 2 +- hw/timer/lm32_timer.c | 2 +- hw/timer/milkymist-sysctl.c | 2 +- hw/timer/mss-timer.c | 2 +- hw/timer/pl031.c | 2 +- hw/timer/stm32f2xx_timer.c | 2 +- hw/timer/sun4v-rtc.c | 2 +- hw/virtio/Makefile.objs | 2 +- 87 files changed, 117 insertions(+), 116 deletions(-)
Signature · 1 line
2.23.0
RFC PATCH 1/17 hw/audio: Declare device little or big endian
For each device declared with DEVICE_NATIVE_ENDIAN, find the set of targets from the set of target/hw/*/device.o.
If the set of targets are all little or all big endian, re-declare the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN respectively.
This *naive* deduction may result in genuinely native endian devices being incorrectly declared as little or big endian, but should not introduce regressions for current targets.
These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it has a new target with an opposite endian or 2) someone informed knows better =)
--- hw/audio/cs4231.c | 2 +- hw/audio/marvell_88w8618.c | 2 +- hw/audio/milkymist-ac97.c | 2 +- hw/audio/pl041.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
hw/audio/cs4231.c +1 -1
@@ -133,7 +133,7 @@ static void cs_mem_write(void *opaque, hwaddr addr,static const MemoryRegionOps cs_mem_ops = { .read = cs_mem_read, .write = cs_mem_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_BIG_ENDIAN , };static const VMStateDescription vmstate_cs4231 = {
hw/audio/marvell_88w8618.c +1 -1
@@ -242,7 +242,7 @@ static void mv88w8618_audio_reset(DeviceState *d)static const MemoryRegionOps mv88w8618_audio_ops = { .read = mv88w8618_audio_read, .write = mv88w8618_audio_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static void mv88w8618_audio_init (Object *obj)
hw/audio/milkymist-ac97.c +1 -1
@@ -177,7 +177,7 @@ static const MemoryRegionOps ac97_mmio_ops = { .min_access_size = 4, .max_access_size = 4, }, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_BIG_ENDIAN, };static void ac97_in_cb (void *opaque,int avail_b)
hw/audio/pl041.c +1 -1
@@ -522,7 +522,7 @@ static void pl041_device_reset(DeviceState *d)static const MemoryRegionOps pl041_ops = { .read = pl041_read, .write = pl041_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static void pl041_init (Object *obj)
Signature · 1 line
2.23.0
RFC PATCH 2/17 hw/block: Declare device little or big endian
In reply to Tony NguyenFor each device declared with DEVICE_NATIVE_ENDIAN, find the set of targets from the set of target/hw/*/device.o.
If the set of targets are all little or all big endian, re-declare the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN respectively.
This *naive* deduction may result in genuinely native endian devices being incorrectly declared as little or big endian, but should not introduce regressions for current targets.
These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it has a new target with an opposite endian or 2) someone informed knows better =)
--- hw/block/onenand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
hw/block/onenand.c +1 -1
@@ -771,7 +771,7 @@ static void onenand_write(void *opaque, hwaddr addr,static const MemoryRegionOps onenand_ops = { .read = onenand_read, .write = onenand_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static void onenand_realize (DeviceState *dev,Error **errp)
Signature · 1 line
2.23.0
RFC PATCH 3/17 hw/char: Declare device little or big endian
In reply to Tony NguyenFor each device declared with DEVICE_NATIVE_ENDIAN, find the set of targets from the set of target/hw/*/device.o.
If the set of targets are all little or all big endian, re-declare the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN respectively.
This *naive* deduction may result in genuinely native endian devices being incorrectly declared as little or big endian, but should not introduce regressions for current targets.
These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it has a new target with an opposite endian or 2) someone informed knows better =)
--- hw/char/cadence_uart.c | 2 +- hw/char/escc.c | 2 +- hw/char/etraxfs_ser.c | 2 +- hw/char/grlib_apbuart.c | 2 +- hw/char/imx_serial.c | 2 +- hw/char/lm32_uart.c | 2 +- hw/char/milkymist-uart.c | 2 +- hw/char/pl011.c | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-)
hw/char/cadence_uart.c +1 -1
@@ -459,7 +459,7 @@ static uint64_t uart_read(void *opaque, hwaddr offset,static const MemoryRegionOps uart_ops = { .read = uart_read, .write = uart_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static void cadence_uart_reset (DeviceState *dev)
hw/char/escc.c +1 -1
@@ -576,7 +576,7 @@ static uint64_t escc_mem_read(void *opaque, hwaddr addr,static const MemoryRegionOps escc_mem_ops = { .read = escc_mem_read, .write = escc_mem_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_BIG_ENDIAN , .valid = { .min_access_size =1 , .max_access_size =1 ,
hw/char/etraxfs_ser.c +1 -1
@@ -157,7 +157,7 @@ ser_write(void *opaque, hwaddr addr,static const MemoryRegionOps ser_ops = { .read = ser_read, .write = ser_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , .valid = { .min_access_size =4 , .max_access_size =4
hw/char/grlib_apbuart.c +1 -1
@@ -239,7 +239,7 @@ static void grlib_apbuart_write(void *opaque, hwaddr addr,static const MemoryRegionOps grlib_apbuart_ops = { .write = grlib_apbuart_write, .read = grlib_apbuart_read, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_BIG_ENDIAN , };static void grlib_apbuart_realize (DeviceState *dev,Error **errp)
hw/char/imx_serial.c +1 -1
@@ -334,7 +334,7 @@ static void imx_event(void *opaque, int event)static const struct MemoryRegionOps imx_serial_ops = { .read = imx_serial_read, .write = imx_serial_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static void imx_serial_realize (DeviceState *dev,Error **errp)
hw/char/lm32_uart.c +1 -1
@@ -207,7 +207,7 @@ static void uart_write(void *opaque, hwaddr addr,static const MemoryRegionOps uart_ops = { .read = uart_read, .write = uart_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_BIG_ENDIAN , .valid = { .min_access_size =4 , .max_access_size =4 ,
hw/char/milkymist-uart.c +1 -1
@@ -158,7 +158,7 @@ static const MemoryRegionOps uart_mmio_ops = { .min_access_size = 4, .max_access_size = 4, }, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_BIG_ENDIAN, };static void uart_rx (void *opaque,const uint8_t *buf,int size)
hw/char/pl011.c +1 -1
@@ -289,7 +289,7 @@ static void pl011_event(void *opaque, int event)static const MemoryRegionOps pl011_ops = { .read = pl011_read, .write = pl011_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static const VMStateDescription vmstate_pl011 = {
Signature · 1 line
2.23.0
RFC PATCH 4/17 hw/display: Declare device little or big endian
In reply to Tony NguyenFor each device declared with DEVICE_NATIVE_ENDIAN, find the set of targets from the set of target/hw/*/device.o.
If the set of targets are all little or all big endian, re-declare the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN respectively.
This *naive* deduction may result in genuinely native endian devices being incorrectly declared as little or big endian, but should not introduce regressions for current targets.
These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it has a new target with an opposite endian or 2) someone informed knows better =)
--- hw/display/pl110.c | 2 +- hw/display/tc6393xb.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
hw/display/pl110.c +1 -1
@@ -473,7 +473,7 @@ static void pl110_write(void *opaque, hwaddr offset,static const MemoryRegionOps pl110_ops = { .read = pl110_read, .write = pl110_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static void pl110_mux_ctrl_set (void *opaque,int line,int level)
hw/display/tc6393xb.c +1 -1
@@ -549,7 +549,7 @@ TC6393xbState *tc6393xb_init(MemoryRegion *sysmem, uint32_t base, qemu_irq irq)static const MemoryRegionOps tc6393xb_ops = { .read = tc6393xb_readb, .write = tc6393xb_writeb, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , .impl = { .min_access_size =1 , .max_access_size =1 ,
Signature · 1 line
2.23.0
RFC PATCH 5/17 hw/dma: Declare device little or big endian
In reply to Tony NguyenFor each device declared with DEVICE_NATIVE_ENDIAN, find the set of targets from the set of target/hw/*/device.o.
If the set of targets are all little or all big endian, re-declare the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN respectively.
This *naive* deduction may result in genuinely native endian devices being incorrectly declared as little or big endian, but should not introduce regressions for current targets.
These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it has a new target with an opposite endian or 2) someone informed knows better =)
--- hw/dma/bcm2835_dma.c | 4 ++-- hw/dma/etraxfs_dma.c | 2 +- hw/dma/pl080.c | 2 +- hw/dma/pl330.c | 2 +- hw/dma/puv3_dma.c | 2 +- hw/dma/sparc32_dma.c | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-)
hw/dma/bcm2835_dma.c +2 -2
@@ -290,7 +290,7 @@ static void bcm2835_dma15_write(void *opaque, hwaddr offset, uint64_t value,static const MemoryRegionOps bcm2835_dma0_ops = { .read = bcm2835_dma0_read, .write = bcm2835_dma0_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , .valid.min_access_size =4 , .valid.max_access_size =4 , };
@@ -298,7 +298,7 @@ static const MemoryRegionOps bcm2835_dma0_ops = {static const MemoryRegionOps bcm2835_dma15_ops = { .read = bcm2835_dma15_read, .write = bcm2835_dma15_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , .valid.min_access_size =4 , .valid.max_access_size =4 , };
hw/dma/etraxfs_dma.c +1 -1
@@ -700,7 +700,7 @@ dma_write(void *opaque, hwaddr addr,static const MemoryRegionOps dma_ops = { .read = dma_read, .write = dma_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , .valid = { .min_access_size =1 , .max_access_size =4
hw/dma/pl080.c +1 -1
@@ -350,7 +350,7 @@ static void pl080_write(void *opaque, hwaddr offset,static const MemoryRegionOps pl080_ops = { .read = pl080_read, .write = pl080_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static void pl080_reset (DeviceState *dev)
hw/dma/pl330.c +1 -1
@@ -1496,7 +1496,7 @@ static uint64_t pl330_iomem_read(void *opaque, hwaddr offset,static const MemoryRegionOps pl330_ops = { .read = pl330_iomem_read, .write = pl330_iomem_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , .impl = { .min_access_size =4 , .max_access_size =4 ,
hw/dma/puv3_dma.c +1 -1
@@ -74,7 +74,7 @@ static const MemoryRegionOps puv3_dma_ops = { .min_access_size = 4, .max_access_size = 4, }, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, };static void puv3_dma_realize (DeviceState *dev,Error **errp)
hw/dma/sparc32_dma.c +1 -1
@@ -226,7 +226,7 @@ static void dma_mem_write(void *opaque, hwaddr addr,static const MemoryRegionOps dma_mem_ops = { .read = dma_mem_read, .write = dma_mem_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_BIG_ENDIAN , .valid = { .min_access_size =4 , .max_access_size =4 ,
Signature · 1 line
2.23.0
RFC PATCH 6/17 hw/gpio: Declare device little or big endian
In reply to Tony NguyenFor each device declared with DEVICE_NATIVE_ENDIAN, find the set of targets from the set of target/hw/*/device.o.
If the set of targets are all little or all big endian, re-declare the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN respectively.
This *naive* deduction may result in genuinely native endian devices being incorrectly declared as little or big endian, but should not introduce regressions for current targets.
These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it has a new target with an opposite endian or 2) someone informed knows better =)
--- hw/gpio/pl061.c | 2 +- hw/gpio/zaurus.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
hw/gpio/pl061.c +1 -1
@@ -341,7 +341,7 @@ static void pl061_set_irq(void * opaque, int irq, int level)static const MemoryRegionOps pl061_ops = { .read = pl061_read, .write = pl061_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static void pl061_luminary_init (Object *obj)
hw/gpio/zaurus.c +1 -1
@@ -157,7 +157,7 @@ static void scoop_write(void *opaque, hwaddr addr,static const MemoryRegionOps scoop_ops = { .read = scoop_read, .write = scoop_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static void scoop_gpio_set (void *opaque,int line,int level)
Signature · 1 line
2.23.0
RFC PATCH 7/17 hw/i2c: Declare device little or big endian
In reply to Tony NguyenFor each device declared with DEVICE_NATIVE_ENDIAN, find the set of targets from the set of target/hw/*/device.o.
If the set of targets are all little or all big endian, re-declare the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN respectively.
This *naive* deduction may result in genuinely native endian devices being incorrectly declared as little or big endian, but should not introduce regressions for current targets.
These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it has a new target with an opposite endian or 2) someone informed knows better =)
--- hw/i2c/imx_i2c.c | 2 +- hw/i2c/mpc_i2c.c | 2 +- hw/i2c/versatile_i2c.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
hw/i2c/imx_i2c.c +1 -1
@@ -278,7 +278,7 @@ static const MemoryRegionOps imx_i2c_ops = { .write = imx_i2c_write, .valid.min_access_size = 1, .valid.max_access_size = 2, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, };static const VMStateDescription imx_i2c_vmstate = {
hw/i2c/mpc_i2c.c +1 -1
@@ -306,7 +306,7 @@ static const MemoryRegionOps i2c_ops = { .read = mpc_i2c_read, .write = mpc_i2c_write, .valid.max_access_size = 1, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_BIG_ENDIAN, };static const VMStateDescription mpc_i2c_vmstate = {
hw/i2c/versatile_i2c.c +1 -1
@@ -77,7 +77,7 @@ static void versatile_i2c_write(void *opaque, hwaddr offset,static const MemoryRegionOps versatile_i2c_ops = { .read = versatile_i2c_read, .write = versatile_i2c_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static void versatile_i2c_init (Object *obj)
Signature · 1 line
2.23.0
Re: [Qemu-arm] [Qemu-devel] [RFC PATCH 07/17] hw/i2c: Declare device little or big endian
Quoted 15 lines · Tony Nguyen
For each device declared with
DEVICE_NATIVE_ENDIAN, find the set of targets from the set oftarget/hw/*/device.o.If the set of targets are all little or all big endian, re-declare the device endianness as
DEVICE_LITTLE_ENDIANorDEVICE_BIG_ENDIANrespectively.This *naive* deduction may result in genuinely native endian devices being incorrectly declared as little or big endian, but should not introduce regressions for current targets.
These devices should be re-declared as
DEVICE_NATIVE_ENDIANif 1) it has a new target with an opposite endian or 2) someone informed knows better =)
Quoted 6 lines
Signed-off-by Tony Nguyen <[email protected]>--- hw/i2c/imx_i2c.c | 2 +- hw/i2c/mpc_i2c.c | 2 +- hw/i2c/versatile_i2c.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
ppc part (mpc_i2c.c)
Quoted 40 lines
hw/i2c/imx_i2c.c +1
-1@@ -278,7 +278,7 @@ static const MemoryRegionOps imx_i2c_ops = { .write = imx_i2c_write, .valid.min_access_size = 1, .valid.max_access_size = 2, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, };static const VMStateDescription imx_i2c_vmstate = {hw/i2c/mpc_i2c.c +1
-1@@ -306,7 +306,7 @@ static const MemoryRegionOps i2c_ops = { .read = mpc_i2c_read, .write = mpc_i2c_write, .valid.max_access_size = 1, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_BIG_ENDIAN, };static const VMStateDescription mpc_i2c_vmstate = {hw/i2c/versatile_i2c.c +1
-1@@ -77,7 +77,7 @@ static void versatile_i2c_write(void *opaque, hwaddr offset,static const MemoryRegionOps versatile_i2c_ops = { .read = versatile_i2c_read, .write = versatile_i2c_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static void versatile_i2c_init (Object *obj)
Signature · 4 lines
David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
RFC PATCH 8/17 hw/input: Declare device little or big endian
In reply to Tony NguyenFor each device declared with DEVICE_NATIVE_ENDIAN, find the set of targets from the set of target/hw/*/device.o.
If the set of targets are all little or all big endian, re-declare the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN respectively.
This *naive* deduction may result in genuinely native endian devices being incorrectly declared as little or big endian, but should not introduce regressions for current targets.
These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it has a new target with an opposite endian or 2) someone informed knows better =)
--- hw/input/pl050.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
hw/input/pl050.c +1 -1
@@ -139,7 +139,7 @@ static void pl050_write(void *opaque, hwaddr offset,static const MemoryRegionOps pl050_ops = { .read = pl050_read, .write = pl050_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static void pl050_realize (DeviceState *dev,Error **errp)
Signature · 1 line
2.23.0
RFC PATCH 9/17 hw/intc: Declare device little or big endian
In reply to Tony NguyenFor each device declared with DEVICE_NATIVE_ENDIAN, find the set of targets from the set of target/hw/*/device.o.
If the set of targets are all little or all big endian, re-declare the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN respectively.
This *naive* deduction may result in genuinely native endian devices being incorrectly declared as little or big endian, but should not introduce regressions for current targets.
These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it has a new target with an opposite endian or 2) someone informed knows better =)
--- hw/intc/arm_gic.c | 12 ++++++------ hw/intc/arm_gicv3.c | 4 ++-- hw/intc/etraxfs_pic.c | 2 +- hw/intc/imx_avic.c | 2 +- hw/intc/imx_gpcv2.c | 2 +- hw/intc/pl190.c | 2 +- hw/intc/puv3_intc.c | 2 +- 7 files changed, 13 insertions(+), 13 deletions(-)
hw/intc/arm_gic.c +6 -6
@@ -2000,38 +2000,38 @@ static const MemoryRegionOps gic_ops[2] = { { .read_with_attrs = gic_dist_read, .write_with_attrs = gic_dist_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, }, { .read_with_attrs = gic_thiscpu_read, .write_with_attrs = gic_thiscpu_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, } };static const MemoryRegionOps gic_cpu_ops = { .read_with_attrs = gic_do_cpu_read, .write_with_attrs = gic_do_cpu_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static const MemoryRegionOps gic_virt_ops[2 ] = { { .read_with_attrs = gic_thiscpu_hyp_read, .write_with_attrs = gic_thiscpu_hyp_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , }, { .read_with_attrs = gic_thisvcpu_read, .write_with_attrs = gic_thisvcpu_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , } };static const MemoryRegionOps gic_viface_ops = { .read_with_attrs = gic_do_hyp_read, .write_with_attrs = gic_do_hyp_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static void arm_gic_realize (DeviceState *dev,Error **errp)
hw/intc/arm_gicv3.c +2 -2
@@ -352,12 +352,12 @@ static const MemoryRegionOps gic_ops[] = { { .read_with_attrs = gicv3_dist_read, .write_with_attrs = gicv3_dist_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, }, { .read_with_attrs = gicv3_redist_read, .write_with_attrs = gicv3_redist_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, } };
hw/intc/etraxfs_pic.c +1 -1
@@ -112,7 +112,7 @@ static void pic_write(void *opaque, hwaddr addr,static const MemoryRegionOps pic_ops = { .read = pic_read, .write = pic_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , .valid = { .min_access_size =4 , .max_access_size =4
hw/intc/imx_avic.c +1 -1
@@ -310,7 +310,7 @@ static void imx_avic_write(void *opaque, hwaddr offset,static const MemoryRegionOps imx_avic_ops = { .read = imx_avic_read, .write = imx_avic_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static void imx_avic_reset (DeviceState *dev)
hw/intc/imx_gpcv2.c +1 -1
@@ -65,7 +65,7 @@ static void imx_gpcv2_write(void *opaque, hwaddr offset,static const struct MemoryRegionOps imx_gpcv2_ops = { .read = imx_gpcv2_read, .write = imx_gpcv2_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , .impl = {/* * Our device would not work correctly if the guest was doing
hw/intc/pl190.c +1 -1
@@ -222,7 +222,7 @@ static void pl190_write(void *opaque, hwaddr offset,static const MemoryRegionOps pl190_ops = { .read = pl190_read, .write = pl190_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static void pl190_reset (DeviceState *d)
hw/intc/puv3_intc.c +1 -1
@@ -101,7 +101,7 @@ static const MemoryRegionOps puv3_intc_ops = { .min_access_size = 4, .max_access_size = 4, }, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, };static void puv3_intc_realize (DeviceState *dev,Error **errp)
Signature · 1 line
2.23.0
RFC PATCH 10/17 hw/isa: Declare device little or big endian
In reply to Tony NguyenFor each device declared with DEVICE_NATIVE_ENDIAN, find the set of targets from the set of target/hw/*/device.o.
If the set of targets are all little or all big endian, re-declare the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN respectively.
This *naive* deduction may result in genuinely native endian devices being incorrectly declared as little or big endian, but should not introduce regressions for current targets.
These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it has a new target with an opposite endian or 2) someone informed knows better =)
--- hw/isa/vt82c686.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
hw/isa/vt82c686.c +1 -1
@@ -109,7 +109,7 @@ static uint64_t superio_ioport_readb(void *opaque, hwaddr addr, unsigned size)static const MemoryRegionOps superio_ops = { .read = superio_ioport_readb, .write = superio_ioport_writeb, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , .impl = { .min_access_size =1 , .max_access_size =1 ,
Signature · 1 line
2.23.0
RFC PATCH 11/17 hw/misc: Declare device little or big endian
In reply to Tony NguyenFor each device declared with DEVICE_NATIVE_ENDIAN, find the set of targets from the set of target/hw/*/device.o.
If the set of targets are all little or all big endian, re-declare the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN respectively.
This *naive* deduction may result in genuinely native endian devices being incorrectly declared as little or big endian, but should not introduce regressions for current targets.
These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it has a new target with an opposite endian or 2) someone informed knows better =)
--- hw/misc/a9scu.c | 2 +- hw/misc/applesmc.c | 6 +++--- hw/misc/arm11scu.c | 2 +- hw/misc/arm_l2x0.c | 2 +- hw/misc/puv3_pm.c | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-)
hw/misc/a9scu.c +1 -1
@@ -96,7 +96,7 @@ static void a9_scu_write(void *opaque, hwaddr offset,static const MemoryRegionOps a9_scu_ops = { .read = a9_scu_read, .write = a9_scu_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static void a9_scu_reset (DeviceState *dev)
hw/misc/applesmc.c +3 -3
@@ -285,7 +285,7 @@ static void qdev_applesmc_isa_reset(DeviceState *dev)static const MemoryRegionOps applesmc_data_io_ops = { .write = applesmc_io_data_write, .read = applesmc_io_data_read, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , .impl = { .min_access_size =1 , .max_access_size =1 ,
@@ -295,7 +295,7 @@ static const MemoryRegionOps applesmc_data_io_ops = {static const MemoryRegionOps applesmc_cmd_io_ops = { .write = applesmc_io_cmd_write, .read = applesmc_io_cmd_read, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , .impl = { .min_access_size =1 , .max_access_size =1 ,
@@ -305,7 +305,7 @@ static const MemoryRegionOps applesmc_cmd_io_ops = {static const MemoryRegionOps applesmc_err_io_ops = { .write = applesmc_io_err_write, .read = applesmc_io_err_read, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , .impl = { .min_access_size =1 , .max_access_size =1 ,
hw/misc/arm11scu.c +1 -1
@@ -58,7 +58,7 @@ static void mpcore_scu_write(void *opaque, hwaddr offset,static const MemoryRegionOps mpcore_scu_ops = { .read = mpcore_scu_read, .write = mpcore_scu_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static void arm11_scu_realize (DeviceState *dev,Error **errp)
hw/misc/arm_l2x0.c +1 -1
@@ -159,7 +159,7 @@ static void l2x0_priv_reset(DeviceState *dev)static const MemoryRegionOps l2x0_mem_ops = { .read = l2x0_priv_read, .write = l2x0_priv_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static void l2x0_priv_init (Object *obj)
hw/misc/puv3_pm.c +1 -1
@@ -117,7 +117,7 @@ static const MemoryRegionOps puv3_pm_ops = { .min_access_size = 4, .max_access_size = 4, }, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, };static void puv3_pm_realize (DeviceState *dev,Error **errp)
Signature · 1 line
2.23.0
RFC PATCH 12/17 hw/net: Declare device little or big endian
In reply to Tony NguyenFor each device declared with DEVICE_NATIVE_ENDIAN, find the set of targets from the set of target/hw/*/device.o.
If the set of targets are all little or all big endian, re-declare the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN respectively.
This *naive* deduction may result in genuinely native endian devices being incorrectly declared as little or big endian, but should not introduce regressions for current targets.
These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it has a new target with an opposite endian or 2) someone informed knows better =)
--- hw/net/allwinner_emac.c | 2 +- hw/net/imx_fec.c | 2 +- hw/net/lan9118.c | 4 ++-- hw/net/lance.c | 2 +- hw/net/smc91c111.c | 2 +- hw/net/stellaris_enet.c | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-)
hw/net/allwinner_emac.c +1 -1
@@ -421,7 +421,7 @@ static void aw_emac_set_link(NetClientState *nc)static const MemoryRegionOps aw_emac_mem_ops = { .read = aw_emac_read, .write = aw_emac_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , .valid = { .min_access_size =4 , .max_access_size =4 ,
hw/net/imx_fec.c +1 -1
@@ -1285,7 +1285,7 @@ static const MemoryRegionOps imx_eth_ops = { .write = imx_eth_write, .valid.min_access_size = 4, .valid.max_access_size = 4, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, };static void imx_eth_cleanup (NetClientState *nc)
hw/net/lan9118.c +2 -2
@@ -1308,13 +1308,13 @@ static uint64_t lan9118_16bit_mode_read(void *opaque, hwaddr offset,static const MemoryRegionOps lan9118_mem_ops = { .read = lan9118_readl, .write = lan9118_writel, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static const MemoryRegionOps lan9118_16bit_mem_ops = { .read = lan9118_16bit_mode_read, .write = lan9118_16bit_mode_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static NetClientInfo net_lan9118_info = {
hw/net/lance.c +1 -1
@@ -76,7 +76,7 @@ static uint64_t lance_mem_read(void *opaque, hwaddr addr,static const MemoryRegionOps lance_mem_ops = { .read = lance_mem_read, .write = lance_mem_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_BIG_ENDIAN , .valid = { .min_access_size =2 , .max_access_size =2 ,
hw/net/smc91c111.c +1 -1
@@ -760,7 +760,7 @@ static const MemoryRegionOps smc91c111_mem_ops = { .write = smc91c111_writefn, .valid.min_access_size = 1, .valid.max_access_size = 4, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, };static NetClientInfo net_smc91c111_info = {
hw/net/stellaris_enet.c +1 -1
@@ -459,7 +459,7 @@ static void stellaris_enet_write(void *opaque, hwaddr offset,static const MemoryRegionOps stellaris_enet_ops = { .read = stellaris_enet_read, .write = stellaris_enet_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static void stellaris_enet_reset (DeviceState *dev)
Signature · 1 line
2.23.0
RFC PATCH 13/17 hw/pci-host: Declare device little or big endian
In reply to Tony NguyenFor each device declared with DEVICE_NATIVE_ENDIAN, find the set of targets from the set of target/hw/*/device.o.
If the set of targets are all little or all big endian, re-declare the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN respectively.
This *naive* deduction may result in genuinely native endian devices being incorrectly declared as little or big endian, but should not introduce regressions for current targets.
These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it has a new target with an opposite endian or 2) someone informed knows better =)
--- hw/pci-host/q35.c | 2 +- hw/pci-host/versatile.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
hw/pci-host/q35.c +1 -1
@@ -289,7 +289,7 @@ static void tseg_blackhole_write(void *opaque, hwaddr addr, uint64_t val,static const MemoryRegionOps tseg_blackhole_ops = { .read = tseg_blackhole_read, .write = tseg_blackhole_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , .valid.min_access_size =1 , .valid.max_access_size =4 , .impl.min_access_size =4 ,
hw/pci-host/versatile.c +2 -2
@@ -243,7 +243,7 @@ static uint64_t pci_vpb_reg_read(void *opaque, hwaddr addr,static const MemoryRegionOps pci_vpb_reg_ops = { .read = pci_vpb_reg_read, .write = pci_vpb_reg_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , .valid = { .min_access_size =4 , .max_access_size =4 ,
@@ -309,7 +309,7 @@ static uint64_t pci_vpb_config_read(void *opaque, hwaddr addr,static const MemoryRegionOps pci_vpb_config_ops = { .read = pci_vpb_config_read, .write = pci_vpb_config_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static int pci_vpb_map_irq (PCIDevice *d,int irq_num)
Signature · 1 line
2.23.0
RFC PATCH 14/17 hw/sd: Declare device little or big endian
In reply to Tony NguyenFor each device declared with DEVICE_NATIVE_ENDIAN, find the set of targets from the set of target/hw/*/device.o.
If the set of targets are all little or all big endian, re-declare the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN respectively.
This *naive* deduction may result in genuinely native endian devices being incorrectly declared as little or big endian, but should not introduce regressions for current targets.
These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it has a new target with an opposite endian or 2) someone informed knows better =)
--- hw/sd/pl181.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
hw/sd/pl181.c +1 -1
@@ -451,7 +451,7 @@ static void pl181_write(void *opaque, hwaddr offset,static const MemoryRegionOps pl181_ops = { .read = pl181_read, .write = pl181_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static void pl181_reset (DeviceState *d)
Signature · 1 line
2.23.0
RFC PATCH 15/17 hw/ssi: Declare device little or big endian
In reply to Tony NguyenFor each device declared with DEVICE_NATIVE_ENDIAN, find the set of targets from the set of target/hw/*/device.o.
If the set of targets are all little or all big endian, re-declare the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN respectively.
This *naive* deduction may result in genuinely native endian devices being incorrectly declared as little or big endian, but should not introduce regressions for current targets.
These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it has a new target with an opposite endian or 2) someone informed knows better =)
--- hw/ssi/mss-spi.c | 2 +- hw/ssi/pl022.c | 2 +- hw/ssi/stm32f2xx_spi.c | 2 +- hw/ssi/xilinx_spips.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
hw/ssi/mss-spi.c +1 -1
@@ -361,7 +361,7 @@ static void spi_write(void *opaque, hwaddr addr,static const MemoryRegionOps spi_ops = { .read = spi_read, .write = spi_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , .valid = { .min_access_size =1 , .max_access_size =4
hw/ssi/pl022.c +1 -1
@@ -228,7 +228,7 @@ static void pl022_reset(DeviceState *dev)static const MemoryRegionOps pl022_ops = { .read = pl022_read, .write = pl022_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static int pl022_post_load (void *opaque,int version_id)
hw/ssi/stm32f2xx_spi.c +1 -1
@@ -167,7 +167,7 @@ static void stm32f2xx_spi_write(void *opaque, hwaddr addr,static const MemoryRegionOps stm32f2xx_spi_ops = { .read = stm32f2xx_spi_read, .write = stm32f2xx_spi_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static const VMStateDescription vmstate_stm32f2xx_spi = {
hw/ssi/xilinx_spips.c +1 -1
@@ -1240,7 +1240,7 @@ static MemTxResult lqspi_write(void *opaque, hwaddr offset, uint64_t value,static const MemoryRegionOps lqspi_ops = { .read_with_attrs = lqspi_read, .write_with_attrs = lqspi_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , .impl = { .min_access_size =4 , .max_access_size =4 ,
Signature · 1 line
2.23.0
RFC PATCH 16/17 hw/timer: Declare device little or big endian
In reply to Tony NguyenFor each device declared with DEVICE_NATIVE_ENDIAN, find the set of targets from the set of target/hw/*/device.o.
If the set of targets are all little or all big endian, re-declare the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN respectively.
This *naive* deduction may result in genuinely native endian devices being incorrectly declared as little or big endian, but should not introduce regressions for current targets.
These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it has a new target with an opposite endian or 2) someone informed knows better =)
--- hw/timer/a9gtimer.c | 4 ++-- hw/timer/arm_mptimer.c | 4 ++-- hw/timer/arm_timer.c | 4 ++-- hw/timer/armv7m_systick.c | 2 +- hw/timer/aspeed_rtc.c | 2 +- hw/timer/cadence_ttc.c | 2 +- hw/timer/grlib_gptimer.c | 2 +- hw/timer/hpet.c | 2 +- hw/timer/imx_epit.c | 2 +- hw/timer/imx_gpt.c | 2 +- hw/timer/lm32_timer.c | 2 +- hw/timer/milkymist-sysctl.c | 2 +- hw/timer/mss-timer.c | 2 +- hw/timer/pl031.c | 2 +- hw/timer/stm32f2xx_timer.c | 2 +- hw/timer/sun4v-rtc.c | 2 +- 16 files changed, 19 insertions(+), 19 deletions(-)
hw/timer/a9gtimer.c +2 -2
@@ -258,7 +258,7 @@ static const MemoryRegionOps a9_gtimer_this_ops = { .min_access_size = 4, .max_access_size = 4, }, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, }; static const MemoryRegionOps a9_gtimer_ops = {
@@ -268,7 +268,7 @@ static const MemoryRegionOps a9_gtimer_ops = { .min_access_size = 4, .max_access_size = 4, }, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, };static void a9_gtimer_reset (DeviceState *dev)
hw/timer/arm_mptimer.c +2 -2
@@ -194,7 +194,7 @@ static const MemoryRegionOps arm_thistimer_ops = { .min_access_size = 4, .max_access_size = 4, }, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, }; static const MemoryRegionOps timerblock_ops = {
@@ -204,7 +204,7 @@ static const MemoryRegionOps timerblock_ops = { .min_access_size = 4, .max_access_size = 4, }, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, };static void timerblock_reset (TimerBlock *tb)
hw/timer/arm_timer.c +2 -2
@@ -267,7 +267,7 @@ static void sp804_write(void *opaque, hwaddr offset,static const MemoryRegionOps sp804_ops = { .read = sp804_read, .write = sp804_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static const VMStateDescription vmstate_sp804 = {
@@ -348,7 +348,7 @@ static void icp_pit_write(void *opaque, hwaddr offset,static const MemoryRegionOps icp_pit_ops = { .read = icp_pit_read, .write = icp_pit_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static void icp_pit_init (Object *obj)
hw/timer/armv7m_systick.c +1 -1
@@ -193,7 +193,7 @@ static MemTxResult systick_write(void *opaque, hwaddr addr,static const MemoryRegionOps systick_ops = { .read_with_attrs = systick_read, .write_with_attrs = systick_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , .valid.min_access_size =4 , .valid.max_access_size =4 , };
hw/timer/aspeed_rtc.c +1 -1
@@ -131,7 +131,7 @@ static void aspeed_rtc_reset(DeviceState *d)static const MemoryRegionOps aspeed_rtc_ops = { .read = aspeed_rtc_read, .write = aspeed_rtc_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static const VMStateDescription vmstate_aspeed_rtc = {
hw/timer/cadence_ttc.c +1 -1
@@ -391,7 +391,7 @@ static void cadence_ttc_write(void *opaque, hwaddr offset,static const MemoryRegionOps cadence_ttc_ops = { .read = cadence_ttc_read, .write = cadence_ttc_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static void cadence_timer_reset (CadenceTimerState *s)
hw/timer/grlib_gptimer.c +1 -1
@@ -315,7 +315,7 @@ static void grlib_gptimer_write(void *opaque, hwaddr addr,static const MemoryRegionOps grlib_gptimer_ops = { .read = grlib_gptimer_read, .write = grlib_gptimer_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_BIG_ENDIAN , .valid = { .min_access_size =4 , .max_access_size =4 ,
hw/timer/hpet.c +1 -1
@@ -676,7 +676,7 @@ static const MemoryRegionOps hpet_ram_ops = { .min_access_size = 4, .max_access_size = 4, }, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, };static void hpet_reset (DeviceState *d)
hw/timer/imx_epit.c +1 -1
@@ -284,7 +284,7 @@ static void imx_epit_cmp(void *opaque)static const MemoryRegionOps imx_epit_ops = { .read = imx_epit_read, .write = imx_epit_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static const VMStateDescription vmstate_imx_timer_epit = {
hw/timer/imx_gpt.c +1 -1
@@ -476,7 +476,7 @@ static void imx_gpt_timeout(void *opaque)static const MemoryRegionOps imx_gpt_ops = { .read = imx_gpt_read, .write = imx_gpt_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };
hw/timer/lm32_timer.c +1 -1
@@ -146,7 +146,7 @@ static void timer_write(void *opaque, hwaddr addr,static const MemoryRegionOps timer_ops = { .read = timer_read, .write = timer_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_BIG_ENDIAN , .valid = { .min_access_size =4 , .max_access_size =4 ,
hw/timer/milkymist-sysctl.c +1 -1
@@ -223,7 +223,7 @@ static const MemoryRegionOps sysctl_mmio_ops = { .min_access_size = 4, .max_access_size = 4, }, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_BIG_ENDIAN, };static void timer0_hit (void *opaque)
hw/timer/mss-timer.c +1 -1
@@ -200,7 +200,7 @@ timer_write(void *opaque, hwaddr offset,static const MemoryRegionOps timer_ops = { .read = timer_read, .write = timer_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , .valid = { .min_access_size =1 , .max_access_size =4
hw/timer/pl031.c +1 -1
@@ -178,7 +178,7 @@ static void pl031_write(void * opaque, hwaddr offset,static const MemoryRegionOps pl031_ops = { .read = pl031_read, .write = pl031_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static void pl031_init (Object *obj)
hw/timer/stm32f2xx_timer.c +1 -1
@@ -268,7 +268,7 @@ static void stm32f2xx_timer_write(void *opaque, hwaddr offset,static const MemoryRegionOps stm32f2xx_timer_ops = { .read = stm32f2xx_timer_read, .write = stm32f2xx_timer_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_LITTLE_ENDIAN , };static const VMStateDescription vmstate_stm32f2xx_timer = {
hw/timer/sun4v-rtc.c +1 -1
@@ -47,7 +47,7 @@ static void sun4v_rtc_write(void *opaque, hwaddr addr,static const MemoryRegionOps sun4v_rtc_ops = { .read = sun4v_rtc_read, .write = sun4v_rtc_write, - .endianness =DEVICE_NATIVE_ENDIAN , + .endianness =DEVICE_BIG_ENDIAN , };void sun4v_rtc_init (hwaddr addr)
Signature · 1 line
2.23.0
RFC PATCH 17/17 build: Correct non-common common-obj-* to obj-*
In reply to Tony NguyenDevice realizing code with MemorRegionOps endianness as DEVICE_NATIVE_ENDIAN is not common code.
Corrected devices were identified by making the declaration of DEVICE_NATIVE_ENDIAN conditional upon NEED_CPU_H and then listing what failed to compile.
--- hw/audio/Makefile.objs | 3 ++- hw/block/Makefile.objs | 6 +++--- hw/char/Makefile.objs | 4 ++-- hw/core/Makefile.objs | 2 +- hw/display/Makefile.objs | 6 +++--- hw/dma/Makefile.objs | 6 +++--- hw/gpio/Makefile.objs | 2 +- hw/i2c/Makefile.objs | 2 +- hw/input/Makefile.objs | 2 +- hw/intc/Makefile.objs | 6 +++--- hw/ipack/Makefile.objs | 2 +- hw/misc/Makefile.objs | 10 +++++----- hw/net/Makefile.objs | 2 +- hw/pci-host/Makefile.objs | 2 +- hw/scsi/Makefile.objs | 2 +- hw/ssi/Makefile.objs | 2 +- hw/timer/Makefile.objs | 6 +++--- hw/virtio/Makefile.objs | 2 +- 18 files changed, 34 insertions(+), 33 deletions(-)
hw/audio/Makefile.objs +2 -1
@@ -5,7 +5,8 @@ common-obj-$(CONFIG_AC97) += ac97.o common-obj-$(CONFIG_ADLIB) += fmopl.o adlib.o common-obj-$(CONFIG_GUS) += gus.o gusemu_hal.o gusemu_mixer.o common-obj-$(CONFIG_CS4231A) += cs4231a.o -common-obj-$(CONFIG_HDA) += intel-hda.o hda-codec.o +common-obj-$(CONFIG_HDA) += hda-codec.o +obj-$(CONFIG_HDA) += intel-hda.o common-obj-$(CONFIG_PCSPK) += pcspk.o common-obj-$(CONFIG_WM8750) += wm8750.o
hw/block/Makefile.objs +3 -3
@@ -1,9 +1,9 @@ common-obj-y += block.o cdrom.o hd-geometry.o -common-obj-$(CONFIG_FDC) += fdc.o +obj-$(CONFIG_FDC) += fdc.o common-obj-$(CONFIG_SSI_M25P80) += m25p80.o common-obj-$(CONFIG_NAND) += nand.o -common-obj-$(CONFIG_PFLASH_CFI01) += pflash_cfi01.o -common-obj-$(CONFIG_PFLASH_CFI02) += pflash_cfi02.o +obj-$(CONFIG_PFLASH_CFI01) += pflash_cfi01.o +obj-$(CONFIG_PFLASH_CFI02) += pflash_cfi02.o common-obj-$(CONFIG_XEN) += xen-block.o common-obj-$(CONFIG_ECC) += ecc.o common-obj-$(CONFIG_ONENAND) += onenand.o
hw/char/Makefile.objs +2 -2
@@ -1,7 +1,6 @@ common-obj-$(CONFIG_IPACK) += ipoctal232.o common-obj-$(CONFIG_ESCC) += escc.o common-obj-$(CONFIG_NRF51_SOC) += nrf51_uart.o -common-obj-$(CONFIG_PARALLEL) += parallel.o common-obj-$(CONFIG_ISA_BUS) += parallel-isa.o common-obj-$(CONFIG_PL011) += pl011.o common-obj-$(CONFIG_SERIAL) += serial.o
@@ -9,7 +8,6 @@ common-obj-$(CONFIG_SERIAL_ISA) += serial-isa.o common-obj-$(CONFIG_SERIAL_PCI) += serial-pci.o common-obj-$(CONFIG_SERIAL_PCI_MULTI) += serial-pci-multi.o common-obj-$(CONFIG_VIRTIO_SERIAL) += virtio-console.o -common-obj-$(CONFIG_XILINX) += xilinx_uartlite.o common-obj-$(CONFIG_XEN) += xen_console.o common-obj-$(CONFIG_CADENCE) += cadence_uart.o
@@ -21,6 +19,8 @@ obj-$(CONFIG_PSERIES) += spapr_vty.o obj-$(CONFIG_DIGIC) += digic-uart.o obj-$(CONFIG_STM32F2XX_USART) += stm32f2xx_usart.o obj-$(CONFIG_RASPI) += bcm2835_aux.o +obj-$(CONFIG_PARALLEL) += parallel.o +obj-$(CONFIG_XILINX) += xilinx_uartlite.o common-obj-$(CONFIG_CMSDK_APB_UART) += cmsdk-apb-uart.o common-obj-$(CONFIG_ETRAXFS) += etraxfs_ser.o
hw/core/Makefile.objs +1 -1
@@ -9,7 +9,7 @@ common-obj-y += hotplug.o common-obj-$(CONFIG_SOFTMMU) += nmi.o common-obj-$(CONFIG_SOFTMMU) += vm-change-state-handler.o -common-obj-$(CONFIG_EMPTY_SLOT) += empty_slot.o +obj-$(CONFIG_EMPTY_SLOT) += empty_slot.o common-obj-$(CONFIG_XILINX_AXI) += stream.o common-obj-$(CONFIG_PTIMER) += ptimer.o common-obj-$(CONFIG_SOFTMMU) += sysbus.o
hw/display/Makefile.objs +3 -3
@@ -8,7 +8,7 @@ common-obj-$(CONFIG_ADS7846) += ads7846.o common-obj-$(CONFIG_VGA_CIRRUS) += cirrus_vga.o common-obj-$(call land,$(CONFIG_VGA_CIRRUS),$(CONFIG_VGA_ISA))+=cirrus_vga_isa.o common-obj-$(CONFIG_G364FB) += g364fb.o -common-obj-$(CONFIG_JAZZ_LED) += jazz_led.o +obj-$(CONFIG_JAZZ_LED) += jazz_led.o common-obj-$(CONFIG_PL110) += pl110.o common-obj-$(CONFIG_SII9022) += sii9022.o common-obj-$(CONFIG_SSD0303) += ssd0303.o
@@ -17,12 +17,12 @@ common-obj-$(CONFIG_XEN) += xenfb.o common-obj-$(CONFIG_VGA_PCI) += vga-pci.o common-obj-$(CONFIG_VGA_ISA) += vga-isa.o -common-obj-$(CONFIG_VGA_ISA_MM) += vga-isa-mm.o +obj-$(CONFIG_VGA_ISA_MM) += vga-isa-mm.o common-obj-$(CONFIG_VMWARE_VGA) += vmware_vga.o common-obj-$(CONFIG_BOCHS_DISPLAY) += bochs-display.o common-obj-$(CONFIG_BLIZZARD) += blizzard.o -common-obj-$(CONFIG_EXYNOS4) += exynos4210_fimd.o +obj-$(CONFIG_EXYNOS4) += exynos4210_fimd.o common-obj-$(CONFIG_FRAMEBUFFER) += framebuffer.o obj-$(CONFIG_MILKYMIST) += milkymist-vgafb.o common-obj-$(CONFIG_ZAURUS) += tc6393xb.o
hw/dma/Makefile.objs +3 -3
@@ -1,10 +1,10 @@ common-obj-$(CONFIG_PUV3) += puv3_dma.o -common-obj-$(CONFIG_RC4030) += rc4030.o +obj-$(CONFIG_RC4030) += rc4030.o common-obj-$(CONFIG_PL080) += pl080.o common-obj-$(CONFIG_PL330) += pl330.o common-obj-$(CONFIG_I82374) += i82374.o -common-obj-$(CONFIG_I8257) += i8257.o -common-obj-$(CONFIG_XILINX_AXI) += xilinx_axidma.o +obj-$(CONFIG_I8257) += i8257.o +obj-$(CONFIG_XILINX_AXI) += xilinx_axidma.o common-obj-$(CONFIG_ZYNQ_DEVCFG) += xlnx-zynq-devcfg.o common-obj-$(CONFIG_ETRAXFS) += etraxfs_dma.o common-obj-$(CONFIG_STP2000) += sparc32_dma.o
hw/gpio/Makefile.objs +1 -1
@@ -1,6 +1,6 @@ common-obj-$(CONFIG_MAX7310) += max7310.o common-obj-$(CONFIG_PL061) += pl061.o -common-obj-$(CONFIG_PUV3) += puv3_gpio.o +obj-$(CONFIG_PUV3) += puv3_gpio.o common-obj-$(CONFIG_ZAURUS) += zaurus.o common-obj-$(CONFIG_E500) += mpc8xxx.o common-obj-$(CONFIG_GPIO_KEY) += gpio_key.o
hw/i2c/Makefile.objs +1 -1
@@ -4,7 +4,7 @@ common-obj-$(CONFIG_VERSATILE_I2C) += versatile_i2c.o common-obj-$(CONFIG_ACPI_X86_ICH) += smbus_ich9.o common-obj-$(CONFIG_ACPI_SMBUS) += pm_smbus.o common-obj-$(CONFIG_BITBANG_I2C) += bitbang_i2c.o -common-obj-$(CONFIG_EXYNOS4) += exynos4210_i2c.o +obj-$(CONFIG_EXYNOS4) += exynos4210_i2c.o common-obj-$(CONFIG_IMX_I2C) += imx_i2c.o common-obj-$(CONFIG_ASPEED_SOC) += aspeed_i2c.o common-obj-$(CONFIG_NRF51_SOC) += microbit_i2c.o
hw/input/Makefile.objs +1 -1
@@ -1,7 +1,7 @@ common-obj-$(CONFIG_ADB) += adb.o adb-mouse.o adb-kbd.o common-obj-y += hid.o common-obj-$(CONFIG_LM832X) += lm832x.o -common-obj-$(CONFIG_PCKBD) += pckbd.o +obj-$(CONFIG_PCKBD) += pckbd.o common-obj-$(CONFIG_PL050) += pl050.o common-obj-$(CONFIG_PS2) += ps2.o common-obj-$(CONFIG_STELLARIS_INPUT) += stellaris_input.o
hw/intc/Makefile.objs +3 -3
@@ -2,14 +2,14 @@ common-obj-$(CONFIG_HEATHROW_PIC) += heathrow_pic.o common-obj-$(CONFIG_I8259) += i8259_common.o i8259.o common-obj-$(CONFIG_PL190) += pl190.o common-obj-$(CONFIG_PUV3) += puv3_intc.o -common-obj-$(CONFIG_XILINX) += xilinx_intc.o +obj-$(CONFIG_XILINX) += xilinx_intc.o common-obj-$(CONFIG_XLNX_ZYNQMP_PMU) += xlnx-pmu-iomod-intc.o common-obj-$(CONFIG_XLNX_ZYNQMP) += xlnx-zynqmp-ipi.o common-obj-$(CONFIG_ETRAXFS) += etraxfs_pic.o common-obj-$(CONFIG_IMX) += imx_avic.o imx_gpcv2.o common-obj-$(CONFIG_LM32) += lm32_pic.o common-obj-$(CONFIG_REALVIEW) += realview_gic.o -common-obj-$(CONFIG_SLAVIO) += slavio_intctl.o +obj-$(CONFIG_SLAVIO) += slavio_intctl.o common-obj-$(CONFIG_IOAPIC) += ioapic_common.o common-obj-$(CONFIG_ARM_GIC) += arm_gic_common.o common-obj-$(CONFIG_ARM_GIC) += arm_gic.o
@@ -18,7 +18,7 @@ common-obj-$(CONFIG_ARM_GIC) += arm_gicv3_common.o common-obj-$(CONFIG_ARM_GIC) += arm_gicv3.o common-obj-$(CONFIG_ARM_GIC) += arm_gicv3_dist.o common-obj-$(CONFIG_ARM_GIC) += arm_gicv3_redist.o -common-obj-$(CONFIG_ARM_GIC) += arm_gicv3_its_common.o +obj-$(CONFIG_ARM_GIC) += arm_gicv3_its_common.o common-obj-$(CONFIG_OPENPIC) += openpic.o common-obj-y += intc.o
hw/ipack/Makefile.objs +1 -1
@@ -1,2 +1,2 @@ common-obj-$(CONFIG_IPACK) += ipack.o -common-obj-$(CONFIG_IPACK) += tpci200.o +obj-$(CONFIG_IPACK) += tpci200.o
hw/misc/Makefile.objs +5 -5
@@ -1,4 +1,4 @@ -common-obj-$(CONFIG_APPLESMC) += applesmc.o +ommon-obj-$(CONFIG_APPLESMC) += applesmc.o common-obj-$(CONFIG_MAX111X) += max111x.o common-obj-$(CONFIG_TMP105) += tmp105.o common-obj-$(CONFIG_TMP421) += tmp421.o
@@ -6,20 +6,20 @@ common-obj-$(CONFIG_ISA_DEBUG) += debugexit.o common-obj-$(CONFIG_SGA) += sga.o common-obj-$(CONFIG_ISA_TESTDEV) += pc-testdev.o common-obj-$(CONFIG_PCI_TESTDEV) += pci-testdev.o -common-obj-$(CONFIG_EDU) += edu.o +obj-$(CONFIG_EDU) += edu.o common-obj-$(CONFIG_PCA9552) += pca9552.o -common-obj-$(CONFIG_UNIMP) += unimp.o +obj-$(CONFIG_UNIMP) += unimp.o common-obj-$(CONFIG_FW_CFG_DMA) += vmcoreinfo.o # ARM devices common-obj-$(CONFIG_PL310) += arm_l2x0.o -common-obj-$(CONFIG_INTEGRATOR_DEBUG) += arm_integrator_debug.o +obj-$(CONFIG_INTEGRATOR_DEBUG) += arm_integrator_debug.o common-obj-$(CONFIG_A9SCU) += a9scu.o common-obj-$(CONFIG_ARM11SCU) += arm11scu.o # Mac devices -common-obj-$(CONFIG_MOS6522) += mos6522.o +obj-$(CONFIG_MOS6522) += mos6522.o # PKUnity SoC devices common-obj-$(CONFIG_PUV3) += puv3_pm.o
hw/net/Makefile.objs +1 -1
@@ -1,4 +1,4 @@ -common-obj-$(CONFIG_DP8393X) += dp8393x.o +obj-$(CONFIG_DP8393X) += dp8393x.o common-obj-$(CONFIG_XEN) += xen_nic.o common-obj-$(CONFIG_NE2000_COMMON) += ne2000.o
hw/pci-host/Makefile.objs +1 -1
@@ -12,7 +12,7 @@ common-obj-$(CONFIG_PPCE500_PCI) += ppce500.o common-obj-$(CONFIG_VERSATILE_PCI) += versatile.o common-obj-$(CONFIG_PCI_SABRE) += sabre.o -common-obj-$(CONFIG_FULONG) += bonito.o +obj-$(CONFIG_FULONG) += bonito.o common-obj-$(CONFIG_PCI_PIIX) += piix.o common-obj-$(CONFIG_PCI_EXPRESS_Q35) += q35.o common-obj-$(CONFIG_PCI_EXPRESS_GENERIC_BRIDGE) += gpex.o
hw/scsi/Makefile.objs +1 -1
@@ -4,7 +4,7 @@ common-obj-$(CONFIG_LSI_SCSI_PCI) += lsi53c895a.o common-obj-$(CONFIG_MPTSAS_SCSI_PCI) += mptsas.o mptconfig.o mptendian.o common-obj-$(CONFIG_MEGASAS_SCSI_PCI) += megasas.o common-obj-$(CONFIG_VMW_PVSCSI_SCSI_PCI) += vmw_pvscsi.o -common-obj-$(CONFIG_ESP) += esp.o +obj-$(CONFIG_ESP) += esp.o common-obj-$(CONFIG_ESP_PCI) += esp-pci.o obj-$(CONFIG_SPAPR_VSCSI) += spapr_vscsi.o
hw/ssi/Makefile.objs +1 -1
@@ -1,6 +1,6 @@ common-obj-$(CONFIG_PL022) += pl022.o common-obj-$(CONFIG_SSI) += ssi.o -common-obj-$(CONFIG_XILINX_SPI) += xilinx_spi.o +obj-$(CONFIG_XILINX_SPI) += xilinx_spi.o common-obj-$(CONFIG_XILINX_SPIPS) += xilinx_spips.o common-obj-$(CONFIG_ASPEED_SOC) += aspeed_smc.o common-obj-$(CONFIG_STM32F2XX_SPI) += stm32f2xx_spi.o
hw/timer/Makefile.objs +3 -3
@@ -12,10 +12,10 @@ ifeq ($(CONFIG_ISA_BUS),y) common-obj-$(CONFIG_M48T59) += m48t59-isa.o endif common-obj-$(CONFIG_PL031) += pl031.o -common-obj-$(CONFIG_PUV3) += puv3_ost.o +obj-$(CONFIG_PUV3) += puv3_ost.o common-obj-$(CONFIG_TWL92230) += twl92230.o -common-obj-$(CONFIG_XILINX) += xilinx_timer.o -common-obj-$(CONFIG_SLAVIO) += slavio_timer.o +obj-$(CONFIG_XILINX) += xilinx_timer.o +obj-$(CONFIG_SLAVIO) += slavio_timer.o common-obj-$(CONFIG_ETRAXFS) += etraxfs_timer.o common-obj-$(CONFIG_GRLIB) += grlib_gptimer.o common-obj-$(CONFIG_IMX) += imx_epit.o
hw/virtio/Makefile.objs +1 -1
@@ -8,7 +8,7 @@ obj-$(CONFIG_VHOST_USER) += vhost-user.o common-obj-$(CONFIG_VIRTIO_RNG) += virtio-rng.o common-obj-$(CONFIG_VIRTIO_PCI) += virtio-pci.o -common-obj-$(CONFIG_VIRTIO_MMIO) += virtio-mmio.o +obj-$(CONFIG_VIRTIO_MMIO) += virtio-mmio.o obj-$(CONFIG_VIRTIO_BALLOON) += virtio-balloon.o obj-$(CONFIG_VIRTIO_CRYPTO) += virtio-crypto.o obj-$(call land,$(CONFIG_VIRTIO_CRYPTO),$(CONFIG_VIRTIO_PCI)) += virtio-crypto-pci.o
Signature · 1 line
2.23.0
Re: [Qemu-devel] [RFC PATCH 17/17] build: Correct non-common common-obj-* to obj-*
Thanks for splitting this. The good news is that most of these devices actually need _not_ be target-endian. Comments are inline.
Paolo
hw/audio/Makefile.objs common-obj-$(CONFIG_AC97) += ac97.o · line 9
Quoted 11 lines · Tony Nguyen
hw/audio/Makefile.objs +2
-1@@ -5,7 +5,8 @@ common-obj-$(CONFIG_AC97) += ac97.o common-obj-$(CONFIG_ADLIB) += fmopl.o adlib.o common-obj-$(CONFIG_GUS) += gus.o gusemu_hal.o gusemu_mixer.o common-obj-$(CONFIG_CS4231A) += cs4231a.o -common-obj-$(CONFIG_HDA) += intel-hda.o hda-codec.o +common-obj-$(CONFIG_HDA) += hda-codec.o +obj-$(CONFIG_HDA) += intel-hda.o
These are certainly little endian, since they are PCI devices.
hw/block/Makefile.objs line 2
Quoted 10 lines
hw/audio/Makefile.objs +0
-0common-obj-$(CONFIG_PCSPK) += pcspk.o common-obj-$(CONFIG_WM8750) += wm8750.ohw/block/Makefile.objs +1
-1@@ -1,9 +1,9 @@ common-obj-y += block.o cdrom.o hd-geometry.o -common-obj-$(CONFIG_FDC) += fdc.o +obj-$(CONFIG_FDC) += fdc.o
fdctrl_mem_ops and sysbus_fdc_info are not used AFAICT and fdctrl_mem_strict_ops is min/max size=1 so it can be made host-endian.
Quoted 43 lines
hw/block/Makefile.objs +2
-2common-obj-$(CONFIG_SSI_M25P80) += m25p80.o common-obj-$(CONFIG_NAND) += nand.o -common-obj-$(CONFIG_PFLASH_CFI01) += pflash_cfi01.o -common-obj-$(CONFIG_PFLASH_CFI02) += pflash_cfi02.o +obj-$(CONFIG_PFLASH_CFI01) += pflash_cfi01.o +obj-$(CONFIG_PFLASH_CFI02) += pflash_cfi02.o common-obj-$(CONFIG_XEN) += xen-block.o common-obj-$(CONFIG_ECC) += ecc.o common-obj-$(CONFIG_ONENAND) += onenand.ohw/char/Makefile.objs +2
-2@@ -1,7 +1,6 @@ common-obj-$(CONFIG_IPACK) += ipoctal232.o common-obj-$(CONFIG_ESCC) += escc.o common-obj-$(CONFIG_NRF51_SOC) += nrf51_uart.o -common-obj-$(CONFIG_PARALLEL) += parallel.o common-obj-$(CONFIG_ISA_BUS) += parallel-isa.o common-obj-$(CONFIG_PL011) += pl011.o common-obj-$(CONFIG_SERIAL) += serial.o@@ -9,7 +8,6 @@ common-obj-$(CONFIG_SERIAL_ISA) += serial-isa.o common-obj-$(CONFIG_SERIAL_PCI) += serial-pci.o common-obj-$(CONFIG_SERIAL_PCI_MULTI) += serial-pci-multi.o common-obj-$(CONFIG_VIRTIO_SERIAL) += virtio-console.o -common-obj-$(CONFIG_XILINX) += xilinx_uartlite.o common-obj-$(CONFIG_XEN) += xen_console.o common-obj-$(CONFIG_CADENCE) += cadence_uart.o@@ -21,6 +19,8 @@ obj-$(CONFIG_PSERIES) += spapr_vty.o obj-$(CONFIG_DIGIC) += digic-uart.o obj-$(CONFIG_STM32F2XX_USART) += stm32f2xx_usart.o obj-$(CONFIG_RASPI) += bcm2835_aux.o +obj-$(CONFIG_PARALLEL) += parallel.o +obj-$(CONFIG_XILINX) += xilinx_uartlite.o common-obj-$(CONFIG_CMSDK_APB_UART) += cmsdk-apb-uart.o common-obj-$(CONFIG_ETRAXFS) += etraxfs_ser.ohw/core/Makefile.objs +0
-0
hw/core/Makefile.objs common-obj-y += hotplug.o · line 12
Quoted 5 lines
hw/core/Makefile.objs +1
-1@@ -9,7 +9,7 @@ common-obj-y += hotplug.o common-obj-$(CONFIG_SOFTMMU) += nmi.o common-obj-$(CONFIG_SOFTMMU) += vm-change-state-handler.o -common-obj-$(CONFIG_EMPTY_SLOT) += empty_slot.o +obj-$(CONFIG_EMPTY_SLOT) += empty_slot.o
Bit bucket, just make it host endian.
hw/display/Makefile.objs common-obj-$(CONFIG_ADS7846) += ads7846.o · line 11
Quoted 13 lines
hw/core/Makefile.objs +0
-0common-obj-$(CONFIG_XILINX_AXI) += stream.o common-obj-$(CONFIG_PTIMER) += ptimer.o common-obj-$(CONFIG_SOFTMMU) += sysbus.ohw/display/Makefile.objs +1
-1@@ -8,7 +8,7 @@ common-obj-$(CONFIG_ADS7846) += ads7846.o common-obj-$(CONFIG_VGA_CIRRUS) += cirrus_vga.o common-obj-$(call land,$(CONFIG_VGA_CIRRUS),$(CONFIG_VGA_ISA))+=cirrus_vga_isa.o common-obj-$(CONFIG_G364FB) += g364fb.o -common-obj-$(CONFIG_JAZZ_LED) += jazz_led.o +obj-$(CONFIG_JAZZ_LED) += jazz_led.o
min/max size is 1, make it host endian.
Quoted 5 lines
hw/display/Makefile.objs +0
-0common-obj-$(CONFIG_PL110) += pl110.o common-obj-$(CONFIG_SII9022) += sii9022.o common-obj-$(CONFIG_SSD0303) += ssd0303.o@@ -17,12 +17,12 @@ common-obj-$(CONFIG_XEN) += xenfb.o
hw/display/Makefile.objs common-obj-$(CONFIG_XEN) += xenfb.o · line 25
Quoted 10 lines
hw/display/Makefile.objs +2
-2common-obj-$(CONFIG_VGA_PCI) += vga-pci.o common-obj-$(CONFIG_VGA_ISA) += vga-isa.o -common-obj-$(CONFIG_VGA_ISA_MM) += vga-isa-mm.o +obj-$(CONFIG_VGA_ISA_MM) += vga-isa-mm.o common-obj-$(CONFIG_VMWARE_VGA) += vmware_vga.o common-obj-$(CONFIG_BOCHS_DISPLAY) += bochs-display.o common-obj-$(CONFIG_BLIZZARD) += blizzard.o -common-obj-$(CONFIG_EXYNOS4) += exynos4210_fimd.o +obj-$(CONFIG_EXYNOS4) += exynos4210_fimd.o
ARM-only, can be little endian.
Quoted 8 lines
hw/display/Makefile.objs +0
-0common-obj-$(CONFIG_FRAMEBUFFER) += framebuffer.o obj-$(CONFIG_MILKYMIST) += milkymist-vgafb.o common-obj-$(CONFIG_ZAURUS) += tc6393xb.ohw/dma/Makefile.objs +0
-0
hw/dma/Makefile.objs line 6
Quoted 9 lines
hw/dma/Makefile.objs +2
-3@@ -1,10 +1,10 @@ common-obj-$(CONFIG_PUV3) += puv3_dma.o -common-obj-$(CONFIG_RC4030) += rc4030.o +obj-$(CONFIG_RC4030) += rc4030.o common-obj-$(CONFIG_PL080) += pl080.o common-obj-$(CONFIG_PL330) += pl330.o common-obj-$(CONFIG_I82374) += i82374.o -common-obj-$(CONFIG_I8257) += i8257.o -common-obj-$(CONFIG_XILINX_AXI) += xilinx_axidma.o +obj-$(CONFIG_I8257) += i8257.o
min/max size is 1, can be host endian.
hw/gpio/Makefile.objs line 3
Quoted 13 lines
hw/dma/Makefile.objs +1
-0+obj-$(CONFIG_XILINX_AXI) += xilinx_axidma.o common-obj-$(CONFIG_ZYNQ_DEVCFG) += xlnx-zynq-devcfg.o common-obj-$(CONFIG_ETRAXFS) += etraxfs_dma.o common-obj-$(CONFIG_STP2000) += sparc32_dma.ohw/gpio/Makefile.objs +1
-1@@ -1,6 +1,6 @@ common-obj-$(CONFIG_MAX7310) += max7310.o common-obj-$(CONFIG_PL061) += pl061.o -common-obj-$(CONFIG_PUV3) += puv3_gpio.o +obj-$(CONFIG_PUV3) += puv3_gpio.o
Only for unicore32; little endian.
hw/i2c/Makefile.objs common-obj-$(CONFIG_VERSATILE_I2C) += versatile_i2c.o · line 7
Quoted 13 lines
hw/gpio/Makefile.objs +0
-0common-obj-$(CONFIG_ZAURUS) += zaurus.o common-obj-$(CONFIG_E500) += mpc8xxx.o common-obj-$(CONFIG_GPIO_KEY) += gpio_key.ohw/i2c/Makefile.objs +1
-1@@ -4,7 +4,7 @@ common-obj-$(CONFIG_VERSATILE_I2C) += versatile_i2c.o common-obj-$(CONFIG_ACPI_X86_ICH) += smbus_ich9.o common-obj-$(CONFIG_ACPI_SMBUS) += pm_smbus.o common-obj-$(CONFIG_BITBANG_I2C) += bitbang_i2c.o -common-obj-$(CONFIG_EXYNOS4) += exynos4210_i2c.o +obj-$(CONFIG_EXYNOS4) += exynos4210_i2c.o
ARM -> little endian.
Quoted 11 lines
hw/i2c/Makefile.objs +0
-0common-obj-$(CONFIG_IMX_I2C) += imx_i2c.o common-obj-$(CONFIG_ASPEED_SOC) += aspeed_i2c.o common-obj-$(CONFIG_NRF51_SOC) += microbit_i2c.ohw/intc/Makefile.objs +0
-0@@ -2,14 +2,14 @@ common-obj-$(CONFIG_HEATHROW_PIC) += heathrow_pic.o common-obj-$(CONFIG_I8259) += i8259_common.o i8259.o common-obj-$(CONFIG_PL190) += pl190.o common-obj-$(CONFIG_PUV3) += puv3_intc.o
hw/intc/Makefile.objs common-obj-$(CONFIG_HEATHROW_PIC) += heathrow_pic.o · line 12
Quoted 10 lines
hw/intc/Makefile.objs +2
-2-common-obj-$(CONFIG_XILINX) += xilinx_intc.o +obj-$(CONFIG_XILINX) += xilinx_intc.o common-obj-$(CONFIG_XLNX_ZYNQMP_PMU) += xlnx-pmu-iomod-intc.o common-obj-$(CONFIG_XLNX_ZYNQMP) += xlnx-zynqmp-ipi.o common-obj-$(CONFIG_ETRAXFS) += etraxfs_pic.o common-obj-$(CONFIG_IMX) += imx_avic.o imx_gpcv2.o common-obj-$(CONFIG_LM32) += lm32_pic.o common-obj-$(CONFIG_REALVIEW) += realview_gic.o -common-obj-$(CONFIG_SLAVIO) += slavio_intctl.o +obj-$(CONFIG_SLAVIO) += slavio_intctl.o
SPARC only -> big endian.
hw/intc/Makefile.objs common-obj-$(CONFIG_ARM_GIC) += arm_gicv3_common.o · line 21
Quoted 9 lines
hw/intc/Makefile.objs +1
-1common-obj-$(CONFIG_IOAPIC) += ioapic_common.o common-obj-$(CONFIG_ARM_GIC) += arm_gic_common.o common-obj-$(CONFIG_ARM_GIC) += arm_gic.o@@ -18,7 +18,7 @@ common-obj-$(CONFIG_ARM_GIC) += arm_gicv3_common.o common-obj-$(CONFIG_ARM_GIC) += arm_gicv3.o common-obj-$(CONFIG_ARM_GIC) += arm_gicv3_dist.o common-obj-$(CONFIG_ARM_GIC) += arm_gicv3_redist.o -common-obj-$(CONFIG_ARM_GIC) += arm_gicv3_its_common.o +obj-$(CONFIG_ARM_GIC) += arm_gicv3_its_common.o
ARM only -> little endian.
hw/ipack/Makefile.objs line 2
Quoted 11 lines
hw/intc/Makefile.objs +0
-0common-obj-$(CONFIG_OPENPIC) += openpic.o common-obj-y += intc.ohw/ipack/Makefile.objs +1
-1@@ -1,2 +1,2 @@ common-obj-$(CONFIG_IPACK) += ipack.o -common-obj-$(CONFIG_IPACK) += tpci200.o +obj-$(CONFIG_IPACK) += tpci200.o
PCI -> little endian.
hw/misc/Makefile.objs line 1
Quoted 7 lines
hw/misc/Makefile.objs +1
-1@@ -1,4 +1,4 @@ -common-obj-$(CONFIG_APPLESMC) += applesmc.o +ommon-obj-$(CONFIG_APPLESMC) += applesmc.o
Careful, typo. The device can be host endian (min/max size = 1).
hw/misc/Makefile.objs common-obj-$(CONFIG_ISA_DEBUG) += debugexit.o · line 9
Quoted 9 lines
hw/misc/Makefile.objs +1
-1common-obj-$(CONFIG_MAX111X) += max111x.o common-obj-$(CONFIG_TMP105) += tmp105.o common-obj-$(CONFIG_TMP421) += tmp421.o@@ -6,20 +6,20 @@ common-obj-$(CONFIG_ISA_DEBUG) += debugexit.o common-obj-$(CONFIG_SGA) += sga.o common-obj-$(CONFIG_ISA_TESTDEV) += pc-testdev.o common-obj-$(CONFIG_PCI_TESTDEV) += pci-testdev.o -common-obj-$(CONFIG_EDU) += edu.o +obj-$(CONFIG_EDU) += edu.o
PCI -> little endian.
hw/misc/Makefile.objs common-obj-$(CONFIG_ISA_DEBUG) += debugexit.o · line 12
Quoted 4 lines
hw/misc/Makefile.objs +1
-1common-obj-$(CONFIG_PCA9552) += pca9552.o -common-obj-$(CONFIG_UNIMP) += unimp.o +obj-$(CONFIG_UNIMP) += unimp.o
Bit bucket -> host endian.
hw/misc/Makefile.objs common-obj-$(CONFIG_ISA_DEBUG) += debugexit.o · line 17
Quoted 6 lines
hw/misc/Makefile.objs +1
-1common-obj-$(CONFIG_FW_CFG_DMA) += vmcoreinfo.o # ARM devices common-obj-$(CONFIG_PL310) += arm_l2x0.o -common-obj-$(CONFIG_INTEGRATOR_DEBUG) += arm_integrator_debug.o +obj-$(CONFIG_INTEGRATOR_DEBUG) += arm_integrator_debug.o
ARM -> little endian.
hw/misc/Makefile.objs common-obj-$(CONFIG_ISA_DEBUG) += debugexit.o · line 22
Quoted 6 lines
hw/misc/Makefile.objs +1
-1common-obj-$(CONFIG_A9SCU) += a9scu.o common-obj-$(CONFIG_ARM11SCU) += arm11scu.o # Mac devices -common-obj-$(CONFIG_MOS6522) += mos6522.o +obj-$(CONFIG_MOS6522) += mos6522.o
min/max size = 1 -> host endian.
hw/pci-host/Makefile.objs common-obj-$(CONFIG_PPCE500_PCI) += ppce500.o · line 15
Quoted 13 lines
hw/misc/Makefile.objs +0
-0# PKUnity SoC devices common-obj-$(CONFIG_PUV3) += puv3_pm.ohw/pci-host/Makefile.objs +1
-1@@ -12,7 +12,7 @@ common-obj-$(CONFIG_PPCE500_PCI) += ppce500.o common-obj-$(CONFIG_VERSATILE_PCI) += versatile.o common-obj-$(CONFIG_PCI_SABRE) += sabre.o -common-obj-$(CONFIG_FULONG) += bonito.o +obj-$(CONFIG_FULONG) += bonito.o
FULONG is little endian.
hw/timer/Makefile.objs ifeq ($(CONFIG_ISA_BUS),y) · line 15
Quoted 13 lines
hw/pci-host/Makefile.objs +0
-0common-obj-$(CONFIG_PCI_PIIX) += piix.o common-obj-$(CONFIG_PCI_EXPRESS_Q35) += q35.o common-obj-$(CONFIG_PCI_EXPRESS_GENERIC_BRIDGE) += gpex.ohw/timer/Makefile.objs +1
-1@@ -12,10 +12,10 @@ ifeq ($(CONFIG_ISA_BUS),y) common-obj-$(CONFIG_M48T59) += m48t59-isa.o endif common-obj-$(CONFIG_PL031) += pl031.o -common-obj-$(CONFIG_PUV3) += puv3_ost.o +obj-$(CONFIG_PUV3) += puv3_ost.o
Unicore32 -> LE.
hw/timer/Makefile.objs ifeq ($(CONFIG_ISA_BUS),y) · line 18
Quoted 5 lines
hw/timer/Makefile.objs +2
-2common-obj-$(CONFIG_TWL92230) += twl92230.o -common-obj-$(CONFIG_XILINX) += xilinx_timer.o -common-obj-$(CONFIG_SLAVIO) += slavio_timer.o +obj-$(CONFIG_XILINX) += xilinx_timer.o +obj-$(CONFIG_SLAVIO) += slavio_timer.o
SPARC -> BE.
Quoted 3 lines
hw/timer/Makefile.objs +0
-0common-obj-$(CONFIG_ETRAXFS) += etraxfs_timer.o common-obj-$(CONFIG_GRLIB) += grlib_gptimer.o common-obj-$(CONFIG_IMX) += imx_epit.o
Patchew URL: https://patchew.org/QEMU/[email protected]/
Patchew URL: https://patchew.org/QEMU/[email protected]/
Hi,
This series seems to have some coding style problems. See output below for more information:
Type: series
Subject: [Qemu-devel] [RFC PATCH 00/17] Declare device little or big endian
Message-id: [email protected]
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/[email protected] -> patchew/[email protected]
* [new tag] patchew/[email protected] -> patchew/[email protected]
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers' Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/edk2' (https://git.qemu.org/git/edk2.git) registered for path 'roms/edk2'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/opensbi' (https://git.qemu.org/git/opensbi.git) registered for path 'roms/opensbi'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://git.qemu.org/git/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex' Submodule 'slirp' (https://git.qemu.org/git/libslirp.git) registered for path 'slirp'
Submodule 'tests/fp/berkeley-softfloat-3' (https://git.qemu.org/git/berkeley-softfloat-3.git) registered for path 'tests/fp/berkeley-softfloat-3' Submodule 'tests/fp/berkeley-testfloat-3' (https://git.qemu.org/git/berkeley-testfloat-3.git) registered for path 'tests/fp/berkeley-testfloat-3' Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out '7bfe584e321946771692711ff83ad2b5850daca7'
Cloning into 'roms/edk2'...
Submodule path 'roms/edk2': checked out '20d2e5a125e34fc8501026613a71549b2a1a3e54'
Submodule 'SoftFloat' (https://github.com/ucb-bar/berkeley-softfloat-3.git) registered for path 'ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3' Submodule 'CryptoPkg/Library/OpensslLib/openssl' (https://github.com/openssl/openssl) registered for path 'CryptoPkg/Library/OpensslLib/openssl' Cloning into 'ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3'...
Submodule path 'roms/edk2/ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037' Cloning into 'CryptoPkg/Library/OpensslLib/openssl'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl': checked out '50eaac9f3337667259de725451f201e784599687' Submodule 'boringssl' (https://boringssl.googlesource.com/boringssl) registered for path 'boringssl'
Submodule 'krb5' (https://github.com/krb5/krb5) registered for path 'krb5'
Submodule 'pyca.cryptography' (https://github.com/pyca/cryptography.git) registered for path 'pyca-cryptography'
Cloning into 'boringssl'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/boringssl': checked out '2070f8ad9151dc8f3a73bffaa146b5e6937a583f' Cloning into 'krb5'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/krb5': checked out 'b9ad6c49505c96a088326b62a52568e3484f2168' Cloning into 'pyca-cryptography'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/pyca-cryptography': checked out '09403100de2f6f1cdd0d484dcb8e620f1c335c8f' Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out 'c79e0ecb84f4f1ee3f73f521622e264edd1bf174'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/opensbi'...
Submodule path 'roms/opensbi': checked out 'ce228ee0919deb9957192d723eecc8aaae2697c6'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out 'bf0e13698872450164fa7040da36a95d2d4b326f'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a5cab58e9a3fb6e168aba919c5669bea406573b4'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '0f4fe84658165e96ce35870fd19fc634e182e77b'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out '261ca8e779e5138869a45f174caa49be6a274501'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd3689267f92c5956e09cc7d1baa4700141662bff'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'slirp'...
Submodule path 'slirp': checked out '126c04acbabd7ad32c2b018fe10dfac2a3bc1210'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
6d40dd9 build: Correct non-common common-obj-* to obj-*
f5bd4e6 hw/timer: Declare device little or big endian
2b2ba8f hw/ssi: Declare device little or big endian
10e575a hw/sd: Declare device little or big endian
965ee01 hw/pci-host: Declare device little or big endian
3d441d1 hw/net: Declare device little or big endian
174b64e hw/misc: Declare device little or big endian
4867b4c hw/isa: Declare device little or big endian
e1f8bd0 hw/intc: Declare device little or big endian
79b34c0 hw/input: Declare device little or big endian
6bd7188 hw/i2c: Declare device little or big endian
6a0dcf0 hw/gpio: Declare device little or big endian
838767a hw/dma: Declare device little or big endian
f6caa90 hw/display: Declare device little or big endian
822e1ff hw/char: Declare device little or big endian
5110188 hw/block: Declare device little or big endian
fc20ac5 hw/audio: Declare device little or big endian
=== OUTPUT BEGIN ===
1/17 Checking commit fc20ac51076d (hw/audio: Declare device little or big endian) 2/17 Checking commit 511018896554 (hw/block: Declare device little or big endian) 3/17 Checking commit 822e1ff39210 (hw/char: Declare device little or big endian) 4/17 Checking commit f6caa90fdc68 (hw/display: Declare device little or big endian) 5/17 Checking commit 838767a7b80b (hw/dma: Declare device little or big endian)
ERROR: code indent should never use tabs
#56: FILE: hw/dma/etraxfs_dma.c:703:
+^I.endianness = DEVICE_LITTLE_ENDIAN,$
total: 1 errors, 0 warnings, 56 lines checked
Patch 5/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS.
6/17 Checking commit 6a0dcf06776a (hw/gpio: Declare device little or big endian) 7/17 Checking commit 6bd71884ee61 (hw/i2c: Declare device little or big endian) 8/17 Checking commit 79b34c0a8f81 (hw/input: Declare device little or big endian) 9/17 Checking commit e1f8bd01d0e6 (hw/intc: Declare device little or big endian) 10/17 Checking commit 4867b4c86571 (hw/isa: Declare device little or big endian) 11/17 Checking commit 174b64e515b9 (hw/misc: Declare device little or big endian) 12/17 Checking commit 3d441d1e6362 (hw/net: Declare device little or big endian) 13/17 Checking commit 965ee01bb0c1 (hw/pci-host: Declare device little or big endian) 14/17 Checking commit 10e575adf05e (hw/sd: Declare device little or big endian) 15/17 Checking commit 2b2ba8fe3455 (hw/ssi: Declare device little or big endian) 16/17 Checking commit f5bd4e6ae8f6 (hw/timer: Declare device little or big endian) 17/17 Checking commit 6d40dd96af57 (build: Correct non-common common-obj-* to obj-*) === OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/[email protected]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [email protected]