Skip to contentSkip to conversation

drivers: Add Tiger Lake hardware IDs to support ACPI,

PATCH In review Gayatri Kammela 3 participants 11 messages Dec 16, 2019 – Dec 19, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v3 cover drivers: Add Tiger Lake hardware IDs to support ACPI,

Hi,

Tiger Lake supports devices whose hardware IDs are changed for various drivers. Hence, add the new hardware IDs.

Patch 1: Add Tiger Lake support to DPTF driver Patch 2: Add Tiger Lake support to fan driver Patch 3: Add Tiger Lake support to device_pm Patch 4: Add Tiger Lake support to Intel's HID driver Patch 5: Add Tiger Lake support to thermal driver

Changes since v1:
1) Maintain the readability by adding hardware IDs in a sorted order

Changes since v2:
1) Added Tiger Lake support to device_pm
2) Changed acpi to ACPI in commit messages

Gayatri Kammela (5):
acpi: dptf: Add new Tiger Lake hardware IDs to support DPTF drivers in
ACPI
acpi: fan: Add new Tiger Lake hardware ID to support fan driver in
ACPI
acpi: device_pm: Add new Tiger Lake hardware ID to support ACPI device
power management
platform/x86: intel-hid: Add new Tiger Lake hardware ID to support HID
driver
thermal: int340x_thermal: Add new Tiger Lake hardware IDs to support
thermal driver

 drivers/acpi/device_pm.c                                | 1 +
 drivers/acpi/dptf/dptf_power.c                          | 1 +
 drivers/acpi/dptf/int340x_thermal.c                     | 4 ++++
 drivers/acpi/fan.c                                      | 1 +
 drivers/platform/x86/intel-hid.c                        | 1 +
 drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 1 +
 drivers/thermal/intel/int340x_thermal/int3403_thermal.c | 1 +
 7 files changed, 10 insertions(+)
Cc Rafael J. Wysocki <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Zhang Rui <[email protected]>
Cc Srinivas Pandruvada <[email protected]>
Signature · 1 line
2.17.1
#1 lore raw

PATCH v3 1/5 acpi: dptf: Add new Tiger Lake hardware IDs to support DPTF drivers in ACPI

Tiger Lake has new unique hardware IDs that are needed to support DPTF drivers. Hence, add them.

Cc Rafael J. Wysocki <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Zhang Rui <[email protected]>
Cc Srinivas Pandruvada <[email protected]>
---
 drivers/acpi/dptf/dptf_power.c      | 1 +
 drivers/acpi/dptf/int340x_thermal.c | 4 ++++
 2 files changed, 5 insertions(+)
drivers/acpi/dptf/dptf_power.c +1 -0
index eb58fc475a03..387f27ef3368 100644
@@ -97,6 +97,7 @@ static int dptf_power_remove(struct platform_device *pdev)
 }
 
 static const struct acpi_device_id int3407_device_ids[] = {
+	{"INT1047", 0},
 	{"INT3407", 0},
 	{"", 0},
 };
drivers/acpi/dptf/int340x_thermal.c +4 -0
index 5c7a90186e3c..1ec7b6900662 100644
@@ -13,6 +13,10 @@
 
 #define INT3401_DEVICE 0X01
 static const struct acpi_device_id int340x_thermal_device_ids[] = {
+	{"INT1040"},
+	{"INT1043"},
+	{"INT1044"},
+	{"INT1047"},
 	{"INT3400"},
 	{"INT3401", INT3401_DEVICE},
 	{"INT3402"},
Signature · 1 line
2.17.1
#2 lore raw

PATCH v3 2/5 acpi: fan: Add new Tiger Lake hardware ID to support fan driver in ACPI

In reply to Gayatri Kammela

Tiger Lake has a new unique hardware ID to support fan driver. Hence, add it.

Cc Rafael J. Wysocki <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Zhang Rui <[email protected]>
Cc Srinivas Pandruvada <[email protected]>
---
 drivers/acpi/fan.c | 1 +
 1 file changed, 1 insertion(+)
drivers/acpi/fan.c +1 -0
index 816b0803f7fb..13708fb48038 100644
@@ -25,6 +25,7 @@ static int acpi_fan_remove(struct platform_device *pdev);
 
 static const struct acpi_device_id fan_device_ids[] = {
 	{"PNP0C0B", 0},
+	{"INT1044", 0},
 	{"INT3404", 0},
 	{"", 0},
 };
Signature · 1 line
2.17.1
#3 lore raw

PATCH v3 3/5 acpi: device_pm: Add new Tiger Lake hardware ID to support ACPI device power management

In reply to Gayatri Kammela

Tiger Lake has a new unique hardware ID that supports ACPI device power management. Hence, add it to the list of special device power management IDs.

Cc Rafael J. Wysocki <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Zhang Rui <[email protected]>
Cc Srinivas Pandruvada <[email protected]>
---
 drivers/acpi/device_pm.c | 1 +
 1 file changed, 1 insertion(+)
drivers/acpi/device_pm.c +1 -0
index 5e4a8860a9c0..b64c62bfcea5 100644
@@ -1321,6 +1321,7 @@ int acpi_dev_pm_attach(struct device *dev, bool power_on)
 	 */
 	static const struct acpi_device_id special_pm_ids[] = {
 		{"PNP0C0B", }, /* Generic ACPI fan */
+		{"INT1044", }, /* Fan for Tiger Lake generation */
 		{"INT3404", }, /* Fan */
 		{}
 	};
Signature · 1 line
2.17.1
#4 lore raw

PATCH v3 4/5 platform/x86: intel-hid: Add new Tiger Lake hardware ID to support HID driver

In reply to Gayatri Kammela

Tiger Lake has a new unique hardware ID to support Intel's HID event filter driver. Hence, add it.

Cc Rafael J. Wysocki <[email protected]>
Cc Zhang Rui <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Srinivas Pandruvada <[email protected]>
---
 drivers/platform/x86/intel-hid.c | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/x86/intel-hid.c +1 -0
index ef6d4bd77b1a..43d590250228 100644
@@ -19,6 +19,7 @@ MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Alex Hung");
 
 static const struct acpi_device_id intel_hid_ids[] = {
+	{"INT1051", 0},
 	{"INT33D5", 0},
 	{"", 0},
 };
Signature · 1 line
2.17.1
#5 lore raw

PATCH v3 5/5 thermal: int340x_thermal: Add new Tiger Lake hardware IDs to support thermal driver

In reply to Gayatri Kammela

Tiger Lake has a new unique hardware IDs to support thermal driver. Hence, add them.

Cc Rafael J. Wysocki <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Zhang rui <[email protected]>
Cc Srinivas Pandruvada <[email protected]>
---
 drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 1 +
 drivers/thermal/intel/int340x_thermal/int3403_thermal.c | 1 +
 2 files changed, 2 insertions(+)
drivers/thermal/intel/int340x_thermal/int3400_thermal.c +1 -0
index 3517883b5cdb..efae0c02d898 100644
@@ -369,6 +369,7 @@ static int int3400_thermal_remove(struct platform_device *pdev)
 }
 
 static const struct acpi_device_id int3400_thermal_match[] = {
+	{"INT1040", 0},
 	{"INT3400", 0},
 	{}
 };
drivers/thermal/intel/int340x_thermal/int3403_thermal.c +1 -0
index a7bbd8584ae2..aeece1e136a5 100644
@@ -282,6 +282,7 @@ static int int3403_remove(struct platform_device *pdev)
 }
 
 static const struct acpi_device_id int3403_device_ids[] = {
+	{"INT1043", 0},
 	{"INT3403", 0},
 	{"", 0},
 };
Signature · 1 line
2.17.1
reviewer Acked-by on v3 5/5
#6 lore raw

Re: [PATCH v3 5/5] thermal: int340x_thermal: Add new Tiger Lake hardware IDs to support thermal driver

Quoted 9 lines · Gayatri Kammela

Tiger Lake has a new unique hardware IDs to support thermal driver. Hence, add them.

Cc Rafael J. Wysocki <[email protected]>
Cc Andy Shevchenko <[email protected]>
Cc Zhang rui <[email protected]>
Cc Srinivas Pandruvada <[email protected]>

thanks,
rui

Quoted 33 lines
---
 drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 1 +
 drivers/thermal/intel/int340x_thermal/int3403_thermal.c | 1 +
 2 files changed, 2 insertions(+)
drivers/thermal/intel/int340x_thermal/int3400_thermal.c +1 -0
index 3517883b5cdb..efae0c02d898 100644
@@ -369,6 +369,7 @@ static int int3400_thermal_remove(struct
 platform_device *pdev)
 }
 
 static const struct acpi_device_id int3400_thermal_match[] = {
+	{"INT1040", 0},
 	{"INT3400", 0},
 	{}

};

drivers/thermal/intel/int340x_thermal/int3403_thermal.c +1 -0
index a7bbd8584ae2..aeece1e136a5 100644
@@ -282,6 +282,7 @@ static int int3403_remove(struct platform_device
 *pdev)
 }
 
 static const struct acpi_device_id int3403_device_ids[] = {
+	{"INT1043", 0},
 	{"INT3403", 0},
 	{"", 0},

};

#7 lore raw
In reply to Gayatri Kammela
Quoted 11 lines · Gayatri Kammela

Hi,

Tiger Lake supports devices whose hardware IDs are changed for various drivers. Hence, add the new hardware IDs.

Patch 1: Add Tiger Lake support to DPTF driver Patch 2: Add Tiger Lake support to fan driver Patch 3: Add Tiger Lake support to device_pm Patch 4: Add Tiger Lake support to Intel's HID driver Patch 5: Add Tiger Lake support to thermal driver

I'm going to apply the whole series (for 5.6) if nobody has any issues with that.

Thanks!

#8 lore raw
Quoted 32 lines

-----Original Message-----
From: Rafael J. Wysocki <[email protected]>
Sent: Monday, December 16, 2019 1:36 PM
To: Kammela, Gayatri <[email protected]>
Cc: Linux PM <[email protected]>; Platform Driver <platform-driver- [email protected]>; Alex Hung <[email protected]>; ACPI Devel Maling List <[email protected]>; Len Brown <[email protected]>; Rafael J. Wysocki <[email protected]>; Linux Kernel Mailing List <linux- [email protected]>; Daniel Lezcano <[email protected]>; Amit Kucheria <[email protected]>; Prestopine, Charles D <[email protected]>; Darren Hart <[email protected]>; Rafael J . Wysocki <[email protected]>; Andy Shevchenko <[email protected]>; Zhang, Rui <[email protected]>; Pandruvada, Srinivas <[email protected]>
Subject: Re: [PATCH v3 0/5] drivers: Add Tiger Lake hardware IDs to support ACPI,

Quoted 10 lines · Gayatri Kammela

Hi,

Tiger Lake supports devices whose hardware IDs are changed for various drivers. Hence, add the new hardware IDs.

Patch 1: Add Tiger Lake support to DPTF driver Patch 2: Add Tiger Lake support to fan driver Patch 3: Add Tiger Lake support to device_pm Patch 4: Add Tiger Lake support to Intel's HID driver Patch 5: Add Tiger Lake support to thermal driver

Quoted 4 lines

I'm going to apply the whole series (for 5.6) if nobody has any issues with that.

Thanks!

Thank you Rafael!

#9 lore raw
Quoted 33 lines · Gayatri
Quoted 33 lines

-----Original Message-----
From: Rafael J. Wysocki <[email protected]>
Sent: Monday, December 16, 2019 1:36 PM
To: Kammela, Gayatri <[email protected]>
Cc: Linux PM <[email protected]>; Platform Driver <platform-driver- [email protected]>; Alex Hung <[email protected]>; ACPI Devel Maling List <[email protected]>; Len Brown <[email protected]>; Rafael J. Wysocki <[email protected]>; Linux Kernel Mailing List <linux- [email protected]>; Daniel Lezcano <[email protected]>; Amit Kucheria <[email protected]>; Prestopine, Charles D <[email protected]>; Darren Hart <[email protected]>; Rafael J . Wysocki <[email protected]>; Andy Shevchenko <[email protected]>; Zhang, Rui <[email protected]>; Pandruvada, Srinivas <[email protected]>
Subject: Re: [PATCH v3 0/5] drivers: Add Tiger Lake hardware IDs to support ACPI,

Quoted 10 lines · Gayatri Kammela

Hi,

Tiger Lake supports devices whose hardware IDs are changed for various drivers. Hence, add the new hardware IDs.

Patch 1: Add Tiger Lake support to DPTF driver Patch 2: Add Tiger Lake support to fan driver Patch 3: Add Tiger Lake support to device_pm Patch 4: Add Tiger Lake support to Intel's HID driver Patch 5: Add Tiger Lake support to thermal driver

Quoted 6 lines
Quoted 4 lines

I'm going to apply the whole series (for 5.6) if nobody has any issues with that.

Thanks!

Thank you Rafael!

So applying as 5.6 material with rewritten subjects and changelogs and with patches [2/5] and [3/5] folded together.

Thanks!

#10 lore raw
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 7 lines

Tiger Lake supports devices whose hardware IDs are changed for various drivers. Hence, add the new hardware IDs.

Patch 1: Add Tiger Lake support to DPTF driver Patch 2: Add Tiger Lake support to fan driver Patch 3: Add Tiger Lake support to device_pm Patch 4: Add Tiger Lake support to Intel's HID driver Patch 5: Add Tiger Lake support to thermal driver

I'm going to apply the whole series (for 5.6) if nobody has any issues with that.

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

Thanks!

Thank you Rafael!

So applying as 5.6 material with rewritten subjects and changelogs and with patches [2/5] and [3/5] folded together.

Thanks!

Okay sounds good. Thanks Rafael!