Support for displays based on ili9486 with regwidth=16
Kamlesh Gurudasani
maintainercover Support for displays based on ili9486 with regwidth=16
The goal of this series is to get the display based on ilitek,ili9486 working
Kamlesh Gurudasani (2):
dt-bindings: add binding for Ilitek ili9486 based display panels drm/tinydrm: add support for ilitek,ili9486 based displays with
regwidth=16
.../devicetree/bindings/display/ilitek,ili9486.txt | 27 ++ MAINTAINERS | 7 + drivers/gpu/drm/tiny/Kconfig | 14 + drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/ili9486.c | 288 +++++++++++++++++++++ 5 files changed, 337 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/ilitek,ili9486.txt create mode 100644 drivers/gpu/drm/tiny/ili9486.c
Signature · 6 lines
2.7.4 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Kamlesh Gurudasani
maintainerPATCH 1/2 dt-bindings: add binding for Ilitek ili9486 based display panels
--- .../devicetree/bindings/display/ilitek,ili9486.txt | 27 ++++++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/ilitek,ili9486.txt
Documentation/devicetree/bindings/display/ilitek,ili9486.txt new file +27 -0
@@ -0,0 +1,27 @@ +Ilitek ILI9486 display panels + +This binding is for display panels using an Ilitek ILI9486 controller in SPI +mode. + +Required properties: +- compatible: "ozzmaker,piscreen", "waveshare,rpi-lcd-35", "ilitek,ili9486" +- dc-gpios: D/C pin +- reset-gpios: Reset pin + +The node for this driver must be a child node of a SPI controller, hence +all mandatory properties described in ../spi/spi-bus.txt must be specified. + +Optional properties: +- rotation: panel rotation in degrees counter clockwise (0,90,180,270) +- backlight: phandle of the backlight device attached to the panel + +Example: + display@0{ + compatible = "ozzmaker,piscreen", "waveshare,rpi-lcd-35", "ilitek,ili9486"; + reg = <0>; + spi-max-frequency = <32000000>; + dc-gpios = <&gpio0 9 GPIO_ACTIVE_HIGH>; + reset-gpios = <&gpio0 8 GPIO_ACTIVE_HIGH>; + rotation = <180>; + backlight = <&backlight>; + };
Signature · 6 lines
2.7.4 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 1/2] dt-bindings: add binding for Ilitek ili9486 based display panels
Den 25.01.2020 16.38, skrev Kamlesh Gurudasani:
Quoted 3 lines
Signed-off-by Kamlesh Gurudasani <[email protected]>--- .../devicetree/bindings/display/ilitek,ili9486.txt | 27 ++++++++++++++++++++++
For version 2, send the patchset to the devicetree mailinglist as well. A DT maintainer has to review it. Send the whole set since he wants to look at the driver as well.
See: Documentation/devicetree/bindings/submitting-patches.txt
Looks like bindings are in yaml format now.
Quoted 9 lines
1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/ilitek,ili9486.txtDocumentation/devicetree/bindings/display/ilitek,ili9486.txt new file +0
-0
Documentation/devicetree/bindings/display/ilitek,ili9486.txt line 7
Quoted 7 lines
Documentation/devicetree/bindings/display/ilitek,ili9486.txt new file +7
-0@@ -0,0 +1,27 @@ +Ilitek ILI9486 display panels + +This binding is for display panels using an Ilitek ILI9486 controller in SPI +mode. + +Required properties: +- compatible: "ozzmaker,piscreen", "waveshare,rpi-lcd-35", "ilitek,ili9486"
Drop the last entry since it doesn't make any sense since the controller won't work without being initialized (it would make sense if we could read out from the controller which panel is connected). And the driver doesn't support this compatible either.
I assume that ozzmaker and waveshare needs to be added to bindings/vendor-prefixes.yaml, and that would be as a separate patch.
Documentation/devicetree/bindings/display/ilitek,ili9486.txt line 9
Quoted 2 lines
Documentation/devicetree/bindings/display/ilitek,ili9486.txt new file +2
-0+- dc-gpios: D/C pin +- reset-gpios: Reset pin
Both these are optional in the driver.
Documentation/devicetree/bindings/display/ilitek,ili9486.txt line 20
Quoted 11 lines
Documentation/devicetree/bindings/display/ilitek,ili9486.txt new file +11
-0+ +The node for this driver must be a child node of a SPI controller, hence +all mandatory properties described in ../spi/spi-bus.txt must be specified. + +Optional properties: +- rotation: panel rotation in degrees counter clockwise (0,90,180,270) +- backlight: phandle of the backlight device attached to the panel + +Example: + display@0{ + compatible = "ozzmaker,piscreen", "waveshare,rpi-lcd-35", "ilitek,ili9486";
Pick only one compatible for the example.
Noralf.
Documentation/devicetree/bindings/display/ilitek,ili9486.txt line 27
Quoted 8 lines
Documentation/devicetree/bindings/display/ilitek,ili9486.txt new file +7
-0+ reg = <0>; + spi-max-frequency = <32000000>; + dc-gpios = <&gpio0 9 GPIO_ACTIVE_HIGH>; + reset-gpios = <&gpio0 8 GPIO_ACTIVE_HIGH>; + rotation = <180>; + backlight = <&backlight>; + };
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Kamlesh Gurudasani
maintainerPATCH 2/2 drm/tinydrm: add support for ilitek, ili9486 based displays with regwidth=16
In reply to Kamlesh GurudasaniThis adds support fot ilitek,ili9486 based display with shift register in front of controller, basically with regwidth=16
--- MAINTAINERS | 7 + drivers/gpu/drm/tiny/Kconfig | 14 ++ drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/ili9486.c | 288 +++++++++++++++++++++++++++++++++++++++++ 4 files changed, 310 insertions(+) create mode 100644 drivers/gpu/drm/tiny/ili9486.c
MAINTAINERS +7 -0
@@ -5227,6 +5227,13 @@ S: Maintained F: drivers/gpu/drm/tiny/ili9225.c F: Documentation/devicetree/bindings/display/ilitek,ili9225.txt +DRM DRIVER FOR ILITEK ILI9486 PANELS +M: Kamlesh Gurudasani <[email protected]> +T: git git://anongit.freedesktop.org/drm/drm-misc +S: Maintained +F: drivers/gpu/drm/tiny/ili9486.c +F: Documentation/devicetree/bindings/display/ilitek,ili9486.txt + DRM DRIVER FOR HX8357D PANELS M: Eric Anholt <[email protected]> T: git git://anongit.freedesktop.org/drm/drm-misc
drivers/gpu/drm/tiny/Kconfig +14 -0
@@ -47,6 +47,20 @@ config TINYDRM_ILI9341 If M is selected the module will be called ili9341. +config TINYDRM_ILI9486 + tristate "DRM support for ILI9486 display panels" + depends on DRM && SPI + select DRM_KMS_HELPER + select DRM_KMS_CMA_HELPER + select DRM_MIPI_DBI + select BACKLIGHT_CLASS_DEVICE + help + DRM driver for the following Ilitek ILI486 panels: + * PISCREEN 3.5" 320x480 TFT (Ozzmaker 3.5") + * RPILCD 3.5" 320x480 TFT (Waveshare 3.5") + + If M is selected the module will be called ili9486. + config TINYDRM_MI0283QT tristate "DRM support for MI0283QT" depends on DRM && SPI
drivers/gpu/drm/tiny/Makefile +1 -0
@@ -8,3 +8,4 @@ obj-$(CONFIG_TINYDRM_MI0283QT) += mi0283qt.o obj-$(CONFIG_TINYDRM_REPAPER) += repaper.o obj-$(CONFIG_TINYDRM_ST7586) += st7586.o obj-$(CONFIG_TINYDRM_ST7735R) += st7735r.o +obj-$(CONFIG_TINYDRM_ILI9486) += ili9486.o
drivers/gpu/drm/tiny/ili9486.c new file +288 -0
288 lines not on this page · raw message
Signature · 6 lines
2.7.4 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 2/2] drm/tinydrm: add support for ilitek,ili9486 based displays with regwidth=16
Hi Kamlesh,
Nice to see this driver, this means I can now drop the piscreen driver from the out-of-tree tinydrm repo.
Den 25.01.2020 16.38, skrev Kamlesh Gurudasani:
Quoted 1 line
This adds support fot ilitek,ili9486 based display with shift register in front
s/fot/for/
Quoted 1 line
of controller, basically with regwidth=16
The last part of this sentence only makes sense for people that know fbtft. Either add a reference to fbtft or just drop it.
Quoted 3 lines
Signed-off-by Kamlesh Gurudasani <[email protected]>---
<snip>
Quoted 7 lines
drivers/gpu/drm/tiny/Kconfig +0
-0@@ -47,6 +47,20 @@ config TINYDRM_ILI9341 If M is selected the module will be called ili9341.
drivers/gpu/drm/tiny/Kconfig config TINYDRM_ILI9341 · line 58
Quoted 10 lines
drivers/gpu/drm/tiny/Kconfig +9
-0+config TINYDRM_ILI9486 + tristate "DRM support for ILI9486 display panels" + depends on DRM && SPI + select DRM_KMS_HELPER + select DRM_KMS_CMA_HELPER + select DRM_MIPI_DBI + select BACKLIGHT_CLASS_DEVICE + help + DRM driver for the following Ilitek ILI486 panels:
s/ILI486/ILI9486/
Quoted 13 lines
drivers/gpu/drm/tiny/Kconfig +5
-0+ * PISCREEN 3.5" 320x480 TFT (Ozzmaker 3.5") + * RPILCD 3.5" 320x480 TFT (Waveshare 3.5") + + If M is selected the module will be called ili9486. + config TINYDRM_MI0283QT tristate "DRM support for MI0283QT" depends on DRM && SPIdrivers/gpu/drm/tiny/Makefile +0
-0
drivers/gpu/drm/tiny/Makefile obj-$(CONFIG_TINYDRM_MI0283QT) += mi0283qt.o · line 11
Quoted 4 lines
drivers/gpu/drm/tiny/Makefile +1
-0@@ -8,3 +8,4 @@ obj-$(CONFIG_TINYDRM_MI0283QT) += mi0283qt.o obj-$(CONFIG_TINYDRM_REPAPER) += repaper.o obj-$(CONFIG_TINYDRM_ST7586) += st7586.o obj-$(CONFIG_TINYDRM_ST7735R) += st7735r.o +obj-$(CONFIG_TINYDRM_ILI9486) += ili9486.o
Please keep the entries sorted alphabetically.
drivers/gpu/drm/tiny/ili9486.c line 5
Quoted 11 lines
drivers/gpu/drm/tiny/ili9486.c new file +5
-0@@ -0,0 +1,288 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* DRM driver for Ilitek ILI9486 panels +* +* Copyright 2018 Kamlesh Gurudasani <[email protected]>
2020?
drivers/gpu/drm/tiny/ili9486.c line 8
Quoted 3 lines
drivers/gpu/drm/tiny/ili9486.c new file +3
-0+* +* Some code copied from mipi-dbi.c +* Copyright 2016 Noralf Tronnes
You can drop this last paragraph, I see that you've copied it from ili9225, but these tiny drivers are just more or less boilerplate drivers with very little special stuff.
Quoted 22 lines
drivers/gpu/drm/tiny/ili9486.c new file +22
-0+*/ + +#include <linux/backlight.h> +#include <linux/delay.h> +#include <linux/gpio/consumer.h> +#include <linux/module.h> +#include <linux/property.h> +#include <linux/spi/spi.h> +#include <video/mipi_display.h> + +#include <drm/drm_atomic_helper.h> +#include <drm/drm_drv.h> +#include <drm/drm_fb_helper.h> +#include <drm/drm_gem_cma_helper.h> +#include <drm/drm_gem_framebuffer_helper.h> +#include <drm/drm_mipi_dbi.h> +#include <drm/drm_modeset_helper.h> + +#define ILI9486_ITFCTR1 0xb0 +#define ILI9486_PWCTRL1 0xc2 +#define ILI9486_VMCTRL1 0xc5 +#define ILI9486_PGAMCTRL 0xe0
drivers/gpu/drm/tiny/ili9486.c line 40
Quoted 10 lines
drivers/gpu/drm/tiny/ili9486.c new file +10
-0+#define ILI9486_NGAMCTRL 0xe1 +#define ILI9486_DGAMCTRL 0xe2 +#define ILI9486_MADCTL_BGR BIT(3) +#define ILI9486_MADCTL_MV BIT(5) +#define ILI9486_MADCTL_MX BIT(6) +#define ILI9486_MADCTL_MY BIT(7) + +/* +* The PiScreen/waveshare rpi-lcd-35 has a SPI to 16-bit parallel bus converter +* in front of the display controller. This means that 8-bit values has to be
s/has/have/
drivers/gpu/drm/tiny/ili9486.c line 43
Quoted 3 lines
drivers/gpu/drm/tiny/ili9486.c new file +3
-0+* transferred as 16-bit. +*/ +static int ili9486_command (struct mipi_dbi *mipi,u8 *cmd,u8 *par,size_t num)
The function name here is misleading, the ili9486 can use the default in drm_mipi_dbi when used in SPI mode, so you should name it piscreen_command or waveshare_command since it's special for those displays.
Quoted 6 lines
drivers/gpu/drm/tiny/ili9486.c new file +6
-0+{ +struct spi_device *spi = mipi->spi; +void *data = par; +u32 speed_hz; +unsigned int bpw =8 ; +int i, ret;
drivers/gpu/drm/tiny/ili9486.c line 59
Quoted 10 lines
drivers/gpu/drm/tiny/ili9486.c new file +10
-0+u16 *buf; + + buf =kmalloc (32 *sizeof (u16),GFP_KERNEL ); +if (!buf) +return -ENOMEM ; + +/* +* The Raspberry Pi supports only 8-bit on the DMA capable SPI +* controller and is little endian, so byte swapping is needed. +*/
I found this comment a bit confusing at first, then I realised that I wrote it myself in the piscreen driver. I think we should expand a little here to make it clear that these displays are made for the Pi. Maybe something like this:
The displays are Raspberry Pi HATs and connected to the 8-bit only SPI controller so 16-bit command and parameters need byte swapping before being transferred as 8-bit on the big endian SPI bus.
Pixel data bytes have already been swapped before this function is called.
drivers/gpu/drm/tiny/ili9486.c line 63
Quoted 4 lines
drivers/gpu/drm/tiny/ili9486.c new file +4
-0+ buf[0 ] =cpu_to_be16 (*cmd); +gpiod_set_value_cansleep (mipi->dc,0 ); + speed_hz =mipi_dbi_spi_cmd_max_speed (spi,2 ); + ret =mipi_dbi_spi_transfer (spi, speed_hz, bpw, buf,2 );
You don't change bpw, so you can drop the variable and use the value directly.
Quoted 11 lines
drivers/gpu/drm/tiny/ili9486.c new file +11
-0+if (ret || !num) + goto free; + +/* 8-bit configuration data, not 16-bit pixel data */ +if (num <=32 ) { +for (i =0 ; i < num; i++) + buf[i] =cpu_to_be16 (par[i]); + num *=2 ; + speed_hz =mipi_dbi_spi_cmd_max_speed (spi, num); + data = buf; + }
drivers/gpu/drm/tiny/ili9486.c line 84
Quoted 10 lines
drivers/gpu/drm/tiny/ili9486.c new file +10
-0+ +gpiod_set_value_cansleep (mipi->dc,1 ); + ret =mipi_dbi_spi_transfer (spi, speed_hz, bpw, data, num); + free: +kfree (buf); + +return ret; +} + +static void ili9486_enable(struct drm_simple_display_pipe *pipe,
Please change the function name here as well. The enable function is always display specific.
Quoted 17 lines
drivers/gpu/drm/tiny/ili9486.c new file +17
-0+struct drm_crtc_state *crtc_state, + struct drm_plane_state *plane_state) +{ + struct mipi_dbi_dev *dbidev = drm_to_mipi_dbi_dev(pipe->crtc.dev); +struct mipi_dbi *dbi = &dbidev->dbi; +u8 addr_mode; +int ret, idx; + +if (!drm_dev_enter (pipe->crtc.dev, &idx)) +return ; + +DRM_DEBUG_KMS ("\n" ); + + ret =mipi_dbi_poweron_conditional_reset (dbidev); +if (ret <0 ) + goto out_exit; +if (ret ==1 )
drivers/gpu/drm/tiny/ili9486.c line 111
Quoted 10 lines
drivers/gpu/drm/tiny/ili9486.c new file +10
-0+ goto out_enable; + +mipi_dbi_command (dbi,ILI9486_ITFCTR1 ); +mipi_dbi_command (dbi,MIPI_DCS_EXIT_SLEEP_MODE ); +msleep (250 ); + +/* Interface Pixel Format */ +mipi_dbi_command (dbi,MIPI_DCS_SET_PIXEL_FORMAT ,0x55 ); + +/* Power Control 3 */
The comment doesn't match the macro.
I think you can drop these comments, the macros (almost) says it all.
Quoted 33 lines
drivers/gpu/drm/tiny/ili9486.c new file +33
-0+mipi_dbi_command (dbi,ILI9486_PWCTRL1 ,0x44 ); + +/* VCOM Control 1 */ +mipi_dbi_command (dbi,ILI9486_VMCTRL1 ,0x00 ,0x00 ,0x00 ,0x00 ); + +/* PGAMCTRL(Positive Gamma Control) */ +mipi_dbi_command (dbi,ILI9486_PGAMCTRL , +0x0F ,0x1F ,0x1C ,0x0C ,0x0F ,0x08 ,0x48 ,0x98 , +0x37 ,0x0A ,0x13 ,0x04 ,0x11 ,0x0D ,0x0 ); +mipi_dbi_command (dbi,ILI9486_NGAMCTRL , +0x0F ,0x32 ,0x2E ,0x0B ,0x0D ,0x05 ,0x47 ,0x75 , +0x37 ,0x06 ,0x10 ,0x03 ,0x24 ,0x20 ,0x00 ); +mipi_dbi_command (dbi,ILI9486_DGAMCTRL , +0x0F ,0x32 ,0x2E ,0x0B ,0x0D ,0x05 ,0x47 ,0x75 , +0x37 ,0x06 ,0x10 ,0x03 ,0x24 ,0x20 ,0x00 ); + +mipi_dbi_command (dbi,MIPI_DCS_SET_DISPLAY_ON ); +msleep (100 ); + + out_enable: +switch (dbidev->rotation) { +case 90 : + addr_mode =ILI9486_MADCTL_MY ; +break ; +case 180 : + addr_mode =ILI9486_MADCTL_MV ; +break ; +case 270 : + addr_mode =ILI9486_MADCTL_MX ; +break ; +default : + addr_mode =ILI9486_MADCTL_MV |ILI9486_MADCTL_MY | +ILI9486_MADCTL_MX ;
drivers/gpu/drm/tiny/ili9486.c line 154
Quoted 10 lines
drivers/gpu/drm/tiny/ili9486.c new file +10
-0+break ; + } + addr_mode |=ILI9486_MADCTL_BGR ; +mipi_dbi_command (dbi,MIPI_DCS_SET_ADDRESS_MODE , addr_mode); +mipi_dbi_enable_flush (dbidev, crtc_state, plane_state); + out_exit: +drm_dev_exit (idx); +} + +static const struct drm_simple_display_pipe_funcs ili9486_pipe_funcs = {
Pipe funcs are also display specific.
drivers/gpu/drm/tiny/ili9486.c line 161
Quoted 7 lines
drivers/gpu/drm/tiny/ili9486.c new file +7
-0+ .enable = ili9486_enable, + .disable = mipi_dbi_pipe_disable, + .update = mipi_dbi_pipe_update, + .prepare_fb = drm_gem_fb_simple_display_pipe_prepare_fb, +}; + +static const struct drm_display_mode ili9486_mode = {
Display specific.
Quoted 52 lines
drivers/gpu/drm/tiny/ili9486.c new file +52
-0+DRM_SIMPLE_MODE (480 ,320 ,73 ,49 ), +}; + +DEFINE_DRM_GEM_CMA_FOPS (ili9486_fops); + +static struct drm_driver ili9486_driver = { + .driver_features =DRIVER_GEM |DRIVER_MODESET |DRIVER_ATOMIC , + .fops = &ili9486_fops, + .release = mipi_dbi_release, +DRM_GEM_CMA_VMAP_DRIVER_OPS , + .debugfs_init = mipi_dbi_debugfs_init, + .name ="ili9486" , + .desc ="Ilitek ILI9486" , + .date ="20200118" , + .major =1 , + .minor =0 , +}; + +static const struct of_device_id ili9486_of_match[] = { + { .compatible ="waveshare,rpi-lcd-35" }, + { .compatible ="ozzmaker,piscreen" }, + {}, +}; +MODULE_DEVICE_TABLE (of, ili9486_of_match); + +static const struct spi_device_id ili9486_id[] = { + {"ili9486" ,0 }, + { } +}; +MODULE_DEVICE_TABLE (spi, ili9486_id); + +static int ili9486_probe (struct spi_device *spi) +{ +struct device *dev = &spi->dev; +struct mipi_dbi_dev *dbidev; +struct drm_device *drm; +struct mipi_dbi *dbi; +struct gpio_desc *dc; +u32 rotation =0 ; +int ret; + + dbidev =kzalloc (sizeof (*dbidev),GFP_KERNEL ); +if (!dbidev) +return -ENOMEM ; + + dbi = &dbidev->dbi; + drm = &dbidev->drm; + ret =devm_drm_dev_init (dev, drm, &ili9486_driver); +if (ret) { +kfree (dbidev); +return ret; + }
drivers/gpu/drm/tiny/ili9486.c line 223
Quoted 10 lines
drivers/gpu/drm/tiny/ili9486.c new file +10
-0+ +drm_mode_config_init (drm); + + dbi->reset =devm_gpiod_get_optional (dev,"reset" ,GPIOD_OUT_HIGH ); +if (IS_ERR (dbi->reset)) { +DRM_DEV_ERROR (dev,"Failed to get gpio 'reset'\n" ); +return PTR_ERR (dbi->reset); + } + + dc =devm_gpiod_get_optional (dev,"dc" ,GPIOD_OUT_LOW );
I don't think DC is optional on these displays?
Quoted 17 lines
drivers/gpu/drm/tiny/ili9486.c new file +17
-0+if (IS_ERR (dc)) { +DRM_DEV_ERROR (dev,"Failed to get gpio 'dc'\n" ); +return PTR_ERR (dc); + } + + dbidev->backlight =devm_of_find_backlight (dev); +if (IS_ERR (dbidev->backlight)) +return PTR_ERR (dbidev->backlight); + +device_property_read_u32 (dev,"rotation" , &rotation); + + ret =mipi_dbi_spi_init (spi, dbi, dc); +if (ret) +return ret; + + ret =mipi_dbi_dev_init (dbidev, &ili9486_pipe_funcs, &ili9486_mode, rotation); +if (ret)
drivers/gpu/drm/tiny/ili9486.c line 250
Quoted 10 lines
drivers/gpu/drm/tiny/ili9486.c new file +10
-0+return ret; + +drm_mode_config_reset (drm); + + ret =drm_dev_register (drm,0 ); +if (ret) +return ret; + + dbi->command = ili9486_command; + dbi->read_commands =NULL ;
You can't change these after the device has been registered, put the assignements between mipi_dbi_spi_init and mipi_dbi_dev_init.
Noralf.
Quoted 29 lines
drivers/gpu/drm/tiny/ili9486.c new file +28
-0+ +spi_set_drvdata (spi, drm); + +drm_fbdev_generic_setup (drm,0 ); + +return 0 ; +} + +static int ili9486_remove (struct spi_device *spi) +{ +struct drm_device *drm =spi_get_drvdata (spi); + +drm_dev_unplug (drm); +drm_atomic_helper_shutdown (drm); + +return 0 ; +} + +static void ili9486_shutdown (struct spi_device *spi) +{ +drm_atomic_helper_shutdown (spi_get_drvdata (spi)); +} + +static struct spi_driver ili9486_spi_driver = { + .driver = { + .name ="ili9486" , + .of_match_table = ili9486_of_match, + },
drivers/gpu/drm/tiny/ili9486.c line 288
Quoted 10 lines
drivers/gpu/drm/tiny/ili9486.c new file +10
-0+ .id_table = ili9486_id, + .probe = ili9486_probe, + .remove = ili9486_remove, + .shutdown = ili9486_shutdown, +}; +module_spi_driver (ili9486_spi_driver); + +MODULE_DESCRIPTION ("Ilitek ILI9486 DRM driver" ); +MODULE_AUTHOR ("Kamlesh Gurudasani <[email protected]>" ); +MODULE_LICENSE ("GPL" );
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel