Skip to contentSkip to conversation

Staging: media: rkisp1: trim diagram in comments to 80 chars

PATCH In review Enrique Vargas 2 participants 5 messages Mar 15, 2020 – Mar 16, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover Staging: media: rkisp1: trim diagram in comments to 80 chars

*** BLURB HERE ***

Enrique Vargas (2):
reduce comments width bellow 80 chars
eliminate trailing whitespaces on comments

 drivers/staging/media/rkisp1/rkisp1-dev.c | 54 ++++++++++++++++-------
 1 file changed, 37 insertions(+), 17 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/2 Staging: media: rkisp1: reduce comments width bellow 80 chars

Make 'Main Picture Path' part of block diagram on separate rows to avoid 80 chars WARNING found with checkpatch.

---
 drivers/staging/media/rkisp1/rkisp1-dev.c | 57 ++++++++++++++++-------
 1 file changed, 39 insertions(+), 18 deletions(-)
drivers/staging/media/rkisp1/rkisp1-dev.c +39 -18
index 558126e66465..194fc33941f0 100644
@@ -37,26 +37,47 @@
  *
  * ISP Block Diagram
  * -----------------
- *                                                             rkisp1-resizer.c          rkisp1-capture.c
- *                                                          |====================|  |=======================|
- *                                rkisp1-isp.c                              Main Picture Path
- *                        |==========================|      |===============================================|
- *                        +-----------+  +--+--+--+--+      +--------+  +--------+              +-----------+
- *                        |           |  |  |  |  |  |      |        |  |        |              |           |
- * +--------+    |\       |           |  |  |  |  |  |   -->|  Crop  |->|  RSZ   |------------->|           |
- * |  MIPI  |--->|  \     |           |  |  |  |  |  |   |  |        |  |        |              |           |
- * +--------+    |   |    |           |  |IE|IE|IE|IE|   |  +--------+  +--------+              |  Memory   |
- *               |MUX|--->|    ISP    |->|0 |1 |2 |3 |---+                                      | Interface |
- * +--------+    |   |    |           |  |  |  |  |  |   |  +--------+  +--------+  +--------+  |           |
- * |Parallel|--->|  /     |           |  |  |  |  |  |   |  |        |  |        |  |        |  |           |
- * +--------+    |/       |           |  |  |  |  |  |   -->|  Crop  |->|  RSZ   |->|  RGB   |->|           |
- *                        |           |  |  |  |  |  |      |        |  |        |  | Rotate |  |           |
- *                        +-----------+  +--+--+--+--+      +--------+  +--------+  +--------+  +-----------+
+ *                                                          
+ *                                                          
+ *                                rkisp1-isp.c              
+ *                        |==========================|      
+ *                        +-----------+  +--+--+--+--+   
+ *                        |           |  |  |  |  |  |   
+ * +--------+    |\       |           |  |  |  |  |  |   
+ * |  MIPI  |--->|  \     |           |  |  |  |  |  |   
+ * +--------+    |   |    |           |  |IE|IE|IE|IE|   
+ *               |MUX|--->|    ISP    |->|0 |1 |2 |3 |--[A]--
+ * +--------+    |   |    |           |  |  |  |  |  |   
+ * |Parallel|--->|  /     |           |  |  |  |  |  |   
+ * +--------+    |/       |           |  |  |  |  |  |   
+ *                        |           |  |  |  |  |  |   
+ *                        +-----------+  +--+--+--+--+   
  *                                               ^
- * +--------+                                    |          |===============================================|
- * |  DMA   |------------------------------------+                          Self Picture Path
+ * +--------+                                    |       
+ * |  DMA   |------------------------------------+       
  * +--------+
- *
+ * 
+ * 
+ *              rkisp1-resizer.c          rkisp1-capture.c
+ *            |====================|  |=======================|
+ *                         Main Picture Path
+ *            |===============================================|
+ *            +--------+  +--------+              +-----------+
+ *            |        |  |        |              |           |
+ *         -->|  Crop  |->|  RSZ   |------------->|           |
+ *         |  |        |  |        |              |           |
+ *         |  +--------+  +--------+              |  Memory   |
+ * --[A]---+                                      | Interface |
+ *         |  +--------+  +--------+  +--------+  |           |
+ *         |  |        |  |        |  |        |  |           |
+ *         -->|  Crop  |->|  RSZ   |->|  RGB   |->|           |
+ *            |        |  |        |  | Rotate |  |           |
+ *            +--------+  +--------+  +--------+  +-----------+
+ *  
+ *            |===============================================|
+ *                          Self Picture Path
+ * 
+ * 
  *         rkisp1-stats.c        rkisp1-params.c
  *       |===============|      |===============|
  *       +---------------+      +---------------+
Signature · 1 line
2.17.1
#2 lore raw

Re: [PATCH 1/2] Staging: media: rkisp1: reduce comments width bellow 80 chars

Hi Enric,

Quoted 21 lines · Enrique Vargas

Make 'Main Picture Path' part of block diagram on separate rows to avoid 80 chars WARNING found with checkpatch.

---
 drivers/staging/media/rkisp1/rkisp1-dev.c | 57 ++++++++++++++++-------
 1 file changed, 39 insertions(+), 18 deletions(-)
drivers/staging/media/rkisp1/rkisp1-dev.c +0 -5
index 558126e66465..194fc33941f0 100644
@@ -37,26 +37,47 @@
  *
  * ISP Block Diagram
  * -----------------
- *                                                             rkisp1-resizer.c          rkisp1-capture.c
- *                                                          |====================|  |=======================|
- *                                rkisp1-isp.c                              Main Picture Path
- *                        |==========================|      |===============================================|
- *                        +-----------+  +--+--+--+--+      +--------+  +--------+              +-----------+

drivers/staging/media/rkisp1/rkisp1-dev.c line 54

Quoted 10 lines
drivers/staging/media/rkisp1/rkisp1-dev.c +0 -10
- *                        |           |  |  |  |  |  |      |        |  |        |              |           |
- * +--------+    |\       |           |  |  |  |  |  |   -->|  Crop  |->|  RSZ   |------------->|           |
- * |  MIPI  |--->|  \     |           |  |  |  |  |  |   |  |        |  |        |              |           |
- * +--------+    |   |    |           |  |IE|IE|IE|IE|   |  +--------+  +--------+              |  Memory   |
- *               |MUX|--->|    ISP    |->|0 |1 |2 |3 |---+                                      | Interface |
- * +--------+    |   |    |           |  |  |  |  |  |   |  +--------+  +--------+  +--------+  |           |
- * |Parallel|--->|  /     |           |  |  |  |  |  |   |  |        |  |        |  |        |  |           |
- * +--------+    |/       |           |  |  |  |  |  |   -->|  Crop  |->|  RSZ   |->|  RGB   |->|           |
- *                        |           |  |  |  |  |  |      |        |  |        |  | Rotate |  |           |
- *                        +-----------+  +--+--+--+--+      +--------+  +--------+  +--------+  +-----------+

To be honest, I prefer the old way, I think it is easier to visualize. But lets see what others think.

Quoted 5 lines
drivers/staging/media/rkisp1/rkisp1-dev.c +5 -0
+ *                                                          
+ *                                                          
+ *                                rkisp1-isp.c              
+ *                        |==========================|      
+ *                        +-----------+  +--+--+--+--+   

drivers/staging/media/rkisp1/rkisp1-dev.c line 54

Quoted 10 lines
drivers/staging/media/rkisp1/rkisp1-dev.c +10 -0
+ *                        |           |  |  |  |  |  |   
+ * +--------+    |\       |           |  |  |  |  |  |   
+ * |  MIPI  |--->|  \     |           |  |  |  |  |  |   
+ * +--------+    |   |    |           |  |IE|IE|IE|IE|   
+ *               |MUX|--->|    ISP    |->|0 |1 |2 |3 |--[A]--
+ * +--------+    |   |    |           |  |  |  |  |  |   
+ * |Parallel|--->|  /     |           |  |  |  |  |  |   
+ * +--------+    |/       |           |  |  |  |  |  |   
+ *                        |           |  |  |  |  |  |   
+ *                        +-----------+  +--+--+--+--+   

You can eliminate the trailing spaces in this patch, since it was generated due to this line break, so you don't need the second patch.

Regards,
Helen

Quoted 33 lines
drivers/staging/media/rkisp1/rkisp1-dev.c +24 -3
  *                                               ^
- * +--------+                                    |          |===============================================|
- * |  DMA   |------------------------------------+                          Self Picture Path
+ * +--------+                                    |       
+ * |  DMA   |------------------------------------+       
  * +--------+
- *
+ * 
+ * 
+ *              rkisp1-resizer.c          rkisp1-capture.c
+ *            |====================|  |=======================|
+ *                         Main Picture Path
+ *            |===============================================|
+ *            +--------+  +--------+              +-----------+
+ *            |        |  |        |              |           |
+ *         -->|  Crop  |->|  RSZ   |------------->|           |
+ *         |  |        |  |        |              |           |
+ *         |  +--------+  +--------+              |  Memory   |
+ * --[A]---+                                      | Interface |
+ *         |  +--------+  +--------+  +--------+  |           |
+ *         |  |        |  |        |  |        |  |           |
+ *         -->|  Crop  |->|  RSZ   |->|  RGB   |->|           |
+ *            |        |  |        |  | Rotate |  |           |
+ *            +--------+  +--------+  +--------+  +-----------+
+ *  
+ *            |===============================================|
+ *                          Self Picture Path
+ * 
+ * 
  *         rkisp1-stats.c        rkisp1-params.c
  *       |===============|      |===============|
  *       +---------------+      +---------------+
#3 lore raw

PATCH 2/2 Staging: media: rkisp1: eliminate trailing whitespaces on comments

In reply to Enrique Vargas

Eliminate lines with trailing whitespaces in block diagram. Found with checkpatch.

---
 drivers/staging/media/rkisp1/rkisp1-dev.c | 41 +++++++++++------------
 1 file changed, 20 insertions(+), 21 deletions(-)
drivers/staging/media/rkisp1/rkisp1-dev.c +20 -21
index 194fc33941f0..faa8538b9fea 100644
@@ -37,27 +37,26 @@
  *
  * ISP Block Diagram
  * -----------------
- *                                                          
- *                                                          
- *                                rkisp1-isp.c              
- *                        |==========================|      
- *                        +-----------+  +--+--+--+--+   
- *                        |           |  |  |  |  |  |   
- * +--------+    |\       |           |  |  |  |  |  |   
- * |  MIPI  |--->|  \     |           |  |  |  |  |  |   
- * +--------+    |   |    |           |  |IE|IE|IE|IE|   
+ *
+ *                                rkisp1-isp.c
+ *                        |==========================|
+ *                        +-----------+  +--+--+--+--+
+ *                        |           |  |  |  |  |  |
+ * +--------+    |\       |           |  |  |  |  |  |
+ * |  MIPI  |--->|  \     |           |  |  |  |  |  |
+ * +--------+    |   |    |           |  |IE|IE|IE|IE|
  *               |MUX|--->|    ISP    |->|0 |1 |2 |3 |--[A]--
- * +--------+    |   |    |           |  |  |  |  |  |   
- * |Parallel|--->|  /     |           |  |  |  |  |  |   
- * +--------+    |/       |           |  |  |  |  |  |   
- *                        |           |  |  |  |  |  |   
- *                        +-----------+  +--+--+--+--+   
+ * +--------+    |   |    |           |  |  |  |  |  |
+ * |Parallel|--->|  /     |           |  |  |  |  |  |
+ * +--------+    |/       |           |  |  |  |  |  |
+ *                        |           |  |  |  |  |  |
+ *                        +-----------+  +--+--+--+--+
  *                                               ^
- * +--------+                                    |       
- * |  DMA   |------------------------------------+       
+ * +--------+                                    |
+ * |  DMA   |------------------------------------+
  * +--------+
- * 
- * 
+ *
+ *
  *              rkisp1-resizer.c          rkisp1-capture.c
  *            |====================|  |=======================|
  *                         Main Picture Path
@@ -73,11 +72,11 @@
  *         -->|  Crop  |->|  RSZ   |->|  RGB   |->|           |
  *            |        |  |        |  | Rotate |  |           |
  *            +--------+  +--------+  +--------+  +-----------+
- *  
+ *
  *            |===============================================|
  *                          Self Picture Path
- * 
- * 
+ *
+ *
  *         rkisp1-stats.c        rkisp1-params.c
  *       |===============|      |===============|
  *       +---------------+      +---------------+
Signature · 1 line
2.17.1
#4 lore raw
In reply to Enrique Vargas

Hi Enrique,

Quoted 1 line · Enrique Vargas

*** BLURB HERE ***

I think you forgot to fill out the cover letter.

Please, see more information on https://kernelnewbies.org/PatchSeries

Let me know if you have any questions.

Regards,
Helen

Quoted 8 lines

Enrique Vargas (2):
reduce comments width bellow 80 chars
eliminate trailing whitespaces on comments

 drivers/staging/media/rkisp1/rkisp1-dev.c | 54 ++++++++++++++++-------
 1 file changed, 37 insertions(+), 17 deletions(-)