Skip to contentSkip to conversation

Correction of typos and long lines of comments

PATCH RESEND In review R Veera Kumar 3 participants 14 messages Mar 19, 2020 Staging

lore
Share & tools
lore
#0 lore raw

cover Correction of typos and long lines of comments

Correction of typos and long lines of comments.
Misspellings found using checkpatch.pl.

---
R Veera Kumar (10):
staging: rtl8723bs: hal: Correct a typo in a comment
staging: rtl8723bs: hal: Correct a typo in a comment
staging: rtl8723bs: hal: Correct typos and long line of comment
staging: rtl8723bs: hal: Correct a typo and long line of a comment
staging: rtl8723bs: hal: Correct a typo and long line of a comment
staging: rtl8723bs: hal: Correct typos and long line of comments
staging: rtl8723bs: hal: Correct a typo in a comment
staging: rtl8723bs: hal: Correct typos in a comment
staging: rtl8723bs: hal: Correct a typo in a comment
staging: rtl8723bs: hal: Correct a typo in a comment

 drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c |  2 +-
 drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c |  2 +-
 drivers/staging/rtl8723bs/hal/HalPhyRf.c        |  7 +++++--
 drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c    |  5 ++++-
 drivers/staging/rtl8723bs/hal/hal_intf.c        |  3 ++-
 drivers/staging/rtl8723bs/hal/odm_HWConfig.c    | 16 +++++++++-------
 drivers/staging/rtl8723bs/hal/odm_debug.h       |  4 ++--
 drivers/staging/rtl8723bs/hal/odm_types.h       |  2 +-
 drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c  |  2 +-
 drivers/staging/rtl8723bs/hal/sdio_halinit.c    |  2 +-
 10 files changed, 27 insertions(+), 18 deletions(-)
Signature · 1 line
2.20.1
#1 lore raw

PATCH RESEND 1/10 staging: rtl8723bs: hal: Correct a typo in a comment

Correct a single typo in a comment.
Misspelling found using checkpatch.pl.

---
 drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c +1 -1
index dd349c506da8..c60e8c58d9cc 100644
@@ -1807,7 +1807,7 @@ static void halbtc8723b1ant_TdmaDurationAdjustForAcl(
 		result = 0;
 		WaitCount = 0;
 	} else {
-		/* accquire the BT TRx retry count from BT_Info byte2 */
+		/* acquire the BT TRx retry count from BT_Info byte2 */
 		retryCount = pCoexSta->btRetryCnt;
 		btInfoExt = pCoexSta->btInfoExt;
 		/* BTC_PRINT(BTC_MSG_ALGORITHM, ALGO_TRACE_FW_DETAIL, ("[BTCoex], retryCount = %d\n", retryCount)); */
Signature · 1 line
2.20.1
#2 lore raw

PATCH RESEND 2/10 staging: rtl8723bs: hal: Correct a typo in a comment

In reply to R Veera Kumar

Correct a single typo in a comment.
Misspelling found using checkpatch.pl.

---
 drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c +1 -1
index 8dfa9b988e20..2779dba92bab 100644
@@ -1646,7 +1646,7 @@ static void halbtc8723b2ant_TdmaDurationAdjust(
 		result = 0;
 		WaitCount = 0;
 	} else {
-		/* accquire the BT TRx retry count from BT_Info byte2 */
+		/* acquire the BT TRx retry count from BT_Info byte2 */
 		retryCount = pCoexSta->btRetryCnt;
 		BTC_PRINT(BTC_MSG_ALGORITHM, ALGO_TRACE_FW_DETAIL, ("[BTCoex], retryCount = %d\n", retryCount));
 		BTC_PRINT(
Signature · 1 line
2.20.1
#3 lore raw

PATCH RESEND 3/10 staging: rtl8723bs: hal: Correct typos and long line of comment

In reply to R Veera Kumar

Correct a long line comment to respect 80 character line limit. Correct a typo in the same comments.
Misspelling found using checkpatch.pl.

---
 drivers/staging/rtl8723bs/hal/HalPhyRf.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/hal/HalPhyRf.c +5 -2
index 357802db9aed..688f29dd84bc 100644
@@ -92,7 +92,7 @@ void ODM_TXPowerTrackingCallback_ThermalMeter(struct adapter *Adapter)
 	u8 *deltaSwingTableIdx_TUP_B;
 	u8 *deltaSwingTableIdx_TDOWN_B;
 
-	/* 4 2. Initilization (7 steps in total) */
+	/* 4 2. Initialization (7 steps in total) */
 
 	ConfigureTxpowerTrack(pDM_Odm, &c);
 
@@ -213,7 +213,10 @@ void ODM_TXPowerTrackingCallback_ThermalMeter(struct adapter *Adapter)
 
 	/* 3 7. If necessary, move the index of swing table to adjust Tx power. */
 	if (delta > 0 && pDM_Odm->RFCalibrateInfo.TxPowerTrackControl) {
-		/* delta" here is used to record the absolute value of differrence. */
+		/*
+		 * delta" here is used to record the absolute value of
+		 * difference.
+		 */
 		delta =
 			ThermalValue > pHalData->EEPROMThermalMeter ?
 			(ThermalValue - pHalData->EEPROMThermalMeter) :
Signature · 1 line
2.20.1
#4 lore raw

PATCH RESEND 4/10 staging: rtl8723bs: hal: Correct a typo and long line of a comment

In reply to R Veera Kumar

Correct a long line comment to respect 80 character line limit. Correct a typo in the same comment.
Misspelling found using checkpatch.pl.

---
 drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c +4 -1
index c24156873fed..aefba05c8cd4 100644
@@ -118,7 +118,10 @@ u8 HalPwrSeqCmdParsing(
 						&GET_PWR_CFG_MASK(PwrCfgCmd)
 					);
 
-					/*  Write the value back to sytem register */
+					/*
+					 * Write the value back to system
+					 * register
+					 */
 					rtw_write8(padapter, offset, value);
 				}
 				break;
Signature · 1 line
2.20.1
#5 lore raw

PATCH RESEND 5/10 staging: rtl8723bs: hal: Correct a typo and long line of a comment

In reply to R Veera Kumar

Correct a long line comment to respect 80 character line limit. Correct a typo in the same comment.
Misspelling found using checkpatch.pl.

---
 drivers/staging/rtl8723bs/hal/hal_intf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/rtl8723bs/hal/hal_intf.c +2 -1
index 7d8f21f32fb9..8aebb8bc11c4 100644
@@ -365,7 +365,8 @@ void rtw_hal_dm_watchdog_in_lps(struct adapter *padapter)
 {
 	if (adapter_to_pwrctl(padapter)->bFwCurrentInPSMode == true) {
 		if (padapter->HalFunc.hal_dm_watchdog_in_lps)
-			padapter->HalFunc.hal_dm_watchdog_in_lps(padapter); /* this fuction caller is in interrupt context */
+			padapter->HalFunc.hal_dm_watchdog_in_lps(padapter);
+			/* this function caller is in interrupt context */
 	}
 }
 
Signature · 1 line
2.20.1
#6 lore raw

PATCH RESEND 6/10 staging: rtl8723bs: hal: Correct typos and long line of comments

In reply to R Veera Kumar

Correct long line comments to respect 80 character line limit. Correct typo in the same comments.
Misspelling found using checkpatch.pl.

---
 drivers/staging/rtl8723bs/hal/odm_HWConfig.c | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)
drivers/staging/rtl8723bs/hal/odm_HWConfig.c +9 -7
index 9950934c3ab3..2bcbe3171dbe 100644
@@ -101,10 +101,11 @@ static void odm_RxPhyStatus92CSeries_Parsing(
 		u8 cck_agc_rpt;
 
 		pDM_Odm->PhyDbgInfo.NumQryPhyStatusCCK++;
-		/*  */
-		/*  (1)Hardware does not provide RSSI for CCK */
-		/*  (2)PWDB, Average PWDB cacluated by hardware (for rate adaptive) */
-		/*  */
+		/*
+		 * (1)Hardware does not provide RSSI for CCK
+		 * (2)PWDB, Average PWDB calculated by hardware
+		 *    (for rate adaptive)
+		 */
 
 		cck_agc_rpt = pPhyStaRpt->cck_agc_rpt_ofdm_cfosho_a;
 
@@ -177,9 +178,10 @@ static void odm_RxPhyStatus92CSeries_Parsing(
 		}
 
 
-		/*  */
-		/*  (2)PWDB, Average PWDB cacluated by hardware (for rate adaptive) */
-		/*  */
+		/*
+		 * (2)PWDB, Average PWDB calculated by hardware
+		 * (for rate adaptive)
+		 */
 		rx_pwr_all = (((pPhyStaRpt->cck_sig_qual_ofdm_pwdb_all) >> 1)&0x7f)-110;
 
 		PWDB_ALL_BT = PWDB_ALL = odm_QueryRxPwrPercentage(rx_pwr_all);
Signature · 1 line
2.20.1
#7 lore raw

PATCH RESEND 7/10 staging: rtl8723bs: hal: Correct a typo in a comment

In reply to R Veera Kumar

Correct a single typo in a comment.
Misspelling found using checkpatch.pl.

---
 drivers/staging/rtl8723bs/hal/odm_debug.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/hal/odm_debug.h +2 -2
index 3e58cb806c8c..a7381173d1a3 100644
@@ -13,7 +13,7 @@
 /* Define the debug levels */
 /*  */
 /* 1.	DBG_TRACE and DBG_LOUD are used for normal cases. */
-/* So that, they can help SW engineer to develope or trace states changed */
+/* So that, they can help SW engineer to developed or trace states changed */
 /* and also help HW enginner to trace every operation to and from HW, */
 /* e.g IO, Tx, Rx. */
 /*  */
@@ -34,7 +34,7 @@
 #define ODM_DBG_SERIOUS				2
 
 /*  */
-/* Abnormal, rare, or unexpeted cases. */
+/* Abnormal, rare, or unexpected cases. */
 /* For example, */
 /* IRP/Packet/OID canceled, */
 /* device suprisely unremoved and so on. */
Signature · 1 line
2.20.1
#8 lore raw

PATCH RESEND 8/10 staging: rtl8723bs: hal: Correct typos in a comment

In reply to R Veera Kumar

Correct a two typos in a comment.
Misspelling found using checkpatch.pl.

---
 drivers/staging/rtl8723bs/hal/odm_types.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/hal/odm_types.h +1 -1
index 28f42c9c3dd7..c79fc1813c3f 100644
@@ -28,7 +28,7 @@ typedef enum _HAL_STATUS {
 
 
 /*  */
-/*  Declare for ODM spin lock defintion temporarily fro compile pass. */
+/*  Declare for ODM spin lock definition temporarily from compile pass. */
 /*  */
 typedef enum _RT_SPINLOCK_TYPE {
 	RT_TX_SPINLOCK = 1,
Signature · 1 line
2.20.1
#9 lore raw

PATCH RESEND 9/10 staging: rtl8723bs: hal: Correct a typo in a comment

In reply to R Veera Kumar

Correct a single typo in a comment.
Misspelling found using checkpatch.pl.

---
 drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c +1 -1
index 1e8b61443408..2b375e75be50 100644
@@ -192,7 +192,7 @@ static inline union recv_frame *try_alloc_recvframe(struct recv_priv *precvpriv,
 		rtw_enqueue_recvbuf_to_head(precvbuf,
 					    &precvpriv->recv_buf_pending_queue);
 
-		/*  The case of can't allocte recvframe should be temporary, */
+		/*  The case of can't allocate recvframe should be temporary, */
 		/*  schedule again and hope recvframe is available next time. */
 		tasklet_schedule(&precvpriv->recv_tasklet);
 	}
Signature · 1 line
2.20.1
#10 lore raw

PATCH RESEND 10/10 staging: rtl8723bs: hal: Correct a typo in a comment

In reply to R Veera Kumar

Correct a single typo in a comment.
Misspelling found using checkpatch.pl.

---
 drivers/staging/rtl8723bs/hal/sdio_halinit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/hal/sdio_halinit.c +1 -1
index 4894f7d9a1d4..7853af53051d 100644
@@ -235,7 +235,7 @@ static void _InitQueueReservedPage(struct adapter *padapter)
 	if (pHalData->OutEpQueueSel & TX_SELE_LQ)
 		numLQ = bWiFiConfig ? WMM_NORMAL_PAGE_NUM_LPQ_8723B : NORMAL_PAGE_NUM_LPQ_8723B;
 
-	/*  NOTE: This step shall be proceed before writting REG_RQPN. */
+	/*  NOTE: This step shall be proceed before writing REG_RQPN. */
 	if (pHalData->OutEpQueueSel & TX_SELE_NQ)
 		numNQ = bWiFiConfig ? WMM_NORMAL_PAGE_NUM_NPQ_8723B : NORMAL_PAGE_NUM_NPQ_8723B;
 
Signature · 1 line
2.20.1
#11 lore raw

Re: [RESEND PATCH 10/10] staging: rtl8723bs: hal: Correct a typo in a comment

Quoted 7 lines · R Veera Kumar

Correct a single typo in a comment.
Misspelling found using checkpatch.pl.

---
 drivers/staging/rtl8723bs/hal/sdio_halinit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

You have many patches in this series with the same identical subject line, yet they do different things.

Please fix that up to be unique, I can not take this series as-is, sorry.

greg k-h

#12 lore raw
In reply to R Veera Kumar
Quoted 15 lines · R Veera Kumar

Correction of typos and long lines of comments.
Misspellings found using checkpatch.pl.

---
R Veera Kumar (10):
staging: rtl8723bs: hal: Correct a typo in a comment
staging: rtl8723bs: hal: Correct a typo in a comment
staging: rtl8723bs: hal: Correct typos and long line of comment
staging: rtl8723bs: hal: Correct a typo and long line of a comment
staging: rtl8723bs: hal: Correct a typo and long line of a comment
staging: rtl8723bs: hal: Correct typos and long line of comments
staging: rtl8723bs: hal: Correct a typo in a comment
staging: rtl8723bs: hal: Correct typos in a comment
staging: rtl8723bs: hal: Correct a typo in a comment
staging: rtl8723bs: hal: Correct a typo in a comment

Maybe you could just put all the typo ones in a single patch? They should be easy to check and have no impact on the execution, so it is hard to see why one would want to revert them separately.

On the other hand, the patch would be just typos, not long line changes mixed in as well.

julia

Quoted 21 lines
 drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c |  2 +-
 drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c |  2 +-
 drivers/staging/rtl8723bs/hal/HalPhyRf.c        |  7 +++++--
 drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c    |  5 ++++-
 drivers/staging/rtl8723bs/hal/hal_intf.c        |  3 ++-
 drivers/staging/rtl8723bs/hal/odm_HWConfig.c    | 16 +++++++++-------
 drivers/staging/rtl8723bs/hal/odm_debug.h       |  4 ++--
 drivers/staging/rtl8723bs/hal/odm_types.h       |  2 +-
 drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c  |  2 +-
 drivers/staging/rtl8723bs/hal/sdio_halinit.c    |  2 +-
 10 files changed, 27 insertions(+), 18 deletions(-)

--
2.20.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1584514678.git.vkor%40vkten.in.

#13 lore raw
Quoted 7 lines · Julia Lawall
Quoted 3 lines · R Veera Kumar

Correction of typos and long lines of comments.
Misspellings found using checkpatch.pl.

Quoted 9 lines
Quoted 4 lines

---
R Veera Kumar (10):
staging: rtl8723bs: hal: Correct a typo in a comment
staging: rtl8723bs: hal: Correct a typo in a comment

Maybe you could just put all the typo ones in a single patch? They should be easy to check and have no impact on the execution, so it is hard to see why one would want to revert them separately.

Yes. That's what he meant in reply. But I did otherwise because in my first patch to mailing list I had typos in two different files. I sent it as single patch and he accepted. And the I asked him whether it could have been sent as patchset, and he said yes.

Now reading submitting-patches doc it says if it is single kind of change then it should be put in one patch. And only if it is logically different then in two separate patches.

Quoted 3 lines

On the other hand, the patch would be just typos, not long line changes mixed in as well.

Yeah.

Veera

Quoted 8 lines

julia

Quoted 6 lines
 drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c |  2 +-
 drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c |  2 +-
 drivers/staging/rtl8723bs/hal/HalPhyRf.c        |  7 +++++--
 10 files changed, 27 insertions(+), 18 deletions(-)