Patch review
cover Patch review
Please review this set of patches for dunfell and have comments back by end of day Friday.
The following changes since commit ac352ad7f95db7eeacb53c2778caa31800bd7c26:
Updated patch for publishing (2020-04-24 15:20:58 +0100)
are available in the Git repository at:
git://git.yoctoproject.org/yocto-docs contrib/dunfell-next
http://git.yoctoproject.org/cgit.cgi/yocto-docs/log/?h=contrib/dunfell-next
Robert P. J. Day (4):
ref-manual: fix excessive command indentation
ref-manual: IMAGE_TYPES, add tar.zst, delete elf
ref-manual: typo "SSTATE_MIRROR" -> "SSTATE_MIRRORS"
ref-manual: Remove long-dead PACKAGE_GROUP variable
documentation/ref-manual/migration.xml | 6 ++--- .../ref-manual/ref-system-requirements.xml | 4 +-- documentation/ref-manual/ref-variables.xml | 26 ++----------------- 3 files changed, 6 insertions(+), 30 deletions(-)
Signature · 1 line
2.17.1
PATCH 1/4 ref-manual: fix excessive command indentation
From: "Robert P. J. Day" <[email protected]>
--- documentation/ref-manual/ref-system-requirements.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
documentation/ref-manual/ref-system-requirements.xml +2 -2
@@ -503,7 +503,7 @@ </literallayout> or run the BitBake command to build the extended tarball: <literallayout class='monospaced'> - $ bitbake buildtools-extended-tarball + $ bitbake buildtools-extended-tarball </literallayout> <note> The
@@ -535,7 +535,7 @@ </literallayout> Here is an example for the extended installer: <literallayout class='monospaced'> - $ sh ~/Downloads/x86_64-buildtools-extended-nativesdk-standalone-&DISTRO;.sh + $ sh ~/Downloads/x86_64-buildtools-extended-nativesdk-standalone-&DISTRO;.sh </literallayout> During execution, a prompt appears that allows you to choose the installation directory.
Signature · 1 line
2.17.1
PATCH 2/4 ref-manual: IMAGE_TYPES, add tar.zst, delete elf
In reply to Steve SakomanFrom: "Robert P. J. Day" <[email protected]>
Update list of legal IMAGE_TYPES to match what's in image_types.bbclass.
--- documentation/ref-manual/ref-variables.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
documentation/ref-manual/ref-variables.xml +1 -1
@@ -6638,7 +6638,6 @@ cpio.lzma cpio.xz cramfs - elf ext2 ext2.bz2 ext2.gz
@@ -6662,6 +6661,7 @@ tar.gz tar.lz4 tar.xz + tar.zst ubi ubifs wic
Signature · 1 line
2.17.1
PATCH 3/4 ref-manual: typo "SSTATE_MIRROR" -> "SSTATE_MIRRORS"
In reply to Steve SakomanFrom: "Robert P. J. Day" <[email protected]>
--- documentation/ref-manual/ref-variables.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
documentation/ref-manual/ref-variables.xml +1 -1
@@ -14033,7 +14033,7 @@ <para> When pointing to sstate build artifacts on another machine that uses a different GCC version for native builds, - you must configure <filename>SSTATE_MIRROR</filename> + you must configure <filename>SSTATE_MIRRORS</filename> with a regular expression that maps local search paths to server paths. The paths need to take into account
Signature · 1 line
2.17.1
PATCH 4/4 ref-manual: Remove long-dead PACKAGE_GROUP variable
In reply to Steve SakomanFrom: "Robert P. J. Day" <[email protected]>
This was, years ago, deprecated in favour of FEATURE_PACKAGES, so remove all references, other than the entry in the migration section.
--- documentation/ref-manual/migration.xml | 6 ++---- documentation/ref-manual/ref-variables.xml | 22 ---------------------- 2 files changed, 2 insertions(+), 26 deletions(-)
documentation/ref-manual/migration.xml +2 -4
@@ -875,8 +875,7 @@ not work. This change is intended to catch those kinds of situations. Valid <filename>IMAGE_FEATURES</filename> are drawn from - <link linkend='var-PACKAGE_GROUP'><filename>PACKAGE_GROUP</filename></link> - definitions, + <filename>PACKAGE_GROUP</filename> definitions, <link linkend='var-COMPLEMENTARY_GLOB'><filename>COMPLEMENTARY_GLOB</filename></link> and a new "validitems" varflag on <filename>IMAGE_FEATURES</filename>.
@@ -1404,8 +1403,7 @@ <para> The - <link linkend='var-PACKAGE_GROUP'><filename>PACKAGE_GROUP</filename></link> - variable has been renamed to + <filename>PACKAGE_GROUP</filename> variable has been renamed to <link linkend='var-FEATURE_PACKAGES'><filename>FEATURE_PACKAGES</filename></link> to more accurately reflect its purpose. You can still use <filename>PACKAGE_GROUP</filename> but
documentation/ref-manual/ref-variables.xml +0 -22
@@ -10292,28 +10292,6 @@ </glossdef> </glossentry> - <glossentry id='var-PACKAGE_GROUP'><glossterm>PACKAGE_GROUP</glossterm> - <info> - PACKAGE_GROUP[doc] = "Defines one or more packages to include in an image when a specific item is included in IMAGE_FEATURES." - </info> - <glossdef> - <para role="glossdeffirst"> -<!-- <para role="glossdeffirst"><imagedata fileref="figures/define-generic.png" /> --> - The <filename>PACKAGE_GROUP</filename> variable has been - renamed to - <link linkend='var-FEATURE_PACKAGES'><filename>FEATURE_PACKAGES</filename></link>. - See the variable description for - <filename>FEATURE_PACKAGES</filename> for information. - </para> - - <para> - If if you use the <filename>PACKAGE_GROUP</filename> - variable, the OpenEmbedded build system issues a warning - message. - </para> - </glossdef> - </glossentry> - <glossentry id='var-PACKAGE_INSTALL'><glossterm>PACKAGE_INSTALL</glossterm> <info> PACKAGE_INSTALL[doc] = "List of the packages to be installed into the image. The variable is generally not user-defined and uses IMAGE_INSTALL as part of the list."
Signature · 1 line
2.17.1