Patchset of coding style fixes
cover Patchset of coding style fixes
This patchset fixed CHECK and WARNINGs of coding style.
Simon Fong (2):
staging: rtl8188eu: Fix CHECK of coding style
staging: rtl8188eu: Fix WARNINGs of Block comments
drivers/staging/rtl8188eu/core/rtw_recv.c | 7 ++- drivers/staging/rtl8188eu/core/rtw_xmit.c | 62 +++++++++++------------ 2 files changed, 34 insertions(+), 35 deletions(-)
Signature · 1 line
2.17.1
PATCH 1/2 staging: rtl8188eu: Fix CHECK of coding style
Fixed a CHECK of Lines should not end with a '('.
Signed-off-by Simon Fong <[email protected]>
--- drivers/staging/rtl8188eu/core/rtw_recv.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/staging/rtl8188eu/core/rtw_recv.c +3 -4
@@ -702,10 +702,9 @@ static int sta2sta_data_frame(struct adapter *adapter,return ret; } -static int ap2sta_data_frame ( -struct adapter *adapter, -struct recv_frame *precv_frame, -struct sta_info **psta) +static int ap2sta_data_frame (struct adapter *adapter, +struct recv_frame *precv_frame, +struct sta_info **psta) {u8 *ptr = precv_frame->pkt->data;struct rx_pkt_attrib *pattrib = &precv_frame->attrib;
Signature · 1 line
2.17.1
PATCH 2/2 staging: rtl8188eu: Fix WARNINGs of Block comments
In reply to Simon FongFixed 5 WARNINGs of Block comments use * on subsequent lines.
Signed-off-by Simon Fong <[email protected]>
--- drivers/staging/rtl8188eu/core/rtw_xmit.c | 62 +++++++++++------------ 1 file changed, 31 insertions(+), 31 deletions(-)
drivers/staging/rtl8188eu/core/rtw_xmit.c +31 -31
@@ -49,8 +49,8 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter)spin_lock_init (&pxmitpriv->lock);/* -Please insert all the queue initializaiton using _rtw_init_queue below -*/ +* Please insert all the queue initializaiton using _rtw_init_queue below +*/ pxmitpriv->adapter = padapter;
@@ -63,10 +63,10 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter)_rtw_init_queue (&pxmitpriv->free_xmit_queue);/* -Please allocate memory with the sz = (struct xmit_frame) * NR_XMITFRAME, -and initialize free_xmit_frame below. -Please also apply free_txobj to link_up all the xmit_frames... -*/ +* Please allocate memory with the sz = (struct xmit_frame) * NR_XMITFRAME, +* and initialize free_xmit_frame below. +* Please also apply free_txobj to link_up all the xmit_frames... +*/ pxmitpriv->pallocated_frame_buf =vzalloc (NR_XMITFRAME *sizeof (struct xmit_frame ) +4 );
@@ -893,17 +893,17 @@ s32 rtw_txframes_sta_ac_pending(struct adapter *padapter, struct pkt_attrib *pat }/* - -This sub-routine will perform all the following: - -1. remove 802.3 header. -2. create wlan_header, based on the info in pxmitframe -3. append sta's iv/ext-iv -4. append LLC -5. move frag chunk from pframe to pxmitframe->mem -6. apply sw-encrypt, if necessary. - -*/ +* +* This sub-routine will perform all the following: +* +* 1. remove 802.3 header. +* 2. create wlan_header, based on the info in pxmitframe +* 3. append sta's iv/ext-iv +* 4. append LLC +* 5. move frag chunk from pframe to pxmitframe->mem +* 6. apply sw-encrypt, if necessary. +* +*/ s32 rtw_xmitframe_coalesce (struct adapter *padapter,struct sk_buff *pkt,struct xmit_frame *pxmitframe) {s32 frg_inx, frg_len, mpdu_len, llc_sz, mem_sz;
@@ -1233,25 +1233,25 @@ s32 rtw_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf) }/* -Calling context: -1. OS_TXENTRY -2. RXENTRY (rx_thread or RX_ISR/RX_CallBack) - -If we turn on USE_RXTHREAD, then, no need for critical section. -Otherwise, we must use _enter/_exit critical to protect free_xmit_queue... - -Must be very very cautious... - -*/ +* Calling context: +* 1. OS_TXENTRY +* 2. RXENTRY (rx_thread or RX_ISR/RX_CallBack) +* +* If we turn on USE_RXTHREAD, then, no need for critical section. +* Otherwise, we must use _enter/_exit critical to protect free_xmit_queue... +* +* Must be very very cautious... +* +*/ struct xmit_frame *rtw_alloc_xmitframe (struct xmit_priv *pxmitpriv)/* _queue *pfree_xmit_queue) */ {/* -Please remember to use all the osdep_service api, -and lock/unlock or _enter/_exit critical to protect -pfree_xmit_queue -*/ +* Please remember to use all the osdep_service api, +* and lock/unlock or _enter/_exit critical to protect +* pfree_xmit_queue +*/ struct xmit_frame *pxframe;struct __queue *pfree_xmit_queue = &pxmitpriv->free_xmit_queue;
Signature · 1 line
2.17.1