Skip to contentSkip to conversation

Modernize rocktech,jh057n00900 bindings a bit

PATCH In review Guido Günther 2 participants 5 messages Aug 16, 2020 – Aug 17, 2020

Subsystems (5)
lore
Share & tools
lore

Guido Günther

author maintainer
#0 lore raw

cover Modernize rocktech,jh057n00900 bindings a bit

This was prompted by Sam's review in
https://lore.kernel.org/dri-devel/[email protected]/
and yamllint. I also added myself as maintainer, hope that's o.k.

Guido Günther (2):
dt-bindings: panel: rocktech,jh057n00900: Modernize
dt-bindings: panel: rocktech,jh057n00900: Add myself as maintainer

 .../display/panel/rocktech,jh057n00900.yaml   | 40 +++++++++----------
 1 file changed, 19 insertions(+), 21 deletions(-)
Signature · 6 lines
2.26.2

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
author maintainer
#1 lore raw

PATCH 1/2 dt-bindings: panel: rocktech,jh057n00900: Modernize

- Use common properties from panel-common.yaml
- Indent comment like content
- Don't preserve newlines in description
- Indent example by four spaces

---
 .../display/panel/rocktech,jh057n00900.yaml   | 39 +++++++++----------
 1 file changed, 18 insertions(+), 21 deletions(-)
Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml +18 -21
index d5733ef309549..c97e89707342e 100644
@@ -9,9 +9,9 @@ title: Rocktech JH057N00900 5.5" 720x1440 TFT LCD panel
 maintainers:
   - Ondrej Jirman <[email protected]>
 
-description: |
-             Rocktech JH057N00900 is a 720x1440 TFT LCD panel
-             connected using a MIPI-DSI video interface.
+description:
+  Rocktech JH057N00900 is a 720x1440 TFT LCD panel
+  connected using a MIPI-DSI video interface.
 
 allOf:
   - $ref: panel-common.yaml#
@@ -19,9 +19,9 @@ allOf:
 properties:
   compatible:
     enum:
-        # Rocktech JH057N00900 5.5" 720x1440 TFT LCD panel
+      # Rocktech JH057N00900 5.5" 720x1440 TFT LCD panel
       - rocktech,jh057n00900
-        # Xingbangda XBD599 5.99" 720x1440 TFT LCD panel
+      # Xingbangda XBD599 5.99" 720x1440 TFT LCD panel
       - xingbangda,xbd599
 
   port: true
@@ -35,13 +35,9 @@ properties:
   iovcc-supply:
     description: I/O voltage supply
 
-  reset-gpios:
-    description: GPIO used for the reset pin
-    maxItems: 1
+  reset-gpios: true
 
-  backlight:
-    description: Backlight used by the panel
-    $ref: "/schemas/types.yaml#/definitions/phandle"
+  backlight: true
 
 required:
   - compatible
@@ -57,15 +53,16 @@ examples:
     #include <dt-bindings/gpio/gpio.h>
 
     dsi {
-      #address-cells = <1>;
-      #size-cells = <0>;
-      panel@0 {
-        compatible = "rocktech,jh057n00900";
-        reg = <0>;
-        vcc-supply = <&reg_2v8_p>;
-        iovcc-supply = <&reg_1v8_p>;
-        reset-gpios = <&gpio3 13 GPIO_ACTIVE_LOW>;
-        backlight = <&backlight>;
-      };
+        #address-cells = <1>;
+        #size-cells = <0>;
+        panel@0 {
+            compatible = "rocktech,jh057n00900";
+            reg = <0>;
+            vcc-supply = <&reg_2v8_p>;
+            iovcc-supply = <&reg_1v8_p>;
+            reset-gpios = <&gpio3 13 GPIO_ACTIVE_LOW>;
+            backlight = <&backlight>;
+        };
     };
+
 ...
Signature · 6 lines
2.26.2

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
author maintainer
#2 lore raw

PATCH 2/2 dt-bindings: panel: rocktech,jh057n00900: Add myself as maintainer

In reply to Guido Günther

I maintained the txt based bindings before yaml conversion and care about the driver.

---
 .../devicetree/bindings/display/panel/rocktech,jh057n00900.yaml  | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml +1 -0
index c97e89707342e..09b5eb7542f8a 100644
@@ -8,6 +8,7 @@ title: Rocktech JH057N00900 5.5" 720x1440 TFT LCD panel
 
 maintainers:
   - Ondrej Jirman <[email protected]>
+  - Guido Gŭnther <[email protected]>
 
 description:
   Rocktech JH057N00900 is a 720x1440 TFT LCD panel
Signature · 6 lines
2.26.2

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#3 lore raw
In reply to Guido Günther

Hi Guido.

Quoted 7 lines · Guido Günther

This was prompted by Sam's review in
https://lore.kernel.org/dri-devel/[email protected]/
and yamllint. I also added myself as maintainer, hope that's o.k.

Guido Günther (2):
dt-bindings: panel: rocktech,jh057n00900: Modernize
dt-bindings: panel: rocktech,jh057n00900: Add myself as maintainer

Thanks for this nice clean-up, and always good with an extra person caring for something.
Applied to drm-misc-next

Sam

Quoted 6 lines
 .../display/panel/rocktech,jh057n00900.yaml   | 40 +++++++++----------
 1 file changed, 19 insertions(+), 21 deletions(-)
Signature · 1 line
2.26.2

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

author maintainer
#4 lore raw

Hi,

Quoted 7 lines · Sam Ravnborg

Hi Guido.

Quoted 4 lines · Guido Günther

This was prompted by Sam's review in
https://lore.kernel.org/dri-devel/[email protected]/
and yamllint. I also added myself as maintainer, hope that's o.k.

Quoted 7 lines
Quoted 3 lines

Guido Günther (2):
dt-bindings: panel: rocktech,jh057n00900: Modernize
dt-bindings: panel: rocktech,jh057n00900: Add myself as maintainer

Thanks for this nice clean-up, and always good with an extra person caring for something.
Applied to drm-misc-next

Thanks!
-- Guido

Quoted 10 lines

Sam

Quoted 6 lines
 .../display/panel/rocktech,jh057n00900.yaml   | 40 +++++++++----------
 1 file changed, 19 insertions(+), 21 deletions(-)
Signature · 1 line
2.26.2

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel