staging: android: Remove BUG/BUG_ON
v5 cover staging: android: Remove BUG/BUG_ON
Remove BUG/BUG_ON from androind/ion
-v5:
remove WARN_ON from ion_page_pool_free
-v4:
some changes based on Dan Carpenter review:
- Remove error check at ion_page_pool_remove (conditions are impossible)
- Remove error check at opn_page_pool_alloc
- restore WARN_ON at ion_page_pool_free
- Remove unnecessary error check at ion_page_pool_shrink
- Add /* This is impossible. */ comment at order_to_index
- Remove error handling of order_to_index
-v3:
remove WARN/WARN_ON as Gerg KH suggests
-v2:
add error check to order_to_index callers
Tomer Samara (2):
staging: android: Remove BUG_ON from ion_page_pool.c
staging: android: Remove BUG from ion_system_heap.c
drivers/staging/android/ion/ion_page_pool.c | 6 ------ drivers/staging/android/ion/ion_system_heap.c | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-)
Signature · 1 line
2.25.1
PATCH v5 1/2 staging: android: Remove BUG_ON from ion_page_pool.c
BUG_ON() is removed at ion_page_pool.c
Fixes the following issue:
Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan BUG() or BUG_ON().
--- drivers/staging/android/ion/ion_page_pool.c | 6 ------ 1 file changed, 6 deletions(-)
drivers/staging/android/ion/ion_page_pool.c +0 -6
@@ -46,11 +46,9 @@ static struct page *ion_page_pool_remove(struct ion_page_pool *pool, bool high)struct page *page;if (high) { -BUG_ON (!pool->high_count); page = list_first_entry(&pool->high_items, struct page, lru); pool->high_count--; }else { -BUG_ON (!pool->low_count); page = list_first_entry(&pool->low_items, struct page, lru); pool->low_count--; }
@@ -65,8 +63,6 @@ struct page *ion_page_pool_alloc(struct ion_page_pool *pool) {struct page *page =NULL ; -BUG_ON (!pool); -mutex_lock (&pool->mutex);if (pool->high_count) page =ion_page_pool_remove (pool, true);
@@ -82,8 +78,6 @@ struct page *ion_page_pool_alloc(struct ion_page_pool *pool)void ion_page_pool_free (struct ion_page_pool *pool,struct page *page) { -BUG_ON (pool->order !=compound_order (page)); -ion_page_pool_add (pool, page); }
Signature · 1 line
2.25.1
PATCH v5 2/2 staging: android: Remove BUG from ion_system_heap.c
In reply to Tomer SamaraRemove BUG() from ion_sytem_heap.c
this fix the following checkpatch issue:
Avoid crashing the kernel - try using WARN_ON &
recovery code ratherthan BUG() or BUG_ON().
--- drivers/staging/android/ion/ion_system_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/android/ion/ion_system_heap.c +1 -1
@@ -30,7 +30,7 @@ static int order_to_index(unsigned int order)for (i =0 ; i <NUM_ORDERS ; i++)if (order == orders[i])return i; -BUG (); +/* This is impossible. */ return -1 ; }
Signature · 1 line
2.25.1