Skip to contentSkip to conversation

Add initial support for RoseapplePi SBC

PATCH In review Cristian Ciocaltea 2 participants 11 messages Aug 28, 2020 – Sep 22, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v2 cover Add initial support for RoseapplePi SBC

This patchset enables basic support for RoseapplePi, relying exclusively on the existing infrastructure for the Actions Semi Owl SoCs (thanks to Andreas and Mani for making this possible).

The SBC is powered by the Actions Semi S500 SoC and comes with 2GB RAM, uSD slot and optional eMMC storage. For more details, please check:
http://roseapplepi.org/index.php/spec/

The upcoming patches will improve this initial support by adding the missing bits and pieces to the S500 clock management unit, which is a prerequisite for providing an S500 pinctrl and gpio driver, in order to eventually enable access to additional functionality like I2C and MMC.

Thanks and regards,
Cristian Ciocaltea

Changes in v2:
- Added Reviewed-by and Acked-by tags from Rob
- Added Reviewed-by tags from Peter
- Rebased series onto v5.9-rc2

Cristian Ciocaltea (4):
arm: dts: owl-s500: Fix incorrect PPI interrupt specifiers
dt-bindings: Add vendor prefix for RoseapplePi.org
dt-bindings: arm: actions: Document RoseapplePi
arm: dts: owl-s500: Add RoseapplePi

 .../devicetree/bindings/arm/actions.yaml      |  1 +
 .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
 arch/arm/boot/dts/Makefile                    |  1 +
 arch/arm/boot/dts/owl-s500-roseapplepi.dts    | 47 +++++++++++++++++++
 arch/arm/boot/dts/owl-s500.dtsi               |  6 +--
 5 files changed, 54 insertions(+), 3 deletions(-)
 create mode 100644 arch/arm/boot/dts/owl-s500-roseapplepi.dts
Signature · 1 line
2.28.0
#1 lore raw

PATCH v2 1/4 arm: dts: owl-s500: Fix incorrect PPI interrupt specifiers

The PPI interrupts for cortex-a9 were incorrectly specified, fix them.

Fixes fdfe7f4f9d85 ("ARM: dts: Add Actions Semi S500 and LeMaker Guitar")
---
 arch/arm/boot/dts/owl-s500.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/owl-s500.dtsi +3 -3
index 5ceb6cc4451d..1dbe4e8b38ac 100644
@@ -84,21 +84,21 @@ scu: scu@b0020000 {
 		global_timer: timer@b0020200 {
 			compatible = "arm,cortex-a9-global-timer";
 			reg = <0xb0020200 0x100>;
-			interrupts = <GIC_PPI 0 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_EDGE_RISING)>;
+			interrupts = <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_EDGE_RISING)>;
 			status = "disabled";
 		};
 
 		twd_timer: timer@b0020600 {
 			compatible = "arm,cortex-a9-twd-timer";
 			reg = <0xb0020600 0x20>;
-			interrupts = <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_EDGE_RISING)>;
+			interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_EDGE_RISING)>;
 			status = "disabled";
 		};
 
 		twd_wdt: wdt@b0020620 {
 			compatible = "arm,cortex-a9-twd-wdt";
 			reg = <0xb0020620 0xe0>;
-			interrupts = <GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_EDGE_RISING)>;
+			interrupts = <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_EDGE_RISING)>;
 			status = "disabled";
 		};
 
Signature · 1 line
2.28.0
Reviewed-by on v2 1/4
#2 lore raw

Re: [PATCH v2 1/4] arm: dts: owl-s500: Fix incorrect PPI interrupt specifiers

Quoted 5 lines · Cristian Ciocaltea

The PPI interrupts for cortex-a9 were incorrectly specified, fix them.

Fixes fdfe7f4f9d85 ("ARM: dts: Add Actions Semi S500 and LeMaker Guitar")

Thanks,
Mani

Quoted 36 lines
---
 arch/arm/boot/dts/owl-s500.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/owl-s500.dtsi +3 -3
index 5ceb6cc4451d..1dbe4e8b38ac 100644
@@ -84,21 +84,21 @@ scu: scu@b0020000 {
 		global_timer: timer@b0020200 {
 			compatible = "arm,cortex-a9-global-timer";
 			reg = <0xb0020200 0x100>;
-			interrupts = <GIC_PPI 0 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_EDGE_RISING)>;
+			interrupts = <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_EDGE_RISING)>;
 			status = "disabled";
 		};
 
 		twd_timer: timer@b0020600 {
 			compatible = "arm,cortex-a9-twd-timer";
 			reg = <0xb0020600 0x20>;
-			interrupts = <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_EDGE_RISING)>;
+			interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_EDGE_RISING)>;
 			status = "disabled";
 		};
 
 		twd_wdt: wdt@b0020620 {
 			compatible = "arm,cortex-a9-twd-wdt";
 			reg = <0xb0020620 0xe0>;
-			interrupts = <GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_EDGE_RISING)>;
+			interrupts = <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_EDGE_RISING)>;
 			status = "disabled";
 		};
 
Signature · 1 line
2.28.0
#3 lore raw

Re: [PATCH v2 1/4] arm: dts: owl-s500: Fix incorrect PPI interrupt specifiers

Quoted 8 lines · Manivannan Sadhasivam
Quoted 5 lines · Cristian Ciocaltea

The PPI interrupts for cortex-a9 were incorrectly specified, fix them.

Fixes fdfe7f4f9d85 ("ARM: dts: Add Actions Semi S500 and LeMaker Guitar")

Thanks,
Cristi

Quoted 39 lines

Thanks,
Mani

Quoted 36 lines
---
 arch/arm/boot/dts/owl-s500.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/owl-s500.dtsi +3 -3
index 5ceb6cc4451d..1dbe4e8b38ac 100644
@@ -84,21 +84,21 @@ scu: scu@b0020000 {
 		global_timer: timer@b0020200 {
 			compatible = "arm,cortex-a9-global-timer";
 			reg = <0xb0020200 0x100>;
-			interrupts = <GIC_PPI 0 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_EDGE_RISING)>;
+			interrupts = <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_EDGE_RISING)>;
 			status = "disabled";
 		};
 
 		twd_timer: timer@b0020600 {
 			compatible = "arm,cortex-a9-twd-timer";
 			reg = <0xb0020600 0x20>;
-			interrupts = <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_EDGE_RISING)>;
+			interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_EDGE_RISING)>;
 			status = "disabled";
 		};
 
 		twd_wdt: wdt@b0020620 {
 			compatible = "arm,cortex-a9-twd-wdt";
 			reg = <0xb0020620 0xe0>;
-			interrupts = <GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_EDGE_RISING)>;
+			interrupts = <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_EDGE_RISING)>;
 			status = "disabled";
 		};
 
Signature · 1 line
2.28.0
#4 lore raw

PATCH v2 2/4 dt-bindings: Add vendor prefix for RoseapplePi.org

In reply to Cristian Ciocaltea

Add devicetree vendor prefix for RoseapplePi.org Foundation.
Website: http://roseapplepi.org/

---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
index 63996ab03521..0b5bd97b4211 100644
@@ -894,6 +894,8 @@ patternProperties:
     description: Ronbo Electronics
   "^roofull,.*":
     description: Shenzhen Roofull Technology Co, Ltd
+  "^roseapplepi,.*":
+    description: RoseapplePi.org
   "^samsung,.*":
     description: Samsung Semiconductor
   "^samtec,.*":
Signature · 1 line
2.28.0
#5 lore raw

Re: [PATCH v2 2/4] dt-bindings: Add vendor prefix for RoseapplePi.org

Quoted 5 lines · Cristian Ciocaltea

Add devicetree vendor prefix for RoseapplePi.org Foundation.
Website: http://roseapplepi.org/

Rob, are you going to take this patch? Else I'll take this through arm-soc tree!

Thanks,
Mani

Quoted 20 lines
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
index 63996ab03521..0b5bd97b4211 100644
@@ -894,6 +894,8 @@ patternProperties:
     description: Ronbo Electronics
   "^roofull,.*":
     description: Shenzhen Roofull Technology Co, Ltd
+  "^roseapplepi,.*":
+    description: RoseapplePi.org
   "^samsung,.*":
     description: Samsung Semiconductor
   "^samtec,.*":
Signature · 1 line
2.28.0
#6 lore raw

Re: [PATCH v2 2/4] dt-bindings: Add vendor prefix for RoseapplePi.org

In reply to Cristian Ciocaltea
Quoted 5 lines · Cristian Ciocaltea

Add devicetree vendor prefix for RoseapplePi.org Foundation.
Website: http://roseapplepi.org/

Applied for v5.10!

Thanks,
Mani

Quoted 20 lines
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
index 63996ab03521..0b5bd97b4211 100644
@@ -894,6 +894,8 @@ patternProperties:
     description: Ronbo Electronics
   "^roofull,.*":
     description: Shenzhen Roofull Technology Co, Ltd
+  "^roseapplepi,.*":
+    description: RoseapplePi.org
   "^samsung,.*":
     description: Samsung Semiconductor
   "^samtec,.*":
Signature · 1 line
2.28.0
#7 lore raw

PATCH v2 3/4 dt-bindings: arm: actions: Document RoseapplePi

In reply to Cristian Ciocaltea

Define compatible strings for RoseapplePi, a SBC manufactured in Taiwan, based on Actions Semi S500 reference design.

---
 Documentation/devicetree/bindings/arm/actions.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/actions.yaml +1 -0
index ace3fdaa8396..787cd1b4f26c 100644
@@ -18,6 +18,7 @@ properties:
           - enum:
               - allo,sparky # Allo.com Sparky
               - cubietech,cubieboard6 # Cubietech CubieBoard6
+              - roseapplepi,roseapplepi # RoseapplePi.org RoseapplePi
           - const: actions,s500
       - items:
           - enum:
Signature · 1 line
2.28.0
#8 lore raw

PATCH v2 4/4 arm: dts: owl-s500: Add RoseapplePi

In reply to Cristian Ciocaltea

Add a Device Tree for the RoseapplePi SBC.

---
 arch/arm/boot/dts/Makefile                 |  1 +
 arch/arm/boot/dts/owl-s500-roseapplepi.dts | 47 ++++++++++++++++++++++
 2 files changed, 48 insertions(+)
 create mode 100644 arch/arm/boot/dts/owl-s500-roseapplepi.dts
arch/arm/boot/dts/Makefile +1 -0
index 4572db3fa5ae..bff9ef996fbb 100644
@@ -868,6 +868,7 @@ dtb-$(CONFIG_ARCH_ORION5X) += \
 dtb-$(CONFIG_ARCH_ACTIONS) += \
 	owl-s500-cubieboard6.dtb \
 	owl-s500-guitar-bb-rev-b.dtb \
+	owl-s500-roseapplepi.dtb \
 	owl-s500-sparky.dtb
 dtb-$(CONFIG_ARCH_PRIMA2) += \
 	prima2-evb.dtb
arch/arm/boot/dts/owl-s500-roseapplepi.dts new file +47 -0

47 lines not on this page · raw message

Signature · 1 line
2.28.0
Reviewed-by on v2 4/4
#9 lore raw

Re: [PATCH v2 4/4] arm: dts: owl-s500: Add RoseapplePi

Quoted 4 lines · Cristian Ciocaltea

Add a Device Tree for the RoseapplePi SBC.

Thanks,
Mani

Quoted 74 lines
---
 arch/arm/boot/dts/Makefile                 |  1 +
 arch/arm/boot/dts/owl-s500-roseapplepi.dts | 47 ++++++++++++++++++++++
 2 files changed, 48 insertions(+)
 create mode 100644 arch/arm/boot/dts/owl-s500-roseapplepi.dts
arch/arm/boot/dts/Makefile +1 -0
index 4572db3fa5ae..bff9ef996fbb 100644
@@ -868,6 +868,7 @@ dtb-$(CONFIG_ARCH_ORION5X) += \
 dtb-$(CONFIG_ARCH_ACTIONS) += \
 	owl-s500-cubieboard6.dtb \
 	owl-s500-guitar-bb-rev-b.dtb \
+	owl-s500-roseapplepi.dtb \
 	owl-s500-sparky.dtb
 dtb-$(CONFIG_ARCH_PRIMA2) += \
 	prima2-evb.dtb
arch/arm/boot/dts/owl-s500-roseapplepi.dts new file +47 -0
new file mode 100644
index 000000000000..a2087e617cb2
@@ -0,0 +1,47 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Roseapple Pi
+ *
+ * Copyright (C) 2020 Cristian Ciocaltea <[email protected]>
+ */
+
+/dts-v1/;
+
+#include "owl-s500.dtsi"
+
+/ {
+	compatible = "roseapplepi,roseapplepi", "actions,s500";
+	model = "Roseapple Pi";
+
+	aliases {
+		serial2 = &uart2;
+	};
+
+	chosen {
+		stdout-path = "serial2:115200n8";
+	};
+
+	memory@0 {
+		device_type = "memory";
+		reg = <0x0 0x80000000>; /* 2GB */
+	};
+
+	uart2_clk: uart2-clk {
+		compatible = "fixed-clock";
+		clock-frequency = <921600>;
+		#clock-cells = <0>;
+	};
+};
+
+&twd_timer {
+	status = "okay";
+};
+
+&timer {
+	clocks = <&hosc>;
+};
+
+&uart2 {
+	status = "okay";
+	clocks = <&uart2_clk>;
+};
Signature · 1 line
2.28.0
#10 lore raw

Re: [PATCH v2 4/4] arm: dts: owl-s500: Add RoseapplePi

Quoted 7 lines · Manivannan Sadhasivam
Quoted 4 lines · Cristian Ciocaltea

Add a Device Tree for the RoseapplePi SBC.

Thanks,
Cristi

Quoted 77 lines

Thanks,
Mani

Quoted 74 lines
---
 arch/arm/boot/dts/Makefile                 |  1 +
 arch/arm/boot/dts/owl-s500-roseapplepi.dts | 47 ++++++++++++++++++++++
 2 files changed, 48 insertions(+)
 create mode 100644 arch/arm/boot/dts/owl-s500-roseapplepi.dts
arch/arm/boot/dts/Makefile +1 -0
index 4572db3fa5ae..bff9ef996fbb 100644
@@ -868,6 +868,7 @@ dtb-$(CONFIG_ARCH_ORION5X) += \
 dtb-$(CONFIG_ARCH_ACTIONS) += \
 	owl-s500-cubieboard6.dtb \
 	owl-s500-guitar-bb-rev-b.dtb \
+	owl-s500-roseapplepi.dtb \
 	owl-s500-sparky.dtb
 dtb-$(CONFIG_ARCH_PRIMA2) += \
 	prima2-evb.dtb
arch/arm/boot/dts/owl-s500-roseapplepi.dts new file +47 -0
new file mode 100644
index 000000000000..a2087e617cb2
@@ -0,0 +1,47 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Roseapple Pi
+ *
+ * Copyright (C) 2020 Cristian Ciocaltea <[email protected]>
+ */
+
+/dts-v1/;
+
+#include "owl-s500.dtsi"
+
+/ {
+	compatible = "roseapplepi,roseapplepi", "actions,s500";
+	model = "Roseapple Pi";
+
+	aliases {
+		serial2 = &uart2;
+	};
+
+	chosen {
+		stdout-path = "serial2:115200n8";
+	};
+
+	memory@0 {
+		device_type = "memory";
+		reg = <0x0 0x80000000>; /* 2GB */
+	};
+
+	uart2_clk: uart2-clk {
+		compatible = "fixed-clock";
+		clock-frequency = <921600>;
+		#clock-cells = <0>;
+	};
+};
+
+&twd_timer {
+	status = "okay";
+};
+
+&timer {
+	clocks = <&hosc>;
+};
+
+&uart2 {
+	status = "okay";
+	clocks = <&uart2_clk>;
+};
Signature · 1 line
2.28.0