add Cellient MPL200 card
Subsystems (6)
v2 cover add Cellient MPL200 card
Add the Cellient MPL200 card to usb/qmi_wwan and serial/option. The serial/option patch got already applied.
Changes v2:
Picked proper subject for qmi_wwan patch, moved the MPL200 device to the section of the combined devices and changed the comment about the device to be more precise.
Wilken Gottwalt (2):
net: usb: qmi_wwan: add Cellient MPL200 card
usb: serial: option: add Cellient MPL200 card
drivers/net/usb/qmi_wwan.c | 1 + drivers/usb/serial/option.c | 3 +++ 2 files changed, 4 insertions(+)
Signature · 1 line
2.28.0
PATCH v2 1/2 net: usb: qmi_wwan: add Cellient MPL200 card
Add usb ids of the Cellient MPL200 card.
--- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/usb/qmi_wwan.c +1 -0
@@ -1375,6 +1375,7 @@ static const struct usb_device_id products[] = { {QMI_QUIRK_SET_DTR(0x2cb7, 0x0104, 4)}, /* Fibocom NL678 series */ {QMI_FIXED_INTF(0x0489, 0xe0b4, 0)}, /* Foxconn T77W968 LTE */ {QMI_FIXED_INTF(0x0489, 0xe0b5, 0)}, /* Foxconn T77W968 LTE with eSIM support*/ + {QMI_FIXED_INTF(0x2692, 0x9025, 4)}, /* Cellient MPL200 (rebranded Qualcomm 05c6:9025) *//* 4. Gobi 1000 devices */ {QMI_GOBI1K_DEVICE(0x05c6, 0x9212)}, /* Acer Gobi Modem Device */
Signature · 1 line
2.28.0
Re: [PATCH v2 1/2] net: usb: qmi_wwan: add Cellient MPL200 card
Quoted 12 lines · Wilken Gottwalt
Add usb ids of the Cellient MPL200 card.
Signed-off-by Wilken Gottwalt <[email protected]>--- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+)drivers/net/usb/qmi_wwan.c +0
-0
drivers/net/usb/qmi_wwan.c static const struct usb_device_id products[] = { · line 1381
Quoted 7 lines
drivers/net/usb/qmi_wwan.c +1
-0@@ -1375,6 +1375,7 @@ static const struct usb_device_id products[] = { {QMI_QUIRK_SET_DTR(0x2cb7, 0x0104, 4)}, /* Fibocom NL678 series */ {QMI_FIXED_INTF(0x0489, 0xe0b4, 0)}, /* Foxconn T77W968 LTE */ {QMI_FIXED_INTF(0x0489, 0xe0b5, 0)}, /* Foxconn T77W968 LTE with eSIM support*/ + {QMI_FIXED_INTF(0x2692, 0x9025, 4)}, /* Cellient MPL200 (rebranded Qualcomm 05c6:9025) *//* 4. Gobi 1000 devices */ {QMI_GOBI1K_DEVICE(0x05c6, 0x9212)}, /* Acer Gobi Modem Device */
Thanks. Looks nice now.
Jakub Kicinski
maintainerRe: [PATCH v2 1/2] net: usb: qmi_wwan: add Cellient MPL200 card
Quoted 18 lines · On Thu, 08 Oct 2020 10:07:20 +0200 Bjørn Mork wrote:
Quoted 17 lines · Wilken Gottwalt
Add usb ids of the Cellient MPL200 card.
Signed-off-by Wilken Gottwalt <[email protected]>--- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+)drivers/net/usb/qmi_wwan.c +1
-0@@ -1375,6 +1375,7 @@ static const struct usb_device_id products[] = { {QMI_QUIRK_SET_DTR(0x2cb7, 0x0104, 4)}, /* Fibocom NL678 series */ {QMI_FIXED_INTF(0x0489, 0xe0b4, 0)}, /* Foxconn T77W968 LTE */ {QMI_FIXED_INTF(0x0489, 0xe0b5, 0)}, /* Foxconn T77W968 LTE with eSIM support*/ + {QMI_FIXED_INTF(0x2692, 0x9025, 4)}, /* Cellient MPL200 (rebranded Qualcomm 05c6:9025) */
Quoted 6 lines
drivers/net/usb/qmi_wwan.c static const struct usb_device_id products[] = { · line 1381
Quoted 2 lines
drivers/net/usb/qmi_wwan.c +0
-0/* 4. Gobi 1000 devices */ {QMI_GOBI1K_DEVICE(0x05c6, 0x9212)}, /* Acer Gobi Modem Device */Thanks. Looks nice now.
Acked-by Bjørn Mork <[email protected]>
I'm guessing that I'm supposed to take this patch into the networking tree, correct?
Is this net or net-next candidate? Bjørn?
Bjørn Mork
maintainerRe: [PATCH v2 1/2] net: usb: qmi_wwan: add Cellient MPL200 card
Quoted 2 lines · Jakub Kicinski
I'm guessing that I'm supposed to take this patch into the networking tree, correct?
Correct.
Quoted 1 line
Is this net or net-next candidate? Bjørn?
Sorry, should have made that explicit. This is for net + stable
Thanks.
Bjørn
Jakub Kicinski
maintainerRe: [PATCH v2 1/2] net: usb: qmi_wwan: add Cellient MPL200 card
Quoted 10 lines · On Thu, 08 Oct 2020 19:10:57 +0200 Bjørn Mork wrote:
Quoted 2 lines · Jakub Kicinski
I'm guessing that I'm supposed to take this patch into the networking tree, correct?
Correct.
Quoted 1 line
Is this net or net-next candidate? Bjørn?
Sorry, should have made that explicit. This is for net + stable
Done, thank you!
PATCH v2 2/2 usb: serial: option: add Cellient MPL200 card
In reply to Wilken GottwaltAdd usb ids of the Cellient MPL200 card.
--- drivers/usb/serial/option.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/usb/serial/option.c +3 -0
@@ -528,6 +528,7 @@ static void option_instat_callback(struct urb *urb);/* Cellient products */ #define CELLIENT_VENDOR_ID 0x2692#define CELLIENT_PRODUCT_MEN200 0x9005 +#define CELLIENT_PRODUCT_MPL200 0x9025/* Hyundai Petatel Inc. products */ #define PETATEL_VENDOR_ID 0x1ff4
@@ -1982,6 +1983,8 @@ static const struct usb_device_id option_ids[] = { { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, MEDIATEK_PRODUCT_DC_4COM2, 0xff, 0x02, 0x01) }, { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, MEDIATEK_PRODUCT_DC_4COM2, 0xff, 0x00, 0x00) }, { USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MEN200) }, + { USB_DEVICE(CELLIENT_VENDOR_ID, CELLIENT_PRODUCT_MPL200), + .driver_info = RSVD(1) | RSVD(4) }, { USB_DEVICE(PETATEL_VENDOR_ID, PETATEL_PRODUCT_NP10T_600A) }, { USB_DEVICE(PETATEL_VENDOR_ID, PETATEL_PRODUCT_NP10T_600E) }, { USB_DEVICE_AND_INTERFACE_INFO(TPLINK_VENDOR_ID, TPLINK_PRODUCT_LTE, 0xff, 0x00, 0x00) }, /* TP-Link LTE Module */
Signature · 1 line
2.28.0
Johan Hovold
maintainerRe: [PATCH v2 2/2] usb: serial: option: add Cellient MPL200 card
Quoted 4 lines · Wilken Gottwalt
Add usb ids of the Cellient MPL200 card.
Signed-off-by Wilken Gottwalt <[email protected]>---
So I had already applied this one (which didn't change since v1).
Thanks again.
Johan