Skip to contentSkip to conversation

drm/i915/gvt: make headers self-contained

PATCH In review Jani Nikula 3 participants 12 messages Dec 8, 2020 – Dec 9, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover drm/i915/gvt: make headers self-contained

For a long time now we've had a build option in i915 to ensure the headers in the driver are self-contained, i.e. they include and forward declare everything they need. Finally fix the gvt headers that aren't, and remove them from the exclude list.

Please use the CONFIG_DRM_I915_WERROR=y config option to ensure the driver remains warning free and headers stay self-contained.

Please merge this via the gvt tree.

BR,
Jani.

Jani Nikula (8):
drm/i915/gvt: make execlist.h self-contained drm/i915/gvt: make fb_decoder.h self-contained drm/i915/gvt: make gtt.h self-contained drm/i915/gvt: make interrupt.h self-contained drm/i915/gvt: make mmio_context.h self-contained drm/i915/gvt: make gvt.h self-contained drm/i915/gvt: make scheduler.h self-contained drm/i915/gvt: make mpt.h self-contained

 drivers/gpu/drm/i915/Makefile           | 10 +---------
 drivers/gpu/drm/i915/gvt/execlist.h     |  3 ---
 drivers/gpu/drm/i915/gvt/fb_decoder.h   |  6 ++++--
 drivers/gpu/drm/i915/gvt/gtt.h          | 11 ++++++++++-
 drivers/gpu/drm/i915/gvt/gvt.h          |  4 ++++
 drivers/gpu/drm/i915/gvt/interrupt.h    |  5 ++++-
 drivers/gpu/drm/i915/gvt/mmio_context.h | 11 +++++++++++
 drivers/gpu/drm/i915/gvt/mpt.h          |  2 ++
 drivers/gpu/drm/i915/gvt/scheduler.h    |  5 +++++
 9 files changed, 41 insertions(+), 16 deletions(-)
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH 1/8 drm/i915/gvt: make execlist.h self-contained

Remove unused declaration.

---
 drivers/gpu/drm/i915/Makefile       | 1 -
 drivers/gpu/drm/i915/gvt/execlist.h | 3 ---
 2 files changed, 4 deletions(-)
drivers/gpu/drm/i915/Makefile +0 -1
index e5574e506a5c..40253c45f705 100644
@@ -284,7 +284,6 @@ obj-$(CONFIG_DRM_I915_GVT_KVMGT) += gvt/kvmgt.o
 # exclude some broken headers from the test coverage
 no-header-test := \
 	display/intel_vbt_defs.h \
-	gvt/execlist.h \
 	gvt/fb_decoder.h \
 	gvt/gtt.h \
 	gvt/gvt.h \
drivers/gpu/drm/i915/gvt/execlist.h +0 -3
index d62cd14605a3..84ad74b37d66 100644
@@ -182,7 +182,4 @@ int intel_vgpu_init_execlist(struct intel_vgpu *vgpu);
 int intel_vgpu_submit_execlist(struct intel_vgpu *vgpu,
 			       const struct intel_engine_cs *engine);
 
-void intel_vgpu_reset_execlist(struct intel_vgpu *vgpu,
-			       intel_engine_mask_t engine_mask);
-
 #endif /*_GVT_EXECLIST_H_*/
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

PATCH 2/8 drm/i915/gvt: make fb_decoder.h self-contained

In reply to Jani Nikula

Add necessary #includes and forward declarations to make the header compile on its own.

While at it, also remove a useless forward declaration.

---
 drivers/gpu/drm/i915/Makefile         | 1 -
 drivers/gpu/drm/i915/gvt/fb_decoder.h | 6 ++++--
 2 files changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/Makefile +0 -1
index 40253c45f705..c22fff634d18 100644
@@ -284,7 +284,6 @@ obj-$(CONFIG_DRM_I915_GVT_KVMGT) += gvt/kvmgt.o
 # exclude some broken headers from the test coverage
 no-header-test := \
 	display/intel_vbt_defs.h \
-	gvt/fb_decoder.h \
 	gvt/gtt.h \
 	gvt/gvt.h \
 	gvt/interrupt.h \
drivers/gpu/drm/i915/gvt/fb_decoder.h +4 -2
index 67b6ede9e707..0daa3931aef7 100644
@@ -38,6 +38,10 @@
 
 #include <linux/types.h>
 
+#include "display/intel_display.h"
+
+struct intel_vgpu;
+
 #define _PLANE_CTL_FORMAT_SHIFT		24
 #define _PLANE_CTL_TILED_SHIFT		10
 #define _PIPE_V_SRCSZ_SHIFT		0
@@ -98,8 +102,6 @@ enum DDI_PORT {
 	DDI_PORT_E	= 4
 };
 
-struct intel_gvt;
-
 /* color space conversion and gamma correction are not included */
 struct intel_vgpu_primary_plane_format {
 	u8	enabled;	/* plane is enabled */
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw

PATCH 3/8 drm/i915/gvt: make gtt.h self-contained

In reply to Jani Nikula

Add necessary #includes and forward declarations to make the header compile on its own.

---
 drivers/gpu/drm/i915/Makefile  |  1 -
 drivers/gpu/drm/i915/gvt/gtt.h | 11 ++++++++++-
 2 files changed, 10 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/Makefile +0 -1
index c22fff634d18..33fdcd81e352 100644
@@ -284,7 +284,6 @@ obj-$(CONFIG_DRM_I915_GVT_KVMGT) += gvt/kvmgt.o
 # exclude some broken headers from the test coverage
 no-header-test := \
 	display/intel_vbt_defs.h \
-	gvt/gtt.h \
 	gvt/gvt.h \
 	gvt/interrupt.h \
 	gvt/mmio_context.h \
drivers/gpu/drm/i915/gvt/gtt.h +10 -1
index b0e173f2d990..3bf45672ef98 100644
@@ -34,10 +34,19 @@
 #ifndef _GVT_GTT_H_
 #define _GVT_GTT_H_
 
-#define I915_GTT_PAGE_SHIFT         12
+#include <linux/kernel.h>
+#include <linux/kref.h>
+#include <linux/mutex.h>
+#include <linux/radix-tree.h>
+
+#include "gt/intel_gtt.h"
 
+struct intel_gvt;
+struct intel_vgpu;
 struct intel_vgpu_mm;
 
+#define I915_GTT_PAGE_SHIFT         12
+
 #define INTEL_GVT_INVALID_ADDR (~0UL)
 
 struct intel_gvt_gtt_entry {
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw

PATCH 4/8 drm/i915/gvt: make interrupt.h self-contained

In reply to Jani Nikula

Add necessary #includes and forward declarations to make the header compile on its own.

---
 drivers/gpu/drm/i915/Makefile        | 1 -
 drivers/gpu/drm/i915/gvt/interrupt.h | 5 ++++-
 2 files changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/Makefile +0 -1
index 33fdcd81e352..082c0629f290 100644
@@ -285,7 +285,6 @@ obj-$(CONFIG_DRM_I915_GVT_KVMGT) += gvt/kvmgt.o
 no-header-test := \
 	display/intel_vbt_defs.h \
 	gvt/gvt.h \
-	gvt/interrupt.h \
 	gvt/mmio_context.h \
 	gvt/mpt.h \
 	gvt/scheduler.h
drivers/gpu/drm/i915/gvt/interrupt.h +4 -1
index fcd663811d37..287cd142629e 100644
@@ -32,7 +32,10 @@
 #ifndef _GVT_INTERRUPT_H_
 #define _GVT_INTERRUPT_H_
 
-#include <linux/types.h>
+#include <linux/hrtimer.h>
+#include <linux/kernel.h>
+
+#include "i915_reg.h"
 
 enum intel_gvt_event_type {
 	RCS_MI_USER_INTERRUPT = 0,
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#5 lore raw

PATCH 5/8 drm/i915/gvt: make mmio_context.h self-contained

In reply to Jani Nikula

Add necessary #includes and forward declarations to make the header compile on its own.

---
 drivers/gpu/drm/i915/Makefile           |  1 -
 drivers/gpu/drm/i915/gvt/mmio_context.h | 11 +++++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/Makefile +0 -1
index 082c0629f290..f91b5fd13eff 100644
@@ -285,7 +285,6 @@ obj-$(CONFIG_DRM_I915_GVT_KVMGT) += gvt/kvmgt.o
 no-header-test := \
 	display/intel_vbt_defs.h \
 	gvt/gvt.h \
-	gvt/mmio_context.h \
 	gvt/mpt.h \
 	gvt/scheduler.h
 
drivers/gpu/drm/i915/gvt/mmio_context.h +11 -0
index 3b25e7fe32f6..1421d3a70412 100644
@@ -36,6 +36,17 @@
 #ifndef __GVT_RENDER_H__
 #define __GVT_RENDER_H__
 
+#include <linux/types.h>
+
+#include "gt/intel_engine_types.h"
+#include "i915_reg.h"
+
+struct i915_request;
+struct intel_context;
+struct intel_engine_cs;
+struct intel_gvt;
+struct intel_vgpu;
+
 struct engine_mmio {
 	enum intel_engine_id id;
 	i915_reg_t reg;
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#6 lore raw

PATCH 6/8 drm/i915/gvt: make gvt.h self-contained

In reply to Jani Nikula

Add necessary #includes and forward declarations to make the header compile on its own.

---
 drivers/gpu/drm/i915/Makefile  | 1 -
 drivers/gpu/drm/i915/gvt/gvt.h | 4 ++++
 2 files changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/Makefile +0 -1
index f91b5fd13eff..b0045a3faf0e 100644
@@ -284,7 +284,6 @@ obj-$(CONFIG_DRM_I915_GVT_KVMGT) += gvt/kvmgt.o
 # exclude some broken headers from the test coverage
 no-header-test := \
 	display/intel_vbt_defs.h \
-	gvt/gvt.h \
 	gvt/mpt.h \
 	gvt/scheduler.h
 
drivers/gpu/drm/i915/gvt/gvt.h +4 -0
index cf3578e3f4dd..62a4807424bb 100644
@@ -33,6 +33,10 @@
 #ifndef _GVT_H_
 #define _GVT_H_
 
+#include <uapi/linux/pci_regs.h>
+
+#include "i915_drv.h"
+
 #include "debug.h"
 #include "hypercall.h"
 #include "mmio.h"
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#7 lore raw

PATCH 7/8 drm/i915/gvt: make scheduler.h self-contained

In reply to Jani Nikula

Add necessary #includes and forward declarations to make the header compile on its own.

---
 drivers/gpu/drm/i915/Makefile        | 3 +--
 drivers/gpu/drm/i915/gvt/scheduler.h | 5 +++++
 2 files changed, 6 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/Makefile +1 -2
index b0045a3faf0e..38c6d8257b0b 100644
@@ -284,8 +284,7 @@ obj-$(CONFIG_DRM_I915_GVT_KVMGT) += gvt/kvmgt.o
 # exclude some broken headers from the test coverage
 no-header-test := \
 	display/intel_vbt_defs.h \
-	gvt/mpt.h \
-	gvt/scheduler.h
+	gvt/mpt.h
 
 extra-$(CONFIG_DRM_I915_WERROR) += \
 	$(patsubst %.h,%.hdrtest, $(filter-out $(no-header-test), \
drivers/gpu/drm/i915/gvt/scheduler.h +5 -0
index 64e7a0b791c3..7c86984a842f 100644
@@ -36,6 +36,11 @@
 #ifndef _GVT_SCHEDULER_H_
 #define _GVT_SCHEDULER_H_
 
+#include "gt/intel_engine_types.h"
+
+#include "execlist.h"
+#include "interrupt.h"
+
 struct intel_gvt_workload_scheduler {
 	struct intel_vgpu *current_vgpu;
 	struct intel_vgpu *next_vgpu;
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#8 lore raw

PATCH 8/8 drm/i915/gvt: make mpt.h self-contained

In reply to Jani Nikula

Add necessary #includes and forward declarations to make the header
compile on its own.

---
 drivers/gpu/drm/i915/Makefile  | 3 +--
 drivers/gpu/drm/i915/gvt/mpt.h | 2 ++
 2 files changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/Makefile +1 -2
index 38c6d8257b0b..220c275aba84 100644
@@ -283,8 +283,7 @@ obj-$(CONFIG_DRM_I915_GVT_KVMGT) += gvt/kvmgt.o
 
 # exclude some broken headers from the test coverage
 no-header-test := \
-	display/intel_vbt_defs.h \
-	gvt/mpt.h
+	display/intel_vbt_defs.h
 
 extra-$(CONFIG_DRM_I915_WERROR) += \
 	$(patsubst %.h,%.hdrtest, $(filter-out $(no-header-test), \
drivers/gpu/drm/i915/gvt/mpt.h +2 -0
index 6f92cde71971..550a456e936f 100644
@@ -33,6 +33,8 @@
 #ifndef _GVT_MPT_H_
 #define _GVT_MPT_H_
 
+#include "gvt.h"
+
 /**
  * DOC: Hypervisor Service APIs for GVT-g Core Logic
  *
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#9 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: make headers self-contained

In reply to Jani Nikula
== Series Details ==

== Series Details ==

Series: drm/i915/gvt: make headers self-contained
URL : https://patchwork.freedesktop.org/series/84678/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9458 -> Patchwork_19079
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/index.html

New tests
---------

New tests have been introduced between CI_DRM_9458 and Patchwork_19079:

### New CI tests (1) ###

* boot:
- Statuses : 1 fail(s) 39 pass(s)
- Exec time: [0.0] s

Known issues
------------

Here are the changes found in Patchwork_19079 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@prime_vgem@basic-read:
- fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([i915#402]) +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/fi-tgl-y/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/fi-tgl-y/igt@[email protected]

#### Possible fixes ####

* igt@fbdev@read:
- fi-tgl-y: [DMESG-WARN][3] ([i915#402]) -> [PASS][4] +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/fi-tgl-y/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/fi-tgl-y/igt@[email protected]

[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402

Participating hosts (43 -> 40)
------------------------------

Missing (3): fi-ilk-m540 fi-bdw-samus fi-hsw-4200u

Build changes
-------------

* Linux: CI_DRM_9458 -> Patchwork_19079

CI-20190529: 20190529
CI_DRM_9458: 7eeed064e42528645b01910bfd6249096ac0cf73 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5884: b1015a3267bbccb985b2fa7e3accb778c7bff0ed @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19079: fc9fd6a12b0a5ea2773969c55bf65514d4a86258 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

fc9fd6a12b0a drm/i915/gvt: make mpt.h self-contained aea7461b2bc1 drm/i915/gvt: make scheduler.h self-contained b9e5378b4040 drm/i915/gvt: make gvt.h self-contained 22185b38ebcc drm/i915/gvt: make mmio_context.h self-contained 95eba910fc82 drm/i915/gvt: make interrupt.h self-contained aaf3d9f6941e drm/i915/gvt: make gtt.h self-contained 0430340c747d drm/i915/gvt: make fb_decoder.h self-contained 835535436710 drm/i915/gvt: make execlist.h self-contained

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#10 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gvt: make headers self-contained

In reply to Jani Nikula
== Series Details ==

== Series Details ==

Series: drm/i915/gvt: make headers self-contained
URL : https://patchwork.freedesktop.org/series/84678/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9458_full -> Patchwork_19079_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

New tests
---------

New tests have been introduced between CI_DRM_9458_full and Patchwork_19079_full:

### New CI tests (1) ###

* boot:
- Statuses : 200 pass(s)
- Exec time: [0.0] s

Known issues
------------

Here are the changes found in Patchwork_19079_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_persistence@hostile:
- shard-hsw: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#1099])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-hsw1/igt@[email protected]

* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-tglb: NOTRUN -> [FAIL][2] ([i915#2389]) +4 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-tglb8/igt@gem_exec_reloc@[email protected]

* igt@gem_exec_whisper@basic-contexts:
- shard-glk: [PASS][3] -> [DMESG-WARN][4] ([i915#118] / [i915#95]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-glk2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-glk8/igt@[email protected]

* igt@gem_userptr_blits@process-exit-mmap-busy@uc:
- shard-skl: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#1699]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-skl6/igt@gem_userptr_blits@[email protected]

* igt@gen3_render_mixed_blits:
- shard-tglb: NOTRUN -> [SKIP][6] ([fdo#109289]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-tglb8/igt@gen3_render_mixed_blits.html

* igt@gen9_exec_parse@allowed-all:
- shard-apl: [PASS][7] -> [DMESG-WARN][8] ([i915#1436] / [i915#716])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-apl4/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-apl1/igt@[email protected]

* igt@gen9_exec_parse@basic-rejected:
- shard-tglb: NOTRUN -> [SKIP][9] ([fdo#112306])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-tglb8/igt@[email protected]

* igt@i915_suspend@sysfs-reader:
- shard-skl: [PASS][10] -> [INCOMPLETE][11] ([i915#198])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-skl10/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-skl4/igt@[email protected]

* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: NOTRUN -> [FAIL][12] ([i915#2521])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-skl6/igt@[email protected]

* igt@kms_big_fb@yf-tiled-8bpp-rotate-180:
- shard-tglb: NOTRUN -> [SKIP][13] ([fdo#111615]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-tglb8/igt@[email protected]

* igt@kms_ccs@pipe-c-bad-pixel-format:
- shard-skl: NOTRUN -> [SKIP][14] ([fdo#109271] / [fdo#111304])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-skl2/igt@[email protected]

* igt@kms_chamelium@hdmi-aspect-ratio:
- shard-skl: NOTRUN -> [SKIP][15] ([fdo#109271] / [fdo#111827]) +6 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-skl2/igt@[email protected]

* igt@kms_color_chamelium@pipe-c-ctm-blue-to-red:
- shard-kbl: NOTRUN -> [SKIP][16] ([fdo#109271] / [fdo#111827])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-kbl6/igt@[email protected]

* igt@kms_color_chamelium@pipe-d-ctm-0-75:
- shard-tglb: NOTRUN -> [SKIP][17] ([fdo#109284] / [fdo#111827])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-tglb8/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-512x170-random:
- shard-tglb: NOTRUN -> [SKIP][18] ([fdo#109279])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-tglb8/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-64x21-random:
- shard-skl: NOTRUN -> [FAIL][19] ([i915#54])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-skl2/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-128x42-random:
- shard-skl: [PASS][20] -> [FAIL][21] ([i915#54])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-skl9/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-skl3/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-skl: [PASS][22] -> [INCOMPLETE][23] ([i915#2405] / [i915#300])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-skl1/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-skl6/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-512x512-random:
- shard-skl: NOTRUN -> [SKIP][24] ([fdo#109271]) +54 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-skl2/igt@[email protected]

* igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
- shard-snb: [PASS][25] -> [SKIP][26] ([fdo#109271])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-snb4/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-snb6/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1:
- shard-glk: [PASS][27] -> [FAIL][28] ([i915#2122])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-glk5/igt@kms_flip@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-glk1/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile:
- shard-skl: NOTRUN -> [FAIL][29] ([i915#2628])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-skl2/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-shrfb-fliptrack:
- shard-tglb: NOTRUN -> [SKIP][30] ([fdo#111825]) +13 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-tglb8/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-draw-render:
- shard-hsw: NOTRUN -> [SKIP][31] ([fdo#109271]) +10 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-hsw1/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-draw-render.html

* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][32] -> [FAIL][33] ([i915#1188])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-skl10/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-skl4/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#533])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-skl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [PASS][35] -> [FAIL][36] ([fdo#108145] / [i915#265])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-skl8/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-skl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
- shard-skl: NOTRUN -> [FAIL][37] ([fdo#108145] / [i915#265])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-skl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-kbl: NOTRUN -> [FAIL][38] ([fdo#108145] / [i915#265]) +1 similar issue
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-kbl6/igt@[email protected]

* igt@kms_properties@connector-properties-legacy:
- shard-kbl: [PASS][39] -> [DMESG-WARN][40] ([i915#165] / [i915#180] / [i915#78])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-kbl7/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-kbl2/igt@[email protected]

* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][41] -> [SKIP][42] ([fdo#109441]) +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-iclb6/igt@kms_psr@psr2_sprite_mmap_gtt.html

* igt@kms_writeback@writeback-pixel-formats:
- shard-skl: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#2437])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-skl6/igt@[email protected]

* igt@prime_nv_pcopy@test3_1:
- shard-tglb: NOTRUN -> [SKIP][44] ([fdo#109291])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-tglb8/igt@prime_nv_pcopy@test3_1.html

* igt@prime_vgem@sync@rcs0:
- shard-skl: [PASS][45] -> [INCOMPLETE][46] ([i915#409])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-skl1/igt@prime_vgem@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-skl10/igt@prime_vgem@[email protected]

* igt@tools_test@sysfs_l3_parity:
- shard-kbl: NOTRUN -> [SKIP][47] ([fdo#109271]) +19 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-kbl6/igt@tools_test@sysfs_l3_parity.html

#### Possible fixes ####

* {igt@gem_ctx_exec@basic-close-race}:
- shard-tglb: [INCOMPLETE][48] ([i915#2245]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-tglb2/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-tglb8/igt@[email protected]

* igt@gem_exec_whisper@basic-queues-priority:
- shard-glk: [DMESG-WARN][50] ([i915#118] / [i915#95]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-glk3/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-glk8/igt@[email protected]

* igt@kms_color@pipe-a-ctm-0-75:
- shard-skl: [DMESG-WARN][52] ([i915#1982]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-skl2/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-skl4/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-256x85-offscreen:
- shard-skl: [FAIL][54] ([i915#54]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-skl2/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-skl4/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-skl: [INCOMPLETE][56] ([i915#300]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-skl1/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-skl6/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@b-edp1:
- shard-iclb: [FAIL][58] ([i915#79]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-iclb5/igt@kms_flip@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-iclb7/igt@kms_flip@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-kbl: [DMESG-WARN][60] ([i915#180]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-kbl4/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-kbl6/igt@[email protected]

* igt@kms_plane@plane-panning-top-left-pipe-b-planes:
- shard-skl: [FAIL][62] ([i915#1036]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-skl5/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-skl8/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][64] ([fdo#108145] / [i915#265]) -> [PASS][65] +1 similar issue
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-skl5/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-skl8/igt@[email protected]

* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [SKIP][66] ([fdo#109441]) -> [PASS][67] +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-iclb5/igt@kms_psr@psr2_primary_page_flip.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html

* igt@perf@blocking:
- shard-skl: [FAIL][68] ([i915#1542]) -> [PASS][69] +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-skl7/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-skl4/igt@[email protected]

#### Warnings ####

* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][70] ([i915#2681] / [i915#2684]) -> [WARN][71] ([i915#2684])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-iclb1/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-iclb5/igt@[email protected]

* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][72] ([fdo#109349]) -> [DMESG-WARN][73] ([i915#1226])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-iclb5/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-iclb2/igt@[email protected]

* igt@runner@aborted:
- shard-kbl: ([FAIL][74], [FAIL][75]) ([i915#1814] / [i915#2295] / [i915#2722] / [i915#483]) -> [FAIL][76] ([i915#2295] / [i915#2722] / [i915#483])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-kbl3/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-kbl4/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-kbl1/igt@[email protected]
- shard-iclb: [FAIL][77] ([i915#2295] / [i915#2722] / [i915#483]) -> [FAIL][78] ([i915#2295] / [i915#2722])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-iclb8/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-iclb3/igt@[email protected]
- shard-apl: [FAIL][79] ([i915#2295] / [i915#2722]) -> ([FAIL][80], [FAIL][81]) ([fdo#109271] / [i915#2295] / [i915#2722] / [i915#716])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-apl8/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-apl1/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-apl2/igt@[email protected]
- shard-glk: ([FAIL][82], [FAIL][83]) ([i915#2295] / [i915#2722] / [i915#483] / [k.org#202321]) -> ([FAIL][84], [FAIL][85]) ([i915#2295] / [i915#2722] / [k.org#202321])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-glk7/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-glk4/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-glk6/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-glk4/igt@[email protected]
- shard-skl: [FAIL][86] ([i915#2295] / [i915#2722]) -> ([FAIL][87], [FAIL][88], [FAIL][89]) ([i915#2029] / [i915#2295] / [i915#2426] / [i915#2722] / [i915#409] / [i915#483])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9458/shard-skl10/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-skl10/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-skl3/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/shard-skl9/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111304]: https://bugs.freedesktop.org/show_bug.cgi?id=111304
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112306]: https://bugs.freedesktop.org/show_bug.cgi?id=112306
[i915#1036]: https://gitlab.freedesktop.org/drm/intel/issues/1036
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#1699]: https://gitlab.freedesktop.org/drm/intel/issues/1699
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2245]: https://gitlab.freedesktop.org/drm/intel/issues/2245
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2628]: https://gitlab.freedesktop.org/drm/intel/issues/2628
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
[i915#409]: https://gitlab.freedesktop.org/drm/intel/issues/409
[i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#78]: https://gitlab.freedesktop.org/drm/intel/issues/78
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321

Participating hosts (10 -> 10)
------------------------------

No changes in participating hosts

Build changes
-------------

* Linux: CI_DRM_9458 -> Patchwork_19079

CI-20190529: 20190529
CI_DRM_9458: 7eeed064e42528645b01910bfd6249096ac0cf73 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5884: b1015a3267bbccb985b2fa7e3accb778c7bff0ed @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19079: fc9fd6a12b0a5ea2773969c55bf65514d4a86258 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19079/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on the v1 series
#11 lore raw
In reply to Jani Nikula
Quoted 10 lines · Jani Nikula

For a long time now we've had a build option in i915 to ensure the headers in the driver are self-contained, i.e. they include and forward declare everything they need. Finally fix the gvt headers that aren't, and remove them from the exclude list.

Please use the CONFIG_DRM_I915_WERROR=y config option to ensure the driver remains warning free and headers stay self-contained.

Please merge this via the gvt tree.

Thanks, Jani! Looks fine to me.

Quoted 30 lines

Jani Nikula (8):
drm/i915/gvt: make execlist.h self-contained drm/i915/gvt: make fb_decoder.h self-contained drm/i915/gvt: make gtt.h self-contained drm/i915/gvt: make interrupt.h self-contained drm/i915/gvt: make mmio_context.h self-contained drm/i915/gvt: make gvt.h self-contained drm/i915/gvt: make scheduler.h self-contained drm/i915/gvt: make mpt.h self-contained

 drivers/gpu/drm/i915/Makefile           | 10 +---------
 drivers/gpu/drm/i915/gvt/execlist.h     |  3 ---
 drivers/gpu/drm/i915/gvt/fb_decoder.h   |  6 ++++--
 drivers/gpu/drm/i915/gvt/gtt.h          | 11 ++++++++++-
 drivers/gpu/drm/i915/gvt/gvt.h          |  4 ++++
 drivers/gpu/drm/i915/gvt/interrupt.h    |  5 ++++-
 drivers/gpu/drm/i915/gvt/mmio_context.h | 11 +++++++++++
 drivers/gpu/drm/i915/gvt/mpt.h          |  2 ++
 drivers/gpu/drm/i915/gvt/scheduler.h    |  5 +++++
 9 files changed, 41 insertions(+), 16 deletions(-)
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 1 line
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx