Skip to contentSkip to conversation

regulators: bd718x7: Add enable times

PATCH Superseded Guido Günther 4 participants 8 messages Dec 16, 2020 – Dec 17, 2020

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover regulators: bd718x7: Add enable times

Use the typical startup times from the data sheet so boards get a reasonable default. Not setting any enable time can lead to board hangs when e.g. clocks are enabled too soon afterwards.

This fixes gpu power domain resume on the Librem 5.

Guido Günther (1):
regulators: bd718x7: Add enable times

 drivers/regulator/bd718x7-regulator.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
Signature · 1 line
2.29.2
#1 lore raw

PATCH 1/1 regulators: bd718x7: Add enable times

Use the typical startup times from the data sheet so boards get a reasonable default. Not setting any enable time can lead to board hangs when e.g. clocks are enabled too soon afterwards.

This fixes gpu power domain resume on the Librem 5.

---
 drivers/regulator/bd718x7-regulator.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
drivers/regulator/bd718x7-regulator.c +27 -0
index e6d5d98c3cea..d6d34aa4ee2e 100644
@@ -613,6 +613,7 @@ static struct bd718xx_regulator_data bd71847_regulators[] = {
 			.vsel_mask = DVS_BUCK_RUN_MASK,
 			.enable_reg = BD718XX_REG_BUCK1_CTRL,
 			.enable_mask = BD718XX_BUCK_EN,
+			.enable_time = 144,
 			.owner = THIS_MODULE,
 			.of_parse_cb = buck_set_hw_dvs_levels,
 		},
@@ -646,6 +647,7 @@ static struct bd718xx_regulator_data bd71847_regulators[] = {
 			.vsel_mask = DVS_BUCK_RUN_MASK,
 			.enable_reg = BD718XX_REG_BUCK2_CTRL,
 			.enable_mask = BD718XX_BUCK_EN,
+			.enable_time = 162,
 			.owner = THIS_MODULE,
 			.of_parse_cb = buck_set_hw_dvs_levels,
 		},
@@ -680,6 +682,7 @@ static struct bd718xx_regulator_data bd71847_regulators[] = {
 			.linear_range_selectors = bd71847_buck3_volt_range_sel,
 			.enable_reg = BD718XX_REG_1ST_NODVS_BUCK_CTRL,
 			.enable_mask = BD718XX_BUCK_EN,
+			.enable_time = 162,
 			.owner = THIS_MODULE,
 		},
 		.init = {
@@ -706,6 +709,7 @@ static struct bd718xx_regulator_data bd71847_regulators[] = {
 			.vsel_range_mask = BD71847_BUCK4_RANGE_MASK,
 			.linear_range_selectors = bd71847_buck4_volt_range_sel,
 			.enable_mask = BD718XX_BUCK_EN,
+			.enable_time = 240,
 			.owner = THIS_MODULE,
 		},
 		.init = {
@@ -727,6 +731,7 @@ static struct bd718xx_regulator_data bd71847_regulators[] = {
 			.vsel_mask = BD718XX_3RD_NODVS_BUCK_MASK,
 			.enable_reg = BD718XX_REG_3RD_NODVS_BUCK_CTRL,
 			.enable_mask = BD718XX_BUCK_EN,
+			.enable_time = 220,
 			.owner = THIS_MODULE,
 		},
 		.init = {
@@ -750,6 +755,7 @@ static struct bd718xx_regulator_data bd71847_regulators[] = {
 			.vsel_mask = BD718XX_4TH_NODVS_BUCK_MASK,
 			.enable_reg = BD718XX_REG_4TH_NODVS_BUCK_CTRL,
 			.enable_mask = BD718XX_BUCK_EN,
+			.enable_time = 200,
 			.owner = THIS_MODULE,
 		},
 		.init = {
@@ -775,6 +781,7 @@ static struct bd718xx_regulator_data bd71847_regulators[] = {
 			.linear_range_selectors = bd718xx_ldo1_volt_range_sel,
 			.enable_reg = BD718XX_REG_LDO1_VOLT,
 			.enable_mask = BD718XX_LDO_EN,
+			.enable_time = 440,
 			.owner = THIS_MODULE,
 		},
 		.init = {
@@ -796,6 +803,7 @@ static struct bd718xx_regulator_data bd71847_regulators[] = {
 			.n_voltages = ARRAY_SIZE(ldo_2_volts),
 			.enable_reg = BD718XX_REG_LDO2_VOLT,
 			.enable_mask = BD718XX_LDO_EN,
+			.enable_time = 370,
 			.owner = THIS_MODULE,
 		},
 		.init = {
@@ -818,6 +826,7 @@ static struct bd718xx_regulator_data bd71847_regulators[] = {
 			.vsel_mask = BD718XX_LDO3_MASK,
 			.enable_reg = BD718XX_REG_LDO3_VOLT,
 			.enable_mask = BD718XX_LDO_EN,
+			.enable_time = 310,
 			.owner = THIS_MODULE,
 		},
 		.init = {
@@ -840,6 +849,7 @@ static struct bd718xx_regulator_data bd71847_regulators[] = {
 			.vsel_mask = BD718XX_LDO4_MASK,
 			.enable_reg = BD718XX_REG_LDO4_VOLT,
 			.enable_mask = BD718XX_LDO_EN,
+			.enable_time = 400,
 			.owner = THIS_MODULE,
 		},
 		.init = {
@@ -865,6 +875,7 @@ static struct bd718xx_regulator_data bd71847_regulators[] = {
 			.linear_range_selectors = bd71847_ldo5_volt_range_sel,
 			.enable_reg = BD718XX_REG_LDO5_VOLT,
 			.enable_mask = BD718XX_LDO_EN,
+			.enable_time = 530,
 			.owner = THIS_MODULE,
 		},
 		.init = {
@@ -889,6 +900,7 @@ static struct bd718xx_regulator_data bd71847_regulators[] = {
 			.vsel_mask = BD718XX_LDO6_MASK,
 			.enable_reg = BD718XX_REG_LDO6_VOLT,
 			.enable_mask = BD718XX_LDO_EN,
+			.enable_time = 400,
 			.owner = THIS_MODULE,
 		},
 		.init = {
@@ -942,6 +954,7 @@ static struct bd718xx_regulator_data bd71837_regulators[] = {
 			.vsel_mask = DVS_BUCK_RUN_MASK,
 			.enable_reg = BD718XX_REG_BUCK1_CTRL,
 			.enable_mask = BD718XX_BUCK_EN,
+			.enable_time = 160,
 			.owner = THIS_MODULE,
 			.of_parse_cb = buck_set_hw_dvs_levels,
 		},
@@ -975,6 +988,7 @@ static struct bd718xx_regulator_data bd71837_regulators[] = {
 			.vsel_mask = DVS_BUCK_RUN_MASK,
 			.enable_reg = BD718XX_REG_BUCK2_CTRL,
 			.enable_mask = BD718XX_BUCK_EN,
+			.enable_time = 180,
 			.owner = THIS_MODULE,
 			.of_parse_cb = buck_set_hw_dvs_levels,
 		},
@@ -1005,6 +1019,7 @@ static struct bd718xx_regulator_data bd71837_regulators[] = {
 			.vsel_mask = DVS_BUCK_RUN_MASK,
 			.enable_reg = BD71837_REG_BUCK3_CTRL,
 			.enable_mask = BD718XX_BUCK_EN,
+			.enable_time = 180,
 			.owner = THIS_MODULE,
 			.of_parse_cb = buck_set_hw_dvs_levels,
 		},
@@ -1033,6 +1048,7 @@ static struct bd718xx_regulator_data bd71837_regulators[] = {
 			.vsel_mask = DVS_BUCK_RUN_MASK,
 			.enable_reg = BD71837_REG_BUCK4_CTRL,
 			.enable_mask = BD718XX_BUCK_EN,
+			.enable_time = 180,
 			.owner = THIS_MODULE,
 			.of_parse_cb = buck_set_hw_dvs_levels,
 		},
@@ -1065,6 +1081,7 @@ static struct bd718xx_regulator_data bd71837_regulators[] = {
 			.linear_range_selectors = bd71837_buck5_volt_range_sel,
 			.enable_reg = BD718XX_REG_1ST_NODVS_BUCK_CTRL,
 			.enable_mask = BD718XX_BUCK_EN,
+			.enable_time = 160,
 			.owner = THIS_MODULE,
 		},
 		.init = {
@@ -1088,6 +1105,7 @@ static struct bd718xx_regulator_data bd71837_regulators[] = {
 			.vsel_mask = BD71837_BUCK6_MASK,
 			.enable_reg = BD718XX_REG_2ND_NODVS_BUCK_CTRL,
 			.enable_mask = BD718XX_BUCK_EN,
+			.enable_time = 240,
 			.owner = THIS_MODULE,
 		},
 		.init = {
@@ -1109,6 +1127,7 @@ static struct bd718xx_regulator_data bd71837_regulators[] = {
 			.vsel_mask = BD718XX_3RD_NODVS_BUCK_MASK,
 			.enable_reg = BD718XX_REG_3RD_NODVS_BUCK_CTRL,
 			.enable_mask = BD718XX_BUCK_EN,
+			.enable_time = 220,
 			.owner = THIS_MODULE,
 		},
 		.init = {
@@ -1132,6 +1151,7 @@ static struct bd718xx_regulator_data bd71837_regulators[] = {
 			.vsel_mask = BD718XX_4TH_NODVS_BUCK_MASK,
 			.enable_reg = BD718XX_REG_4TH_NODVS_BUCK_CTRL,
 			.enable_mask = BD718XX_BUCK_EN,
+			.enable_time = 200,
 			.owner = THIS_MODULE,
 		},
 		.init = {
@@ -1157,6 +1177,7 @@ static struct bd718xx_regulator_data bd71837_regulators[] = {
 			.linear_range_selectors = bd718xx_ldo1_volt_range_sel,
 			.enable_reg = BD718XX_REG_LDO1_VOLT,
 			.enable_mask = BD718XX_LDO_EN,
+			.enable_time = 440,
 			.owner = THIS_MODULE,
 		},
 		.init = {
@@ -1178,6 +1199,7 @@ static struct bd718xx_regulator_data bd71837_regulators[] = {
 			.n_voltages = ARRAY_SIZE(ldo_2_volts),
 			.enable_reg = BD718XX_REG_LDO2_VOLT,
 			.enable_mask = BD718XX_LDO_EN,
+			.enable_time = 370,
 			.owner = THIS_MODULE,
 		},
 		.init = {
@@ -1200,6 +1222,7 @@ static struct bd718xx_regulator_data bd71837_regulators[] = {
 			.vsel_mask = BD718XX_LDO3_MASK,
 			.enable_reg = BD718XX_REG_LDO3_VOLT,
 			.enable_mask = BD718XX_LDO_EN,
+			.enable_time = 310,
 			.owner = THIS_MODULE,
 		},
 		.init = {
@@ -1222,6 +1245,7 @@ static struct bd718xx_regulator_data bd71837_regulators[] = {
 			.vsel_mask = BD718XX_LDO4_MASK,
 			.enable_reg = BD718XX_REG_LDO4_VOLT,
 			.enable_mask = BD718XX_LDO_EN,
+			.enable_time = 400,
 			.owner = THIS_MODULE,
 		},
 		.init = {
@@ -1246,6 +1270,7 @@ static struct bd718xx_regulator_data bd71837_regulators[] = {
 			.vsel_mask = BD71837_LDO5_MASK,
 			.enable_reg = BD718XX_REG_LDO5_VOLT,
 			.enable_mask = BD718XX_LDO_EN,
+			.enable_time = 310,
 			.owner = THIS_MODULE,
 		},
 		.init = {
@@ -1272,6 +1297,7 @@ static struct bd718xx_regulator_data bd71837_regulators[] = {
 			.vsel_mask = BD718XX_LDO6_MASK,
 			.enable_reg = BD718XX_REG_LDO6_VOLT,
 			.enable_mask = BD718XX_LDO_EN,
+			.enable_time = 400,
 			.owner = THIS_MODULE,
 		},
 		.init = {
@@ -1296,6 +1322,7 @@ static struct bd718xx_regulator_data bd71837_regulators[] = {
 			.vsel_mask = BD71837_LDO7_MASK,
 			.enable_reg = BD71837_REG_LDO7_VOLT,
 			.enable_mask = BD718XX_LDO_EN,
+			.enable_time = 530,
 			.owner = THIS_MODULE,
 		},
 		.init = {
Signature · 1 line
2.29.2
#2 lore raw

Hello Guido,

Thanks for looking at this!

Quoted 19 lines · Guido Günther

Use the typical startup times from the data sheet so boards get a reasonable default. Not setting any enable time can lead to board hangs
when e.g. clocks are enabled too soon afterwards.

This fixes gpu power domain resume on the Librem 5.

---
 drivers/regulator/bd718x7-regulator.c | 27
+++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
drivers/regulator/bd718x7-regulator.c +0 -0
index e6d5d98c3cea..d6d34aa4ee2e 100644

drivers/regulator/bd718x7-regulator.c static struct bd718xx_regulator_data · line 617

Quoted 5 lines
drivers/regulator/bd718x7-regulator.c +1 -0
@@ -613,6 +613,7 @@ static struct bd718xx_regulator_data
 bd71847_regulators[] = {
 			.vsel_mask = DVS_BUCK_RUN_MASK,
 			.enable_reg = BD718XX_REG_BUCK1_CTRL,
 			.enable_mask = BD718XX_BUCK_EN,
+			.enable_time = 144,

Where are these values obtained from? I have a feeling they might be board / load specific. If this is the case - can the "regulator-enable- ramp-delay" from device-tree be used instead to avoid hard-coding board specific values in the driver? Although, sane defaults would probably not be a bad idea - if I read code correctly then the constrains from DT can be used to override these values.

I'd prefer well named defines over raw numeric values though.

Best Regards
Matti Vaittinen

#3 lore raw

Hi Matti,

Quoted 28 lines · Matti

Hello Guido,

Thanks for looking at this!

Quoted 23 lines · Guido Günther

Use the typical startup times from the data sheet so boards get a reasonable default. Not setting any enable time can lead to board hangs
when e.g. clocks are enabled too soon afterwards.

This fixes gpu power domain resume on the Librem 5.

---
 drivers/regulator/bd718x7-regulator.c | 27
+++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
drivers/regulator/bd718x7-regulator.c +0 -0
index e6d5d98c3cea..d6d34aa4ee2e 100644
@@ -613,6 +613,7 @@ static struct bd718xx_regulator_data
 bd71847_regulators[] = {
 			.vsel_mask = DVS_BUCK_RUN_MASK,
 			.enable_reg = BD718XX_REG_BUCK1_CTRL,
 			.enable_mask = BD718XX_BUCK_EN,
Quoted 8 lines

drivers/regulator/bd718x7-regulator.c static struct bd718xx_regulator_data bd71847_regulators[] = { · line 616

Quoted 1 line
drivers/regulator/bd718x7-regulator.c +1 -0
+			.enable_time = 144,

Where are these values obtained from? I have a feeling they might be board / load specific. If this is the case - can the "regulator-enable- ramp-delay" from device-tree be used instead to avoid hard-coding board specific values in the driver? Although, sane defaults would probably not be a bad idea - if I read code correctly then the constrains from DT can be used to override these values.

They're the 'typical values' from the data sheet and it's basically all about setting a default for "regulator-enable-ramp-delay" to avoid having every board do the same. If that's not the right thing todo let me know and i add these to each of our boards (which is where i basically started from but then figured that this would be busywork and every board would hit that problem).

Quoted 1 line

I'd prefer well named defines over raw numeric values though.

So s.th. like

BD71837_BUCK1_STARTUP_TIME 144

(using the terminology from the datasheet)? If that works I'll send a v2.

Cheers,
--Guido

Quoted 5 lines

Best Regards
Matti Vaittinen

maintainer
#4 lore raw
Quoted 11 lines · Guido Günther
Quoted 8 lines · Matti

drivers/regulator/bd718x7-regulator.c static struct bd718xx_regulator_data bd71847_regulators[] = { · line 616

Quoted 1 line
drivers/regulator/bd718x7-regulator.c +1 -0
+			.enable_time = 144,

Where are these values obtained from? I have a feeling they might be board / load specific. If this is the case - can the "regulator-enable- ramp-delay" from device-tree be used instead to avoid hard-coding board specific values in the driver? Although, sane defaults would probably not be a bad idea - if I read code correctly then the constrains from DT can be used to override these values.

Quoted 6 lines

They're the 'typical values' from the data sheet and it's basically all about setting a default for "regulator-enable-ramp-delay" to avoid having every board do the same. If that's not the right thing todo let me know and i add these to each of our boards (which is where i basically started from but then figured that this would be busywork and every board would hit that problem).

If it's a DCDC they're *probably* generic values rather than board specific, they tend to be more predictable as they're regulating much more actively than LDOs.

#5 lore raw
Quoted 23 lines · Mark Brown
Quoted 13 lines · Guido Günther
Quoted 4 lines · Matti

drivers/regulator/bd718x7-regulator.c static struct bd718xx_regulator_data bd71847_regulators[] = { · line 616

Quoted 1 line
drivers/regulator/bd718x7-regulator.c +1 -0
+			.enable_time = 144,

Where are these values obtained from? I have a feeling they might be
board / load specific. If this is the case - can the "regulator-

Quoted 8 lines

enable-
ramp-delay" from device-tree be used instead to avoid hard-coding board
specific values in the driver? Although, sane defaults would probably
not be a bad idea - if I read code correctly then the constrains from
DT can be used to override these values.

Quoted 8 lines

They're the 'typical values' from the data sheet and it's basically all
about setting a default for "regulator-enable-ramp-delay" to avoid having every board do the same. If that's not the right thing todo let
me know and i add these to each of our boards (which is where i basically started from but then figured that this would be busywork and every board would hit that problem).

Quoted 3 lines

If it's a DCDC they're *probably* generic values rather than board specific, they tend to be more predictable as they're regulating much more actively than LDOs.

Thank you for explanation Mark & Guido.
Then I'd say the 'default' enable times do make sense. Thanks for improving the driver!

Best Regards
Matti Vaittinen

#6 lore raw
In reply to Guido Günther
Quoted 53 lines · Guido Günther

Hi Matti,

Quoted 33 lines · Matti

Hello Guido,

Thanks for looking at this!

Quoted 19 lines · Guido Günther

Use the typical startup times from the data sheet so boards get a reasonable default. Not setting any enable time can lead to board hangs
when e.g. clocks are enabled too soon afterwards.

This fixes gpu power domain resume on the Librem 5.

---
 drivers/regulator/bd718x7-regulator.c | 27
+++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
drivers/regulator/bd718x7-regulator.c +0 -0
index e6d5d98c3cea..d6d34aa4ee2e 100644

drivers/regulator/bd718x7-regulator.c static struct bd718xx_regulator_data · line 617

Quoted 5 lines
drivers/regulator/bd718x7-regulator.c +1 -0
@@ -613,6 +613,7 @@ static struct bd718xx_regulator_data
 bd71847_regulators[] = {
 			.vsel_mask = DVS_BUCK_RUN_MASK,
 			.enable_reg = BD718XX_REG_BUCK1_CTRL,
 			.enable_mask = BD718XX_BUCK_EN,
+			.enable_time = 144,

Where are these values obtained from? I have a feeling they might be
board / load specific. If this is the case - can the "regulator-

Quoted 8 lines

enable-
ramp-delay" from device-tree be used instead to avoid hard-coding board
specific values in the driver? Although, sane defaults would probably
not be a bad idea - if I read code correctly then the constrains from
DT can be used to override these values.

They're the 'typical values' from the data sheet and it's basically all
about setting a default for "regulator-enable-ramp-delay" to avoid having every board do the same. If that's not the right thing todo let
me know and i add these to each of our boards (which is where i basically started from but then figured that this would be busywork and every board would hit that problem).

Quoted 8 lines
Quoted 1 line

I'd prefer well named defines over raw numeric values though.

So s.th. like

BD71837_BUCK1_STARTUP_TIME 144

(using the terminology from the datasheet)? If that works I'll send a v2.

Just noticed I never replied. Sorry. This looks good to me!

Best Regards
--Matti

maintainer
#7 lore raw
In reply to Guido Günther
Quoted 3 lines · Guido Günther

Use the typical startup times from the data sheet so boards get a reasonable default. Not setting any enable time can lead to board hangs when e.g. clocks are enabled too soon afterwards.

Please don't send cover letters for single patches, if there is anything that needs saying put it in the changelog of the patch or after the --- if it's administrative stuff. This reduces mail volume and ensures that any important information is recorded in the changelog rather than being lost.