clk: renesas: cpg-mssr: Small cleaups
Subsystems (2)
Geert Uytterhoeven
maintainercover clk: renesas: cpg-mssr: Small cleaups
Hi Mike, Stephen,
Here are two small cleanups for the Renesas CPG/MSSR driver. I plan to queue these in renesas-clk for v5.14.
Thanks!
Geert Uytterhoeven (2):
clk: renesas: cpg-mssr: Remove unused [RM]MSTPCR() definitions
clk: renesas: cpg-mssr: Make srstclr[] comment block consistent
drivers/clk/renesas/renesas-cpg-mssr.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
Signature · 12 lines
2.25.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus TorvaldsGeert Uytterhoeven
maintainerPATCH 1/2 clk: renesas: cpg-mssr: Remove unused [RM]MSTPCR() definitions
The Realtime Module Stop Control Register definitions (RMSTPCR(i)) are incorrect for i >= 8 on R-Car Gen2 and Gen3.
As these are unused, and not planned to be used, just like the corresponding Modem Module Stop Control Register definitions (MMSTPCR()) on R-Mobile APE6 (they are intended for the software running on the Real-Time and Modem CPU cores), they can just be removed.
--- drivers/clk/renesas/renesas-cpg-mssr.c | 6 ------ 1 file changed, 6 deletions(-)
drivers/clk/renesas/renesas-cpg-mssr.c +0 -6
@@ -100,12 +100,6 @@ static const u16 srcr_for_v3u[] = { 0x2C20, 0x2C24, 0x2C28, 0x2C2C, 0x2C30, 0x2C34, 0x2C38, }; -/* Realtime Module Stop Control Register offsets */ -#define RMSTPCR (i) (smstpcr[i] - 0x20) - -/* Modem Module Stop Control Register offsets (r8a73a4) */ -#define MMSTPCR (i) (smstpcr[i] + 0x20) -/* Software Reset Clearing Register offsets */ static const u16 srstclr[] = {
Signature · 1 line
2.25.1
Re: [PATCH 1/2] clk: renesas: cpg-mssr: Remove unused [RM]MSTPCR() definitions
Quoting Geert Uytterhoeven (2021-05-04 02:17:21)
Quoted 11 lines
The Realtime Module Stop Control Register definitions (RMSTPCR(i)) are incorrect for i >= 8 on R-Car Gen2 and Gen3.
As these are unused, and not planned to be used, just like the corresponding Modem Module Stop Control Register definitions (
MMSTPCR()) on R-Mobile APE6 (they are intended for the software running on the Real-Time and Modem CPU cores), they can just be removed.Reported-by Hai Nguyen Pham <[email protected]>Signed-off-by Geert Uytterhoeven <[email protected]>---
Geert Uytterhoeven
maintainerPATCH 2/2 clk: renesas: cpg-mssr: Make srstclr[] comment block consistent
In reply to Geert UytterhoevenMake the style of the comment block for the Software Reset Clearing Register offsets consistent with the comment blocks for the other register offsets.
--- drivers/clk/renesas/renesas-cpg-mssr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/clk/renesas/renesas-cpg-mssr.c +3 -1
@@ -100,7 +100,9 @@ static const u16 srcr_for_v3u[] = { 0x2C20, 0x2C24, 0x2C28, 0x2C2C, 0x2C30, 0x2C34, 0x2C38, }; -/* Software Reset Clearing Register offsets */ +/* +* Software Reset Clearing Register offsets +*/ static const u16 srstclr[] = {0x940 ,0x944 ,0x948 ,0x94C ,0x950 ,0x954 ,0x958 ,0x95C ,
Signature · 1 line
2.25.1
Re: [PATCH 2/2] clk: renesas: cpg-mssr: Make srstclr[] comment block consistent
Quoting Geert Uytterhoeven (2021-05-04 02:17:22)
Quoted 6 lines
Make the style of the comment block for the Software Reset Clearing Register offsets consistent with the comment blocks for the other register offsets.
Signed-off-by Geert Uytterhoeven <[email protected]>---