Skip to contentSkip to conversation

mips: dts: loongson: fix DTC unit name warnings

PATCH In review zhaoxiao 3 participants 9 messages May 21, 2021 – May 27, 2021

Subsystems (2)
lore
Share & tools
lore

zhaoxiao

author
#0 lore raw

cover mips: dts: loongson: fix DTC unit name warnings

*** BLURB HERE ***

zhaoxiao (5):
mips: dts: loongson: fix DTC unit name warnings
mips: dts: loongson: fix DTC unit name warnings
mips: dts: loongson: fix DTC unit name warnings
mips: dts: loongson: fix DTC unit name warnings
mips: dts: loongson: fix DTC unit name warnings

 arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi       | 2 +-
 arch/mips/boot/dts/loongson/loongson64g-package.dtsi     | 4 ++--
 arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts | 2 +-
 arch/mips/boot/dts/loongson/ls7a-pch.dtsi                | 2 +-
 arch/mips/boot/dts/loongson/rs780e-pch.dtsi              | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)
Signature · 1 line
2.20.1
author
#1 lore raw

PATCH 1/5 mips: dts: loongson: fix DTC unit name warnings

Fixes the following W=1 kernel build warning(s):
arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi:26.9-32.4: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name

---
 arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi +1 -1
index 569e814def83..06207254b2d1 100644
@@ -23,7 +23,7 @@
 		};
 	};
 
-	memory {
+	memory@200000 {
 		compatible = "memory";
 		device_type = "memory";
 		reg = <0x00000000 0x00200000 0x00000000 0x0ee00000>, /* 238 MB at 2 MB */
Signature · 1 line
2.20.1
author
#2 lore raw

PATCH 2/5 mips: dts: loongson: fix DTC unit name warnings

In reply to zhaoxiao

Fixes the following W=1 kernel build warning(s):
arch/mips/boot/dts/loongson/loongson64g-package.dtsi:42.30-49.5: Warning (simple_bus_reg): /bus@1fe00000/serial@1fe001e0: simple-bus unit address format error, expected "1fe00100" arch/mips/boot/dts/loongson/loongson64g-package.dtsi:51.30-59.5: Warning (simple_bus_reg): /bus@1fe00000/serial@1fe001e8: simple-bus unit address format error, expected "1fe00110"

---
 arch/mips/boot/dts/loongson/loongson64g-package.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/mips/boot/dts/loongson/loongson64g-package.dtsi +2 -2
index 38abc570cd82..d4314f62ccc2 100644
@@ -39,7 +39,7 @@
 
 		};
 
-		cpu_uart0: serial@1fe001e0 {
+		cpu_uart0: serial@1fe00100 {
 			compatible = "ns16550a";
 			reg = <0 0x1fe00100 0x10>;
 			clock-frequency = <100000000>;
@@ -48,7 +48,7 @@
 			no-loopback-test;
 		};
 
-		cpu_uart1: serial@1fe001e8 {
+		cpu_uart1: serial@1fe00110 {
 			status = "disabled";
 			compatible = "ns16550a";
 			reg = <0 0x1fe00110 0x10>;
Signature · 1 line
2.20.1
Acked-by on v1 2/5
#3 lore raw
Quoted 3 lines · zhaoxiao

Fixes the following W=1 kernel build warning(s):
arch/mips/boot/dts/loongson/loongson64g-package.dtsi:42.30-49.5: Warning (simple_bus_reg): /bus@1fe00000/serial@1fe001e0: simple-bus unit address format error, expected "1fe00100" arch/mips/boot/dts/loongson/loongson64g-package.dtsi:51.30-59.5: Warning (simple_bus_reg): /bus@1fe00000/serial@1fe001e8: simple-bus unit address format error, expected "1fe00110"

Quoted 28 lines
---
  arch/mips/boot/dts/loongson/loongson64g-package.dtsi | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
arch/mips/boot/dts/loongson/loongson64g-package.dtsi +2 -2
index 38abc570cd82..d4314f62ccc2 100644
@@ -39,7 +39,7 @@
 
  		};
 
-		cpu_uart0: serial@1fe001e0 {
+		cpu_uart0: serial@1fe00100 {
  			compatible = "ns16550a";
  			reg = <0 0x1fe00100 0x10>;
  			clock-frequency = <100000000>;
@@ -48,7 +48,7 @@
  			no-loopback-test;
  		};
 
-		cpu_uart1: serial@1fe001e8 {
+		cpu_uart1: serial@1fe00110 {
  			status = "disabled";
  			compatible = "ns16550a";
  			reg = <0 0x1fe00110 0x10>;
author
#4 lore raw

PATCH 3/5 mips: dts: loongson: fix DTC unit name warnings

In reply to zhaoxiao

Fixes the following W=1 kernel build warning(s):
arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts:91.7-96.5: Warning (unit_address_vs_reg): /bus@10000000/isa: node has a reg or ranges property, but no unit name arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts:91.7-96.5: Warning (simple_bus_reg): /bus@10000000/isa: simple-bus unit address format error, expected "18000000"

---
 arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts +1 -1
index 41f0b110d455..d0588d81e0c2 100644
@@ -88,7 +88,7 @@
 			interrupt-map-mask = <0x1800 0x0 0x0  0x7>;
 		};
 
-		isa {
+		isa@18000000 {
 			compatible = "isa";
 			#address-cells = <2>;
 			#size-cells = <1>;
Signature · 1 line
2.20.1
author
#5 lore raw

PATCH 4/5 mips: dts: loongson: fix DTC unit name warnings

In reply to zhaoxiao

Fixes the following W=1 kernel build warning(s):
arch/mips/boot/dts/loongson/ls7a-pch.dtsi:410.7-415.5: Warning (unit_address_vs_reg): /bus@10000000/isa: node has a reg or ranges property, but no unit name arch/mips/boot/dts/loongson/ls7a-pch.dtsi:410.7-415.5: Warning (simple_bus_reg): /bus@10000000/isa: simple-bus unit address format error, expected "18000000"

---
 arch/mips/boot/dts/loongson/ls7a-pch.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/mips/boot/dts/loongson/ls7a-pch.dtsi +1 -1
index f99a7a11fded..d66e1037fba5 100644
@@ -407,7 +407,7 @@
 			};
 		};
 
-		isa {
+		isa@18000000 {
 			compatible = "isa";
 			#address-cells = <2>;
 			#size-cells = <1>;
Signature · 1 line
2.20.1
author
#6 lore raw

PATCH 5/5 mips: dts: loongson: fix DTC unit name warnings

In reply to zhaoxiao

Fixes the following W=1 kernel build warning(s):
arch/mips/boot/dts/loongson/rs780e-pch.dtsi:24.7-41.5: Warning (unit_address_vs_reg): /bus@10000000/isa: node has a reg or ranges property, but no unit name arch/mips/boot/dts/loongson/rs780e-pch.dtsi:24.7-41.5: Warning (simple_bus_reg): /bus@10000000/isa: simple-bus unit address format error, expected "18000000"

---
 arch/mips/boot/dts/loongson/rs780e-pch.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/mips/boot/dts/loongson/rs780e-pch.dtsi +1 -1
index 871c866e0423..6f459511e6c9 100644
@@ -21,7 +21,7 @@
 				 <0x02000000 0 0x40000000 0 0x40000000 0 0x40000000>;
 		};
 
-		isa {
+		isa@18000000 {
 			compatible = "isa";
 			#address-cells = <2>;
 			#size-cells = <1>;
Signature · 1 line
2.20.1
#7 lore raw
In reply to zhaoxiao
Quoted 1 line · zhaoxiao

*** BLURB HERE ***

Hi Xiao,

Most of these are not real problem beside patch 2.

There are some established by usage rules important than these verbose warnings.

Thanks.

- Jiaxun

Quoted 15 lines

zhaoxiao (5):
mips: dts: loongson: fix DTC unit name warnings
mips: dts: loongson: fix DTC unit name warnings
mips: dts: loongson: fix DTC unit name warnings
mips: dts: loongson: fix DTC unit name warnings
mips: dts: loongson: fix DTC unit name warnings

  arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi       | 2 +-
  arch/mips/boot/dts/loongson/loongson64g-package.dtsi     | 4 ++--
  arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts | 2 +-
  arch/mips/boot/dts/loongson/ls7a-pch.dtsi                | 2 +-
  arch/mips/boot/dts/loongson/rs780e-pch.dtsi              | 2 +-
  5 files changed, 6 insertions(+), 6 deletions(-)
#8 lore raw
In reply to zhaoxiao
Quoted 9 lines · zhaoxiao

*** BLURB HERE ***

zhaoxiao (5):
mips: dts: loongson: fix DTC unit name warnings
mips: dts: loongson: fix DTC unit name warnings
mips: dts: loongson: fix DTC unit name warnings
mips: dts: loongson: fix DTC unit name warnings
mips: dts: loongson: fix DTC unit name warnings

Quoted 6 lines
 arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi       | 2 +-
 arch/mips/boot/dts/loongson/loongson64g-package.dtsi     | 4 ++--
 arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts | 2 +-
 arch/mips/boot/dts/loongson/ls7a-pch.dtsi                | 2 +-
 arch/mips/boot/dts/loongson/rs780e-pch.dtsi              | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

series applied to mips-next.

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]