sms911x: DTS fixes and DT binding to json-schema conversion
v2 cover sms911x: DTS fixes and DT binding to json-schema conversion
Hi all,
This patch series converts the Smart Mixed-Signal Connectivity (SMSC) LAN911x/912x Controller Device Tree binding documentation to json-schema, after fixing a few issues in DTS files.
Changed compared to v1[1]:
- Dropped applied patches,
- Add Reviewed-by,
- Drop bogus double quotes in compatible values,
- Add comment explaining why "additionalProperties: true" is needed.
Thanks!
[1] [PATCH 0/5] sms911x: DTS fixes and DT binding to json-schema conversion
https://lore.kernel.org/r/[email protected]
Geert Uytterhoeven (2):
ARM: dts: qcom-apq8060: Correct Ethernet node name and drop bogus irq
property
dt-bindings: net: sms911x: Convert to json-schema
.../devicetree/bindings/net/gpmc-eth.txt | 2 +- .../devicetree/bindings/net/smsc,lan9115.yaml | 110 ++++++++++++++++++ .../devicetree/bindings/net/smsc911x.txt | 43 ------- .../arm/boot/dts/qcom-apq8060-dragonboard.dts | 4 +- 4 files changed, 112 insertions(+), 47 deletions(-) create mode 100644 Documentation/devicetree/bindings/net/smsc,lan9115.yaml delete mode 100644 Documentation/devicetree/bindings/net/smsc911x.txt
Signature · 12 lines
2.25.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus TorvaldsPATCH v2 1/2 ARM: dts: qcom-apq8060: Correct Ethernet node name and drop bogus irq property
make dtbs_check:
ethernet-ebi2@2,0: $nodename:0: 'ethernet-ebi2@2,0' does not match '^ethernet(@.*)?$' ethernet-ebi2@2,0: 'smsc,irq-active-low' does not match any of the regexes: 'pinctrl-[0-9]+'
There is no "smsc,irq-active-low" property, as active low is the default.
---
v2:
- Add Reviewed-by.
--- arch/arm/boot/dts/qcom-apq8060-dragonboard.dts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
arch/arm/boot/dts/qcom-apq8060-dragonboard.dts +1 -3
@@ -581,7 +581,7 @@ external-bus@1a100000 { * EBI2. This has a 25MHz chrystal next to it, so no * clocking is needed. */ - ethernet-ebi2@2,0 { + ethernet@2,0 { compatible = "smsc,lan9221", "smsc,lan9115"; reg = <2 0x0 0x100>; /*
@@ -598,8 +598,6 @@ ethernet-ebi2@2,0 { phy-mode = "mii"; reg-io-width = <2>; smsc,force-external-phy; - /* IRQ on edge falling = active low */ - smsc,irq-active-low; smsc,irq-push-pull; /*
Signature · 1 line
2.25.1
PATCH v2 2/2 dt-bindings: net: sms911x: Convert to json-schema
In reply to Geert UytterhoevenConvert the Smart Mixed-Signal Connectivity (SMSC) LAN911x/912x Controller Device Tree binding documentation to json-schema.
Document missing properties.
Make "phy-mode" not required, as many DTS files do not have it, and the Linux drivers falls back to PHY_INTERFACE_MODE_NA.
Correct nodename in example.
---
I have listed Shawn as the maintainer, as he wrote the original bindings. Shawn: Please scream if this is inappropriate ;-)
v2:
- Drop bogus double quotes in compatible values,
- Add comment explaining why "additionalProperties: true" is needed.
--- .../devicetree/bindings/net/gpmc-eth.txt | 2 +- .../devicetree/bindings/net/smsc,lan9115.yaml | 110 ++++++++++++++++++ .../devicetree/bindings/net/smsc911x.txt | 43 ------- 3 files changed, 111 insertions(+), 44 deletions(-) create mode 100644 Documentation/devicetree/bindings/net/smsc,lan9115.yaml delete mode 100644 Documentation/devicetree/bindings/net/smsc911x.txt
Documentation/devicetree/bindings/net/gpmc-eth.txt +1 -1
@@ -13,7 +13,7 @@ Documentation/devicetree/bindings/memory-controllers/omap-gpmc.txt For the properties relevant to the ethernet controller connected to the GPMC refer to the binding documentation of the device. For example, the documentation -for the SMSC 911x is Documentation/devicetree/bindings/net/smsc911x.txt +for the SMSC 911x is Documentation/devicetree/bindings/net/smsc,lan9115.yaml Child nodes need to specify the GPMC bus address width using the "bank-width" property but is possible that an ethernet controller also has a property to
Documentation/devicetree/bindings/net/smsc,lan9115.yaml new file +110 -0
110 lines not on this page · raw message
Documentation/devicetree/bindings/net/smsc911x.txt deleted +0 -43
43 lines not on this page · raw message
Signature · 1 line
2.25.1
This series was applied to netdev/net.git (refs/heads/master):
Hello:
This series was applied to netdev/net.git (refs/heads/master):
Quoted 6 lines · On Thu, 1 Jul 2021 14:02:19 +0200 you wrote:
Hi all,
This patch series converts the Smart Mixed-Signal Connectivity (SMSC) LAN911x/912x Controller Device Tree binding documentation to json-schema, after fixing a few issues in DTS files.
Quoted 7 lines
Changed compared to v1[1]:
- Dropped applied patches,
- Add Reviewed-by,
- Drop bogus double quotes in compatible values,
- Add comment explaining why "additionalProperties: true" is needed.[...]
Here is the summary with links:
- [v2,1/2] ARM: dts: qcom-apq8060: Correct Ethernet node name and drop bogus irq property
https://git.kernel.org/netdev/net/c/b6c880103823 - [v2,2/2] dt-bindings: net: sms911x: Convert to json-schema https://git.kernel.org/netdev/net/c/19373d0233d0
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html