Add Pdc, GCC and RPMh clock support for SDX65
Subsystems (5)
v2 cover Add Pdc, GCC and RPMh clock support for SDX65
From: Vamsi Krishna Lanka <[email protected]>
Hello,
Changes from v1:
- Addressed Bjorn's comments related to the GCC support patch
- Collected Bjorn's and Rob's Reviewed-by for the dt-bindings patches
This patch series adds bindings and device driver changes for GCC, pdc and RPMh clock support for SDX65 Platform.
Thanks,
Vamsi
Vamsi Krishna Lanka (2):
clk: qcom: Add new PLL type for SDX65
clk: qcom: Add SDX65 GCC support
Vamsi krishna Lanka (4):
dt-bindings: clock: Add SDX65 GCC clock bindings
dt-bindings: clock: Introduce RPMHCC bindings for SDX65
clk: qcom: Add support for SDX65 RPMh clocks
dt-bindings: clock: Introduce pdc bindings for SDX65
.../bindings/clock/qcom,gcc-sdx65.yaml | 79 + .../bindings/clock/qcom,rpmhcc.yaml | 1 + .../interrupt-controller/qcom,pdc.txt | 1 + drivers/clk/qcom/Kconfig | 8 + drivers/clk/qcom/Makefile | 1 + drivers/clk/qcom/clk-alpha-pll.c | 170 ++ drivers/clk/qcom/clk-alpha-pll.h | 4 + drivers/clk/qcom/clk-rpmh.c | 27 + drivers/clk/qcom/gcc-sdx65.c | 1597 +++++++++++++++++ include/dt-bindings/clock/qcom,gcc-sdx65.h | 122 ++ 10 files changed, 2010 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-sdx65.yaml create mode 100644 drivers/clk/qcom/gcc-sdx65.c create mode 100644 include/dt-bindings/clock/qcom,gcc-sdx65.h
Signature · 1 line
2.32.0
PATCH v2 1/6 dt-bindings: clock: Add SDX65 GCC clock bindings
From: Vamsi krishna Lanka <[email protected]>
Add device tree bindings for global clock controller on SDX65 SOCs.
--- .../bindings/clock/qcom,gcc-sdx65.yaml | 79 ++++++++++++ include/dt-bindings/clock/qcom,gcc-sdx65.h | 122 ++++++++++++++++++ 2 files changed, 201 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-sdx65.yaml create mode 100644 include/dt-bindings/clock/qcom,gcc-sdx65.h
Documentation/devicetree/bindings/clock/qcom,gcc-sdx65.yaml new file +79 -0
@@ -0,0 +1,79 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/clock/qcom,gcc-sdx65.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm Global Clock & Reset Controller Binding for SDX65 + +maintainers: + - Vamsi krishna Lanka <[email protected]> + +description: | + Qualcomm global clock control module which supports the clocks, resets and + power domains on SDX65 + + See also: + - dt-bindings/clock/qcom,gcc-sdx65.h + +properties: + compatible: + const: qcom,gcc-sdx65 + + reg: + maxItems: 1 + + clocks: + items: + - description: Board XO source + - description: Board active XO source + - description: Sleep clock source + - description: PCIE Pipe clock source + - description: USB3 phy wrapper pipe clock source + - description: PLL test clock source (Optional clock) + + clock-names: + items: + - const: bi_tcxo + - const: bi_tcxo_ao + - const: sleep_clk + - const: pcie_pipe_clk + - const: usb3_phy_wrapper_gcc_usb30_pipe_clk + - const: core_bi_pll_test_se # Optional clock + + '#clock-cells': + const: 1 + + '#reset-cells': + const: 1 + + '#power-domain-cells': + const: 1 + +required: + - compatible + - reg + - clocks + - clock-names + - '#clock-cells' + - '#reset-cells' + - '#power-domain-cells' + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/qcom,rpmh.h> + clock-controller@100000 { + compatible = "qcom,gcc-sdx65"; + reg = <0x100000 0x1f7400>; + clocks = <&rpmhcc RPMH_CXO_CLK>, <&rpmhcc RPMH_CXO_CLK_A>, <&sleep_clk>, + <&pcie_pipe_clk>, <&usb3_phy_wrapper_gcc_usb30_pipe_clk>, <&pll_test_clk>; + clock-names = "bi_tcxo", "bi_tcxo_ao", "sleep_clk", + "pcie_pipe_clk", "usb3_phy_wrapper_gcc_usb30_pipe_clk", "core_bi_pll_test_se"; + #clock-cells = <1>; + #reset-cells = <1>; + #power-domain-cells = <1>; + }; + +...
include/dt-bindings/clock/qcom,gcc-sdx65.h new file +122 -0
122 lines not on this page · raw message
Signature · 1 line
2.32.0
Rob Herring
maintainerRe: [PATCH v2 1/6] dt-bindings: clock: Add SDX65 GCC clock bindings
Quoted 4 lines · On Thu, 22 Jul 2021 14:09:38 -0700, [email protected] wrote:
From: Vamsi krishna Lanka <[email protected]>
Add device tree bindings for global clock controller on SDX65 SOCs.
Quoted 8 lines
Signed-off-by Vamsi Krishna Lanka <[email protected]>--- .../bindings/clock/qcom,gcc-sdx65.yaml | 79 ++++++++++++ include/dt-bindings/clock/qcom,gcc-sdx65.h | 122 ++++++++++++++++++ 2 files changed, 201 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-sdx65.yaml create mode 100644 include/dt-bindings/clock/qcom,gcc-sdx65.h
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
make[1]: *** Deleting file 'Documentation/devicetree/bindings/clock/qcom,gcc-sdx65.example.dts'
Traceback (most recent call last):
File "/usr/local/bin/dt-extract-example", line 45, in <module>
binding = yaml.load(open(args.yamlfile, encoding='utf-8').read())
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line 434, in load
return constructor.get_single_data()
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 120, in get_single_data
node = self.composer.get_single_node()
File "_ruamel_yaml.pyx", line 706, in _ruamel_yaml.CParser.get_single_node
File "_ruamel_yaml.pyx", line 724, in _ruamel_yaml.CParser._compose_document
File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
File "_ruamel_yaml.pyx", line 773, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 848, in _ruamel_yaml.CParser._compose_sequence_node
File "_ruamel_yaml.pyx", line 904, in _ruamel_yaml.CParser._parse_next_event
ruamel.yaml.scanner.ScannerError: while scanning a block scalar
in "<unicode string>", line 65, column 5
found a tab character where an indentation space is expected
in "<unicode string>", line 71, column 1
make[1]: *** [Documentation/devicetree/bindings/Makefile:20: Documentation/devicetree/bindings/clock/qcom,gcc-sdx65.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs...../Documentation/devicetree/bindings/clock/qcom,gcc-sdx65.yaml: while scanning a block scalar
in "<unicode string>", line 65, column 5
found a tab character where an indentation space is expected
in "<unicode string>", line 71, column 1
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/qcom,gcc-sdx65.yaml: ignoring, error parsing file
warning: no schema found in file: ./Documentation/devicetree/bindings/clock/qcom,gcc-sdx65.yaml
make: *** [Makefile:1418: dt_binding_check] Error 2
\ndoc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1508862
This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
PATCH v2 2/6 clk: qcom: Add new PLL type for SDX65
In reply to [email protected]From: Vamsi Krishna Lanka <[email protected]>
Add a new PLL type for SDX65 SoC from Qualcomm.
--- drivers/clk/qcom/clk-alpha-pll.c | 170 +++++++++++++++++++++++++++++++ drivers/clk/qcom/clk-alpha-pll.h | 4 + 2 files changed, 174 insertions(+)
drivers/clk/qcom/clk-alpha-pll.c +170 -0
@@ -1,5 +1,6 @@// SPDX-License-Identifier: GPL-2.0 /* +* Copyright (c) 2021, Qualcomm Innovation Center, Inc. All rights reserved. * Copyright (c) 2015, 2018, The Linux Foundation. All rights reserved. */
@@ -126,6 +127,20 @@ const u8 clk_alpha_pll_regs[][PLL_OFF_MAX_REGS] = { [PLL_OFF_TEST_CTL_U] = 0x1c, [PLL_OFF_STATUS] = 0x2c, }, + [CLK_ALPHA_PLL_TYPE_LUCID_EVO] = { + [PLL_OFF_OPMODE] = 0x04, + [PLL_OFF_STATUS] = 0x0c, + [PLL_OFF_L_VAL] = 0x10, + [PLL_OFF_ALPHA_VAL] = 0x14, + [PLL_OFF_USER_CTL] = 0x18, + [PLL_OFF_USER_CTL_U] = 0x1c, + [PLL_OFF_CONFIG_CTL] = 0x20, + [PLL_OFF_CONFIG_CTL_U] = 0x24, + [PLL_OFF_CONFIG_CTL_U1] = 0x28, + [PLL_OFF_TEST_CTL] = 0x2c, + [PLL_OFF_TEST_CTL_U] = 0x30, + [PLL_OFF_TEST_CTL_U1] = 0x34, + }, };EXPORT_SYMBOL_GPL (clk_alpha_pll_regs);
@@ -155,12 +170,14 @@ EXPORT_SYMBOL_GPL(clk_alpha_pll_regs);/* LUCID PLL specific settings and offsets */ #define LUCID_PCAL_DONE BIT(27) +#define LUCID_EVO_PLL_L_VAL_MASK GENMASK(15, 0)/* LUCID 5LPE PLL specific settings and offsets */ #define LUCID_5LPE_PCAL_DONE BIT(11)#define LUCID_5LPE_ALPHA_PLL_ACK_LATCH BIT(13)#define LUCID_5LPE_PLL_LATCH_INPUT BIT(14)#define LUCID_5LPE_ENABLE_VOTE_RUN BIT(21) +#define LUCID_EVO_ENABLE_VOTE_RUN BIT(25)#define pll_alpha_width (p) \ ((PLL_ALPHA_VAL_U(p) - PLL_ALPHA_VAL(p) == 4) ? \
@@ -1777,3 +1794,156 @@ const struct clk_ops clk_alpha_pll_postdiv_lucid_5lpe_ops = { .set_rate = clk_lucid_5lpe_pll_postdiv_set_rate, };EXPORT_SYMBOL (clk_alpha_pll_postdiv_lucid_5lpe_ops); + +static int alpha_pll_lucid_evo_enable (struct clk_hw *hw) +{ +struct clk_alpha_pll *pll =to_clk_alpha_pll (hw); +u32 val; +int ret; + + ret =regmap_read (pll->clkr.regmap,PLL_USER_CTL (pll), &val); +if (ret) +return ret; + +/* If in FSM mode, just vote for it */ +if (val &LUCID_EVO_ENABLE_VOTE_RUN ) { + ret =clk_enable_regmap (hw); +if (ret) +return ret; +return wait_for_pll_enable_lock (pll); + } + +/* Check if PLL is already enabled */ + ret =trion_pll_is_enabled (pll, pll->clkr.regmap); +if (ret <0 ) +return ret; +else if (ret) { +pr_warn ("%s PLL is already enabled\n" , +clk_hw_get_name (&pll->clkr.hw)); +return 0 ; + } + + ret =regmap_update_bits (pll->clkr.regmap,PLL_MODE (pll), +PLL_RESET_N ,PLL_RESET_N ); +if (ret) +return ret; + +/* Set operation mode to RUN */ +regmap_write (pll->clkr.regmap,PLL_OPMODE (pll),PLL_RUN ); + + ret =wait_for_pll_enable_lock (pll); +if (ret) +return ret; + +/* Enable the PLL outputs */ + ret =regmap_update_bits (pll->clkr.regmap,PLL_USER_CTL (pll), +PLL_OUT_MASK ,PLL_OUT_MASK ); +if (ret) +return ret; + +/* Enable the global PLL outputs */ + ret =regmap_update_bits (pll->clkr.regmap,PLL_MODE (pll), +PLL_OUTCTRL ,PLL_OUTCTRL ); +if (ret) +return ret; + +/* Ensure that the write above goes through before returning. */ +mb (); +return ret; +} + +static void alpha_pll_lucid_evo_disable (struct clk_hw *hw) +{ +struct clk_alpha_pll *pll =to_clk_alpha_pll (hw); +u32 val; +int ret; + + ret =regmap_read (pll->clkr.regmap,PLL_USER_CTL (pll), &val); +if (ret) +return ; + +/* If in FSM mode, just unvote it */ +if (val &LUCID_EVO_ENABLE_VOTE_RUN ) { +clk_disable_regmap (hw); +return ; + } + +/* Disable the global PLL output */ + ret =regmap_update_bits (pll->clkr.regmap,PLL_MODE (pll), +PLL_OUTCTRL ,0 ); +if (ret) +return ; + +/* Disable the PLL outputs */ + ret =regmap_update_bits (pll->clkr.regmap,PLL_USER_CTL (pll), +PLL_OUT_MASK ,0 ); +if (ret) +return ; + +/* Place the PLL mode in STANDBY */ +regmap_write (pll->clkr.regmap,PLL_OPMODE (pll), +PLL_STANDBY ); +} + +static unsigned long alpha_pll_lucid_evo_recalc_rate (struct clk_hw *hw,unsigned long parent_rate) +{ +struct clk_alpha_pll *pll =to_clk_alpha_pll (hw); +u32 l, frac; + +regmap_read (pll->clkr.regmap,PLL_L_VAL (pll), &l); + l &=LUCID_EVO_PLL_L_VAL_MASK ; +regmap_read (pll->clkr.regmap,PLL_ALPHA_VAL (pll), &frac); + +return alpha_pll_calc_rate (parent_rate, l, frac,ALPHA_REG_16BIT_WIDTH ); +} + +static int clk_lucid_evo_pll_postdiv_set_rate (struct clk_hw *hw, +unsigned long rate,unsigned long parent_rate) +{ +struct clk_alpha_pll_postdiv *pll =to_clk_alpha_pll_postdiv (hw); +int i, val =0 , div, ret; + +/* +* If the PLL is in FSM mode, then treat set_rate callback as a +* no-operation. +*/ + ret =regmap_read (pll->clkr.regmap,PLL_USER_CTL (pll), &val); +if (ret) +return ret; + +if (val &LUCID_EVO_ENABLE_VOTE_RUN ) +return 0 ; + +if (!pll->post_div_table) { +pr_err ("Missing the post_div_table for the PLL\n" ); +return -EINVAL ; + } + + div =DIV_ROUND_UP_ULL ((u64 )parent_rate, rate); +for (i =0 ; i < pll->num_post_div; i++) { +if (pll->post_div_table[i].div == div) { + val = pll->post_div_table[i].val; +break ; + } + } + +return regmap_update_bits (pll->clkr.regmap,PLL_USER_CTL (pll), + (BIT (pll->width) -1 ) << pll->post_div_shift, + val << pll->post_div_shift); +} + +const struct clk_ops clk_alpha_pll_fixed_lucid_evo_ops = { + .enable = alpha_pll_lucid_evo_enable, + .disable = alpha_pll_lucid_evo_disable, + .is_enabled = clk_trion_pll_is_enabled, + .recalc_rate = alpha_pll_lucid_evo_recalc_rate, + .round_rate = clk_alpha_pll_round_rate, +}; +EXPORT_SYMBOL_GPL (clk_alpha_pll_fixed_lucid_evo_ops); + +const struct clk_ops clk_alpha_pll_postdiv_lucid_evo_ops = { + .recalc_rate = clk_alpha_pll_postdiv_fabia_recalc_rate, + .round_rate = clk_alpha_pll_postdiv_fabia_round_rate, + .set_rate = clk_lucid_evo_pll_postdiv_set_rate, +}; +EXPORT_SYMBOL_GPL (clk_alpha_pll_postdiv_lucid_evo_ops);
drivers/clk/qcom/clk-alpha-pll.h +4 -0
@@ -16,6 +16,7 @@ enum {CLK_ALPHA_PLL_TYPE_TRION ,CLK_ALPHA_PLL_TYPE_LUCID =CLK_ALPHA_PLL_TYPE_TRION ,CLK_ALPHA_PLL_TYPE_AGERA , +CLK_ALPHA_PLL_TYPE_LUCID_EVO , CLK_ALPHA_PLL_TYPE_MAX, };
@@ -148,6 +149,9 @@ extern const struct clk_ops clk_alpha_pll_lucid_5lpe_ops;extern const struct clk_ops clk_alpha_pll_fixed_lucid_5lpe_ops;extern const struct clk_ops clk_alpha_pll_postdiv_lucid_5lpe_ops; +extern const struct clk_ops clk_alpha_pll_fixed_lucid_evo_ops; +extern const struct clk_ops clk_alpha_pll_postdiv_lucid_evo_ops; +void clk_alpha_pll_configure (struct clk_alpha_pll *pll,struct regmap *regmap,const struct alpha_pll_config *config); void clk_fabia_pll_configure(struct clk_alpha_pll *pll, struct regmap *regmap,
Signature · 1 line
2.32.0
Re: [PATCH v2 2/6] clk: qcom: Add new PLL type for SDX65
Quoted 43 lines · On 7/23/2021 2:39 AM, [email protected] wrote:
From: Vamsi Krishna Lanka <[email protected]>
Add a new PLL type for SDX65 SoC from Qualcomm.
Signed-off-by Vamsi Krishna Lanka <[email protected]>--- drivers/clk/qcom/clk-alpha-pll.c | 170 +++++++++++++++++++++++++++++++ drivers/clk/qcom/clk-alpha-pll.h | 4 + 2 files changed, 174 insertions(+)drivers/clk/qcom/clk-alpha-pll.c +15
-0@@ -1,5 +1,6 @@// SPDX-License-Identifier: GPL-2.0 /* +* Copyright (c) 2021, Qualcomm Innovation Center, Inc. All rights reserved. * Copyright (c) 2015, 2018, The Linux Foundation. All rights reserved. */ @@ -126,6 +127,20 @@ const u8 clk_alpha_pll_regs[][PLL_OFF_MAX_REGS] = { [PLL_OFF_TEST_CTL_U] = 0x1c, [PLL_OFF_STATUS] = 0x2c, }, + [CLK_ALPHA_PLL_TYPE_LUCID_EVO] = { + [PLL_OFF_OPMODE] = 0x04, + [PLL_OFF_STATUS] = 0x0c, + [PLL_OFF_L_VAL] = 0x10, + [PLL_OFF_ALPHA_VAL] = 0x14, + [PLL_OFF_USER_CTL] = 0x18, + [PLL_OFF_USER_CTL_U] = 0x1c, + [PLL_OFF_CONFIG_CTL] = 0x20, + [PLL_OFF_CONFIG_CTL_U] = 0x24, + [PLL_OFF_CONFIG_CTL_U1] = 0x28, + [PLL_OFF_TEST_CTL] = 0x2c, + [PLL_OFF_TEST_CTL_U] = 0x30, + [PLL_OFF_TEST_CTL_U1] = 0x34, + }, };EXPORT_SYMBOL_GPL (clk_alpha_pll_regs);
drivers/clk/qcom/clk-alpha-pll.c EXPORT_SYMBOL_GPL(clk_alpha_pll_regs); · line 179
Quoted 10 lines
drivers/clk/qcom/clk-alpha-pll.c +1
-0@@ -155,12 +170,14 @@ EXPORT_SYMBOL_GPL(clk_alpha_pll_regs);/* LUCID PLL specific settings and offsets */ #define LUCID_PCAL_DONE BIT(27) +#define LUCID_EVO_PLL_L_VAL_MASK GENMASK(15, 0)/* LUCID 5LPE PLL specific settings and offsets */ #define LUCID_5LPE_PCAL_DONE BIT(11)#define LUCID_5LPE_ALPHA_PLL_ACK_LATCH BIT(13)#define LUCID_5LPE_PLL_LATCH_INPUT BIT(14)#define LUCID_5LPE_ENABLE_VOTE_RUN BIT(21)
Please add a comment
/* LUCID EVO PLL specific settings and offsets */
Quoted 99 lines
drivers/clk/qcom/clk-alpha-pll.c +92
-0+#define LUCID_EVO_ENABLE_VOTE_RUN BIT(25)#define pll_alpha_width (p) \ ((PLL_ALPHA_VAL_U(p) - PLL_ALPHA_VAL(p) == 4) ? \@@ -1777,3 +1794,156 @@ const struct clk_ops clk_alpha_pll_postdiv_lucid_5lpe_ops = { .set_rate = clk_lucid_5lpe_pll_postdiv_set_rate, };EXPORT_SYMBOL (clk_alpha_pll_postdiv_lucid_5lpe_ops); + +static int alpha_pll_lucid_evo_enable (struct clk_hw *hw) +{ +struct clk_alpha_pll *pll =to_clk_alpha_pll (hw); +u32 val; +int ret; + + ret =regmap_read (pll->clkr.regmap,PLL_USER_CTL (pll), &val); +if (ret) +return ret; + +/* If in FSM mode, just vote for it */ +if (val &LUCID_EVO_ENABLE_VOTE_RUN ) { + ret =clk_enable_regmap (hw); +if (ret) +return ret; +return wait_for_pll_enable_lock (pll); + } + +/* Check if PLL is already enabled */ + ret =trion_pll_is_enabled (pll, pll->clkr.regmap); +if (ret <0 ) +return ret; +else if (ret) { +pr_warn ("%s PLL is already enabled\n" , +clk_hw_get_name (&pll->clkr.hw)); +return 0 ; + } + + ret =regmap_update_bits (pll->clkr.regmap,PLL_MODE (pll), +PLL_RESET_N ,PLL_RESET_N ); +if (ret) +return ret; + +/* Set operation mode to RUN */ +regmap_write (pll->clkr.regmap,PLL_OPMODE (pll),PLL_RUN ); + + ret =wait_for_pll_enable_lock (pll); +if (ret) +return ret; + +/* Enable the PLL outputs */ + ret =regmap_update_bits (pll->clkr.regmap,PLL_USER_CTL (pll), +PLL_OUT_MASK ,PLL_OUT_MASK ); +if (ret) +return ret; + +/* Enable the global PLL outputs */ + ret =regmap_update_bits (pll->clkr.regmap,PLL_MODE (pll), +PLL_OUTCTRL ,PLL_OUTCTRL ); +if (ret) +return ret; + +/* Ensure that the write above goes through before returning. */ +mb (); +return ret; +} + +static void alpha_pll_lucid_evo_disable (struct clk_hw *hw) +{ +struct clk_alpha_pll *pll =to_clk_alpha_pll (hw); +u32 val; +int ret; + + ret =regmap_read (pll->clkr.regmap,PLL_USER_CTL (pll), &val); +if (ret) +return ; + +/* If in FSM mode, just unvote it */ +if (val &LUCID_EVO_ENABLE_VOTE_RUN ) { +clk_disable_regmap (hw); +return ; + } + +/* Disable the global PLL output */ + ret =regmap_update_bits (pll->clkr.regmap,PLL_MODE (pll), +PLL_OUTCTRL ,0 ); +if (ret) +return ; + +/* Disable the PLL outputs */ + ret =regmap_update_bits (pll->clkr.regmap,PLL_USER_CTL (pll), +PLL_OUT_MASK ,0 ); +if (ret) +return ; + +/* Place the PLL mode in STANDBY */ +regmap_write (pll->clkr.regmap,PLL_OPMODE (pll), +PLL_STANDBY ); +} +
drivers/clk/qcom/clk-alpha-pll.c const struct clk_ops clk_alpha_pll_postdiv_lucid_5lpe_ops = { · line 1897
Quoted 10 lines
drivers/clk/qcom/clk-alpha-pll.c +10
-0+static unsigned long alpha_pll_lucid_evo_recalc_rate (struct clk_hw *hw,unsigned long parent_rate) +{ +struct clk_alpha_pll *pll =to_clk_alpha_pll (hw); +u32 l, frac; + +regmap_read (pll->clkr.regmap,PLL_L_VAL (pll), &l); + l &=LUCID_EVO_PLL_L_VAL_MASK ; +regmap_read (pll->clkr.regmap,PLL_ALPHA_VAL (pll), &frac); + +return alpha_pll_calc_rate (parent_rate, l, frac,ALPHA_REG_16BIT_WIDTH );
Can you please use "pll_alpha_width(pll)".
drivers/clk/qcom/clk-alpha-pll.c const struct clk_ops clk_alpha_pll_postdiv_lucid_5lpe_ops = { · line 1904
Quoted 7 lines
drivers/clk/qcom/clk-alpha-pll.c +7
-0+} + +static int clk_lucid_evo_pll_postdiv_set_rate (struct clk_hw *hw, +unsigned long rate,unsigned long parent_rate) +{ +struct clk_alpha_pll_postdiv *pll =to_clk_alpha_pll_postdiv (hw); +int i, val =0 , div, ret;
'val' not required to be initialized.
Quoted 68 lines
drivers/clk/qcom/clk-alpha-pll.c +45
-0+ +/* +* If the PLL is in FSM mode, then treat set_rate callback as a +* no-operation. +*/ + ret =regmap_read (pll->clkr.regmap,PLL_USER_CTL (pll), &val); +if (ret) +return ret; + +if (val &LUCID_EVO_ENABLE_VOTE_RUN ) +return 0 ; + +if (!pll->post_div_table) { +pr_err ("Missing the post_div_table for the PLL\n" ); +return -EINVAL ; + } + + div =DIV_ROUND_UP_ULL ((u64 )parent_rate, rate); +for (i =0 ; i < pll->num_post_div; i++) { +if (pll->post_div_table[i].div == div) { + val = pll->post_div_table[i].val; +break ; + } + } + +return regmap_update_bits (pll->clkr.regmap,PLL_USER_CTL (pll), + (BIT (pll->width) -1 ) << pll->post_div_shift, + val << pll->post_div_shift); +} + +const struct clk_ops clk_alpha_pll_fixed_lucid_evo_ops = { + .enable = alpha_pll_lucid_evo_enable, + .disable = alpha_pll_lucid_evo_disable, + .is_enabled = clk_trion_pll_is_enabled, + .recalc_rate = alpha_pll_lucid_evo_recalc_rate, + .round_rate = clk_alpha_pll_round_rate, +}; +EXPORT_SYMBOL_GPL (clk_alpha_pll_fixed_lucid_evo_ops); + +const struct clk_ops clk_alpha_pll_postdiv_lucid_evo_ops = { + .recalc_rate = clk_alpha_pll_postdiv_fabia_recalc_rate, + .round_rate = clk_alpha_pll_postdiv_fabia_round_rate, + .set_rate = clk_lucid_evo_pll_postdiv_set_rate, +}; +EXPORT_SYMBOL_GPL (clk_alpha_pll_postdiv_lucid_evo_ops);drivers/clk/qcom/clk-alpha-pll.h +4
-0@@ -16,6 +16,7 @@ enum {CLK_ALPHA_PLL_TYPE_TRION ,CLK_ALPHA_PLL_TYPE_LUCID =CLK_ALPHA_PLL_TYPE_TRION ,CLK_ALPHA_PLL_TYPE_AGERA , +CLK_ALPHA_PLL_TYPE_LUCID_EVO , CLK_ALPHA_PLL_TYPE_MAX, };@@ -148,6 +149,9 @@ extern const struct clk_ops clk_alpha_pll_lucid_5lpe_ops;extern const struct clk_ops clk_alpha_pll_fixed_lucid_5lpe_ops;extern const struct clk_ops clk_alpha_pll_postdiv_lucid_5lpe_ops; +extern const struct clk_ops clk_alpha_pll_fixed_lucid_evo_ops; +extern const struct clk_ops clk_alpha_pll_postdiv_lucid_evo_ops; +void clk_alpha_pll_configure (struct clk_alpha_pll *pll,struct regmap *regmap,const struct alpha_pll_config *config); void clk_fabia_pll_configure(struct clk_alpha_pll *pll, struct regmap *regmap,
Signature · 4 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation. --
Re: [PATCH v2 2/6] clk: qcom: Add new PLL type for SDX65
In reply to [email protected]Hello Vamsi,
Quoted 1 line · On 22-07-21, 14:09, [email protected] wrote:
From: Vamsi Krishna Lanka <[email protected]>
Can you please add the type of pll in patch title. Something like Add LUCID_EVO pll
Quoted 57 lines
Add a new PLL type for SDX65 SoC from Qualcomm.
Signed-off-by Vamsi Krishna Lanka <[email protected]>--- drivers/clk/qcom/clk-alpha-pll.c | 170 +++++++++++++++++++++++++++++++ drivers/clk/qcom/clk-alpha-pll.h | 4 + 2 files changed, 174 insertions(+)drivers/clk/qcom/clk-alpha-pll.c +17
-0@@ -1,5 +1,6 @@// SPDX-License-Identifier: GPL-2.0 /* +* Copyright (c) 2021, Qualcomm Innovation Center, Inc. All rights reserved. * Copyright (c) 2015, 2018, The Linux Foundation. All rights reserved. */ @@ -126,6 +127,20 @@ const u8 clk_alpha_pll_regs[][PLL_OFF_MAX_REGS] = { [PLL_OFF_TEST_CTL_U] = 0x1c, [PLL_OFF_STATUS] = 0x2c, }, + [CLK_ALPHA_PLL_TYPE_LUCID_EVO] = { + [PLL_OFF_OPMODE] = 0x04, + [PLL_OFF_STATUS] = 0x0c, + [PLL_OFF_L_VAL] = 0x10, + [PLL_OFF_ALPHA_VAL] = 0x14, + [PLL_OFF_USER_CTL] = 0x18, + [PLL_OFF_USER_CTL_U] = 0x1c, + [PLL_OFF_CONFIG_CTL] = 0x20, + [PLL_OFF_CONFIG_CTL_U] = 0x24, + [PLL_OFF_CONFIG_CTL_U1] = 0x28, + [PLL_OFF_TEST_CTL] = 0x2c, + [PLL_OFF_TEST_CTL_U] = 0x30, + [PLL_OFF_TEST_CTL_U1] = 0x34, + }, };EXPORT_SYMBOL_GPL (clk_alpha_pll_regs);@@ -155,12 +170,14 @@ EXPORT_SYMBOL_GPL(clk_alpha_pll_regs);/* LUCID PLL specific settings and offsets */ #define LUCID_PCAL_DONE BIT(27) +#define LUCID_EVO_PLL_L_VAL_MASK GENMASK(15, 0)/* LUCID 5LPE PLL specific settings and offsets */ #define LUCID_5LPE_PCAL_DONE BIT(11)#define LUCID_5LPE_ALPHA_PLL_ACK_LATCH BIT(13)#define LUCID_5LPE_PLL_LATCH_INPUT BIT(14)#define LUCID_5LPE_ENABLE_VOTE_RUN BIT(21) +#define LUCID_EVO_ENABLE_VOTE_RUN BIT(25)#define pll_alpha_width (p) \ ((PLL_ALPHA_VAL_U(p) - PLL_ALPHA_VAL(p) == 4) ? \
drivers/clk/qcom/clk-alpha-pll.c const struct clk_ops clk_alpha_pll_postdiv_lucid_5lpe_ops = { · line 1800
Quoted 7 lines
drivers/clk/qcom/clk-alpha-pll.c +4
-0@@ -1777,3 +1794,156 @@ const struct clk_ops clk_alpha_pll_postdiv_lucid_5lpe_ops = { .set_rate = clk_lucid_5lpe_pll_postdiv_set_rate, };EXPORT_SYMBOL (clk_alpha_pll_postdiv_lucid_5lpe_ops); + +static int alpha_pll_lucid_evo_enable (struct clk_hw *hw) +{ +struct clk_alpha_pll *pll =to_clk_alpha_pll (hw);
Use a regmap ptr like we do for other functions here?
Quoted 17 lines
drivers/clk/qcom/clk-alpha-pll.c +17
-0+u32 val; +int ret; + + ret =regmap_read (pll->clkr.regmap,PLL_USER_CTL (pll), &val); +if (ret) +return ret; + +/* If in FSM mode, just vote for it */ +if (val &LUCID_EVO_ENABLE_VOTE_RUN ) { + ret =clk_enable_regmap (hw); +if (ret) +return ret; +return wait_for_pll_enable_lock (pll); + } + +/* Check if PLL is already enabled */ + ret =trion_pll_is_enabled (pll, pll->clkr.regmap);
drivers/clk/qcom/clk-alpha-pll.c const struct clk_ops clk_alpha_pll_postdiv_lucid_5lpe_ops = { · line 1827
Quoted 10 lines
drivers/clk/qcom/clk-alpha-pll.c +10
-0+if (ret <0 ) +return ret; +else if (ret) { +pr_warn ("%s PLL is already enabled\n" , +clk_hw_get_name (&pll->clkr.hw)); +return 0 ; + } + + ret =regmap_update_bits (pll->clkr.regmap,PLL_MODE (pll), +PLL_RESET_N ,PLL_RESET_N );
this and others should fit in a single line (with regmap ptr)
Quoted 14 lines
drivers/clk/qcom/clk-alpha-pll.c +14
-0+if (ret) +return ret; + +/* Set operation mode to RUN */ +regmap_write (pll->clkr.regmap,PLL_OPMODE (pll),PLL_RUN ); + + ret =wait_for_pll_enable_lock (pll); +if (ret) +return ret; + +/* Enable the PLL outputs */ + ret =regmap_update_bits (pll->clkr.regmap,PLL_USER_CTL (pll), +PLL_OUT_MASK ,PLL_OUT_MASK ); +if (ret)
drivers/clk/qcom/clk-alpha-pll.c const struct clk_ops clk_alpha_pll_postdiv_lucid_5lpe_ops = { · line 1851
Quoted 10 lines
drivers/clk/qcom/clk-alpha-pll.c +10
-0+return ret; + +/* Enable the global PLL outputs */ + ret =regmap_update_bits (pll->clkr.regmap,PLL_MODE (pll), +PLL_OUTCTRL ,PLL_OUTCTRL ); +if (ret) +return ret; + +/* Ensure that the write above goes through before returning. */ +mb ();
why is this required?
drivers/clk/qcom/clk-alpha-pll.c const struct clk_ops clk_alpha_pll_postdiv_lucid_5lpe_ops = { · line 1857
Quoted 6 lines
drivers/clk/qcom/clk-alpha-pll.c +6
-0+return ret; +} + +static void alpha_pll_lucid_evo_disable (struct clk_hw *hw) +{ +struct clk_alpha_pll *pll =to_clk_alpha_pll (hw);
regmap here too
Quoted 21 lines
drivers/clk/qcom/clk-alpha-pll.c +21
-0+u32 val; +int ret; + + ret =regmap_read (pll->clkr.regmap,PLL_USER_CTL (pll), &val); +if (ret) +return ; + +/* If in FSM mode, just unvote it */ +if (val &LUCID_EVO_ENABLE_VOTE_RUN ) { +clk_disable_regmap (hw); +return ; + } + +/* Disable the global PLL output */ + ret =regmap_update_bits (pll->clkr.regmap,PLL_MODE (pll), +PLL_OUTCTRL ,0 ); +if (ret) +return ; + +/* Disable the PLL outputs */ + ret = regmap_update_bits(pll->clkr.regmap, PLL_USER_CTL(pll),
drivers/clk/qcom/clk-alpha-pll.c const struct clk_ops clk_alpha_pll_postdiv_lucid_5lpe_ops = { · line 1888
Quoted 10 lines
drivers/clk/qcom/clk-alpha-pll.c +10
-0+ PLL_OUT_MASK, 0); +if (ret) +return ; + +/* Place the PLL mode in STANDBY */ +regmap_write (pll->clkr.regmap,PLL_OPMODE (pll), +PLL_STANDBY ); +} + +static unsigned long alpha_pll_lucid_evo_recalc_rate (struct clk_hw *hw,unsigned long parent_rate)
too long pls split to two lines!
drivers/clk/qcom/clk-alpha-pll.c const struct clk_ops clk_alpha_pll_postdiv_lucid_5lpe_ops = { · line 1898
Quoted 10 lines
drivers/clk/qcom/clk-alpha-pll.c +10
-0+{ +struct clk_alpha_pll *pll =to_clk_alpha_pll (hw); +u32 l, frac; + +regmap_read (pll->clkr.regmap,PLL_L_VAL (pll), &l); + l &=LUCID_EVO_PLL_L_VAL_MASK ; +regmap_read (pll->clkr.regmap,PLL_ALPHA_VAL (pll), &frac); + +return alpha_pll_calc_rate (parent_rate, l, frac,ALPHA_REG_16BIT_WIDTH ); +}
looks like you should reuse clk_trion_pll_recalc_rate() instead...
Quoted 25 lines
drivers/clk/qcom/clk-alpha-pll.c +25
-0+ +static int clk_lucid_evo_pll_postdiv_set_rate (struct clk_hw *hw, +unsigned long rate,unsigned long parent_rate) +{ +struct clk_alpha_pll_postdiv *pll =to_clk_alpha_pll_postdiv (hw); +int i, val =0 , div, ret; + +/* +* If the PLL is in FSM mode, then treat set_rate callback as a +* no-operation. +*/ + ret =regmap_read (pll->clkr.regmap,PLL_USER_CTL (pll), &val); +if (ret) +return ret; + +if (val &LUCID_EVO_ENABLE_VOTE_RUN ) +return 0 ; + +if (!pll->post_div_table) { +pr_err ("Missing the post_div_table for the PLL\n" ); +return -EINVAL ; + } + + div =DIV_ROUND_UP_ULL ((u64 )parent_rate, rate); +for (i =0 ; i < pll->num_post_div; i++) {
drivers/clk/qcom/clk-alpha-pll.c const struct clk_ops clk_alpha_pll_postdiv_lucid_5lpe_ops = { · line 1933
Quoted 10 lines
drivers/clk/qcom/clk-alpha-pll.c +10
-0+if (pll->post_div_table[i].div == div) { + val = pll->post_div_table[i].val; +break ; + } + } + +return regmap_update_bits (pll->clkr.regmap,PLL_USER_CTL (pll), + (BIT (pll->width) -1 ) << pll->post_div_shift, + val << pll->post_div_shift); +}
clk_lucid_5lpe_pll_postdiv_set_rate() looks similar?
Signature · 1 line
~Vinod
PATCH v2 3/6 clk: qcom: Add SDX65 GCC support
In reply to [email protected]From: Vamsi Krishna Lanka <[email protected]>
Add Global Clock Controller (GCC) support for SDX65 SoCs from Qualcomm.
--- drivers/clk/qcom/Kconfig | 8 + drivers/clk/qcom/Makefile | 1 + drivers/clk/qcom/gcc-sdx65.c | 1597 ++++++++++++++++++++++++++++++++++ 3 files changed, 1606 insertions(+) create mode 100644 drivers/clk/qcom/gcc-sdx65.c
drivers/clk/qcom/Kconfig +8 -0
@@ -483,6 +483,14 @@ config SDX_GCC_55 Say Y if you want to use peripheral devices such as UART, SPI, I2C, USB, SD/UFS, PCIe etc. +config SDX_GCC_65 + tristate "SDX65 Global Clock Controller" + select QCOM_GDSC + help + Support for the global clock controller on SDX65 devices. + Say Y if you want to use peripheral devices such as UART, + SPI, I2C, USB, SD/UFS, PCIe etc. + config SM_DISPCC_8250 tristate "SM8150 and SM8250 Display Clock Controller" depends on SM_GCC_8150 || SM_GCC_8250
drivers/clk/qcom/Makefile +1 -0
@@ -73,6 +73,7 @@ obj-$(CONFIG_SDM_GPUCC_845) += gpucc-sdm845.o obj-$(CONFIG_SDM_LPASSCC_845) += lpasscc-sdm845.o obj-$(CONFIG_SDM_VIDEOCC_845) += videocc-sdm845.o obj-$(CONFIG_SDX_GCC_55) += gcc-sdx55.o +obj-$(CONFIG_SDX_GCC_65) += gcc-sdx65.o obj-$(CONFIG_SM_DISPCC_8250) += dispcc-sm8250.o obj-$(CONFIG_SM_GCC_8150) += gcc-sm8150.o obj-$(CONFIG_SM_GCC_8250) += gcc-sm8250.o
drivers/clk/qcom/gcc-sdx65.c new file +1597 -0
1,597 lines not on this page · raw message
Signature · 1 line
2.32.0
PATCH v2 4/6 dt-bindings: clock: Introduce RPMHCC bindings for SDX65
In reply to [email protected]From: Vamsi krishna Lanka <[email protected]>
Add compatible for SDX65 RPMHCC.
--- Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml +1 -0
@@ -22,6 +22,7 @@ properties: - qcom,sc8180x-rpmh-clk - qcom,sdm845-rpmh-clk - qcom,sdx55-rpmh-clk + - qcom,sdx65-rpmh-clk - qcom,sm8150-rpmh-clk - qcom,sm8250-rpmh-clk - qcom,sm8350-rpmh-clk
Signature · 1 line
2.32.0
Re: [PATCH v2 4/6] dt-bindings: clock: Introduce RPMHCC bindings for SDX65
Quoted 10 lines · On Thu, 22 Jul 2021 14:09:41 -0700, [email protected] wrote:
From: Vamsi krishna Lanka <[email protected]>
Add compatible for SDX65 RPMHCC.
Signed-off-by Vamsi Krishna Lanka <[email protected]>Reviewed-by Bjorn Andersson <[email protected]>--- Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml | 1 + 1 file changed, 1 insertion(+)
PATCH v2 5/6 clk: qcom: Add support for SDX65 RPMh clocks
In reply to [email protected]From: Vamsi krishna Lanka <[email protected]>
Add support for clocks maintained by RPMh in SDX65 SoCs.
--- drivers/clk/qcom/clk-rpmh.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+)
drivers/clk/qcom/clk-rpmh.c +27 -0
@@ -477,6 +477,32 @@ static const struct clk_rpmh_desc clk_rpmh_sm8250 = { .num_clks = ARRAY_SIZE(sm8250_rpmh_clocks), }; +DEFINE_CLK_RPMH_ARC (sdx65, bi_tcxo, bi_tcxo_ao,"xo.lvl" ,0x3 ,4 ); +DEFINE_CLK_RPMH_VRM (sdx65, ln_bb_clk1, ln_bb_clk1_ao,"lnbclka1" ,4 ); +DEFINE_CLK_RPMH_VRM (sdx65, rf_clk4, rf_clk4_ao,"rfclka4" ,1 ); + +static struct clk_hw *sdx65_rpmh_clocks[] = { + [RPMH_CXO_CLK ] = &sdx65_bi_tcxo.hw, + [RPMH_CXO_CLK_A ] = &sdx65_bi_tcxo_ao.hw, + [RPMH_LN_BB_CLK1 ] = &sdx65_ln_bb_clk1.hw, + [RPMH_LN_BB_CLK1_A ] = &sdx65_ln_bb_clk1_ao.hw, + [RPMH_RF_CLK1 ] = &sdm845_rf_clk1.hw, + [RPMH_RF_CLK1_A ] = &sdm845_rf_clk1_ao.hw, + [RPMH_RF_CLK2 ] = &sdm845_rf_clk2.hw, + [RPMH_RF_CLK2_A ] = &sdm845_rf_clk2_ao.hw, + [RPMH_RF_CLK3 ] = &sdm845_rf_clk3.hw, + [RPMH_RF_CLK3_A ] = &sdm845_rf_clk3_ao.hw, + [RPMH_RF_CLK4 ] = &sdx65_rf_clk4.hw, + [RPMH_RF_CLK4_A ] = &sdx65_rf_clk4_ao.hw, + [RPMH_IPA_CLK ] = &sdm845_ipa.hw, + [RPMH_QPIC_CLK ] = &sdx55_qpic_clk.hw, +}; + +static const struct clk_rpmh_desc clk_rpmh_sdx65 = { + .clks = sdx65_rpmh_clocks, + .num_clks =ARRAY_SIZE (sdx65_rpmh_clocks), +}; +DEFINE_CLK_RPMH_VRM (sm8350, div_clk1, div_clk1_ao,"divclka1" ,2 );DEFINE_CLK_RPMH_VRM (sm8350, rf_clk4, rf_clk4_ao,"rfclka4" ,1 );DEFINE_CLK_RPMH_VRM (sm8350, rf_clk5, rf_clk5_ao,"rfclka5" ,1 );
@@ -618,6 +644,7 @@ static const struct of_device_id clk_rpmh_match_table[] = { { .compatible = "qcom,sc8180x-rpmh-clk", .data = &clk_rpmh_sc8180x}, { .compatible = "qcom,sdm845-rpmh-clk", .data = &clk_rpmh_sdm845}, { .compatible = "qcom,sdx55-rpmh-clk", .data = &clk_rpmh_sdx55}, + { .compatible = "qcom,sdx65-rpmh-clk", .data = &clk_rpmh_sdx65}, { .compatible = "qcom,sm8150-rpmh-clk", .data = &clk_rpmh_sm8150}, { .compatible = "qcom,sm8250-rpmh-clk", .data = &clk_rpmh_sm8250}, { .compatible = "qcom,sm8350-rpmh-clk", .data = &clk_rpmh_sm8350},
Signature · 1 line
2.32.0
Re: [PATCH v2 5/6] clk: qcom: Add support for SDX65 RPMh clocks
Quoted 15 lines · On 7/23/2021 2:39 AM, [email protected] wrote:
From: Vamsi krishna Lanka <[email protected]>
Add support for clocks maintained by RPMh in SDX65 SoCs.
Signed-off-by Vamsi Krishna Lanka <[email protected]>Acked-by Bjorn Andersson <[email protected]>--- drivers/clk/qcom/clk-rpmh.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+)drivers/clk/qcom/clk-rpmh.c +0
-0
drivers/clk/qcom/clk-rpmh.c static const struct clk_rpmh_desc clk_rpmh_sm8250 = { · line 480
Quoted 4 lines
drivers/clk/qcom/clk-rpmh.c +1
-0@@ -477,6 +477,32 @@ static const struct clk_rpmh_desc clk_rpmh_sm8250 = { .num_clks = ARRAY_SIZE(sm8250_rpmh_clocks), }; +DEFINE_CLK_RPMH_ARC (sdx65, bi_tcxo, bi_tcxo_ao,"xo.lvl" ,0x3 ,4 );
please re-use "sc7280" resources.
drivers/clk/qcom/clk-rpmh.c static const struct clk_rpmh_desc clk_rpmh_sm8250 = { · line 482
Quoted 2 lines
drivers/clk/qcom/clk-rpmh.c +2
-0+DEFINE_CLK_RPMH_VRM (sdx65, ln_bb_clk1, ln_bb_clk1_ao,"lnbclka1" ,4 ); +DEFINE_CLK_RPMH_VRM (sdx65, rf_clk4, rf_clk4_ao,"rfclka4" ,1 );
please re-use "sm8350" resources.
drivers/clk/qcom/clk-rpmh.c static const struct clk_rpmh_desc clk_rpmh_sm8250 = { · line 486
Quoted 4 lines
drivers/clk/qcom/clk-rpmh.c +4
-0+ +static struct clk_hw *sdx65_rpmh_clocks[] = { + [RPMH_CXO_CLK ] = &sdx65_bi_tcxo.hw, + [RPMH_CXO_CLK_A ] = &sdx65_bi_tcxo_ao.hw,
you can re-use sc7280 resources.
drivers/clk/qcom/clk-rpmh.c static const struct clk_rpmh_desc clk_rpmh_sm8250 = { · line 496
Quoted 10 lines
drivers/clk/qcom/clk-rpmh.c +10
-0+ [RPMH_LN_BB_CLK1] = &sdx65_ln_bb_clk1.hw, + [RPMH_LN_BB_CLK1_A] = &sdx65_ln_bb_clk1_ao.hw, + [RPMH_RF_CLK1] = &sdm845_rf_clk1.hw, + [RPMH_RF_CLK1_A] = &sdm845_rf_clk1_ao.hw, + [RPMH_RF_CLK2] = &sdm845_rf_clk2.hw, + [RPMH_RF_CLK2_A] = &sdm845_rf_clk2_ao.hw, + [RPMH_RF_CLK3] = &sdm845_rf_clk3.hw, + [RPMH_RF_CLK3_A] = &sdm845_rf_clk3_ao.hw, + [RPMH_RF_CLK4] = &sdx65_rf_clk4.hw, + [RPMH_RF_CLK4_A] = &sdx65_rf_clk4_ao.hw,
"sm8350"
Quoted 21 lines
drivers/clk/qcom/clk-rpmh.c +10
-0+ [RPMH_IPA_CLK] = &sdm845_ipa.hw, + [RPMH_QPIC_CLK] = &sdx55_qpic_clk.hw, +}; + +static const struct clk_rpmh_desc clk_rpmh_sdx65 = { + .clks = sdx65_rpmh_clocks, + .num_clks =ARRAY_SIZE (sdx65_rpmh_clocks), +}; +DEFINE_CLK_RPMH_VRM (sm8350, div_clk1, div_clk1_ao,"divclka1" ,2 );DEFINE_CLK_RPMH_VRM (sm8350, rf_clk4, rf_clk4_ao,"rfclka4" ,1 );DEFINE_CLK_RPMH_VRM (sm8350, rf_clk5, rf_clk5_ao,"rfclka5" ,1 );@@ -618,6 +644,7 @@ static const struct of_device_id clk_rpmh_match_table[] = { { .compatible = "qcom,sc8180x-rpmh-clk", .data = &clk_rpmh_sc8180x}, { .compatible = "qcom,sdm845-rpmh-clk", .data = &clk_rpmh_sdm845}, { .compatible = "qcom,sdx55-rpmh-clk", .data = &clk_rpmh_sdx55}, + { .compatible = "qcom,sdx65-rpmh-clk", .data = &clk_rpmh_sdx65}, { .compatible = "qcom,sm8150-rpmh-clk", .data = &clk_rpmh_sm8150}, { .compatible = "qcom,sm8250-rpmh-clk", .data = &clk_rpmh_sm8250}, { .compatible = "qcom,sm8350-rpmh-clk", .data = &clk_rpmh_sm8350},
Signature · 4 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation. --
PATCH v2 6/6 dt-bindings: clock: Introduce pdc bindings for SDX65
In reply to [email protected]From: Vamsi krishna Lanka <[email protected]>
Add compatible for SDX65 pdc.
To: Rob Herring <[email protected]>
--- .../devicetree/bindings/interrupt-controller/qcom,pdc.txt | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt +1 -0
@@ -22,6 +22,7 @@ Properties: - "qcom,sdm845-pdc": For SDM845 - "qcom,sdm8250-pdc": For SM8250 - "qcom,sdm8350-pdc": For SM8350 + - "qcom,sdx65-pdc": For SDX65 - reg: Usage: required
Signature · 1 line
2.32.0
Re: [PATCH v2 6/6] dt-bindings: clock: Introduce pdc bindings for SDX65
Quoted 13 lines · On Thu, 22 Jul 2021 14:09:43 -0700, [email protected] wrote:
From: Vamsi krishna Lanka <[email protected]>
Add compatible for SDX65 pdc.
To: Rob Herring <[email protected]>
Cc Mark Brown <[email protected]>Cc Jonathan Cameron <[email protected]>Cc Kozlowski <[email protected]>Cc Vinod Koul <[email protected]>Signed-off-by Vamsi Krishna Lanka <[email protected]>Reviewed-by Bjorn Andersson <[email protected]>
Quoted 4 lines
--- .../devicetree/bindings/interrupt-controller/qcom,pdc.txt | 1 + 1 file changed, 1 insertion(+)
Stephen Boyd
maintainerRe: [PATCH v2 6/6] dt-bindings: clock: Introduce pdc bindings for SDX65
In reply to [email protected]Quoting [email protected] (2021-07-22 14:09:43)
Quoted 3 lines
From: Vamsi krishna Lanka <[email protected]>
Add compatible for SDX65 pdc.
This isn't clk related. It's an interrupt controller. Please don't send this to linux-clk list.
Quoted 29 lines
To: Rob Herring <[email protected]>
Cc Mark Brown <[email protected]>Cc Jonathan Cameron <[email protected]>Cc Kozlowski <[email protected]>Cc Vinod Koul <[email protected]>Signed-off-by Vamsi Krishna Lanka <[email protected]>Reviewed-by Bjorn Andersson <[email protected]>--- .../devicetree/bindings/interrupt-controller/qcom,pdc.txt | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt +1
-0@@ -22,6 +22,7 @@ Properties: - "qcom,sdm845-pdc": For SDM845 - "qcom,sdm8250-pdc": For SM8250 - "qcom,sdm8350-pdc": For SM8350 + - "qcom,sdx65-pdc": For SDX65 - reg: Usage: requiredSignature · 1 line
2.32.0