btrfs: add ioctls and send/receive support for reading/writing compressed data
Subsystems (4)
v11 cover btrfs: add ioctls and send/receive support for reading/writing compressed data
From: Omar Sandoval <[email protected]>
This series has three parts: new Btrfs ioctls for reading/writing compressed data, support for sending compressed data via Btrfs send, and btrfs-progs support for sending/receiving compressed data and writing it with the new ioctl.
Patches 1 and 2 are VFS changes exporting a couple of helpers for checks needed by reads and writes. Patches 3-7 are preparatory Btrfs changes for compressed reads and writes. Patch 8 adds the compressed read ioctl and patch 9 adds the compressed write ioctl.
The main use-case for this interface is Btrfs send/receive. Currently, when sending data from one compressed filesystem to another, the sending side decompresses the data and the receiving side recompresses it before writing it out. This is wasteful and can be avoided if we can just send and write compressed extents.
Patches 10-14 add the Btrfs send support. See the previous posting for more details and benchmarks [1]. Patches 10-12 prepare some protocol changes for send stream v2. Patch 13 implements compressed send. Patch 14 enables send stream v2 and compressed send in the send ioctl when requested.
These patches are based on Dave Sterba's Btrfs misc-next branch [2], which is in turn currently based on v5.14-rc7. Test cases are here [3].
Changes since v10 [4]:
Addressed Dave's and Nikolay's comments, mostly stylistic.
- Renamed __generic_write_checks() to generic_write_checks_count().
- Add missing count == 0 check to generic_write_checks_count().
- Used in_range() macro in btrfs_csum_one_bio().
- Renamed page_offsets variable to use_page_offsets in btrfs_csum_one_bio().
- Removed conditional on offset increment in btrfs_csum_one_bio().
- Fixed stale reference to RWF_ENCODED in comment.
1: https://lore.kernel.org/linux-btrfs/[email protected]/
2: https://github.com/kdave/btrfs-devel/tree/misc-next
3: https://github.com/osandov/xfstests/tree/btrfs-encoded-io
4: https://lore.kernel.org/linux-btrfs/[email protected]/
Omar Sandoval (14):
fs: export rw_verify_area()
fs: export variant of generic_write_checks without iov_iter
btrfs: don't advance offset for compressed bios in
btrfs_csum_one_bio()
btrfs: add ram_bytes and offset to btrfs_ordered_extent
btrfs: support different disk extent size for delalloc
btrfs: optionally extend i_size in cow_file_range_inline()
btrfs: add definitions + documentation for encoded I/O ioctls
btrfs: add BTRFS_IOC_ENCODED_READ
btrfs: add BTRFS_IOC_ENCODED_WRITE
btrfs: add send stream v2 definitions
btrfs: send: write larger chunks when using stream v2
btrfs: send: allocate send buffer with alloc_page() and vmap() for v2
btrfs: send: send compressed extents with encoded writes
btrfs: send: enable support for stream v2 and compressed writes
fs/btrfs/compression.c | 12 +- fs/btrfs/compression.h | 6 +- fs/btrfs/ctree.h | 17 +- fs/btrfs/delalloc-space.c | 18 +- fs/btrfs/file-item.c | 32 +- fs/btrfs/file.c | 68 ++- fs/btrfs/inode.c | 911 +++++++++++++++++++++++++++++++++---- fs/btrfs/ioctl.c | 213 +++++++++ fs/btrfs/ordered-data.c | 124 ++--- fs/btrfs/ordered-data.h | 25 +- fs/btrfs/relocation.c | 2 +- fs/btrfs/send.c | 307 +++++++++++-- fs/btrfs/send.h | 32 +- fs/internal.h | 5 - fs/read_write.c | 34 +- include/linux/fs.h | 2 + include/uapi/linux/btrfs.h | 149 +++++- 17 files changed, 1686 insertions(+), 271 deletions(-)
The btrfs-progs patches were written by Boris Burkov with some updates from me. Patches 1-4 are preparation. Patch 5 implements encoded writes. Patch 6 implements the fallback to decompressing. Patches 7 and 8 implement the other commands. Patch 9 adds the new btrfs send options. Patch 10 adds a test case.
Changes from v10:
- Fixed feature fallback to check for ENOTTY instead of EOPNOTSUPP.
Boris Burkov (10):
btrfs-progs: receive: support v2 send stream larger tlv_len
btrfs-progs: receive: dynamically allocate sctx->read_buf
btrfs-progs: receive: support v2 send stream DATA tlv format
btrfs-progs: receive: add send stream v2 cmds and attrs to send.h
btrfs-progs: receive: process encoded_write commands
btrfs-progs: receive: encoded_write fallback to explicit decode and
write
btrfs-progs: receive: process fallocate commands
btrfs-progs: receive: process setflags ioctl commands
btrfs-progs: send: stream v2 ioctl flags
btrfs-progs: receive: add tests for basic encoded_write send/receive
Documentation/btrfs-receive.asciidoc | 4 + Documentation/btrfs-send.asciidoc | 16 +- cmds/receive-dump.c | 31 +- cmds/receive.c | 347 +++++++++++++++++- cmds/send.c | 54 ++- common/send-stream.c | 157 ++++++-- common/send-stream.h | 7 + ioctl.h | 149 +++++++- libbtrfsutil/btrfs.h | 17 +- send.h | 19 +- .../049-receive-write-encoded/test.sh | 114 ++++++ 11 files changed, 871 insertions(+), 44 deletions(-) create mode 100755 tests/misc-tests/049-receive-write-encoded/test.sh
Signature · 1 line
2.33.0
PATCH v11 1/14 fs: export rw_verify_area()
From: Omar Sandoval <[email protected]>
I'm adding Btrfs ioctls to read and write compressed data, and rather than duplicating the checks in rw_verify_area(), let's just export it.
--- fs/internal.h | 5 ----- fs/read_write.c | 1 + include/linux/fs.h | 1 + 3 files changed, 2 insertions(+), 5 deletions(-)
fs/internal.h +0 -5
@@ -165,11 +165,6 @@ extern char *simple_dname(struct dentry *, char *, int);extern void dput_to_list (struct dentry *,struct list_head *);extern void shrink_dentry_list (struct list_head *); -/* -* read_write.c -*/ -extern int rw_verify_area (int ,struct file *,const loff_t *,size_t ); -/* * pipe.c */
fs/read_write.c +1 -0
@@ -400,6 +400,7 @@ int rw_verify_area(int read_write, struct file *file, const loff_t *ppos, size_treturn security_file_permission (file, read_write ==READ ?MAY_READ :MAY_WRITE ); } +EXPORT_SYMBOL (rw_verify_area);static ssize_t new_sync_read (struct file *filp,char __user *buf,size_t len,loff_t *ppos) {
include/linux/fs.h +1 -0
@@ -3274,6 +3274,7 @@ extern loff_t fixed_size_llseek(struct file *file, loff_t offset, int whence, loff_t size);extern loff_t no_seek_end_llseek_size (struct file *,loff_t ,int ,loff_t );extern loff_t no_seek_end_llseek (struct file *,loff_t ,int ); +extern int rw_verify_area (int ,struct file *,const loff_t *,size_t );extern int generic_file_open (struct inode * inode,struct file * filp);extern int nonseekable_open (struct inode * inode,struct file * filp);extern int stream_open (struct inode * inode,struct file * filp);
Signature · 1 line
2.33.0
Re: [PATCH v11 01/14] fs: export rw_verify_area()
Quoted 5 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
I'm adding Btrfs ioctls to read and write compressed data, and rather than duplicating the checks in
rw_verify_area(), let's just export it.
Quoted 7 lines
Reviewed-by Josef Bacik <[email protected]>Signed-off-by Omar Sandoval <[email protected]>--- fs/internal.h | 5 ----- fs/read_write.c | 1 + include/linux/fs.h | 1 + 3 files changed, 2 insertions(+), 5 deletions(-)
Could I please get an ack from the VFS side on this patch and "fs:
export variant of generic_write_checks without iov_iter"? We're going the route of doing this as a Btrfs ioctl since we couldn't agree on a generic interface, so this is all I need from the VFS.
Re: [PATCH v11 01/14] fs: export rw_verify_area()
Quoted 14 lines · Omar Sandoval
Quoted 5 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
I'm adding Btrfs ioctls to read and write compressed data, and rather than duplicating the checks in
rw_verify_area(), let's just export it.Quoted 7 lines
Reviewed-by Josef Bacik <[email protected]>Signed-off-by Omar Sandoval <[email protected]>--- fs/internal.h | 5 ----- fs/read_write.c | 1 + include/linux/fs.h | 1 + 3 files changed, 2 insertions(+), 5 deletions(-)
Quoted 4 lines
Could I please get an ack from the VFS side on this patch and "fs:
export variant ofgeneric_write_checkswithoutiov_iter"? We're going the route of doing this as a Btrfs ioctl since we couldn't agree on a generic interface, so this is all I need from the VFS.
Ping.
PATCH v11 2/14 fs: export variant of generic_write_checks without iov_iter
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
Encoded I/O in Btrfs needs to check a write with a given logical size without an iov_iter that matches that size (because the iov_iter we have is for the compressed data). So, factor out the parts of generic_write_check() that don't need an iov_iter into a new generic_write_checks_count() function and export that.
--- fs/read_write.c | 33 ++++++++++++++++++++------------- include/linux/fs.h | 1 + 2 files changed, 21 insertions(+), 13 deletions(-)
fs/read_write.c +20 -13
@@ -1633,24 +1633,16 @@ int generic_write_check_limits(struct file *file, loff_t pos, loff_t *count)return 0 ; } -/* -* Performs necessary checks before doing a write -* -* Can adjust writing position or amount of bytes to write. -* Returns appropriate error code that caller should return or -* zero in case that write should be allowed. -*/ -ssize_t generic_write_checks (struct kiocb *iocb,struct iov_iter *from) +/* Like generic_write_checks(), but takes size of write instead of iter. */ +int generic_write_checks_count (struct kiocb *iocb,loff_t *count) {struct file *file = iocb->ki_filp;struct inode *inode = file->f_mapping->host; -loff_t count; -int ret;if (IS_SWAPFILE (inode))return -ETXTBSY ; -if (!iov_iter_count (from)) +if (!*count)return 0 ;/* FIXME: this is for backwards compatibility with 2.4 */
@@ -1660,8 +1652,23 @@ ssize_t generic_write_checks(struct kiocb *iocb, struct iov_iter *from)if ((iocb->ki_flags &IOCB_NOWAIT ) && !(iocb->ki_flags &IOCB_DIRECT ))return -EINVAL ; - count =iov_iter_count (from); - ret =generic_write_check_limits (file, iocb->ki_pos, &count); +return generic_write_check_limits (iocb->ki_filp, iocb->ki_pos, count); +} +EXPORT_SYMBOL (generic_write_checks_count); + +/* +* Performs necessary checks before doing a write +* +* Can adjust writing position or amount of bytes to write. +* Returns appropriate error code that caller should return or +* zero in case that write should be allowed. +*/ +ssize_t generic_write_checks (struct kiocb *iocb,struct iov_iter *from) +{ +loff_t count =iov_iter_count (from); +int ret; + + ret =generic_write_checks_count (iocb, &count);if (ret)return ret;
include/linux/fs.h +1 -0
@@ -3227,6 +3227,7 @@ extern int sb_min_blocksize(struct super_block *, int);extern int generic_file_mmap (struct file *,struct vm_area_struct *);extern int generic_file_readonly_mmap (struct file *,struct vm_area_struct *);extern ssize_t generic_write_checks (struct kiocb *,struct iov_iter *); +extern int generic_write_checks_count (struct kiocb *iocb,loff_t *count);extern int generic_write_check_limits (struct file *file,loff_t pos,loff_t *count);extern int generic_file_rw_checks (struct file *file_in,struct file *file_out);
Signature · 1 line
2.33.0
Re: [PATCH v11 02/14] fs: export variant of generic_write_checks without iov_iter
Quoted 9 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
Encoded I/O in Btrfs needs to check a write with a given logical size without an
iov_iterthat matches that size (because theiov_iterwe have is for the compressed data). So, factor out the parts ofgeneric_write_check()that don't need aniov_iterinto a newgeneric_write_checks_count()function and export that.Signed-off-by Omar Sandoval <[email protected]>
PATCH v11 3/14 btrfs: don't advance offset for compressed bios in btrfs_csum_one_bio()
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
btrfs_csum_one_bio() loops over each filesystem block in the bio while keeping a cursor of its current logical position in the file in order to look up the ordered extent to add the checksums to. However, this doesn't make much sense for compressed extents, as a sector on disk does not correspond to a sector of decompressed file data. It happens to work because 1) the compressed bio always covers one ordered extent and 2) the size of the bio is always less than the size of the ordered extent. However, the second point will not always be true for encoded writes.
Let's add a boolean parameter to btrfs_csum_one_bio() to indicate that it can assume that the bio only covers one ordered extent. Since we're already changing the signature, let's get rid of the contig parameter and make it implied by the offset parameter, similar to the change we recently made to btrfs_lookup_bio_sums(). Additionally, let's rename nr_sectors to blockcount to make it clear that it's the number of filesystem blocks, not the number of 512-byte sectors.
--- fs/btrfs/compression.c | 5 +++-- fs/btrfs/ctree.h | 2 +- fs/btrfs/file-item.c | 32 ++++++++++++++------------------ fs/btrfs/inode.c | 8 ++++---- 4 files changed, 22 insertions(+), 25 deletions(-)
fs/btrfs/compression.c +3 -2
@@ -480,7 +480,8 @@ blk_status_t btrfs_submit_compressed_write(struct btrfs_inode *inode, u64 start,BUG_ON (ret);/* -ENOMEM */ if (!skip_sum) { - ret =btrfs_csum_one_bio (inode, bio, start,1 ); + ret =btrfs_csum_one_bio (inode, bio, start, + true);BUG_ON (ret);/* -ENOMEM */ }
@@ -516,7 +517,7 @@ blk_status_t btrfs_submit_compressed_write(struct btrfs_inode *inode, u64 start,BUG_ON (ret);/* -ENOMEM */ if (!skip_sum) { - ret =btrfs_csum_one_bio (inode, bio, start,1 ); + ret =btrfs_csum_one_bio (inode, bio, start, true);BUG_ON (ret);/* -ENOMEM */ }
fs/btrfs/ctree.h +1 -1
@@ -3115,7 +3115,7 @@ int btrfs_csum_file_blocks(struct btrfs_trans_handle *trans,struct btrfs_root *root, struct btrfs_ordered_sum *sums);blk_status_t btrfs_csum_one_bio (struct btrfs_inode *inode,struct bio *bio, -u64 file_start,int contig); +u64 offset,bool one_ordered);int btrfs_lookup_csums_range (struct btrfs_root *root,u64 start,u64 end,struct list_head *list,int search_commit); void btrfs_extent_item_to_extent_map(struct btrfs_inode *inode,
fs/btrfs/file-item.c +14 -18
@@ -614,28 +614,28 @@ int btrfs_lookup_csums_range(struct btrfs_root *root, u64 start, u64 end,* btrfs_csum_one_bio - Calculates checksums of the data contained inside a bio * @inode: Owner of the data inside the bio * @bio: Contains the data to be checksummed -* @file_start: offset in file this bio begins to describe -* @contig: Boolean. If true/1 means all bio vecs in this bio are -* contiguous and they begin at @file_start in the file. False/0 -* means this bio can contain potentially discontiguous bio vecs -* so the logical offset of each should be calculated separately. +* @offset: If (u64)-1, @bio may contain discontiguous bio vecs, so the +* file offsets are determined from the page offsets in the bio. +* Otherwise, this is the starting file offset of the bio vecs in +* @bio, which must be contiguous. +* @one_ordered: If true, @bio only refers to one ordered extent. */ blk_status_t btrfs_csum_one_bio (struct btrfs_inode *inode,struct bio *bio, -u64 file_start,int contig) +u64 offset,bool one_ordered) {struct btrfs_fs_info *fs_info = inode->root->fs_info;SHASH_DESC_ON_STACK (shash, fs_info->csum_shash);struct btrfs_ordered_sum *sums;struct btrfs_ordered_extent *ordered =NULL ; +const bool use_page_offsets = (offset == (u64)-1 );char *data;struct bvec_iter iter;struct bio_vec bvec;int index; -int nr_sectors; +int blockcount;unsigned long total_bytes =0 ;unsigned long this_sum_bytes =0 ;int i; -u64 offset;unsigned nofs_flag; nofs_flag =memalloc_nofs_save ();
@@ -649,18 +649,13 @@ blk_status_t btrfs_csum_one_bio(struct btrfs_inode *inode, struct bio *bio, sums->len = bio->bi_iter.bi_size;INIT_LIST_HEAD (&sums->list); -if (contig) - offset = file_start; -else - offset =0 ;/* shut up gcc */ - sums->bytenr = bio->bi_iter.bi_sector <<9 ; index =0 ; shash->tfm = fs_info->csum_shash;bio_for_each_segment (bvec, bio, iter) { -if (!contig) +if (use_page_offsets) offset =page_offset (bvec.bv_page) + bvec.bv_offset;if (!ordered) {
@@ -668,13 +663,14 @@ blk_status_t btrfs_csum_one_bio(struct btrfs_inode *inode, struct bio *bio,BUG_ON (!ordered);/* Logic error */ } - nr_sectors =BTRFS_BYTES_TO_BLKS (fs_info, + blockcount =BTRFS_BYTES_TO_BLKS (fs_info, bvec.bv_len + fs_info->sectorsize -1 ); -for (i =0 ; i < nr_sectors; i++) { -if (offset >= ordered->file_offset + ordered->num_bytes || - offset < ordered->file_offset) { +for (i =0 ; i < blockcount; i++) { +if (!one_ordered && + !in_range (offset, ordered->file_offset, + ordered->num_bytes)) {unsigned long bytes_left; sums->len = this_sum_bytes;
fs/btrfs/inode.c +4 -4
@@ -2286,7 +2286,7 @@ int btrfs_bio_fits_in_stripe(struct page *page, size_t size, struct bio *bio,static blk_status_t btrfs_submit_bio_start (struct inode *inode,struct bio *bio,u64 dio_file_offset) { -return btrfs_csum_one_bio (BTRFS_I (inode), bio,0 ,0 ); +return btrfs_csum_one_bio (BTRFS_I (inode), bio, (u64)-1 , false); }/*
@@ -2538,7 +2538,7 @@ blk_status_t btrfs_submit_data_bio(struct inode *inode, struct bio *bio, 0, btrfs_submit_bio_start); goto out; }else if (!skip_sum) { - ret =btrfs_csum_one_bio (BTRFS_I (inode), bio,0 ,0 ); + ret =btrfs_csum_one_bio (BTRFS_I (inode), bio, (u64)-1 , false);if (ret) goto out; }
@@ -8140,7 +8140,7 @@ static blk_status_t btrfs_submit_bio_start_direct_io(struct inode *inode,struct bio *bio, u64 dio_file_offset) { - return btrfs_csum_one_bio(BTRFS_I(inode), bio, dio_file_offset, 1); + return btrfs_csum_one_bio(BTRFS_I(inode), bio, dio_file_offset, false); }static void btrfs_end_dio_bio (struct bio *bio)
@@ -8199,7 +8199,7 @@ static inline blk_status_t btrfs_submit_dio_bio(struct bio *bio,* If we aren't doing async submit, calculate the csum of the * bio now. */ - ret =btrfs_csum_one_bio (BTRFS_I (inode), bio, file_offset,1 ); + ret =btrfs_csum_one_bio (BTRFS_I (inode), bio, file_offset, false);if (ret) goto err; }else {
Signature · 1 line
2.33.0
Re: [PATCH v11 03/14] btrfs: don't advance offset for compressed bios in btrfs_csum_one_bio()
Quoted 19 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
btrfs_csum_one_bio()loops over each filesystem block in the bio while keeping a cursor of its current logical position in the file in order to look up the ordered extent to add the checksums to. However, this doesn't make much sense for compressed extents, as a sector on disk does not correspond to a sector of decompressed file data. It happens to work because 1) the compressed bio always covers one ordered extent and 2) the size of the bio is always less than the size of the ordered extent. However, the second point will not always be true for encoded writes.Let's add a boolean parameter to
btrfs_csum_one_bio()to indicate that it can assume that the bio only covers one ordered extent. Since we're already changing the signature, let's get rid of the contig parameter and make it implied by the offset parameter, similar to the change we recently made tobtrfs_lookup_bio_sums(). Additionally, let's renamenr_sectorsto blockcount to make it clear that it's the number of filesystem blocks, not the number of 512-byte sectors.
Quoted 2 lines
Reviewed-by Josef Bacik <[email protected]>Signed-off-by Omar Sandoval <[email protected]>
Code-wise this looks, though I don't know why we are guaranteed that a compressed extent will only cover a single OE. But I trust you so:
Re: [PATCH v11 03/14] btrfs: don't advance offset for compressed bios in btrfs_csum_one_bio()
Quoted 22 lines · Nikolay Borisov
Quoted 19 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
btrfs_csum_one_bio()loops over each filesystem block in the bio while keeping a cursor of its current logical position in the file in order to look up the ordered extent to add the checksums to. However, this doesn't make much sense for compressed extents, as a sector on disk does not correspond to a sector of decompressed file data. It happens to work because 1) the compressed bio always covers one ordered extent and 2) the size of the bio is always less than the size of the ordered extent. However, the second point will not always be true for encoded writes.Let's add a boolean parameter to
btrfs_csum_one_bio()to indicate that it can assume that the bio only covers one ordered extent. Since we're already changing the signature, let's get rid of the contig parameter and make it implied by the offset parameter, similar to the change we recently made tobtrfs_lookup_bio_sums(). Additionally, let's renamenr_sectorsto blockcount to make it clear that it's the number of filesystem blocks, not the number of 512-byte sectors.
Quoted 5 lines
Quoted 2 lines
Reviewed-by Josef Bacik <[email protected]>Signed-off-by Omar Sandoval <[email protected]>Code-wise this looks, though I don't know why we are guaranteed that a compressed extent will only cover a single OE.
See submit_compressed_extents(): we always add an ordered extent that covers the whole range that we're submitting, and then btrfs_submit_compressed_write() creates one or more bios that are subsets of that range.
Quoted 2 lines
But I trust you so:
Reviewed-by Nikolay Borisov <[email protected]>
Thanks!
PATCH v11 4/14 btrfs: add ram_bytes and offset to btrfs_ordered_extent
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
Currently, we only create ordered extents when ram_bytes == num_bytes and offset == 0. However, RWF_ENCODED writes may create extents which only refer to a subset of the full unencoded extent, so we need to plumb these fields through the ordered extent infrastructure and pass them down to insert_reserved_file_extent().
Since we're changing the btrfs_add_ordered_extent* signature, let's get rid of the trivial wrappers and add a kernel-doc.
--- fs/btrfs/inode.c | 56 +++++++++++--------- fs/btrfs/ordered-data.c | 112 +++++++++++----------------------------- fs/btrfs/ordered-data.h | 22 ++++---- 3 files changed, 76 insertions(+), 114 deletions(-)
fs/btrfs/inode.c +32 -24
@@ -945,12 +945,12 @@ static noinline void submit_compressed_extents(struct async_chunk *async_chunk) goto out_free_reserve;free_extent_map (em); - ret =btrfs_add_ordered_extent_compress (inode, - async_extent->start, - ins.objectid, - async_extent->ram_size, - ins.offset, - async_extent->compress_type); + ret =btrfs_add_ordered_extent (inode, async_extent->start, + async_extent->ram_size, + async_extent->ram_size, + ins.objectid, ins.offset,0 , +1 <<BTRFS_ORDERED_COMPRESSED , + async_extent->compress_type);if (ret) { btrfs_drop_extent_cache(inode, async_extent->start, async_extent->start +
@@ -1180,9 +1180,9 @@ static noinline int cow_file_range(struct btrfs_inode *inode, }free_extent_map (em); - ret =btrfs_add_ordered_extent (inode, start, ins.objectid, - ram_size, cur_alloc_size, -BTRFS_ORDERED_REGULAR ); + ret =btrfs_add_ordered_extent (inode, start, ram_size, ram_size, + ins.objectid, cur_alloc_size,0 , +0 ,BTRFS_COMPRESS_NONE );if (ret) goto out_drop_extent_cache;
@@ -1843,10 +1843,11 @@ static noinline int run_delalloc_nocow(struct btrfs_inode *inode, goto error; }free_extent_map (em); - ret =btrfs_add_ordered_extent (inode, cur_offset, - disk_bytenr, num_bytes, - num_bytes, -BTRFS_ORDERED_PREALLOC ); + ret =btrfs_add_ordered_extent (inode, + cur_offset, num_bytes, num_bytes, + disk_bytenr, num_bytes,0 , +1 <<BTRFS_ORDERED_PREALLOC , +BTRFS_COMPRESS_NONE );if (ret) { btrfs_drop_extent_cache(inode, cur_offset, cur_offset + num_bytes - 1,
@@ -1855,9 +1856,11 @@ static noinline int run_delalloc_nocow(struct btrfs_inode *inode, } }else { ret =btrfs_add_ordered_extent (inode, cur_offset, + num_bytes, num_bytes, disk_bytenr, num_bytes, - num_bytes, -BTRFS_ORDERED_NOCOW ); +0 , +1 <<BTRFS_ORDERED_NOCOW , +BTRFS_COMPRESS_NONE );if (ret) goto error; }
@@ -2842,6 +2845,7 @@ static int insert_reserved_file_extent(struct btrfs_trans_handle *trans,struct btrfs_key ins;u64 disk_num_bytes =btrfs_stack_file_extent_disk_num_bytes (stack_fi);u64 disk_bytenr =btrfs_stack_file_extent_disk_bytenr (stack_fi); +u64 offset =btrfs_stack_file_extent_offset (stack_fi);u64 num_bytes =btrfs_stack_file_extent_num_bytes (stack_fi);u64 ram_bytes =btrfs_stack_file_extent_ram_bytes (stack_fi);struct btrfs_drop_extents_args drop_args = {0 };
@@ -2916,7 +2920,8 @@ static int insert_reserved_file_extent(struct btrfs_trans_handle *trans, goto out; ret =btrfs_alloc_reserved_file_extent (trans, root,btrfs_ino (inode), - file_pos, qgroup_reserved, &ins); + file_pos - offset, + qgroup_reserved, &ins); out:btrfs_free_path (path);
@@ -2942,20 +2947,20 @@ static int insert_ordered_extent_file_extent(struct btrfs_trans_handle *trans, struct btrfs_ordered_extent *oe) {struct btrfs_file_extent_item stack_fi; -u64 logical_len;bool update_inode_bytes; +u64 num_bytes = oe->num_bytes; +u64 ram_bytes = oe->ram_bytes;memset (&stack_fi,0 ,sizeof (stack_fi));btrfs_set_stack_file_extent_type (&stack_fi,BTRFS_FILE_EXTENT_REG );btrfs_set_stack_file_extent_disk_bytenr (&stack_fi, oe->disk_bytenr);btrfs_set_stack_file_extent_disk_num_bytes (&stack_fi, oe->disk_num_bytes); +btrfs_set_stack_file_extent_offset (&stack_fi, oe->offset);if (test_bit (BTRFS_ORDERED_TRUNCATED , &oe->flags)) - logical_len = oe->truncated_len; -else - logical_len = oe->num_bytes; -btrfs_set_stack_file_extent_num_bytes (&stack_fi, logical_len); -btrfs_set_stack_file_extent_ram_bytes (&stack_fi, logical_len); + num_bytes = ram_bytes = oe->truncated_len; +btrfs_set_stack_file_extent_num_bytes (&stack_fi, num_bytes); +btrfs_set_stack_file_extent_ram_bytes (&stack_fi, ram_bytes);btrfs_set_stack_file_extent_compression (&stack_fi, oe->compress_type);/* Encryption and other encoding is reserved and all 0 */
@@ -7395,8 +7400,11 @@ static struct extent_map *btrfs_create_dio_extent(struct btrfs_inode *inode,if (IS_ERR (em)) goto out; } - ret =btrfs_add_ordered_extent_dio (inode, start, block_start, len, - block_len, type); + ret =btrfs_add_ordered_extent (inode, start, len, len, block_start, + block_len,0 , + (1 << type) | + (1 <<BTRFS_ORDERED_DIRECT ), +BTRFS_COMPRESS_NONE );if (ret) {if (em) {free_extent_map (em);
fs/btrfs/ordered-data.c +31 -81
157 lines not on this page · raw message
fs/btrfs/ordered-data.h +13 -9
@@ -76,6 +76,13 @@ enum { BTRFS_ORDERED_PENDING, }; +/* BTRFS_ORDERED_* flags that specify the type of the extent. */ +#define BTRFS_ORDERED_TYPE_FLAGS ((1UL << BTRFS_ORDERED_REGULAR) | \ + (1UL << BTRFS_ORDERED_NOCOW) | \ + (1UL << BTRFS_ORDERED_PREALLOC) | \ + (1UL << BTRFS_ORDERED_COMPRESSED) | \ + (1UL << BTRFS_ORDERED_DIRECT)) +struct btrfs_ordered_extent {/* logical offset in the file */ u64 file_offset;
@@ -84,9 +91,11 @@ struct btrfs_ordered_extent {* These fields directly correspond to the same fields in * btrfs_file_extent_item. */ -u64 disk_bytenr;u64 num_bytes; +u64 ram_bytes; +u64 disk_bytenr;u64 disk_num_bytes; +u64 offset;/* number of bytes that still need writing */ u64 bytes_left;
@@ -179,14 +188,9 @@ bool btrfs_dec_test_ordered_pending(struct btrfs_inode *inode,struct btrfs_ordered_extent **cached, u64 file_offset, u64 io_size);int btrfs_add_ordered_extent (struct btrfs_inode *inode,u64 file_offset, -u64 disk_bytenr,u64 num_bytes,u64 disk_num_bytes, -int type); -int btrfs_add_ordered_extent_dio (struct btrfs_inode *inode,u64 file_offset, -u64 disk_bytenr,u64 num_bytes, -u64 disk_num_bytes,int type); -int btrfs_add_ordered_extent_compress (struct btrfs_inode *inode,u64 file_offset, -u64 disk_bytenr,u64 num_bytes, -u64 disk_num_bytes,int compress_type); +u64 num_bytes,u64 ram_bytes,u64 disk_bytenr, +u64 disk_num_bytes,u64 offset,int flags, +int compress_type);void btrfs_add_ordered_sum (struct btrfs_ordered_extent *entry,struct btrfs_ordered_sum *sum); struct btrfs_ordered_extent *btrfs_lookup_ordered_extent(struct btrfs_inode *inode,
Signature · 1 line
2.33.0
Re: [PATCH v11 04/14] btrfs: add ram_bytes and offset to btrfs_ordered_extent
Quoted 4 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
Currently, we only create ordered extents when
ram_bytes==num_bytesand offset == 0. However,RWF_ENCODEDwrites may create extents which
Change RWF_ENCODED to simply encoded as we no longer rely on RWF flags, same thing for the changelog in the next patch.
<snip>
Re: [PATCH v11 04/14] btrfs: add ram_bytes and offset to btrfs_ordered_extent
Quoted 10 lines · Nikolay Borisov
Quoted 4 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
Currently, we only create ordered extents when
ram_bytes==num_bytesand offset == 0. However,RWF_ENCODEDwrites may create extents whichChange
RWF_ENCODEDto simply encoded as we no longer rely on RWF flags, same thing for the changelog in the next patch.
Oops, I checked the diff for stray references to RWF_ENCODED but I forgot to check the commit messages. Thanks, I'll fix it.
PATCH v11 5/14 btrfs: support different disk extent size for delalloc
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
Currently, we always reserve the same extent size in the file and extent size on disk for delalloc because the former is the worst case for the latter. For RWF_ENCODED writes, we know the exact size of the extent on disk, which may be less than or greater than (for bookends) the size in the file. Add a disk_num_bytes parameter to btrfs_delalloc_reserve_metadata() so that we can reserve the correct amount of csum bytes. No functional change.
--- fs/btrfs/ctree.h | 3 ++- fs/btrfs/delalloc-space.c | 18 ++++++++++-------- fs/btrfs/file.c | 3 ++- fs/btrfs/inode.c | 2 +- fs/btrfs/relocation.c | 2 +- 5 files changed, 16 insertions(+), 12 deletions(-)
fs/btrfs/ctree.h +2 -1
@@ -2802,7 +2802,8 @@ void btrfs_subvolume_release_metadata(struct btrfs_root *root, struct btrfs_block_rsv *rsv);void btrfs_delalloc_release_extents (struct btrfs_inode *inode,u64 num_bytes); -int btrfs_delalloc_reserve_metadata (struct btrfs_inode *inode,u64 num_bytes); +int btrfs_delalloc_reserve_metadata (struct btrfs_inode *inode,u64 num_bytes, +u64 disk_num_bytes);u64 btrfs_account_ro_block_groups_free_space (struct btrfs_space_info *sinfo);int btrfs_error_unpin_extent_range (struct btrfs_fs_info *fs_info,u64 start,u64 end);
fs/btrfs/delalloc-space.c +10 -8
@@ -267,11 +267,11 @@ static void btrfs_calculate_inode_block_rsv_size(struct btrfs_fs_info *fs_info, }static void calc_inode_reservations (struct btrfs_fs_info *fs_info, -u64 num_bytes,u64 *meta_reserve, -u64 *qgroup_reserve) +u64 num_bytes,u64 disk_num_bytes, +u64 *meta_reserve,u64 *qgroup_reserve) {u64 nr_extents =count_max_extents (num_bytes); -u64 csum_leaves =btrfs_csum_bytes_to_leaves (fs_info, num_bytes); +u64 csum_leaves =btrfs_csum_bytes_to_leaves (fs_info, disk_num_bytes);u64 inode_update =btrfs_calc_metadata_size (fs_info,1 ); *meta_reserve = btrfs_calc_insert_metadata_size(fs_info,
@@ -285,7 +285,8 @@ static void calc_inode_reservations(struct btrfs_fs_info *fs_info, *qgroup_reserve = nr_extents * fs_info->nodesize; } -int btrfs_delalloc_reserve_metadata (struct btrfs_inode *inode,u64 num_bytes) +int btrfs_delalloc_reserve_metadata (struct btrfs_inode *inode,u64 num_bytes, +u64 disk_num_bytes) {struct btrfs_root *root = inode->root;struct btrfs_fs_info *fs_info = root->fs_info;
@@ -315,6 +316,7 @@ int btrfs_delalloc_reserve_metadata(struct btrfs_inode *inode, u64 num_bytes) } num_bytes =ALIGN (num_bytes, fs_info->sectorsize); + disk_num_bytes =ALIGN (disk_num_bytes, fs_info->sectorsize);/* * We always want to do it this way, every other way is wrong and ends
@@ -326,8 +328,8 @@ int btrfs_delalloc_reserve_metadata(struct btrfs_inode *inode, u64 num_bytes)* everything out and try again, which is bad. This way we just * over-reserve slightly, and clean up the mess when we are done. */ -calc_inode_reservations (fs_info, num_bytes, &meta_reserve, - &qgroup_reserve); +calc_inode_reservations (fs_info, num_bytes, disk_num_bytes, + &meta_reserve, &qgroup_reserve); ret =btrfs_qgroup_reserve_meta_prealloc (root, qgroup_reserve, true);if (ret)return ret;
@@ -346,7 +348,7 @@ int btrfs_delalloc_reserve_metadata(struct btrfs_inode *inode, u64 num_bytes)spin_lock (&inode->lock); nr_extents =count_max_extents (num_bytes);btrfs_mod_outstanding_extents (inode, nr_extents); - inode->csum_bytes += num_bytes; + inode->csum_bytes += disk_num_bytes;btrfs_calculate_inode_block_rsv_size (fs_info, inode);spin_unlock (&inode->lock);
@@ -451,7 +453,7 @@ int btrfs_delalloc_reserve_space(struct btrfs_inode *inode, ret =btrfs_check_data_free_space (inode, reserved, start, len);if (ret <0 )return ret; - ret =btrfs_delalloc_reserve_metadata (inode, len); + ret =btrfs_delalloc_reserve_metadata (inode, len, len);if (ret <0 )btrfs_free_reserved_data_space (inode, *reserved, start, len);return ret;
fs/btrfs/file.c +2 -1
@@ -1741,7 +1741,8 @@ static noinline ssize_t btrfs_buffered_write(struct kiocb *iocb, fs_info->sectorsize);WARN_ON (reserve_bytes ==0 ); ret =btrfs_delalloc_reserve_metadata (BTRFS_I (inode), - reserve_bytes); + reserve_bytes, + reserve_bytes);if (ret) {if (!only_release_metadata) btrfs_free_reserved_data_space(BTRFS_I(inode),
fs/btrfs/inode.c +1 -1
@@ -5043,7 +5043,7 @@ int btrfs_truncate_block(struct btrfs_inode *inode, loff_t from, loff_t len, goto out; } } - ret =btrfs_delalloc_reserve_metadata (inode, blocksize); + ret =btrfs_delalloc_reserve_metadata (inode, blocksize, blocksize);if (ret <0 ) {if (!only_release_metadata) btrfs_free_reserved_data_space(inode, data_reserved,
fs/btrfs/relocation.c +1 -1
@@ -3017,7 +3017,7 @@ static int relocate_one_page(struct inode *inode, struct file_ra_state *ra,/* Reserve metadata for this range */ ret =btrfs_delalloc_reserve_metadata (BTRFS_I (inode), - clamped_len); + clamped_len, clamped_len);if (ret) goto release_page;
Signature · 1 line
2.33.0
PATCH v11 6/14 btrfs: optionally extend i_size in cow_file_range_inline()
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
Currently, an inline extent is always created after i_size is extended from btrfs_dirty_pages(). However, for encoded writes, we only want to update i_size after we successfully created the inline extent. Add an update_i_size parameter to cow_file_range_inline() and insert_inline_extent() and pass in the size of the extent rather than determining it from i_size. Since the start parameter is always passed as 0, get rid of it and simplify the logic in these two functions. While we're here, let's document the requirements for creating an inline extent.
--- fs/btrfs/inode.c | 100 +++++++++++++++++++++++------------------------ 1 file changed, 48 insertions(+), 52 deletions(-)
fs/btrfs/inode.c +48 -52
@@ -236,9 +236,10 @@ static int btrfs_init_inode_security(struct btrfs_trans_handle *trans,static int insert_inline_extent (struct btrfs_trans_handle *trans,struct btrfs_path *path,bool extent_inserted,struct btrfs_root *root,struct inode *inode, -u64 start,size_t size,size_t compressed_size, +size_t size,size_t compressed_size,int compress_type, -struct page **compressed_pages) +struct page **compressed_pages, +bool update_i_size) {struct extent_buffer *leaf;struct page *page =NULL ;
@@ -247,7 +248,7 @@ static int insert_inline_extent(struct btrfs_trans_handle *trans,struct btrfs_file_extent_item *ei;int ret;size_t cur_size = size; -unsigned long offset; +u64 i_size;ASSERT ((compressed_size >0 && compressed_pages) || (compressed_size ==0 && !compressed_pages));
@@ -260,7 +261,7 @@ static int insert_inline_extent(struct btrfs_trans_handle *trans,size_t datasize; key.objectid =btrfs_ino (BTRFS_I (inode)); - key.offset = start; + key.offset =0 ; key.type =BTRFS_EXTENT_DATA_KEY ; datasize =btrfs_file_extent_calc_inline_size (cur_size);
@@ -297,12 +298,10 @@ static int insert_inline_extent(struct btrfs_trans_handle *trans,btrfs_set_file_extent_compression (leaf, ei, compress_type); }else { - page =find_get_page (inode->i_mapping, - start >>PAGE_SHIFT ); + page =find_get_page (inode->i_mapping,0 );btrfs_set_file_extent_compression (leaf, ei,0 ); kaddr =kmap_atomic (page); - offset =offset_in_page (start); -write_extent_buffer (leaf, kaddr + offset, ptr, size); +write_extent_buffer (leaf, kaddr, ptr, size);kunmap_atomic (kaddr);put_page (page); }
@@ -313,8 +312,8 @@ static int insert_inline_extent(struct btrfs_trans_handle *trans,* We align size to sectorsize for inline extents just for simplicity * sake. */ - size =ALIGN (size, root->fs_info->sectorsize); - ret =btrfs_inode_set_file_extent_range (BTRFS_I (inode), start, size); + ret =btrfs_inode_set_file_extent_range (BTRFS_I (inode),0 , +ALIGN (size, root->fs_info->sectorsize));if (ret) goto fail;
@@ -327,7 +326,13 @@ static int insert_inline_extent(struct btrfs_trans_handle *trans,* before we unlock the pages. Otherwise we * could end up racing with unlink. */ -BTRFS_I (inode)->disk_i_size = inode->i_size; + i_size =i_size_read (inode); +if (update_i_size && size > i_size) { +i_size_write (inode, size); + i_size = size; + } +BTRFS_I (inode)->disk_i_size = i_size; + fail:return ret; }
@@ -338,35 +343,31 @@ static int insert_inline_extent(struct btrfs_trans_handle *trans,* does the checks required to make sure the data is small enough * to fit as an inline extent. */ -static noinline int cow_file_range_inline(struct btrfs_inode *inode, u64 start, -u64 end,size_t compressed_size, +static noinline int cow_file_range_inline(struct btrfs_inode *inode, u64 size, +size_t compressed_size,int compress_type, -struct page **compressed_pages) +struct page **compressed_pages, +bool update_i_size) {struct btrfs_drop_extents_args drop_args = {0 };struct btrfs_root *root = inode->root;struct btrfs_fs_info *fs_info = root->fs_info;struct btrfs_trans_handle *trans; -u64 isize =i_size_read (&inode->vfs_inode); -u64 actual_end =min (end +1 , isize); -u64 inline_len = actual_end - start; -u64 aligned_end =ALIGN (end, fs_info->sectorsize); -u64 data_len = inline_len; +u64 data_len = compressed_size ? compressed_size : size;int ret;struct btrfs_path *path; -if (compressed_size) - data_len = compressed_size; - -if (start >0 || - actual_end > fs_info->sectorsize || +/* +* We can create an inline extent if it ends at or beyond the current +* i_size, is no larger than a sector (decompressed), and the (possibly +* compressed) data fits in a leaf and the configured maximum inline +* size. +*/ +if (size <i_size_read (&inode->vfs_inode) || + size > fs_info->sectorsize || data_len >BTRFS_MAX_INLINE_DATA_SIZE (fs_info) || - (!compressed_size && - (actual_end & (fs_info->sectorsize -1 )) ==0 ) || - end +1 < isize || - data_len > fs_info->max_inline) { + data_len > fs_info->max_inline)return 1 ; - } path =btrfs_alloc_path ();if (!path)
@@ -380,30 +381,21 @@ static noinline int cow_file_range_inline(struct btrfs_inode *inode, u64 start, trans->block_rsv = &inode->block_rsv; drop_args.path = path; - drop_args.start = start; - drop_args.end = aligned_end; + drop_args.start =0 ; + drop_args.end = fs_info->sectorsize; drop_args.drop_cache = true; drop_args.replace_extent = true; - -if (compressed_size && compressed_pages) - drop_args.extent_item_size =btrfs_file_extent_calc_inline_size ( - compressed_size); -else - drop_args.extent_item_size =btrfs_file_extent_calc_inline_size ( - inline_len); - + drop_args.extent_item_size =btrfs_file_extent_calc_inline_size (data_len); ret =btrfs_drop_extents (trans, root, inode, &drop_args);if (ret) {btrfs_abort_transaction (trans, ret); goto out; } -if (isize > actual_end) - inline_len =min_t (u64, isize, actual_end); - ret =insert_inline_extent (trans, path, drop_args.extent_inserted, - root, &inode->vfs_inode, start, - inline_len, compressed_size, - compress_type, compressed_pages); + ret =insert_inline_extent (trans, path, drop_args.extent_inserted, root, + &inode->vfs_inode, size, compressed_size, + compress_type, compressed_pages, + update_i_size);if (ret && ret != -ENOSPC ) {btrfs_abort_transaction (trans, ret); goto out;
@@ -412,7 +404,7 @@ static noinline int cow_file_range_inline(struct btrfs_inode *inode, u64 start, goto out; } -btrfs_update_inode_bytes (inode, inline_len, drop_args.bytes_found); +btrfs_update_inode_bytes (inode, size, drop_args.bytes_found); ret =btrfs_update_inode (trans, root, inode);if (ret && ret != -ENOSPC ) {btrfs_abort_transaction (trans, ret);
@@ -695,14 +687,15 @@ static noinline int compress_file_range(struct async_chunk *async_chunk)/* we didn't compress the entire range, try * to make an uncompressed inline extent. */ - ret =cow_file_range_inline (BTRFS_I (inode), start, end, + ret =cow_file_range_inline (BTRFS_I (inode), actual_end,0 ,BTRFS_COMPRESS_NONE , -NULL ); +NULL , false); }else {/* try making a compressed inline extent */ - ret =cow_file_range_inline (BTRFS_I (inode), start, end, + ret =cow_file_range_inline (BTRFS_I (inode), actual_end, total_compressed, - compress_type, pages); + compress_type, pages, + false); }if (ret <=0 ) { unsigned long clear_flags = EXTENT_DELALLOC |
@@ -1098,9 +1091,12 @@ static noinline int cow_file_range(struct btrfs_inode *inode,* So here we skip inline extent creation completely. */ if (start ==0 && fs_info->sectorsize ==PAGE_SIZE ) { +u64 actual_end =min_t (u64,i_size_read (&inode->vfs_inode), + end +1 ); +/* lets try to make an inline extent */ - ret =cow_file_range_inline (inode, start, end,0 , -BTRFS_COMPRESS_NONE ,NULL ); + ret =cow_file_range_inline (inode, actual_end,0 , +BTRFS_COMPRESS_NONE ,NULL , false);if (ret ==0 ) {/* * We use DO_ACCOUNTING here because we need the
Signature · 1 line
2.33.0
Re: [PATCH v11 06/14] btrfs: optionally extend i_size in cow_file_range_inline()
Quoted 12 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
Currently, an inline extent is always created after
i_sizeis extended frombtrfs_dirty_pages(). However, for encoded writes, we only want to updatei_sizeafter we successfully created the inline extent. Add anupdate_i_sizeparameter tocow_file_range_inline()andinsert_inline_extent()and pass in the size of the extent rather than determining it fromi_size. Since the start parameter is always passed as 0, get rid of it and simplify the logic in these two functions. While we're here, let's document the requirements for creating an inline extent.
Quoted 2 lines
Reviewed-by Josef Bacik <[email protected]>Signed-off-by Omar Sandoval <[email protected]>
Overall I like where this is going, actually the diff is larger than it should be because some refactoring is tucked in. If there would be yet another submission with more substantial changes I'd like to see this patch split into 2:
1. Patch does the refactoring
2. Adds the logic to update i_size alongside the addition of the update_i_size parameter.
That will make the functional change a lot more obvious.
Quoted 9 lines
--- fs/btrfs/inode.c | 100 +++++++++++++++++++++++------------------------ 1 file changed, 48 insertions(+), 52 deletions(-)fs/btrfs/inode.c +0
-0
fs/btrfs/inode.c static int btrfs_init_inode_security(struct btrfs_trans_handle *trans, · line 242
Quoted 9 lines
fs/btrfs/inode.c +3
-2@@ -236,9 +236,10 @@ static int btrfs_init_inode_security(struct btrfs_trans_handle *trans,static int insert_inline_extent (struct btrfs_trans_handle *trans,struct btrfs_path *path,bool extent_inserted,struct btrfs_root *root,struct inode *inode, -u64 start,size_t size,size_t compressed_size, +size_t size,size_t compressed_size,int compress_type, -struct page **compressed_pages) +struct page **compressed_pages, +bool update_i_size)
This function grows to 10 parameters, I think it's high time it took an argument struct and each member can in turn be documented in this structure, otherwise it's very unwieldy to work with.
Quoted 3 lines
fs/btrfs/inode.c +0
-0{struct extent_buffer *leaf;struct page *page =NULL ;
<snip>
Quoted 18 lines
fs/btrfs/inode.c +7
-1@@ -327,7 +326,13 @@ static int insert_inline_extent(struct btrfs_trans_handle *trans,* before we unlock the pages. Otherwise we * could end up racing with unlink. */ -BTRFS_I (inode)->disk_i_size = inode->i_size; + i_size =i_size_read (inode); +if (update_i_size && size > i_size) { +i_size_write (inode, size); + i_size = size; + } +BTRFS_I (inode)->disk_i_size = i_size; + fail:return ret; }@@ -338,35 +343,31 @@ static int insert_inline_extent(struct btrfs_trans_handle *trans,* does the checks required to make sure the data is small enough
fs/btrfs/inode.c static int insert_inline_extent(struct btrfs_trans_handle *trans, · line 350
Quoted 10 lines
fs/btrfs/inode.c +4
-3* to fit as an inline extent. */ -static noinline int cow_file_range_inline(struct btrfs_inode *inode, u64 start, -u64 end,size_t compressed_size, +static noinline int cow_file_range_inline(struct btrfs_inode *inode, u64 size, +size_t compressed_size,int compress_type, -struct page **compressed_pages) +struct page **compressed_pages, +bool update_i_size)
This function also has 6 parameters which is not on the extreme but I have a feeling it also needs to be refactored to take an argument structure.
Quoted 24 lines
fs/btrfs/inode.c +6
-10{struct btrfs_drop_extents_args drop_args = {0 };struct btrfs_root *root = inode->root;struct btrfs_fs_info *fs_info = root->fs_info;struct btrfs_trans_handle *trans; -u64 isize =i_size_read (&inode->vfs_inode); -u64 actual_end =min (end +1 , isize); -u64 inline_len = actual_end - start; -u64 aligned_end =ALIGN (end, fs_info->sectorsize); -u64 data_len = inline_len; +u64 data_len = compressed_size ? compressed_size : size;int ret;struct btrfs_path *path; -if (compressed_size) - data_len = compressed_size; - - if (start > 0 || - actual_end > fs_info->sectorsize || +/* +* We can create an inline extent if it ends at or beyond the current +* i_size, is no larger than a sector (decompressed), and the (possibly +* compressed) data fits in a leaf and the configured maximum inline +* size.
fs/btrfs/inode.c static int insert_inline_extent(struct btrfs_trans_handle *trans, · line 370
Quoted 10 lines
fs/btrfs/inode.c +4
-4+*/ +if (size <i_size_read (&inode->vfs_inode) || + size > fs_info->sectorsize || data_len >BTRFS_MAX_INLINE_DATA_SIZE (fs_info) || - (!compressed_size && - (actual_end & (fs_info->sectorsize - 1)) == 0) || - end + 1 < isize || - data_len > fs_info->max_inline) { + data_len > fs_info->max_inline)return 1 ;
With this change you allow to write more than PAGE_SIZE data in case of a compressed extents, Qu said he had some concerns regarding this. I'm CCing him so this can be discussed on this submission.
Quoted 4 lines
fs/btrfs/inode.c +0
-1- } path =btrfs_alloc_path ();if (!path)
<snip>
PATCH v11 7/14 btrfs: add definitions + documentation for encoded I/O ioctls
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
In order to allow sending and receiving compressed data without decompressing it, we need an interface to write pre-compressed data directly to the filesystem and the matching interface to read compressed data without decompressing it. This adds the definitions for ioctls to do that and detailed explanations of how to use them.
--- include/uapi/linux/btrfs.h | 132 +++++++++++++++++++++++++++++++++++++ 1 file changed, 132 insertions(+)
include/uapi/linux/btrfs.h +132 -0
@@ -861,6 +861,134 @@ struct btrfs_ioctl_get_subvol_rootref_args {__u8 align[7 ]; }; +/* +* Data and metadata for an encoded read or write. +* +* Encoded I/O bypasses any encoding automatically done by the filesystem (e.g., +* compression). This can be used to read the compressed contents of a file or +* write pre-compressed data directly to a file. +* +* BTRFS_IOC_ENCODED_READ and BTRFS_IOC_ENCODED_WRITE are essentially +* preadv/pwritev with additional metadata about how the data is encoded and the +* size of the unencoded data. +* +* BTRFS_IOC_ENCODED_READ fills the given iovecs with the encoded data, fills +* the metadata fields, and returns the size of the encoded data. It reads one +* extent per call. It can also read data which is not encoded. +* +* BTRFS_IOC_ENCODED_WRITE uses the metadata fields, writes the encoded data +* from the iovecs, and returns the size of the encoded data. Note that the +* encoded data is not validated when it is written; if it is not valid (e.g., +* it cannot be decompressed), then a subsequent read may return an error. +* +* Since the filesystem page cache contains decoded data, encoded I/O bypasses +* the page cache. Encoded I/O requires CAP_SYS_ADMIN. +*/ +struct btrfs_ioctl_encoded_io_args { +/* Input parameters for both reads and writes. */ + +/* +* iovecs containing encoded data. +* +* For reads, if the size of the encoded data is larger than the sum of +* iov[n].iov_len for 0 <= n < iovcnt, then the ioctl fails with +* ENOBUFS. +* +* For writes, the size of the encoded data is the sum of iov[n].iov_len +* for 0 <= n < iovcnt. This must be less than 128 KiB (this limit may +* increase in the future). This must also be less than or equal to +* unencoded_len. +*/ +const struct iovec __user *iov; +/* Number of iovecs. */ +unsigned long iovcnt; +/* +* Offset in file. +* +* For writes, must be aligned to the sector size of the filesystem. +*/ +__s64 offset; +/* Currently must be zero. */ +__u64 flags; + +/* +* For reads, the following members are filled in with the metadata for +* the encoded data. +* For writes, the following members must be set to the metadata for the +* encoded data. +*/ + +/* +* Length of the data in the file. +* +* Must be less than or equal to unencoded_len - unencoded_offset. For +* writes, must be aligned to the sector size of the filesystem unless +* the data ends at or beyond the current end of the file. +*/ +__u64 len; +/* +* Length of the unencoded (i.e., decrypted and decompressed) data. +* +* For writes, must be no more than 128 KiB (this limit may increase in +* the future). If the unencoded data is actually longer than +* unencoded_len, then it is truncated; if it is shorter, then it is +* extended with zeroes. +*/ +__u64 unencoded_len; +/* +* Offset from the first byte of the unencoded data to the first byte of +* logical data in the file. +* +* Must be less than unencoded_len. +*/ +__u64 unencoded_offset; +/* +* BTRFS_ENCODED_IO_COMPRESSION_* type. +* +* For writes, must not be BTRFS_ENCODED_IO_COMPRESSION_NONE. +*/ +__u32 compression; +/* Currently always BTRFS_ENCODED_IO_ENCRYPTION_NONE. */ +__u32 encryption; +/* +* Reserved for future expansion. +* +* For reads, always returned as zero. Users should check for non-zero +* bytes. If there are any, then the kernel has a newer version of this +* structure with additional information that the user definition is +* missing. +* +* For writes, must be zeroed. +*/ +__u8 reserved[32 ]; +}; + +/* Data is not compressed. */ +#define BTRFS_ENCODED_IO_COMPRESSION_NONE 0 +/* Data is compressed as a single zlib stream. */ +#define BTRFS_ENCODED_IO_COMPRESSION_ZLIB 1 +/* +* Data is compressed as a single zstd frame with the windowLog compression +* parameter set to no more than 17. +*/ +#define BTRFS_ENCODED_IO_COMPRESSION_ZSTD 2 +/* +* Data is compressed page by page (using the page size indicated by the name of +* the constant) with LZO1X and wrapped in the format documented in +* fs/btrfs/lzo.c. For writes, the compression page size must match the +* filesystem page size. +*/ +#define BTRFS_ENCODED_IO_COMPRESSION_LZO_4K 3 +#define BTRFS_ENCODED_IO_COMPRESSION_LZO_8K 4 +#define BTRFS_ENCODED_IO_COMPRESSION_LZO_16K 5 +#define BTRFS_ENCODED_IO_COMPRESSION_LZO_32K 6 +#define BTRFS_ENCODED_IO_COMPRESSION_LZO_64K 7 +#define BTRFS_ENCODED_IO_COMPRESSION_TYPES 8 + +/* Data is not encrypted. */ +#define BTRFS_ENCODED_IO_ENCRYPTION_NONE 0 +#define BTRFS_ENCODED_IO_ENCRYPTION_TYPES 1 +/* Error codes as returned by the kernel */ enum btrfs_err_code {BTRFS_ERROR_DEV_RAID1_MIN_NOT_MET =1 ,
@@ -989,5 +1117,9 @@ enum btrfs_err_code { struct btrfs_ioctl_ino_lookup_user_args)#define BTRFS_IOC_SNAP_DESTROY_V2 _IOW(BTRFS_IOCTL_MAGIC, 63, \ struct btrfs_ioctl_vol_args_v2) +#define BTRFS_IOC_ENCODED_READ _IOR(BTRFS_IOCTL_MAGIC, 64, \ + struct btrfs_ioctl_encoded_io_args) +#define BTRFS_IOC_ENCODED_WRITE _IOW(BTRFS_IOCTL_MAGIC, 64, \ + struct btrfs_ioctl_encoded_io_args)#endif /* _UAPI_LINUX_BTRFS_H */
Signature · 1 line
2.33.0
Re: [PATCH v11 07/14] btrfs: add definitions + documentation for encoded I/O ioctls
Quoted 9 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
In order to allow sending and receiving compressed data without decompressing it, we need an interface to write pre-compressed data directly to the filesystem and the matching interface to read compressed data without decompressing it. This adds the definitions for ioctls to do that and detailed explanations of how to use them.
Signed-off-by Omar Sandoval <[email protected]>
One minor nit below but otherwise LGTM:
<snip>
Quoted 17 lines
include/uapi/linux/btrfs.h +17
-0+struct btrfs_ioctl_encoded_io_args { +/* Input parameters for both reads and writes. */ + +/* +* iovecs containing encoded data. +* +* For reads, if the size of the encoded data is larger than the sum of +* iov[n].iov_len for 0 <= n < iovcnt, then the ioctl fails with +* ENOBUFS. +* +* For writes, the size of the encoded data is the sum of iov[n].iov_len +* for 0 <= n < iovcnt. This must be less than 128 KiB (this limit may +* increase in the future). This must also be less than or equal to +* unencoded_len. +*/ +const struct iovec __user *iov; +/* Number of iovecs. */
include/uapi/linux/btrfs.h struct btrfs_ioctl_get_subvol_rootref_args { · line 913
Quoted 10 lines
include/uapi/linux/btrfs.h +10
-0+unsigned long iovcnt; +/* +* Offset in file. +* +* For writes, must be aligned to the sector size of the filesystem. +*/ +__s64 offset; +/* Currently must be zero. */ +__u64 flags; +
nit: A comment stating that the output params begin here could be added.
Quoted 1 line
Re: [PATCH v11 07/14] btrfs: add definitions + documentation for encoded I/O ioctls
Quoted 40 lines · Nikolay Borisov
Quoted 9 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
In order to allow sending and receiving compressed data without decompressing it, we need an interface to write pre-compressed data directly to the filesystem and the matching interface to read compressed data without decompressing it. This adds the definitions for ioctls to do that and detailed explanations of how to use them.
Signed-off-by Omar Sandoval <[email protected]>One minor nit below but otherwise LGTM:
Reviewed-by Nikolay Borisov <[email protected]><snip>
Quoted 21 lines
include/uapi/linux/btrfs.h +21
-0+struct btrfs_ioctl_encoded_io_args { +/* Input parameters for both reads and writes. */ + +/* +* iovecs containing encoded data. +* +* For reads, if the size of the encoded data is larger than the sum of +* iov[n].iov_len for 0 <= n < iovcnt, then the ioctl fails with +* ENOBUFS. +* +* For writes, the size of the encoded data is the sum of iov[n].iov_len +* for 0 <= n < iovcnt. This must be less than 128 KiB (this limit may +* increase in the future). This must also be less than or equal to +* unencoded_len. +*/ +const struct iovec __user *iov; +/* Number of iovecs. */ +unsigned long iovcnt; +/* +* Offset in file. +*
Quoted 8 lines
include/uapi/linux/btrfs.h struct btrfs_ioctl_get_subvol_rootref_args { · line 913
Quoted 6 lines
include/uapi/linux/btrfs.h +6
-0+* For writes, must be aligned to the sector size of the filesystem. +*/ +__s64 offset; +/* Currently must be zero. */ +__u64 flags; +nit: A comment stating that the output params begin here could be added.
There is a comment in this spot:
/*
* For reads, the following members are filled in with the metadata for
* the encoded data.
* For writes, the following members must be set to the metadata for the
* encoded data.
*/
I'll clarify it to:
/*
* For reads, the following members are output parameters that will
* contain the returned metadata for the encoded data.
* For writes, the following members must be set to the metadata for the
* encoded data.
*/
PATCH v11 8/14 btrfs: add BTRFS_IOC_ENCODED_READ
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
There are 4 main cases:
1. Inline extents: we copy the data straight out of the extent buffer.
2. Hole/preallocated extents: we fill in zeroes.
3. Regular, uncompressed extents: we read the sectors we need directly from disk.
4. Regular, compressed extents: we read the entire compressed extent from disk and indicate what subset of the decompressed extent is in the file.
This initial implementation simplifies a few things that can be improved in the future:
- We hold the inode lock during the operation.
- Cases 1, 3, and 4 allocate temporary memory to read into before copying out to userspace.
- We don't do read repair, because it turns out that read repair is currently broken for compressed data.
--- fs/btrfs/ctree.h | 4 + fs/btrfs/inode.c | 489 +++++++++++++++++++++++++++++++++++++++++++++++ fs/btrfs/ioctl.c | 111 +++++++++++ 3 files changed, 604 insertions(+)
fs/btrfs/ctree.h +4 -0
@@ -3223,6 +3223,10 @@ int btrfs_writepage_cow_fixup(struct page *page);void btrfs_writepage_endio_finish_ordered (struct btrfs_inode *inode,struct page *page,u64 start,u64 end,bool uptodate); +struct btrfs_ioctl_encoded_io_args ; +ssize_t btrfs_encoded_read (struct kiocb *iocb,struct iov_iter *iter, +struct btrfs_ioctl_encoded_io_args *encoded); +extern const struct dentry_operations btrfs_dentry_operations;extern const struct iomap_ops btrfs_dio_iomap_ops;extern const struct iomap_dio_ops btrfs_dio_ops;
fs/btrfs/inode.c +489 -0
495 lines not on this page · raw message
fs/btrfs/ioctl.c +111 -0
135 lines not on this page · raw message
Signature · 1 line
2.33.0
Re: [PATCH v11 08/14] btrfs: add BTRFS_IOC_ENCODED_READ
Quoted 51 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
There are 4 main cases:
1. Inline extents: we copy the data straight out of the extent buffer.
2. Hole/preallocated extents: we fill in zeroes.
3. Regular, uncompressed extents: we read the sectors we need directly from disk.
4. Regular, compressed extents: we read the entire compressed extent from disk and indicate what subset of the decompressed extent is in the file.This initial implementation simplifies a few things that can be improved in the future:
- We hold the inode lock during the operation.
- Cases 1, 3, and 4 allocate temporary memory to read into before copying out to userspace.
- We don't do read repair, because it turns out that read repair is currently broken for compressed data.Signed-off-by Omar Sandoval <[email protected]>--- fs/btrfs/ctree.h | 4 + fs/btrfs/inode.c | 489 +++++++++++++++++++++++++++++++++++++++++++++++ fs/btrfs/ioctl.c | 111 +++++++++++ 3 files changed, 604 insertions(+)fs/btrfs/ctree.h +4
-0@@ -3223,6 +3223,10 @@ int btrfs_writepage_cow_fixup(struct page *page);void btrfs_writepage_endio_finish_ordered (struct btrfs_inode *inode,struct page *page,u64 start,u64 end,bool uptodate); +struct btrfs_ioctl_encoded_io_args ; +ssize_t btrfs_encoded_read (struct kiocb *iocb,struct iov_iter *iter, +struct btrfs_ioctl_encoded_io_args *encoded); +extern const struct dentry_operations btrfs_dentry_operations;extern const struct iomap_ops btrfs_dio_iomap_ops;extern const struct iomap_dio_ops btrfs_dio_ops;fs/btrfs/inode.c +0
-0@@ -10500,6 +10500,495 @@ void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) } }
<snip>
fs/btrfs/inode.c
Quoted 2 lines
fs/btrfs/inode.c +2
-0+ +static blk_status_t btrfs_encoded_read_check_bio (struct btrfs_io_bio *io_bio)
nit: The gist of this function is to check the csum so how about renaming it to btrfs_encoded_read_verify_csum
<snip>
fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10693
Quoted 13 lines
fs/btrfs/inode.c +13
-0+ +static void btrfs_encoded_read_endio (struct bio *bio) +{ +struct btrfs_encoded_read_private *priv = bio->bi_private; +struct btrfs_io_bio *io_bio =btrfs_io_bio (bio); +blk_status_t status; + + status =btrfs_encoded_read_check_bio (io_bio); +if (status) { +/* +* The memory barrier implied by the atomic_dec_return() here +* pairs with the memory barrier implied by the +* atomic_dec_return() or io_wait_event() in
nit: I think atomic_dec_return in read_regular_fill_pages is inconsequential, what we want to ensure is that when the caller of io_wait_event is woken up by this thread it will observe the priv->status, which it will, because the atomic-dec_return in this function has paired with the general barrier interpolated by wait_event.
So for brevity just leave the text to say "by io_wait_event".
Quoted 11 lines
fs/btrfs/inode.c +11
-0+* btrfs_encoded_read_regular_fill_pages() to ensure that this +* write is observed before the load of status in +* btrfs_encoded_read_regular_fill_pages(). +*/ +WRITE_ONCE (priv->status, status); + } +if (!atomic_dec_return (&priv->pending)) +wake_up (&priv->wait); +btrfs_io_bio_free_csum (io_bio); +bio_put (bio); +}
<snip>
Quoted 4 lines
fs/btrfs/inode.c +0
-0@@ -4824,6 +4841,94 @@ static int _btrfs_ioctl_send(struct file *file, void __user *argp, bool compat)return ret; }
<snip>
fs/btrfs/inode.c
Quoted 2 lines
fs/btrfs/inode.c +2
-0+memset ((char *)&args + copy_end_kernel,0 , +sizeof (args) - copy_end_kernel);
nit: This memset can be eliminated ( in source) by marking args = {}; and just leaving copy from user above.
Quoted 7 lines
fs/btrfs/inode.c +7
-0+ + ret =import_iovec (READ , args.iov, args.iovcnt,ARRAY_SIZE (iovstack), + &iov, &iter); +if (ret <0 ) + goto out_acct; + +if (iov_iter_count (&iter) ==0 ) {
fs/btrfs/inode.c
Quoted 10 lines
fs/btrfs/inode.c +10
-0+ ret =0 ; + goto out_iov; + } + pos = args.offset; + ret =rw_verify_area (READ , file, &pos, args.len); +if (ret <0 ) + goto out_iov; + +init_sync_kiocb (&kiocb, file); + ret =kiocb_set_rw_flags (&kiocb,0 );
This call is a noop due to:
if (!flags) return 0;
in kiocb_set_rw_flags.
<snip>
Re: [PATCH v11 08/14] btrfs: add BTRFS_IOC_ENCODED_READ
Quoted 57 lines · Nikolay Borisov
Quoted 51 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
There are 4 main cases:
1. Inline extents: we copy the data straight out of the extent buffer.
2. Hole/preallocated extents: we fill in zeroes.
3. Regular, uncompressed extents: we read the sectors we need directly from disk.
4. Regular, compressed extents: we read the entire compressed extent from disk and indicate what subset of the decompressed extent is in the file.This initial implementation simplifies a few things that can be improved in the future:
- We hold the inode lock during the operation.
- Cases 1, 3, and 4 allocate temporary memory to read into before copying out to userspace.
- We don't do read repair, because it turns out that read repair is currently broken for compressed data.Signed-off-by Omar Sandoval <[email protected]>--- fs/btrfs/ctree.h | 4 + fs/btrfs/inode.c | 489 +++++++++++++++++++++++++++++++++++++++++++++++ fs/btrfs/ioctl.c | 111 +++++++++++ 3 files changed, 604 insertions(+)fs/btrfs/ctree.h +4
-0@@ -3223,6 +3223,10 @@ int btrfs_writepage_cow_fixup(struct page *page);void btrfs_writepage_endio_finish_ordered (struct btrfs_inode *inode,struct page *page,u64 start,u64 end,bool uptodate); +struct btrfs_ioctl_encoded_io_args ; +ssize_t btrfs_encoded_read (struct kiocb *iocb,struct iov_iter *iter, +struct btrfs_ioctl_encoded_io_args *encoded); +extern const struct dentry_operations btrfs_dentry_operations;extern const struct iomap_ops btrfs_dio_iomap_ops;extern const struct iomap_dio_ops btrfs_dio_ops;fs/btrfs/inode.c +0
-0@@ -10500,6 +10500,495 @@ void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) } }<snip>
Quoted 5 lines
fs/btrfs/inode.c
Quoted 2 lines
fs/btrfs/inode.c +2
-0+ +static blk_status_t btrfs_encoded_read_check_bio (struct btrfs_io_bio *io_bio)nit: The gist of this function is to check the csum so how about renaming it to
btrfs_encoded_read_verify_csum
Good point, will do.
Quoted 20 lines
fs/btrfs/inode.c void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) · line 10693
Quoted 13 lines
fs/btrfs/inode.c +13
-0+ +static void btrfs_encoded_read_endio (struct bio *bio) +{ +struct btrfs_encoded_read_private *priv = bio->bi_private; +struct btrfs_io_bio *io_bio =btrfs_io_bio (bio); +blk_status_t status; + + status =btrfs_encoded_read_check_bio (io_bio); +if (status) { +/* +* The memory barrier implied by the atomic_dec_return() here +* pairs with the memory barrier implied by the +* atomic_dec_return() or io_wait_event() in nit: I think
atomic_dec_returninread_regular_fill_pagesis inconsequential, what we want to ensure is that when the caller ofio_wait_eventis woken up by this thread it will observe thepriv->status, which it will, because the atomic-dec_return in this function has paired with the general barrier interpolated bywait_event.
Quoted 1 line
So for brevity just leave the text to say "by
io_wait_event".
Considering that there is a code path in btrfs_encoded_read_regular_fill_pages() where atomic_dec_return() is called but io_wait_event() isn't, I think it's important to mention both. (This path should be fairly rare, since it can only happen if all of the bios are completed before the submitting thread checks the pending counter. But, it's a possible code path, and I wouldn't want someone reading the comment to be confused and think that we're missing a barrier in that case.)
Quoted 21 lines
Quoted 11 lines
fs/btrfs/inode.c +11
-0+* btrfs_encoded_read_regular_fill_pages() to ensure that this +* write is observed before the load of status in +* btrfs_encoded_read_regular_fill_pages(). +*/ +WRITE_ONCE (priv->status, status); + } +if (!atomic_dec_return (&priv->pending)) +wake_up (&priv->wait); +btrfs_io_bio_free_csum (io_bio); +bio_put (bio); +}<snip>
Quoted 4 lines
fs/btrfs/inode.c +0
-0@@ -4824,6 +4841,94 @@ static int _btrfs_ioctl_send(struct file *file, void __user *argp, bool compat)return ret; }<snip>
Quoted 5 lines
fs/btrfs/inode.c
Quoted 2 lines
fs/btrfs/inode.c +2
-0+memset ((char *)&args + copy_end_kernel,0 , +sizeof (args) - copy_end_kernel);nit: This memset can be eliminated ( in source) by marking args = {}; and just leaving copy from user above.
args = {} results in slightly worse generated code, but that doesn't really matter here, so I'll change it.
Quoted 19 lines
Quoted 7 lines
fs/btrfs/inode.c +7
-0+ + ret =import_iovec (READ , args.iov, args.iovcnt,ARRAY_SIZE (iovstack), + &iov, &iter); +if (ret <0 ) + goto out_acct; + +if (iov_iter_count (&iter) ==0 ) {fs/btrfs/inode.c
Quoted 10 lines
fs/btrfs/inode.c +10
-0+ ret =0 ; + goto out_iov; + } + pos = args.offset; + ret =rw_verify_area (READ , file, &pos, args.len); +if (ret <0 ) + goto out_iov; + +init_sync_kiocb (&kiocb, file); + ret =kiocb_set_rw_flags (&kiocb,0 );This call is a noop due to:
Quoted 4 lines
if (!flags) return 0;in
kiocb_set_rw_flags.
Good catch, I'll remove that call.
PATCH v11 9/14 btrfs: add BTRFS_IOC_ENCODED_WRITE
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
The implementation resembles direct I/O: we have to flush any ordered extents, invalidate the page cache, and do the io tree/delalloc/extent map/ordered extent dance. From there, we can reuse the compression code with a minor modification to distinguish the write from writeback. This also creates inline extents when possible.
--- fs/btrfs/compression.c | 7 +- fs/btrfs/compression.h | 6 +- fs/btrfs/ctree.h | 4 + fs/btrfs/file.c | 65 ++++++++-- fs/btrfs/inode.c | 256 +++++++++++++++++++++++++++++++++++++++- fs/btrfs/ioctl.c | 102 ++++++++++++++++ fs/btrfs/ordered-data.c | 12 +- fs/btrfs/ordered-data.h | 5 +- 8 files changed, 437 insertions(+), 20 deletions(-)
fs/btrfs/compression.c +5 -2
@@ -353,7 +353,8 @@ static void end_compressed_bio_write(struct bio *bio) cb->start, cb->start + cb->len -1 , !cb->errors); -end_compressed_writeback (inode, cb); +if (cb->writeback) +end_compressed_writeback (inode, cb);/* note, our inode could be gone now */ /*
@@ -389,7 +390,8 @@ blk_status_t btrfs_submit_compressed_write(struct btrfs_inode *inode, u64 start,struct page **compressed_pages, unsigned int nr_pages, unsigned int write_flags, - struct cgroup_subsys_state *blkcg_css) + struct cgroup_subsys_state *blkcg_css, + bool writeback) { struct btrfs_fs_info *fs_info = inode->root->fs_info;struct bio *bio =NULL ;
@@ -415,6 +417,7 @@ blk_status_t btrfs_submit_compressed_write(struct btrfs_inode *inode, u64 start, cb->mirror_num =0 ; cb->compressed_pages = compressed_pages; cb->compressed_len = compressed_len; + cb->writeback = writeback; cb->orig_bio =NULL ; cb->nr_pages = nr_pages;
fs/btrfs/compression.h +5 -1
@@ -52,6 +52,9 @@ struct compressed_bio {/* The compression algorithm for this bio */ u8 compress_type; +/* Whether this is a write for writeback. */ +bool writeback; +/* IO errors */ u8 errors;int mirror_num;
@@ -95,7 +98,8 @@ blk_status_t btrfs_submit_compressed_write(struct btrfs_inode *inode, u64 start,struct page **compressed_pages, unsigned int nr_pages, unsigned int write_flags, - struct cgroup_subsys_state *blkcg_css); + struct cgroup_subsys_state *blkcg_css, + bool writeback);blk_status_t btrfs_submit_compressed_read (struct inode *inode,struct bio *bio,int mirror_num,unsigned long bio_flags);
fs/btrfs/ctree.h +4 -0
@@ -3226,6 +3226,8 @@ void btrfs_writepage_endio_finish_ordered(struct btrfs_inode *inode,struct btrfs_ioctl_encoded_io_args ;ssize_t btrfs_encoded_read (struct kiocb *iocb,struct iov_iter *iter,struct btrfs_ioctl_encoded_io_args *encoded); +ssize_t btrfs_do_encoded_write (struct kiocb *iocb,struct iov_iter *from, +const struct btrfs_ioctl_encoded_io_args *encoded);extern const struct dentry_operations btrfs_dentry_operations;extern const struct iomap_ops btrfs_dio_iomap_ops;
@@ -3286,6 +3288,8 @@ int btrfs_replace_file_extents(struct btrfs_inode *inode, struct btrfs_trans_handle **trans_out);int btrfs_mark_extent_written (struct btrfs_trans_handle *trans,struct btrfs_inode *inode,u64 start,u64 end); +ssize_t btrfs_do_write_iter (struct kiocb *iocb,struct iov_iter *from, +const struct btrfs_ioctl_encoded_io_args *encoded);int btrfs_release_file (struct inode *inode,struct file *file); int btrfs_dirty_pages(struct btrfs_inode *inode, struct page **pages, size_t num_pages, loff_t pos, size_t write_bytes,
fs/btrfs/file.c +54 -11
94 lines not on this page · raw message
fs/btrfs/inode.c +254 -2
280 lines not on this page · raw message
fs/btrfs/ioctl.c +102 -0
123 lines not on this page · raw message
fs/btrfs/ordered-data.c +9 -3
@@ -521,9 +521,15 @@ void btrfs_remove_ordered_extent(struct btrfs_inode *btrfs_inode,spin_lock (&btrfs_inode->lock);btrfs_mod_outstanding_extents (btrfs_inode,-1 );spin_unlock (&btrfs_inode->lock); -if (root != fs_info->tree_root) -btrfs_delalloc_release_metadata (btrfs_inode, entry->num_bytes, - false); +if (root != fs_info->tree_root) { +u64 release; + +if (test_bit (BTRFS_ORDERED_ENCODED , &entry->flags)) + release = entry->disk_num_bytes; +else + release = entry->num_bytes; +btrfs_delalloc_release_metadata (btrfs_inode, release, false); + }percpu_counter_add_batch (&fs_info->ordered_bytes, -entry->num_bytes, fs_info->delalloc_batch);
fs/btrfs/ordered-data.h +4 -1
@@ -74,6 +74,8 @@ enum {BTRFS_ORDERED_LOGGED_CSUM ,/* We wait for this extent to complete in the current transaction */ BTRFS_ORDERED_PENDING , +/* BTRFS_IOC_ENCODED_WRITE */ + BTRFS_ORDERED_ENCODED, };/* BTRFS_ORDERED_* flags that specify the type of the extent. */
@@ -81,7 +83,8 @@ enum { (1UL <<BTRFS_ORDERED_NOCOW ) | \ (1UL <<BTRFS_ORDERED_PREALLOC ) | \ (1UL <<BTRFS_ORDERED_COMPRESSED ) | \ - (1UL << BTRFS_ORDERED_DIRECT)) + (1UL <<BTRFS_ORDERED_DIRECT ) | \ + (1UL << BTRFS_ORDERED_ENCODED)) struct btrfs_ordered_extent {/* logical offset in the file */
Signature · 1 line
2.33.0
PATCH v11 10/14 btrfs: add send stream v2 definitions
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
This adds the definitions of the new commands for send stream version 2 and their respective attributes: fallocate, FS_IOC_SETFLAGS (a.k.a. chattr), and encoded writes. It also documents two changes to the send stream format in v2: the receiver shouldn't assume a maximum command size, and the DATA attribute is encoded differently to allow for writes larger than 64k. These will be implemented in subsequent changes, and then the ioctl will accept the new flags.
--- fs/btrfs/send.c | 2 +- fs/btrfs/send.h | 30 +++++++++++++++++++++++++++++- include/uapi/linux/btrfs.h | 13 +++++++++++++ 3 files changed, 43 insertions(+), 2 deletions(-)
fs/btrfs/send.c +1 -1
@@ -7287,7 +7287,7 @@ long btrfs_ioctl_send(struct file *mnt_file, struct btrfs_ioctl_send_args *arg) sctx->clone_roots_cnt = arg->clone_sources_count; - sctx->send_max_size =BTRFS_SEND_BUF_SIZE ; + sctx->send_max_size =BTRFS_SEND_BUF_SIZE_V1 ; sctx->send_buf =kvmalloc (sctx->send_max_size,GFP_KERNEL );if (!sctx->send_buf) { ret = -ENOMEM ;
fs/btrfs/send.h +29 -1
@@ -12,7 +12,11 @@#define BTRFS_SEND_STREAM_MAGIC "btrfs-stream"#define BTRFS_SEND_STREAM_VERSION 1 -#define BTRFS_SEND_BUF_SIZE SZ_64K +/* +* In send stream v1, no command is larger than 64k. In send stream v2, no limit +* should be assumed. +*/ +#define BTRFS_SEND_BUF_SIZE_V1 SZ_64Kenum btrfs_tlv_type {BTRFS_TLV_U8 ,
@@ -76,6 +80,13 @@ enum btrfs_send_cmd {BTRFS_SEND_C_END ,BTRFS_SEND_C_UPDATE_EXTENT , + +/* The following commands were added in send stream v2. */ + +BTRFS_SEND_C_FALLOCATE , +BTRFS_SEND_C_SETFLAGS , +BTRFS_SEND_C_ENCODED_WRITE , + __BTRFS_SEND_C_MAX, };#define BTRFS_SEND_C_MAX (__BTRFS_SEND_C_MAX - 1)
@@ -106,6 +117,11 @@ enum {BTRFS_SEND_A_PATH_LINK ,BTRFS_SEND_A_FILE_OFFSET , +/* +* In send stream v2, this attribute is special: it must be the last +* attribute in a command, its header contains only the type, and its +* length is implicitly the remaining length of the command. +*/ BTRFS_SEND_A_DATA , BTRFS_SEND_A_CLONE_UUID,
@@ -114,6 +130,18 @@ enum {BTRFS_SEND_A_CLONE_OFFSET ,BTRFS_SEND_A_CLONE_LEN , +/* The following attributes were added in send stream v2. */ + +BTRFS_SEND_A_FALLOCATE_MODE , + +BTRFS_SEND_A_SETFLAGS_FLAGS , + +BTRFS_SEND_A_UNENCODED_FILE_LEN , +BTRFS_SEND_A_UNENCODED_LEN , +BTRFS_SEND_A_UNENCODED_OFFSET , +BTRFS_SEND_A_COMPRESSION , +BTRFS_SEND_A_ENCRYPTION , + __BTRFS_SEND_A_MAX, };#define BTRFS_SEND_A_MAX (__BTRFS_SEND_A_MAX - 1)
include/uapi/linux/btrfs.h +13 -0
@@ -771,6 +771,19 @@ struct btrfs_ioctl_received_subvol_args {*/ #define BTRFS_SEND_FLAG_OMIT_END_CMD 0x4 +/* +* Use version 2 of the send stream, which adds new commands and supports larger +* writes. +*/ +#define BTRFS_SEND_FLAG_STREAM_V2 0x8 + +/* +* Send compressed data using the ENCODED_WRITE command instead of decompressing +* the data and sending it with the WRITE command. This requires +* BTRFS_SEND_FLAG_STREAM_V2. +*/ +#define BTRFS_SEND_FLAG_COMPRESSED 0x10 +#define BTRFS_SEND_FLAG_MASK \ (BTRFS_SEND_FLAG_NO_FILE_DATA | \ BTRFS_SEND_FLAG_OMIT_STREAM_HEADER | \
Signature · 1 line
2.33.0
Re: [PATCH v11 10/14] btrfs: add send stream v2 definitions
Quoted 10 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
This adds the definitions of the new commands for send stream version 2 and their respective attributes: fallocate,
FS_IOC_SETFLAGS(a.k.a. chattr), and encoded writes. It also documents two changes to the send stream format in v2: the receiver shouldn't assume a maximum command size, and the DATA attribute is encoded differently to allow for writes larger than 64k. These will be implemented in subsequent changes, and then the ioctl will accept the new flags.
Quoted 2 lines
Reviewed-by Josef Bacik <[email protected]>Signed-off-by Omar Sandoval <[email protected]>
Re: [PATCH v11 10/14] btrfs: add send stream v2 definitions
In reply to Omar SandovalQuoted 63 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
This adds the definitions of the new commands for send stream version 2 and their respective attributes: fallocate,
FS_IOC_SETFLAGS(a.k.a. chattr), and encoded writes. It also documents two changes to the send stream format in v2: the receiver shouldn't assume a maximum command size, and the DATA attribute is encoded differently to allow for writes larger than 64k. These will be implemented in subsequent changes, and then the ioctl will accept the new flags.Reviewed-by Josef Bacik <[email protected]>Signed-off-by Omar Sandoval <[email protected]>--- fs/btrfs/send.c | 2 +- fs/btrfs/send.h | 30 +++++++++++++++++++++++++++++- include/uapi/linux/btrfs.h | 13 +++++++++++++ 3 files changed, 43 insertions(+), 2 deletions(-)fs/btrfs/send.c +1
-1@@ -7287,7 +7287,7 @@ long btrfs_ioctl_send(struct file *mnt_file, struct btrfs_ioctl_send_args *arg) sctx->clone_roots_cnt = arg->clone_sources_count; - sctx->send_max_size =BTRFS_SEND_BUF_SIZE ; + sctx->send_max_size =BTRFS_SEND_BUF_SIZE_V1 ; sctx->send_buf =kvmalloc (sctx->send_max_size,GFP_KERNEL );if (!sctx->send_buf) { ret = -ENOMEM ;fs/btrfs/send.h +12
-1@@ -12,7 +12,11 @@#define BTRFS_SEND_STREAM_MAGIC "btrfs-stream"#define BTRFS_SEND_STREAM_VERSION 1 -#define BTRFS_SEND_BUF_SIZE SZ_64K +/* +* In send stream v1, no command is larger than 64k. In send stream v2, no limit +* should be assumed. +*/ +#define BTRFS_SEND_BUF_SIZE_V1 SZ_64Kenum btrfs_tlv_type {BTRFS_TLV_U8 ,@@ -76,6 +80,13 @@ enum btrfs_send_cmd {BTRFS_SEND_C_END ,BTRFS_SEND_C_UPDATE_EXTENT , + +/* The following commands were added in send stream v2. */ + +BTRFS_SEND_C_FALLOCATE , +BTRFS_SEND_C_SETFLAGS , +BTRFS_SEND_C_ENCODED_WRITE , + __BTRFS_SEND_C_MAX, };#define BTRFS_SEND_C_MAX (__BTRFS_SEND_C_MAX - 1)
fs/btrfs/send.h enum { · line 125
Quoted 9 lines
fs/btrfs/send.h +5
-0@@ -106,6 +117,11 @@ enum {BTRFS_SEND_A_PATH_LINK ,BTRFS_SEND_A_FILE_OFFSET , +/* +* In send stream v2, this attribute is special: it must be the last +* attribute in a command, its header contains only the type, and its +* length is implicitly the remaining length of the command. +*/ BTRFS_SEND_A_DATA,
Now that I think more about this, it would be best if this logic is actually codified in the code. I.e first set of SEND_A_DATA would set some bool/flag in the sctx and subsequent calls would be able to ASSERT/WARN ?
Re: [PATCH v11 10/14] btrfs: add send stream v2 definitions
Quoted 68 lines · Nikolay Borisov
Quoted 65 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
This adds the definitions of the new commands for send stream version 2 and their respective attributes: fallocate,
FS_IOC_SETFLAGS(a.k.a. chattr), and encoded writes. It also documents two changes to the send stream format in v2: the receiver shouldn't assume a maximum command size, and the DATA attribute is encoded differently to allow for writes larger than 64k. These will be implemented in subsequent changes, and then the ioctl will accept the new flags.Reviewed-by Josef Bacik <[email protected]>Signed-off-by Omar Sandoval <[email protected]>--- fs/btrfs/send.c | 2 +- fs/btrfs/send.h | 30 +++++++++++++++++++++++++++++- include/uapi/linux/btrfs.h | 13 +++++++++++++ 3 files changed, 43 insertions(+), 2 deletions(-)fs/btrfs/send.c +1
-1@@ -7287,7 +7287,7 @@ long btrfs_ioctl_send(struct file *mnt_file, struct btrfs_ioctl_send_args *arg) sctx->clone_roots_cnt = arg->clone_sources_count; - sctx->send_max_size =BTRFS_SEND_BUF_SIZE ; + sctx->send_max_size =BTRFS_SEND_BUF_SIZE_V1 ; sctx->send_buf =kvmalloc (sctx->send_max_size,GFP_KERNEL );if (!sctx->send_buf) { ret = -ENOMEM ;fs/btrfs/send.h +12
-1@@ -12,7 +12,11 @@#define BTRFS_SEND_STREAM_MAGIC "btrfs-stream"#define BTRFS_SEND_STREAM_VERSION 1 -#define BTRFS_SEND_BUF_SIZE SZ_64K +/* +* In send stream v1, no command is larger than 64k. In send stream v2, no limit +* should be assumed. +*/ +#define BTRFS_SEND_BUF_SIZE_V1 SZ_64Kenum btrfs_tlv_type {BTRFS_TLV_U8 ,@@ -76,6 +80,13 @@ enum btrfs_send_cmd {BTRFS_SEND_C_END ,BTRFS_SEND_C_UPDATE_EXTENT , + +/* The following commands were added in send stream v2. */ + +BTRFS_SEND_C_FALLOCATE , +BTRFS_SEND_C_SETFLAGS , +BTRFS_SEND_C_ENCODED_WRITE , + __BTRFS_SEND_C_MAX, };#define BTRFS_SEND_C_MAX (__BTRFS_SEND_C_MAX - 1)@@ -106,6 +117,11 @@ enum { BTRFS_SEND_A_PATH_LINK,
Quoted 12 lines
fs/btrfs/send.h enum { · line 125
Quoted 7 lines
fs/btrfs/send.h +5
-0BTRFS_SEND_A_FILE_OFFSET , +/* +* In send stream v2, this attribute is special: it must be the last +* attribute in a command, its header contains only the type, and its +* length is implicitly the remaining length of the command. +*/ BTRFS_SEND_A_DATA,Now that I think more about this, it would be best if this logic is actually codified in the code. I.e first set of
SEND_A_DATAwould set some bool/flag in the sctx and subsequent calls would be able to ASSERT/WARN ?
I suppose I could do something like this, is that what you had in mind?
fs/btrfs/send.c +9 -0
@@ -81,6 +81,7 @@ struct send_ctx {char *send_buf;u32 send_size;u32 send_max_size; +bool put_data;struct page **send_buf_pages;u64 total_send_size;u64 cmd_send_size[BTRFS_SEND_C_MAX +1 ];
@@ -575,6 +576,9 @@ static int tlv_put(struct send_ctx *sctx, u16 attr, const void *data, int len)int total_len =sizeof (*hdr) + len;int left = sctx->send_max_size - sctx->send_size; +if (WARN_ON (sctx->put_data)) +return -EINVAL ; +if (unlikely (left < total_len))return -EOVERFLOW ;
@@ -718,6 +722,7 @@ static int send_cmd(struct send_ctx *sctx) sctx->total_send_size += sctx->send_size; sctx->cmd_send_size[get_unaligned_le16 (&hdr->cmd)] += sctx->send_size; sctx->send_size =0 ; + sctx->put_data = false;return ret; }
@@ -4913,6 +4918,9 @@ static inline u64 max_send_read_size(const struct send_ctx *sctx)static int put_data_header (struct send_ctx *sctx,u32 len) { +if (WARN_ON (sctx->put_data)) +return -EINVAL ; + sctx->put_data = true;if (sctx->flags &BTRFS_SEND_FLAG_STREAM_V2 ) {/* * In v2, the data attribute header doesn't include a length; it
@@ -5368,6 +5376,7 @@ static int send_encoded_extent(struct send_ctx *sctx, struct btrfs_path *path, sctx->cmd_send_size[le16_to_cpu (hdr->cmd)] += sctx->send_size + block_len; sctx->send_size =0 ; + sctx->put_data = false; tlv_put_failure: out:
Re: [PATCH v11 10/14] btrfs: add send stream v2 definitions
Quoted 1 line · Omar Sandoval
I suppose I could do something like this, is that what you had in mind?
Yes, however I think it needs to be augmented a bit like making this member populated/checked only if V2 is being used? But that's generally what I had in mind.
PATCH v11 11/14 btrfs: send: write larger chunks when using stream v2
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
The length field of the send stream TLV header is 16 bits. This means that the maximum amount of data that can be sent for one write is 64k minus one. However, encoded writes must be able to send the maximum compressed extent (128k) in one command. To support this, send stream version 2 encodes the DATA attribute differently: it has no length field, and the length is implicitly up to the end of containing command (which has a 32-bit length field). Although this is necessary for encoded writes, normal writes can benefit from it, too.
For v2, let's bump up the send buffer to the maximum compressed extent size plus 16k for the other metadata (144k total). Since this will most likely be vmalloc'd (and always will be after the next commit), we round it up to the next page since we might as well use the rest of the page on systems with >16k pages.
--- fs/btrfs/send.c | 34 ++++++++++++++++++++++++++-------- 1 file changed, 26 insertions(+), 8 deletions(-)
fs/btrfs/send.c +26 -8
@@ -4908,14 +4908,27 @@ static inline u64 max_send_read_size(const struct send_ctx *sctx)static int put_data_header (struct send_ctx *sctx,u32 len) { -struct btrfs_tlv_header *hdr; +if (sctx->flags &BTRFS_SEND_FLAG_STREAM_V2 ) { +/* +* In v2, the data attribute header doesn't include a length; it +* is implicitly to the end of the command. +*/ +if (sctx->send_max_size - sctx->send_size <2 + len) +return -EOVERFLOW ; +put_unaligned_le16 (BTRFS_SEND_A_DATA , + sctx->send_buf + sctx->send_size); + sctx->send_size +=2 ; + }else { +struct btrfs_tlv_header *hdr; -if (sctx->send_max_size - sctx->send_size <sizeof (*hdr) + len) -return -EOVERFLOW ; - hdr = (struct btrfs_tlv_header *)(sctx->send_buf + sctx->send_size); -put_unaligned_le16 (BTRFS_SEND_A_DATA , &hdr->tlv_type); -put_unaligned_le16 (len, &hdr->tlv_len); - sctx->send_size +=sizeof (*hdr); +if (sctx->send_max_size - sctx->send_size <sizeof (*hdr) + len) +return -EOVERFLOW ; + hdr = (struct btrfs_tlv_header *)(sctx->send_buf + + sctx->send_size); +put_unaligned_le16 (BTRFS_SEND_A_DATA , &hdr->tlv_type); +put_unaligned_le16 (len, &hdr->tlv_len); + sctx->send_size +=sizeof (*hdr); + }return 0 ; }
@@ -7287,7 +7300,12 @@ long btrfs_ioctl_send(struct file *mnt_file, struct btrfs_ioctl_send_args *arg) sctx->clone_roots_cnt = arg->clone_sources_count; - sctx->send_max_size =BTRFS_SEND_BUF_SIZE_V1 ; +if (sctx->flags &BTRFS_SEND_FLAG_STREAM_V2 ) { + sctx->send_max_size =ALIGN (SZ_16K +BTRFS_MAX_COMPRESSED , +PAGE_SIZE ); + }else { + sctx->send_max_size =BTRFS_SEND_BUF_SIZE_V1 ; + } sctx->send_buf =kvmalloc (sctx->send_max_size,GFP_KERNEL );if (!sctx->send_buf) { ret = -ENOMEM ;
Signature · 1 line
2.33.0
Re: [PATCH v11 11/14] btrfs: send: write larger chunks when using stream v2
Quoted 11 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
The length field of the send stream TLV header is 16 bits. This means that the maximum amount of data that can be sent for one write is 64k minus one. However, encoded writes must be able to send the maximum compressed extent (128k) in one command. To support this, send stream version 2 encodes the DATA attribute differently: it has no length field, and the length is implicitly up to the end of containing command (which has a 32-bit length field). Although this is necessary for encoded writes, normal writes can benefit from it, too.
Quoted 7 lines
For v2, let's bump up the send buffer to the maximum compressed extent size plus 16k for the other metadata (144k total). Since this will most likely be vmalloc'd (and always will be after the next commit), we round it up to the next page since we might as well use the rest of the page on systems with >16k pages.
Signed-off-by Omar Sandoval <[email protected]>
PATCH v11 12/14 btrfs: send: allocate send buffer with alloc_page() and vmap() for v2
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
For encoded writes, we need the raw pages for reading compressed data directly via a bio. So, replace kvmalloc() with vmap() so we have access to the raw pages. 144k is large enough that it usually gets allocated with vmalloc(), anyways.
--- fs/btrfs/send.c | 33 +++++++++++++++++++++++++++++++-- 1 file changed, 31 insertions(+), 2 deletions(-)
fs/btrfs/send.c +31 -2
@@ -81,6 +81,7 @@ struct send_ctx {char *send_buf;u32 send_size;u32 send_max_size; +struct page **send_buf_pages;u64 total_send_size;u64 cmd_send_size[BTRFS_SEND_C_MAX +1 ];u64 flags;/* 'flags' member of btrfs_ioctl_send_args is u64 */
@@ -7223,6 +7224,7 @@ long btrfs_ioctl_send(struct file *mnt_file, struct btrfs_ioctl_send_args *arg)struct btrfs_root *clone_root;struct send_ctx *sctx =NULL ;u32 i; +u32 send_buf_num_pages =0 ;u64 *clone_sources_tmp =NULL ;int clone_sources_to_rollback =0 ;size_t alloc_size;
@@ -7303,10 +7305,28 @@ long btrfs_ioctl_send(struct file *mnt_file, struct btrfs_ioctl_send_args *arg)if (sctx->flags &BTRFS_SEND_FLAG_STREAM_V2 ) { sctx->send_max_size =ALIGN (SZ_16K +BTRFS_MAX_COMPRESSED ,PAGE_SIZE ); + send_buf_num_pages = sctx->send_max_size >>PAGE_SHIFT ; + sctx->send_buf_pages =kcalloc (send_buf_num_pages, +sizeof (*sctx->send_buf_pages), +GFP_KERNEL ); +if (!sctx->send_buf_pages) { + send_buf_num_pages =0 ; + ret = -ENOMEM ; + goto out; + } +for (i =0 ; i < send_buf_num_pages; i++) { + sctx->send_buf_pages[i] =alloc_page (GFP_KERNEL ); +if (!sctx->send_buf_pages[i]) { + ret = -ENOMEM ; + goto out; + } + } + sctx->send_buf =vmap (sctx->send_buf_pages, send_buf_num_pages, +VM_MAP ,PAGE_KERNEL ); }else { sctx->send_max_size =BTRFS_SEND_BUF_SIZE_V1 ; + sctx->send_buf =kvmalloc (sctx->send_max_size,GFP_KERNEL ); } - sctx->send_buf =kvmalloc (sctx->send_max_size,GFP_KERNEL );if (!sctx->send_buf) { ret = -ENOMEM ; goto out;
@@ -7513,7 +7533,16 @@ long btrfs_ioctl_send(struct file *mnt_file, struct btrfs_ioctl_send_args *arg)fput (sctx->send_filp);kvfree (sctx->clone_roots); -kvfree (sctx->send_buf); +if (sctx->flags &BTRFS_SEND_FLAG_STREAM_V2 ) { +vunmap (sctx->send_buf); +for (i =0 ; i < send_buf_num_pages; i++) { +if (sctx->send_buf_pages[i]) +__free_page (sctx->send_buf_pages[i]); + } +kfree (sctx->send_buf_pages); + }else { +kvfree (sctx->send_buf); + }name_cache_free (sctx);
Signature · 1 line
2.33.0
Re: [PATCH v11 12/14] btrfs: send: allocate send buffer with alloc_page() and vmap() for v2
Quoted 8 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
For encoded writes, we need the raw pages for reading compressed data directly via a bio. So, replace
kvmalloc()withvmap()so we have access to the raw pages. 144k is large enough that it usually gets allocated withvmalloc(), anyways.Signed-off-by Omar Sandoval <[email protected]>
PATCH v11 13/14 btrfs: send: send compressed extents with encoded writes
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
Now that all of the pieces are in place, we can use the ENCODED_WRITE command to send compressed extents when appropriate.
--- fs/btrfs/ctree.h | 4 + fs/btrfs/inode.c | 6 +- fs/btrfs/send.c | 230 +++++++++++++++++++++++++++++++++++++++++++---- 3 files changed, 220 insertions(+), 20 deletions(-)
fs/btrfs/ctree.h +4 -0
@@ -3223,6 +3223,10 @@ int btrfs_writepage_cow_fixup(struct page *page);void btrfs_writepage_endio_finish_ordered (struct btrfs_inode *inode,struct page *page,u64 start,u64 end,bool uptodate); +int btrfs_encoded_io_compression_from_extent (int compress_type); +int btrfs_encoded_read_regular_fill_pages (struct inode *inode,u64 offset, +u64 disk_io_size, +struct page **pages);struct btrfs_ioctl_encoded_io_args ;ssize_t btrfs_encoded_read (struct kiocb *iocb,struct iov_iter *iter,struct btrfs_ioctl_encoded_io_args *encoded);
fs/btrfs/inode.c +3 -3
@@ -10502,7 +10502,7 @@ void btrfs_set_range_writeback(struct btrfs_inode *inode, u64 start, u64 end) } } -static int btrfs_encoded_io_compression_from_extent (int compress_type) +int btrfs_encoded_io_compression_from_extent (int compress_type) {switch (compress_type) {case BTRFS_COMPRESS_NONE :
@@ -10705,8 +10705,8 @@ static void btrfs_encoded_read_endio(struct bio *bio)bio_put (bio); } -static int btrfs_encoded_read_regular_fill_pages (struct inode *inode,u64 offset, -u64 disk_io_size,struct page **pages) +int btrfs_encoded_read_regular_fill_pages (struct inode *inode,u64 offset, +u64 disk_io_size,struct page **pages) {struct btrfs_fs_info *fs_info =btrfs_sb (inode->i_sb);struct btrfs_encoded_read_private priv = {
fs/btrfs/send.c +213 -17
292 lines not on this page · raw message
Signature · 1 line
2.33.0
Re: [PATCH v11 13/14] btrfs: send: send compressed extents with encoded writes
Quoted 6 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
Now that all of the pieces are in place, we can use the
ENCODED_WRITEcommand to send compressed extents when appropriate.Signed-off-by Omar Sandoval <[email protected]>
Overall looks sane but consider some of the nits below.
<snip>
Quoted 29 lines
fs/btrfs/send.c +29
-0+static int send_encoded_extent (struct send_ctx *sctx,struct btrfs_path *path, +u64 offset,u64 len) +{ +struct btrfs_root *root = sctx->send_root; +struct btrfs_fs_info *fs_info = root->fs_info; +struct inode *inode; +struct fs_path *p; +struct extent_buffer *leaf = path->nodes[0 ]; +struct btrfs_key key; +struct btrfs_file_extent_item *ei; +u64 block_start; +u64 block_len; +u32 data_offset; +struct btrfs_cmd_header *hdr; +u32 crc; +int ret; + + inode =btrfs_iget (fs_info->sb, sctx->cur_ino, root); +if (IS_ERR (inode)) +return PTR_ERR (inode); + + p =fs_path_alloc (); +if (!p) { + ret = -ENOMEM ; + goto out; + } + + ret =begin_cmd (sctx,BTRFS_SEND_C_ENCODED_WRITE ); +if (ret <0 )
fs/btrfs/send.c static int send_hole(struct send_ctx *sctx, u64 end) · line 5314
Quoted 10 lines
fs/btrfs/send.c +10
-0+ goto out; + + ret =get_cur_path (sctx, sctx->cur_ino, sctx->cur_inode_gen, p); +if (ret <0 ) + goto out; + +btrfs_item_key_to_cpu (leaf, &key, path->slots[0 ]); + ei =btrfs_item_ptr (leaf, path->slots[0 ], + struct btrfs_file_extent_item); + block_start =btrfs_file_extent_disk_bytenr (leaf, ei);
block_start is somewhat ambiguous here, this is just the disk bytenr of the extent.
fs/btrfs/send.c static int send_hole(struct send_ctx *sctx, u64 end) · line 5315
Quoted 1 line
fs/btrfs/send.c +1
-0+ block_len =btrfs_file_extent_disk_num_bytes (leaf, ei);
Why is this called block_len when it's just the size in bytes on-disk?
Quoted 12 lines
fs/btrfs/send.c +12
-0+ +TLV_PUT_PATH (sctx,BTRFS_SEND_A_PATH , p); +TLV_PUT_U64 (sctx,BTRFS_SEND_A_FILE_OFFSET , offset); +TLV_PUT_U64 (sctx,BTRFS_SEND_A_UNENCODED_FILE_LEN , +min (key.offset +btrfs_file_extent_num_bytes (leaf, ei) - offset, + len)); +TLV_PUT_U64 (sctx,BTRFS_SEND_A_UNENCODED_LEN , +btrfs_file_extent_ram_bytes (leaf, ei)); +TLV_PUT_U64 (sctx,BTRFS_SEND_A_UNENCODED_OFFSET , + offset - key.offset +btrfs_file_extent_offset (leaf, ei)); + ret =btrfs_encoded_io_compression_from_extent ( +btrfs_file_extent_compression (leaf, ei));
fs/btrfs/send.c static int send_hole(struct send_ctx *sctx, u64 end) · line 5337
Quoted 10 lines
fs/btrfs/send.c +10
-0+if (ret <0 ) + goto out; +TLV_PUT_U32 (sctx,BTRFS_SEND_A_COMPRESSION , ret); +TLV_PUT_U32 (sctx,BTRFS_SEND_A_ENCRYPTION ,0 ); + + ret =put_data_header (sctx, block_len); +if (ret <0 ) + goto out; + + data_offset =ALIGN (sctx->send_size,PAGE_SIZE );
nit: The whole data_offset warrants a comment here, since send_buf is now mapped from send_buf_pages, so all the TLV you've put before are actually stored in the beginning of send_buf_pages, so by doing the above you ensure the data write begins on a clean page boundary ...
Quoted 8 lines
fs/btrfs/send.c +8
-0+if (data_offset > sctx->send_max_size || + sctx->send_max_size - data_offset < block_len) { + ret = -EOVERFLOW ; + goto out; + } + + ret = btrfs_encoded_read_regular_fill_pages(inode, block_start, + block_len,
fs/btrfs/send.c static int send_hole(struct send_ctx *sctx, u64 end) · line 5355
Quoted 10 lines
fs/btrfs/send.c +10
-0+ sctx->send_buf_pages + + (data_offset >> PAGE_SHIFT)); +if (ret) + goto out; + + hdr = (struct btrfs_cmd_header *)sctx->send_buf; + hdr->len =cpu_to_le32 (sctx->send_size + block_len -sizeof (*hdr)); + hdr->crc =0 ; + crc =btrfs_crc32c (0 , sctx->send_buf, sctx->send_size); + crc =btrfs_crc32c (crc, sctx->send_buf + data_offset, block_len);
... and because of that you can't simply use send_cmd ;(
Quoted 12 lines
fs/btrfs/send.c +12
-0+ hdr->crc =cpu_to_le32 (crc); + + ret =write_buf (sctx->send_filp, sctx->send_buf, sctx->send_size, + &sctx->send_off); +if (!ret) { + ret =write_buf (sctx->send_filp, sctx->send_buf + data_offset, + block_len, &sctx->send_off); + } + sctx->total_send_size += sctx->send_size + block_len; + sctx->cmd_send_size[le16_to_cpu (hdr->cmd)] += + sctx->send_size + block_len; + sctx->send_size =0 ;
fs/btrfs/send.c static int send_hole(struct send_ctx *sctx, u64 end) · line 5377
Quoted 10 lines
fs/btrfs/send.c +10
-0+ +tlv_put_failure: +out: +fs_path_free (p); +iput (inode); +return ret; +} + +static int send_extent_data (struct send_ctx *sctx,struct btrfs_path *path, +const u64 offset,const u64 len)
nit: Instead of sending around a btrfs_path struct around and "polluting" callees to deal with the oddities of our btree interface i.e btrfs_item_ptr et al. Why not refactor the code so that when we know we are about to send an extent data simply initialize some struct extent_info with all the necessary data items: extent type, compression type, based on the extent type properly initialize a size attribute etc and pass that. Right now you have send_extent_data fiddling with path->nodes[0], then based on that you either call send_encoded_inline_extent or send_encoded_extent, instead pass extent_info to send_extent_data/clone_range and be done with it.
<snip>
Re: [PATCH v11 13/14] btrfs: send: send compressed extents with encoded writes
Quoted 58 lines · Nikolay Borisov
Quoted 6 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
Now that all of the pieces are in place, we can use the
ENCODED_WRITEcommand to send compressed extents when appropriate.Signed-off-by Omar Sandoval <[email protected]>Overall looks sane but consider some of the nits below.
<snip>
Quoted 29 lines
fs/btrfs/send.c +29
-0+static int send_encoded_extent (struct send_ctx *sctx,struct btrfs_path *path, +u64 offset,u64 len) +{ +struct btrfs_root *root = sctx->send_root; +struct btrfs_fs_info *fs_info = root->fs_info; +struct inode *inode; +struct fs_path *p; +struct extent_buffer *leaf = path->nodes[0 ]; +struct btrfs_key key; +struct btrfs_file_extent_item *ei; +u64 block_start; +u64 block_len; +u32 data_offset; +struct btrfs_cmd_header *hdr; +u32 crc; +int ret; + + inode =btrfs_iget (fs_info->sb, sctx->cur_ino, root); +if (IS_ERR (inode)) +return PTR_ERR (inode); + + p =fs_path_alloc (); +if (!p) { + ret = -ENOMEM ; + goto out; + } + + ret =begin_cmd (sctx,BTRFS_SEND_C_ENCODED_WRITE ); +if (ret <0 )fs/btrfs/send.c static int send_hole(struct send_ctx *sctx, u64 end) · line 5314
Quoted 10 lines
fs/btrfs/send.c +10
-0+ goto out; + + ret =get_cur_path (sctx, sctx->cur_ino, sctx->cur_inode_gen, p); +if (ret <0 ) + goto out; + +btrfs_item_key_to_cpu (leaf, &key, path->slots[0 ]); + ei =btrfs_item_ptr (leaf, path->slots[0 ], + struct btrfs_file_extent_item); + block_start =btrfs_file_extent_disk_bytenr (leaf, ei);
block_startis somewhat ambiguous here, this is just the disk bytenr of the extent.
Quoted 3 lines
fs/btrfs/send.c static int send_hole(struct send_ctx *sctx, u64 end) · line 5315
Quoted 1 line
fs/btrfs/send.c +1
-0+ block_len =btrfs_file_extent_disk_num_bytes (leaf, ei);Why is this called
block_lenwhen it's just the size in bytes on-disk?
I copied this naming from extent_map since btrfs_encoded_read() was the reference for this code, but I'll change the naming here.
Quoted 19 lines
Quoted 19 lines
fs/btrfs/send.c +19
-0+ +TLV_PUT_PATH (sctx,BTRFS_SEND_A_PATH , p); +TLV_PUT_U64 (sctx,BTRFS_SEND_A_FILE_OFFSET , offset); +TLV_PUT_U64 (sctx,BTRFS_SEND_A_UNENCODED_FILE_LEN , +min (key.offset +btrfs_file_extent_num_bytes (leaf, ei) - offset, + len)); +TLV_PUT_U64 (sctx,BTRFS_SEND_A_UNENCODED_LEN , +btrfs_file_extent_ram_bytes (leaf, ei)); +TLV_PUT_U64 (sctx,BTRFS_SEND_A_UNENCODED_OFFSET , + offset - key.offset +btrfs_file_extent_offset (leaf, ei)); + ret =btrfs_encoded_io_compression_from_extent ( +btrfs_file_extent_compression (leaf, ei)); +if (ret <0 ) + goto out; +TLV_PUT_U32 (sctx,BTRFS_SEND_A_COMPRESSION , ret); +TLV_PUT_U32 (sctx,BTRFS_SEND_A_ENCRYPTION ,0 ); + + ret =put_data_header (sctx, block_len); +if (ret <0 )
Quoted 8 lines
fs/btrfs/send.c static int send_hole(struct send_ctx *sctx, u64 end) · line 5337
Quoted 3 lines
fs/btrfs/send.c +3
-0+ goto out; + + data_offset =ALIGN (sctx->send_size,PAGE_SIZE );nit: The whole
data_offsetwarrants a comment here, sincesend_bufis now mapped fromsend_buf_pages, so all the TLV you've put before are actually stored in the beginning ofsend_buf_pages, so by doing the above you ensure the data write begins on a clean page boundary ...
Yup, I'll add a comment.
Quoted 46 lines
Quoted 8 lines
fs/btrfs/send.c +8
-0+if (data_offset > sctx->send_max_size || + sctx->send_max_size - data_offset < block_len) { + ret = -EOVERFLOW ; + goto out; + } + + ret = btrfs_encoded_read_regular_fill_pages(inode, block_start, + block_len,fs/btrfs/send.c static int send_hole(struct send_ctx *sctx, u64 end) · line 5355
Quoted 10 lines
fs/btrfs/send.c +10
-0+ sctx->send_buf_pages + + (data_offset >> PAGE_SHIFT)); +if (ret) + goto out; + + hdr = (struct btrfs_cmd_header *)sctx->send_buf; + hdr->len =cpu_to_le32 (sctx->send_size + block_len -sizeof (*hdr)); + hdr->crc =0 ; + crc =btrfs_crc32c (0 , sctx->send_buf, sctx->send_size); + crc =btrfs_crc32c (crc, sctx->send_buf + data_offset, block_len);... and because of that you can't simply use
send_cmd;(Quoted 12 lines
fs/btrfs/send.c +12
-0+ hdr->crc =cpu_to_le32 (crc); + + ret =write_buf (sctx->send_filp, sctx->send_buf, sctx->send_size, + &sctx->send_off); +if (!ret) { + ret =write_buf (sctx->send_filp, sctx->send_buf + data_offset, + block_len, &sctx->send_off); + } + sctx->total_send_size += sctx->send_size + block_len; + sctx->cmd_send_size[le16_to_cpu (hdr->cmd)] += + sctx->send_size + block_len; + sctx->send_size =0 ;fs/btrfs/send.c static int send_hole(struct send_ctx *sctx, u64 end) · line 5377
Quoted 10 lines
fs/btrfs/send.c +10
-0+ +tlv_put_failure: +out: +fs_path_free (p); +iput (inode); +return ret; +} + +static int send_extent_data (struct send_ctx *sctx,struct btrfs_path *path, +const u64 offset,const u64 len)nit: Instead of sending around a
btrfs_pathstruct around and "polluting" callees to deal with the oddities of our btree interface i.e
Quoted 8 lines
btrfs_item_ptret al. Why not refactor the code so that when we know we are about to send an extent data simply initialize some structextent_infowith all the necessary data items: extent type, compression type, based on the extent type properly initialize a size attribute etc and pass that. Right now you havesend_extent_datafiddling with path->nodes[0], then based on that you either callsend_encoded_inline_extentorsend_encoded_extent, instead passextent_infoto send_extent_data/clone_range and be done with it.
I don't like this for a few reasons:
* An extra "struct extent_info" layer of abstraction would just be extra cognitive overhead. I hate having to trace back where the fields in some struct came from when it's information that's readily available in more well-known data structures.
* send_encoded_inline_extent() (called by send_extent_data()) needs the btrfs_path in order to get the inline data anyways.
* clone_range() also already deals with btrfs_paths, so it's not new.
PATCH v11 14/14 btrfs: send: enable support for stream v2 and compressed writes
In reply to Omar SandovalFrom: Omar Sandoval <[email protected]>
Now that the new support is implemented, allow the ioctl to accept the flags and update the version in sysfs.
--- fs/btrfs/send.c | 10 +++++++++- fs/btrfs/send.h | 2 +- include/uapi/linux/btrfs.h | 4 +++- 3 files changed, 13 insertions(+), 3 deletions(-)
fs/btrfs/send.c +9 -1
@@ -671,7 +671,10 @@ static int send_header(struct send_ctx *sctx)struct btrfs_stream_header hdr;strcpy (hdr.magic,BTRFS_SEND_STREAM_MAGIC ); - hdr.version =cpu_to_le32 (BTRFS_SEND_STREAM_VERSION ); +if (sctx->flags &BTRFS_SEND_FLAG_STREAM_V2 ) + hdr.version =cpu_to_le32 (2 ); +else + hdr.version =cpu_to_le32 (1 );return write_buf (sctx->send_filp, &hdr,sizeof (hdr), &sctx->send_off);
@@ -7466,6 +7469,11 @@ long btrfs_ioctl_send(struct file *mnt_file, struct btrfs_ioctl_send_args *arg) ret = -EINVAL ; goto out; } +if ((arg->flags &BTRFS_SEND_FLAG_COMPRESSED ) && + !(arg->flags &BTRFS_SEND_FLAG_STREAM_V2 )) { + ret = -EINVAL ; + goto out; + } sctx =kzalloc (sizeof (struct send_ctx ),GFP_KERNEL );if (!sctx) {
fs/btrfs/send.h +1 -1
@@ -10,7 +10,7 @@#include "ctree.h" #define BTRFS_SEND_STREAM_MAGIC "btrfs-stream" -#define BTRFS_SEND_STREAM_VERSION 1 +#define BTRFS_SEND_STREAM_VERSION 2/* * In send stream v1, no command is larger than 64k. In send stream v2, no limit
include/uapi/linux/btrfs.h +3 -1
@@ -787,7 +787,9 @@ struct btrfs_ioctl_received_subvol_args {#define BTRFS_SEND_FLAG_MASK \ (BTRFS_SEND_FLAG_NO_FILE_DATA | \ BTRFS_SEND_FLAG_OMIT_STREAM_HEADER | \ - BTRFS_SEND_FLAG_OMIT_END_CMD) + BTRFS_SEND_FLAG_OMIT_END_CMD | \ + BTRFS_SEND_FLAG_STREAM_V2 | \ + BTRFS_SEND_FLAG_COMPRESSED)struct btrfs_ioctl_send_args {__s64 send_fd;/* in */
Signature · 1 line
2.33.0
Re: [PATCH v11 14/14] btrfs: send: enable support for stream v2 and compressed writes
Quoted 4 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
Now that the new support is implemented, allow the ioctl to accept the flags and update the version in sysfs.
This seems like an appropriate place to bring up the discussion about versioned streams. SO instead of adding a BTRFS_SEND_FLAG_STREAM_V2 flag, which implies that for the next version we have to add BTRFS_SEND_FLAG_STREAM_V3 etc. Why not generalize the flag to BTRFS_SEND_FLAG_STREAM_VERSIONED and carve an u32 from one of the reserved fields so that in the future we simply increment the version field?
Quoted 65 lines
Signed-off-by Omar Sandoval <[email protected]>--- fs/btrfs/send.c | 10 +++++++++- fs/btrfs/send.h | 2 +- include/uapi/linux/btrfs.h | 4 +++- 3 files changed, 13 insertions(+), 3 deletions(-)fs/btrfs/send.c +9
-1@@ -671,7 +671,10 @@ static int send_header(struct send_ctx *sctx)struct btrfs_stream_header hdr;strcpy (hdr.magic,BTRFS_SEND_STREAM_MAGIC ); - hdr.version =cpu_to_le32 (BTRFS_SEND_STREAM_VERSION ); +if (sctx->flags &BTRFS_SEND_FLAG_STREAM_V2 ) + hdr.version =cpu_to_le32 (2 ); +else + hdr.version =cpu_to_le32 (1 );return write_buf (sctx->send_filp, &hdr,sizeof (hdr), &sctx->send_off);@@ -7466,6 +7469,11 @@ long btrfs_ioctl_send(struct file *mnt_file, struct btrfs_ioctl_send_args *arg) ret = -EINVAL ; goto out; } +if ((arg->flags &BTRFS_SEND_FLAG_COMPRESSED ) && + !(arg->flags &BTRFS_SEND_FLAG_STREAM_V2 )) { + ret = -EINVAL ; + goto out; + } sctx =kzalloc (sizeof (struct send_ctx ),GFP_KERNEL );if (!sctx) {fs/btrfs/send.h +1
-1@@ -10,7 +10,7 @@#include "ctree.h" #define BTRFS_SEND_STREAM_MAGIC "btrfs-stream" -#define BTRFS_SEND_STREAM_VERSION 1 +#define BTRFS_SEND_STREAM_VERSION 2/* * In send stream v1, no command is larger than 64k. In send stream v2, no limit include/uapi/linux/btrfs.h +3
-1@@ -787,7 +787,9 @@ struct btrfs_ioctl_received_subvol_args {#define BTRFS_SEND_FLAG_MASK \ (BTRFS_SEND_FLAG_NO_FILE_DATA | \ BTRFS_SEND_FLAG_OMIT_STREAM_HEADER | \ - BTRFS_SEND_FLAG_OMIT_END_CMD) + BTRFS_SEND_FLAG_OMIT_END_CMD | \ + BTRFS_SEND_FLAG_STREAM_V2 | \ + BTRFS_SEND_FLAG_COMPRESSED)struct btrfs_ioctl_send_args {__s64 send_fd;/* in */
Re: [PATCH v11 14/14] btrfs: send: enable support for stream v2 and compressed writes
Quoted 8 lines · Nikolay Borisov
Quoted 4 lines · Omar Sandoval
From: Omar Sandoval <[email protected]>
Now that the new support is implemented, allow the ioctl to accept the flags and update the version in sysfs.
Quoted 6 lines
This seems like an appropriate place to bring up the discussion about versioned streams. SO instead of adding a
BTRFS_SEND_FLAG_STREAM_V2flag, which implies that for the next version we have to addBTRFS_SEND_FLAG_STREAM_V3etc. Why not generalize the flag toBTRFS_SEND_FLAG_STREAM_VERSIONEDand carve an u32 from one of the reserved fields so that in the future we simply increment the version field?
Yes, that definitely sounds better.
PATCH v11 1/10 btrfs-progs: receive: support v2 send stream larger tlv_len
In reply to Omar SandovalFrom: Boris Burkov <[email protected]>
An encoded extent can be up to 128K in length, which exceeds the largest value expressible by the current send stream format's 16 bit tlv_len field. Since encoded writes cannot be split into multiple writes by btrfs send, the send stream format must change to accommodate encoded writes.
Supporting this changed format requires retooling how we store the commands we have processed. Since we can no longer use btrfs_tlv_header to describe every attribute, we define a new struct btrfs_send_attribute which has a 32 bit length field, and use that to store the attribute information needed for receive processing. This is transparent to users of the various TLV_GET macros.
--- common/send-stream.c | 34 +++++++++++++++++++++++++--------- 1 file changed, 25 insertions(+), 9 deletions(-)
common/send-stream.c +25 -9
@@ -24,13 +24,23 @@#include "crypto/crc32c.h" #include "common/utils.h" +struct btrfs_send_attribute { +u16 tlv_type; +/* +* Note: in btrfs_tlv_header, this is __le16, but we need 32 bits for +* attributes with file data as of version 2 of the send stream format +*/ +u32 tlv_len; +char *data; +}; +struct btrfs_send_stream {char read_buf[BTRFS_SEND_BUF_SIZE ];int fd;int cmd;struct btrfs_cmd_header *cmd_hdr; -struct btrfs_tlv_header *cmd_attrs[BTRFS_SEND_A_MAX +1 ]; +struct btrfs_send_attribute cmd_attrs[BTRFS_SEND_A_MAX +1 ];u32 version;/*
@@ -152,6 +162,7 @@ static int read_cmd(struct btrfs_send_stream *sctx)struct btrfs_tlv_header *tlv_hdr;u16 tlv_type;u16 tlv_len; +struct btrfs_send_attribute *send_attr; tlv_hdr = (struct btrfs_tlv_header *)data; tlv_type =le16_to_cpu (tlv_hdr->tlv_type);
@@ -164,10 +175,15 @@ static int read_cmd(struct btrfs_send_stream *sctx) goto out; } - sctx->cmd_attrs[tlv_type] = tlv_hdr; + send_attr = &sctx->cmd_attrs[tlv_type]; + send_attr->tlv_type = tlv_type; + send_attr->tlv_len = tlv_len; + pos +=sizeof (*tlv_hdr); + data +=sizeof (*tlv_hdr); - data +=sizeof (*tlv_hdr) + tlv_len; - pos +=sizeof (*tlv_hdr) + tlv_len; + send_attr->data = data; + pos += send_attr->tlv_len; + data += send_attr->tlv_len; } sctx->cmd = cmd;
@@ -180,7 +196,7 @@ out:static int tlv_get (struct btrfs_send_stream *sctx,int attr,void **data,int *len) {int ret; -struct btrfs_tlv_header *hdr; +struct btrfs_send_attribute *send_attr;if (attr <=0 || attr >BTRFS_SEND_A_MAX ) {error ("invalid attribute requested, attr = %d" , attr);
@@ -188,15 +204,15 @@ static int tlv_get(struct btrfs_send_stream *sctx, int attr, void **data, int *l goto out; } - hdr = sctx->cmd_attrs[attr]; -if (!hdr) { + send_attr = &sctx->cmd_attrs[attr]; +if (!send_attr->data) {error ("attribute %d requested but not present" , attr); ret = -ENOENT ; goto out; } - *len =le16_to_cpu (hdr->tlv_len); - *data = hdr +1 ; + *len = send_attr->tlv_len; + *data = send_attr->data; ret =0 ;
Signature · 1 line
2.33.0
Re: [PATCH v11 01/10] btrfs-progs: receive: support v2 send stream larger tlv_len
Quoted 36 lines · Omar Sandoval
From: Boris Burkov <[email protected]>
An encoded extent can be up to 128K in length, which exceeds the largest value expressible by the current send stream format's 16 bit
tlv_lenfield. Since encoded writes cannot be split into multiple writes by btrfs send, the send stream format must change to accommodate encoded writes.Supporting this changed format requires retooling how we store the commands we have processed. Since we can no longer use
btrfs_tlv_headerto describe every attribute, we define a new structbtrfs_send_attributewhich has a 32 bit length field, and use that to store the attribute information needed for receive processing. This is transparent to users of the variousTLV_GETmacros.Signed-off-by Boris Burkov <[email protected]>--- common/send-stream.c | 34 +++++++++++++++++++++++++--------- 1 file changed, 25 insertions(+), 9 deletions(-)common/send-stream.c +8
-0@@ -24,13 +24,23 @@#include "crypto/crc32c.h" #include "common/utils.h" +struct btrfs_send_attribute { +u16 tlv_type; +/* +* Note: in btrfs_tlv_header, this is __le16, but we need 32 bits for +* attributes with file data as of version 2 of the send stream format +*/ +u32 tlv_len; +char *data;
common/send-stream.c line 43
Quoted 10 lines
common/send-stream.c +3
-1+}; +struct btrfs_send_stream {char read_buf[BTRFS_SEND_BUF_SIZE ];int fd;int cmd;struct btrfs_cmd_header *cmd_hdr; -struct btrfs_tlv_header *cmd_attrs[BTRFS_SEND_A_MAX +1 ]; +struct btrfs_send_attribute cmd_attrs[BTRFS_SEND_A_MAX +1 ];
This is subtle and it took me a couple of minutes to get it at first. Currently cmds_attrs holds an array of pointers into the command buffer, with every pointer being the beginning of the tlv_header, whilst with your change cmd_attr now holds actual btrfs_send_attribute structures (52 bytes vs sizeof(uintptr_t) bytes before). So this increases the overall size of btrfs_send_stream because with your version of the code you parse the type/length fields and store them directly in the send attribute structure at command parse time rather than just referring to the raw command buffer during read_cmd and referring to them during attribute parsing.
This might seem superficial but this kind of change should really be mentioned explicitly in the changelog to better prepare reviewers what to expect.
OTOH the code LGTM and actually now it seems less tricky than before so:
David if you deem it necessary adjust the commit message appropriately.
Re: [PATCH v11 01/10] btrfs-progs: receive: support v2 send stream larger tlv_len
Quoted 66 lines · Nikolay Borisov
Quoted 36 lines · Omar Sandoval
From: Boris Burkov <[email protected]>
An encoded extent can be up to 128K in length, which exceeds the largest value expressible by the current send stream format's 16 bit
tlv_lenfield. Since encoded writes cannot be split into multiple writes by btrfs send, the send stream format must change to accommodate encoded writes.Supporting this changed format requires retooling how we store the commands we have processed. Since we can no longer use
btrfs_tlv_headerto describe every attribute, we define a new structbtrfs_send_attributewhich has a 32 bit length field, and use that to store the attribute information needed for receive processing. This is transparent to users of the variousTLV_GETmacros.Signed-off-by Boris Burkov <[email protected]>--- common/send-stream.c | 34 +++++++++++++++++++++++++--------- 1 file changed, 25 insertions(+), 9 deletions(-)common/send-stream.c +8
-0@@ -24,13 +24,23 @@#include "crypto/crc32c.h" #include "common/utils.h" +struct btrfs_send_attribute { +u16 tlv_type; +/* +* Note: in btrfs_tlv_header, this is __le16, but we need 32 bits for +* attributes with file data as of version 2 of the send stream format +*/ +u32 tlv_len; +char *data;common/send-stream.c line 43
Quoted 10 lines
common/send-stream.c +3
-1+}; +struct btrfs_send_stream {char read_buf[BTRFS_SEND_BUF_SIZE ];int fd;int cmd;struct btrfs_cmd_header *cmd_hdr; -struct btrfs_tlv_header *cmd_attrs[BTRFS_SEND_A_MAX +1 ]; +struct btrfs_send_attribute cmd_attrs[BTRFS_SEND_A_MAX +1 ];This is subtle and it took me a couple of minutes to get it at first. Currently
cmds_attrsholds an array of pointers into the command buffer, with every pointer being the beginning of thetlv_header, whilst with your changecmd_attrnow holds actualbtrfs_send_attributestructures (52 bytes vssizeof(uintptr_t)bytes before). So this increases the overall size ofbtrfs_send_streambecause with your version of the code you parse the type/length fields and store them directly in the send attribute structure at command parse time rather than just referring to the raw command buffer duringread_cmdand referring to them during attribute parsing.This might seem superficial but this kind of change should really be mentioned explicitly in the changelog to better prepare reviewers what to expect.
Quoted 6 lines
OTOH the code LGTM and actually now it seems less tricky than before so:
Reviewed-by Nikolay Borisov <[email protected]>David if you deem it necessary adjust the commit message appropriately.
I clarified the second paragraph to:
Supporting this changed format requires retooling how we store the commands we have processed. We currently store pointers to the struct btrfs_tlv_headers in the command buffer. This is not sufficient to represent the new BTRFS_SEND_A_DATA format. Instead, parse the attribute headers and store them in a new struct btrfs_send_attribute which has a 32-bit length field. This is transparent to users of the various TLV_GET macros.
PATCH v11 2/10 btrfs-progs: receive: dynamically allocate sctx->read_buf
In reply to Omar SandovalFrom: Boris Burkov <[email protected]>
In send stream v2, write commands can now be an arbitrary size. For that reason, we can no longer allocate a fixed array in sctx for read_cmd. Instead, read_cmd dynamically allocates sctx->read_buf. To avoid needless reallocations, we reuse read_buf between read_cmd calls by also keeping track of the size of the allocated buffer in sctx->read_buf_sz.
We do the first allocation of the old default size at the start of processing the stream, and we only reallocate if we encounter a command that needs a larger buffer.
--- common/send-stream.c | 55 ++++++++++++++++++++++++++++---------------- send.h | 2 +- 2 files changed, 36 insertions(+), 21 deletions(-)
common/send-stream.c +35 -20
@@ -35,11 +35,11 @@ struct btrfs_send_attribute { };struct btrfs_send_stream { -char read_buf[BTRFS_SEND_BUF_SIZE ]; +char *read_buf; +size_t read_buf_sz;int fd;int cmd; -struct btrfs_cmd_header *cmd_hdr;struct btrfs_send_attribute cmd_attrs[BTRFS_SEND_A_MAX +1 ];u32 version;
@@ -111,11 +111,12 @@ static int read_cmd(struct btrfs_send_stream *sctx)u32 pos;u32 crc;u32 crc2; +struct btrfs_cmd_header *cmd_hdr; +size_t buf_len;memset (sctx->cmd_attrs,0 ,sizeof (sctx->cmd_attrs)); -ASSERT (sizeof (*sctx->cmd_hdr) <=sizeof (sctx->read_buf)); - ret =read_buf (sctx, sctx->read_buf,sizeof (*sctx->cmd_hdr)); + ret =read_buf (sctx, sctx->read_buf,sizeof (*cmd_hdr));if (ret <0 ) goto out;if (ret) {
@@ -124,18 +125,22 @@ static int read_cmd(struct btrfs_send_stream *sctx) goto out; } - sctx->cmd_hdr = (struct btrfs_cmd_header *)sctx->read_buf; - cmd =le16_to_cpu (sctx->cmd_hdr->cmd); - cmd_len =le32_to_cpu (sctx->cmd_hdr->len); - -if (cmd_len +sizeof (*sctx->cmd_hdr) >=sizeof (sctx->read_buf)) { - ret = -EINVAL ; -error ("command length %u too big for buffer %zu" , - cmd_len,sizeof (sctx->read_buf)); - goto out; + cmd_hdr = (struct btrfs_cmd_header *)sctx->read_buf; + cmd_len =le32_to_cpu (cmd_hdr->len); + cmd =le16_to_cpu (cmd_hdr->cmd); + buf_len =sizeof (*cmd_hdr) + cmd_len; +if (sctx->read_buf_sz < buf_len) { + sctx->read_buf =realloc (sctx->read_buf, buf_len); +if (!sctx->read_buf) { + ret = -ENOMEM ; +error ("failed to reallocate read buffer for cmd" ); + goto out; + } + sctx->read_buf_sz = buf_len; +/* We need to reset cmd_hdr after realloc of sctx->read_buf */ + cmd_hdr = (struct btrfs_cmd_header *)sctx->read_buf; } - - data = sctx->read_buf +sizeof (*sctx->cmd_hdr); + data = sctx->read_buf +sizeof (*cmd_hdr); ret =read_buf (sctx, data, cmd_len);if (ret <0 ) goto out;
@@ -145,11 +150,12 @@ static int read_cmd(struct btrfs_send_stream *sctx) goto out; } - crc =le32_to_cpu (sctx->cmd_hdr->crc); - sctx->cmd_hdr->crc =0 ; + crc =le32_to_cpu (cmd_hdr->crc); +/* in send, crc is computed with header crc = 0, replicate that */ + cmd_hdr->crc =0 ; crc2 =crc32c (0 , (unsigned char *)sctx->read_buf, -sizeof (*sctx->cmd_hdr) + cmd_len); +sizeof (*cmd_hdr) + cmd_len);if (crc != crc2) { ret = -EINVAL ;
@@ -524,19 +530,28 @@ int btrfs_read_and_process_send_stream(int fd, goto out; } + sctx.read_buf =malloc (BTRFS_SEND_BUF_SIZE_V1 ); +if (!sctx.read_buf) { + ret = -ENOMEM ; +error ("unable to allocate send stream read buffer" ); + goto out; + } + sctx.read_buf_sz =BTRFS_SEND_BUF_SIZE_V1 ; +while (1 ) { ret =read_and_process_cmd (&sctx);if (ret <0 ) { last_err = ret; errors++;if (max_errors >0 && errors >= max_errors) - goto out; +break ; }else if (ret >0 ) {if (!honor_end_cmd) ret =0 ; - goto out; +break ; } } +free (sctx.read_buf); out:if (last_err && !ret)
send.h +1 -1
@@ -33,7 +33,7 @@ extern "C" {#define BTRFS_SEND_STREAM_MAGIC "btrfs-stream"#define BTRFS_SEND_STREAM_VERSION 1 -#define BTRFS_SEND_BUF_SIZE SZ_64K +#define BTRFS_SEND_BUF_SIZE_V1 SZ_64K#define BTRFS_SEND_READ_SIZE (1024 * 48)enum btrfs_tlv_type {
Signature · 1 line
2.33.0
Re: [PATCH v11 02/10] btrfs-progs: receive: dynamically allocate sctx->read_buf
Quoted 18 lines · Omar Sandoval
From: Boris Burkov <[email protected]>
In send stream v2, write commands can now be an arbitrary size. For that reason, we can no longer allocate a fixed array in sctx for
read_cmd. Instead,read_cmddynamically allocatessctx->read_buf. To avoid needless reallocations, we reuseread_bufbetweenread_cmdcalls by also keeping track of the size of the allocated buffer insctx->read_buf_sz.We do the first allocation of the old default size at the start of processing the stream, and we only reallocate if we encounter a command that needs a larger buffer.
Signed-off-by Boris Burkov <[email protected]>--- common/send-stream.c | 55 ++++++++++++++++++++++++++++---------------- send.h | 2 +- 2 files changed, 36 insertions(+), 21 deletions(-)
<snip>
Quoted 10 lines
common/send-stream.c +0
-6@@ -124,18 +125,22 @@ static int read_cmd(struct btrfs_send_stream *sctx) goto out; } - sctx->cmd_hdr = (struct btrfs_cmd_header *)sctx->read_buf; - cmd =le16_to_cpu (sctx->cmd_hdr->cmd); - cmd_len =le32_to_cpu (sctx->cmd_hdr->len); - -if (cmd_len +sizeof (*sctx->cmd_hdr) >=sizeof (sctx->read_buf)) { - ret = -EINVAL ;
common/send-stream.c static int read_cmd(struct btrfs_send_stream *sctx) · line 134
Quoted 10 lines
common/send-stream.c +7
-3-error ("command length %u too big for buffer %zu" , - cmd_len,sizeof (sctx->read_buf)); - goto out; + cmd_hdr = (struct btrfs_cmd_header *)sctx->read_buf; + cmd_len =le32_to_cpu (cmd_hdr->len); + cmd =le16_to_cpu (cmd_hdr->cmd); + buf_len =sizeof (*cmd_hdr) + cmd_len; +if (sctx->read_buf_sz < buf_len) { + sctx->read_buf =realloc (sctx->read_buf, buf_len); +if (!sctx->read_buf) {
nit: This is prone to a memory leak, because according to
https://en.cppreference.com/w/c/memory/realloc
If there is not enough memory, the old memory block is not freed and null pointer is returned.
This means if realloc fails it will overwrite sctx->read_buf with NULL, yet the old memory won't be freed which will cause a memory leak. It can be argued that's not critical since we'll very quickly terminate the program afterwards but still.
<snip>
Re: [PATCH v11 02/10] btrfs-progs: receive: dynamically allocate sctx->read_buf
Quoted 6 lines · Nikolay Borisov
Quoted 3 lines · Omar Sandoval
From: Boris Burkov <[email protected]>
In send stream v2, write commands can now be an arbitrary size. For that
nit: Actually can't commands really be up-to BTRFS_MAX_COMPRESSED + 16K really or are we going to leave this as an implementation detail? I'm fine either way but looking at the changelog of patch 12 in the kernel series doesn't really mention of arbitrary size, instead it explicitly is talking about sending the max compressed extent size (128K) + some space for metadata (the 16K above).
Quoted 54 lines
Quoted 15 lines
reason, we can no longer allocate a fixed array in sctx for
read_cmd. Instead,read_cmddynamically allocatessctx->read_buf. To avoid needless reallocations, we reuseread_bufbetweenread_cmdcalls by also keeping track of the size of the allocated buffer insctx->read_buf_sz.We do the first allocation of the old default size at the start of processing the stream, and we only reallocate if we encounter a command that needs a larger buffer.
Signed-off-by Boris Burkov <[email protected]>--- common/send-stream.c | 55 ++++++++++++++++++++++++++++---------------- send.h | 2 +- 2 files changed, 36 insertions(+), 21 deletions(-)<snip>
Quoted 10 lines
common/send-stream.c +0
-6@@ -124,18 +125,22 @@ static int read_cmd(struct btrfs_send_stream *sctx) goto out; } - sctx->cmd_hdr = (struct btrfs_cmd_header *)sctx->read_buf; - cmd =le16_to_cpu (sctx->cmd_hdr->cmd); - cmd_len =le32_to_cpu (sctx->cmd_hdr->len); - -if (cmd_len +sizeof (*sctx->cmd_hdr) >=sizeof (sctx->read_buf)) { - ret = -EINVAL ;common/send-stream.c static int read_cmd(struct btrfs_send_stream *sctx) · line 134
Quoted 10 lines
common/send-stream.c +7
-3-error ("command length %u too big for buffer %zu" , - cmd_len,sizeof (sctx->read_buf)); - goto out; + cmd_hdr = (struct btrfs_cmd_header *)sctx->read_buf; + cmd_len =le32_to_cpu (cmd_hdr->len); + cmd =le16_to_cpu (cmd_hdr->cmd); + buf_len =sizeof (*cmd_hdr) + cmd_len; +if (sctx->read_buf_sz < buf_len) { + sctx->read_buf =realloc (sctx->read_buf, buf_len); +if (!sctx->read_buf) {nit: This is prone to a memory leak, because according to
https://en.cppreference.com/w/c/memory/reallocIf there is not enough memory, the old memory block is not freed and null pointer is returned.
This means if realloc fails it will overwrite
sctx->read_bufwith NULL, yet the old memory won't be freed which will cause a memory leak. It can be argued that's not critical since we'll very quickly terminate the program afterwards but still.<snip>
Re: [PATCH v11 02/10] btrfs-progs: receive: dynamically allocate sctx->read_buf
Quoted 8 lines · Nikolay Borisov
Quoted 5 lines · Nikolay Borisov
Quoted 2 lines · Omar Sandoval
From: Boris Burkov <[email protected]>
Quoted 8 lines
Quoted 1 line
Quoted 1 line
In send stream v2, write commands can now be an arbitrary size. For that
nit: Actually can't commands really be up-to
BTRFS_MAX_COMPRESSED+ 16K really or are we going to leave this as an implementation detail? I'm fine either way but looking at the changelog of patch 12 in the kernel series doesn't really mention of arbitrary size, instead it explicitly is talking about sending the max compressed extent size (128K) + some space for metadata (the 16K above).
Patch 10 mentions it in the changelog: "It also documents two changes to the send stream format in v2: the receiver shouldn't assume a maximum command size, and the DATA attribute is encoded differently to allow for writes larger than 64k".
And in send.h:
-#define BTRFS_SEND_BUF_SIZE SZ_64K
+/*
+ * In send stream v1, no command is larger than 64k. In send stream v2, no limit
+ * should be assumed.
+ */
+#define BTRFS_SEND_BUF_SIZE_V1 SZ_64K
You're correct that right now the limit is BTRFS_MAX_COMPRESSED + 16k, but I think it's better if userspace doesn't make any assumptions about that in case we want to send larger commands in the future.
Quoted 42 lines
Quoted 42 lines
Quoted 15 lines
reason, we can no longer allocate a fixed array in sctx for
read_cmd. Instead,read_cmddynamically allocatessctx->read_buf. To avoid needless reallocations, we reuseread_bufbetweenread_cmdcalls by also keeping track of the size of the allocated buffer insctx->read_buf_sz.We do the first allocation of the old default size at the start of processing the stream, and we only reallocate if we encounter a command that needs a larger buffer.
Signed-off-by Boris Burkov <[email protected]>--- common/send-stream.c | 55 ++++++++++++++++++++++++++++---------------- send.h | 2 +- 2 files changed, 36 insertions(+), 21 deletions(-)<snip>
Quoted 10 lines
common/send-stream.c +0
-6@@ -124,18 +125,22 @@ static int read_cmd(struct btrfs_send_stream *sctx) goto out; } - sctx->cmd_hdr = (struct btrfs_cmd_header *)sctx->read_buf; - cmd =le16_to_cpu (sctx->cmd_hdr->cmd); - cmd_len =le32_to_cpu (sctx->cmd_hdr->len); - -if (cmd_len +sizeof (*sctx->cmd_hdr) >=sizeof (sctx->read_buf)) { - ret = -EINVAL ;common/send-stream.c static int read_cmd(struct btrfs_send_stream *sctx) · line 134
Quoted 10 lines
common/send-stream.c +7
-3-error ("command length %u too big for buffer %zu" , - cmd_len,sizeof (sctx->read_buf)); - goto out; + cmd_hdr = (struct btrfs_cmd_header *)sctx->read_buf; + cmd_len =le32_to_cpu (cmd_hdr->len); + cmd =le16_to_cpu (cmd_hdr->cmd); + buf_len =sizeof (*cmd_hdr) + cmd_len; +if (sctx->read_buf_sz < buf_len) { + sctx->read_buf =realloc (sctx->read_buf, buf_len); +if (!sctx->read_buf) {nit: This is prone to a memory leak, because according to
https://en.cppreference.com/w/c/memory/realloc
Quoted 8 lines
Quoted 8 lines
If there is not enough memory, the old memory block is not freed and null pointer is returned.
This means if realloc fails it will overwrite
sctx->read_bufwith NULL, yet the old memory won't be freed which will cause a memory leak. It can be argued that's not critical since we'll very quickly terminate the program afterwards but still.
Good catch, I'll fix that.
PATCH v11 3/10 btrfs-progs: receive: support v2 send stream DATA tlv format
In reply to Omar SandovalFrom: Boris Burkov <[email protected]>
The new format privileges the BTRFS_SEND_A_DATA attribute by guaranteeing it will always be the last attribute in any command that needs it, and by implicitly encoding the data length as the difference between the total command length in the command header and the sizes of the rest of the attributes (and of course the tlv_type identifying the DATA attribute). To parse the new stream, we must read the tlv_type and if it is not DATA, we proceed normally, but if it is DATA, we don't parse a tlv_len but simply compute the length.
In addition, we add some bounds checking when parsing each chunk of data, as well as for the tlv_len itself.
--- common/send-stream.c | 36 ++++++++++++++++++++++++++---------- 1 file changed, 26 insertions(+), 10 deletions(-)
common/send-stream.c +26 -10
@@ -165,28 +165,44 @@ static int read_cmd(struct btrfs_send_stream *sctx) pos =0 ;while (pos < cmd_len) { -struct btrfs_tlv_header *tlv_hdr;u16 tlv_type; -u16 tlv_len;struct btrfs_send_attribute *send_attr; - tlv_hdr = (struct btrfs_tlv_header *)data; - tlv_type =le16_to_cpu (tlv_hdr->tlv_type); - tlv_len =le16_to_cpu (tlv_hdr->tlv_len); +if (cmd_len - pos <sizeof (__le16)) { +error ("send stream is truncated" ); + ret = -EINVAL ; + goto out; + } + tlv_type =le16_to_cpu (*(__le16 *)data);if (tlv_type ==0 || tlv_type >BTRFS_SEND_A_MAX ) { -error ("invalid tlv in cmd tlv_type = %hu, tlv_len = %hu" , - tlv_type, tlv_len); +error ("invalid tlv in cmd tlv_type = %hu" , tlv_type); ret = -EINVAL ; goto out; } send_attr = &sctx->cmd_attrs[tlv_type]; send_attr->tlv_type = tlv_type; - send_attr->tlv_len = tlv_len; - pos +=sizeof (*tlv_hdr); - data +=sizeof (*tlv_hdr); + pos +=sizeof (tlv_type); + data +=sizeof (tlv_type); +if (sctx->version ==2 && tlv_type ==BTRFS_SEND_A_DATA ) { + send_attr->tlv_len = cmd_len - pos; + }else { +if (cmd_len - pos <sizeof (__le16)) { +error ("send stream is truncated" ); + ret = -EINVAL ; + goto out; + } + send_attr->tlv_len =le16_to_cpu (*(__le16 *)data); + pos +=sizeof (__le16); + data +=sizeof (__le16); + } +if (cmd_len - pos < send_attr->tlv_len) { +error ("send stream is truncated" ); + ret = -EINVAL ; + goto out; + } send_attr->data = data; pos += send_attr->tlv_len; data += send_attr->tlv_len;
Signature · 1 line
2.33.0
Re: [PATCH v11 03/10] btrfs-progs: receive: support v2 send stream DATA tlv format
Quoted 11 lines · Omar Sandoval
From: Boris Burkov <[email protected]>
The new format privileges the
BTRFS_SEND_A_DATAattribute by guaranteeing it will always be the last attribute in any command that needs it, and by implicitly encoding the data length as the difference between the total command length in the command header and the sizes of the rest of the attributes (and of course thetlv_typeidentifying the DATA attribute). To parse the new stream, we must read thetlv_typeand if it is not DATA, we proceed normally, but if it is DATA, we don't parse atlv_lenbut simply compute the length.
Quoted 4 lines
In addition, we add some bounds checking when parsing each chunk of data, as well as for the
tlv_lenitself.Signed-off-by Boris Burkov <[email protected]>
PATCH v11 4/10 btrfs-progs: receive: add send stream v2 cmds and attrs to send.h
In reply to Omar SandovalFrom: Boris Burkov <[email protected]>
Send stream v2 adds three commands and several attributes associated to those commands. Before we implement processing them, add all the commands and attributes. This avoids leaving the enums in an intermediate state that doesn't correspond to any version of send stream.
--- send.h | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
send.h +15 -0
@@ -98,6 +98,11 @@ enum btrfs_send_cmd {BTRFS_SEND_C_END ,BTRFS_SEND_C_UPDATE_EXTENT , + +BTRFS_SEND_C_FALLOCATE , +BTRFS_SEND_C_SETFLAGS , +BTRFS_SEND_C_ENCODED_WRITE , + __BTRFS_SEND_C_MAX, };#define BTRFS_SEND_C_MAX (__BTRFS_SEND_C_MAX - 1)
@@ -136,6 +141,16 @@ enum {BTRFS_SEND_A_CLONE_OFFSET ,BTRFS_SEND_A_CLONE_LEN , +BTRFS_SEND_A_FALLOCATE_MODE , + +BTRFS_SEND_A_SETFLAGS_FLAGS , + +BTRFS_SEND_A_UNENCODED_FILE_LEN , +BTRFS_SEND_A_UNENCODED_LEN , +BTRFS_SEND_A_UNENCODED_OFFSET , +BTRFS_SEND_A_COMPRESSION , +BTRFS_SEND_A_ENCRYPTION , + __BTRFS_SEND_A_MAX, };#define BTRFS_SEND_A_MAX (__BTRFS_SEND_A_MAX - 1)
Signature · 1 line
2.33.0
Re: [PATCH v11 04/10] btrfs-progs: receive: add send stream v2 cmds and attrs to send.h
Quoted 9 lines · Omar Sandoval
From: Boris Burkov <[email protected]>
Send stream v2 adds three commands and several attributes associated to those commands. Before we implement processing them, add all the commands and attributes. This avoids leaving the enums in an intermediate state that doesn't correspond to any version of send stream.
Signed-off-by Boris Burkov <[email protected]>
PATCH v11 5/10 btrfs-progs: receive: process encoded_write commands
In reply to Omar SandovalFrom: Boris Burkov <[email protected]>
Add a new btrfs_send_op and support for both dumping and proper receive processing which does actual encoded writes.
Encoded writes are only allowed on a file descriptor opened with an extra flag that allows encoded writes, so we also add support for this flag when opening or reusing a file for writing.
--- cmds/receive-dump.c | 16 +++++- cmds/receive.c | 47 +++++++++++++++ common/send-stream.c | 22 ++++++++ common/send-stream.h | 4 ++ ioctl.h | 132 +++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 220 insertions(+), 1 deletion(-)
cmds/receive-dump.c +15 -1
@@ -316,6 +316,19 @@ static int print_update_extent(const char *path, u64 offset, u64 len, offset, len); } +static int print_encoded_write (const char *path,const void *data,u64 offset, +u64 len,u64 unencoded_file_len, +u64 unencoded_len,u64 unencoded_offset, +u32 compression,u32 encryption,void *user) +{ +return PRINT_DUMP (user, path,"encoded_write" , +"offset=%llu len=%llu, unencoded_file_len=%llu, " +"unencoded_len=%llu, unencoded_offset=%llu, " +"compression=%u, encryption=%u" , + offset, len, unencoded_file_len, unencoded_len, + unencoded_offset, compression, encryption); +} +struct btrfs_send_ops btrfs_print_send_ops = { .subvol = print_subvol, .snapshot = print_snapshot,
@@ -337,5 +350,6 @@ struct btrfs_send_ops btrfs_print_send_ops = { .chmod = print_chmod, .chown = print_chown, .utimes = print_utimes, - .update_extent = print_update_extent + .update_extent = print_update_extent, + .encoded_write = print_encoded_write, };
cmds/receive.c +47 -0
77 lines not on this page · raw message
common/send-stream.c +22 -0
@@ -354,6 +354,8 @@ static int read_and_process_cmd(struct btrfs_send_stream *sctx)struct timespec mt;u8 uuid[BTRFS_UUID_SIZE ];u8 clone_uuid[BTRFS_UUID_SIZE ]; +u32 compression; +u32 encryption;u64 tmp;u64 tmp2;u64 ctransid;
@@ -362,6 +364,9 @@ static int read_and_process_cmd(struct btrfs_send_stream *sctx)u64 dev;u64 clone_offset;u64 offset; +u64 unencoded_file_len; +u64 unencoded_len; +u64 unencoded_offset;int len;int xattr_len;
@@ -436,6 +441,23 @@ static int read_and_process_cmd(struct btrfs_send_stream *sctx)TLV_GET (sctx,BTRFS_SEND_A_DATA , &data, &len); ret = sctx->ops->write (path, data, offset, len, sctx->user);break ; +case BTRFS_SEND_C_ENCODED_WRITE : +TLV_GET_STRING (sctx,BTRFS_SEND_A_PATH , &path); +TLV_GET_U64 (sctx,BTRFS_SEND_A_FILE_OFFSET , &offset); +TLV_GET_U64 (sctx,BTRFS_SEND_A_UNENCODED_FILE_LEN , + &unencoded_file_len); +TLV_GET_U64 (sctx,BTRFS_SEND_A_UNENCODED_LEN , &unencoded_len); +TLV_GET_U64 (sctx,BTRFS_SEND_A_UNENCODED_OFFSET , + &unencoded_offset); +TLV_GET_U32 (sctx,BTRFS_SEND_A_COMPRESSION , &compression); +TLV_GET_U32 (sctx,BTRFS_SEND_A_ENCRYPTION , &encryption); +TLV_GET (sctx,BTRFS_SEND_A_DATA , &data, &len); + ret = sctx->ops->encoded_write (path, data, offset, len, + unencoded_file_len, + unencoded_len, unencoded_offset, + compression, encryption, + sctx->user); +break ;case BTRFS_SEND_C_CLONE :TLV_GET_STRING (sctx,BTRFS_SEND_A_PATH , &path);TLV_GET_U64 (sctx,BTRFS_SEND_A_FILE_OFFSET , &offset);
common/send-stream.h +4 -0
@@ -66,6 +66,10 @@ struct btrfs_send_ops { struct timespec *mt, struct timespec *ct, void *user);int (*update_extent)(const char *path,u64 offset,u64 len,void *user); +int (*encoded_write)(const char *path,const void *data,u64 offset, +u64 len,u64 unencoded_file_len,u64 unencoded_len, +u64 unencoded_offset,u32 compression, +u32 encryption,void *user); }; int btrfs_read_and_process_send_stream(int fd,
ioctl.h +132 -0
144 lines not on this page · raw message
Signature · 1 line
2.33.0
Re: [PATCH v11 05/10] btrfs-progs: receive: process encoded_write commands
Quoted 2 lines · Omar Sandoval
From: Boris Burkov <[email protected]>
<snip>
Quoted 11 lines
ioctl.h +11
-0+/* Data is not compressed. */ +#define BTRFS_ENCODED_IO_COMPRESSION_NONE 0 +/* Data is compressed as a single zlib stream. */ +#define BTRFS_ENCODED_IO_COMPRESSION_ZLIB 1 +/* +* Data is compressed as a single zstd frame with the windowLog compression +* parameter set to no more than 17. +*/ +#define BTRFS_ENCODED_IO_COMPRESSION_ZSTD 2 +/* +* Data is compressed page by page (using the page size indicated by the name of
ioctl.h struct btrfs_ioctl_get_subvol_rootref_args { · line 900
Quoted 10 lines
ioctl.h +10
-0+* the constant) with LZO1X and wrapped in the format documented in +* fs/btrfs/lzo.c. For writes, the compression page size must match the +* filesystem page size. +*/ +#define BTRFS_ENCODED_IO_COMPRESSION_LZO_4K 3 +#define BTRFS_ENCODED_IO_COMPRESSION_LZO_8K 4 +#define BTRFS_ENCODED_IO_COMPRESSION_LZO_16K 5 +#define BTRFS_ENCODED_IO_COMPRESSION_LZO_32K 6 +#define BTRFS_ENCODED_IO_COMPRESSION_LZO_64K 7 +#define BTRFS_ENCODED_IO_COMPRESSION_TYPES 8
nit: Make those an enum ? Same applies for the kernel counterpart patch.
Quoted 20 lines
ioctl.h +9
-0+ +/* Data is not encrypted. */ +#define BTRFS_ENCODED_IO_ENCRYPTION_NONE 0 +#define BTRFS_ENCODED_IO_ENCRYPTION_TYPES 1 +/* Error codes as returned by the kernel */ enum btrfs_err_code { notused,@@ -949,6 +1077,10 @@ static inline char *btrfs_err_str(enum btrfs_err_code err_code) struct btrfs_ioctl_ino_lookup_user_args)#define BTRFS_IOC_SNAP_DESTROY_V2 _IOW(BTRFS_IOCTL_MAGIC, 63, \ struct btrfs_ioctl_vol_args_v2) +#define BTRFS_IOC_ENCODED_READ _IOR(BTRFS_IOCTL_MAGIC, 64, \ + struct btrfs_ioctl_encoded_io_args) +#define BTRFS_IOC_ENCODED_WRITE _IOW(BTRFS_IOCTL_MAGIC, 64, \ + struct btrfs_ioctl_encoded_io_args) #ifdef __cplusplus }
Re: [PATCH v11 05/10] btrfs-progs: receive: process encoded_write commands
Quoted 22 lines · Nikolay Borisov
Quoted 2 lines · Omar Sandoval
From: Boris Burkov <[email protected]>
<snip>
Quoted 15 lines
ioctl.h +15
-0+/* Data is not compressed. */ +#define BTRFS_ENCODED_IO_COMPRESSION_NONE 0 +/* Data is compressed as a single zlib stream. */ +#define BTRFS_ENCODED_IO_COMPRESSION_ZLIB 1 +/* +* Data is compressed as a single zstd frame with the windowLog compression +* parameter set to no more than 17. +*/ +#define BTRFS_ENCODED_IO_COMPRESSION_ZSTD 2 +/* +* Data is compressed page by page (using the page size indicated by the name of +* the constant) with LZO1X and wrapped in the format documented in +* fs/btrfs/lzo.c. For writes, the compression page size must match the +* filesystem page size. +*/
Quoted 8 lines
ioctl.h struct btrfs_ioctl_get_subvol_rootref_args { · line 900
Quoted 6 lines
ioctl.h +6
-0+#define BTRFS_ENCODED_IO_COMPRESSION_LZO_4K 3 +#define BTRFS_ENCODED_IO_COMPRESSION_LZO_8K 4 +#define BTRFS_ENCODED_IO_COMPRESSION_LZO_16K 5 +#define BTRFS_ENCODED_IO_COMPRESSION_LZO_32K 6 +#define BTRFS_ENCODED_IO_COMPRESSION_LZO_64K 7 +#define BTRFS_ENCODED_IO_COMPRESSION_TYPES 8nit: Make those an enum ? Same applies for the kernel counterpart patch.
I responded to this before:
https://lore.kernel.org/linux-btrfs/YR%[email protected]/
PATCH v11 6/10 btrfs-progs: receive: encoded_write fallback to explicit decode and write
In reply to Omar SandovalFrom: Boris Burkov <[email protected]>
An encoded_write can fail if the file system it is being applied to does not support encoded writes or if it can't find enough contiguous space to accommodate the encoded extent. In those cases, we can likely still process an encoded_write by explicitly decoding the data and doing a normal write.
Add the necessary fallback path for decoding data compressed with zlib, lzo, or zstd. zlib and zstd have reusable decoding context data structures which we cache in the receive context so that we don't have to recreate them on every encoded_write.
Finally, add a command line flag for force-decompress which causes receive to always use the fallback path rather than first attempting the encoded write.
--- Documentation/btrfs-receive.asciidoc | 4 + cmds/receive.c | 266 ++++++++++++++++++++++++++- 2 files changed, 261 insertions(+), 9 deletions(-)
Documentation/btrfs-receive.asciidoc +4 -0
@@ -60,6 +60,10 @@ By default the mountpoint is searched in '/proc/self/mounts'. If '/proc' is not accessible, eg. in a chroot environment, use this option to tell us where this filesystem is mounted. +--force-decompress:: +if the stream contains compressed data (see '--compressed-data' in +`btrfs-send`(8)), always decompress it instead of writing it with encoded I/O. + --dump:: dump the stream metadata, one line per operation +
cmds/receive.c +257 -9
327 lines not on this page · raw message
Signature · 1 line
2.33.0
Re: [PATCH v11 06/10] btrfs-progs: receive: encoded_write fallback to explicit decode and write
Quoted 2 lines · Omar Sandoval
From: Boris Burkov <[email protected]>
<snip>
cmds/receive.c struct btrfs_receive · line 87
Quoted 6 lines
cmds/receive.c +2
-0@@ -79,6 +83,12 @@ struct btrfs_receivestruct subvol_uuid_search sus;int honor_end_cmd; + +int force_decompress;
Make it bool
Quoted 11 lines
cmds/receive.c +4
-0+ +/* Reuse stream objects for encoded_write decompression fallback */ +ZSTD_DStream *zstd_dstream; +z_stream *zlib_stream; };static int finish_subvol (struct btrfs_receive *rctx)@@ -989,9 +999,222 @@ static int process_update_extent(const char *path, u64 offset, u64 len,return 0 ; }
<snip>
Quoted 18 lines
cmds/receive.c +18
-0+ +static int decompress_lzo (const char *encoded_data,u64 encoded_len, +char *unencoded_data,u64 unencoded_len, +unsigned int page_size) +{ +uint32_t total_len; +size_t in_pos, out_pos; + +if (encoded_len <4 ) { +error ("lzo header is truncated" ); +return -EIO ; + } +memcpy (&total_len, encoded_data,4 ); + total_len =le32toh (total_len); +if (total_len > encoded_len) { +error ("lzo header is invalid" ); +return -EIO ; + }
cmds/receive.c static int process_update_extent(const char *path, u64 offset, u64 len, · line 1113
Quoted 10 lines
cmds/receive.c +10
-0+ + in_pos =4 ; + out_pos =0 ; +while (in_pos < total_len && out_pos < unencoded_len) { +size_t page_remaining; +uint32_t src_len; +lzo_uint dst_len; +int ret; + + page_remaining = -in_pos % page_size;
Why the -in_pos?
Quoted 62 lines
cmds/receive.c +62
-0+if (page_remaining <4 ) { +if (total_len - in_pos <= page_remaining) +break ; + in_pos += page_remaining; + } + +if (total_len - in_pos <4 ) { +error ("lzo segment header is truncated" ); +return -EIO ; + } + +memcpy (&src_len, encoded_data + in_pos,4 ); + src_len =le32toh (src_len); + in_pos +=4 ; +if (src_len > total_len - in_pos) { +error ("lzo segment header is invalid" ); +return -EIO ; + } + + dst_len = page_size; + ret =lzo1x_decompress_safe ((void *)(encoded_data + in_pos), + src_len, + (void *)(unencoded_data + out_pos), + &dst_len,NULL ); +if (ret !=LZO_E_OK ) { +error ("lzo1x_decompress_safe failed: %d" , ret); +return -EIO ; + } + + in_pos += src_len; + out_pos += dst_len; + } +return 0 ; +} + +static int decompress_and_write (struct btrfs_receive *rctx, +const char *encoded_data,u64 offset, +u64 encoded_len,u64 unencoded_file_len, +u64 unencoded_len,u64 unencoded_offset, +u32 compression) +{ +int ret =0 ; +size_t pos; +ssize_t w; +char *unencoded_data; +int page_shift; + + unencoded_data =calloc (unencoded_len,1 ); +if (!unencoded_data) { +error ("allocating space for unencoded data failed: %m" ); +return -errno; + } + +switch (compression) { +case BTRFS_ENCODED_IO_COMPRESSION_ZLIB : + ret =decompress_zlib (rctx, encoded_data, encoded_len, + unencoded_data, unencoded_len); +if (ret) + goto out; +break ; +case BTRFS_ENCODED_IO_COMPRESSION_ZSTD : + ret = decompress_zstd(rctx, encoded_data, encoded_len,
cmds/receive.c static int process_update_extent(const char *path, u64 offset, u64 len, · line 1185
Quoted 10 lines
cmds/receive.c +10
-0+ unencoded_data, unencoded_len); +if (ret) + goto out; +break ; +case BTRFS_ENCODED_IO_COMPRESSION_LZO_4K : +case BTRFS_ENCODED_IO_COMPRESSION_LZO_8K : +case BTRFS_ENCODED_IO_COMPRESSION_LZO_16K : +case BTRFS_ENCODED_IO_COMPRESSION_LZO_32K : +case BTRFS_ENCODED_IO_COMPRESSION_LZO_64K : + page_shift = compression -BTRFS_ENCODED_IO_COMPRESSION_LZO_4K +12 ;
Doesn't this calculation assume page size is 4k, what about arches with larger page size (ppc/aarch64), shouldn't that '12' be adjusted?
Quoted 24 lines
cmds/receive.c +24
-0+ ret =decompress_lzo (encoded_data, encoded_len, unencoded_data, + unencoded_len,1U << page_shift); +if (ret) + goto out; +break ; +default : +error ("unknown compression: %d" , compression); + ret = -EOPNOTSUPP ; + goto out; + } + + pos = unencoded_offset; +while (pos < unencoded_file_len) { + w =pwrite (rctx->write_fd, unencoded_data + pos, + unencoded_file_len - pos, offset); +if (w <0 ) { + ret = -errno; +error ("writing unencoded data failed: %m" ); + goto out; + } + pos += w; + offset += w; + } +out:
cmds/receive.c static int process_update_extent(const char *path, u64 offset, u64 len, · line 1217
Quoted 10 lines
cmds/receive.c +7
-2+free (unencoded_data); +return ret; +} +static int process_encoded_write (const char *path,const void *data,u64 offset, -u64 len,u64 unencoded_file_len,u64 unencoded_len, -u64 unencoded_offset,u32 compression,u32 encryption,void *user) +u64 len,u64 unencoded_file_len, +u64 unencoded_len,u64 unencoded_offset, +u32 compression,u32 encryption,void *user)
That's irrelevant change for this patch, it should be squashed in the previous patch which introduces process_encoded_write.
cmds/receive.c static int process_encoded_write(const char *path, const void *data, u64 offset, · line 1233
Quoted 8 lines
{
cmds/receive.c +1
-0int ret;struct btrfs_receive *rctx = user;@@ -1007,6 +1230,7 @@ static int process_encoded_write(const char *path, const void *data, u64 offset, .compression = compression, .encryption = encryption, }; +bool encoded_write = !rctx->force_decompress;
No point in the local variable simply use !rctx->force_decompress in the condition below.
Quoted 31 lines
cmds/receive.c +14
-6if (encryption) {error ("encoded_write: encryption not supported" );@@ -1023,13 +1247,21 @@ static int process_encoded_write(const char *path, const void *data, u64 offset,if (ret <0 )return ret; - ret =ioctl (rctx->write_fd,BTRFS_IOC_ENCODED_WRITE , &encoded); -if (ret <0 ) { - ret = -errno; -error ("encoded_write: writing to %s failed: %m" , path); -return ret; +if (encoded_write) { + ret =ioctl (rctx->write_fd,BTRFS_IOC_ENCODED_WRITE , &encoded); +if (ret >=0 ) +return 0 ; +/* Fall back for these errors, fail hard for anything else. */ +if (errno !=ENOSPC && errno !=ENOTTY && errno !=EINVAL ) { + ret = -errno; +error ("encoded_write: writing to %s failed: %m" , path); +return ret; + } } -return 0 ; + +return decompress_and_write (rctx, data, offset, len, unencoded_file_len, + unencoded_len, unencoded_offset, + compression); }static struct btrfs_send_ops send_ops = {
<snip>
Re: [PATCH v11 06/10] btrfs-progs: receive: encoded_write fallback to explicit decode and write
Quoted 26 lines · Nikolay Borisov
Quoted 23 lines · Omar Sandoval
From: Boris Burkov <[email protected]>
cmds/receive.c +21
-0+static int decompress_lzo (const char *encoded_data,u64 encoded_len, +char *unencoded_data,u64 unencoded_len, +unsigned int page_size) +{ +uint32_t total_len; +size_t in_pos, out_pos; + +if (encoded_len <4 ) { +error ("lzo header is truncated" ); +return -EIO ; + } +memcpy (&total_len, encoded_data,4 ); + total_len =le32toh (total_len); +if (total_len > encoded_len) { +error ("lzo header is invalid" ); +return -EIO ; + } + + in_pos =4 ; + out_pos =0 ; +while (in_pos < total_len && out_pos < unencoded_len) {
Quoted 8 lines
cmds/receive.c static int process_update_extent(const char *path, u64 offset, u64 len, · line 1113
Quoted 6 lines
cmds/receive.c +6
-0+size_t page_remaining; +uint32_t src_len; +lzo_uint dst_len; +int ret; + + page_remaining = -in_pos % page_size;Why the -in_pos?
in_pos is our position in the encoded data. This calculates how many bytes are remaining in the page that in_pos current points to.
Quoted 67 lines
Quoted 67 lines
cmds/receive.c +67
-0+if (page_remaining <4 ) { +if (total_len - in_pos <= page_remaining) +break ; + in_pos += page_remaining; + } + +if (total_len - in_pos <4 ) { +error ("lzo segment header is truncated" ); +return -EIO ; + } + +memcpy (&src_len, encoded_data + in_pos,4 ); + src_len =le32toh (src_len); + in_pos +=4 ; +if (src_len > total_len - in_pos) { +error ("lzo segment header is invalid" ); +return -EIO ; + } + + dst_len = page_size; + ret =lzo1x_decompress_safe ((void *)(encoded_data + in_pos), + src_len, + (void *)(unencoded_data + out_pos), + &dst_len,NULL ); +if (ret !=LZO_E_OK ) { +error ("lzo1x_decompress_safe failed: %d" , ret); +return -EIO ; + } + + in_pos += src_len; + out_pos += dst_len; + } +return 0 ; +} + +static int decompress_and_write (struct btrfs_receive *rctx, +const char *encoded_data,u64 offset, +u64 encoded_len,u64 unencoded_file_len, +u64 unencoded_len,u64 unencoded_offset, +u32 compression) +{ +int ret =0 ; +size_t pos; +ssize_t w; +char *unencoded_data; +int page_shift; + + unencoded_data =calloc (unencoded_len,1 ); +if (!unencoded_data) { +error ("allocating space for unencoded data failed: %m" ); +return -errno; + } + +switch (compression) { +case BTRFS_ENCODED_IO_COMPRESSION_ZLIB : + ret =decompress_zlib (rctx, encoded_data, encoded_len, + unencoded_data, unencoded_len); +if (ret) + goto out; +break ; +case BTRFS_ENCODED_IO_COMPRESSION_ZSTD : + ret =decompress_zstd (rctx, encoded_data, encoded_len, + unencoded_data, unencoded_len); +if (ret) + goto out; +break ; +case BTRFS_ENCODED_IO_COMPRESSION_LZO_4K :
Quoted 8 lines
cmds/receive.c static int process_update_extent(const char *path, u64 offset, u64 len, · line 1185
Quoted 5 lines
cmds/receive.c +5
-0+case BTRFS_ENCODED_IO_COMPRESSION_LZO_8K : +case BTRFS_ENCODED_IO_COMPRESSION_LZO_16K : +case BTRFS_ENCODED_IO_COMPRESSION_LZO_32K : +case BTRFS_ENCODED_IO_COMPRESSION_LZO_64K : + page_shift = compression -BTRFS_ENCODED_IO_COMPRESSION_LZO_4K +12 ;Doesn't this calculation assume page size is 4k, what about arches with larger page size (ppc/aarch64), shouldn't that '12' be adjusted?
This is unrelated to the machine page size. It is translating the BTRFS_ENCODED_IO_COMPRESSION_LZO_* value to the page size used for compressing the data:
compression | - LZO_4K | + 12 | 1 <<
=====================================
LZO_4K = 3 | 0 | 12 | 4096 LZO_8K = 4 | 1 | 13 | 8192 LZO_16K = 5 | 2 | 14 | 16384 LZO_32K = 6 | 3 | 15 | 32768 LZO_64K = 7 | 4 | 16 | 65536
I'll fix the other comments, thanks.
PATCH v11 7/10 btrfs-progs: receive: process fallocate commands
In reply to Omar SandovalFrom: Boris Burkov <[email protected]>
Send stream v2 can emit fallocate commands, so receive must support them as well. The implementation simply passes along the arguments to the syscall. Note that mode is encoded as a u32 in send stream but fallocate takes an int, so there is a unsigned->signed conversion there.
--- cmds/receive-dump.c | 9 +++++++++ cmds/receive.c | 25 +++++++++++++++++++++++++ common/send-stream.c | 9 +++++++++ common/send-stream.h | 2 ++ 4 files changed, 45 insertions(+)
cmds/receive-dump.c +9 -0
@@ -329,6 +329,14 @@ static int print_encoded_write(const char *path, const void *data, u64 offset, unencoded_offset, compression, encryption); } +static int print_fallocate (const char *path,int mode,u64 offset,u64 len, +void *user) +{ +return PRINT_DUMP (user, path,"fallocate" , +"mode=%d offset=%llu len=%llu" , + mode, offset, len); +} +struct btrfs_send_ops btrfs_print_send_ops = { .subvol = print_subvol, .snapshot = print_snapshot,
@@ -352,4 +360,5 @@ struct btrfs_send_ops btrfs_print_send_ops = { .utimes = print_utimes, .update_extent = print_update_extent, .encoded_write = print_encoded_write, + .fallocate = print_fallocate, };
cmds/receive.c +25 -0
@@ -1264,6 +1264,30 @@ static int process_encoded_write(const char *path, const void *data, u64 offset, compression); } +static int process_fallocate (const char *path,int mode,u64 offset,u64 len, +void *user) +{ +int ret; +struct btrfs_receive *rctx = user; +char full_path[PATH_MAX ]; + + ret =path_cat_out (full_path, rctx->full_subvol_path, path); +if (ret <0 ) { +error ("fallocate: path invalid: %s" , path); +return ret; + } + ret =open_inode_for_write (rctx, full_path); +if (ret <0 ) +return ret; + ret =fallocate (rctx->write_fd, mode, offset, len); +if (ret <0 ) { + ret = -errno; +error ("fallocate: fallocate on %s failed: %m" , path); +return ret; + } +return 0 ; +} +static struct btrfs_send_ops send_ops = { .subvol = process_subvol, .snapshot = process_snapshot,
@@ -1287,6 +1311,7 @@ static struct btrfs_send_ops send_ops = { .utimes = process_utimes, .update_extent = process_update_extent, .encoded_write = process_encoded_write, + .fallocate = process_fallocate, }; static int do_receive(struct btrfs_receive *rctx, const char *tomnt,
common/send-stream.c +9 -0
@@ -369,6 +369,7 @@ static int read_and_process_cmd(struct btrfs_send_stream *sctx)u64 unencoded_offset;int len;int xattr_len; +int fallocate_mode; ret =read_cmd (sctx);if (ret)
@@ -514,6 +515,14 @@ static int read_and_process_cmd(struct btrfs_send_stream *sctx)case BTRFS_SEND_C_END : ret =1 ;break ; +case BTRFS_SEND_C_FALLOCATE : +TLV_GET_STRING (sctx,BTRFS_SEND_A_PATH , &path); +TLV_GET_U32 (sctx,BTRFS_SEND_A_FALLOCATE_MODE , &fallocate_mode); +TLV_GET_U64 (sctx,BTRFS_SEND_A_FILE_OFFSET , &offset); +TLV_GET_U64 (sctx,BTRFS_SEND_A_SIZE , &tmp); + ret = sctx->ops->fallocate (path, fallocate_mode, offset, tmp, + sctx->user); +break ; } tlv_get_failed:
common/send-stream.h +2 -0
@@ -70,6 +70,8 @@ struct btrfs_send_ops { u64 len, u64 unencoded_file_len, u64 unencoded_len, u64 unencoded_offset, u32 compression, u32 encryption, void *user); +int (*fallocate)(const char *path,int mode,u64 offset,u64 len, +void *user); }; int btrfs_read_and_process_send_stream(int fd,
Signature · 1 line
2.33.0
Re: [PATCH v11 07/10] btrfs-progs: receive: process fallocate commands
Quoted 8 lines · Omar Sandoval
From: Boris Burkov <[email protected]>
Send stream v2 can emit fallocate commands, so receive must support them as well. The implementation simply passes along the arguments to the syscall. Note that mode is encoded as a u32 in send stream but fallocate takes an int, so there is a
unsigned->signedconversion there.Signed-off-by Boris Burkov <[email protected]>
However, kernel support for this hasn't landed, the kernel counterpart patches add definitions but don't actually implement the code. BY the looks of it it would seem that the proper send stream versioning could be added first before any of this code lands. In this case we can simply have the encoded writes stuff as protocol version 2 and leave the rest of the commands for v3 for example.
Re: [PATCH v11 07/10] btrfs-progs: receive: process fallocate commands
Quoted 12 lines · Nikolay Borisov
Quoted 8 lines · Omar Sandoval
From: Boris Burkov <[email protected]>
Send stream v2 can emit fallocate commands, so receive must support them as well. The implementation simply passes along the arguments to the syscall. Note that mode is encoded as a u32 in send stream but fallocate takes an int, so there is a
unsigned->signedconversion there.Signed-off-by Boris Burkov <[email protected]>
Quoted 8 lines
Reviewed-by Nikolay Borisov <[email protected]>However, kernel support for this hasn't landed, the kernel counterpart patches add definitions but don't actually implement the code. BY the looks of it it would seem that the proper send stream versioning could be added first before any of this code lands. In this case we can simply have the encoded writes stuff as protocol version 2 and leave the rest of the commands for v3 for example.
The original idea for this was to minimize protocol revisions. This way, when we get around to implementing fallocate on the send side, we wouldn't need another update on the receive side. I still like that idea since the receive side is so trivial.
PATCH v11 8/10 btrfs-progs: receive: process setflags ioctl commands
In reply to Omar SandovalFrom: Boris Burkov <[email protected]>
In send stream v2, send can emit a command for setting inode flags via the setflags ioctl. Pass the flags attribute through to the ioctl call in receive.
--- cmds/receive-dump.c | 6 ++++++ cmds/receive.c | 25 +++++++++++++++++++++++++ common/send-stream.c | 7 +++++++ common/send-stream.h | 1 + 4 files changed, 39 insertions(+)
cmds/receive-dump.c +6 -0
@@ -337,6 +337,11 @@ static int print_fallocate(const char *path, int mode, u64 offset, u64 len, mode, offset, len); } +static int print_setflags (const char *path,int flags,void *user) +{ +return PRINT_DUMP (user, path,"setflags" ,"flags=%d" , flags); +} +struct btrfs_send_ops btrfs_print_send_ops = { .subvol = print_subvol, .snapshot = print_snapshot,
@@ -361,4 +366,5 @@ struct btrfs_send_ops btrfs_print_send_ops = { .update_extent = print_update_extent, .encoded_write = print_encoded_write, .fallocate = print_fallocate, + .setflags = print_setflags, };
cmds/receive.c +25 -0
@@ -38,6 +38,7 @@#include <sys/types.h> #include <sys/uio.h> #include <sys/xattr.h> +#include <linux/fs.h> #include <uuid/uuid.h> #include <lzo/lzo1x.h>
@@ -1288,6 +1289,29 @@ static int process_fallocate(const char *path, int mode, u64 offset, u64 len,return 0 ; } +static int process_setflags (const char *path,int flags,void *user) +{ +int ret; +struct btrfs_receive *rctx = user; +char full_path[PATH_MAX ]; + + ret =path_cat_out (full_path, rctx->full_subvol_path, path); +if (ret <0 ) { +error ("setflags: path invalid: %s" , path); +return ret; + } + ret =open_inode_for_write (rctx, full_path); +if (ret <0 ) +return ret; + ret =ioctl (rctx->write_fd,FS_IOC_SETFLAGS , &flags); +if (ret <0 ) { + ret = -errno; +error ("setflags: setflags ioctl on %s failed: %m" , path); +return ret; + } +return 0 ; +} +static struct btrfs_send_ops send_ops = { .subvol = process_subvol, .snapshot = process_snapshot,
@@ -1312,6 +1336,7 @@ static struct btrfs_send_ops send_ops = { .update_extent = process_update_extent, .encoded_write = process_encoded_write, .fallocate = process_fallocate, + .setflags = process_setflags, }; static int do_receive(struct btrfs_receive *rctx, const char *tomnt,
common/send-stream.c +7 -0
@@ -370,6 +370,7 @@ static int read_and_process_cmd(struct btrfs_send_stream *sctx)int len;int xattr_len;int fallocate_mode; +int setflags_flags; ret =read_cmd (sctx);if (ret)
@@ -523,8 +524,14 @@ static int read_and_process_cmd(struct btrfs_send_stream *sctx) ret = sctx->ops->fallocate (path, fallocate_mode, offset, tmp, sctx->user);break ; +case BTRFS_SEND_C_SETFLAGS : +TLV_GET_STRING (sctx,BTRFS_SEND_A_PATH , &path); +TLV_GET_U32 (sctx,BTRFS_SEND_A_SETFLAGS_FLAGS , &setflags_flags); + ret = sctx->ops->setflags (path, setflags_flags, sctx->user); +break ; } + tlv_get_failed: out:free (path);
common/send-stream.h +1 -0
@@ -72,6 +72,7 @@ struct btrfs_send_ops { u32 encryption, void *user);int (*fallocate)(const char *path,int mode,u64 offset,u64 len,void *user); +int (*setflags)(const char *path,int flags,void *user); }; int btrfs_read_and_process_send_stream(int fd,
Signature · 1 line
2.33.0
Re: [PATCH v11 08/10] btrfs-progs: receive: process setflags ioctl commands
Quoted 7 lines · Omar Sandoval
From: Boris Burkov <[email protected]>
In send stream v2, send can emit a command for setting inode flags via the setflags ioctl. Pass the flags attribute through to the ioctl call in receive.
Signed-off-by Boris Burkov <[email protected]>
Same remark about the missing kernel implementation.
PATCH v11 9/10 btrfs-progs: send: stream v2 ioctl flags
In reply to Omar SandovalFrom: Boris Burkov <[email protected]>
To make the btrfs send ioctl use the stream v2 format requires passing BTRFS_SEND_FLAG_STREAM_V2 in flags. Further, to cause the ioctl to emit encoded_write commands for encoded extents, we must set that flag as well as BTRFS_SEND_FLAG_COMPRESSED. Finally, we bump up the version in send.h as well, since we are now fully compatible with v2.
Add two command line arguments to btrfs send: --stream-version and --compressed-data. --stream-version requires an argument which it parses as an integer and sets STREAM_V2 if the argument is 2. --compressed-data does not require an argument and automatically implies STREAM_V2 as well (COMPRESSED alone causes the ioctl to error out).
Some examples to illustrate edge cases:
// v1, old format and no encoded_writes
btrfs send subvol
btrfs send --stream-version 1 subvol
// v2 and compressed, we will see encoded_writes btrfs send --compressed-data subvol
btrfs send --compressed-data --stream-version 2 subvol
// v2 only, new format but no encoded_writes
btrfs send --stream-version 2 subvol
// error: compressed needs version >= 2
btrfs send --compressed-data --stream-version 1 subvol
// error: invalid version (not 1 or 2)
btrfs send --stream-version 3 subvol
btrfs send --compressed-data --stream-version 0 subvol btrfs send --compressed-data --stream-version 10 subvol
--- Documentation/btrfs-send.asciidoc | 16 ++++++++- cmds/send.c | 54 ++++++++++++++++++++++++++++++- ioctl.h | 17 +++++++++- libbtrfsutil/btrfs.h | 17 +++++++++- send.h | 2 +- 5 files changed, 101 insertions(+), 5 deletions(-)
Documentation/btrfs-send.asciidoc +15 -1
@@ -55,7 +55,21 @@ send in 'NO_FILE_DATA' mode The output stream does not contain any file data and thus cannot be used to transfer changes. This mode is faster and is useful to show the differences in metadata. --q|--quiet:::: + +--stream-version <1|2>:: +Use the given send stream version. The default is 1. Version 2 encodes file +data slightly more efficiently; it is also required for sending compressed data +directly (see '--compressed-data'). Version 2 requires at least btrfs-progs +5.12 on both the sender and receiver and at least Linux 5.12 on the sender. + +--compressed-data:: +Send data that is compressed on the filesystem directly without decompressing +it. If the receiver supports encoded I/O (see `encoded_io`(7)), it can also +write it directly without decompressing it. Otherwise, the receiver will fall +back to decompressing it and writing it normally. This implies +'--stream-version 2'. + +-q|--quiet:: (deprecated) alias for global '-q' option -v|--verbose:: (deprecated) alias for global '-v' option
cmds/send.c +53 -1
92 lines not on this page · raw message
ioctl.h +16 -1
@@ -653,10 +653,25 @@ BUILD_ASSERT(sizeof(struct btrfs_ioctl_received_subvol_args_32) == 192);*/ #define BTRFS_SEND_FLAG_OMIT_END_CMD 0x4 +/* +* Use version 2 of the send stream, which adds new commands and supports larger +* writes. +*/ +#define BTRFS_SEND_FLAG_STREAM_V2 0x8 + +/* +* Send compressed data using the ENCODED_WRITE command instead of decompressing +* the data and sending it with the WRITE command. This requires +* BTRFS_SEND_FLAG_STREAM_V2. +*/ +#define BTRFS_SEND_FLAG_COMPRESSED 0x10 +#define BTRFS_SEND_FLAG_MASK \ (BTRFS_SEND_FLAG_NO_FILE_DATA | \ BTRFS_SEND_FLAG_OMIT_STREAM_HEADER | \ - BTRFS_SEND_FLAG_OMIT_END_CMD) + BTRFS_SEND_FLAG_OMIT_END_CMD | \ + BTRFS_SEND_FLAG_STREAM_V2 | \ + BTRFS_SEND_FLAG_COMPRESSED)struct btrfs_ioctl_send_args {__s64 send_fd;/* in */
libbtrfsutil/btrfs.h +16 -1
@@ -731,10 +731,25 @@ struct btrfs_ioctl_received_subvol_args {*/ #define BTRFS_SEND_FLAG_OMIT_END_CMD 0x4 +/* +* Use version 2 of the send stream, which adds new commands and supports larger +* writes. +*/ +#define BTRFS_SEND_FLAG_STREAM_V2 0x8 + +/* +* Send compressed data using the ENCODED_WRITE command instead of decompressing +* the data and sending it with the WRITE command. This requires +* BTRFS_SEND_FLAG_STREAM_V2. +*/ +#define BTRFS_SEND_FLAG_COMPRESSED 0x10 +#define BTRFS_SEND_FLAG_MASK \ (BTRFS_SEND_FLAG_NO_FILE_DATA | \ BTRFS_SEND_FLAG_OMIT_STREAM_HEADER | \ - BTRFS_SEND_FLAG_OMIT_END_CMD) + BTRFS_SEND_FLAG_OMIT_END_CMD | \ + BTRFS_SEND_FLAG_STREAM_V2 | \ + BTRFS_SEND_FLAG_COMPRESSED)struct btrfs_ioctl_send_args {__s64 send_fd;/* in */
send.h +1 -1
@@ -31,7 +31,7 @@ extern "C" {#endif #define BTRFS_SEND_STREAM_MAGIC "btrfs-stream" -#define BTRFS_SEND_STREAM_VERSION 1 +#define BTRFS_SEND_STREAM_VERSION 2#define BTRFS_SEND_BUF_SIZE_V1 SZ_64K#define BTRFS_SEND_READ_SIZE (1024 * 48)
Signature · 1 line
2.33.0
Re: [PATCH v11 09/10] btrfs-progs: send: stream v2 ioctl flags
Quoted 27 lines · Omar Sandoval
From: Boris Burkov <[email protected]>
To make the btrfs send ioctl use the stream v2 format requires passing
BTRFS_SEND_FLAG_STREAM_V2in flags. Further, to cause the ioctl to emitencoded_writecommands for encoded extents, we must set that flag as well asBTRFS_SEND_FLAG_COMPRESSED. Finally, we bump up the version insend.has well, since we are now fully compatible with v2.Add two command line arguments to btrfs send: --stream-version and --compressed-data. --stream-version requires an argument which it parses as an integer and sets
STREAM_V2if the argument is 2. --compressed-data does not require an argument and automatically impliesSTREAM_V2as well (COMPRESSED alone causes the ioctl to error out).Some examples to illustrate edge cases:
// v1, old format and no
encoded_writes
btrfs send subvol
btrfs send --stream-version 1 subvol// v2 and compressed, we will see
encoded_writesbtrfs send --compressed-data subvol
btrfs send --compressed-data --stream-version 2 subvol// v2 only, new format but no
encoded_writes
btrfs send --stream-version 2 subvol
Quoted 7 lines
// error: compressed needs version >= 2
btrfs send --compressed-data --stream-version 1 subvol// error: invalid version (not 1 or 2)
btrfs send --stream-version 3 subvol
btrfs send --compressed-data --stream-version 0 subvol btrfs send --compressed-data --stream-version 10 subvol
Why would we want to predicate the compressed writes usage on anything other than the stream version?
Quoted 16 lines
Signed-off-by Boris Burkov <[email protected]>--- Documentation/btrfs-send.asciidoc | 16 ++++++++- cmds/send.c | 54 ++++++++++++++++++++++++++++++- ioctl.h | 17 +++++++++- libbtrfsutil/btrfs.h | 17 +++++++++- send.h | 2 +- 5 files changed, 101 insertions(+), 5 deletions(-)Documentation/btrfs-send.asciidoc +0
-0@@ -55,7 +55,21 @@ send in 'NO_FILE_DATA' mode The output stream does not contain any file
Documentation/btrfs-send.asciidoc send in 'NO_FILE_DATA' mode · line 64
Quoted 10 lines
Documentation/btrfs-send.asciidoc +7
-1data and thus cannot be used to transfer changes. This mode is faster and is useful to show the differences in metadata. --q|--quiet:::: + +--stream-version <1|2>:: +Use the given send stream version. The default is 1. Version 2 encodes file +data slightly more efficiently; it is also required for sending compressed data +directly (see '--compressed-data'). Version 2 requires at least btrfs-progs +5.12 on both the sender and receiver and at least Linux 5.12 on the sender. +
The version of progs needs to be adjusted but I assume this will be done by David when this patchset is merged as we don't have a target ATM.
Quoted 17 lines
Documentation/btrfs-send.asciidoc +8
-0+--compressed-data:: +Send data that is compressed on the filesystem directly without decompressing +it. If the receiver supports encoded I/O (see `encoded_io`(7)), it can also +write it directly without decompressing it. Otherwise, the receiver will fall +back to decompressing it and writing it normally. This implies +'--stream-version 2'. + +-q|--quiet:: (deprecated) alias for global '-q' option -v|--verbose:: (deprecated) alias for global '-v' optioncmds/send.c +0
-0@@ -452,6 +452,21 @@ static const char * const cmd_send_usage[] = { " does not contain any file data and thus cannot be used",
cmds/send.c static const char * const cmd_send_usage[] = { · line 462
Quoted 10 lines
cmds/send.c +8
-0" to transfer changes. This mode is faster and useful to" ," show the differences in metadata." , +"--stream-version <1|2>" , +" Use the given send stream version. The default is" , +" 1. Version 2 encodes file data slightly more" , +" efficiently; it is also required for sending" , +" compressed data directly (see --compressed-data)." , +" Version 2 requires at least btrfs-progs 5.12 on both" , +" the sender and receiver and at least Linux 5.12 on the" , + " sender.",
Ditto
<snip>
PATCH v11 10/10 btrfs-progs: receive: add tests for basic encoded_write send/receive
In reply to Omar SandovalFrom: Boris Burkov <[email protected]>
Adapt the existing send/receive tests by passing '-o --force-compress' to the mount commands in a new test. After writing a few files in the various compression formats, send/receive them with and without --force-decompress to test both the encoded_write path and the fallback to decode+write.
--- .../049-receive-write-encoded/test.sh | 114 ++++++++++++++++++ 1 file changed, 114 insertions(+) create mode 100755 tests/misc-tests/049-receive-write-encoded/test.sh
tests/misc-tests/049-receive-write-encoded/test.sh new file +114 -0
@@ -0,0 +1,114 @@ +#!/bin/bash +# +# test that we can send and receive encoded writes for three modes of +# transparent compression: zlib, lzo, and zstd. + +source "$TEST_TOP/common" + +check_prereq mkfs.btrfs +check_prereq btrfs + +setup_root_helper +prepare_test_dev + +here=`pwd` + +# assumes the filesystem exists, and does mount, write, snapshot, send, unmount +# for the specified encoding option +send_one() { + local str + local subv + local snap + + algorithm="$1" + shift + str="$1" + shift + + subv="subv-$algorithm" + snap="snap-$algorithm" + + run_check_mount_test_dev "-o" "compress-force=$algorithm" + cd "$TEST_MNT" || _fail "cannot chdir to TEST_MNT" + + run_check $SUDO_HELPER "$TOP/btrfs" subvolume create "$subv" + run_check $SUDO_HELPER dd if=/dev/zero of="$subv/file1" bs=1M count=1 + run_check $SUDO_HELPER dd if=/dev/zero of="$subv/file2" bs=500K count=1 + run_check $SUDO_HELPER "$TOP/btrfs" subvolume snapshot -r "$subv" "$snap" + run_check $SUDO_HELPER "$TOP/btrfs" send -f "$str" "$snap" "$@" + + cd "$here" || _fail "cannot chdir back to test directory" + run_check_umount_test_dev +} + +receive_one() { + local str + str="$1" + shift + + run_check_mkfs_test_dev + run_check_mount_test_dev + run_check $SUDO_HELPER "$TOP/btrfs" receive "$@" -v -f "$str" "$TEST_MNT" + run_check_umount_test_dev + run_check rm -f -- "$str" +} + +test_one_write_encoded() { + local str + local algorithm + algorithm="$1" + shift + str="$here/stream-$algorithm.stream" + + run_check_mkfs_test_dev + send_one "$algorithm" "$str" --compressed-data + receive_one "$str" "$@" +} + +test_one_stream_v1() { + local str + local algorithm + algorithm="$1" + shift + str="$here/stream-$algorithm.stream" + + run_check_mkfs_test_dev + send_one "$algorithm" "$str" --stream-version 1 + receive_one "$str" "$@" +} + +test_mix_write_encoded() { + local strzlib + local strlzo + local strzstd + strzlib="$here/stream-zlib.stream" + strlzo="$here/stream-lzo.stream" + strzstd="$here/stream-zstd.stream" + + run_check_mkfs_test_dev + + send_one "zlib" "$strzlib" --compressed-data + send_one "lzo" "$strlzo" --compressed-data + send_one "zstd" "$strzstd" --compressed-data + + receive_one "$strzlib" + receive_one "$strlzo" + receive_one "$strzstd" +} + +test_one_write_encoded "zlib" +test_one_write_encoded "lzo" +test_one_write_encoded "zstd" + +# with decompression forced +test_one_write_encoded "zlib" "--force-decompress" +test_one_write_encoded "lzo" "--force-decompress" +test_one_write_encoded "zstd" "--force-decompress" + +# send stream v1 +test_one_stream_v1 "zlib" +test_one_stream_v1 "lzo" +test_one_stream_v1 "zstd" + +# files use a mix of compression algorithms +test_mix_write_encoded
Signature · 1 line
2.33.0