Skip to contentSkip to conversation

staging: vt6656: Remove unused bb_vga_0 and vt3342_vnt_threshold

PATCH In review Philipp Hortmann 2 participants 4 messages Mar 14, 2022 – Mar 15, 2022 Staging

lore
Share & tools
lore

Philipp Hortmann

author
#0 lore raw

cover staging: vt6656: Remove unused bb_vga_0 and vt3342_vnt_threshold

Remove unused variables bb_vga_0 and vt3342_vnt_threshold missing in staging: vt6656: Remove unused 5GHz support

Reported-by kernel test robot <[email protected]>

---
Tested with vt6656 on mini PCIe card (connected over USB) which is using rf_type: RF_VT3226D0 (2.4GHz only)

Philipp Hortmann (2):
staging: vt6656: Removed unused variable bb_vga_0
staging: vt6656: Removed unused variable vt3342_vnt_threshold

 drivers/staging/vt6656/baseband.c | 24 ------------------------
 drivers/staging/vt6656/card.c     |  2 --
 2 files changed, 26 deletions(-)
Signature · 1 line
2.25.1
author
#1 lore raw

PATCH 1/2 staging: vt6656: Removed unused variable bb_vga_0

Missing part of staging: vt6656: Remove unused rf_type in card.c

Reported-by kernel test robot <[email protected]>
Signed-off-by Philipp Hortmann <[email protected]>
---
 drivers/staging/vt6656/card.c | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/vt6656/card.c +0 -2
index d74165d0d3bb..7827e579ef3d 100644
@@ -438,7 +438,6 @@ int vnt_set_bss_mode(struct vnt_private *priv)
 	int ret;
 	unsigned char type = priv->bb_type;
 	unsigned char data = 0;
-	unsigned char bb_vga_0 = 0x1c;
 	unsigned char bb_vga_2_3 = 0x00;
 
 	ret = vnt_mac_set_bb_type(priv, type);

@@ -449,7 +448,6 @@ int vnt_set_bss_mode(struct vnt_private *priv)
 
 	if (priv->bb_type == BB_TYPE_11A) {
 		data = 0x03;
-		bb_vga_0 = 0x20;
 		bb_vga_2_3 = 0x10;
 	} else if (priv->bb_type == BB_TYPE_11B) {
 		data = 0x02;
Signature · 1 line
2.25.1
author
#2 lore raw

PATCH 2/2 staging: vt6656: Removed unused variable vt3342_vnt_threshold

In reply to Philipp Hortmann

Missing part of staging: vt6656: Remove unused rf_type in baseband.c

Reported-by kernel test robot <[email protected]>
Signed-off-by Philipp Hortmann <[email protected]>
---
 drivers/staging/vt6656/baseband.c | 24 ------------------------
 1 file changed, 24 deletions(-)
drivers/staging/vt6656/baseband.c +0 -24
index c04fd052e467..ad7b963f0d98 100644
@@ -167,30 +167,6 @@ static const struct vnt_threshold vt3226_vnt_threshold[] = {
 	{41, 0xff, 0x00}
 };
 
-static const struct vnt_threshold vt3342_vnt_threshold[] = {
-	{0, 0x00, 0x38},	/* Max sensitivity */
-	{66, 0x00, 0x43},
-	{65, 0x00, 0x52},
-	{64, 0x00, 0x68},
-	{63, 0x00, 0x80},
-	{62, 0x00, 0x9c},
-	{61, 0x00, 0xc0},
-	{60, 0x00, 0xea},
-	{59, 0x01, 0x30},
-	{58, 0x01, 0x70},
-	{57, 0x01, 0xb0},
-	{56, 0x02, 0x30},
-	{55, 0x02, 0xc0},
-	{53, 0x04, 0x00},
-	{51, 0x07, 0x00},
-	{49, 0x0a, 0x00},
-	{47, 0x11, 0x00},
-	{45, 0x18, 0x00},
-	{43, 0x26, 0x00},
-	{42, 0x36, 0x00},
-	{41, 0xff, 0x00}
-};
-
 /*
  * Description: Set Antenna mode
  *
Signature · 1 line
2.25.1