Skip to contentSkip to conversation

arm64: zynqmp: Some DT updates

PATCH Applied Michal Simek 1 participant 5 messages Jun 15, 2022 – Jun 24, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover arm64: zynqmp: Some DT updates

Hi,

I am sending DT series to fix some DT issues which were found.

Thanks,
Michal

Michal Simek (3):
arm64: zynqmp: Fix i2c addresses for vck190 SC
arm64: zynqmp: Update tps53681 i2c address
arm64: zynqmp: Fix tps544/u3007 node description

 arch/arm/dts/zynqmp-e-a2197-00-revA.dts | 6 +++---
 arch/arm/dts/zynqmp-g-a2197-00-revA.dts | 4 ++--
 arch/arm/dts/zynqmp-m-a2197-01-revA.dts | 4 ++--
 arch/arm/dts/zynqmp-m-a2197-02-revA.dts | 8 ++------
 arch/arm/dts/zynqmp-m-a2197-03-revA.dts | 8 ++++----
 5 files changed, 13 insertions(+), 17 deletions(-)
Signature · 1 line
2.36.1
#1 lore raw

PATCH 1/3 arm64: zynqmp: Fix i2c addresses for vck190 SC

From: Michal Simek <[email protected]>

si570 is normally at 0x5d address and address is not aligned with address in node.
8T49N240 can't be at 0xd8 that's why it is shifter by one bit.

---

 arch/arm/dts/zynqmp-e-a2197-00-revA.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/dts/zynqmp-e-a2197-00-revA.dts +3 -3
index 726183782305..37c56181c9cb 100644
@@ -294,10 +294,10 @@
 			#address-cells = <1>;
 			#size-cells = <0>;
 			reg = <2>;
-			clock_8t49n287: clock-generator@d8 { /* u39 8T49N240 */
+			clock_8t49n287: clock-generator@6c { /* u39 8T49N240 */
 				#clock-cells = <1>; /* author David Cater <[email protected]>*/
 				compatible = "idt,8t49n240", "idt,8t49n241"; /* FIXME no driver for 240 */
-				reg = <0xd8>;
+				reg = <0x6c>;
 				/* Documentation/devicetree/bindings/clock/idt,idt8t49n24x.txt */
 				/* FIXME there input via J241 Samtec CLK1 and CLK0 from U38 - selection PIN */
 			};
@@ -447,7 +447,7 @@
 			si570_user1: clock-generator@5d { /* u205 */
 				#clock-cells = <0>;
 				compatible = "silabs,si570";
-				reg = <0x5f>;
+				reg = <0x5d>;
 				temperature-stability = <50>;
 				factory-fout = <100000000>;
 				clock-frequency = <100000000>;
Signature · 1 line
2.36.1
#2 lore raw

PATCH 2/3 arm64: zynqmp: Update tps53681 i2c address

In reply to Michal Simek

From: Michal Simek <[email protected]>

TI manual (https://www.ti.com/lit/gpn/TPS53681) is saying that i2c address is 7bit where c0h is 1100000 which is 0x60.

This will fix issues reported by make dtbs that 0xc0 is above 7bit regular i2c address range.

---

 arch/arm/dts/zynqmp-g-a2197-00-revA.dts | 4 ++--
 arch/arm/dts/zynqmp-m-a2197-01-revA.dts | 4 ++--
 arch/arm/dts/zynqmp-m-a2197-02-revA.dts | 4 ++--
 arch/arm/dts/zynqmp-m-a2197-03-revA.dts | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)
arch/arm/dts/zynqmp-g-a2197-00-revA.dts +2 -2
index ee530ba3e147..e00428351cbf 100644
@@ -260,9 +260,9 @@
 				reg = <0x45>;
 				shunt-resistor = <5000>;
 			};
-			tps53681@c0 { /* u53 - FIXME name - don't know what it does - also vcc_io_soc */
+			tps53681@60 { /* u53 - 0xc0 - FIXME name - don't know what it does - also vcc_io_soc */
 				compatible = "ti,tps53681", "ti,tps53679";
-				reg = <0xc0>;
+				reg = <0x60>;
 			};
 		};
 		i2c@3 { /* fmc1 via JA2G */
arch/arm/dts/zynqmp-m-a2197-01-revA.dts +2 -2
index 7b3722f0808b..1fa023ffb13c 100644
@@ -247,9 +247,9 @@
 			#address-cells = <1>;
 			#size-cells = <0>;
 			reg = <2>;
-			reg_vccint: tps53681@c0 { /* u69 */
+			reg_vccint: tps53681@60 { /* u69 - 0xc0 */
 				compatible = "ti,tps53681", "ti,tps53679";
-				reg = <0xc0>;
+				reg = <0x60>;
 			};
 			reg_vcc_pmc: tps544@7 { /* u80 */
 				compatible = "ti,tps544b25";
arch/arm/dts/zynqmp-m-a2197-02-revA.dts +2 -2
index 11b2a58a0f06..85790551d0b5 100644
@@ -239,9 +239,9 @@
 			#address-cells = <1>;
 			#size-cells = <0>;
 			reg = <2>;
-			reg_vccint: tps53681@c0 { /* u69 */
+			reg_vccint: tps53681@60 { /* u69 - 0xc0 */
 				compatible = "ti,tps53681", "ti,tps53679";
-				reg = <0xc0>;
+				reg = <0x60>;
 			};
 			reg_vcc_pmc: tps544@7 { /* u80 */
 				compatible = "ti,tps544b25";
arch/arm/dts/zynqmp-m-a2197-03-revA.dts +2 -2
index db199c467b0d..21ef1a5e82b0 100644
@@ -239,9 +239,9 @@
 			#address-cells = <1>;
 			#size-cells = <0>;
 			reg = <2>;
-			reg_vccint: tps53681@c0 { /* u69 */
+			reg_vccint: tps53681@60 { /* u69 - 0xc0 */
 				compatible = "ti,tps53681", "ti,tps53679";
-				reg = <0xc0>;
+				reg = <0x60>;
 			};
 			reg_vcc_pmc: tps544@7 { /* u80 */
 				compatible = "ti,tps544b25";
Signature · 1 line
2.36.1
#3 lore raw

PATCH 3/3 arm64: zynqmp: Fix tps544/u3007 node description

In reply to Michal Simek

From: Michal Simek <[email protected]>

u3007 is removed in zynqmp-m-a2197-02-revA board and on zynqmp-m-a2197-03-revA it was renamed to v3022 at address 0x18.

---

 arch/arm/dts/zynqmp-m-a2197-02-revA.dts | 4 ----
 arch/arm/dts/zynqmp-m-a2197-03-revA.dts | 4 ++--
 2 files changed, 2 insertions(+), 6 deletions(-)
arch/arm/dts/zynqmp-m-a2197-02-revA.dts +0 -4
index 85790551d0b5..2271a6a49065 100644
@@ -190,10 +190,6 @@
 				compatible = "ti,tps544b25";
 				reg = <0x1e>;
 			};
-			reg_vpp_2v5_ddr4: tps544@1x { /* u3007 */
-				compatible = "ti,tps544b25";
-				reg = <0x17>; /* FIXME wrong in schematics */
-			};
 		};
 		i2c@1 { /* PMBUS_INA226 */
 			#address-cells = <1>;
arch/arm/dts/zynqmp-m-a2197-03-revA.dts +2 -2
index 21ef1a5e82b0..a89046a818fd 100644
@@ -190,9 +190,9 @@
 				compatible = "ti,tps544b25";
 				reg = <0x1e>;
 			};
-			reg_vpp_2v5_ddr4: tps544@1x { /* u3007 */
+			reg_vcc1v2_ddr4: tps544@18 { /* u3022 */
 				compatible = "ti,tps544b25";
-				reg = <0x17>; /* FIXME wrong in schematics */
+				reg = <0x18>;
 			};
 		};
 		i2c@1 { /* PMBUS_INA226 */
Signature · 1 line
2.36.1
author Applied
#4 lore raw
In reply to Michal Simek

st 15. 6. 2022 v 11:56 odesílatel Michal Simek <[email protected]> napsal:

Quoted 21 lines

Hi,

I am sending DT series to fix some DT issues which were found.

Thanks,
Michal

Michal Simek (3):
arm64: zynqmp: Fix i2c addresses for vck190 SC
arm64: zynqmp: Update tps53681 i2c address
arm64: zynqmp: Fix tps544/u3007 node description

 arch/arm/dts/zynqmp-e-a2197-00-revA.dts | 6 +++---
 arch/arm/dts/zynqmp-g-a2197-00-revA.dts | 4 ++--
 arch/arm/dts/zynqmp-m-a2197-01-revA.dts | 4 ++--
 arch/arm/dts/zynqmp-m-a2197-02-revA.dts | 8 ++------
 arch/arm/dts/zynqmp-m-a2197-03-revA.dts | 8 ++++----
 5 files changed, 13 insertions(+), 17 deletions(-)
Quoted 3 lines

--
2.36.1

Applied.
M

Signature · 5 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs