Skip to contentSkip to conversation

Update Documentation/ cross references and fix issues

PATCH In review Mauro Carvalho Chehab 6 participants 29 messages Jul 9, 2022 – Aug 11, 2022

Subsystems (24)
lore
Share & tools
lore

Mauro Carvalho Chehab

author maintainer
#0 lore raw

v3 cover Update Documentation/ cross references and fix issues

This series fix almost all fixable issues when building the html docs at linux-next (next-20220608):

- Address some broken cross-references;
- Fix kernel-doc warnings;
- Fix bad tags on ReST files.

With this series applied, plus other pending patches that should hopefully be merged in time for the next merge window, htmldocs build will produce just 4 warnings with Sphinx 2.4.4.

Sphinx >=3 will produce some extra false-positive warnings due to conflicts between structs and functions sharing the same name. Hopefully this will be fixed either on a new Sphinx 5.x version or Sphinx 6.0.

Mauro Carvalho Chehab (21):
docs: networking: update netdevices.rst reference
docs: update vmalloced-kernel-stacks.rst reference
docs: update vmemmap_dedup.rst reference
docs: zh_CN: page_migration: fix reference to mm index.rst
dt-bindings: arm: update arm,coresight-cpu-debug.yaml reference x86/sgx: fix kernel-doc markups
fscache: fix kernel-doc documentation
fs: namei: address some kernel-doc issues drm/scheduler: fix a kernel-doc warning drm/scheduler: add a missing kernel-doc parameter
kfence: fix a kernel-doc parameter
genalloc: add a description for start_addr parameter
textsearch: document list inside struct ts_ops
dcache: fix a kernel-doc warning
docs: ext4: blockmap.rst: fix a broken table
docs: PCI: pci-vntb-function.rst: Properly include ascii artwork
docs: PCI: pci-vntb-howto.rst: fix a title markup
docs: virt: kvm: fix a title markup at api.rst
docs: ABI: sysfs-bus-nvdimm
docs: leds: index.rst: add leds-qcom-lpg to it
Documentation: coresight: fix binding wildcards

 Documentation/ABI/testing/sysfs-bus-nvdimm             |  2 ++
 Documentation/PCI/endpoint/pci-vntb-function.rst       |  2 +-
 Documentation/PCI/endpoint/pci-vntb-howto.rst          |  2 +-
 Documentation/filesystems/ext4/blockmap.rst            |  2 +-
 Documentation/leds/index.rst                           |  1 +
 Documentation/trace/coresight/coresight-cpu-debug.rst  |  2 +-
 Documentation/trace/coresight/coresight.rst            |  2 +-
 Documentation/translations/zh_CN/mm/page_migration.rst |  2 +-
 .../translations/zh_CN/mm/vmalloced-kernel-stacks.rst  |  2 +-
 Documentation/virt/kvm/api.rst                         |  6 +++---
 arch/x86/include/uapi/asm/sgx.h                        | 10 ++++++++--
 drivers/gpu/drm/scheduler/sched_main.c                 |  1 +
 drivers/net/can/can327.c                               |  2 +-
 fs/namei.c                                             |  3 +++
 include/drm/gpu_scheduler.h                            |  1 +
 include/linux/dcache.h                                 |  2 +-
 include/linux/fscache.h                                |  4 ++--
 include/linux/genalloc.h                               |  1 +
 include/linux/kfence.h                                 |  1 +
 include/linux/textsearch.h                             |  1 +
 mm/hugetlb_vmemmap.h                                   |  2 +-
 21 files changed, 34 insertions(+), 17 deletions(-)
Signature · 1 line
2.36.1
author maintainer
#1 lore raw

PATCH v3 1/21 docs: networking: update netdevices.rst reference

Changeset 482a4360c56a ("docs: networking: convert netdevices.txt to ReST")
renamed: Documentation/networking/netdevices.txt
to: Documentation/networking/netdevices.rst.

Update its cross-reference accordingly.

Fixes 482a4360c56a ("docs: networking: convert netdevices.txt to ReST")

---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/[email protected]/

 drivers/net/can/can327.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/can/can327.c +1 -1
index 5da7778d92dc..925e880bf570 100644
@@ -827,7 +827,7 @@ static netdev_tx_t can327_netdev_start_xmit(struct sk_buff *skb,
 	netif_stop_queue(dev);
 
 	/* BHs are already disabled, so no spin_lock_bh().
-	 * See Documentation/networking/netdevices.txt
+	 * See Documentation/networking/netdevices.rst
 	 */
 	spin_lock(&elm->lock);
 	can327_send_frame(elm, frame);
Signature · 1 line
2.36.1
author maintainer
#2 lore raw

PATCH v3 2/21 docs: update vmalloced-kernel-stacks.rst reference

In reply to Mauro Carvalho Chehab

Changeset ee65728e103b ("docs: rename Documentation/vm to Documentation/mm")
renamed: Documentation/vm/vmalloced-kernel-stacks.rst
to: Documentation/mm/vmalloced-kernel-stacks.rst.

Update its cross-reference accordingly.

Fixes ee65728e103b ("docs: rename Documentation/vm to Documentation/mm")

---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/[email protected]/

 Documentation/translations/zh_CN/mm/vmalloced-kernel-stacks.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/translations/zh_CN/mm/vmalloced-kernel-stacks.rst +1 -1
index ad23f274f6d7..d02a23f7f07e 100644
@@ -1,7 +1,7 @@
 .. SPDX-License-Identifier: GPL-2.0
 .. include:: ../disclaimer-zh_CN.rst
 
-:Original: Documentation/vm/vmalloced-kernel-stacks.rst
+:Original: Documentation/mm/vmalloced-kernel-stacks.rst
 
 :翻译:
 
Signature · 1 line
2.36.1
Acked-by on v3 2/21
#3 lore raw

Re: [PATCH v3 02/21] docs: update vmalloced-kernel-stacks.rst reference

Quoted 8 lines · Mauro Carvalho Chehab

Changeset ee65728e103b ("docs: rename Documentation/vm to Documentation/mm")
renamed: Documentation/vm/vmalloced-kernel-stacks.rst
to: Documentation/mm/vmalloced-kernel-stacks.rst.

Update its cross-reference accordingly.

Fixes ee65728e103b ("docs: rename Documentation/vm to Documentation/mm")

Thanks,
Wu

Quoted 23 lines

---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/[email protected]/

 Documentation/translations/zh_CN/mm/vmalloced-kernel-stacks.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/translations/zh_CN/mm/vmalloced-kernel-stacks.rst +1 -1
index ad23f274f6d7..d02a23f7f07e 100644
@@ -1,7 +1,7 @@
 .. SPDX-License-Identifier: GPL-2.0
 .. include:: ../disclaimer-zh_CN.rst
 
-:Original: Documentation/vm/vmalloced-kernel-stacks.rst
+:Original: Documentation/mm/vmalloced-kernel-stacks.rst
 
 :翻译:
 
Signature · 1 line
2.36.1
Acked-by on v3 2/21
#4 lore raw

Re: [PATCH v3 02/21] docs: update vmalloced-kernel-stacks.rst reference

In reply to Mauro Carvalho Chehab
Quoted 8 lines · Mauro Carvalho Chehab

Changeset ee65728e103b ("docs: rename Documentation/vm to Documentation/mm")
renamed: Documentation/vm/vmalloced-kernel-stacks.rst
to: Documentation/mm/vmalloced-kernel-stacks.rst.

Update its cross-reference accordingly.

Fixes ee65728e103b ("docs: rename Documentation/vm to Documentation/mm")

Thanks,

Yanteng

Quoted 21 lines

---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/[email protected]/

  Documentation/translations/zh_CN/mm/vmalloced-kernel-stacks.rst | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/translations/zh_CN/mm/vmalloced-kernel-stacks.rst +1 -1
index ad23f274f6d7..d02a23f7f07e 100644
@@ -1,7 +1,7 @@
  .. SPDX-License-Identifier: GPL-2.0
  .. include:: ../disclaimer-zh_CN.rst
 
-:Original: Documentation/vm/vmalloced-kernel-stacks.rst
+:Original: Documentation/mm/vmalloced-kernel-stacks.rst
 
  :翻译:
 
author maintainer
#5 lore raw

PATCH v3 3/21 docs: update vmemmap_dedup.rst reference

In reply to Mauro Carvalho Chehab

Changeset ee65728e103b ("docs: rename Documentation/vm to Documentation/mm")
renamed: Documentation/vm/vmemmap_dedup.rst
to: Documentation/mm/vmemmap_dedup.rst.

Update its cross-reference accordingly.

Fixes ee65728e103b ("docs: rename Documentation/vm to Documentation/mm")

---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/[email protected]/

 mm/hugetlb_vmemmap.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/hugetlb_vmemmap.h +1 -1
index 25bd0e002431..b8fc23c8763f 100644
@@ -16,7 +16,7 @@ void hugetlb_vmemmap_optimize(const struct hstate *h, struct page *head);
 
 /*
  * Reserve one vmemmap page, all vmemmap addresses are mapped to it. See
- * Documentation/vm/vmemmap_dedup.rst.
+ * Documentation/mm/vmemmap_dedup.rst.
  */
 #define HUGETLB_VMEMMAP_RESERVE_SIZE	PAGE_SIZE
 
Signature · 1 line
2.36.1
Reviewed-by on v3 3/21
#6 lore raw

Re: [PATCH v3 03/21] docs: update vmemmap_dedup.rst reference

Quoted 8 lines · Mauro Carvalho Chehab

Changeset ee65728e103b ("docs: rename Documentation/vm to Documentation/mm")
renamed: Documentation/vm/vmemmap_dedup.rst
to: Documentation/mm/vmemmap_dedup.rst.

Update its cross-reference accordingly.

Fixes ee65728e103b ("docs: rename Documentation/vm to Documentation/mm")

Thanks.

author maintainer
#7 lore raw

PATCH v3 4/21 docs: zh_CN: page_migration: fix reference to mm index.rst

In reply to Mauro Carvalho Chehab

This got renamed, so we need to also rename at page_migration.rst.

Fixes ee65728e103b ("docs: rename Documentation/vm to Documentation/mm")

---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/[email protected]/

 Documentation/translations/zh_CN/mm/page_migration.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/translations/zh_CN/mm/page_migration.rst +1 -1
index 566880a41ea0..ea9647d060fb 100644
@@ -1,6 +1,6 @@
 .. include:: ../disclaimer-zh_CN.rst
 
-:Original: Documentation/vm/index.rst
+:Original: Documentation/mm/index.rst
 
 :翻译:
 
Signature · 1 line
2.36.1
Acked-by on v3 4/21
#8 lore raw

Re: [PATCH v3 04/21] docs: zh_CN: page_migration: fix reference to mm index.rst

于 2022年7月9日 GMT+08:00 下午6:07:17, Mauro Carvalho Chehab <[email protected]> 写到:

Quoted 4 lines

This got renamed, so we need to also rename at page_migration.rst.

Fixes ee65728e103b ("docs: rename Documentation/vm to Documentation/mm")

Thanks,
Wu

Quoted 20 lines

---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/[email protected]/

Documentation/translations/zh_CN/mm/page_migration.rst | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/translations/zh_CN/mm/page_migration.rst +0 -0
index 566880a41ea0..ea9647d060fb 100644
@@ -1,6 +1,6 @@

.. include:: ../disclaimer-zh_CN.rst

-:Original: Documentation/vm/index.rst
+:Original: Documentation/mm/index.rst

:翻译:

#9 lore raw

Re: [PATCH v3 04/21] docs: zh_CN: page_migration: fix reference to mm index.rst

In reply to Mauro Carvalho Chehab
Quoted 17 lines · Mauro Carvalho Chehab

This got renamed, so we need to also rename at page_migration.rst.

Fixes ee65728e103b ("docs: rename Documentation/vm to Documentation/mm")

---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/[email protected]/

  Documentation/translations/zh_CN/mm/page_migration.rst | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/translations/zh_CN/mm/page_migration.rst +0 -0
index 566880a41ea0..ea9647d060fb 100644

Documentation/translations/zh_CN/mm/page_migration.rst line 3

Quoted 4 lines
Documentation/translations/zh_CN/mm/page_migration.rst +1 -1
@@ -1,6 +1,6 @@
  .. include:: ../disclaimer-zh_CN.rst
 
-:Original: Documentation/vm/index.rst
+:Original: Documentation/mm/index.rst

Oops! I wrote it wrong. Let's use:

Documentation/translations/zh_CN/mm/page_migration.rst +1 -1
index 566880a41ea0..076081dc1635 100644
@@ -1,6 +1,6 @@
 .. include:: ../disclaimer-zh_CN.rst
 
-:Original: Documentation/vm/index.rst
+:Original: Documentation/mm/page_migration.rst
 
 :翻译:
 

Thanks,
Yanteng

Quoted 3 lines
Documentation/translations/zh_CN/mm/page_migration.rst +0 -0
  :翻译:
 
author maintainer
#10 lore raw

PATCH v3 5/21 dt-bindings: arm: update arm,coresight-cpu-debug.yaml reference

In reply to Mauro Carvalho Chehab

Changeset 66d052047ca8 ("dt-bindings: arm: Convert CoreSight CPU debug to DT schema")
renamed: Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt
to: Documentation/devicetree/bindings/arm/arm,coresight-cpu-debug.yaml.

Update its cross-reference accordingly.

Fixes 66d052047ca8 ("dt-bindings: arm: Convert CoreSight CPU debug to DT schema")

---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/[email protected]/

 Documentation/trace/coresight/coresight-cpu-debug.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/trace/coresight/coresight-cpu-debug.rst +1 -1
index 993dd294b81b..79bbe587e5e8 100644
@@ -117,7 +117,7 @@ divide into below cases:
 Device Tree Bindings
 --------------------
 
-See Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt for details.
+See Documentation/devicetree/bindings/arm/arm,coresight-cpu-debug.yaml for details.
 
 
 How to use the module
Signature · 1 line
2.36.1
author maintainer
#11 lore raw

PATCH v3 6/21 x86/sgx: fix kernel-doc markups

In reply to Mauro Carvalho Chehab

There are a couple typos there, violating kernel-doc syntax.

Also, on a function typedef, the register snapshots aren't documented.

This should fix those warnings:

arch/x86/include/uapi/asm/sgx.h:19: warning: Enum value 'SGX_PAGE_MEASURE' not described in enum 'sgx_page_flags' arch/x86/include/uapi/asm/sgx.h:97: warning: Function parameter or member 'rdi' not described in 'sgx_enclave_user_handler_t' arch/x86/include/uapi/asm/sgx.h:97: warning: Function parameter or member 'rsi' not described in 'sgx_enclave_user_handler_t' arch/x86/include/uapi/asm/sgx.h:97: warning: Function parameter or member 'rdx' not described in 'sgx_enclave_user_handler_t' arch/x86/include/uapi/asm/sgx.h:97: warning: Function parameter or member 'rsp' not described in 'sgx_enclave_user_handler_t' arch/x86/include/uapi/asm/sgx.h:97: warning: Function parameter or member 'r8' not described in 'sgx_enclave_user_handler_t' arch/x86/include/uapi/asm/sgx.h:97: warning: Function parameter or member 'r9' not described in 'sgx_enclave_user_handler_t' arch/x86/include/uapi/asm/sgx.h:124: warning: Function parameter or member 'reserved' not described in 'sgx_enclave_run'

Fixes 3fa97bf00126 ("Documentation/x86: Document SGX kernel architecture")

---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/[email protected]/

 arch/x86/include/uapi/asm/sgx.h | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
arch/x86/include/uapi/asm/sgx.h +8 -2
index f4b81587e90b..6306bcaaf67a 100644
@@ -10,7 +10,7 @@
 
 /**
  * enum sgx_page_flags - page control flags
- * %SGX_PAGE_MEASURE:	Measure the page contents with a sequence of
+ * @SGX_PAGE_MEASURE:	Measure the page contents with a sequence of
  *			ENCLS[EEXTEND] operations.
  */
 enum sgx_page_flags {
@@ -81,6 +81,12 @@ struct sgx_enclave_run;
 /**
  * typedef sgx_enclave_user_handler_t - Exit handler function accepted by
  *					__vdso_sgx_enter_enclave()
+ * @rdi:	snapshot of RDI register at enclave exit
+ * @rsi:	snapshot of RSI register at enclave exit
+ * @rdx:	snapshot of RDX register at enclave exit
+ * @rsp:	snapshot of RSP register at enclave exit
+ * @r8:		snapshot of R8 register at enclave exit
+ * @r9:		snapshot of R9 register at enclave exit
  * @run:	The run instance given by the caller
  *
  * The register parameters contain the snapshot of their values at enclave
@@ -104,7 +110,7 @@ typedef int (*sgx_enclave_user_handler_t)(long rdi, long rsi, long rdx,
  * @exception_addr:		The address that triggered the exception
  * @user_handler:		User provided callback run on exception
  * @user_data:			Data passed to the user handler
- * @reserved			Reserved for future extensions
+ * @reserved:			Reserved for future extensions
  *
  * If @user_handler is provided, the handler will be invoked on all return paths
  * of the normal flow.  The user handler may transfer control, e.g. via a
Signature · 1 line
2.36.1
author maintainer
#12 lore raw

PATCH v3 7/21 fscache: fix kernel-doc documentation

In reply to Mauro Carvalho Chehab

The prototype of two functions use "cookie" for the object parameter.

Update kernel-doc tags accordingly, fixing those warnings:

include/linux/fscache.h:270: warning: Function parameter or member 'cookie' not described in 'fscache_use_cookie' include/linux/fscache.h:270: warning: Excess function parameter 'object' description in 'fscache_use_cookie' include/linux/fscache.h:287: warning: Function parameter or member 'cookie' not described in 'fscache_unuse_cookie' include/linux/fscache.h:287: warning: Excess function parameter 'object' description in 'fscache_unuse_cookie'

---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/[email protected]/

 include/linux/fscache.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/fscache.h +2 -2
index 2f82ea31d4c1..e13184c4b198 100644
@@ -257,7 +257,7 @@ struct fscache_cookie *fscache_acquire_cookie(struct fscache_volume *volume,
 
 /**
  * fscache_use_cookie - Request usage of cookie attached to an object
- * @object: Object description
+ * @cookie: Object description
  * @will_modify: If cache is expected to be modified locally
  *
  * Request usage of the cookie attached to an object.  The caller should tell
@@ -273,7 +273,7 @@ static inline void fscache_use_cookie(struct fscache_cookie *cookie,
 
 /**
  * fscache_unuse_cookie - Cease usage of cookie attached to an object
- * @object: Object description
+ * @cookie: Object description
  * @aux_data: Updated auxiliary data (or NULL)
  * @object_size: Revised size of the object (or NULL)
  *
Signature · 1 line
2.36.1
author maintainer
#13 lore raw

PATCH v3 8/21 fs: namei: address some kernel-doc issues

In reply to Mauro Carvalho Chehab

There are couple of symbols missing documentation:

fs/namei.c:649: warning: Function parameter or member 'mnt' not described in 'path_connected' fs/namei.c:649: warning: Function parameter or member 'dentry' not described in 'path_connected' fs/namei.c:1089: warning: Function parameter or member 'inode' not described in 'may_follow_link'

Document them.

---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/[email protected]/

 fs/namei.c | 3 +++
 1 file changed, 3 insertions(+)
fs/namei.c +3 -0
index 1f28d3f463c3..a8079d6250bc 100644
@@ -640,6 +640,8 @@ static bool nd_alloc_stack(struct nameidata *nd)
 
 /**
  * path_connected - Verify that a dentry is below mnt.mnt_root
+ * @mnt: pointer to vfs mount
+ * @dentry:  pointer to dentry to verify
  *
  * Rename can sometimes move a file or directory outside of a bind
  * mount, path_connected allows those cases to be detected.
@@ -1072,6 +1074,7 @@ fs_initcall(init_fs_namei_sysctls);
 /**
  * may_follow_link - Check symlink following for unsafe situations
  * @nd: nameidata pathwalk data
+ * @inode: inode to check
  *
  * In the case of the sysctl_protected_symlinks sysctl being enabled,
  * CAP_DAC_OVERRIDE needs to be specifically ignored if the symlink is
Signature · 1 line
2.36.1
author maintainer
#14 lore raw

PATCH v3 9/21 drm/scheduler: fix a kernel-doc warning

In reply to Mauro Carvalho Chehab

The dev field was not documented:

include/drm/gpu_scheduler.h:463: warning: Function parameter or member 'dev' not described in 'drm_gpu_scheduler'

Document it.

---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/[email protected]/

 include/drm/gpu_scheduler.h | 1 +
 1 file changed, 1 insertion(+)
include/drm/gpu_scheduler.h +1 -0
index addb135eeea6..c7c487e0c40e 100644
@@ -435,6 +435,7 @@ struct drm_sched_backend_ops {
  * @_score: score used when the driver doesn't provide one
  * @ready: marks if the underlying HW is ready to work
  * @free_guilty: A hit to time out handler to free the guilty job.
+ * @dev: pointer to struct device.
  *
  * One scheduler is implemented for each hardware ring.
  */
Signature · 1 line
2.36.1
Reviewed-by on v3 9/21
#15 lore raw

Re: [PATCH v3 09/21] drm/scheduler: fix a kernel-doc warning

Quoted 9 lines · Mauro Carvalho Chehab

The dev field was not documented:

include/drm/gpu_scheduler.h:463: warning: Function parameter or member 'dev' not described in 'drm_gpu_scheduler'

Document it.

Patches 9, 10 are:

Do you have commit rights to drm-misc or do you need me to push them?

Thanks,

Alex

Quoted 23 lines

---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/[email protected]/

 include/drm/gpu_scheduler.h | 1 +
 1 file changed, 1 insertion(+)
include/drm/gpu_scheduler.h +1 -1
index addb135eeea6..c7c487e0c40e 100644
@@ -435,6 +435,7 @@ struct drm_sched_backend_ops {
  * @_score: score used when the driver doesn't provide one
  * @ready: marks if the underlying HW is ready to work
  * @free_guilty: A hit to time out handler to free the guilty job.
+ * @dev: pointer to struct device.
  *
  * One scheduler is implemented for each hardware ring.
  */
--

2.36.1

author maintainer
#16 lore raw

PATCH v3 10/21 drm/scheduler: add a missing kernel-doc parameter

In reply to Mauro Carvalho Chehab

Add a description for struct device at drm_sched_init(), in order to solve this warning:

drivers/gpu/drm/scheduler/sched_main.c:999: warning: Function parameter or member 'dev' not described in 'drm_sched_init'

---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/[email protected]/

 drivers/gpu/drm/scheduler/sched_main.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/scheduler/sched_main.c +1 -0
index 68317d3a7a27..9d27cd280c89 100644
@@ -994,6 +994,7 @@ static int drm_sched_main(void *param)
  *		used
  * @score: optional score atomic shared with other schedulers
  * @name: name used for debugging
+ * @dev: pointer to struct device
  *
  * Return 0 on success, otherwise error code.
  */
Signature · 1 line
2.36.1
author maintainer
#17 lore raw

PATCH v3 11/21 kfence: fix a kernel-doc parameter

In reply to Mauro Carvalho Chehab

The kernel-doc markup is missing the slab pointer description:

include/linux/kfence.h:221: warning: Function parameter or member 'slab' not described in '__kfence_obj_info'

Document it.

---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/[email protected]/

 include/linux/kfence.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/kfence.h +1 -0
index 726857a4b680..9c242f4e9fab 100644
@@ -210,6 +210,7 @@ struct kmem_obj_info;
  * __kfence_obj_info() - fill kmem_obj_info struct
  * @kpp: kmem_obj_info to be filled
  * @object: the object
+ * @slab: pointer to slab
  *
  * Return:
  * * false - not a KFENCE object
Signature · 1 line
2.36.1
author maintainer
#18 lore raw

PATCH v3 12/21 genalloc: add a description for start_addr parameter

In reply to Mauro Carvalho Chehab

Copy the same description as found at lib/genalloc.c, fixing this warning:

include/linux/genalloc.h:54: warning: Function parameter or member 'start_addr' not described in 'genpool_algo_t'

---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/[email protected]/

 include/linux/genalloc.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/genalloc.h +1 -0
index 0bd581003cd5..2a67a54e5018 100644
@@ -44,6 +44,7 @@ struct gen_pool;
  * @nr: The number of zeroed bits we're looking for
  * @data: optional additional data used by the callback
  * @pool: the pool being allocated from
+ * @start_addr: virtual starting address of memory chunk to add to pool
  */
 typedef unsigned long (*genpool_algo_t)(unsigned long *map,
 			unsigned long size,
Signature · 1 line
2.36.1
author maintainer
#19 lore raw

PATCH v3 13/21 textsearch: document list inside struct ts_ops

In reply to Mauro Carvalho Chehab

The list field of struct ts_ops is not documented:

include/linux/textsearch.h:51: warning: Function parameter or member 'list' not described in 'ts_ops'

Add a documentation for it.

---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/[email protected]/

 include/linux/textsearch.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/textsearch.h +1 -0
index 6673e4d4ac2e..29de95657ff1 100644
@@ -35,6 +35,7 @@ struct ts_state
  * @get_pattern: return head of pattern
  * @get_pattern_len: return length of pattern
  * @owner: module reference to algorithm
+ * @list: pointer to ts_ops list
  */
 struct ts_ops
 {
Signature · 1 line
2.36.1
author maintainer
#20 lore raw

PATCH v3 14/21 dcache: fix a kernel-doc warning

In reply to Mauro Carvalho Chehab

The name of the function is wrong:
include/linux/dcache.h:309: warning: expecting prototype for dget, dget_dlock(). Prototype was for dget_dlock() instead

Fix it.

---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/[email protected]/

 include/linux/dcache.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/dcache.h +1 -1
index f5bba51480b2..ce0b36f728fa 100644
@@ -297,7 +297,7 @@ extern char *dentry_path(const struct dentry *, char *, int);
 /* Allocation counts.. */
 
 /**
- *	dget, dget_dlock -	get a reference to a dentry
+ *	dget_dlock -	get a reference to a dentry
  *	@dentry: dentry to get a reference to
  *
  *	Given a dentry or %NULL pointer increment the reference count
Signature · 1 line
2.36.1
author maintainer
#21 lore raw

PATCH v3 15/21 docs: ext4: blockmap.rst: fix a broken table

In reply to Mauro Carvalho Chehab

There's one missing space, causing a long error message when building the docs.

---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/[email protected]/

 Documentation/filesystems/ext4/blockmap.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/filesystems/ext4/blockmap.rst +1 -1
index 2bd990402a5c..cc596541ce79 100644
@@ -1,7 +1,7 @@
 .. SPDX-License-Identifier: GPL-2.0
 
 +---------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
-| i.i_block Offset   | Where It Points                                                                                                                                                                                                              |
+| i.i_block Offset    | Where It Points                                                                                                                                                                                                              |
 +=====================+==============================================================================================================================================================================================================================+
 | 0 to 11             | Direct map to file blocks 0 to 11.                                                                                                                                                                                           |
 +---------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
Signature · 1 line
2.36.1
author maintainer
#23 lore raw

PATCH v3 16/21 docs: PCI: pci-vntb-function.rst: Properly include ascii artwork

In reply to Mauro Carvalho Chehab

Adjust identation and add a "::" in order to properly mark the ascii artwork as a code block, fixing this warning:

Documentation/PCI/endpoint/pci-vntb-function.rst:82: WARNING: Unexpected indentation.

---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/[email protected]/

 Documentation/PCI/endpoint/pci-vntb-function.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/PCI/endpoint/pci-vntb-function.rst +1 -1
index cad8013e8839..7b2ac70e2c57 100644
@@ -58,7 +58,7 @@ It is same as PCI NTB Function driver
 Scratchpad Registers:
 ---------------------
 
-  It is appended after Config region.
+It is appended after Config region::
 
   +--------------------------------------------------+ Base
   |                                                  |
Signature · 1 line
2.36.1
author maintainer
#24 lore raw

PATCH v3 17/21 docs: PCI: pci-vntb-howto.rst: fix a title markup

In reply to Mauro Carvalho Chehab

As warned by Sphinx:
Documentation/PCI/endpoint/pci-vntb-howto.rst:131: WARNING: Title underline too short.

---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/[email protected]/

 Documentation/PCI/endpoint/pci-vntb-howto.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/PCI/endpoint/pci-vntb-howto.rst +1 -1
index b4a679144692..31a0bae868f9 100644
@@ -128,7 +128,7 @@ RootComplex Device
 ==================
 
 lspci Output at Host side
-------------------------
+-------------------------
 
 Note that the devices listed here correspond to the values populated in
 "Creating pci-epf-ntb Device" section above::
Signature · 1 line
2.36.1
author maintainer
#25 lore raw

PATCH v3 18/21 docs: virt: kvm: fix a title markup at api.rst

In reply to Mauro Carvalho Chehab

As warned by Sphinx:

Documentation/virt/kvm/api.rst:8210: WARNING: Title underline too short.

---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/[email protected]/

 Documentation/virt/kvm/api.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Documentation/virt/kvm/api.rst +3 -3
index 1a0f68d23999..3466f7124833 100644
@@ -8207,15 +8207,15 @@ dump related UV data. Also the vcpu ioctl `KVM_S390_PV_CPU_COMMAND` is
 available and supports the `KVM_PV_DUMP_CPU` subcommand.
 
 8.38 KVM_CAP_VM_DISABLE_NX_HUGE_PAGES
----------------------------
+-------------------------------------
 
 :Capability KVM_CAP_VM_DISABLE_NX_HUGE_PAGES
 :Architectures: x86
 :Type: vm
 :Parameters: arg[0] must be 0.
 :Returns 0 on success, -EPERM if the userspace process does not
-	 have CAP_SYS_BOOT, -EINVAL if args[0] is not 0 or any vCPUs have been
-	 created.
+have CAP_SYS_BOOT, -EINVAL if args[0] is not 0 or any vCPUs have been
+created.
 
 This capability disables the NX huge pages mitigation for iTLB MULTIHIT.
 
Signature · 1 line
2.36.1
author maintainer
#26 lore raw

PATCH v3 19/21 docs: ABI: sysfs-bus-nvdimm

In reply to Mauro Carvalho Chehab

Add blank lines, as this is required by code-block markup syntax.

Fix this warning:
Documentation/ABI/testing/sysfs-bus-nvdimm:11: WARNING: Unexpected indentation.

---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/[email protected]/

 Documentation/ABI/testing/sysfs-bus-nvdimm | 2 ++
 1 file changed, 2 insertions(+)
Documentation/ABI/testing/sysfs-bus-nvdimm +2 -0
index 1c1f5acbf53d..eeabba807e4b 100644
@@ -18,9 +18,11 @@ Description:	(RO) Attribute group to describe the magic bits
 		Each attribute under this group defines a bit range of the
 		perf_event_attr.config. Supported attribute is listed
 		below::
+
 		  event  = "config:0-4"  - event ID
 
 		For example::
+
 			ctl_res_cnt = "event=0x1"
 
 What:           /sys/bus/event_source/devices/nmemX/events
Signature · 1 line
2.36.1
author maintainer
#27 lore raw

PATCH v3 20/21 docs: leds: index.rst: add leds-qcom-lpg to it

In reply to Mauro Carvalho Chehab

This document was added without placing it at leds index.

Fixes 24e2d05d1b68 ("leds: Add driver for Qualcomm LPG")

---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/[email protected]/

 Documentation/leds/index.rst | 1 +
 1 file changed, 1 insertion(+)
Documentation/leds/index.rst +1 -0
index e5d63b940045..014e009b0761 100644
@@ -25,4 +25,5 @@ LEDs
    leds-lp5562
    leds-lp55xx
    leds-mlxcpld
+   leds-qcom-lpg
    leds-sc27xx
Signature · 1 line
2.36.1
author maintainer
#28 lore raw

PATCH v3 21/21 Documentation: coresight: fix binding wildcards

In reply to Mauro Carvalho Chehab

The changeset c06475910b52 ("Documentation: coresight: Escape coresight bindings file wildcard") fixed a Sphinx warning but introduced a new warning while building
the docs:
Documentation/trace/coresight/coresight.rst: Documentation/devicetree/bindings/arm/arm,coresight-

As it basically broke the cross-reference breakage detector that runs during the Kernel build. Address it the proper way by marking the references to such documents as a code block. This should make Sphinx automarkup.py extension happy while allowing the script to check if the doc reference is pointing to the right place.

Fixes c06475910b52 ("Documentation: coresight: Escape coresight bindings file wildcard")

---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/21] at: https://lore.kernel.org/all/[email protected]/

 Documentation/trace/coresight/coresight.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/trace/coresight/coresight.rst +1 -1
index 4a71ea6cb390..826e59a698da 100644
@@ -130,7 +130,7 @@ Misc:
 Device Tree Bindings
 --------------------
 
-See Documentation/devicetree/bindings/arm/arm,coresight-\*.yaml for details.
+See ``Documentation/devicetree/bindings/arm/arm,coresight-*.yaml`` for details.
 
 As of this writing drivers for ITM, STMs and CTIs are not provided but are
 expected to be added as the solution matures.
Signature · 1 line
2.36.1