staging: rtl8192e: rtl819x_HTProc: code cleanup patches on the rtl8192x_HTProc.c file.
v2 cover staging: rtl8192e: rtl819x_HTProc: code cleanup patches on the rtl8192x_HTProc.c file.
Multiple patches regarding the cleanup of code in the rtl819x_HTProc.c file according to the checkpatch script aside from the CamelCase issues.
Fixed patchset email format in v2.
Aaron Lawrence (3):
Staging: rtl8192e: rtl819x_HTProc: fixed missing blank space
Staging: rtl8192e: rtl819x_HTProc: fixed alignment matching open
parenthesis
Staging: rtl8192e: rtl819x_HTProc: fixed unnecessary parentheses
drivers/staging/rtl8192e/rtl819x_HTProc.c | 38 ++++++++++++----------- 1 file changed, 20 insertions(+), 18 deletions(-)
Signature · 1 line
2.38.1
PATCH v2 1/3 Staging: rtl8192e: rtl819x_HTProc: fixed missing blank space
Added a missing blank space as per the Linux kernel coding-style regulations. The issue was flagged by the checkpatch script as a warning.
--- drivers/staging/rtl8192e/rtl819x_HTProc.c | 1 + 1 file changed, 1 insertion(+)
drivers/staging/rtl8192e/rtl819x_HTProc.c +1 -0
@@ -70,6 +70,7 @@ static u8 LINKSYS_MARVELL_4400N[3] = {0x00, 0x14, 0xa4};void HTUpdateDefaultSetting (struct rtllib_device *ieee) {struct rt_hi_throughput *pHTInfo = ieee->pHTInfo; + pHTInfo->bRegShortGI20MHz =1 ; pHTInfo->bRegShortGI40MHz =1 ;
Signature · 1 line
2.38.1
PATCH v2 2/3 Staging: rtl8192e: rtl819x_HTProc: fixed alignment matching open parenthesis
In reply to Aaron LawrenceAligned multiple statements to match open parenthesis as per Linux kernel coding-style regulations. The issues were flagged by the checkpatch script.
--- drivers/staging/rtl8192e/rtl819x_HTProc.c | 25 ++++++++++++----------- 1 file changed, 13 insertions(+), 12 deletions(-)
drivers/staging/rtl8192e/rtl819x_HTProc.c +13 -12
@@ -152,8 +152,8 @@ bool IsHTHalfNmodeAPs(struct rtllib_device *ieee) (net->ralink_cap_exist)) retValue = true; else if (!memcmp(net->bssid, UNKNOWN_BORADCOM, 3) || - !memcmp(net->bssid, LINKSYSWRT330_LINKSYSWRT300_BROADCOM, 3) || - !memcmp(net->bssid, LINKSYSWRT350_LINKSYSWRT150_BROADCOM, 3) || + !memcmp(net->bssid, LINKSYSWRT330_LINKSYSWRT300_BROADCOM, 3) || + !memcmp(net->bssid, LINKSYSWRT350_LINKSYSWRT150_BROADCOM, 3) || (net->broadcom_cap_exist)) retValue = true; else if (net->bssht.bd_rt2rt_aggregation)
@@ -540,7 +540,7 @@ void HTOnAssocRsp(struct rtllib_device *ieee) pPeerHTCap, sizeof(struct ht_capab_ele));#endif HTSetConnectBwMode (ieee, (enum ht_channel_width )(pPeerHTCap->ChlWidth), - (enum ht_extchnl_offset )(pPeerHTInfo->ExtChlOffset)); + (enum ht_extchnl_offset )(pPeerHTInfo->ExtChlOffset)); pHTInfo->cur_tx_bw40mhz = ((pPeerHTInfo->RecommemdedTxWidth ==1 ) ? true : false);
@@ -566,9 +566,9 @@ void HTOnAssocRsp(struct rtllib_device *ieee) pHTInfo->bCurrentAMPDUEnable = pHTInfo->bAMPDUEnable;if (ieee->rtllib_ap_sec_type && - (ieee->rtllib_ap_sec_type (ieee) & (SEC_ALG_WEP |SEC_ALG_TKIP ))) { + (ieee->rtllib_ap_sec_type (ieee) & (SEC_ALG_WEP |SEC_ALG_TKIP ))) {if ((pHTInfo->IOTPeer ==HT_IOT_PEER_ATHEROS ) || - (pHTInfo->IOTPeer ==HT_IOT_PEER_UNKNOWN )) + (pHTInfo->IOTPeer ==HT_IOT_PEER_UNKNOWN )) pHTInfo->bCurrentAMPDUEnable = false; }
@@ -617,7 +617,8 @@ void HTOnAssocRsp(struct rtllib_device *ieee)else pMcsFilter =MCS_FILTER_ALL ; ieee->HTHighestOperaRate =HTGetHighestMCSRate (ieee, - ieee->dot11HTOperationalRateSet, pMcsFilter); + ieee->dot11HTOperationalRateSet, + pMcsFilter); ieee->HTCurrentOperaRate = ieee->HTHighestOperaRate; pHTInfo->current_op_mode = pPeerHTInfo->OptMode;
@@ -644,13 +645,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee) pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor;memset ((void *)(&(pHTInfo->SelfHTCap)),0 , -sizeof (pHTInfo->SelfHTCap)); +sizeof (pHTInfo->SelfHTCap));memset ((void *)(&(pHTInfo->SelfHTInfo)),0 , -sizeof (pHTInfo->SelfHTInfo)); +sizeof (pHTInfo->SelfHTInfo));memset ((void *)(&(pHTInfo->PeerHTCapBuf)),0 , -sizeof (pHTInfo->PeerHTCapBuf)); +sizeof (pHTInfo->PeerHTCapBuf));memset ((void *)(&(pHTInfo->PeerHTInfoBuf)),0 , -sizeof (pHTInfo->PeerHTInfoBuf)); +sizeof (pHTInfo->PeerHTInfoBuf)); pHTInfo->sw_bw_in_progress = false;
@@ -803,8 +804,8 @@ void HTUseDefaultSetting(struct rtllib_device *ieee)HTFilterMCSRate (ieee, ieee->Regdot11TxHTOperationalRateSet, ieee->dot11HTOperationalRateSet); ieee->HTHighestOperaRate =HTGetHighestMCSRate (ieee, - ieee->dot11HTOperationalRateSet, -MCS_FILTER_ALL ); + ieee->dot11HTOperationalRateSet, +MCS_FILTER_ALL ); ieee->HTCurrentOperaRate = ieee->HTHighestOperaRate; }else {
Signature · 1 line
2.38.1
PATCH v2 3/3 Staging: rtl8192e: rtl819x_HTProc: fixed unnecessary parentheses
In reply to Aaron LawrenceFixed multiple unnecessary parentheses as per the Linux kernel coding-style regulations. The issues were flagged by the checkpatch script.
--- drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/staging/rtl8192e/rtl819x_HTProc.c +6 -6
@@ -285,7 +285,7 @@ void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,u8 EWC11NHTCap[] = {0x00 ,0x90 ,0x4c ,0x33 };memcpy (posHTCap, EWC11NHTCap,sizeof (EWC11NHTCap)); - pCapELE = (struct ht_capab_ele *)&(posHTCap[4 ]); + pCapELE = (struct ht_capab_ele *)&posHTCap[4 ]; *len =30 +2 ; }else { pCapELE = (struct ht_capab_ele *)posHTCap;
@@ -644,13 +644,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee) pHTInfo->current_mpdu_density = pHTInfo->MPDU_Density; pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor; -memset ((void *)(&(pHTInfo->SelfHTCap)),0 , +memset ((void *)(&pHTInfo->SelfHTCap),0 ,sizeof (pHTInfo->SelfHTCap)); -memset ((void *)(&(pHTInfo->SelfHTInfo)),0 , +memset ((void *)(&pHTInfo->SelfHTInfo),0 ,sizeof (pHTInfo->SelfHTInfo)); -memset ((void *)(&(pHTInfo->PeerHTCapBuf)),0 , +memset ((void *)(&pHTInfo->PeerHTCapBuf),0 ,sizeof (pHTInfo->PeerHTCapBuf)); -memset ((void *)(&(pHTInfo->PeerHTInfoBuf)),0 , +memset ((void *)(&pHTInfo->PeerHTInfoBuf),0 ,sizeof (pHTInfo->PeerHTInfoBuf)); pHTInfo->sw_bw_in_progress = false;
@@ -666,7 +666,7 @@ void HTInitializeHTInfo(struct rtllib_device *ieee) pHTInfo->iot_ra_func =0 ; { -u8 *RegHTSuppRateSets = &(ieee->RegHTSuppRateSet[0 ]); +u8 *RegHTSuppRateSets = &ieee->RegHTSuppRateSet[0 ]; RegHTSuppRateSets[0 ] =0xFF ; RegHTSuppRateSets[1 ] =0xFF ;
Signature · 1 line
2.38.1
Quoted 5 lines · Aaron Lawrence
Multiple patches regarding the cleanup of code in the
rtl819x_HTProc.cfile according to the checkpatch script aside from the CamelCase issues.Fixed patchset email format in v2.
Quoted 9 lines
Aaron Lawrence (3):
Staging: rtl8192e:rtl819x_HTProc: fixed missing blank space
Staging: rtl8192e:rtl819x_HTProc: fixed alignment matching open
parenthesis
Staging: rtl8192e:rtl819x_HTProc: fixed unnecessary parenthesesdrivers/staging/rtl8192e/rtl819x_HTProc.c | 38 ++++++++++++----------- 1 file changed, 20 insertions(+), 18 deletions(-)