drm/amd/pm/powerplay: use bitwise or for bitmasks addition
Subsystems (3)
cover drm/amd/pm/powerplay: use bitwise or for bitmasks addition
The patch series proposes usage of bitwise or "|" operator for addition of bitmasks instead of using numerial additions. The former is quicker and cleaner.
The proposed change is compile tested.
Deepak R Varma (3):
drm/amd/pm/powerplay/smumgr: use bitwise or for addition drm/amd/pm/powerplay/hwmgr: use bitwise or for bitmasks addition drm/amd/pm/powerplay/smumgr/ci: use bitwise or for bitmasks addition
drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c | 8 ++++---- drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c | 2 +- drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c | 2 +- drivers/gpu/drm/amd/pm/powerplay/smumgr/tonga_smumgr.c | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-)
Signature · 1 line
2.34.1
PATCH 1/3 drm/amd/pm/powerplay/smumgr: use bitwise or for addition
For bit mask addition, it is recommended to use or operator "|" instead of numerical addition as the former is quicker and cleaner. Change suggested by orplus.cocci Coccinelle semantic patch.
--- drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c | 2 +- drivers/gpu/drm/amd/pm/powerplay/smumgr/tonga_smumgr.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c +1 -1
@@ -2165,7 +2165,7 @@ static int iceland_program_mem_timing_parameters(struct pp_hwmgr *hwmgr)struct smu7_hwmgr *data = (struct smu7_hwmgr *)(hwmgr->backend);if (data->need_update_smu7_dpm_table & - (DPMTABLE_OD_UPDATE_SCLK +DPMTABLE_OD_UPDATE_MCLK )) + (DPMTABLE_OD_UPDATE_SCLK |DPMTABLE_OD_UPDATE_MCLK ))return iceland_program_memory_timing_parameters (hwmgr);return 0 ;
drivers/gpu/drm/amd/pm/powerplay/smumgr/tonga_smumgr.c +1 -1
@@ -2554,7 +2554,7 @@ static int tonga_program_mem_timing_parameters(struct pp_hwmgr *hwmgr)struct smu7_hwmgr *data = (struct smu7_hwmgr *)(hwmgr->backend);if (data->need_update_smu7_dpm_table & - (DPMTABLE_OD_UPDATE_SCLK +DPMTABLE_OD_UPDATE_MCLK )) + (DPMTABLE_OD_UPDATE_SCLK |DPMTABLE_OD_UPDATE_MCLK ))return tonga_program_memory_timing_parameters (hwmgr);return 0 ;
Signature · 1 line
2.34.1
PATCH 2/3 drm/amd/pm/powerplay/hwmgr: use bitwise or for bitmasks addition
In reply to Deepak R VarmaFor bit mask addition, it is recommended to use or operator "|" instead of numerical addition as the former is quicker and cleaner. Change suggested by orplus.cocci Coccinelle semantic patch.
--- drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c +4 -4
@@ -4153,7 +4153,7 @@ static int smu7_freeze_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)if ((0 == data->sclk_dpm_key_disabled) && (data->need_update_smu7_dpm_table & - (DPMTABLE_OD_UPDATE_SCLK +DPMTABLE_UPDATE_SCLK ))) { + (DPMTABLE_OD_UPDATE_SCLK |DPMTABLE_UPDATE_SCLK ))) {PP_ASSERT_WITH_CODE (true ==smum_is_dpm_running (hwmgr), "Trying to freeze SCLK DPM when DPM is disabled", );
@@ -4210,7 +4210,7 @@ static int smu7_populate_and_upload_sclk_mclk_dpm_levels( }if (data->need_update_smu7_dpm_table & - (DPMTABLE_OD_UPDATE_SCLK +DPMTABLE_UPDATE_SCLK )) { + (DPMTABLE_OD_UPDATE_SCLK |DPMTABLE_UPDATE_SCLK )) { result =smum_populate_all_graphic_levels (hwmgr); PP_ASSERT_WITH_CODE((0 == result), "Failed to populate SCLK during PopulateNewDPMClocksStates Function!",
@@ -4218,7 +4218,7 @@ static int smu7_populate_and_upload_sclk_mclk_dpm_levels( }if (data->need_update_smu7_dpm_table & - (DPMTABLE_OD_UPDATE_MCLK +DPMTABLE_UPDATE_MCLK )) { + (DPMTABLE_OD_UPDATE_MCLK |DPMTABLE_UPDATE_MCLK )) {/*populate MCLK dpm table to SMU7 */ result =smum_populate_all_memory_levels (hwmgr); PP_ASSERT_WITH_CODE((0 == result),
@@ -4309,7 +4309,7 @@ static int smu7_unfreeze_sclk_mclk_dpm(struct pp_hwmgr *hwmgr)if ((0 == data->sclk_dpm_key_disabled) && (data->need_update_smu7_dpm_table & - (DPMTABLE_OD_UPDATE_SCLK +DPMTABLE_UPDATE_SCLK ))) { + (DPMTABLE_OD_UPDATE_SCLK |DPMTABLE_UPDATE_SCLK ))) { PP_ASSERT_WITH_CODE(true == smum_is_dpm_running(hwmgr), "Trying to Unfreeze SCLK DPM when DPM is disabled",
Signature · 1 line
2.34.1
PATCH 3/3 drm/amd/pm/powerplay/smumgr/ci: use bitwise or for bitmasks addition
In reply to Deepak R VarmaFor bit mask addition, it is recommended to use or operator "|" instead of numerical addition as the former is quicker and cleaner. Change suggested by orplus.cocci Coccinelle semantic patch.
--- drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c +1 -1
@@ -2203,7 +2203,7 @@ static int ci_program_mem_timing_parameters(struct pp_hwmgr *hwmgr)struct smu7_hwmgr *data = (struct smu7_hwmgr *)(hwmgr->backend);if (data->need_update_smu7_dpm_table & - (DPMTABLE_OD_UPDATE_SCLK +DPMTABLE_OD_UPDATE_MCLK )) + (DPMTABLE_OD_UPDATE_SCLK |DPMTABLE_OD_UPDATE_MCLK ))return ci_program_memory_timing_parameters (hwmgr);return 0 ;
Signature · 1 line
2.34.1
[AMD Official Use Only - General]
Series is reviewed-by: Evan Quan <[email protected]>
Quoted 36 lines
-----Original Message-----
From: Deepak R Varma <[email protected]>
Sent: Sunday, January 15, 2023 3:16 PM
To: Quan, Evan <[email protected]>; Deucher, Alexander <[email protected]>; Koenig, Christian <[email protected]>; Pan, Xinhui <[email protected]>; David Airlie <[email protected]>; Daniel Vetter <[email protected]>; amd- [email protected]; [email protected]; linux- [email protected]
Cc: Saurabh Singh Sengar <[email protected]>; Praveen Kumar <[email protected]>
Subject: [PATCH 0/3] drm/amd/pm/powerplay: use bitwise or for bitmasks additionThe patch series proposes usage of bitwise or "|" operator for addition of bitmasks instead of using numerial additions. The former is quicker and cleaner.
The proposed change is compile tested.
Deepak R Varma (3):
drm/amd/pm/powerplay/smumgr: use bitwise or for addition drm/amd/pm/powerplay/hwmgr: use bitwise or for bitmasks addition drm/amd/pm/powerplay/smumgr/ci: use bitwise or for bitmasks additiondrivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c | 8 ++++--- - drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c | 2 +- drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c | 2 +- drivers/gpu/drm/amd/pm/powerplay/smumgr/tonga_smumgr.c | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-)--
2.34.1
Alex Deucher
AppliedApplied. Thanks!
Alex
Quoted 41 lines · Evan
[AMD Official Use Only - General]
Series is reviewed-by: Evan Quan <[email protected]>
Quoted 36 lines
-----Original Message-----
From: Deepak R Varma <[email protected]>
Sent: Sunday, January 15, 2023 3:16 PM
To: Quan, Evan <[email protected]>; Deucher, Alexander <[email protected]>; Koenig, Christian <[email protected]>; Pan, Xinhui <[email protected]>; David Airlie <[email protected]>; Daniel Vetter <[email protected]>; amd- [email protected]; [email protected]; linux- [email protected]
Cc: Saurabh Singh Sengar <[email protected]>; Praveen Kumar <[email protected]>
Subject: [PATCH 0/3] drm/amd/pm/powerplay: use bitwise or for bitmasks additionThe patch series proposes usage of bitwise or "|" operator for addition of bitmasks instead of using numerial additions. The former is quicker and cleaner.
The proposed change is compile tested.
Deepak R Varma (3):
drm/amd/pm/powerplay/smumgr: use bitwise or for addition drm/amd/pm/powerplay/hwmgr: use bitwise or for bitmasks addition drm/amd/pm/powerplay/smumgr/ci: use bitwise or for bitmasks additiondrivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c | 8 ++++--- - drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c | 2 +- drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c | 2 +- drivers/gpu/drm/amd/pm/powerplay/smumgr/tonga_smumgr.c | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-)--
2.34.1