mtd: spi-nor: spansion: Add support for Infineon S25FS256T
Subsystems (2)
v3 cover mtd: spi-nor: spansion: Add support for Infineon S25FS256T
From: Takahiro Kuwano <[email protected]>
Infineon S25FS256T is 256Mbit Quad SPI NOR flash. This series updates RD_ANY_REG_OP macro to support dummy cycles and then adds ID and fixups for S25FS256T.
---
zynq> cat /sys/bus/spi/devices/spi0.0/spi-nor/partname s25fs256t
zynq> cat /sys/bus/spi/devices/spi0.0/spi-nor/jedec_id 342b190f0890
zynq> cat /sys/bus/spi/devices/spi0.0/spi-nor/manufacturer spansion
zynq> xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp 53464450080101ff00000114000100ff84000102500100ffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff ffffffffffffffffffffffffffffffffe7ffe2ffffffff0f48eb086bffff ffffeeffffffffff00ffffff00ff11d810d800ff00ff321cfeff71e9ffe1 ec031c607a757a75f766805c00d65dfff938c0a100000000000000000000 0000ffffffff710600fedcdcffff
zynq> md5sum /sys/bus/spi/devices/spi0.0/spi-nor/sfdp 13ecce2f195c4c71648e90d4a7e4a0df /sys/bus/spi/devices/spi0.0/spi-nor/sfdp zynq> test_qspi.sh
random: crng init done
6+0 records in
6+0 records out
6291456 bytes (6.0MB) copied, 3.200008 seconds, 1.9MB/s
Copied 6291456 bytes from qspi_test to address 0x00000000 in flash Erased 6291456 bytes from address 0x00000000 in flash
Copied 6291456 bytes from address 0x00000000 in flash to qspi_read 0000000 ffff ffff ffff ffff ffff ffff ffff ffff
*
0600000
Copied 6291456 bytes from qspi_test to address 0x00000000 in flash Copied 6291456 bytes from address 0x00000000 in flash to qspi_read 3b47256fecc997f606d7e75e6a9b567a8e8037c1 qspi_test 3b47256fecc997f606d7e75e6a9b567a8e8037c1 qspi_read
---
Takahiro Kuwano (2):
mtd: spi-nor: spansion: Make RD_ANY_REG_OP macro take number of dummy
bytes
mtd: spi-nor: spansion: Add support for Infineon S25FS256T
drivers/mtd/spi-nor/spansion.c | 70 +++++++++++++++++++++++++++++++--- 1 file changed, 65 insertions(+), 5 deletions(-)
Signature · 6 lines
2.25.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
PATCH v3 1/2 mtd: spi-nor: spansion: Make RD_ANY_REG_OP macro take number of dummy bytes
From: Takahiro Kuwano <[email protected]>
Currently Read Any Register op is used to read volatile registers without any dummy cycles, but the op requires dummy cycles depending on register type (volatiler or non-volatile), device family, and device configuration. Add 'ndummy' argument to RD_ANY_REG_OP macro to support other use cases.
--- drivers/mtd/spi-nor/spansion.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/mtd/spi-nor/spansion.c +5 -5
@@ -37,10 +37,10 @@ SPI_MEM_OP_NO_DUMMY, \ SPI_MEM_OP_DATA_OUT(ndata, buf, 0)) -#define CYPRESS_NOR_RD_ANY_REG_OP (naddr, addr, buf) \ +#define CYPRESS_NOR_RD_ANY_REG_OP (naddr, addr, ndummy, buf) \ SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_RD_ANY_REG, 0), \ SPI_MEM_OP_ADDR(naddr, addr, 0), \ - SPI_MEM_OP_NO_DUMMY, \ + SPI_MEM_OP_DUMMY(ndummy, 0), \ SPI_MEM_OP_DATA_IN(1, buf, 0))#define SPANSION_CLSR_OP \
@@ -148,7 +148,7 @@ static int cypress_nor_quad_enable_volatile(struct spi_nor *nor) op = (struct spi_mem_op )CYPRESS_NOR_RD_ANY_REG_OP (addr_mode_nbytes, -SPINOR_REG_CYPRESS_CFR1V , +SPINOR_REG_CYPRESS_CFR1V ,0 , nor->bouncebuf); ret =spi_nor_read_any_reg (nor, &op, nor->reg_proto);
@@ -173,7 +173,7 @@ static int cypress_nor_quad_enable_volatile(struct spi_nor *nor)/* Read back and check it. */ op = (struct spi_mem_op )CYPRESS_NOR_RD_ANY_REG_OP (addr_mode_nbytes, -SPINOR_REG_CYPRESS_CFR1V , +SPINOR_REG_CYPRESS_CFR1V ,0 , nor->bouncebuf); ret =spi_nor_read_any_reg (nor, &op, nor->reg_proto);if (ret)
@@ -202,7 +202,7 @@ static int cypress_nor_set_page_size(struct spi_nor *nor) {struct spi_mem_op op =CYPRESS_NOR_RD_ANY_REG_OP (nor->params->addr_mode_nbytes, -SPINOR_REG_CYPRESS_CFR3V , +SPINOR_REG_CYPRESS_CFR3V ,0 , nor->bouncebuf);int ret;
Signature · 6 lines
2.25.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
PATCH v3 2/2 mtd: spi-nor: spansion: Add support for Infineon S25FS256T
In reply to [email protected]From: Takahiro Kuwano <[email protected]>
Infineon S25FS256T is 256Mbit Quad SPI NOR flash. The key features and differences comparing to other Spansion/Cypress flash familes are:
- 4-byte address mode by factory default
- Quad mode is enabled by factory default
- OP_READ_FAST_4B(0Ch) is not supported
- Supports mixture of 128KB and 64KB sectors by OTP configuration (this patch supports uniform 128KB only due to complexity of non-uniform layout)
Tested on Xilinx Zynq-7000 FPGA board.
---
Changes in v3:
- add params->addr_nbytes = 4 in post_bfpt
- give 'ndummy' to RD_ANY_REG_OP in post_bfpt
- s/SFDP/4BAIT in post_sfdp
Changes in v2:
- s/EOPNOTSUPP/ENODEV
- Drop READ_FAST support
- Amend comment in late_init()
- sector size and page size as 0 in sizeINFO6()
--- drivers/mtd/spi-nor/spansion.c | 60 ++++++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+)
drivers/mtd/spi-nor/spansion.c +60 -0
@@ -29,6 +29,7 @@ SPINOR_REG_CYPRESS_CFR5_OPI)#define SPINOR_REG_CYPRESS_CFR5_OCT_DTR_DS SPINOR_REG_CYPRESS_CFR5_BIT6#define SPINOR_OP_CYPRESS_RD_FAST 0xee +#define SPINOR_REG_CYPRESS_ARCFN 0x00000006/* Cypress SPI NOR flash operations. */ #define CYPRESS_NOR_WR_ANY_REG_OP (naddr, addr, ndata, buf) \
@@ -218,6 +219,62 @@ static int cypress_nor_set_page_size(struct spi_nor *nor)return 0 ; } +static int +s25fs256t_post_bfpt_fixup (struct spi_nor *nor, +const struct sfdp_parameter_header *bfpt_header, +const struct sfdp_bfpt *bfpt) +{ +struct spi_mem_op op; +int ret; + +/* 4-byte address mode is enabled by default */ + nor->params->addr_nbytes =4 ; + nor->params->addr_mode_nbytes =4 ; + +/* Read Architecture Configuration Register (ARCFN) */ + op = (struct spi_mem_op ) +CYPRESS_NOR_RD_ANY_REG_OP (nor->params->addr_mode_nbytes, +SPINOR_REG_CYPRESS_ARCFN ,1 , + nor->bouncebuf); + ret =spi_nor_read_any_reg (nor, &op, nor->reg_proto); +if (ret) +return ret; + +/* ARCFN value must be 0 if uniform sector is selected */ +if (nor->bouncebuf[0 ]) +return -ENODEV ; + +return cypress_nor_set_page_size (nor); +} + +static void s25fs256t_post_sfdp_fixup (struct spi_nor *nor) +{ +struct spi_nor_flash_parameter *params = nor->params; + +/* PP_1_1_4_4B is supported but missing in 4BAIT. */ + params->hwcaps.mask |=SNOR_HWCAPS_PP_1_1_4 ; +spi_nor_set_pp_settings (¶ms->page_programs[SNOR_CMD_PP_1_1_4 ], +SPINOR_OP_PP_1_1_4_4B , +SNOR_PROTO_1_1_4 ); +} + +static void s25fs256t_late_init (struct spi_nor *nor) +{ +/* +* Programming is supported only in 16-byte ECC data unit granularity. +* Byte-programming, bit-walking, or multiple program operations to the +* same ECC data unit without an erase are not allowed. See chapter +* 5.3.1 and 5.6 in the datasheet. +*/ + nor->params->writesize =16 ; +} + +static struct spi_nor_fixups s25fs256t_fixups = { + .post_bfpt = s25fs256t_post_bfpt_fixup, + .post_sfdp = s25fs256t_post_sfdp_fixup, + .late_init = s25fs256t_late_init, +}; + static int s25hx_t_post_bfpt_fixup(struct spi_nor *nor, const struct sfdp_parameter_header *bfpt_header,
@@ -446,6 +503,9 @@ static const struct flash_info spansion_nor_parts[] = { { "s25fl256l", INFO(0x016019, 0, 64 * 1024, 512) NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) FIXUP_FLAGS(SPI_NOR_4B_OPCODES) }, + { "s25fs256t", INFO6(0x342b19, 0x0f0890, 0, 0) +PARSE_SFDP + .fixups = &s25fs256t_fixups }, { "s25hl512t", INFO6(0x342a1a, 0x0f0390, 256 * 1024, 256)PARSE_SFDP MFR_FLAGS (USE_CLSR )
Signature · 6 lines
2.25.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
The series is looking good, I'll queue it once -rc1 is out.
Cheers,
ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Tudor Ambarus
AppliedQuoted 4 lines · On Thu, 02 Mar 2023 16:35:05 +0900, [email protected] wrote:
Infineon S25FS256T is 256Mbit Quad SPI NOR flash. This series updates
RD_ANY_REG_OPmacro to support dummy cycles and then adds ID and fixups for S25FS256T.
Applied to git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git, spi-nor/next.
Thanks!
[1/2] mtd: spi-nor: spansion: Make RD_ANY_REG_OP macro take number of dummy bytes
https://git.kernel.org/mtd/c/d628783c46d3 [2/2] mtd: spi-nor: spansion: Add support for Infineon S25FS256T https://git.kernel.org/mtd/c/6afcc84080c4
Signature · 5 lines
Tudor Ambarus <[email protected]> ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/