Patch review
cover Patch review
Please review these patches for dunfell and have comments back by end of day Thursday.
Passed a-full on autobuilder:
https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/5073
The following changes since commit efb1a73a13907bed3acac8e06053aef3e2ef57f5:
build-appliance-image: Update to dunfell head revision (2023-03-15 23:09:39 +0000)
are available in the Git repository at:
https://git.openembedded.org/openembedded-core-contrib stable/dunfell-nut
http://cgit.openembedded.org/openembedded-core-contrib/log/?h=stable/dunfell-nut
Alban Bedel (1):
systemd: Fix systemd when used with busybox less
Andrej Valek (1):
libarchive: fix CVE-2022-26280
Chee Yang Lee (2):
ghostscript: add CVE tag for
check-stack-limits-after-function-evalution.patch
libksba: fix CVE-2022-3515
Hitendra Prajapati (1):
QEMU: CVE-2022-4144 QXL: qxl_phys2virt unsafe address translation can
lead to out-of-bounds read
Kenfe-Mickael Laventure (3):
buildtools-tarball: Handle spaces within user $PATH
toolchain-scripts: Handle spaces within user $PATH
populate_sdk_ext: Handle spaces within user $PATH
Richard Purdie (4):
staging: Separate out different multiconfig manifests staging/multilib: Fix manifest corruption
glibc: Add missing binutils dependency
base-files: Drop localhost.localdomain from hosts file
Ross Burton (2):
vim: upgrade to 9.0.1403
vim: set modified-by to the recipe MAINTAINER
meta/classes/multilib.bbclass | 1 + meta/classes/populate_sdk_ext.bbclass | 2 +- meta/classes/staging.bbclass | 4 + meta/classes/toolchain-scripts.bbclass | 2 +- meta/recipes-core/base-files/base-files/hosts | 2 +- meta/recipes-core/glibc/glibc.inc | 4 +- meta/recipes-core/meta/buildtools-tarball.bb | 2 +- .../systemd/systemd/systemd-pager.sh | 7 ++ meta/recipes-core/systemd/systemd_244.5.bb | 5 + meta/recipes-devtools/qemu/qemu.inc | 9 +- .../qemu/qemu/CVE-2022-4144.patch | 103 ++++++++++++++++++ ...tack-limits-after-function-evalution.patch | 2 +- .../libarchive/CVE-2022-26280.patch | 29 +++++ .../libarchive/libarchive_3.4.2.bb | 1 + .../libksba/libksba/CVE-2022-3515.patch | 47 ++++++++ meta/recipes-support/libksba/libksba_1.3.5.bb | 1 + meta/recipes-support/vim/vim.inc | 8 +- 17 files changed, 215 insertions(+), 14 deletions(-) create mode 100644 meta/recipes-core/systemd/systemd/systemd-pager.sh create mode 100644 meta/recipes-devtools/qemu/qemu/CVE-2022-4144.patch create mode 100644 meta/recipes-extended/libarchive/libarchive/CVE-2022-26280.patch create mode 100644 meta/recipes-support/libksba/libksba/CVE-2022-3515.patch
Signature · 1 line
2.34.1
PATCH 1/14 libarchive: fix CVE-2022-26280
From: Andrej Valek <[email protected]>
Backport fix from https://github.com/libarchive/libarchive/issues/1672
--- .../libarchive/CVE-2022-26280.patch | 29 +++++++++++++++++++ .../libarchive/libarchive_3.4.2.bb | 1 + 2 files changed, 30 insertions(+) create mode 100644 meta/recipes-extended/libarchive/libarchive/CVE-2022-26280.patch
meta/recipes-extended/libarchive/libarchive/CVE-2022-26280.patch new file +29 -0
@@ -0,0 +1,29 @@ +From cfaa28168a07ea4a53276b63068f94fce37d6aff Mon Sep 17 00:00:00 2001 +From: Tim Kientzle <[email protected]> +Date: Thu, 24 Mar 2022 10:35:00 +0100 +Subject: [PATCH] ZIP reader: fix possible out-of-bounds read in + zipx_lzma_alone_init() + +Fixes #1672 + +CVE: CVE-2022-26280 +Upstream-Status: Backport [https://github.com/libarchive/libarchive/commit/cfaa28168a07ea4a53276b63068f94fce37d6aff] +Signed-off-by: Andrej Valek <[email protected]> + +--- + libarchive/archive_read_support_format_zip.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/libarchive/archive_read_support_format_zip.c b/libarchive/archive_read_support_format_zip.c +index 38ada70b5..9d6c900b2 100644 +--- a/libarchive/archive_read_support_format_zip.c ++++ b/libarchive/archive_read_support_format_zip.c +@@ -1667,7 +1667,7 @@ zipx_lzma_alone_init(struct archive_read *a, struct zip *zip) + */ + + /* Read magic1,magic2,lzma_params from the ZIPX stream. */ +- if((p = __archive_read_ahead(a, 9, NULL)) == NULL) { ++ if(zip->entry_bytes_remaining < 9 || (p = __archive_read_ahead(a, 9, NULL)) == NULL) { + archive_set_error(&a->archive, ARCHIVE_ERRNO_FILE_FORMAT, + "Truncated lzma data"); + return (ARCHIVE_FATAL);
meta/recipes-extended/libarchive/libarchive_3.4.2.bb +1 -0
@@ -39,6 +39,7 @@ SRC_URI = "http://libarchive.org/downloads/libarchive-${PV}.tar.gz \ file://CVE-2021-23177.patch \ file://CVE-2021-31566-01.patch \ file://CVE-2021-31566-02.patch \ + file://CVE-2022-26280.patch \ file://CVE-2022-36227.patch \ "
Signature · 1 line
2.34.1
PATCH 2/14 QEMU: CVE-2022-4144 QXL: qxl_phys2virt unsafe address translation can lead to out-of-bounds read
In reply to Steve SakomanFrom: Hitendra Prajapati <[email protected]>
Upstream-Status: Backport from https://gitlab.com/qemu-project/qemu/-/commit/6dbbf055148c6f1b7d8a3251a65bd6f3d1e1f622
Replace the tabs with spaces to correct the indent.
--- meta/recipes-devtools/qemu/qemu.inc | 9 +- .../qemu/qemu/CVE-2022-4144.patch | 103 ++++++++++++++++++ 2 files changed, 108 insertions(+), 4 deletions(-) create mode 100644 meta/recipes-devtools/qemu/qemu/CVE-2022-4144.patch
meta/recipes-devtools/qemu/qemu.inc +5 -4
@@ -112,10 +112,11 @@ SRC_URI = "https://download.qemu.org/${BPN}-${PV}.tar.xz \ file://CVE-2022-0216-1.patch \ file://CVE-2022-0216-2.patch \ file://CVE-2021-3750.patch \ - file://CVE-2021-3638.patch \ - file://CVE-2021-20196.patch \ - file://CVE-2021-3507.patch \ - file://CVE-2021-3929.patch \ + file://CVE-2021-3638.patch \ + file://CVE-2021-20196.patch \ + file://CVE-2021-3507.patch \ + file://CVE-2021-3929.patch \ + file://CVE-2022-4144.patch \ " UPSTREAM_CHECK_REGEX = "qemu-(?P<pver>\d+(\.\d+)+)\.tar"
meta/recipes-devtools/qemu/qemu/CVE-2022-4144.patch new file +103 -0
103 lines not on this page · raw message
Signature · 1 line
2.34.1
PATCH 3/14 ghostscript: add CVE tag for check-stack-limits-after-function-evalution.patch
In reply to Steve SakomanFrom: Chee Yang Lee <[email protected]>
This patch fix CVE-2021-45944.
https://nvd.nist.gov/vuln/detail/CVE-2021-45944
--- .../check-stack-limits-after-function-evalution.patch | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-extended/ghostscript/ghostscript/check-stack-limits-after-function-evalution.patch +1 -1
@@ -14,7 +14,7 @@ stack than are available. To cope, add in stack limit checking to throw an appropriate error when this happens. - +CVE: CVE-2021-45944 Upstream-Status: Backported [https://git.ghostscript.com/?p=ghostpdl.git;a=patch;h=7861fcad13c497728189feafb41cd57b5b50ea25] Signed-off-by: Minjae Kim <[email protected]> ---
Signature · 1 line
2.34.1
PATCH 4/14 libksba: fix CVE-2022-3515
In reply to Steve SakomanFrom: Chee Yang Lee <[email protected]>
--- .../libksba/libksba/CVE-2022-3515.patch | 47 +++++++++++++++++++ meta/recipes-support/libksba/libksba_1.3.5.bb | 1 + 2 files changed, 48 insertions(+) create mode 100644 meta/recipes-support/libksba/libksba/CVE-2022-3515.patch
meta/recipes-support/libksba/libksba/CVE-2022-3515.patch new file +47 -0
@@ -0,0 +1,47 @@ +From 4b7d9cd4a018898d7714ce06f3faf2626c14582b Mon Sep 17 00:00:00 2001 +From: Werner Koch <[email protected]> +Date: Wed, 5 Oct 2022 14:19:06 +0200 +Subject: [PATCH] Detect a possible overflow directly in the TLV parser. + +* src/ber-help.c (_ksba_ber_read_tl): Check for overflow of a commonly +used sum. +-- + +It is quite common to have checks like + + if (ti.nhdr + ti.length >= DIM(tmpbuf)) + return gpg_error (GPG_ERR_TOO_LARGE); + +This patch detects possible integer overflows immmediately when +creating the TI object. + +Reported-by: ZDI-CAN-18927, ZDI-CAN-18928, ZDI-CAN-18929 + + +Upstream-Status: Backport [https://git.gnupg.org/cgi-bin/gitweb.cgi?p=libksba.git;a=patch;h=4b7d9cd4a018898d7714ce06f3faf2626c14582b] +CVE: CVE-2022-3515 +Signed-off-by: Chee Yang Lee <[email protected]> +--- + src/ber-help.c | 6 ++++++ + 1 file changed, 6 insertions(+) + +diff --git a/src/ber-help.c b/src/ber-help.c +index 81c31ed..56efb6a 100644 +--- a/src/ber-help.c ++++ b/src/ber-help.c +@@ -182,6 +182,12 @@ _ksba_ber_read_tl (ksba_reader_t reader, struct tag_info *ti) + ti->length = len; + } + ++ if (ti->length > ti->nhdr && (ti->nhdr + ti->length) < ti->length) ++ { ++ ti->err_string = "header+length would overflow"; ++ return gpg_error (GPG_ERR_EOVERFLOW); ++ } ++ + /* Without this kludge some example certs can't be parsed */ + if (ti->class == CLASS_UNIVERSAL && !ti->tag) + ti->length = 0; +-- +2.11.0 +
meta/recipes-support/libksba/libksba_1.3.5.bb +1 -0
@@ -24,6 +24,7 @@ UPSTREAM_CHECK_URI = "https://gnupg.org/download/index.html" SRC_URI = "${GNUPG_MIRROR}/${BPN}/${BPN}-${PV}.tar.bz2 \ file://ksba-add-pkgconfig-support.patch \ file://CVE-2022-47629.patch \ + file://CVE-2022-3515.patch \ " SRC_URI[md5sum] = "8302a3e263a7c630aa7dea7d341f07a2"
Signature · 1 line
2.34.1
PATCH 5/14 vim: upgrade to 9.0.1403
In reply to Steve SakomanFrom: Ross Burton <[email protected]>
This incorporates fixes for CVE-2023-1127, CVE-2023-1170, CVE-2023-1175.
Also remove runtime/doc/uganda.txt from the license checksum: the Vim license is also in the top-level LICENSE file so this is redundant.
--- meta/recipes-support/vim/vim.inc | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
meta/recipes-support/vim/vim.inc +3 -4
@@ -10,8 +10,7 @@ DEPENDS = "ncurses gettext-native" RSUGGESTS_${PN} = "diffutils" LICENSE = "vim" -LIC_FILES_CHKSUM = "file://LICENSE;md5=6b30ea4fa660c483b619924bc709ef99 \ - file://runtime/doc/uganda.txt;md5=001ef779f422a0e9106d428c84495b4d" +LIC_FILES_CHKSUM = "file://LICENSE;md5=6b30ea4fa660c483b619924bc709ef99" SRC_URI = "git://github.com/vim/vim.git;branch=master;protocol=https \ file://disable_acl_header_check.patch \
@@ -20,8 +19,8 @@ SRC_URI = "git://github.com/vim/vim.git;branch=master;protocol=https \ file://no-path-adjust.patch \ " -PV .= ".1293" -SRCREV = "0caaf1e46511f7a92e036f05e6aa9d5992540117" +PV .= ".1403" +SRCREV = "e764d1b4219e6615a04df1c3a6a5c0210a0a7dac" # Remove when 8.3 is out UPSTREAM_VERSION_UNKNOWN = "1"
Signature · 1 line
2.34.1
PATCH 6/14 vim: set modified-by to the recipe MAINTAINER
In reply to Steve SakomanFrom: Ross Burton <[email protected]>
Clause II.3 of the Vim license states that any distribution of Vim that has been extended or modified must _at least_ indicate in the :version output that this is the case.
Handily, Vim has a --with-modified-by argument to add a line in that text, so use MAINTAINER. This is the distribution maintainer contact, by default it is OE-Core Developers <[email protected]>.
--- meta/recipes-support/vim/vim.inc | 1 + 1 file changed, 1 insertion(+)
meta/recipes-support/vim/vim.inc +1 -0
@@ -80,6 +80,7 @@ EXTRA_OECONF = " \ --disable-netbeans \ --disable-desktop-database-update \ --with-tlib=ncurses \ + --with-modified-by='${MAINTAINER}' \ ac_cv_small_wchar_t=no \ ac_cv_path_GLIB_COMPILE_RESOURCES=no \ vim_cv_getcwd_broken=no \
Signature · 1 line
2.34.1
PATCH 7/14 systemd: Fix systemd when used with busybox less
In reply to Steve SakomanFrom: Alban Bedel <[email protected]>
Per default systemd use a pager for the output of most of its tools and it expect this pager to be color capable. But that is not the case when the busybox less is used, which lead to output garbled by color escape sequences.
To fix this issue add a profile frament that disable the systemd pager when busybox less is detected.
--- meta/recipes-core/systemd/systemd/systemd-pager.sh | 7 +++++++ meta/recipes-core/systemd/systemd_244.5.bb | 5 +++++ 2 files changed, 12 insertions(+) create mode 100644 meta/recipes-core/systemd/systemd/systemd-pager.sh
meta/recipes-core/systemd/systemd/systemd-pager.sh new file +7 -0
@@ -0,0 +1,7 @@ +# Systemd expect a color capable pager, however the less provided +# by busybox is not. This make many interaction with systemd pretty +# annoying. As a workaround we disable the systemd pager if less +# is not the GNU version. +if ! less -V > /dev/null 2>&1 ; then + export SYSTEMD_PAGER= +fi
meta/recipes-core/systemd/systemd_244.5.bb +5 -0
@@ -18,6 +18,7 @@ SRC_URI += "file://touchscreen.rules \ file://00-create-volatile.conf \ file://init \ file://99-default.preset \ + file://systemd-pager.sh \ file://0001-binfmt-Don-t-install-dependency-links-at-install-tim.patch \ file://0003-implment-systemd-sysv-install-for-OE.patch \ file://CVE-2021-33910.patch \
@@ -317,6 +318,9 @@ do_install() { # install default policy for presets # https://www.freedesktop.org/wiki/Software/systemd/Preset/#howto install -Dm 0644 ${WORKDIR}/99-default.preset ${D}${systemd_unitdir}/system-preset/99-default.preset + + # add a profile fragment to disable systemd pager with busybox less + install -Dm 0644 ${WORKDIR}/systemd-pager.sh ${D}${sysconfdir}/profile.d/systemd-pager.sh } python populate_packages_prepend (){
@@ -539,6 +543,7 @@ FILES_${PN} = " ${base_bindir}/* \ ${sysconfdir}/dbus-1/ \ ${sysconfdir}/modules-load.d/ \ ${sysconfdir}/pam.d/ \ + ${sysconfdir}/profile.d/ \ ${sysconfdir}/sysctl.d/ \ ${sysconfdir}/systemd/ \ ${sysconfdir}/tmpfiles.d/ \
Signature · 1 line
2.34.1
PATCH 8/14 staging: Separate out different multiconfig manifests
In reply to Steve SakomanFrom: Richard Purdie <[email protected]>
"""
require conf/multilib.conf
MACHINE = "qemuarm64"
MULTILIBS = "multilib:lib32" DEFAULTTUNE:virtclass-multilib-lib32 = "armv7athf-neon"
bitbake gcc-cross-canadian-arm
"""
and then inspecting the lib32* manifest files under recipe-sysroot-native shows them referencing lib32-recipe-sysroot instead of recipe-sysroot as used by gcc-cross-canadian recipes.
To fix this separate out the manifest by multilib. It is caching mechanism to optimise disk usage so this doesn't break anything, just separated out some files.
--- meta/classes/staging.bbclass | 3 +++ 1 file changed, 3 insertions(+)
meta/classes/staging.bbclass +3 -0
@@ -267,6 +267,9 @@ python extend_recipe_sysroot() { pn = d.getVar("PN") stagingdir = d.getVar("STAGING_DIR") sharedmanifests = d.getVar("COMPONENTS_DIR") + "/manifests" + mlprefix = d.getVar("MLPREFIX") + if mlprefix: + sharedmanifests = sharedmanifests + "/" + mlprefix recipesysroot = d.getVar("RECIPE_SYSROOT") recipesysrootnative = d.getVar("RECIPE_SYSROOT_NATIVE")
Signature · 1 line
2.34.1
PATCH 9/14 staging/multilib: Fix manifest corruption
In reply to Steve SakomanFrom: Richard Purdie <[email protected]>
The previous fix wasn't enough to address all the possible ways the manifests might be ordered. Rework the previous fix so it is tied to the multilib cross-canadian code which is causing the problem.
RECIPE_SYSROOT_MANIFEST_SUBDIR is not documented as I'd hope nobody ever needs to use this outside the core multilib code.
--- meta/classes/multilib.bbclass | 1 + meta/classes/staging.bbclass | 7 ++++--- 2 files changed, 5 insertions(+), 3 deletions(-)
meta/classes/multilib.bbclass +1 -0
@@ -45,6 +45,7 @@ python multilib_virtclass_handler () { e.data.setVar("RECIPE_SYSROOT", "${WORKDIR}/recipe-sysroot") e.data.setVar("STAGING_DIR_TARGET", "${WORKDIR}/recipe-sysroot") e.data.setVar("STAGING_DIR_HOST", "${WORKDIR}/recipe-sysroot") + e.data.setVar("RECIPE_SYSROOT_MANIFEST_SUBDIR", "nativesdk-" + variant) e.data.setVar("MLPREFIX", variant + "-") override = ":virtclass-multilib-" + variant e.data.setVar("OVERRIDES", e.data.getVar("OVERRIDES", False) + override)
meta/classes/staging.bbclass +4 -3
@@ -267,9 +267,10 @@ python extend_recipe_sysroot() { pn = d.getVar("PN") stagingdir = d.getVar("STAGING_DIR") sharedmanifests = d.getVar("COMPONENTS_DIR") + "/manifests" - mlprefix = d.getVar("MLPREFIX") - if mlprefix: - sharedmanifests = sharedmanifests + "/" + mlprefix + # only needed by multilib cross-canadian since it redefines RECIPE_SYSROOT + manifestprefix = d.getVar("RECIPE_SYSROOT_MANIFEST_SUBDIR") + if manifestprefix: + sharedmanifests = sharedmanifests + "/" + manifestprefix recipesysroot = d.getVar("RECIPE_SYSROOT") recipesysrootnative = d.getVar("RECIPE_SYSROOT_NATIVE")
Signature · 1 line
2.34.1
PATCH 10/14 glibc: Add missing binutils dependency
In reply to Steve SakomanFrom: Richard Purdie <[email protected]>
glibc has it's dependencies handled more manually due to it's place in the toolchain bootstrap. It depends upon the compiler and indirectly through that to binutils. This did mean that if binutils changes and the compiler does not, sstate and hash equivalence could mean that glibc wouldn't rebuild.
Add a direct dependency on binutils that if it changes, it forces glibc to rebuild, as it should.
--- meta/recipes-core/glibc/glibc.inc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
meta/recipes-core/glibc/glibc.inc +3 -1
@@ -1,7 +1,9 @@ require glibc-common.inc require glibc-ld.inc -DEPENDS = "virtual/${TARGET_PREFIX}gcc libgcc-initial linux-libc-headers" +DEPENDS = "virtual/${TARGET_PREFIX}gcc virtual/${TARGET_PREFIX}binutils${BUSUFFIX} libgcc-initial linux-libc-headers" +BUSUFFIX= "" +BUSUFFIX:class-nativesdk = "-crosssdk" PROVIDES = "virtual/libc" PROVIDES += "virtual/libintl virtual/libiconv"
Signature · 1 line
2.34.1
PATCH 11/14 buildtools-tarball: Handle spaces within user $PATH
In reply to Steve SakomanFrom: Kenfe-Mickael Laventure <[email protected]>
The environment-setup script generated by the recipe was not quoting the user existing PATH when updating it causing the export command to fail.
Add necessary double quotes around $PATH.
--- meta/recipes-core/meta/buildtools-tarball.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/meta/buildtools-tarball.bb +1 -1
@@ -66,7 +66,7 @@ create_sdk_files_append () { # Generate new (mini) sdk-environment-setup file script=${1:-${SDK_OUTPUT}/${SDKPATH}/environment-setup-${SDK_SYS}} touch $script - echo 'export PATH=${SDKPATHNATIVE}${bindir_nativesdk}:${SDKPATHNATIVE}${sbindir_nativesdk}:${SDKPATHNATIVE}${base_bindir_nativesdk}:${SDKPATHNATIVE}${base_sbindir_nativesdk}:$PATH' >> $script + echo 'export PATH="${SDKPATHNATIVE}${bindir_nativesdk}:${SDKPATHNATIVE}${sbindir_nativesdk}:${SDKPATHNATIVE}${base_bindir_nativesdk}:${SDKPATHNATIVE}${base_sbindir_nativesdk}:$PATH"' >> $script echo 'export OECORE_NATIVE_SYSROOT="${SDKPATHNATIVE}"' >> $script echo 'export GIT_SSL_CAINFO="${SDKPATHNATIVE}${sysconfdir}/ssl/certs/ca-certificates.crt"' >>$script echo 'export SSL_CERT_FILE="${SDKPATHNATIVE}${sysconfdir}/ssl/certs/ca-certificates.crt"' >>$script
Signature · 1 line
2.34.1
PATCH 12/14 toolchain-scripts: Handle spaces within user $PATH
In reply to Steve SakomanFrom: Kenfe-Mickael Laventure <[email protected]>
The environment-setup script generated by the recipe was not quoting the user existing PATH when updating it causing the export command to fail.
Add necessary double quotes around $PATH.
--- meta/classes/toolchain-scripts.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/toolchain-scripts.bbclass +1 -1
@@ -44,7 +44,7 @@ toolchain_create_sdk_env_script () { for i in ${CANADIANEXTRAOS}; do EXTRAPATH="$EXTRAPATH:$sdkpathnative$bindir/${TARGET_ARCH}${TARGET_VENDOR}-$i" done - echo "export PATH=$sdkpathnative$bindir:$sdkpathnative$sbindir:$sdkpathnative$base_bindir:$sdkpathnative$base_sbindir:$sdkpathnative$bindir/../${HOST_SYS}/bin:$sdkpathnative$bindir/${TARGET_SYS}"$EXTRAPATH':$PATH' >> $script + echo "export PATH=$sdkpathnative$bindir:$sdkpathnative$sbindir:$sdkpathnative$base_bindir:$sdkpathnative$base_sbindir:$sdkpathnative$bindir/../${HOST_SYS}/bin:$sdkpathnative$bindir/${TARGET_SYS}"$EXTRAPATH':"$PATH"' >> $script echo 'export PKG_CONFIG_SYSROOT_DIR=$SDKTARGETSYSROOT' >> $script echo 'export PKG_CONFIG_PATH=$SDKTARGETSYSROOT'"$libdir"'/pkgconfig:$SDKTARGETSYSROOT'"$prefix"'/share/pkgconfig' >> $script echo 'export CONFIG_SITE=${SDKPATH}/site-config-'"${multimach_target_sys}" >> $script
Signature · 1 line
2.34.1
PATCH 13/14 populate_sdk_ext: Handle spaces within user $PATH
In reply to Steve SakomanFrom: Kenfe-Mickael Laventure <[email protected]>
The script generated by the sdk_ext_postinst function was not quoting the user existing PATH when updating it causing the export command to fail.
Add necessary double quotes around $PATH.
--- meta/classes/populate_sdk_ext.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/populate_sdk_ext.bbclass +1 -1
@@ -669,7 +669,7 @@ sdk_ext_postinst() { # A bit of another hack, but we need this in the path only for devtool # so put it at the end of $PATH. - echo "export PATH=$target_sdk_dir/sysroots/${SDK_SYS}${bindir_nativesdk}:\$PATH" >> $env_setup_script + echo "export PATH=\"$target_sdk_dir/sysroots/${SDK_SYS}${bindir_nativesdk}:\$PATH\"" >> $env_setup_script echo "printf 'SDK environment now set up; additionally you may now run devtool to perform development tasks.\nRun devtool --help for further details.\n'" >> $env_setup_script
Signature · 1 line
2.34.1
PATCH 14/14 base-files: Drop localhost.localdomain from hosts file
In reply to Steve SakomanFrom: Richard Purdie <[email protected]>
This was likely something we took inspiration from elsewhere with. It was added in:
in 2005. Debian added this entry around 2004 and discussed and dropped it in 2005:
https://lists.debian.org/debian-devel/2005/10/msg00559.html
resulting in:
https://salsa.debian.org/installer-team/netcfg/-/commit/3c15ee521b2b8f47b34ccc7f610523cd284f2221
We should drop this for some of the reasons in those threads, it doesn't seem to be doing anything too helpful and isn't what most applications expect.
--- meta/recipes-core/base-files/base-files/hosts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/base-files/base-files/hosts +1 -1
@@ -1,4 +1,4 @@ -127.0.0.1 localhost.localdomain localhost +127.0.0.1 localhost # The following lines are desirable for IPv6 capable hosts ::1 localhost ip6-localhost ip6-loopback
Signature · 1 line
2.34.1