Skip to contentSkip to conversation

drm/panel: simple: Add support for Ampire AM-800480L1TMQW-T00H

PATCH Applied Geert Uytterhoeven 3 participants 6 messages May 24, 2023 – May 26, 2023

Subsystems (4)
Device tree bindings DRM drivers DRM misc DRM panel drivers
lore
Share & tools
lore

Geert Uytterhoeven

author
#0 lore raw

cover drm/panel: simple: Add support for Ampire AM-800480L1TMQW-T00H

Hi all,

This patch series adds support for the Ampire AM-800480L1TMQW-T00H 5" WVGA TFT LCD panel, which can be found on e.g. the Atmark Techno Armadillo-800-EVA development board.

It has been tested with a WIP DT-enhanced version of the shmob-drm driver.

Thanks for your comments!

Geert Uytterhoeven (2):
dt-bindings: display: panel-simple: Add Ampire AM-800480L1TMQW-T00H drm/panel: simple: Add Ampire AM-800480L1TMQW-T00H

 .../bindings/display/panel/panel-simple.yaml  |  2 ++
 drivers/gpu/drm/panel/panel-simple.c          | 33 +++++++++++++++++++
 2 files changed, 35 insertions(+)
Signature · 12 lines
2.34.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
author
#1 lore raw

PATCH 1/2 dt-bindings: display: panel-simple: Add Ampire AM-800480L1TMQW-T00H

Document support for the Ampire AM-800480L1TMQW-T00H 5" WVGA TFT LCD panel.

Signed-off-by Geert Uytterhoeven <[email protected]>
---
 .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/display/panel/panel-simple.yaml +2 -0
index 733e47da36e80896..f7c45e38d4b75b2e 100644
@@ -33,6 +33,8 @@ properties:
       - ampire,am-1280800n3tzqw-t00h
         # Ampire AM-480272H3TMQW-T01H 4.3" WQVGA TFT LCD panel
       - ampire,am-480272h3tmqw-t01h
+        # Ampire AM-800480L1TMQW-T00H 5" WVGA TFT LCD panel
+      - ampire,am-800480l1tmqw-t00h
         # Ampire AM-800480R3TMQW-A1H 7.0" WVGA TFT LCD panel
       - ampire,am800480r3tmqwa1h
         # Ampire AM-800600P5TMQW-TB8H 8.0" SVGA TFT LCD panel
Signature · 1 line
2.34.1
author
#3 lore raw

PATCH 2/2 drm/panel: simple: Add Ampire AM-800480L1TMQW-T00H

In reply to Geert Uytterhoeven

Add support for the Ampire AM-800480L1TMQW-T00H 5" WVGA TFT LCD panel.

Signed-off-by Geert Uytterhoeven <[email protected]>
---
 drivers/gpu/drm/panel/panel-simple.c | 33 ++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +33 -0
index 5778824dffd47a31..467117c0b2c9d463 100644
@@ -778,6 +778,36 @@ static const struct drm_display_mode ampire_am800480r3tmqwa1h_mode = {
 	.flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
 };
 
+static const struct display_timing ampire_am_800480l1tmqw_t00h_timing = {
+	.pixelclock = { 29930000, 33260000, 36590000 },
+	.hactive = { 800, 800, 800 },
+	.hfront_porch = { 1, 40, 168 },
+	.hback_porch = { 88, 88, 88 },
+	.hsync_len = { 1, 128, 128 },
+	.vactive = { 480, 480, 480 },
+	.vfront_porch = { 1, 35, 37 },
+	.vback_porch = { 8, 8, 8 },
+	.vsync_len = { 1, 2, 2 },
+	.flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW |
+		 DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE |
+		 DISPLAY_FLAGS_SYNC_POSEDGE,
+};
+
+static const struct panel_desc ampire_am_800480l1tmqw_t00h = {
+	.timings = &ampire_am_800480l1tmqw_t00h_timing,
+	.num_timings = 1,
+	.bpc = 8,
+	.size = {
+		.width = 111,
+		.height = 67,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH |
+		     DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE |
+		     DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE,
+	.connector_type = DRM_MODE_CONNECTOR_DPI,
+};
+
 static const struct panel_desc ampire_am800480r3tmqwa1h = {
 	.modes = &ampire_am800480r3tmqwa1h_mode,
 	.num_modes = 1,

@@ -3993,6 +4023,9 @@ static const struct of_device_id platform_of_match[] = {
 	}, {
 		.compatible = "ampire,am-480272h3tmqw-t01h",
 		.data = &ampire_am_480272h3tmqw_t01h,
+	}, {
+		.compatible = "ampire,am-800480l1tmqw-t00h",
+		.data = &ampire_am_800480l1tmqw_t00h,
 	}, {
 		.compatible = "ampire,am800480r3tmqwa1h",
 		.data = &ampire_am800480r3tmqwa1h,
Signature · 1 line
2.34.1
maintainer Reviewed-by on v1 2/2
#4 lore raw

Re: [PATCH 2/2] drm/panel: simple: Add Ampire AM-800480L1TMQW-T00H

Quoted 49 lines · Geert Uytterhoeven

Add support for the Ampire AM-800480L1TMQW-T00H 5" WVGA TFT LCD panel.

Signed-off-by Geert Uytterhoeven <[email protected]>
---
  drivers/gpu/drm/panel/panel-simple.c | 33 ++++++++++++++++++++++++++++
  1 file changed, 33 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +30 -0
index 5778824dffd47a31..467117c0b2c9d463 100644
@@ -778,6 +778,36 @@ static const struct drm_display_mode ampire_am800480r3tmqwa1h_mode = {
  	.flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
  };
 
+static const struct display_timing ampire_am_800480l1tmqw_t00h_timing = {
+	.pixelclock = { 29930000, 33260000, 36590000 },
+	.hactive = { 800, 800, 800 },
+	.hfront_porch = { 1, 40, 168 },
+	.hback_porch = { 88, 88, 88 },
+	.hsync_len = { 1, 128, 128 },
+	.vactive = { 480, 480, 480 },
+	.vfront_porch = { 1, 35, 37 },
+	.vback_porch = { 8, 8, 8 },
+	.vsync_len = { 1, 2, 2 },
+	.flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW |
+		 DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE |
+		 DISPLAY_FLAGS_SYNC_POSEDGE,
+};
+
+static const struct panel_desc ampire_am_800480l1tmqw_t00h = {
+	.timings = &ampire_am_800480l1tmqw_t00h_timing,
+	.num_timings = 1,
+	.bpc = 8,
+	.size = {
+		.width = 111,
+		.height = 67,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH |
+		     DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE |
+		     DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE,
+	.connector_type = DRM_MODE_CONNECTOR_DPI,
+};
+
  static const struct panel_desc ampire_am800480r3tmqwa1h = {
  	.modes = &ampire_am800480r3tmqwa1h_mode,
  	.num_modes = 1,

drivers/gpu/drm/panel/panel-simple.c static const struct of_device_id platform_of_match[] = { · line 4031

Quoted 9 lines
drivers/gpu/drm/panel/panel-simple.c +3 -0
@@ -3993,6 +4023,9 @@ static const struct of_device_id platform_of_match[] = {
  	}, {
  		.compatible = "ampire,am-480272h3tmqw-t01h",
  		.data = &ampire_am_480272h3tmqw_t01h,
+	}, {
+		.compatible = "ampire,am-800480l1tmqw-t00h",
+		.data = &ampire_am_800480l1tmqw_t00h,
  	}, {
  		.compatible = "ampire,am800480r3tmqwa1h",
  		.data = &ampire_am800480r3tmqwa1h,
Reviewed-by Neil Armstrong <[email protected]>
maintainer Applied
#5 lore raw
In reply to Geert Uytterhoeven

Hi,

Quoted 10 lines · Geert Uytterhoeven

Hi all,

This patch series adds support for the Ampire AM-800480L1TMQW-T00H 5" WVGA TFT LCD panel, which can be found on e.g. the Atmark Techno Armadillo-800-EVA development board.

It has been tested with a WIP DT-enhanced version of the shmob-drm driver.

[...]

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)

[1/2] dt-bindings: display: panel-simple: Add Ampire AM-800480L1TMQW-T00H

      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=d3a6c2b60f07c64631b9437032d8f079341b7a16
[2/2] drm/panel: simple: Add Ampire AM-800480L1TMQW-T00H
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=410bb21319f69c2ec28aeafe530d00ed2f6a1c54
Signature · 1 line
Neil