fix fwnode_irq_get[_byname()] returnvalue
Subsystems (16)
v7 cover fix fwnode_irq_get[_byname()] returnvalue
The fwnode_irq_get() and the fwnode_irq_get_byname() may have returned zero if mapping the IRQ fails. This contradicts the fwnode_irq_get_byname() documentation. Furthermore, returning zero or errno on error is unepected and can easily lead to problems like:
int probe(foo)
{
...
ret = fwnode_irq_get_byname(...); if (ret < 0) return ret;
...
}
or
int probe(foo)
{
...
ret = fwnode_irq_get_byname(...); if (ret <= 0) return ret;
...
}
which are both likely to be wrong. First treats zero as successful call and misses the IRQ mapping failure. Second returns zero from probe even though it detects the IRQ mapping failure correvtly.
Here we change the fwnode_irq_get() and the fwnode_irq_get_byname() to always return a negative errno upon failure.
I have audited following callers (v6.4-rc2):
fwnode_irq_get_byname():drivers/i2c/i2c-smbus.cdrivers/iio/accel/adxl355_core.cdrivers/iio/accel/kionix-kx022a.cdrivers/iio/adc/ad4130.cdrivers/iio/adc/max11410.cdrivers/iio/addac/ad74115.cdrivers/iio/gyro/fxas21002c_core.cdrivers/iio/imu/adis16480.cdrivers/iio/imu/bmi160/bmi160_core.cdrivers/iio/imu/bmi160/bmi160_core.c
fwnode_irq_get():drivers/gpio/gpio-dwapb.cdrivers/iio/chemical/scd30_serial.cdrivers/iio/proximity/mb1232.cdrivers/net/ethernet/marvell/mvpp2/mvpp2_main.cdrivers/net/mdio/fwnode_mdio.cdrivers/pinctrl/pinctrl-ingenic.cdrivers/pinctrl/pinctrl-microchip-sgpio.cdrivers/pinctrl/pinctrl-pistachio.c
and it seems to me these calls will be Ok after the change. The i2c-smbus.c and kionix-kx022a.c will gain a functional change (bugfix?) as after this patch the probe will return -EINVAL should the IRQ mapping fail. The series will also adjust the return value check for zero to be omitted.
NOTES:
Changes are compile-tested only.
drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
will also gain a functional change. The pinctrl-wpcm450.c change is easy to see - after this series the device-tree mapping failures will be handled as any other errors - probe will be aborted with -EINVAL. Other feasible option could be treating other errors in IRQ getting same way as the DT mapping failures - just silently skip the IRQ. Please see comment in the respective patch.
drivers/iio/cdc/ad7150.c
Changed logic so that all the IRQ getting errors jump to the same 'no-IRQ' branch as the DT mapping error did.
Revision history:
v6 => v7:
- re-ordered patches per subsystem
- mvpp2 - added a patch for not shadowing the return value
v5 => v6:
- iio: cdc: ad7150 - never abort probe if IRQ getting fails
v4 => v5:
- Fix subject lines for mvpp2 and wpcm450
- drop unnecessary irqno assignment from mb1232
- add back the drivers/i2c/i2c-smbus.c change which was accidentally dropped during v3 => v4 work
v3 => v4:
- Change also the fwnode_irq_get() as was suggested by Jonathan.
Changelog v2 => v3:
- rebase/resend/add kx022a fix.
Changelog v1 => v2:
- minor styling
---
Matti Vaittinen (9):
drivers: fwnode: fix fwnode_irq_get[_byname]()
iio: mb1232: relax return value check for IRQ get
iio: cdc: ad7150: relax return value check for IRQ get
pinctrl: wpcm450: relax return value check for IRQ get
pinctrl: ingenic: relax return value check for IRQ get
pinctrl: pistachio: relax return value check for IRQ get
i2c: i2c-smbus: fwnode_irq_get_byname() return value fix
net-next: mvpp2: relax return value check for IRQ get
net-next: mvpp2: don't shadow error
drivers/base/property.c | 12 +++++++++--- drivers/i2c/i2c-smbus.c | 2 +- drivers/iio/cdc/ad7150.c | 10 +++++----- drivers/iio/proximity/mb1232.c | 7 ++----- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 12 ++++++------ drivers/pinctrl/nuvoton/pinctrl-wpcm450.c | 2 -- drivers/pinctrl/pinctrl-ingenic.c | 2 -- drivers/pinctrl/pinctrl-pistachio.c | 6 ------ 8 files changed, 23 insertions(+), 30 deletions(-)
base-commit: f1fcbaa18b28dec10281551dfe6ed3a3ed80e3d6
Signature · 14 lines
2.40.1 -- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ Simon says - in Latin please. ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ Thanks to Simon Glass for the translation =]
PATCH v7 1/9 drivers: fwnode: fix fwnode_irq_get[_byname]()
The fwnode_irq_get() and the fwnode_irq_get_byname() return 0 upon device-tree IRQ mapping failure. This is contradicting the fwnode_irq_get_byname() function documentation and can potentially be a source of errors like:
int probe(...) {
...
irq = fwnode_irq_get_byname();
if (irq <= 0)
return irq;
...
}Here we do correctly check the return value from fwnode_irq_get_byname() but the driver probe will now return success. (There was already one such user in-tree).
Change the fwnode_irq_get_byname() to work as documented and make also the fwnode_irq_get() follow same common convention returning a negative errno upon failure.
---
Revision history:
v4 =>:
- No Changes
v3 => v4:
- Change also the fwnode_irq_get()
--- drivers/base/property.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
drivers/base/property.c +9 -3
@@ -987,12 +987,18 @@ EXPORT_SYMBOL(fwnode_iomap);* @fwnode: Pointer to the firmware node * @index: Zero-based index of the IRQ * -* Return: Linux IRQ number on success. Other values are determined -* according to acpi_irq_get() or of_irq_get() operation. +* Return: Linux IRQ number on success. Negative errno on failure. */ int fwnode_irq_get (const struct fwnode_handle *fwnode,unsigned int index) { -return fwnode_call_int_op (fwnode, irq_get, index); +int ret; + + ret =fwnode_call_int_op (fwnode, irq_get, index); +/* We treat mapping errors as invalid case */ +if (ret ==0 ) +return -EINVAL ; + +return ret; }EXPORT_SYMBOL (fwnode_irq_get);
Signature · 14 lines
2.40.1 -- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ Simon says - in Latin please. ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ Thanks to Simon Glass for the translation =]
PATCH v7 2/9 iio: mb1232: relax return value check for IRQ get
In reply to Matti Vaittinenfwnode_irq_get() was changed to not return 0 anymore.
Drop check for return value 0.
---
Revsion history:
v5 =>:
- No changes
v4 => v5:
- drop unnecessary data->irqnr = -1 assignment
The first patch of the series changes the fwnode_irq_get() so this depends on the first patch of the series and should not be applied alone.
--- drivers/iio/proximity/mb1232.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/iio/proximity/mb1232.c +2 -5
@@ -76,7 +76,7 @@ static s16 mb1232_read_distance(struct mb1232_data *data) goto error_unlock; } -if (data->irqnr >=0 ) { +if (data->irqnr >0 ) {/* it cannot take more than 100 ms */ ret =wait_for_completion_killable_timeout (&data->ranging,HZ /10 );
@@ -212,10 +212,7 @@ static int mb1232_probe(struct i2c_client *client)init_completion (&data->ranging); data->irqnr =fwnode_irq_get (dev_fwnode (&client->dev),0 ); -if (data->irqnr <=0 ) { -/* usage of interrupt is optional */ - data->irqnr =-1 ; - }else { +if (data->irqnr >0 ) { ret =devm_request_irq (dev, data->irqnr, mb1232_handle_irq,IRQF_TRIGGER_FALLING , id->name, indio_dev);if (ret <0 ) {
Signature · 14 lines
2.40.1 -- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ Simon says - in Latin please. ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ Thanks to Simon Glass for the translation =]
PATCH v7 3/9 iio: cdc: ad7150: relax return value check for IRQ get
In reply to Matti Vaittinenfwnode_irq_get[_byname]() were changed to not return 0 anymore. The special error case where device-tree based IRQ mapping fails can't no longer be reliably detected from this return value. This yields a functional change in the driver where the mapping failure is treated as an error.
The mapping failure can occur for example when the device-tree IRQ information translation call-back(s) (xlate) fail, IRQ domain is not found, IRQ type conflicts, etc. In most cases this indicates an error in the device-tree and special handling is not really required.
One more thing to note is that ACPI APIs do not return zero for any failures so this special handling did only apply on device-tree based systems.
Drop the special handling for DT mapping failures as these can no longer be separated from other errors at driver side. Change all failures in IRQ getting to be handled by continuing without the events instead of aborting the probe upon certain errors.
---
Revision history:
v5 => v6:
- Never abort the probe when IRQ getting fails but continue without events.
Please note that I don't have the hardware to test this change. Furthermore, testing this type of device-tree error cases is not trivial, as the question we probably dive in is "what happens with the existing users who have errors in the device-tree". Answering to this question is not simple.
The first patch of the series changes the fwnode_irq_get() so this depends on the first patch of the series and should not be applied alone.
--- drivers/iio/cdc/ad7150.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/iio/cdc/ad7150.c +5 -5
@@ -541,6 +541,7 @@ static int ad7150_probe(struct i2c_client *client)const struct i2c_device_id *id =i2c_client_get_device_id (client);struct ad7150_chip_info *chip;struct iio_dev *indio_dev; +bool use_irq = true;int ret; indio_dev =devm_iio_device_alloc (&client->dev,sizeof (*chip));
@@ -561,14 +562,13 @@ static int ad7150_probe(struct i2c_client *client) chip->interrupts[0 ] =fwnode_irq_get (dev_fwnode (&client->dev),0 );if (chip->interrupts[0 ] <0 ) -return chip->interrupts[0 ]; -if (id->driver_data ==AD7150 ) { + use_irq = false; +else if (id->driver_data ==AD7150 ) { chip->interrupts[1 ] =fwnode_irq_get (dev_fwnode (&client->dev),1 );if (chip->interrupts[1 ] <0 ) -return chip->interrupts[1 ]; + use_irq = false; } -if (chip->interrupts[0 ] && - (id->driver_data ==AD7151 || chip->interrupts[1 ])) { +if (use_irq) {irq_set_status_flags (chip->interrupts[0 ],IRQ_NOAUTOEN ); ret = devm_request_threaded_irq(&client->dev, chip->interrupts[0],
Signature · 14 lines
2.40.1 -- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ Simon says - in Latin please. ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ Thanks to Simon Glass for the translation =]
PATCH v7 4/9 pinctrl: wpcm450: relax return value check for IRQ get
In reply to Matti Vaittinenfwnode_irq_get[_byname]() were changed to not return 0 anymore. The special error case where device-tree based IRQ mapping fails can't no longer be reliably detected from this return value. This yields a functional change in the driver where the mapping failure is treated as an error.
The mapping failure can occur for example when the device-tree IRQ information translation call-back(s) (xlate) fail, IRQ domain is not found, IRQ type conflicts, etc. In most cases this indicates an error in the device-tree and special handling is not really required.
One more thing to note is that ACPI APIs do not return zero for any failures so this special handling did only apply on device-tree based systems.
Drop the special (no error, just skip the IRQ) handling for DT mapping failures as these can no longer be separated from other errors at driver side.
---
Revision history:
v5 => :
- No changes
v4 => v5:
Fix typo in subject "elax" => "relax"
Please note, I took Linus' reply to v4 cover-letter as ack && added the tag. Please let me know if this was not Ok.
The first patch of the series changes the fwnode_irq_get() so this depends on the first patch of the series and should not be applied alone.
--- drivers/pinctrl/nuvoton/pinctrl-wpcm450.c | 2 -- 1 file changed, 2 deletions(-)
drivers/pinctrl/nuvoton/pinctrl-wpcm450.c +0 -2
@@ -1106,8 +1106,6 @@ static int wpcm450_gpio_register(struct platform_device *pdev, irq =fwnode_irq_get (child, i);if (irq <0 )break ; -if (!irq) -continue ; girq->parents[i] = irq; girq->num_parents++;
Signature · 14 lines
2.40.1 -- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ Simon says - in Latin please. ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ Thanks to Simon Glass for the translation =]
PATCH v7 5/9 pinctrl: ingenic: relax return value check for IRQ get
In reply to Matti Vaittinenfwnode_irq_get[_byname]() were changed to not return 0 anymore.
Drop check for return value 0.
---
Revision history:
- No changes
Please note, I took Linus' reply to v4 cover-letter as ack && added the tag. Please let me know if this was not Ok.
The first patch of the series changes the fwnode_irq_get() so this depends on the first patch of the series and should not be applied alone.
--- drivers/pinctrl/pinctrl-ingenic.c | 2 -- 1 file changed, 2 deletions(-)
drivers/pinctrl/pinctrl-ingenic.c +0 -2
@@ -4201,8 +4201,6 @@ static int __init ingenic_gpio_probe(struct ingenic_pinctrl *jzpc, err =fwnode_irq_get (fwnode,0 );if (err <0 )return err; -if (!err) -return -EINVAL ; jzgc->irq = err; girq = &jzgc->gc.irq;
Signature · 14 lines
2.40.1 -- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ Simon says - in Latin please. ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ Thanks to Simon Glass for the translation =]
PATCH v7 6/9 pinctrl: pistachio: relax return value check for IRQ get
In reply to Matti Vaittinenfwnode_irq_get[_byname]() were changed to not return 0 anymore.
Drop check for return value 0.
---
Revision history:
- No changes
Please note, I took Linus' reply to v4 cover-letter as ack && added the tag. Please let me know if this was not Ok.
The first patch of the series changes the fwnode_irq_get() so this depends on the first patch of the series and should not be applied alone.
--- drivers/pinctrl/pinctrl-pistachio.c | 6 ------ 1 file changed, 6 deletions(-)
drivers/pinctrl/pinctrl-pistachio.c +0 -6
@@ -1393,12 +1393,6 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl)dev_err (pctl->dev,"Failed to retrieve IRQ for bank %u\n" , i); goto err; } -if (!ret) { -fwnode_handle_put (child); -dev_err (pctl->dev,"No IRQ for bank %u\n" , i); - ret = -EINVAL ; - goto err; - } irq = ret; bank = &pctl->gpio_banks[i];
Signature · 14 lines
2.40.1 -- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ Simon says - in Latin please. ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ Thanks to Simon Glass for the translation =]
PATCH v7 7/9 i2c: i2c-smbus: fwnode_irq_get_byname() return value fix
In reply to Matti VaittinenThe fwnode_irq_get_byname() was changed to not return 0 upon failure so return value check can be adjusted to reflect the change.
---
Revision history:
v5 =>:
- No changes
v4 => v5:
- Added back after this was accidentally dropped at v4.
Depends on the mentioned return value change which is in patch 1/N. The return value change does also cause a functional change here. Eg. when IRQ mapping fails, the fwnode_irq_get_byname() no longer returns zero. This will cause also the probe here to return nonzero failure. I guess this is desired behaviour - but I would appreciate any confirmation.
Please, see also previous discussion here:
https://lore.kernel.org/all/fbd52f5f5253b382b8d7b3e8046134de29f965b8.1666710197.git.mazziesaccount@gmail.com/
Another suggestion has been to drop the check altogether. I am slightly reluctant on doing that unless it gets confirmed that is the "right thing to do".
--- drivers/i2c/i2c-smbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/i2c-smbus.c +1 -1
@@ -129,7 +129,7 @@ static int smbalert_probe(struct i2c_client *ara) }else { irq =fwnode_irq_get_byname (dev_fwnode (adapter->dev.parent),"smbus_alert" ); -if (irq <=0 ) +if (irq <0 )return irq; }
Signature · 14 lines
2.40.1 -- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ Simon says - in Latin please. ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ Thanks to Simon Glass for the translation =]
PATCH v7 8/9 net-next: mvpp2: relax return value check for IRQ get
In reply to Matti Vaittinenfwnode_irq_get[_byname]() were changed to not return 0 anymore.
Drop check for return value 0.
---
Revision history:
v5 =>:
- No changes
v4 = v5:
Fix the subject, mb1232 => mvpp2
The first patch of the series changes the fwnode_irq_get() so this depends on the first patch of the series and should not be applied alone.
--- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +2 -2
@@ -5833,7 +5833,7 @@ static int mvpp2_multi_queue_vectors_init(struct mvpp2_port *port, v->irq =of_irq_get_byname (port_node, irqname); else v->irq = fwnode_irq_get(port->fwnode, i); -if (v->irq <=0 ) { +if (v->irq <0 ) { ret = -EINVAL ; goto err; }
@@ -6764,7 +6764,7 @@ static int mvpp2_port_probe(struct platform_device *pdev, err = -EPROBE_DEFER ; goto err_deinit_qvecs; } -if (port->port_irq <=0 ) +if (port->port_irq <0 )/* the link irq is optional */ port->port_irq =0 ;
Signature · 14 lines
2.40.1 -- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ Simon says - in Latin please. ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ Thanks to Simon Glass for the translation =]
PATCH v7 9/9 net-next: mvpp2: don't shadow error
In reply to Matti VaittinenDo not overwrite error from lower layers but return the actual error to user if obtaining an IRQ fails.
---
Revision history:
v7: New patch
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +5 -5
@@ -5830,13 +5830,13 @@ static int mvpp2_multi_queue_vectors_init(struct mvpp2_port *port, }if (port_node) - v->irq =of_irq_get_byname (port_node, irqname); + ret =of_irq_get_byname (port_node, irqname);else - v->irq =fwnode_irq_get (port->fwnode, i); -if (v->irq <0 ) { - ret = -EINVAL ; + ret =fwnode_irq_get (port->fwnode, i); +if (ret <0 ) goto err; - } + + v->irq = ret;netif_napi_add (port->dev, &v->napi, mvpp2_poll); }
Signature · 14 lines
2.40.1 -- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ Simon says - in Latin please. ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ Thanks to Simon Glass for the translation =]
Jakub Kicinski
maintainerQuoted 5 lines · On Mon, 29 May 2023 09:22:15 +0300 Matti Vaittinen wrote:
The
fwnode_irq_get()and thefwnode_irq_get_byname()may have returned zero if mapping the IRQ fails. This contradicts thefwnode_irq_get_byname()documentation. Furthermore, returning zero or errno on error is unepected and can easily lead to problems like.
What's the merging plan? Could patch 1 go to a stable branch and then driver trees can pull it in and apply their respective patches locally?
Greg Kroah-Hartman
maintainerQuoted 10 lines · Jakub Kicinski
Quoted 5 lines · On Mon, 29 May 2023 09:22:15 +0300 Matti Vaittinen wrote:
The
fwnode_irq_get()and thefwnode_irq_get_byname()may have returned zero if mapping the IRQ fails. This contradicts thefwnode_irq_get_byname()documentation. Furthermore, returning zero or errno on error is unepected and can easily lead to problems like.What's the merging plan? Could patch 1 go to a stable branch and then driver trees can pull it in and apply their respective patches locally?
I'll take patch 1 now, and then after 6.5-rc1, Matti, can you send the cleanup patches to the respective subsystems?
thanks,
greg k-h
Jakub Kicinski
maintainerQuoted 6 lines · On Thu, 15 Jun 2023 13:37:17 +0200 Greg Kroah-Hartman wrote:
Quoted 3 lines
What's the merging plan? Could patch 1 go to a stable branch and then driver trees can pull it in and apply their respective patches locally?
I'll take patch 1 now, and then after 6.5-rc1, Matti, can you send the cleanup patches to the respective subsystems?
👍️👍️
Quoted 8 lines · Greg Kroah-Hartman
Quoted 7 lines · Jakub Kicinski
Quoted 5 lines · On Mon, 29 May 2023 09:22:15 +0300 Matti Vaittinen wrote:
The
fwnode_irq_get()and thefwnode_irq_get_byname()may have returned zero if mapping the IRQ fails. This contradicts thefwnode_irq_get_byname()documentation. Furthermore, returning zero or errno on error is unepected and can easily lead to problems like.
Quoted 6 lines
Quoted 3 lines
What's the merging plan? Could patch 1 go to a stable branch and then driver trees can pull it in and apply their respective patches locally?
I'll take patch 1 now, and then after 6.5-rc1, Matti, can you send the cleanup patches to the respective subsystems?
Yes. I can re-spin the rest of the patches.
Yours,
-- Matti
Quoted 4 lines
thanks,
greg k-h
Signature · 5 lines
Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~