staging: rtl8192e: Remove unsupported modes a and 5G
cover staging: rtl8192e: Remove unsupported modes a and 5G
Remove unsupported modes a and 5G to shorten code. Change variable names to align with rtlwifi driver as requested in TODO.
Tested with rtl8192e (WLL6130-D99) in Modes b, g, n (12.5 MB/s) Transferred this patch over wlan connection of rtl8192e.
Philipp Hortmann (9):
staging: rtl8192e: Remove variable stats->freq as it is constant
staging: rtl8192e: Remove unsupported modes IEEE_N_5G and IEEE_A
staging: rtl8192e: Rename constant IEEE_x to WIRELESS_MODE_x
staging: rtl8192e: Remove unused enum led_ctl_mode
staging: rtl8192e: Rename rtllib_state to rtl_link_state
staging: rtl8192e: Rename state to link_state
staging: rtl8192e: Rename RTLLIB_NOLINK to MAC80211_NOLINK
staging: rtl8192e: Rename RTLLIB_LINKED to MAC80211_LINKED
staging: rtl8192e: Rename RTLLIB_LINKED_SCANNING
.../staging/rtl8192e/rtl8192e/r8192E_dev.c | 24 ++-- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 41 +++--- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 18 +-- .../staging/rtl8192e/rtl8192e/rtl_ethtool.c | 4 +- drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 4 +- drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 12 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 8 +- drivers/staging/rtl8192e/rtllib.h | 37 +----- drivers/staging/rtl8192e/rtllib_rx.c | 43 +++--- drivers/staging/rtl8192e/rtllib_softmac.c | 122 +++++++++--------- drivers/staging/rtl8192e/rtllib_softmac_wx.c | 18 +-- drivers/staging/rtl8192e/rtllib_tx.c | 2 +- drivers/staging/rtl8192e/rtllib_wx.c | 4 +- 13 files changed, 146 insertions(+), 191 deletions(-)
Signature · 1 line
2.40.1
PATCH 1/9 staging: rtl8192e: Remove variable stats->freq as it is constant
stats->freq is initialized with 1 and then unchanged. All evaluations will result accordingly. Remove resulting dead code and unused defines.
--- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 1 - drivers/staging/rtl8192e/rtllib.h | 5 ----- drivers/staging/rtl8192e/rtllib_rx.c | 19 +++++-------------- 3 files changed, 5 insertions(+), 20 deletions(-)
drivers/staging/rtl8192e/rtl8192e/rtl_core.c +0 -1
@@ -1769,7 +1769,6 @@ static void _rtl92e_rx_normal(struct net_device *dev) .signal = 0, .noise = (u8)-98, .rate = 0, - .freq = RTLLIB_24GHZ_BAND, };unsigned int count = priv->rxringcount;
drivers/staging/rtl8192e/rtllib.h +0 -5
@@ -500,9 +500,6 @@ enum _REG_PREAMBLE_MODE {#define RTLLIB_CCK_MODULATION (1<<0)#define RTLLIB_OFDM_MODULATION (1<<1) -#define RTLLIB_24GHZ_BAND (1<<0) -#define RTLLIB_52GHZ_BAND (1<<1) -#define RTLLIB_CCK_RATE_LEN 4#define RTLLIB_CCK_RATE_1MB 0x02#define RTLLIB_CCK_RATE_2MB 0x04
@@ -549,10 +546,8 @@ struct rtllib_rx_stats {u8 signal;u8 noise;u16 rate;/* in 100 kbps */ -u8 received_channel;u8 control;u8 mask; -u8 freq;u16 len;u64 tsf;u32 beacon_time;
drivers/staging/rtl8192e/rtllib_rx.c +5 -14
@@ -2301,12 +2301,7 @@ static inline int rtllib_network_init( network->CountryIeLen =0 ;memset (network->CountryIeBuf,0 ,MAX_IE_LEN );HTInitializeBssDesc (&network->bssht); -if (stats->freq ==RTLLIB_52GHZ_BAND ) { -/* for A band (No DS info) */ - network->channel = stats->received_channel; - }else { - network->flags |=NETWORK_HAS_CCK ; - } + network->flags |=NETWORK_HAS_CCK ; network->wpa_ie_len =0 ; network->rsn_ie_len =0 ;
@@ -2321,14 +2316,10 @@ static inline int rtllib_network_init( network->mode =0 ; -if (stats->freq ==RTLLIB_52GHZ_BAND ) { - network->mode =IEEE_A ; - }else { -if (network->flags &NETWORK_HAS_OFDM ) - network->mode |=IEEE_G ; -if (network->flags &NETWORK_HAS_CCK ) - network->mode |=IEEE_B ; - } +if (network->flags &NETWORK_HAS_OFDM ) + network->mode |=IEEE_G ; +if (network->flags &NETWORK_HAS_CCK ) + network->mode |=IEEE_B ;if (network->mode ==0 ) { netdev_dbg(ieee->dev, "Filtered out '%s (%pM)' network.\n",
Signature · 1 line
2.40.1
PATCH 2/9 staging: rtl8192e: Remove unsupported modes IEEE_N_5G and IEEE_A
In reply to Philipp HortmannRemove unsupported modes IEEE_N_5G and IEEE_A as those are not supported by hardware and are not offered by user software. Remove resulting dead code and unused defines.
--- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 4 ---- drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 -- drivers/staging/rtl8192e/rtllib.h | 8 ++------ drivers/staging/rtl8192e/rtllib_rx.c | 4 +--- drivers/staging/rtl8192e/rtllib_softmac.c | 6 ++---- drivers/staging/rtl8192e/rtllib_softmac_wx.c | 2 +- 6 files changed, 6 insertions(+), 20 deletions(-)
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +0 -4
@@ -1816,9 +1816,6 @@ void rtl92e_update_ratr_table(struct net_device *dev)rtl92e_config_rate (dev, &rate_config); ratr_value = rate_config | *pMcsRate <<12 ;switch (ieee->mode) { -case IEEE_A : - ratr_value &=0x00000FF0 ; -break ;case IEEE_B : ratr_value &=0x0000000F ;break ;
@@ -1827,7 +1824,6 @@ void rtl92e_update_ratr_table(struct net_device *dev) ratr_value &=0x00000FF7 ;break ;case IEEE_N_24G : -case IEEE_N_5G :if (ieee->ht_info->peer_mimo_ps ==0 ) ratr_value &=0x0007F007 ;else
drivers/staging/rtl8192e/rtl819x_HTProc.c +0 -2
@@ -424,14 +424,12 @@ static u8 HT_PickMCSRate(struct rtllib_device *ieee, u8 *pOperateMCS) }switch (ieee->mode) { -case IEEE_A :case IEEE_B :case IEEE_G :for (i =0 ; i <=15 ; i++) pOperateMCS[i] =0 ;break ;case IEEE_N_24G : -case IEEE_N_5G : pOperateMCS[0 ] &=RATE_ADPT_1SS_MASK ; pOperateMCS[1 ] &=RATE_ADPT_2SS_MASK ; pOperateMCS[3 ] &=RATE_ADPT_MCS32_MASK ;
drivers/staging/rtl8192e/rtllib.h +2 -6
@@ -309,9 +309,7 @@ enum rt_op_mode { };#define aSifsTime \ - (((priv->rtllib->current_network.mode == IEEE_A) \ - || (priv->rtllib->current_network.mode == IEEE_N_24G) \ - || (priv->rtllib->current_network.mode == IEEE_N_5G)) ? 16 : 10) + ((priv->rtllib->current_network.mode == IEEE_N_24G) ? 16 : 10)#define MGMT_QUEUE_NUM 5
@@ -1724,12 +1722,10 @@ struct rtllib_device {u8 priv[]; }; -#define IEEE_A (1<<0)#define IEEE_B (1<<1)#define IEEE_G (1<<2)#define IEEE_N_24G (1<<4) -#define IEEE_N_5G (1<<5) -#define IEEE_MODE_MASK (IEEE_A|IEEE_B|IEEE_G) +#define IEEE_MODE_MASK (IEEE_B | IEEE_G)/* Generate a 802.11 header */
drivers/staging/rtl8192e/rtllib_rx.c +1 -3
@@ -2329,9 +2329,7 @@ static inline int rtllib_network_init( }if (network->bssht.bd_support_ht) { -if (network->mode ==IEEE_A ) - network->mode =IEEE_N_5G ; -else if (network->mode & (IEEE_G |IEEE_B )) +if (network->mode & (IEEE_G |IEEE_B )) network->mode =IEEE_N_24G ; }if (rtllib_is_empty_essid (network->ssid, network->ssid_len))
drivers/staging/rtl8192e/rtllib_softmac.c +2 -4
@@ -181,9 +181,7 @@ static u8 MgntQuery_MgntFrameTxRate(struct rtllib_device *ieee) rate = ieee->basic_rate &0x7f ;if (rate ==0 ) { -if (ieee->mode ==IEEE_A || - ieee->mode ==IEEE_N_5G || - (ieee->mode ==IEEE_N_24G && !ht_info->bCurSuppCCK)) +if (ieee->mode ==IEEE_N_24G && !ht_info->bCurSuppCCK) rate =0x0c ;else rate =0x02 ;
@@ -2577,7 +2575,7 @@ static void rtllib_start_ibss_wq(void *data) }netdev_info (ieee->dev,"%s(): ieee->mode = %d\n" , __func__, ieee->mode); -if ((ieee->mode ==IEEE_N_24G ) || (ieee->mode ==IEEE_N_5G )) +if (ieee->mode ==IEEE_N_24G )HTUseDefaultSetting (ieee);else ieee->ht_info->bCurrentHTSupport = false;
drivers/staging/rtl8192e/rtllib_softmac_wx.c +1 -1
@@ -489,7 +489,7 @@ int rtllib_wx_get_name(struct rtllib_device *ieee, struct iw_request_info *info, {const char *b = ieee->modulation &RTLLIB_CCK_MODULATION ?"b" :"" ;const char *g = ieee->modulation &RTLLIB_OFDM_MODULATION ?"g" :"" ; -const char *n = ieee->mode & (IEEE_N_24G |IEEE_N_5G ) ?"n" :"" ; +const char *n = ieee->mode & (IEEE_N_24G ) ?"n" :"" ;scnprintf (wrqu->name,sizeof (wrqu->name),"802.11%s%s%s" , b, g, n);return 0 ;
Signature · 1 line
2.40.1
PATCH 3/9 staging: rtl8192e: Rename constant IEEE_x to WIRELESS_MODE_x
In reply to Philipp HortmannRename constant IEEE_B to WIRELESS_MODE_B, IEEE_G -> WIRELESS_MODE_G and IEEE_N_24G -> WIRELESS_MODE_N_24G to align with rtlwifi driver as requested in TODO.
--- .../staging/rtl8192e/rtl8192e/r8192E_dev.c | 10 +++---- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 6 ++-- drivers/staging/rtl8192e/rtllib.h | 7 ++--- drivers/staging/rtl8192e/rtllib_rx.c | 12 ++++---- drivers/staging/rtl8192e/rtllib_softmac.c | 28 +++++++++---------- drivers/staging/rtl8192e/rtllib_softmac_wx.c | 2 +- drivers/staging/rtl8192e/rtllib_tx.c | 2 +- drivers/staging/rtl8192e/rtllib_wx.c | 2 +- 10 files changed, 34 insertions(+), 39 deletions(-)
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +5 -5
@@ -162,7 +162,7 @@ void rtl92e_set_reg(struct net_device *dev, u8 variable, u8 *val) &priv->rtllib->current_network.qos_data.parameters; u1bAIFS = qop->aifs[pAcParam] * - ((mode & (IEEE_G |IEEE_N_24G )) ?9 :20 ) + aSifsTime; + ((mode & (WIRELESS_MODE_G |WIRELESS_MODE_N_24G )) ?9 :20 ) + aSifsTime;rtl92e_dm_init_edca_turbo (dev);
@@ -1816,14 +1816,14 @@ void rtl92e_update_ratr_table(struct net_device *dev)rtl92e_config_rate (dev, &rate_config); ratr_value = rate_config | *pMcsRate <<12 ;switch (ieee->mode) { -case IEEE_B : +case WIRELESS_MODE_B : ratr_value &=0x0000000F ;break ; -case IEEE_G : -case IEEE_G |IEEE_B : +case WIRELESS_MODE_G : +case WIRELESS_MODE_G |WIRELESS_MODE_B : ratr_value &=0x00000FF7 ;break ; -case IEEE_N_24G : +case WIRELESS_MODE_N_24G :if (ieee->ht_info->peer_mimo_ps ==0 ) ratr_value &=0x0007F007 ;else
drivers/staging/rtl8192e/rtl8192e/rtl_core.c +1 -1
@@ -277,7 +277,7 @@ static void _rtl92e_update_cap(struct net_device *dev, u16 cap) } } -if (net->mode & (IEEE_G |IEEE_N_24G )) { +if (net->mode & (WIRELESS_MODE_G |WIRELESS_MODE_N_24G )) {u8 slot_time_val;u8 cur_slot_time = priv->slot_time;
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +1 -1
@@ -2104,7 +2104,7 @@ static void _rtl92e_dm_dynamic_tx_power(struct net_device *dev)return ; }if ((priv->rtllib->ht_info->IOTPeer ==HT_IOT_PEER_ATHEROS ) && - (priv->rtllib->mode ==IEEE_G )) { + (priv->rtllib->mode ==WIRELESS_MODE_G )) { txhipower_threshold =TX_POWER_ATHEROAP_THRESH_HIGH ; txlowpower_threshold =TX_POWER_ATHEROAP_THRESH_LOW ; }else {
drivers/staging/rtl8192e/rtl819x_HTProc.c +3 -3
@@ -424,12 +424,12 @@ static u8 HT_PickMCSRate(struct rtllib_device *ieee, u8 *pOperateMCS) }switch (ieee->mode) { -case IEEE_B : -case IEEE_G : +case WIRELESS_MODE_B : +case WIRELESS_MODE_G :for (i =0 ; i <=15 ; i++) pOperateMCS[i] =0 ;break ; -case IEEE_N_24G : +case WIRELESS_MODE_N_24G : pOperateMCS[0 ] &=RATE_ADPT_1SS_MASK ; pOperateMCS[1 ] &=RATE_ADPT_2SS_MASK ; pOperateMCS[3 ] &=RATE_ADPT_MCS32_MASK ;
drivers/staging/rtl8192e/rtllib.h +2 -5
@@ -309,7 +309,7 @@ enum rt_op_mode { };#define aSifsTime \ - ((priv->rtllib->current_network.mode == IEEE_N_24G) ? 16 : 10) + ((priv->rtllib->current_network.mode == WIRELESS_MODE_N_24G) ? 16 : 10)#define MGMT_QUEUE_NUM 5
@@ -1722,10 +1722,7 @@ struct rtllib_device {u8 priv[]; }; -#define IEEE_B (1<<1) -#define IEEE_G (1<<2) -#define IEEE_N_24G (1<<4) -#define IEEE_MODE_MASK (IEEE_B | IEEE_G) +#define IEEE_MODE_MASK (WIRELESS_MODE_B | WIRELESS_MODE_G)/* Generate a 802.11 header */
drivers/staging/rtl8192e/rtllib_rx.c +6 -6
@@ -2317,9 +2317,9 @@ static inline int rtllib_network_init( network->mode =0 ;if (network->flags &NETWORK_HAS_OFDM ) - network->mode |=IEEE_G ; + network->mode |=WIRELESS_MODE_G ;if (network->flags &NETWORK_HAS_CCK ) - network->mode |=IEEE_B ; + network->mode |=WIRELESS_MODE_B ;if (network->mode ==0 ) { netdev_dbg(ieee->dev, "Filtered out '%s (%pM)' network.\n",
@@ -2329,8 +2329,8 @@ static inline int rtllib_network_init( }if (network->bssht.bd_support_ht) { -if (network->mode & (IEEE_G |IEEE_B )) - network->mode =IEEE_N_24G ; +if (network->mode & (WIRELESS_MODE_G |WIRELESS_MODE_B )) + network->mode =WIRELESS_MODE_N_24G ; }if (rtllib_is_empty_essid (network->ssid, network->ssid_len)) network->flags |=NETWORK_EMPTY_ESSID ;
@@ -2576,8 +2576,8 @@ static inline void rtllib_process_probe_response(if (is_same_network (&ieee->current_network, network, (network->ssid_len ?1 :0 ))) {update_network (ieee, &ieee->current_network, network); -if ((ieee->current_network.mode ==IEEE_N_24G || - ieee->current_network.mode ==IEEE_G ) && +if ((ieee->current_network.mode ==WIRELESS_MODE_N_24G || + ieee->current_network.mode ==WIRELESS_MODE_G ) && ieee->current_network.berp_info_valid) {if (ieee->current_network.erp_value & ERP_UseProtection) ieee->current_network.buseprotection = true;
drivers/staging/rtl8192e/rtllib_softmac.c +13 -15
@@ -181,7 +181,7 @@ static u8 MgntQuery_MgntFrameTxRate(struct rtllib_device *ieee) rate = ieee->basic_rate &0x7f ;if (rate ==0 ) { -if (ieee->mode ==IEEE_N_24G && !ht_info->bCurSuppCCK) +if (ieee->mode ==WIRELESS_MODE_N_24G && !ht_info->bCurSuppCCK) rate =0x0c ;else rate =0x02 ;
@@ -802,8 +802,8 @@ static struct sk_buff *rtllib_probe_resp(struct rtllib_device *ieee,else atim_len =0 ; -if ((ieee->current_network.mode ==IEEE_G ) || - (ieee->current_network.mode ==IEEE_N_24G && +if ((ieee->current_network.mode ==WIRELESS_MODE_G ) || + (ieee->current_network.mode ==WIRELESS_MODE_N_24G && ieee->ht_info->bCurSuppCCK)) { erp_len =3 ; erpinfo_content =0 ;
@@ -1470,7 +1470,7 @@ static void rtllib_associate_complete_wq(void *data)netdev_info (ieee->dev,"Using G rates:%d\n" , ieee->rate); }else { ieee->rate =22 ; - ieee->SetWirelessMode (ieee->dev,IEEE_B ); + ieee->SetWirelessMode (ieee->dev,WIRELESS_MODE_B );netdev_info (ieee->dev,"Using B rates:%d\n" , ieee->rate); }if (ieee->ht_info->bCurrentHTSupport && ieee->ht_info->enable_ht) {
@@ -1654,14 +1654,12 @@ inline void rtllib_softmac_new_net(struct rtllib_device *ieee, (ieee->modulation & RTLLIB_OFDM_MODULATION)) { ieee->rate = 108; - ieee->SetWirelessMode(ieee->dev, - IEEE_G); + ieee->SetWirelessMode(ieee->dev, WIRELESS_MODE_G); netdev_info(ieee->dev, "Using G rates\n"); } else { ieee->rate =22 ; - ieee->SetWirelessMode (ieee->dev, -IEEE_B ); + ieee->SetWirelessMode (ieee->dev,WIRELESS_MODE_B );netdev_info (ieee->dev,"Using B rates\n" ); }
@@ -1826,8 +1824,8 @@ static inline u16 assoc_parse(struct rtllib_device *ieee, struct sk_buff *skb, status_code =le16_to_cpu (response_head->status);if ((status_code ==WLAN_STATUS_ASSOC_DENIED_RATES || status_code ==WLAN_STATUS_CAPS_UNSUPPORTED ) && - ((ieee->mode ==IEEE_G ) && - (ieee->current_network.mode ==IEEE_N_24G ) && + ((ieee->mode ==WIRELESS_MODE_G ) && + (ieee->current_network.mode ==WIRELESS_MODE_N_24G ) && (ieee->AsocRetryCount++ < (RT_ASOC_RETRY_LIMIT -1 )))) { ieee->ht_info->iot_action |=HT_IOT_ACT_PURE_N_MODE ; }else {
@@ -2239,10 +2237,10 @@ static void rtllib_rx_auth_resp(struct rtllib_device *ieee, struct sk_buff *skb) ieee->current_network.mode); }else {/*TODO*/ - ieee->SetWirelessMode (ieee->dev,IEEE_G ); + ieee->SetWirelessMode (ieee->dev,WIRELESS_MODE_G ); } -if ((ieee->current_network.mode ==IEEE_N_24G ) && +if ((ieee->current_network.mode ==WIRELESS_MODE_N_24G ) && bHalfSupportNmode) {netdev_info (ieee->dev,"======>enter half N mode\n" ); ieee->bHalfWirelessN24GMode = true;
@@ -2498,7 +2496,7 @@ static void rtllib_start_ibss_wq(void *data) } ieee->state =RTLLIB_NOLINK ; - ieee->mode =IEEE_G ; + ieee->mode =WIRELESS_MODE_G ;/* check if we have this cell in our network list */ rtllib_softmac_check_all_nets (ieee);
@@ -2568,14 +2566,14 @@ static void rtllib_start_ibss_wq(void *data) } ieee->current_network.qos_data.supported =0 ; - ieee->SetWirelessMode (ieee->dev,IEEE_G ); + ieee->SetWirelessMode (ieee->dev,WIRELESS_MODE_G ); ieee->current_network.mode = ieee->mode; ieee->current_network.atim_window =0 ; ieee->current_network.capability =WLAN_CAPABILITY_IBSS ; }netdev_info (ieee->dev,"%s(): ieee->mode = %d\n" , __func__, ieee->mode); -if (ieee->mode ==IEEE_N_24G ) +if (ieee->mode ==WIRELESS_MODE_N_24G )HTUseDefaultSetting (ieee);else ieee->ht_info->bCurrentHTSupport = false;
drivers/staging/rtl8192e/rtllib_softmac_wx.c +1 -1
@@ -489,7 +489,7 @@ int rtllib_wx_get_name(struct rtllib_device *ieee, struct iw_request_info *info, {const char *b = ieee->modulation &RTLLIB_CCK_MODULATION ?"b" :"" ;const char *g = ieee->modulation &RTLLIB_OFDM_MODULATION ?"g" :"" ; -const char *n = ieee->mode & (IEEE_N_24G ) ?"n" :"" ; +const char *n = ieee->mode & (WIRELESS_MODE_N_24G ) ?"n" :"" ;scnprintf (wrqu->name,sizeof (wrqu->name),"802.11%s%s%s" , b, g, n);return 0 ;
drivers/staging/rtl8192e/rtllib_tx.c +1 -1
@@ -406,7 +406,7 @@ static void rtllib_query_protectionmode(struct rtllib_device *ieee,if (is_broadcast_ether_addr (skb->data +16 ))return ; -if (ieee->mode <IEEE_N_24G ) { +if (ieee->mode <WIRELESS_MODE_N_24G ) {if (skb->len > ieee->rts) { tcb_desc->bRTSEnable = true; tcb_desc->rts_rate =MGN_24M ;
drivers/staging/rtl8192e/rtllib_wx.c +1 -1
@@ -118,7 +118,7 @@ static inline char *rtl819x_translate_scan(struct rtllib_device *ieee, max_rate = rate; } -if (network->mode >=IEEE_N_24G ) { +if (network->mode >=WIRELESS_MODE_N_24G ) {struct ht_capab_ele *ht_cap =NULL ;bool is40M = false, isShortGI = false;u8 max_mcs =0 ;
Signature · 1 line
2.40.1
PATCH 4/9 staging: rtl8192e: Remove unused enum led_ctl_mode
In reply to Philipp HortmannRemove unused enum led_ctl_mode to shorten code.
--- drivers/staging/rtl8192e/rtllib.h | 11 ----------- 1 file changed, 11 deletions(-)
drivers/staging/rtl8192e/rtllib.h +0 -11
@@ -420,17 +420,6 @@ enum init_gain_op_type {IG_Max }; -enum led_ctl_mode { -LED_CTL_POWER_ON =1 , -LED_CTL_LINK =2 , -LED_CTL_NO_LINK =3 , -LED_CTL_TX =4 , -LED_CTL_RX =5 , -LED_CTL_SITE_SURVEY =6 , -LED_CTL_POWER_OFF =7 , -LED_CTL_START_TO_LINK =8 , -}; -enum wireless_mode {WIRELESS_MODE_UNKNOWN =0x00 ,WIRELESS_MODE_A =0x01 ,
Signature · 1 line
2.40.1
PATCH 5/9 staging: rtl8192e: Rename rtllib_state to rtl_link_state
In reply to Philipp HortmannRename rtllib_state to rtl_link_state to align with rtlwifi driver and to increase readability as state is to general.
--- drivers/staging/rtl8192e/rtllib.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8192e/rtllib.h +2 -2
@@ -1119,7 +1119,7 @@ struct rtllib_network {struct list_head list; }; -enum rtllib_state { +enum rtl_link_state {/* the card is not linked at all */ RTLLIB_NOLINK =0 ,
@@ -1489,7 +1489,7 @@ struct rtllib_device {*/ struct rtllib_network current_network; -enum rtllib_state state; +enum rtl_link_state state;int short_slot;int mode;/* A, B, G */
Signature · 1 line
2.40.1
PATCH 6/9 staging: rtl8192e: Rename state to link_state
In reply to Philipp HortmannRename state to link_state to align with rtlwifi driver and to increase readability as state is to general.
---
Note: Special care must be taken because state is used in more than one struct.
--- .../staging/rtl8192e/rtl8192e/r8192E_dev.c | 10 +-- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 36 ++++---- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 16 ++-- .../staging/rtl8192e/rtl8192e/rtl_ethtool.c | 4 +- drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 4 +- drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 12 +-- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 14 ++-- drivers/staging/rtl8192e/rtllib_softmac.c | 82 +++++++++---------- drivers/staging/rtl8192e/rtllib_softmac_wx.c | 16 ++-- drivers/staging/rtl8192e/rtllib_wx.c | 2 +- 11 files changed, 99 insertions(+), 99 deletions(-)
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +5 -5
@@ -52,15 +52,15 @@ static void _rtl92e_update_msr(struct net_device *dev)switch (priv->rtllib->iw_mode) {case IW_MODE_INFRA : -if (priv->rtllib->state ==RTLLIB_LINKED ) +if (priv->rtllib->link_state ==RTLLIB_LINKED ) msr |=MSR_LINK_MANAGED ;break ;case IW_MODE_ADHOC : -if (priv->rtllib->state ==RTLLIB_LINKED ) +if (priv->rtllib->link_state ==RTLLIB_LINKED ) msr |=MSR_LINK_ADHOC ;break ;case IW_MODE_MASTER : -if (priv->rtllib->state ==RTLLIB_LINKED ) +if (priv->rtllib->link_state ==RTLLIB_LINKED ) msr |=MSR_LINK_MASTER ;break ;default :
@@ -745,7 +745,7 @@ void rtl92e_link_change(struct net_device *dev)if (!priv->up)return ; -if (ieee->state ==RTLLIB_LINKED ) { +if (ieee->link_state ==RTLLIB_LINKED ) {_rtl92e_net_update (dev);rtl92e_update_ratr_table (dev); if ((ieee->pairwise_key_type == KEY_TYPE_WEP40) ||
@@ -760,7 +760,7 @@ void rtl92e_link_change(struct net_device *dev)u32 reg; reg =rtl92e_readl (dev,RCR ); -if (priv->rtllib->state ==RTLLIB_LINKED ) { +if (priv->rtllib->link_state ==RTLLIB_LINKED ) {if (ieee->intel_promiscuous_md_info.promiscuous_on) ;else
drivers/staging/rtl8192e/rtl8192e/rtl_core.c +18 -18
@@ -169,7 +169,7 @@ bool rtl92e_set_rf_state(struct net_device *dev, (priv->rtllib->iw_mode == IW_MODE_ADHOC)) {if ((priv->rtllib->rf_off_reason >RF_CHANGE_BY_IPS ) || (change_source >RF_CHANGE_BY_IPS )) { -if (ieee->state ==RTLLIB_LINKED ) +if (ieee->link_state ==RTLLIB_LINKED ) priv->blinked_ingpio = true;else priv->blinked_ingpio = false;
@@ -327,7 +327,7 @@ static void _rtl92e_qos_activate(void *data)int i;mutex_lock (&priv->mutex); -if (priv->rtllib->state !=RTLLIB_LINKED ) +if (priv->rtllib->link_state !=RTLLIB_LINKED ) goto success;for (i =0 ; i <QOS_QUEUE_NUM ; i++)
@@ -344,7 +344,7 @@ static int _rtl92e_qos_handle_probe_response(struct r8192_priv *priv,int ret =0 ;u32 size =sizeof (struct rtllib_qos_parameters ); -if (priv->rtllib->state !=RTLLIB_LINKED ) +if (priv->rtllib->link_state !=RTLLIB_LINKED )return ret;if (priv->rtllib->iw_mode !=IW_MODE_INFRA )
@@ -400,7 +400,7 @@ static int _rtl92e_qos_assoc_resp(struct r8192_priv *priv,if (!priv || !network)return 0 ; -if (priv->rtllib->state !=RTLLIB_LINKED ) +if (priv->rtllib->link_state !=RTLLIB_LINKED )return 0 ;if (priv->rtllib->iw_mode !=IW_MODE_INFRA )
@@ -635,7 +635,7 @@ static int _rtl92e_sta_up(struct net_device *dev, bool is_silent_reset)if (priv->polling_timer_on ==0 )rtl92e_check_rfctrl_gpio_timer (&priv->gpio_polling_timer); -if (priv->rtllib->state !=RTLLIB_LINKED ) +if (priv->rtllib->link_state !=RTLLIB_LINKED )rtllib_softmac_start_protocol (priv->rtllib,0 );rtllib_reset_queue (priv->rtllib);_rtl92e_watchdog_timer_cb (&priv->watch_dog_timer);
@@ -660,7 +660,7 @@ static int _rtl92e_sta_down(struct net_device *dev, bool shutdownrf) priv->rtllib->rtllib_ips_leave (dev); -if (priv->rtllib->state ==RTLLIB_LINKED ) +if (priv->rtllib->link_state ==RTLLIB_LINKED )rtl92e_leisure_ps_leave (dev); priv->up =0 ;
@@ -1009,7 +1009,7 @@ static enum reset_type _rtl92e_if_check_reset(struct net_device *dev)if (rfState == rf_on && (priv->rtllib->iw_mode ==IW_MODE_INFRA ) && - (priv->rtllib->state ==RTLLIB_LINKED )) + (priv->rtllib->link_state ==RTLLIB_LINKED )) RxResetType =_rtl92e_rx_check_stuck (dev); if (TxResetType == RESET_TYPE_NORMAL ||
@@ -1051,7 +1051,7 @@ static void _rtl92e_if_silent_reset(struct net_device *dev)mutex_lock (&priv->wx_mutex); -if (priv->rtllib->state ==RTLLIB_LINKED ) +if (priv->rtllib->link_state ==RTLLIB_LINKED )rtl92e_leisure_ps_leave (dev);if (priv->up) {
@@ -1073,9 +1073,9 @@ static void _rtl92e_if_silent_reset(struct net_device *dev)rtl92e_dm_deinit (dev);rtllib_stop_scan_syncro (ieee); -if (ieee->state ==RTLLIB_LINKED ) { +if (ieee->link_state ==RTLLIB_LINKED ) {mutex_lock (&ieee->wx_mutex); -netdev_info (dev,"ieee->state is RTLLIB_LINKED\n" ); +netdev_info (dev,"ieee->link_state is RTLLIB_LINKED\n" );rtllib_stop_send_beacons (priv->rtllib);del_timer_sync (&ieee->associate_timer);cancel_delayed_work (&ieee->associate_retry_wq);
@@ -1083,7 +1083,7 @@ static void _rtl92e_if_silent_reset(struct net_device *dev)netif_carrier_off (dev);mutex_unlock (&ieee->wx_mutex); }else { -netdev_info (dev,"ieee->state is NOT LINKED\n" ); +netdev_info (dev,"ieee->link_state is NOT LINKED\n" );rtllib_softmac_stop_protocol (priv->rtllib,0 , true); }
@@ -1110,14 +1110,14 @@ static void _rtl92e_if_silent_reset(struct net_device *dev)rtl92e_enable_hw_security_config (dev); -if (ieee->state ==RTLLIB_LINKED && ieee->iw_mode == +if (ieee->link_state ==RTLLIB_LINKED && ieee->iw_mode ==IW_MODE_INFRA ) { ieee->set_chan (ieee->dev, ieee->current_network.channel);schedule_work (&ieee->associate_complete_wq); - }else if (ieee->state ==RTLLIB_LINKED && ieee->iw_mode == + }else if (ieee->link_state ==RTLLIB_LINKED && ieee->iw_mode ==IW_MODE_ADHOC ) { ieee->set_chan (ieee->dev, ieee->current_network.channel);
@@ -1181,7 +1181,7 @@ static void _rtl92e_watchdog_wq_cb(void *data)if (!priv->up || priv->hw_radio_off)return ; -if (priv->rtllib->state >=RTLLIB_LINKED ) { +if (priv->rtllib->link_state >=RTLLIB_LINKED ) {if (priv->rtllib->CntAfterLink <2 ) priv->rtllib->CntAfterLink++; }else {
@@ -1191,7 +1191,7 @@ static void _rtl92e_watchdog_wq_cb(void *data)rtl92e_dm_watchdog (dev);if (!rtllib_act_scanning (priv->rtllib, false)) { -if ((ieee->iw_mode ==IW_MODE_INFRA ) && (ieee->state == +if ((ieee->iw_mode ==IW_MODE_INFRA ) && (ieee->link_state ==RTLLIB_NOLINK ) && (ieee->rf_power_state == rf_on) && !ieee->is_set_key && (!ieee->proto_stoppping) && !ieee->wx_set_enc) {
@@ -1202,7 +1202,7 @@ static void _rtl92e_watchdog_wq_cb(void *data) } } } -if ((ieee->state ==RTLLIB_LINKED ) && (ieee->iw_mode == +if ((ieee->link_state ==RTLLIB_LINKED ) && (ieee->iw_mode ==IW_MODE_INFRA ) && (!ieee->net_promiscuous_md)) {if (ieee->link_detect_info.NumRxOkInPeriod >100 || ieee->link_detect_info.NumTxOkInPeriod >100 )
@@ -1244,7 +1244,7 @@ static void _rtl92e_watchdog_wq_cb(void *data) ieee->link_detect_info.bHigherBusyTraffic = bHigherBusyTraffic; ieee->link_detect_info.bHigherBusyRxTraffic = bHigherBusyRxTraffic; -if (ieee->state ==RTLLIB_LINKED && ieee->iw_mode ==IW_MODE_INFRA ) { +if (ieee->link_state ==RTLLIB_LINKED && ieee->iw_mode ==IW_MODE_INFRA ) {u32 TotalRxBcnNum =0 ;u32 TotalRxDataNum =0 ;
@@ -1263,7 +1263,7 @@ static void _rtl92e_watchdog_wq_cb(void *data)"===>%s(): AP is power off, chan:%d, connect another one\n" , __func__, priv->chan); - ieee->state =RTLLIB_ASSOCIATING ; + ieee->link_state =RTLLIB_ASSOCIATING ;RemovePeerTS (priv->rtllib, priv->rtllib->current_network.bssid);
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +8 -8
@@ -291,7 +291,7 @@ static void _rtl92e_dm_check_rate_adaptive(struct net_device *dev)if (priv->rtllib->mode !=WIRELESS_MODE_N_24G )return ; -if (priv->rtllib->state ==RTLLIB_LINKED ) { +if (priv->rtllib->link_state ==RTLLIB_LINKED ) { bshort_gi_enabled = (ht_info->cur_tx_bw40mhz && ht_info->bCurShortGI40MHz) || (!ht_info->cur_tx_bw40mhz &&
@@ -1075,7 +1075,7 @@ static void _rtl92e_dm_ctrl_initgain_byrssi_driver(struct net_device *dev) dm_digtable.dig_state =DM_STA_DIG_OFF ; } -if (priv->rtllib->state ==RTLLIB_LINKED ) +if (priv->rtllib->link_state ==RTLLIB_LINKED ) dm_digtable.cur_sta_connect_state =DIG_STA_CONNECT ;else dm_digtable.cur_sta_connect_state =DIG_STA_DISCONNECT ;
@@ -1105,7 +1105,7 @@ static void _rtl92e_dm_ctrl_initgain_byrssi_false_alarm(struct net_device *dev) dm_digtable.dig_algorithm_switch =0 ; } -if (priv->rtllib->state !=RTLLIB_LINKED ) +if (priv->rtllib->link_state !=RTLLIB_LINKED )return ; if ((priv->undecorated_smoothed_pwdb > dm_digtable.rssi_low_thresh) &&
@@ -1406,7 +1406,7 @@ static void _rtl92e_dm_check_edca_turbo(struct net_device *dev)if (priv->rtllib->iw_mode ==IW_MODE_ADHOC ) goto dm_CheckEdcaTurbo_EXIT; -if (priv->rtllib->state !=RTLLIB_LINKED ) +if (priv->rtllib->link_state !=RTLLIB_LINKED ) goto dm_CheckEdcaTurbo_EXIT;if (priv->rtllib->ht_info->iot_action &HT_IOT_ACT_DISABLE_EDCA_TURBO ) goto dm_CheckEdcaTurbo_EXIT;
@@ -1820,7 +1820,7 @@ static void _rtl92e_dm_fsync_timer_callback(struct timer_list *t)bool bSwitchFromCountDiff = false;bool bDoubleTimeInterval = false; -if (priv->rtllib->state ==RTLLIB_LINKED && +if (priv->rtllib->link_state ==RTLLIB_LINKED && priv->rtllib->bfsync_enable && (priv->rtllib->ht_info->iot_action &HT_IOT_ACT_CDD_FSYNC )) {u32 rate_bitmap;
@@ -1990,7 +1990,7 @@ static void _rtl92e_dm_check_fsync(struct net_device *dev)static u8 reg_c38_State = RegC38_Default;static u32 reset_cnt; -if (priv->rtllib->state ==RTLLIB_LINKED && +if (priv->rtllib->link_state ==RTLLIB_LINKED && priv->rtllib->ht_info->IOTPeer ==HT_IOT_PEER_BROADCOM ) {if (priv->rtllib->bfsync_enable ==0 ) {switch (priv->rtllib->fsync_state) {
@@ -2043,7 +2043,7 @@ static void _rtl92e_dm_check_fsync(struct net_device *dev)break ; } -if (priv->rtllib->state ==RTLLIB_LINKED ) { +if (priv->rtllib->link_state ==RTLLIB_LINKED ) {if (priv->undecorated_smoothed_pwdb <= RegC38_TH) { if (reg_c38_State !=
@@ -2112,7 +2112,7 @@ static void _rtl92e_dm_dynamic_tx_power(struct net_device *dev) txlowpower_threshold =TX_POWER_NEAR_FIELD_THRESH_LOW ; } -if (priv->rtllib->state ==RTLLIB_LINKED ) { +if (priv->rtllib->link_state ==RTLLIB_LINKED ) {if (priv->undecorated_smoothed_pwdb >= txhipower_threshold) { priv->dynamic_tx_high_pwr = true; priv->dynamic_tx_low_pwr = false;
drivers/staging/rtl8192e/rtl8192e/rtl_ethtool.c +2 -2
@@ -27,8 +27,8 @@ static u32 _rtl92e_ethtool_get_link(struct net_device *dev) {struct r8192_priv *priv =rtllib_priv (dev); -return ((priv->rtllib->state ==RTLLIB_LINKED ) || - (priv->rtllib->state ==RTLLIB_LINKED_SCANNING )); +return ((priv->rtllib->link_state ==RTLLIB_LINKED ) || + (priv->rtllib->link_state ==RTLLIB_LINKED_SCANNING )); }const struct ethtool_ops rtl819x_ethtool_ops = {
drivers/staging/rtl8192e/rtl8192e/rtl_ps.c +2 -2
@@ -118,7 +118,7 @@ void rtl92e_ips_enter(struct net_device *dev) rt_state = priv->rtllib->rf_power_state;if (rt_state == rf_on && !psc->bSwRfProcessing && - (priv->rtllib->state !=RTLLIB_LINKED ) && + (priv->rtllib->link_state !=RTLLIB_LINKED ) && (priv->rtllib->iw_mode !=IW_MODE_MASTER )) { psc->eInactivePowerState = rf_off;_rtl92e_ps_update_rf_state (dev);
@@ -209,7 +209,7 @@ void rtl92e_leisure_ps_enter(struct net_device *dev) &priv->rtllib->pwr_save_ctrl;if (!((priv->rtllib->iw_mode ==IW_MODE_INFRA ) && - (priv->rtllib->state ==RTLLIB_LINKED )) + (priv->rtllib->link_state ==RTLLIB_LINKED )) || (priv->rtllib->iw_mode ==IW_MODE_ADHOC ) || (priv->rtllib->iw_mode ==IW_MODE_MASTER ))return ;
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c +6 -6
@@ -169,7 +169,7 @@ static int _rtl92e_wx_adapter_power_status(struct net_device *dev, priv->ps_force = false; psc->bLeisurePs = true; }else { -if (priv->rtllib->state ==RTLLIB_LINKED ) +if (priv->rtllib->link_state ==RTLLIB_LINKED )rtl92e_leisure_ps_leave (dev); priv->ps_force = true;
@@ -375,10 +375,10 @@ static int _rtl92e_wx_set_scan(struct net_device *dev,int ret;if (!(ieee->softmac_features &IEEE_SOFTMAC_SCAN )) { -if ((ieee->state >=RTLLIB_ASSOCIATING ) && - (ieee->state <=RTLLIB_ASSOCIATING_AUTHENTICATED )) +if ((ieee->link_state >=RTLLIB_ASSOCIATING ) && + (ieee->link_state <=RTLLIB_ASSOCIATING_AUTHENTICATED ))return 0 ; -if ((priv->rtllib->state ==RTLLIB_LINKED ) && +if ((priv->rtllib->link_state ==RTLLIB_LINKED ) && (priv->rtllib->CntAfterLink <2 ))return 0 ; }
@@ -409,7 +409,7 @@ static int _rtl92e_wx_set_scan(struct net_device *dev, priv->rtllib->FirstIe_InScan = true; -if (priv->rtllib->state !=RTLLIB_LINKED ) { +if (priv->rtllib->link_state !=RTLLIB_LINKED ) {if (rt_state == rf_off) {if (priv->rtllib->rf_off_reason >RF_CHANGE_BY_IPS ) {
@@ -1124,7 +1124,7 @@ static struct iw_statistics *_rtl92e_get_wireless_stats(struct net_device *dev)int tmp_qual =0 ;int tmp_noise =0 ; -if (ieee->state <RTLLIB_LINKED ) { +if (ieee->link_state <RTLLIB_LINKED ) { wstats->qual.qual =10 ; wstats->qual.level =0 ; wstats->qual.noise =0x100 -100 ;/* -100 dBm */
drivers/staging/rtl8192e/rtllib.h +1 -1
@@ -1489,7 +1489,7 @@ struct rtllib_device {*/ struct rtllib_network current_network; -enum rtl_link_state state; +enum rtl_link_state link_state;int short_slot;int mode;/* A, B, G */
drivers/staging/rtl8192e/rtllib_rx.c +7 -7
@@ -1196,7 +1196,7 @@ static void rtllib_rx_check_leave_lps(struct rtllib_device *ieee, u8 unicast, u8 nr_subframes) {if (unicast) { -if (ieee->state ==RTLLIB_LINKED ) { +if (ieee->link_state ==RTLLIB_LINKED ) {if (((ieee->link_detect_info.NumRxUnicastOkInPeriod + ieee->link_detect_info.NumTxOkInPeriod) >8 ) || (ieee->link_detect_info.NumRxUnicastOkInPeriod >2 )) {
@@ -2117,7 +2117,7 @@ int rtllib_parse_info_param(struct rtllib_device *ieee, network->tim.tim_period = info_element->data[1 ]; network->dtim_period = info_element->data[1 ]; -if (ieee->state !=RTLLIB_LINKED ) +if (ieee->link_state !=RTLLIB_LINKED )break ; network->last_dtim_sta_time = jiffies;
@@ -2585,7 +2585,7 @@ static inline void rtllib_process_probe_response( ieee->current_network.buseprotection = false; }if (is_beacon (frame_ctl)) { -if (ieee->state >=RTLLIB_LINKED ) +if (ieee->link_state >=RTLLIB_LINKED ) ieee->link_detect_info.NumRecvBcnInPeriod++; } }
@@ -2643,7 +2643,7 @@ static inline void rtllib_process_probe_response( || ((ieee->current_network.ssid_len == network->ssid_len) && (strncmp(ieee->current_network.ssid, network->ssid, network->ssid_len) == 0) && - (ieee->state == RTLLIB_NOLINK)))) + (ieee->link_state == RTLLIB_NOLINK)))) renew =1 ;update_network (ieee, target, network);if (renew && (ieee->softmac_features &IEEE_SOFTMAC_ASSOCIATE ))
@@ -2654,7 +2654,7 @@ static inline void rtllib_process_probe_response(if (is_beacon (frame_ctl) &&is_same_network (&ieee->current_network, network, (network->ssid_len ?1 :0 )) && - (ieee->state ==RTLLIB_LINKED )) { + (ieee->link_state ==RTLLIB_LINKED )) { ieee->handle_beacon (ieee->dev, beacon, &ieee->current_network); } free_network:
@@ -2683,7 +2683,7 @@ static void rtllib_rx_mgt(struct rtllib_device *ieee,if (ieee->sta_sleep || (ieee->ps !=RTLLIB_PS_DISABLED && ieee->iw_mode ==IW_MODE_INFRA && - ieee->state ==RTLLIB_LINKED )) + ieee->link_state ==RTLLIB_LINKED ))schedule_work (&ieee->ps_task);break ;
@@ -2700,7 +2700,7 @@ static void rtllib_rx_mgt(struct rtllib_device *ieee,if ((ieee->softmac_features &IEEE_SOFTMAC_PROBERS ) && ((ieee->iw_mode ==IW_MODE_ADHOC || ieee->iw_mode ==IW_MODE_MASTER ) && - ieee->state ==RTLLIB_LINKED )) + ieee->link_state ==RTLLIB_LINKED ))rtllib_rx_probe_rq (ieee, skb);break ; }
drivers/staging/rtl8192e/rtllib_softmac.c +41 -41
300 lines not on this page · raw message
drivers/staging/rtl8192e/rtllib_softmac_wx.c +8 -8
@@ -53,7 +53,7 @@ int rtllib_wx_set_freq(struct rtllib_device *ieee, struct iw_request_info *a,if (ieee->iw_mode ==IW_MODE_ADHOC || ieee->iw_mode ==IW_MODE_MASTER ) -if (ieee->state ==RTLLIB_LINKED ) { +if (ieee->link_state ==RTLLIB_LINKED ) {rtllib_stop_send_beacons (ieee);rtllib_start_send_beacons (ieee); }
@@ -95,8 +95,8 @@ int rtllib_wx_get_wap(struct rtllib_device *ieee,/* We want avoid to give to the user inconsistent infos*/ spin_lock_irqsave (&ieee->lock, flags); -if (ieee->state !=RTLLIB_LINKED && - ieee->state !=RTLLIB_LINKED_SCANNING && +if (ieee->link_state !=RTLLIB_LINKED && + ieee->link_state !=RTLLIB_LINKED_SCANNING && ieee->wap_set ==0 )eth_zero_addr (wrqu->ap_addr.sa_data);
@@ -184,8 +184,8 @@ int rtllib_wx_get_essid(struct rtllib_device *ieee, struct iw_request_info *a, goto out; } -if (ieee->state !=RTLLIB_LINKED && - ieee->state !=RTLLIB_LINKED_SCANNING && +if (ieee->link_state !=RTLLIB_LINKED && + ieee->link_state !=RTLLIB_LINKED_SCANNING && ieee->ssid_set ==0 ) { ret =-1 ; goto out;
@@ -323,7 +323,7 @@ void rtllib_wx_sync_scan_wq(void *data)rtllib_stop_all_queues (ieee);rtllib_stop_send_beacons (ieee); - ieee->state =RTLLIB_LINKED_SCANNING ; + ieee->link_state =RTLLIB_LINKED_SCANNING ; ieee->link_change (ieee->dev);/* wait for ps packet to be kicked out successfully */ msleep (50 );
@@ -355,7 +355,7 @@ void rtllib_wx_sync_scan_wq(void *data) ieee->ScanOperationBackupHandler (ieee->dev,SCAN_OPT_RESTORE ); - ieee->state =RTLLIB_LINKED ; + ieee->link_state =RTLLIB_LINKED ; ieee->link_change (ieee->dev);/* Notify AP that I wake up again */
@@ -385,7 +385,7 @@ int rtllib_wx_set_scan(struct rtllib_device *ieee, struct iw_request_info *a, goto out; } -if (ieee->state ==RTLLIB_LINKED ) { +if (ieee->link_state ==RTLLIB_LINKED ) {schedule_work (&ieee->wx_sync_scan_wq);/* intentionally forget to up sem */ return 0 ;
drivers/staging/rtl8192e/rtllib_wx.c +1 -1
@@ -619,7 +619,7 @@ int rtllib_wx_set_mlme(struct rtllib_device *ieee,bool deauth = false;struct iw_mlme *mlme = (struct iw_mlme *)extra; -if (ieee->state !=RTLLIB_LINKED ) +if (ieee->link_state !=RTLLIB_LINKED )return -ENOLINK ;mutex_lock (&ieee->wx_mutex);
Signature · 1 line
2.40.1
PATCH 7/9 staging: rtl8192e: Rename RTLLIB_NOLINK to MAC80211_NOLINK
In reply to Philipp HortmannRename RTLLIB_NOLINK to MAC80211_NOLINK to align with rtlwifi driver.
--- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 2 +- drivers/staging/rtl8192e/rtllib_softmac.c | 34 ++++++++++---------- 4 files changed, 20 insertions(+), 20 deletions(-)
drivers/staging/rtl8192e/rtl8192e/rtl_core.c +1 -1
@@ -1192,7 +1192,7 @@ static void _rtl92e_watchdog_wq_cb(void *data)if (!rtllib_act_scanning (priv->rtllib, false)) {if ((ieee->iw_mode ==IW_MODE_INFRA ) && (ieee->link_state == -RTLLIB_NOLINK ) && +MAC80211_NOLINK ) && (ieee->rf_power_state == rf_on) && !ieee->is_set_key && (!ieee->proto_stoppping) && !ieee->wx_set_enc) { if ((ieee->pwr_save_ctrl.ReturnPoint ==
drivers/staging/rtl8192e/rtllib.h +1 -1
@@ -1121,7 +1121,7 @@ struct rtllib_network {enum rtl_link_state {/* the card is not linked at all */ -RTLLIB_NOLINK =0 , +MAC80211_NOLINK =0 ,/* RTLLIB_ASSOCIATING* are for BSS client mode * the driver shall not perform RX filtering unless
drivers/staging/rtl8192e/rtllib_rx.c +1 -1
@@ -2643,7 +2643,7 @@ static inline void rtllib_process_probe_response( || ((ieee->current_network.ssid_len == network->ssid_len) && (strncmp(ieee->current_network.ssid, network->ssid, network->ssid_len) == 0) && - (ieee->link_state == RTLLIB_NOLINK)))) + (ieee->link_state == MAC80211_NOLINK)))) renew =1 ;update_network (ieee, target, network);if (renew && (ieee->softmac_features &IEEE_SOFTMAC_ASSOCIATE ))
drivers/staging/rtl8192e/rtllib_softmac.c +17 -17
@@ -508,7 +508,7 @@ static void rtllib_softmac_scan_syncro(struct rtllib_device *ieee, u8 is_mesh)* performing a complete syncro scan before conclude * there are no interesting cell and to create a * new one. In this case the link state is -* RTLLIB_NOLINK until we found an interesting cell. +* MAC80211_NOLINK until we found an interesting cell. * If so the ieee8021_new_net, called by the RX path * will set the state to RTLLIB_LINKED, so we stop * scanning
@@ -1548,7 +1548,7 @@ inline void rtllib_softmac_new_net(struct rtllib_device *ieee,/* we are interested in new only if we are not associated * and we are not associating / authenticating */ -if (ieee->link_state !=RTLLIB_NOLINK ) +if (ieee->link_state !=MAC80211_NOLINK )return ; if ((ieee->iw_mode == IW_MODE_INFRA) && !(net->capability &
@@ -1682,7 +1682,7 @@ static void rtllib_softmac_check_all_nets(struct rtllib_device *ieee)* we had found what we are searching for */ -if (ieee->link_state !=RTLLIB_NOLINK ) +if (ieee->link_state !=MAC80211_NOLINK )break ; if (ieee->scan_age == 0 || time_after(target->last_scanned +
@@ -2495,7 +2495,7 @@ static void rtllib_start_ibss_wq(void *data) ieee->ssid_set =1 ; } - ieee->link_state =RTLLIB_NOLINK ; + ieee->link_state =MAC80211_NOLINK ; ieee->mode =WIRELESS_MODE_G ;/* check if we have this cell in our network list */ rtllib_softmac_check_all_nets (ieee);
@@ -2514,11 +2514,11 @@ static void rtllib_start_ibss_wq(void *data)* scan, that will stop at the first round because it sees the state * associated. */ -if (ieee->link_state ==RTLLIB_NOLINK ) +if (ieee->link_state ==MAC80211_NOLINK )rtllib_start_scan_syncro (ieee,0 );/* the network definitively is not here.. create a new cell */ -if (ieee->link_state ==RTLLIB_NOLINK ) { +if (ieee->link_state ==MAC80211_NOLINK ) {netdev_info (ieee->dev,"creating new IBSS cell\n" ); ieee->current_network.channel = ieee->bss_start_channel;if (!ieee->wap_set)
@@ -2623,7 +2623,7 @@ static void rtllib_start_bss(struct rtllib_device *ieee)*/ spin_lock_irqsave (&ieee->lock, flags); -if (ieee->link_state ==RTLLIB_NOLINK ) +if (ieee->link_state ==MAC80211_NOLINK )rtllib_start_scan (ieee);spin_unlock_irqrestore (&ieee->lock, flags); }
@@ -2643,7 +2643,7 @@ void rtllib_disassociate(struct rtllib_device *ieee)if (IS_DOT11D_ENABLE (ieee))dot11d_reset (ieee); - ieee->link_state =RTLLIB_NOLINK ; + ieee->link_state =MAC80211_NOLINK ; ieee->is_set_key = false; ieee->wap_set =0 ;
@@ -2665,11 +2665,11 @@ static void rtllib_associate_retry_wq(void *data)if (ieee->link_state !=RTLLIB_ASSOCIATING_RETRY ) goto exit; -/* until we do not set the state to RTLLIB_NOLINK +/* until we do not set the state to MAC80211_NOLINK * there are no possibility to have someone else trying * to start an association procedure (we get here with * ieee->link_state = RTLLIB_ASSOCIATING). -* When we set the state to RTLLIB_NOLINK it is possible +* When we set the state to MAC80211_NOLINK it is possible * that the RX path run an attempt to associate, but * both rtllib_softmac_check_all_nets and the * RX path works with ieee->lock held so there are no
@@ -2679,13 +2679,13 @@ static void rtllib_associate_retry_wq(void *data)* state and we are going to start the scan. */ ieee->beinretry = true; - ieee->link_state =RTLLIB_NOLINK ; + ieee->link_state =MAC80211_NOLINK ;rtllib_softmac_check_all_nets (ieee);spin_lock_irqsave (&ieee->lock, flags); -if (ieee->link_state ==RTLLIB_NOLINK ) +if (ieee->link_state ==MAC80211_NOLINK )rtllib_start_scan (ieee);spin_unlock_irqrestore (&ieee->lock, flags);
@@ -2763,7 +2763,7 @@ void rtllib_stop_protocol(struct rtllib_device *ieee, u8 shutdown)rtllib_stop_scan (ieee);if (ieee->link_state <=RTLLIB_ASSOCIATING_AUTHENTICATED ) - ieee->link_state =RTLLIB_NOLINK ; + ieee->link_state =MAC80211_NOLINK ;if (ieee->link_state ==RTLLIB_LINKED ) {if (ieee->iw_mode ==IW_MODE_INFRA )
@@ -2845,7 +2845,7 @@ int rtllib_softmac_init(struct rtllib_device *ieee)memset (&ieee->current_network,0 ,sizeof (struct rtllib_network )); - ieee->link_state =RTLLIB_NOLINK ; + ieee->link_state =MAC80211_NOLINK ;for (i =0 ; i <5 ; i++) ieee->seq_ctrl[i] =0 ; ieee->dot11d_info =kzalloc (sizeof (struct rt_dot11d_info ),GFP_ATOMIC );
@@ -3036,7 +3036,7 @@ static void rtllib_MgntDisconnectIBSS(struct rtllib_device *rtllib)u8 i;bool bFilterOutNonAssociatedBSSID = false; - rtllib->link_state =RTLLIB_NOLINK ; + rtllib->link_state =MAC80211_NOLINK ;for (i =0 ; i <6 ; i++) rtllib->current_network.bssid[i] =0x55 ;
@@ -3063,7 +3063,7 @@ static void rtllib_MlmeDisassociateRequest(struct rtllib_device *rtllib,RemovePeerTS (rtllib, asSta);if (memcmp (rtllib->current_network.bssid, asSta,6 ) ==0 ) { - rtllib->link_state =RTLLIB_NOLINK ; + rtllib->link_state =MAC80211_NOLINK ;for (i =0 ; i <6 ; i++) rtllib->current_network.bssid[i] =0x22 ;
@@ -3092,7 +3092,7 @@ rtllib_MgntDisconnectAP(rtllib_MlmeDisassociateRequest (rtllib, rtllib->current_network.bssid, asRsn); - rtllib->link_state =RTLLIB_NOLINK ; + rtllib->link_state =MAC80211_NOLINK ; }bool rtllib_MgntDisconnect (struct rtllib_device *rtllib,u8 asRsn)
Signature · 1 line
2.40.1
PATCH 8/9 staging: rtl8192e: Rename RTLLIB_LINKED to MAC80211_LINKED
In reply to Philipp HortmannRename RTLLIB_LINKED to MAC80211_LINKED to align with rtlwifi driver.
--- .../staging/rtl8192e/rtl8192e/r8192E_dev.c | 10 +++---- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 30 +++++++++---------- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 16 +++++----- .../staging/rtl8192e/rtl8192e/rtl_ethtool.c | 2 +- drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 4 +-- drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 8 ++--- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 12 ++++---- drivers/staging/rtl8192e/rtllib_softmac.c | 28 ++++++++--------- drivers/staging/rtl8192e/rtllib_softmac_wx.c | 10 +++---- drivers/staging/rtl8192e/rtllib_wx.c | 2 +- 11 files changed, 62 insertions(+), 62 deletions(-)
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +5 -5
@@ -52,15 +52,15 @@ static void _rtl92e_update_msr(struct net_device *dev)switch (priv->rtllib->iw_mode) {case IW_MODE_INFRA : -if (priv->rtllib->link_state ==RTLLIB_LINKED ) +if (priv->rtllib->link_state ==MAC80211_LINKED ) msr |=MSR_LINK_MANAGED ;break ;case IW_MODE_ADHOC : -if (priv->rtllib->link_state ==RTLLIB_LINKED ) +if (priv->rtllib->link_state ==MAC80211_LINKED ) msr |=MSR_LINK_ADHOC ;break ;case IW_MODE_MASTER : -if (priv->rtllib->link_state ==RTLLIB_LINKED ) +if (priv->rtllib->link_state ==MAC80211_LINKED ) msr |=MSR_LINK_MASTER ;break ;default :
@@ -745,7 +745,7 @@ void rtl92e_link_change(struct net_device *dev)if (!priv->up)return ; -if (ieee->link_state ==RTLLIB_LINKED ) { +if (ieee->link_state ==MAC80211_LINKED ) {_rtl92e_net_update (dev);rtl92e_update_ratr_table (dev); if ((ieee->pairwise_key_type == KEY_TYPE_WEP40) ||
@@ -760,7 +760,7 @@ void rtl92e_link_change(struct net_device *dev)u32 reg; reg =rtl92e_readl (dev,RCR ); -if (priv->rtllib->link_state ==RTLLIB_LINKED ) { +if (priv->rtllib->link_state ==MAC80211_LINKED ) {if (ieee->intel_promiscuous_md_info.promiscuous_on) ;else
drivers/staging/rtl8192e/rtl8192e/rtl_core.c +15 -15
@@ -169,7 +169,7 @@ bool rtl92e_set_rf_state(struct net_device *dev, (priv->rtllib->iw_mode == IW_MODE_ADHOC)) {if ((priv->rtllib->rf_off_reason >RF_CHANGE_BY_IPS ) || (change_source >RF_CHANGE_BY_IPS )) { -if (ieee->link_state ==RTLLIB_LINKED ) +if (ieee->link_state ==MAC80211_LINKED ) priv->blinked_ingpio = true;else priv->blinked_ingpio = false;
@@ -327,7 +327,7 @@ static void _rtl92e_qos_activate(void *data)int i;mutex_lock (&priv->mutex); -if (priv->rtllib->link_state !=RTLLIB_LINKED ) +if (priv->rtllib->link_state !=MAC80211_LINKED ) goto success;for (i =0 ; i <QOS_QUEUE_NUM ; i++)
@@ -344,7 +344,7 @@ static int _rtl92e_qos_handle_probe_response(struct r8192_priv *priv,int ret =0 ;u32 size =sizeof (struct rtllib_qos_parameters ); -if (priv->rtllib->link_state !=RTLLIB_LINKED ) +if (priv->rtllib->link_state !=MAC80211_LINKED )return ret;if (priv->rtllib->iw_mode !=IW_MODE_INFRA )
@@ -400,7 +400,7 @@ static int _rtl92e_qos_assoc_resp(struct r8192_priv *priv,if (!priv || !network)return 0 ; -if (priv->rtllib->link_state !=RTLLIB_LINKED ) +if (priv->rtllib->link_state !=MAC80211_LINKED )return 0 ;if (priv->rtllib->iw_mode !=IW_MODE_INFRA )
@@ -635,7 +635,7 @@ static int _rtl92e_sta_up(struct net_device *dev, bool is_silent_reset)if (priv->polling_timer_on ==0 )rtl92e_check_rfctrl_gpio_timer (&priv->gpio_polling_timer); -if (priv->rtllib->link_state !=RTLLIB_LINKED ) +if (priv->rtllib->link_state !=MAC80211_LINKED )rtllib_softmac_start_protocol (priv->rtllib,0 );rtllib_reset_queue (priv->rtllib);_rtl92e_watchdog_timer_cb (&priv->watch_dog_timer);
@@ -660,7 +660,7 @@ static int _rtl92e_sta_down(struct net_device *dev, bool shutdownrf) priv->rtllib->rtllib_ips_leave (dev); -if (priv->rtllib->link_state ==RTLLIB_LINKED ) +if (priv->rtllib->link_state ==MAC80211_LINKED )rtl92e_leisure_ps_leave (dev); priv->up =0 ;
@@ -1009,7 +1009,7 @@ static enum reset_type _rtl92e_if_check_reset(struct net_device *dev)if (rfState == rf_on && (priv->rtllib->iw_mode ==IW_MODE_INFRA ) && - (priv->rtllib->link_state ==RTLLIB_LINKED )) + (priv->rtllib->link_state ==MAC80211_LINKED )) RxResetType =_rtl92e_rx_check_stuck (dev); if (TxResetType == RESET_TYPE_NORMAL ||
@@ -1051,7 +1051,7 @@ static void _rtl92e_if_silent_reset(struct net_device *dev)mutex_lock (&priv->wx_mutex); -if (priv->rtllib->link_state ==RTLLIB_LINKED ) +if (priv->rtllib->link_state ==MAC80211_LINKED )rtl92e_leisure_ps_leave (dev);if (priv->up) {
@@ -1073,9 +1073,9 @@ static void _rtl92e_if_silent_reset(struct net_device *dev)rtl92e_dm_deinit (dev);rtllib_stop_scan_syncro (ieee); -if (ieee->link_state ==RTLLIB_LINKED ) { +if (ieee->link_state ==MAC80211_LINKED ) {mutex_lock (&ieee->wx_mutex); -netdev_info (dev,"ieee->link_state is RTLLIB_LINKED\n" ); +netdev_info (dev,"ieee->link_state is MAC80211_LINKED\n" );rtllib_stop_send_beacons (priv->rtllib);del_timer_sync (&ieee->associate_timer);cancel_delayed_work (&ieee->associate_retry_wq);
@@ -1110,14 +1110,14 @@ static void _rtl92e_if_silent_reset(struct net_device *dev)rtl92e_enable_hw_security_config (dev); -if (ieee->link_state ==RTLLIB_LINKED && ieee->iw_mode == +if (ieee->link_state ==MAC80211_LINKED && ieee->iw_mode ==IW_MODE_INFRA ) { ieee->set_chan (ieee->dev, ieee->current_network.channel);schedule_work (&ieee->associate_complete_wq); - }else if (ieee->link_state ==RTLLIB_LINKED && ieee->iw_mode == + }else if (ieee->link_state ==MAC80211_LINKED && ieee->iw_mode ==IW_MODE_ADHOC ) { ieee->set_chan (ieee->dev, ieee->current_network.channel);
@@ -1181,7 +1181,7 @@ static void _rtl92e_watchdog_wq_cb(void *data)if (!priv->up || priv->hw_radio_off)return ; -if (priv->rtllib->link_state >=RTLLIB_LINKED ) { +if (priv->rtllib->link_state >=MAC80211_LINKED ) {if (priv->rtllib->CntAfterLink <2 ) priv->rtllib->CntAfterLink++; }else {
@@ -1202,7 +1202,7 @@ static void _rtl92e_watchdog_wq_cb(void *data) } } } -if ((ieee->link_state ==RTLLIB_LINKED ) && (ieee->iw_mode == +if ((ieee->link_state ==MAC80211_LINKED ) && (ieee->iw_mode ==IW_MODE_INFRA ) && (!ieee->net_promiscuous_md)) {if (ieee->link_detect_info.NumRxOkInPeriod >100 || ieee->link_detect_info.NumTxOkInPeriod >100 )
@@ -1244,7 +1244,7 @@ static void _rtl92e_watchdog_wq_cb(void *data) ieee->link_detect_info.bHigherBusyTraffic = bHigherBusyTraffic; ieee->link_detect_info.bHigherBusyRxTraffic = bHigherBusyRxTraffic; -if (ieee->link_state ==RTLLIB_LINKED && ieee->iw_mode ==IW_MODE_INFRA ) { +if (ieee->link_state ==MAC80211_LINKED && ieee->iw_mode ==IW_MODE_INFRA ) {u32 TotalRxBcnNum =0 ;u32 TotalRxDataNum =0 ;
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +8 -8
@@ -291,7 +291,7 @@ static void _rtl92e_dm_check_rate_adaptive(struct net_device *dev)if (priv->rtllib->mode !=WIRELESS_MODE_N_24G )return ; -if (priv->rtllib->link_state ==RTLLIB_LINKED ) { +if (priv->rtllib->link_state ==MAC80211_LINKED ) { bshort_gi_enabled = (ht_info->cur_tx_bw40mhz && ht_info->bCurShortGI40MHz) || (!ht_info->cur_tx_bw40mhz &&
@@ -1075,7 +1075,7 @@ static void _rtl92e_dm_ctrl_initgain_byrssi_driver(struct net_device *dev) dm_digtable.dig_state =DM_STA_DIG_OFF ; } -if (priv->rtllib->link_state ==RTLLIB_LINKED ) +if (priv->rtllib->link_state ==MAC80211_LINKED ) dm_digtable.cur_sta_connect_state =DIG_STA_CONNECT ;else dm_digtable.cur_sta_connect_state =DIG_STA_DISCONNECT ;
@@ -1105,7 +1105,7 @@ static void _rtl92e_dm_ctrl_initgain_byrssi_false_alarm(struct net_device *dev) dm_digtable.dig_algorithm_switch =0 ; } -if (priv->rtllib->link_state !=RTLLIB_LINKED ) +if (priv->rtllib->link_state !=MAC80211_LINKED )return ; if ((priv->undecorated_smoothed_pwdb > dm_digtable.rssi_low_thresh) &&
@@ -1406,7 +1406,7 @@ static void _rtl92e_dm_check_edca_turbo(struct net_device *dev)if (priv->rtllib->iw_mode ==IW_MODE_ADHOC ) goto dm_CheckEdcaTurbo_EXIT; -if (priv->rtllib->link_state !=RTLLIB_LINKED ) +if (priv->rtllib->link_state !=MAC80211_LINKED ) goto dm_CheckEdcaTurbo_EXIT;if (priv->rtllib->ht_info->iot_action &HT_IOT_ACT_DISABLE_EDCA_TURBO ) goto dm_CheckEdcaTurbo_EXIT;
@@ -1820,7 +1820,7 @@ static void _rtl92e_dm_fsync_timer_callback(struct timer_list *t)bool bSwitchFromCountDiff = false;bool bDoubleTimeInterval = false; -if (priv->rtllib->link_state ==RTLLIB_LINKED && +if (priv->rtllib->link_state ==MAC80211_LINKED && priv->rtllib->bfsync_enable && (priv->rtllib->ht_info->iot_action &HT_IOT_ACT_CDD_FSYNC )) {u32 rate_bitmap;
@@ -1990,7 +1990,7 @@ static void _rtl92e_dm_check_fsync(struct net_device *dev)static u8 reg_c38_State = RegC38_Default;static u32 reset_cnt; -if (priv->rtllib->link_state ==RTLLIB_LINKED && +if (priv->rtllib->link_state ==MAC80211_LINKED && priv->rtllib->ht_info->IOTPeer ==HT_IOT_PEER_BROADCOM ) {if (priv->rtllib->bfsync_enable ==0 ) {switch (priv->rtllib->fsync_state) {
@@ -2043,7 +2043,7 @@ static void _rtl92e_dm_check_fsync(struct net_device *dev)break ; } -if (priv->rtllib->link_state ==RTLLIB_LINKED ) { +if (priv->rtllib->link_state ==MAC80211_LINKED ) {if (priv->undecorated_smoothed_pwdb <= RegC38_TH) { if (reg_c38_State !=
@@ -2112,7 +2112,7 @@ static void _rtl92e_dm_dynamic_tx_power(struct net_device *dev) txlowpower_threshold =TX_POWER_NEAR_FIELD_THRESH_LOW ; } -if (priv->rtllib->link_state ==RTLLIB_LINKED ) { +if (priv->rtllib->link_state ==MAC80211_LINKED ) {if (priv->undecorated_smoothed_pwdb >= txhipower_threshold) { priv->dynamic_tx_high_pwr = true; priv->dynamic_tx_low_pwr = false;
drivers/staging/rtl8192e/rtl8192e/rtl_ethtool.c +1 -1
@@ -27,7 +27,7 @@ static u32 _rtl92e_ethtool_get_link(struct net_device *dev) {struct r8192_priv *priv =rtllib_priv (dev); -return ((priv->rtllib->link_state ==RTLLIB_LINKED ) || +return ((priv->rtllib->link_state ==MAC80211_LINKED ) || (priv->rtllib->link_state ==RTLLIB_LINKED_SCANNING )); }
drivers/staging/rtl8192e/rtl8192e/rtl_ps.c +2 -2
@@ -118,7 +118,7 @@ void rtl92e_ips_enter(struct net_device *dev) rt_state = priv->rtllib->rf_power_state;if (rt_state == rf_on && !psc->bSwRfProcessing && - (priv->rtllib->link_state !=RTLLIB_LINKED ) && + (priv->rtllib->link_state !=MAC80211_LINKED ) && (priv->rtllib->iw_mode !=IW_MODE_MASTER )) { psc->eInactivePowerState = rf_off;_rtl92e_ps_update_rf_state (dev);
@@ -209,7 +209,7 @@ void rtl92e_leisure_ps_enter(struct net_device *dev) &priv->rtllib->pwr_save_ctrl;if (!((priv->rtllib->iw_mode ==IW_MODE_INFRA ) && - (priv->rtllib->link_state ==RTLLIB_LINKED )) + (priv->rtllib->link_state ==MAC80211_LINKED )) || (priv->rtllib->iw_mode ==IW_MODE_ADHOC ) || (priv->rtllib->iw_mode ==IW_MODE_MASTER ))return ;
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c +4 -4
@@ -169,7 +169,7 @@ static int _rtl92e_wx_adapter_power_status(struct net_device *dev, priv->ps_force = false; psc->bLeisurePs = true; }else { -if (priv->rtllib->link_state ==RTLLIB_LINKED ) +if (priv->rtllib->link_state ==MAC80211_LINKED )rtl92e_leisure_ps_leave (dev); priv->ps_force = true;
@@ -378,7 +378,7 @@ static int _rtl92e_wx_set_scan(struct net_device *dev,if ((ieee->link_state >=RTLLIB_ASSOCIATING ) && (ieee->link_state <=RTLLIB_ASSOCIATING_AUTHENTICATED ))return 0 ; -if ((priv->rtllib->link_state ==RTLLIB_LINKED ) && +if ((priv->rtllib->link_state ==MAC80211_LINKED ) && (priv->rtllib->CntAfterLink <2 ))return 0 ; }
@@ -409,7 +409,7 @@ static int _rtl92e_wx_set_scan(struct net_device *dev, priv->rtllib->FirstIe_InScan = true; -if (priv->rtllib->link_state !=RTLLIB_LINKED ) { +if (priv->rtllib->link_state !=MAC80211_LINKED ) {if (rt_state == rf_off) {if (priv->rtllib->rf_off_reason >RF_CHANGE_BY_IPS ) {
@@ -1124,7 +1124,7 @@ static struct iw_statistics *_rtl92e_get_wireless_stats(struct net_device *dev)int tmp_qual =0 ;int tmp_noise =0 ; -if (ieee->link_state <RTLLIB_LINKED ) { +if (ieee->link_state <MAC80211_LINKED ) { wstats->qual.qual =10 ; wstats->qual.level =0 ; wstats->qual.noise =0x100 -100 ;/* -100 dBm */
drivers/staging/rtl8192e/rtllib.h +1 -1
@@ -1146,7 +1146,7 @@ enum rtl_link_state {/* the link is ok. the card associated to a BSS or linked * to a ibss cell or acting as an AP and creating the bss */ - RTLLIB_LINKED, + MAC80211_LINKED,/* same as LINKED, but the driver shall apply RX filter * rules as we are in NO_LINK mode. As the card is still
drivers/staging/rtl8192e/rtllib_rx.c +6 -6
@@ -1196,7 +1196,7 @@ static void rtllib_rx_check_leave_lps(struct rtllib_device *ieee, u8 unicast, u8 nr_subframes) {if (unicast) { -if (ieee->link_state ==RTLLIB_LINKED ) { +if (ieee->link_state ==MAC80211_LINKED ) {if (((ieee->link_detect_info.NumRxUnicastOkInPeriod + ieee->link_detect_info.NumTxOkInPeriod) >8 ) || (ieee->link_detect_info.NumRxUnicastOkInPeriod >2 )) {
@@ -2117,7 +2117,7 @@ int rtllib_parse_info_param(struct rtllib_device *ieee, network->tim.tim_period = info_element->data[1 ]; network->dtim_period = info_element->data[1 ]; -if (ieee->link_state !=RTLLIB_LINKED ) +if (ieee->link_state !=MAC80211_LINKED )break ; network->last_dtim_sta_time = jiffies;
@@ -2585,7 +2585,7 @@ static inline void rtllib_process_probe_response( ieee->current_network.buseprotection = false; }if (is_beacon (frame_ctl)) { -if (ieee->link_state >=RTLLIB_LINKED ) +if (ieee->link_state >=MAC80211_LINKED ) ieee->link_detect_info.NumRecvBcnInPeriod++; } }
@@ -2654,7 +2654,7 @@ static inline void rtllib_process_probe_response(if (is_beacon (frame_ctl) &&is_same_network (&ieee->current_network, network, (network->ssid_len ?1 :0 )) && - (ieee->link_state ==RTLLIB_LINKED )) { + (ieee->link_state ==MAC80211_LINKED )) { ieee->handle_beacon (ieee->dev, beacon, &ieee->current_network); } free_network:
@@ -2683,7 +2683,7 @@ static void rtllib_rx_mgt(struct rtllib_device *ieee,if (ieee->sta_sleep || (ieee->ps !=RTLLIB_PS_DISABLED && ieee->iw_mode ==IW_MODE_INFRA && - ieee->link_state ==RTLLIB_LINKED )) + ieee->link_state ==MAC80211_LINKED ))schedule_work (&ieee->ps_task);break ;
@@ -2700,7 +2700,7 @@ static void rtllib_rx_mgt(struct rtllib_device *ieee,if ((ieee->softmac_features &IEEE_SOFTMAC_PROBERS ) && ((ieee->iw_mode ==IW_MODE_ADHOC || ieee->iw_mode ==IW_MODE_MASTER ) && - ieee->link_state ==RTLLIB_LINKED )) + ieee->link_state ==MAC80211_LINKED ))rtllib_rx_probe_rq (ieee, skb);break ; }
drivers/staging/rtl8192e/rtllib_softmac.c +14 -14
@@ -510,7 +510,7 @@ static void rtllib_softmac_scan_syncro(struct rtllib_device *ieee, u8 is_mesh)* new one. In this case the link state is * MAC80211_NOLINK until we found an interesting cell. * If so the ieee8021_new_net, called by the RX path -* will set the state to RTLLIB_LINKED, so we stop +* will set the state to MAC80211_LINKED, so we stop * scanning * 2- We are linked and the root uses run iwlist scan. * So we switch to RTLLIB_LINKED_SCANNING to remember
@@ -522,7 +522,7 @@ static void rtllib_softmac_scan_syncro(struct rtllib_device *ieee, u8 is_mesh)* if the state become LINKED because of the #1 situation */ -if (ieee->link_state ==RTLLIB_LINKED ) +if (ieee->link_state ==MAC80211_LINKED ) goto out;if (ieee->sync_scan_hurryup) { netdev_info(ieee->dev,
@@ -543,7 +543,7 @@ static void rtllib_softmac_scan_syncro(struct rtllib_device *ieee, u8 is_mesh) ieee->actscanning = false; ieee->sync_scan_hurryup =0 ; -if (ieee->link_state >=RTLLIB_LINKED ) { +if (ieee->link_state >=MAC80211_LINKED ) {if (IS_DOT11D_ENABLE (ieee))dot11d_scan_complete (ieee); }
@@ -1508,7 +1508,7 @@ static void rtllib_associate_complete(struct rtllib_device *ieee) {del_timer_sync (&ieee->associate_timer); - ieee->link_state =RTLLIB_LINKED ; + ieee->link_state =MAC80211_LINKED ;rtllib_sta_send_associnfo (ieee);schedule_work (&ieee->associate_complete_wq);
@@ -1664,7 +1664,7 @@ inline void rtllib_softmac_new_net(struct rtllib_device *ieee, "Using B rates\n"); }memset (ieee->dot11ht_oper_rate_set,0 ,16 ); - ieee->link_state =RTLLIB_LINKED ; + ieee->link_state =MAC80211_LINKED ; } } }
@@ -1985,7 +1985,7 @@ static inline void rtllib_sta_ps(struct work_struct *work)if ((ieee->ps ==RTLLIB_PS_DISABLED || ieee->iw_mode !=IW_MODE_INFRA || - ieee->link_state !=RTLLIB_LINKED )) { + ieee->link_state !=MAC80211_LINKED )) {spin_lock_irqsave (&ieee->mgmt_tx_lock, flags2);rtllib_sta_wakeup (ieee,1 );
@@ -2149,7 +2149,7 @@ rtllib_rx_assoc_resp(struct rtllib_device *ieee, struct sk_buff *skb,if (!network)return 1 ; - ieee->link_state =RTLLIB_LINKED ; + ieee->link_state =MAC80211_LINKED ; ieee->assoc_id = aid; ieee->softmac_stats.rx_ass_ok++;/* station support qos */
@@ -2283,7 +2283,7 @@ rtllib_rx_deauth(struct rtllib_device *ieee, struct sk_buff *skb)* both for disassociation and deauthentication */ if ((ieee->softmac_features &IEEE_SOFTMAC_ASSOCIATE ) && - ieee->link_state ==RTLLIB_LINKED && + ieee->link_state ==MAC80211_LINKED && (ieee->iw_mode ==IW_MODE_INFRA )) { frame_ctl =le16_to_cpu (header->frame_ctl); netdev_info(ieee->dev,
@@ -2458,7 +2458,7 @@ static void rtllib_start_master_bss(struct rtllib_device *ieee)ether_addr_copy (ieee->current_network.bssid, ieee->dev->dev_addr); ieee->set_chan (ieee->dev, ieee->current_network.channel); - ieee->link_state =RTLLIB_LINKED ; + ieee->link_state =MAC80211_LINKED ; ieee->link_change (ieee->dev);notify_wx_assoc_event (ieee);netif_carrier_on (ieee->dev);
@@ -2509,7 +2509,7 @@ static void rtllib_start_ibss_wq(void *data)* (in bss mode we had to make sure no-one tried to associate when * we had just checked the ieee->link_state and we was going to start the * scan) because in ibss mode the rtllib_new_net function, when -* finds a good net, just set the ieee->link_state to RTLLIB_LINKED, +* finds a good net, just set the ieee->link_state to MAC80211_LINKED, * so, at worst, we waste a bit of time to initiate an unneeded syncro * scan, that will stop at the first round because it sees the state * associated.
@@ -2581,7 +2581,7 @@ static void rtllib_start_ibss_wq(void *data) ieee->SetHwRegHandler (ieee->dev,HW_VAR_MEDIA_STATUS , (u8 *)(&ieee->link_state)); - ieee->link_state =RTLLIB_LINKED ; + ieee->link_state =MAC80211_LINKED ; ieee->link_change (ieee->dev);HTSetConnectBwMode (ieee,HT_CHANNEL_WIDTH_20 ,HT_EXTCHNL_OFFSET_NO_EXT );
@@ -2765,7 +2765,7 @@ void rtllib_stop_protocol(struct rtllib_device *ieee, u8 shutdown)if (ieee->link_state <=RTLLIB_ASSOCIATING_AUTHENTICATED ) ieee->link_state =MAC80211_NOLINK ; -if (ieee->link_state ==RTLLIB_LINKED ) { +if (ieee->link_state ==MAC80211_LINKED ) {if (ieee->iw_mode ==IW_MODE_INFRA )SendDisassociation (ieee,1 ,WLAN_REASON_DEAUTH_LEAVING );rtllib_disassociate (ieee);
@@ -3100,7 +3100,7 @@ bool rtllib_MgntDisconnect(struct rtllib_device *rtllib, u8 asRsn)if (rtllib->ps !=RTLLIB_PS_DISABLED ) rtllib->sta_wake_up (rtllib->dev); -if (rtllib->link_state ==RTLLIB_LINKED ) { +if (rtllib->link_state ==MAC80211_LINKED ) {if (rtllib->iw_mode ==IW_MODE_ADHOC )rtllib_MgntDisconnectIBSS (rtllib);if (rtllib->iw_mode ==IW_MODE_INFRA )
@@ -3119,7 +3119,7 @@ void notify_wx_assoc_event(struct rtllib_device *ieee)return ; wrqu.ap_addr.sa_family =ARPHRD_ETHER ; -if (ieee->link_state ==RTLLIB_LINKED ) +if (ieee->link_state ==MAC80211_LINKED )memcpy (wrqu.ap_addr.sa_data, ieee->current_network.bssid,ETH_ALEN );else {
drivers/staging/rtl8192e/rtllib_softmac_wx.c +5 -5
@@ -53,7 +53,7 @@ int rtllib_wx_set_freq(struct rtllib_device *ieee, struct iw_request_info *a,if (ieee->iw_mode ==IW_MODE_ADHOC || ieee->iw_mode ==IW_MODE_MASTER ) -if (ieee->link_state ==RTLLIB_LINKED ) { +if (ieee->link_state ==MAC80211_LINKED ) {rtllib_stop_send_beacons (ieee);rtllib_start_send_beacons (ieee); }
@@ -95,7 +95,7 @@ int rtllib_wx_get_wap(struct rtllib_device *ieee,/* We want avoid to give to the user inconsistent infos*/ spin_lock_irqsave (&ieee->lock, flags); -if (ieee->link_state !=RTLLIB_LINKED && +if (ieee->link_state !=MAC80211_LINKED && ieee->link_state !=RTLLIB_LINKED_SCANNING && ieee->wap_set ==0 )
@@ -184,7 +184,7 @@ int rtllib_wx_get_essid(struct rtllib_device *ieee, struct iw_request_info *a, goto out; } -if (ieee->link_state !=RTLLIB_LINKED && +if (ieee->link_state !=MAC80211_LINKED && ieee->link_state !=RTLLIB_LINKED_SCANNING && ieee->ssid_set ==0 ) { ret =-1 ;
@@ -355,7 +355,7 @@ void rtllib_wx_sync_scan_wq(void *data) ieee->ScanOperationBackupHandler (ieee->dev,SCAN_OPT_RESTORE ); - ieee->link_state =RTLLIB_LINKED ; + ieee->link_state =MAC80211_LINKED ; ieee->link_change (ieee->dev);/* Notify AP that I wake up again */
@@ -385,7 +385,7 @@ int rtllib_wx_set_scan(struct rtllib_device *ieee, struct iw_request_info *a, goto out; } -if (ieee->link_state ==RTLLIB_LINKED ) { +if (ieee->link_state ==MAC80211_LINKED ) {schedule_work (&ieee->wx_sync_scan_wq);/* intentionally forget to up sem */ return 0 ;
drivers/staging/rtl8192e/rtllib_wx.c +1 -1
@@ -619,7 +619,7 @@ int rtllib_wx_set_mlme(struct rtllib_device *ieee,bool deauth = false;struct iw_mlme *mlme = (struct iw_mlme *)extra; -if (ieee->link_state !=RTLLIB_LINKED ) +if (ieee->link_state !=MAC80211_LINKED )return -ENOLINK ;mutex_lock (&ieee->wx_mutex);
Signature · 1 line
2.40.1
PATCH 9/9 staging: rtl8192e: Rename RTLLIB_LINKED_SCANNING
In reply to Philipp HortmannRename RTLLIB_LINKED_SCANNING to MAC80211_LINKED_SCANNING to align with rtlwifi driver.
--- drivers/staging/rtl8192e/rtl8192e/rtl_ethtool.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- drivers/staging/rtl8192e/rtllib_softmac_wx.c | 6 +++--- 4 files changed, 6 insertions(+), 6 deletions(-)
drivers/staging/rtl8192e/rtl8192e/rtl_ethtool.c +1 -1
@@ -28,7 +28,7 @@ static u32 _rtl92e_ethtool_get_link(struct net_device *dev)struct r8192_priv *priv =rtllib_priv (dev);return ((priv->rtllib->link_state ==MAC80211_LINKED ) || - (priv->rtllib->link_state ==RTLLIB_LINKED_SCANNING )); + (priv->rtllib->link_state ==MAC80211_LINKED_SCANNING )); }const struct ethtool_ops rtl819x_ethtool_ops = {
drivers/staging/rtl8192e/rtllib.h +1 -1
@@ -1153,7 +1153,7 @@ enum rtl_link_state {* logically linked, but it is doing a syncro site survey * then it will be back to LINKED state. */ - RTLLIB_LINKED_SCANNING, + MAC80211_LINKED_SCANNING, };#define DEFAULT_MAX_SCAN_AGE (15 * HZ)
drivers/staging/rtl8192e/rtllib_softmac.c +1 -1
@@ -513,7 +513,7 @@ static void rtllib_softmac_scan_syncro(struct rtllib_device *ieee, u8 is_mesh)* will set the state to MAC80211_LINKED, so we stop * scanning * 2- We are linked and the root uses run iwlist scan. -* So we switch to RTLLIB_LINKED_SCANNING to remember +* So we switch to MAC80211_LINKED_SCANNING to remember * that we are still logically linked (not interested in * new network events, despite for updating the net list, * but we are temporarly 'unlinked' as the driver shall
drivers/staging/rtl8192e/rtllib_softmac_wx.c +3 -3
@@ -96,7 +96,7 @@ int rtllib_wx_get_wap(struct rtllib_device *ieee,spin_lock_irqsave (&ieee->lock, flags);if (ieee->link_state !=MAC80211_LINKED && - ieee->link_state !=RTLLIB_LINKED_SCANNING && + ieee->link_state !=MAC80211_LINKED_SCANNING && ieee->wap_set ==0 )eth_zero_addr (wrqu->ap_addr.sa_data);
@@ -185,7 +185,7 @@ int rtllib_wx_get_essid(struct rtllib_device *ieee, struct iw_request_info *a, }if (ieee->link_state !=MAC80211_LINKED && - ieee->link_state !=RTLLIB_LINKED_SCANNING && + ieee->link_state !=MAC80211_LINKED_SCANNING && ieee->ssid_set ==0 ) { ret =-1 ; goto out;
@@ -323,7 +323,7 @@ void rtllib_wx_sync_scan_wq(void *data)rtllib_stop_all_queues (ieee);rtllib_stop_send_beacons (ieee); - ieee->link_state =RTLLIB_LINKED_SCANNING ; + ieee->link_state =MAC80211_LINKED_SCANNING ; ieee->link_change (ieee->dev);/* wait for ps packet to be kicked out successfully */ msleep (50 );
Signature · 1 line
2.40.1