Enable IPQ5332 USB2
Subsystems (5)
cover Enable IPQ5332 USB2
This patch series adds the relevant phy and controller configurations for enabling USB2 on IPQ5332.
v1:
Cleanup DTS
Combine driver, kconfig and makefile patches Remove unused functions from M31 driver Drop the clock driver changes
Varadarajan Narayanan (6):
dt-bindings: usb: dwc3: Add IPQ5332 compatible
dt-bindings: phy: qcom,m31: Document qcom,m31 USB phy
phy: qcom-m31: Introduce qcom,m31 USB phy driver
arm64: dts: qcom: ipq5332: Add USB related nodes
arm64: dts: qcom: ipq5332: Enable USB
arm64: defconfig: Enable M31 USB phy driver
.../bindings/phy/qcom,ipq5332-usb-hsphy.yaml | 51 ++++ .../devicetree/bindings/usb/qcom,dwc3.yaml | 3 + arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts | 12 + arch/arm64/boot/dts/qcom/ipq5332.dtsi | 54 +++++ arch/arm64/configs/defconfig | 1 + drivers/phy/qualcomm/Kconfig | 11 + drivers/phy/qualcomm/Makefile | 1 + drivers/phy/qualcomm/phy-qcom-m31.c | 256 +++++++++++++++++++++ 8 files changed, 389 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml create mode 100644 drivers/phy/qualcomm/phy-qcom-m31.c
Signature · 7 lines
2.7.4 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
PATCH v2 1/6 dt-bindings: usb: dwc3: Add IPQ5332 compatible
Document the IPQ5332 dwc3 compatible.
---
v1:
Add ipq5332 to interrupts sections
--- Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 3 +++ 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/usb/qcom,dwc3.yaml +3 -0
@@ -14,6 +14,7 @@ properties: items: - enum: - qcom,ipq4019-dwc3 + - qcom,ipq5332-dwc3 - qcom,ipq6018-dwc3 - qcom,ipq8064-dwc3 - qcom,ipq8074-dwc3
@@ -246,6 +247,7 @@ allOf: compatible: contains: enum: + - qcom,ipq5332-dwc3 - qcom,msm8994-dwc3 - qcom,qcs404-dwc3 then:
@@ -410,6 +412,7 @@ allOf: compatible: contains: enum: + - qcom,ipq5332-dwc3 - qcom,sdm660-dwc3 then: properties:
Signature · 7 lines
2.7.4 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
PATCH v2 2/6 dt-bindings: phy: qcom,m31: Document qcom,m31 USB phy
In reply to Varadarajan NarayananDocument the M31 USB2 phy present in IPQ5332.
---
v1:
Rename qcom,m31.yaml -> qcom,ipq5332-usb-hsphy.yaml Drop default binding "m31,usb-hsphy"
Add clock
Remove 'oneOf' from compatible
Remove 'qscratch' region from register space as it is not needed Remove reset-names
Fix the example definition
--- .../bindings/phy/qcom,ipq5332-usb-hsphy.yaml | 51 ++++++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +51 -0
@@ -0,0 +1,51 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/qcom,ipq5332-usb-hsphy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: M31 (https://www.m31tech.com) USB PHY + +maintainers: + - Sricharan Ramabadhran <[email protected]> + - Varadarajan Narayanan <[email protected]> + +description: + USB M31 PHY found in Qualcomm IPQ5018, IPQ5332 SoCs. + +properties: + compatible: + items: + - enum: + - qcom,ipq5332-usb-hsphy + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + maxItems: 1 + contains: + items: + - const: cfg_ahb + + resets: + maxItems: 1 + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/qcom,ipq5332-gcc.h> + usbphy0: ipq5332-hsphy@7b000 { + compatible = "qcom,ipq5332-usb-hsphy"; + reg = <0x0007b000 0x12c>; + + clocks = <&gcc GCC_USB0_PHY_CFG_AHB_CLK>; + clock-names = "cfg_ahb"; + + resets = <&gcc GCC_QUSB2_0_PHY_BCR>; + }; +
Signature · 7 lines
2.7.4 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Rob Herring
maintainerRe: [PATCH v2 2/6] dt-bindings: phy: qcom,m31: Document qcom,m31 USB phy
Quoted 24 lines · Varadarajan Narayanan
Document the M31 USB2 phy present in IPQ5332.
Signed-off-by Sricharan Ramabadhran <[email protected]>Signed-off-by Varadarajan Narayanan <[email protected]>---
v1:
Rename qcom,m31.yaml -> qcom,ipq5332-usb-hsphy.yaml Drop default binding "m31,usb-hsphy"
Add clock
Remove 'oneOf' from compatible
Remove 'qscratch' region from register space as it is not needed Remove reset-names
Fix the example definition--- .../bindings/phy/qcom,ipq5332-usb-hsphy.yaml | 51 ++++++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yamlDocumentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +0
-0
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml line 7
Quoted 7 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +7
-0@@ -0,0 +1,51 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/qcom,ipq5332-usb-hsphy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: M31 (https://www.m31tech.com) USB PHY
Put the URL in 'description'.
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml line 11
Quoted 4 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +4
-0+ +maintainers: + - Sricharan Ramabadhran <[email protected]> + - Varadarajan Narayanan <[email protected]>
.org? It's .com everywhere else.
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml line 14
Quoted 3 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +3
-0+ +description: + USB M31 PHY found in Qualcomm IPQ5018, IPQ5332 SoCs.
Where's the IPQ5018 compatible?
Quoted 6 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +6
-0+ +properties: + compatible: + items: + - enum: + - qcom,ipq5332-usb-hsphy
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml line 30
Quoted 10 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +10
-0+ + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + maxItems: 1 + contains:
'contains' is not appropriate here. Drop.
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml line 32
Quoted 2 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +2
-0+ items: + - const: cfg_ahb
Don't need both items list and maxItems. Really, you don't need 'clock-names' at all because there is only 1 clock.
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml line 42
Quoted 10 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +10
-0+ + resets: + maxItems: 1 + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/qcom,ipq5332-gcc.h> + usbphy0: ipq5332-hsphy@7b000 {
Drop unused labels.
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml line 49
Quoted 7 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +7
-0+ compatible = "qcom,ipq5332-usb-hsphy"; + reg = <0x0007b000 0x12c>; + + clocks = <&gcc GCC_USB0_PHY_CFG_AHB_CLK>; + clock-names = "cfg_ahb"; + + resets = <&gcc GCC_QUSB2_0_PHY_BCR>;
Whitespace errors in here.
Quoted 5 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +2
-0+ }; +Signature · 1 line
2.7.4
Signature · 3 lines
linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Re: [PATCH v2 2/6] dt-bindings: phy: qcom,m31: Document qcom,m31 USB phy
Quoted 19 lines · Rob Herring
Quoted 18 lines · Varadarajan Narayanan
Document the M31 USB2 phy present in IPQ5332.
Signed-off-by Sricharan Ramabadhran <[email protected]>Signed-off-by Varadarajan Narayanan <[email protected]>---
v1:
Rename qcom,m31.yaml -> qcom,ipq5332-usb-hsphy.yaml Drop default binding "m31,usb-hsphy"
Add clock
Remove 'oneOf' from compatible
Remove 'qscratch' region from register space as it is not needed Remove reset-names
Fix the example definition--- .../bindings/phy/qcom,ipq5332-usb-hsphy.yaml | 51 ++++++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml
Quoted 15 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml line 7
Quoted 13 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +7
-0@@ -0,0 +1,51 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/qcom,ipq5332-usb-hsphy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: M31 (https://www.m31tech.com) USB PHYPut the URL in 'description'.
Ok.
Quoted 6 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml line 11
Quoted 4 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +4
-0+ +maintainers: + - Sricharan Ramabadhran <[email protected]> + - Varadarajan Narayanan <[email protected]>.org? It's .com everywhere else.
Ok.
Quoted 5 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml line 14
Quoted 3 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +3
-0+ +description: + USB M31 PHY found in Qualcomm IPQ5018, IPQ5332 SoCs.Where's the IPQ5018 compatible?
In the previous version had a default and IPQ5332 specific compatible. IPQ5018 would have used the default compatible. However, in the review was asked to drop the default compatible. Hence planned to include ipq5018 compatible and post it in separate patchset while enabling IPQ5018 USB. IPQ5018 init is also diffferent from the init used here.
Quoted 19 lines
Quoted 6 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +6
-0+ +properties: + compatible: + items: + - enum: + - qcom,ipq5332-usb-hsphyDocumentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml line 30
Quoted 10 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +10
-0+ + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + maxItems: 1 + contains:'contains' is not appropriate here. Drop.
Quoted 5 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml line 32
Quoted 2 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +2
-0+ items: + - const: cfg_ahbDon't need both items list and maxItems. Really, you don't need 'clock-names' at all because there is only 1 clock.
Will drop 'clock-names'.
Quoted 4 lines
Quoted 4 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +4
-0+ + resets: + maxItems: 1 +
Quoted 8 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml line 42
Quoted 6 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +6
-0+additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/qcom,ipq5332-gcc.h> + usbphy0: ipq5332-hsphy@7b000 {Drop unused labels.
Ok.
Quoted 9 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml line 49
Quoted 7 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +7
-0+ compatible = "qcom,ipq5332-usb-hsphy"; + reg = <0x0007b000 0x12c>; + + clocks = <&gcc GCC_USB0_PHY_CFG_AHB_CLK>; + clock-names = "cfg_ahb"; + + resets = <&gcc GCC_QUSB2_0_PHY_BCR>;Whitespace errors in here.
Ok.
Thanks
Varada
Quoted 5 lines
Quoted 5 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +2
-1+ }; + --2.7.4
Signature · 3 lines
linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Re: [PATCH v2 2/6] dt-bindings: phy: qcom,m31: Document qcom,m31 USB phy
Quoted 7 lines · Varadarajan Narayanan
Quoted 6 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml line 14
Quoted 4 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +3
-0+ +description: + USB M31 PHY found in Qualcomm IPQ5018, IPQ5332 SoCs.Where's the IPQ5018 compatible?
Quoted 6 lines
In the previous version had a default and IPQ5332 specific compatible. IPQ5018 would have used the default compatible. However, in the review was asked to drop the default compatible. Hence planned to include ipq5018 compatible and post it in separate patchset while enabling IPQ5018 USB. IPQ5018 init is also diffferent from the init used here.
Your previous patch did not have ipq5018 compatible. There was nothing indicating that some default means ipq5018...
Best regards,
Krzysztof
Re: [PATCH v2 2/6] dt-bindings: phy: qcom,m31: Document qcom,m31 USB phy
In reply to Varadarajan NarayananDocumentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml line 18
Quoted 9 lines · Varadarajan Narayanan
Document the M31 USB2 phy present in IPQ5332.
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +6
-0+description: + USB M31 PHY found in Qualcomm IPQ5018, IPQ5332 SoCs. + +properties: + compatible: + items:
Also drop items.
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml line 21
Quoted 3 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +3
-0+ - enum: + - qcom,ipq5332-usb-hsphy +
Best regards,
Krzysztof
PATCH v2 3/6 phy: qcom-m31: Introduce qcom,m31 USB phy driver
In reply to Varadarajan NarayananAdd the M31 USB2 phy driver.
---
v1:
Combine driver, makefile and kconfig into 1 patch
Remove 'qscratch' region and its usage. The controller driver takes care of those settings
Use compatible/data to handle ipq5332 init
Drop the default case
Get resources by index instead of name as there is only one resource Add clock
Fix other review comments in the driver
--- drivers/phy/qualcomm/Kconfig | 11 ++ drivers/phy/qualcomm/Makefile | 1 + drivers/phy/qualcomm/phy-qcom-m31.c | 256 ++++++++++++++++++++++++++++++++++++ 3 files changed, 268 insertions(+) create mode 100644 drivers/phy/qualcomm/phy-qcom-m31.c
drivers/phy/qualcomm/Kconfig +11 -0
@@ -188,3 +188,14 @@ config PHY_QCOM_IPQ806X_USB This option enables support for the Synopsis PHYs present inside the Qualcomm USB3.0 DWC3 controller on ipq806x SoC. This driver supports both HS and SS PHY controllers. + +config PHY_QCOM_M31_USB + tristate "Qualcomm M31 HS PHY driver support" + depends on (USB || USB_GADGET) && ARCH_QCOM + select USB_PHY + help + Enable this to support M31 HS PHY transceivers on Qualcomm chips + with DWC3 USB core. It handles PHY initialization, clock + management required after resetting the hardware and power + management. This driver is required even for peripheral only or + host only mode configurations.
drivers/phy/qualcomm/Makefile +1 -0
@@ -21,3 +21,4 @@ obj-$(CONFIG_PHY_QCOM_USB_HS_28NM) += phy-qcom-usb-hs-28nm.o obj-$(CONFIG_PHY_QCOM_USB_SS) += phy-qcom-usb-ss.o obj-$(CONFIG_PHY_QCOM_USB_SNPS_FEMTO_V2)+= phy-qcom-snps-femto-v2.o obj-$(CONFIG_PHY_QCOM_IPQ806X_USB) += phy-qcom-ipq806x-usb.o +obj-$(CONFIG_PHY_QCOM_M31_USB) += phy-qcom-m31.o
drivers/phy/qualcomm/phy-qcom-m31.c new file +256 -0
256 lines not on this page · raw message
Signature · 7 lines
2.7.4 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
PATCH v2 4/6 arm64: dts: qcom: ipq5332: Add USB related nodes
In reply to Varadarajan NarayananAdd USB phy and controller nodes.
---
v1:
Rename phy node
Change compatible from m31,ipq5332-usb-hsphy -> qcom,ipq5332-usb-hsphy Remove 'qscratch' from phy node
Fix alignment and upper-case hex no.s
Add clock definition for the phy
Remove snps,ref-clock-period-ns as it is not used. dwc3_ref_clk_period() in dwc3/core.c takes the frequency from ref clock and calculates fladj as appropriate.
--- arch/arm64/boot/dts/qcom/ipq5332.dtsi | 54 +++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+)
arch/arm64/boot/dts/qcom/ipq5332.dtsi +54 -0
@@ -405,6 +405,60 @@ status = "disabled"; }; }; + + usbphy0: ipq5332-hsphy@7b000 { + compatible = "qcom,ipq5332-usb-hsphy"; + reg = <0x0007b000 0x12c>; + + clocks = <&gcc GCC_USB0_PHY_CFG_AHB_CLK>; + clock-names = "cfg_ahb"; + + resets = <&gcc GCC_QUSB2_0_PHY_BCR>; + + status = "disabled"; + }; + + usb2: usb2@8a00000 { + compatible = "qcom,ipq5332-dwc3", "qcom,dwc3"; + + reg = <0x08af8800 0x400>; + + interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "hs_phy_irq"; + + clocks = <&gcc GCC_USB0_MASTER_CLK>, + <&gcc GCC_SNOC_USB_CLK>, + <&gcc GCC_USB0_SLEEP_CLK>, + <&gcc GCC_USB0_MOCK_UTMI_CLK>; + clock-names = "core", + "iface", + "sleep", + "mock_utmi"; + + resets = <&gcc GCC_USB_BCR>; + + qcom,select-utmi-as-pipe-clk; + + #address-cells = <1>; + #size-cells = <1>; + ranges; + + status = "disabled"; + + usb2_0_dwc: usb@8a00000 { + compatible = "snps,dwc3"; + reg = <0x08a00000 0xe000>; + clocks = <&gcc GCC_USB0_MOCK_UTMI_CLK>; + clock-names = "ref"; + interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>; + usb-phy = <&usbphy0>; + tx-fifo-resize; + snps,is-utmi-l1-suspend; + snps,hird-threshold = /bits/ 8 <0x0>; + snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; + }; + }; }; timer {
Signature · 7 lines
2.7.4 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v2 5/6 arm64: dts: qcom: ipq5332: Enable USB
In reply to Varadarajan NarayananEnable USB2 in host mode.
---
v1:
Enable usb-phy node
--- arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts | 12 ++++++++++++ 1 file changed, 12 insertions(+)
arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts +12 -0
@@ -101,3 +101,15 @@ bias-pull-up; }; }; + +&usbphy0 { + status = "okay"; +}; + +&usb2 { + status = "okay"; +}; + +&usb2_0_dwc { + dr_mode = "host"; +};
Signature · 7 lines
2.7.4 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
PATCH v2 6/6 arm64: defconfig: Enable M31 USB phy driver
In reply to Varadarajan NarayananEnable M31 USB phy driver present in IPQ5332.
--- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)
arch/arm64/configs/defconfig +1 -0
@@ -1377,6 +1377,7 @@ CONFIG_PHY_QCOM_USB_HS=m CONFIG_PHY_QCOM_USB_SNPS_FEMTO_V2=m CONFIG_PHY_QCOM_USB_HS_28NM=m CONFIG_PHY_QCOM_USB_SS=m +CONFIG_PHY_QCOM_M31_USB=m CONFIG_PHY_R8A779F0_ETHERNET_SERDES=y CONFIG_PHY_RCAR_GEN3_PCIE=y CONFIG_PHY_RCAR_GEN3_USB2=y
Signature · 7 lines
2.7.4 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy