Enable IPQ5332 USB2
Subsystems (5)
v3 cover Enable IPQ5332 USB2
This patch series adds the relevant phy and controller configurations for enabling USB2 on IPQ5332
v3:
Fix bindings file based on review comments
v1:
Cleanup DTS
Combine driver, kconfig and makefile patches Remove unused functions from M31 driver Drop the clock driver changes
Varadarajan Narayanan (6):
dt-bindings: usb: dwc3: Add IPQ5332 compatible
dt-bindings: phy: qcom,m31: Document qcom,m31 USB phy
phy: qcom-m31: Introduce qcom,m31 USB phy driver
arm64: dts: qcom: ipq5332: Add USB related nodes
arm64: dts: qcom: ipq5332: Enable USB
arm64: defconfig: Enable M31 USB phy driver
.../bindings/phy/qcom,ipq5332-usb-hsphy.yaml | 49 ++++ .../devicetree/bindings/usb/qcom,dwc3.yaml | 3 + arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts | 12 + arch/arm64/boot/dts/qcom/ipq5332.dtsi | 54 +++++ arch/arm64/configs/defconfig | 1 + drivers/phy/qualcomm/Kconfig | 11 + drivers/phy/qualcomm/Makefile | 1 + drivers/phy/qualcomm/phy-qcom-m31.c | 256 +++++++++++++++++++++ 8 files changed, 387 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml create mode 100644 drivers/phy/qualcomm/phy-qcom-m31.c
Signature · 7 lines
2.7.4 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
PATCH v3 1/6 dt-bindings: usb: dwc3: Add IPQ5332 compatible
Document the IPQ5332 dwc3 compatible.
---
v1:
Add ipq5332 to interrupts sections
--- Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 3 +++ 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/usb/qcom,dwc3.yaml +3 -0
@@ -14,6 +14,7 @@ properties: items: - enum: - qcom,ipq4019-dwc3 + - qcom,ipq5332-dwc3 - qcom,ipq6018-dwc3 - qcom,ipq8064-dwc3 - qcom,ipq8074-dwc3
@@ -246,6 +247,7 @@ allOf: compatible: contains: enum: + - qcom,ipq5332-dwc3 - qcom,msm8994-dwc3 - qcom,qcs404-dwc3 then:
@@ -410,6 +412,7 @@ allOf: compatible: contains: enum: + - qcom,ipq5332-dwc3 - qcom,sdm660-dwc3 then: properties:
Signature · 7 lines
2.7.4 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Re: [PATCH v3 1/6] dt-bindings: usb: dwc3: Add IPQ5332 compatible
Quoted 6 lines · Varadarajan Narayanan
Document the IPQ5332 dwc3 compatible.
Signed-off-by Varadarajan Narayanan <[email protected]>---
v1:
Add ipq5332 to interrupts sections
Best regards,
Krzysztof
Signature · 3 lines
linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
PATCH v3 2/6 dt-bindings: phy: qcom,m31: Document qcom,m31 USB phy
In reply to Varadarajan NarayananDocument the M31 USB2 phy present in IPQ5332.
---
v3:
Incorporate review comments. Will bring in ipq5018 compatible string while posting ipq5018 usb patchset.
v1:
Rename qcom,m31.yaml -> qcom,ipq5332-usb-hsphy.yaml Drop default binding "m31,usb-hsphy"
Add clock
Remove 'oneOf' from compatible
Remove 'qscratch' region from register space as it is not needed Remove reset-names
Fix the example definition
--- .../bindings/phy/qcom,ipq5332-usb-hsphy.yaml | 49 ++++++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +49 -0
@@ -0,0 +1,49 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/qcom,ipq5332-usb-hsphy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: M31 (https://www.m31tech.com) USB PHY + +maintainers: + - Sricharan Ramabadhran <[email protected]> + - Varadarajan Narayanan <[email protected]> + +description: + USB M31 PHY found in Qualcomm IPQ5018, IPQ5332 SoCs. + +properties: + compatible: + enum: + - qcom,ipq5332-usb-hsphy + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + maxItems: 1 + contains: + items: + - const: cfg_ahb + + resets: + maxItems: 1 + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/qcom,ipq5332-gcc.h> + usbphy0: ipq5332-hsphy@7b000 { + compatible = "qcom,ipq5332-usb-hsphy"; + reg = <0x0007b000 0x12c>; + + clocks = <&gcc GCC_USB0_PHY_CFG_AHB_CLK>; + clock-names = "cfg_ahb"; + + resets = <&gcc GCC_QUSB2_0_PHY_BCR>; + };
Signature · 7 lines
2.7.4 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Re: [PATCH v3 2/6] dt-bindings: phy: qcom,m31: Document qcom,m31 USB phy
Quoted 28 lines · Varadarajan Narayanan
Document the M31 USB2 phy present in IPQ5332.
Signed-off-by Sricharan Ramabadhran <[email protected]>Signed-off-by Varadarajan Narayanan <[email protected]>---
v3:
Incorporate review comments. Will bring in ipq5018 compatible string while posting ipq5018 usb patchset.v1:
Rename qcom,m31.yaml -> qcom,ipq5332-usb-hsphy.yaml Drop default binding "m31,usb-hsphy"
Add clock
Remove 'oneOf' from compatible
Remove 'qscratch' region from register space as it is not needed Remove reset-names
Fix the example definition--- .../bindings/phy/qcom,ipq5332-usb-hsphy.yaml | 49 ++++++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yamlDocumentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +0
-0
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml line 7
Quoted 7 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +7
-0@@ -0,0 +1,49 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/qcom,ipq5332-usb-hsphy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: M31 (https://www.m31tech.com) USB PHY
The URL should rather go to description, not the title. Title is like document title.
Quoted 11 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +11
-0+ +maintainers: + - Sricharan Ramabadhran <[email protected]> + - Varadarajan Narayanan <[email protected]> + +description: + USB M31 PHY found in Qualcomm IPQ5018, IPQ5332 SoCs. + +properties: + compatible: + enum:
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml line 28
Quoted 10 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +10
-0+ - qcom,ipq5332-usb-hsphy + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + maxItems: 1
Drop
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml line 29
Quoted 1 line
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +1
-0+ contains:
Drop
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml line 41
Quoted 12 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +12
-0+ items: + - const: cfg_ahb + + resets: + maxItems: 1 + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/qcom,ipq5332-gcc.h> + usbphy0: ipq5332-hsphy@7b000 {
Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
Re: [PATCH v3 2/6] dt-bindings: phy: qcom,m31: Document qcom,m31 USB phy
In reply to Varadarajan NarayananQuoted 29 lines · Varadarajan Narayanan
Document the M31 USB2 phy present in IPQ5332.
Signed-off-by Sricharan Ramabadhran <[email protected]>Signed-off-by Varadarajan Narayanan <[email protected]>---
v3:
Incorporate review comments. Will bring in ipq5018 compatible string while posting ipq5018 usb patchset.v1:
Rename qcom,m31.yaml -> qcom,ipq5332-usb-hsphy.yaml Drop default binding "m31,usb-hsphy"
Add clock
Remove 'oneOf' from compatible
Remove 'qscratch' region from register space as it is not needed Remove reset-names
Fix the example definition--- .../bindings/phy/qcom,ipq5332-usb-hsphy.yaml | 49 ++++++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yamlDocumentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +1
-0@@ -0,0 +1,49 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml line 11
Quoted 10 lines
Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml new file +10
-0+%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/qcom,ipq5332-usb-hsphy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: M31 (https://www.m31tech.com) USB PHY + +maintainers: + - Sricharan Ramabadhran <[email protected]> + - Varadarajan Narayanan <[email protected]>
I was wondering why I keep receiving delays/bounces for my emails in this thread... and here we have. Please correct your email.
Best regards,
Krzysztof
Signature · 3 lines
linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
PATCH v3 3/6 phy: qcom-m31: Introduce qcom,m31 USB phy driver
In reply to Varadarajan NarayananAdd the M31 USB2 phy driver.
---
v1:
Combine driver, makefile and kconfig into 1 patch
Remove 'qscratch' region and its usage. The controller driver takes care of those settings
Use compatible/data to handle ipq5332 init
Drop the default case
Get resources by index instead of name as there is only one resource Add clock
Fix review comments in the driver
--- drivers/phy/qualcomm/Kconfig | 11 ++ drivers/phy/qualcomm/Makefile | 1 + drivers/phy/qualcomm/phy-qcom-m31.c | 256 ++++++++++++++++++++++++++++++++++++ 3 files changed, 268 insertions(+) create mode 100644 drivers/phy/qualcomm/phy-qcom-m31.c
drivers/phy/qualcomm/Kconfig +11 -0
@@ -197,3 +197,14 @@ config PHY_QCOM_SGMII_ETH help Enable this to support the internal SerDes/SGMII PHY on various Qualcomm chipsets. + +config PHY_QCOM_M31_USB + tristate "Qualcomm M31 HS PHY driver support" + depends on (USB || USB_GADGET) && ARCH_QCOM + select USB_PHY + help + Enable this to support M31 HS PHY transceivers on Qualcomm chips + with DWC3 USB core. It handles PHY initialization, clock + management required after resetting the hardware and power + management. This driver is required even for peripheral only or + host only mode configurations.
drivers/phy/qualcomm/Makefile +1 -0
@@ -22,3 +22,4 @@ obj-$(CONFIG_PHY_QCOM_USB_SS) += phy-qcom-usb-ss.o obj-$(CONFIG_PHY_QCOM_USB_SNPS_FEMTO_V2)+= phy-qcom-snps-femto-v2.o obj-$(CONFIG_PHY_QCOM_IPQ806X_USB) += phy-qcom-ipq806x-usb.o obj-$(CONFIG_PHY_QCOM_SGMII_ETH) += phy-qcom-sgmii-eth.o +obj-$(CONFIG_PHY_QCOM_M31_USB) += phy-qcom-m31.o
drivers/phy/qualcomm/phy-qcom-m31.c new file +256 -0
256 lines not on this page · raw message
Signature · 7 lines
2.7.4 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Re: [PATCH v3 3/6] phy: qcom-m31: Introduce qcom,m31 USB phy driver
Quoted 67 lines · Varadarajan Narayanan
Add the M31 USB2 phy driver.
Signed-off-by Varadarajan Narayanan <[email protected]>---
v1:
Combine driver, makefile and kconfig into 1 patch
Remove 'qscratch' region and its usage. The controller driver takes care of those settings
Use compatible/data to handle ipq5332 init
Drop the default case
Get resources by index instead of name as there is only one resource Add clock
Fix review comments in the driver--- drivers/phy/qualcomm/Kconfig | 11 ++ drivers/phy/qualcomm/Makefile | 1 + drivers/phy/qualcomm/phy-qcom-m31.c | 256 ++++++++++++++++++++++++++++++++++++ 3 files changed, 268 insertions(+) create mode 100644 drivers/phy/qualcomm/phy-qcom-m31.cdrivers/phy/qualcomm/Kconfig +11
-0@@ -197,3 +197,14 @@ config PHY_QCOM_SGMII_ETH help Enable this to support the internal SerDes/SGMII PHY on various Qualcomm chipsets. + +config PHY_QCOM_M31_USB + tristate "Qualcomm M31 HS PHY driver support" + depends on (USB || USB_GADGET) && ARCH_QCOM + select USB_PHY + help + Enable this to support M31 HS PHY transceivers on Qualcomm chips + with DWC3 USB core. It handles PHY initialization, clock + management required after resetting the hardware and power + management. This driver is required even for peripheral only or + host only mode configurations.drivers/phy/qualcomm/Makefile +1
-0@@ -22,3 +22,4 @@ obj-$(CONFIG_PHY_QCOM_USB_SS) += phy-qcom-usb-ss.o obj-$(CONFIG_PHY_QCOM_USB_SNPS_FEMTO_V2)+= phy-qcom-snps-femto-v2.o obj-$(CONFIG_PHY_QCOM_IPQ806X_USB) += phy-qcom-ipq806x-usb.o obj-$(CONFIG_PHY_QCOM_SGMII_ETH) += phy-qcom-sgmii-eth.o +obj-$(CONFIG_PHY_QCOM_M31_USB) += phy-qcom-m31.odrivers/phy/qualcomm/phy-qcom-m31.c new file +13
-0@@ -0,0 +1,256 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* Copyright (c) 2014-2016, 2020, The Linux Foundation. All rights reserved. +*/ + +#include <linux/clk.h> +#include <linux/delay.h> +#include <linux/err.h> +#include <linux/io.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/of_device.h> +#include <linux/of.h>
drivers/phy/qualcomm/phy-qcom-m31.c line 23
Quoted 10 lines
drivers/phy/qualcomm/phy-qcom-m31.c new file +10
-0+#include <linux/platform_device.h> +#include <linux/reset.h> +#include <linux/slab.h> +#include <linux/usb/of.h> +#include <linux/usb/phy.h> + +enum clk_reset_action { +CLK_RESET_DEASSERT =0 , +CLK_RESET_ASSERT =1 +};
Drop entire enum. I don't see it being used.
...
Quoted 13 lines
drivers/phy/qualcomm/phy-qcom-m31.c new file +13
-0+ +static int m31usb_phy_probe (struct platform_device *pdev) +{ +const struct m31_priv_data *data; +struct device *dev = &pdev->dev; +struct m31usb_phy *qphy; +int ret; + + qphy =devm_kzalloc (dev,sizeof (*qphy),GFP_KERNEL ); +if (!qphy) +return -ENOMEM ; + + qphy->phy.dev = dev;
drivers/phy/qualcomm/phy-qcom-m31.c line 209
Quoted 10 lines
drivers/phy/qualcomm/phy-qcom-m31.c new file +10
-0+ + qphy->base =devm_platform_ioremap_resource (pdev,0 ); +if (IS_ERR (qphy->base)) +return PTR_ERR (qphy->base); + + qphy->phy_reset =devm_reset_control_get_exclusive_by_index (dev,0 ); +if (IS_ERR (qphy->phy_reset)) +return PTR_ERR (qphy->phy_reset); + + qphy->cfg_ahb_clk =devm_clk_get (dev,"cfg_ahb" );
How do you handle errors? I don't see it.
Quoted 14 lines
drivers/phy/qualcomm/phy-qcom-m31.c new file +14
-0+platform_set_drvdata (pdev, qphy); + + data =of_device_get_match_data (dev); + qphy->regs = data->regs; + qphy->ulpi_mode = data->ulpi_mode; + + qphy->phy.label ="m31-usb-phy" ; + qphy->phy.init = m31usb_phy_init; + qphy->phy.shutdown = m31usb_phy_shutdown; + qphy->phy.type =USB_PHY_TYPE_USB2 ; + + ret =usb_add_phy_dev (&qphy->phy); + +return ret;
drivers/phy/qualcomm/phy-qcom-m31.c line 233
Quoted 10 lines
drivers/phy/qualcomm/phy-qcom-m31.c new file +10
-0+} + +static void m31usb_phy_remove (struct platform_device *pdev) +{ +struct m31usb_phy *qphy =platform_get_drvdata (pdev); + +usb_remove_phy (&qphy->phy); +} + +struct m31_priv_data m31_ipq5332_data = {
static const
drivers/phy/qualcomm/phy-qcom-m31.c line 236
Quoted 3 lines
drivers/phy/qualcomm/phy-qcom-m31.c new file +3
-0+ .ulpi_mode = false, + .regs = m31_ipq5332_regs, +};
Best regards,
Krzysztof
Signature · 3 lines
linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
PATCH v3 4/6 arm64: dts: qcom: ipq5332: Add USB related nodes
In reply to Varadarajan NarayananAdd USB phy and controller nodes.
---
v1:
Rename phy node
Change compatible from m31,ipq5332-usb-hsphy -> qcom,ipq5332-usb-hsphy Remove 'qscratch' from phy node
Fix alignment and upper-case hex no.s
Add clock definition for the phy
Remove snps,ref-clock-period-ns as it is not used. dwc3_ref_clk_period() in dwc3/core.c takes the frequency from ref clock and calculates fladj as appropriate.
--- arch/arm64/boot/dts/qcom/ipq5332.dtsi | 54 +++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+)
arch/arm64/boot/dts/qcom/ipq5332.dtsi +54 -0
@@ -405,6 +405,60 @@ status = "disabled"; }; }; + + usbphy0: ipq5332-hsphy@7b000 { + compatible = "qcom,ipq5332-usb-hsphy"; + reg = <0x0007b000 0x12c>; + + clocks = <&gcc GCC_USB0_PHY_CFG_AHB_CLK>; + clock-names = "cfg_ahb"; + + resets = <&gcc GCC_QUSB2_0_PHY_BCR>; + + status = "disabled"; + }; + + usb2: usb2@8a00000 { + compatible = "qcom,ipq5332-dwc3", "qcom,dwc3"; + + reg = <0x08af8800 0x400>; + + interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "hs_phy_irq"; + + clocks = <&gcc GCC_USB0_MASTER_CLK>, + <&gcc GCC_SNOC_USB_CLK>, + <&gcc GCC_USB0_SLEEP_CLK>, + <&gcc GCC_USB0_MOCK_UTMI_CLK>; + clock-names = "core", + "iface", + "sleep", + "mock_utmi"; + + resets = <&gcc GCC_USB_BCR>; + + qcom,select-utmi-as-pipe-clk; + + #address-cells = <1>; + #size-cells = <1>; + ranges; + + status = "disabled"; + + usb2_0_dwc: usb@8a00000 { + compatible = "snps,dwc3"; + reg = <0x08a00000 0xe000>; + clocks = <&gcc GCC_USB0_MOCK_UTMI_CLK>; + clock-names = "ref"; + interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>; + usb-phy = <&usbphy0>; + tx-fifo-resize; + snps,is-utmi-l1-suspend; + snps,hird-threshold = /bits/ 8 <0x0>; + snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; + }; + }; }; timer {
Signature · 7 lines
2.7.4 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Re: [PATCH v3 4/6] arm64: dts: qcom: ipq5332: Add USB related nodes
Quoted 6 lines · Varadarajan Narayanan
Add USB phy and controller nodes.
Signed-off-by Varadarajan Narayanan <[email protected]>---
v1:
Rename phy node
I don't see any improvements.
Quoted 16 lines
Change compatible from m31,ipq5332-usb-hsphy -> qcom,ipq5332-usb-hsphy Remove 'qscratch' from phy node
Fix alignment and upper-case hex no.s
Add clock definition for the phy
Remove snps,ref-clock-period-ns as it is not used.dwc3_ref_clk_period()indwc3/core.ctakes the frequency from ref clock and calculates fladj as appropriate.--- arch/arm64/boot/dts/qcom/ipq5332.dtsi | 54 +++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+)arch/arm64/boot/dts/qcom/ipq5332.dtsi +0
-0
arch/arm64/boot/dts/qcom/ipq5332.dtsi line 409
Quoted 5 lines
arch/arm64/boot/dts/qcom/ipq5332.dtsi +2
-0@@ -405,6 +405,60 @@ status = "disabled"; }; }; + + usbphy0: ipq5332-hsphy@7b000 {
Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
"phy"
arch/arm64/boot/dts/qcom/ipq5332.dtsi line 421
Quoted 12 lines
arch/arm64/boot/dts/qcom/ipq5332.dtsi +12
-0+ compatible = "qcom,ipq5332-usb-hsphy"; + reg = <0x0007b000 0x12c>; + + clocks = <&gcc GCC_USB0_PHY_CFG_AHB_CLK>; + clock-names = "cfg_ahb"; + + resets = <&gcc GCC_QUSB2_0_PHY_BCR>; + + status = "disabled"; + }; + + usb2: usb2@8a00000 {
It does not look like you tested the DTS against bindings. Please run make dtbs_check (see Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
arch/arm64/boot/dts/qcom/ipq5332.dtsi line 423
Quoted 2 lines
arch/arm64/boot/dts/qcom/ipq5332.dtsi +2
-0+ compatible = "qcom,ipq5332-dwc3", "qcom,dwc3"; +
No need for blank line.
arch/arm64/boot/dts/qcom/ipq5332.dtsi
Quoted 3 lines
arch/arm64/boot/dts/qcom/ipq5332.dtsi +3
-0+ reg = <0x08af8800 0x400>; + + interrupts = <GIC_SPI 62 IRQ_
Best regards,
Krzysztof
Signature · 3 lines
linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Re: [PATCH v3 4/6] arm64: dts: qcom: ipq5332: Add USB related nodes
Quoted 9 lines · Krzysztof Kozlowski
Quoted 6 lines · Varadarajan Narayanan
Add USB phy and controller nodes.
Signed-off-by Varadarajan Narayanan <[email protected]>---
v1:
Rename phy nodeI don't see any improvements.
Will fix and post a new patch
Quoted 26 lines
Quoted 16 lines
Change compatible from m31,ipq5332-usb-hsphy -> qcom,ipq5332-usb-hsphy Remove 'qscratch' from phy node
Fix alignment and upper-case hex no.s
Add clock definition for the phy
Remove snps,ref-clock-period-ns as it is not used.dwc3_ref_clk_period()indwc3/core.ctakes the frequency from ref clock and calculates fladj as appropriate.--- arch/arm64/boot/dts/qcom/ipq5332.dtsi | 54 +++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+)arch/arm64/boot/dts/qcom/ipq5332.dtsi +0
-0arch/arm64/boot/dts/qcom/ipq5332.dtsi line 409
Quoted 5 lines
arch/arm64/boot/dts/qcom/ipq5332.dtsi +2
-0@@ -405,6 +405,60 @@ status = "disabled"; }; }; + + usbphy0: ipq5332-hsphy@7b000 {Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Quoted 1 line
"phy"
Will fix and post a new patch
Quoted 10 lines
Quoted 10 lines
arch/arm64/boot/dts/qcom/ipq5332.dtsi +10
-0+ compatible = "qcom,ipq5332-usb-hsphy"; + reg = <0x0007b000 0x12c>; + + clocks = <&gcc GCC_USB0_PHY_CFG_AHB_CLK>; + clock-names = "cfg_ahb"; + + resets = <&gcc GCC_QUSB2_0_PHY_BCR>; + + status = "disabled"; + };
Quoted 8 lines
arch/arm64/boot/dts/qcom/ipq5332.dtsi line 421
Quoted 2 lines
arch/arm64/boot/dts/qcom/ipq5332.dtsi +2
-0+ + usb2: usb2@8a00000 {It does not look like you tested the DTS against bindings. Please run
make dtbs_check(seeDocumentation/devicetree/bindings/writing-schema.rstor
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
'make dtbs_check' passed. The '2' in 'usb2' is to indicate USB v2. There is one more USB v3 controller in this SoC. Hence, to differentiate between the two used 'usb2'.
Hope that is ok.
Quoted 4 lines
arch/arm64/boot/dts/qcom/ipq5332.dtsi line 423
Quoted 2 lines
arch/arm64/boot/dts/qcom/ipq5332.dtsi +2
-0+ compatible = "qcom,ipq5332-dwc3", "qcom,dwc3"; +No need for blank line.
Will remove.
Thanks
Varada
Quoted 8 lines
arch/arm64/boot/dts/qcom/ipq5332.dtsi
Quoted 3 lines
arch/arm64/boot/dts/qcom/ipq5332.dtsi +3
-0+ reg = <0x08af8800 0x400>; + + interrupts = <GIC_SPI 62 IRQ_Best regards,
Krzysztof
Signature · 3 lines
linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Re: [PATCH v3 4/6] arm64: dts: qcom: ipq5332: Add USB related nodes
Quoted 9 lines · Varadarajan Narayanan
Quoted 8 lines
Review
Quoted 2 lines
(quoted diff) +2
-0+ + usb2: usb2@8a00000 {It does not look like you tested the DTS against bindings. Please run
make dtbs_check(seeDocumentation/devicetree/bindings/writing-schema.rstor
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Quoted 5 lines
'make
dtbs_check' passed. The '2' in 'usb2' is to indicate USB v2. There is one more USB v3 controller in this SoC. Hence, to differentiate between the two used 'usb2'.Hope that is ok.
Nope, unfortunately it is not.
Best regards,
Krzysztof
PATCH v3 5/6 arm64: dts: qcom: ipq5332: Enable USB
In reply to Varadarajan NarayananEnable USB2 in host mode.
---
v1:
Enable usb-phy node
--- arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts | 12 ++++++++++++ 1 file changed, 12 insertions(+)
arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts +12 -0
@@ -79,3 +79,15 @@ bias-pull-up; }; }; + +&usbphy0 { + status = "okay"; +}; + +&usb2 { + status = "okay"; +}; + +&usb2_0_dwc { + dr_mode = "host"; +};
Signature · 7 lines
2.7.4 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
PATCH v3 6/6 arm64: defconfig: Enable M31 USB phy driver
In reply to Varadarajan NarayananEnable M31 USB phy driver present in IPQ5332.
---
v2:
Add full stop to commit log.
--- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)
arch/arm64/configs/defconfig +1 -0
@@ -1386,6 +1386,7 @@ CONFIG_PHY_QCOM_USB_HS=m CONFIG_PHY_QCOM_USB_SNPS_FEMTO_V2=m CONFIG_PHY_QCOM_USB_HS_28NM=m CONFIG_PHY_QCOM_USB_SS=m +CONFIG_PHY_QCOM_M31_USB=m CONFIG_PHY_R8A779F0_ETHERNET_SERDES=y CONFIG_PHY_RCAR_GEN3_PCIE=y CONFIG_PHY_RCAR_GEN3_USB2=y
Signature · 7 lines
2.7.4 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy