trivial-patches for 2023-08-07
Subsystems (10)
cover trivial-patches for 2023-08-07
The following changes since commit 9400601a689a128c25fa9c21e932562e0eeb7a26:
Merge tag 'pull-tcg-20230806-3' of https://gitlab.com/rth7680/qemu into staging (2023-08-06 16:47:48 -0700)
are available in the Git repository at:
https://gitlab.com/mjt0k/qemu.git tags/trivial-patches-pull
for you to fetch changes up to 6ee960823da8fd780ae9912c4327b7e85e80d846:
Fixed incorrect LLONG alignment for openrisc and cris (2023-08-07 13:52:59 +0300)
----------------------------------------------------------------
trivial-patches for 2023-08-07
there are 3 trivial bugfixes in there, for 8.1
----------------------------------------------------------------
BALATON Zoltan (1):
hw/i2c: Fix bitbang_i2c_data trace event
Luca Bonissi (1):
Fixed incorrect LLONG alignment for openrisc and cris
Michael Tokarev (1):
stubs/colo.c: spelling
hw/i2c/bitbang_i2c.c | 2 +- hw/i2c/trace-events | 2 +- include/exec/user/abitypes.h | 8 ++++++++ stubs/colo.c | 2 +- 4 files changed, 11 insertions(+), 3 deletions(-)
Signature · 1 line
2.39.2
PATCH 1/3 hw/i2c: Fix bitbang_i2c_data trace event
From: BALATON Zoltan <[email protected]>
The clock and data values were logged swapped. Correct the trace event text to match what is logged. Also fix a typo in a comment nearby.
--- hw/i2c/bitbang_i2c.c | 2 +- hw/i2c/trace-events | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
hw/i2c/bitbang_i2c.c +1 -1
@@ -70,7 +70,7 @@ static int bitbang_i2c_ret(bitbang_i2c_interface *i2c, int level)return level & i2c->last_data; } -/* Leave device data pin unodified. */ +/* Leave device data pin unmodified. */ static int bitbang_i2c_nop (bitbang_i2c_interface *i2c) {return bitbang_i2c_ret (i2c, i2c->device_out);
hw/i2c/trace-events +1 -1
@@ -5,7 +5,7 @@ bitbang_i2c_state(const char *old_state, const char *new_state) "state %s -> %s" bitbang_i2c_addr(uint8_t addr) "Address 0x%02x" bitbang_i2c_send(uint8_t byte) "TX byte 0x%02x" bitbang_i2c_recv(uint8_t byte) "RX byte 0x%02x" -bitbang_i2c_data(unsigned dat, unsigned clk, unsigned old_out, unsigned new_out) "dat %u clk %u out %u -> %u" +bitbang_i2c_data(unsigned clk, unsigned dat, unsigned old_out, unsigned new_out) "clk %u dat %u out %u -> %u" # core.c
Signature · 1 line
2.39.2
PATCH 2/3 stubs/colo.c: spelling
In reply to Michael Tokarev--- stubs/colo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
stubs/colo.c +1 -1
@@ -21,7 +21,7 @@ void colo_checkpoint_delay_set(void)void migrate_start_colo_process (MigrationState *s) { -error_report ("Impossible happend: trying to start COLO when COLO " +error_report ("Impossible happened: trying to start COLO when COLO " "module is not built in" );abort (); }
Signature · 1 line
2.39.2
PATCH 3/3 Fixed incorrect LLONG alignment for openrisc and cris
In reply to Michael TokarevFrom: Luca Bonissi <[email protected]>
OpenRISC (or1k) has long long alignment to 4 bytes, but currently not defined in abitypes.h. This lead to incorrect packing of /epoll_event/ structure and eventually infinite loop while waiting for file descriptor[s] event[s].
Fixed also CRIS alignments (1 byte for all types).
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1770
--- include/exec/user/abitypes.h | 8 ++++++++ 1 file changed, 8 insertions(+)
include/exec/user/abitypes.h +8 -0
@@ -15,8 +15,16 @@#define ABI_LLONG_ALIGNMENT 2#endif +#ifdef TARGET_CRIS +#define ABI_SHORT_ALIGNMENT 1 +#define ABI_INT_ALIGNMENT 1 +#define ABI_LONG_ALIGNMENT 1 +#define ABI_LLONG_ALIGNMENT 1 +#endif +#if (defined(TARGET_I386 ) && !defined(TARGET_X86_64 )) \ || defined(TARGET_SH4 ) \ + || defined(TARGET_OPENRISC ) \ || defined(TARGET_MICROBLAZE ) \ || defined(TARGET_NIOS2 )#define ABI_LLONG_ALIGNMENT 4
Signature · 1 line
2.39.2
Richard Henderson
AppliedQuoted 8 lines · Michael Tokarev
The following changes since commit
9400601a689a128c25fa9c21e932562e0eeb7a26:Merge tag 'pull-tcg-20230806-3' of https://gitlab.com/rth7680/qemu into staging (2023-08-06 16:47:48 -0700)are available in the Git repository at:
https://gitlab.com/mjt0k/qemu.git tags/trivial-patches-pull
Quoted 8 lines
for you to fetch changes up to
6ee960823da8fd780ae9912c4327b7e85e80d846:Fixed incorrect LLONG alignment for openrisc and cris (2023-08-07 13:52:59 +0300)
----------------------------------------------------------------
trivial-patches for 2023-08-07there are 3 trivial bugfixes in there, for 8.1
Be more careful to use PULL in the subject.
This nearly got lost.
Applied, thanks. Please update https://wiki.qemu.org/ChangeLog/8.1 as appropriate.
r~
PATCH 2/24 bsd-user: spelling fixes
In reply to Michael Tokarev--- bsd-user/errno_defs.h | 2 +- bsd-user/freebsd/target_os_siginfo.h | 2 +- bsd-user/freebsd/target_os_stack.h | 4 ++-- bsd-user/freebsd/target_os_user.h | 2 +- bsd-user/qemu.h | 2 +- bsd-user/signal-common.h | 4 ++-- bsd-user/signal.c | 6 +++--- 7 files changed, 11 insertions(+), 11 deletions(-)
bsd-user/errno_defs.h +1 -1
@@ -150,5 +150,5 @@/* Internal errors: */ -#define TARGET_EJUSTRETURN 254/* Just return without modifing regs */ +#define TARGET_EJUSTRETURN 254/* Just return without modifying regs */ #define TARGET_ERESTART 255/* Restart syscall */
bsd-user/freebsd/target_os_siginfo.h +1 -1
@@ -73,5 +73,5 @@ typedef struct target_siginfo { } _mesgp; -/* SIGPOLL -- Not really genreated in FreeBSD ??? */ +/* SIGPOLL -- Not really generated in FreeBSD ??? */ struct {int _band;/* POLL_IN, POLL_OUT, POLL_MSG */
bsd-user/freebsd/target_os_stack.h +2 -2
@@ -26,5 +26,5 @@/* -* The inital FreeBSD stack is as follows: +* The initial FreeBSD stack is as follows: * (see kern/kern_exec.c exec_copyout_strings() ) *
@@ -60,5 +60,5 @@ static inline int setup_initial_stack(struct bsd_binprm *bprm, p -=sizeof (struct target_ps_strings ); -/* Add machine depedent sigcode. */ +/* Add machine dependent sigcode. */ p -=TARGET_SZSIGCODE ; if (setup_sigtramp(p, (unsigned)offsetof(struct target_sigframe, sf_uc),
bsd-user/freebsd/target_os_user.h +1 -1
@@ -27,5 +27,5 @@ struct target_priority {uint8_t pri_class;/* Scheduling class. */ uint8_t pri_level;/* Normal priority level. */ -uint8_t pri_native;/* Priority before propogation. */ +uint8_t pri_native;/* Priority before propagation. */ uint8_t pri_user;/* User priority based on p_cpu and p_nice. */ };
bsd-user/qemu.h +1 -1
@@ -119,5 +119,5 @@ extern const char *qemu_uname_release;* TARGET_ARG_MAX defines the number of bytes allocated for arguments * and envelope for the new program. 256k should suffice for a reasonable -* maxiumum env+arg in 32-bit environments, bump it up to 512k for !ILP32 +* maximum env+arg in 32-bit environments, bump it up to 512k for !ILP32 * platforms. */
bsd-user/signal-common.h +2 -2
@@ -50,9 +50,9 @@ void target_to_host_sigset(sigset_t *d, const target_sigset_t *s);* host_to_target_siginfo_noswap() and tswap_siginfo(); it does not appear * either within host siginfo_t or in target_siginfo structures which we get -* from the guest userspace program. Linux kenrels use this internally, but BSD +* from the guest userspace program. Linux kernels use this internally, but BSD * kernels don't do this, but its a useful abstraction. * * The linux-user version of this uses the top 16 bits, but FreeBSD's SI_USER -* and other signal indepenent SI_ codes have bit 16 set, so we only use the top +* and other signal independent SI_ codes have bit 16 set, so we only use the top * byte instead. *
bsd-user/signal.c +3 -3
@@ -45,5 +45,5 @@ static inline int sas_ss_flags(TaskState *ts, unsigned long sp)/* -* The BSD ABIs use the same singal numbers across all the CPU architectures, so +* The BSD ABIs use the same signal numbers across all the CPU architectures, so * (unlike Linux) these functions are just the identity mapping. This might not * be true for XyzBSD running on AbcBSD, which doesn't currently work.
@@ -242,5 +242,5 @@ static inline void host_to_target_siginfo_noswap(target_siginfo_t *tinfo,/* * Unsure that this can actually be generated, and our support for -* capsicum is somewhere between weak and non-existant, but if we get +* capsicum is somewhere between weak and non-existent, but if we get * one, then we know what to save. */
@@ -320,5 +320,5 @@ int block_signals(void)* It's OK to block everything including SIGSEGV, because we won't run any * further guest code before unblocking signals in -* process_pending_signals(). We depend on the FreeBSD behaivor here where +* process_pending_signals(). We depend on the FreeBSD behavior here where * this will only affect this thread's signal mask. We don't use * pthread_sigmask which might seem more correct because that routine also
Signature · 1 line
2.39.2
PATCH 3/24 ui: spelling fixes
In reply to Michael Tokarev--- ui/cocoa.m | 2 +- ui/keymaps.h | 2 +- ui/sdl2-2d.c | 2 +- ui/sdl2.c | 2 +- ui/vnc-enc-zrle.c.inc | 2 +- ui/vnc-enc-zywrle.h | 4 ++-- 6 files changed, 7 insertions(+), 7 deletions(-)
ui/cocoa.m +1 -1
@@ -2046,5 +2046,5 @@ static void cocoa_display_init(DisplayState *ds, DisplayOptions *opts) /* * Create the menu entries which depend on QEMU state (for consoles - * and removeable devices). These make calls back into QEMU functions, + * and removable devices). These make calls back into QEMU functions, * which is OK because at this point we know that the second thread * holds the iothread lock and is synchronously waiting for us to
ui/keymaps.h +1 -1
@@ -45,5 +45,5 @@ typedef struct {#define SCANCODE_UP 0x80 -/* Additional modifiers to use if not catched another way. */ +/* Additional modifiers to use if not caught another way. */ #define SCANCODE_SHIFT 0x100#define SCANCODE_CTRL 0x200
ui/sdl2-2d.c +1 -1
@@ -151,5 +151,5 @@ bool sdl2_2d_check_format(DisplayChangeListener *dcl,/* * We let SDL convert for us a few more formats than, -* the native ones. Thes are the ones I have tested. +* the native ones. These are the ones I have tested. */ return (format == PIXMAN_x8r8g8b8 ||
ui/sdl2.c +1 -1
@@ -861,5 +861,5 @@ static void sdl2_display_init(DisplayState *ds, DisplayOptions *o)#endif #ifndef CONFIG_WIN32 -/* QEMU uses its own low level keyboard hook procecure on Windows */ +/* QEMU uses its own low level keyboard hook procedure on Windows */ SDL_SetHint (SDL_HINT_GRAB_KEYBOARD ,"1" );#endif
ui/vnc-enc-zrle.c.inc +1 -1
@@ -111,5 +111,5 @@ static void ZRLE_ENCODE_TILE(VncState *vs, ZRLE_PIXEL *data, int w, int h, *end = ~*(end-1); /* one past the end is different so the while loop ends */ - /* Real limit is 127 but we wan't a way to know if there is more than 127 */ + /* Real limit is 127 but we want a way to know if there is more than 127 */ palette_init(palette, 256, ZRLE_BPP);
ui/vnc-enc-zywrle.h +2 -2
@@ -486,5 +486,5 @@ static inline void wavelet(int *buf, int width, int height, int level)/* RGB <=> YUV conversion stuffs. -YUV coversion is explained as following formula in strict meaning: +YUV conversion is explained as following formula in strict meaning: Y = 0.299R + 0.587G + 0.114B ( 0<=Y<=255) U = -0.169R - 0.331G + 0.500B (-128<=U<=127)
@@ -540,5 +540,5 @@ static inline void wavelet(int *buf, int width, int height, int level) So, we must transfer each sub images individually in strict meaning. - But at least ZRLE meaning, following one decompositon image is same as + But at least ZRLE meaning, following one decomposition image is same as avobe individual sub image. I use this format. (Strictly saying, transfer order is reverse(Hxy->Hy->Hx->L)
Signature · 1 line
2.39.2
PATCH 4/24 util: spelling fixes
In reply to Michael Tokarev--- util/cpuinfo-aarch64.c | 4 ++-- util/cpuinfo-i386.c | 4 ++-- util/cpuinfo-ppc.c | 2 +- util/main-loop.c | 2 +- util/oslib-posix.c | 2 +- util/qdist.c | 2 +- util/qemu-sockets.c | 2 +- util/rcu.c | 2 +- 8 files changed, 10 insertions(+), 10 deletions(-)
util/cpuinfo-aarch64.c +2 -2
@@ -1,5 +1,5 @@/* * SPDX-License-Identifier: GPL-2.0-or-later -* Host specific cpu indentification for AArch64. +* Host specific cpu identification for AArch64. */
@@ -34,5 +34,5 @@ static bool sysctl_for_bool(const char *name)* We might in the future ask for properties not present in older kernels, * but we're only asking about static properties, all of which should be -* 'int'. So we shouln't see ENOMEM (val too small), or any of the other +* 'int'. So we shouldn't see ENOMEM (val too small), or any of the other * more exotic errors. */
util/cpuinfo-i386.c +2 -2
@@ -1,5 +1,5 @@/* * SPDX-License-Identifier: GPL-2.0-or-later -* Host specific cpu indentification for x86. +* Host specific cpu identification for x86. */
@@ -75,5 +75,5 @@ unsigned __attribute__((constructor)) cpuinfo_init(void)* * AMD has provided an even stronger guarantee that processors -* with AVX provide 16-byte atomicity for all cachable, +* with AVX provide 16-byte atomicity for all cacheable, * naturally aligned single loads and stores, e.g. MOVDQU. *
util/cpuinfo-ppc.c +1 -1
@@ -1,5 +1,5 @@/* * SPDX-License-Identifier: GPL-2.0-or-later -* Host specific cpu indentification for ppc. +* Host specific cpu identification for ppc. */
util/main-loop.c +1 -1
@@ -48,5 +48,5 @@/* * Disable CFI checks. -* We are going to call a signal hander directly. Such handler may or may not +* We are going to call a signal handler directly. Such handler may or may not * have been defined in our binary, so there's no guarantee that the pointer * used to set the handler is a cfi-valid pointer. Since the handlers are
util/oslib-posix.c +1 -1
@@ -672,5 +672,5 @@ void qemu_free_stack(void *stack, size_t sz)/* * Disable CFI checks. -* We are going to call a signal hander directly. Such handler may or may not +* We are going to call a signal handler directly. Such handler may or may not * have been defined in our binary, so there's no guarantee that the pointer * used to set the handler is a cfi-valid pointer. Since the handlers are
util/qdist.c +1 -1
@@ -211,5 +211,5 @@ void qdist_bin__internal(struct qdist *to, const struct qdist *from, size_t n)/* * To avoid double-counting we capture [left, right) ranges, except for -* the righmost bin, which captures a [left, right] range. +* the rightmost bin, which captures a [left, right] range. */ while (j < from->n && (from->entries[j].x < right || i == n -1 )) {
util/qemu-sockets.c +1 -1
@@ -930,5 +930,5 @@ static int unix_listen_saddr(UnixSocketAddress *saddr,if (pathbuf !=NULL ) {/* -* This dummy fd usage silences the mktemp() unsecure warning. +* This dummy fd usage silences the mktemp() insecure warning. * Using mkstemp() doesn't make things more secure here * though. bind() complains about existing files, so we have
util/rcu.c +1 -1
@@ -356,5 +356,5 @@ void drain_call_rcu(void)* Note that since we have only one global queue of the RCU callbacks, * we also end up waiting for most of RCU callbacks that were registered -* on the other threads, but this is a side effect that shoudn't be +* on the other threads, but this is a side effect that shouldn't be * assumed. */
Signature · 1 line
2.39.2
PATCH 5/24 tcg: spelling fixes
In reply to Michael Tokarev--- tcg/aarch64/tcg-target.c.inc | 2 +- tcg/arm/tcg-target.c.inc | 4 ++-- tcg/riscv/tcg-target.c.inc | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-)
tcg/aarch64/tcg-target.c.inc +1 -1
@@ -3087,5 +3087,5 @@ static void tcg_target_qemu_prologue(TCGContext *s) /* * Note that XZR cannot be encoded in the address base register slot, - * as that actaully encodes SP. Depending on the guest, we may need + * as that actually encodes SP. Depending on the guest, we may need * to zero-extend the guest address via the address index register slot, * therefore we need to load even a zero guest base into a register.
tcg/arm/tcg-target.c.inc +2 -2
@@ -1217,5 +1217,5 @@ static TCGCond tcg_out_cmp2(TCGContext *s, const TCGArg *args, case TCG_COND_GTU: case TCG_COND_GEU: - /* We perform a conditional comparision. If the high half is + /* We perform a conditional comparison. If the high half is equal, then overwrite the flags with the comparison of the low half. The resulting flags cover the whole. */
@@ -1251,5 +1251,5 @@ static TCGCond tcg_out_cmp2(TCGContext *s, const TCGArg *args, /* * Note that TCGReg references Q-registers. - * Q-regno = 2 * D-regno, so shift left by 1 whlie inserting. + * Q-regno = 2 * D-regno, so shift left by 1 while inserting. */ static uint32_t encode_vd(TCGReg rd)
tcg/riscv/tcg-target.c.inc +2 -2
@@ -70,5 +70,5 @@ static const char * const tcg_target_reg_names[TCG_TARGET_NB_REGS] = { static const int tcg_target_reg_alloc_order[] = { /* Call saved registers */ - /* TCG_REG_S0 reservered for TCG_AREG0 */ + /* TCG_REG_S0 reserved for TCG_AREG0 */ TCG_REG_S1, TCG_REG_S2,
@@ -261,5 +261,5 @@ typedef enum { OPC_ADD_UW = 0x0800003b, - /* Zbb: Bit manipulation extension, basic bit manipulaton */ + /* Zbb: Bit manipulation extension, basic bit manipulation */ OPC_ANDN = 0x40007033, OPC_CLZ = 0x60001013,
Signature · 1 line
2.39.2
PATCH 6/24 docs: spelling fixes
In reply to Michael Tokarev--- docs/devel/qapi-code-gen.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
docs/devel/qapi-code-gen.rst +1 -1
@@ -1368,5 +1368,5 @@ anymore, optional return or event data members that can't be sent anymore, and return or event data member (enumeration) values that can't be sent anymore makes no difference to clients, except for -introspection. The latter can conceivably confuse clients, so tread +introspection. The latter can conceivably confuse clients, so treat carefully.
Signature · 1 line
2.39.2
PATCH 7/24 i386: spelling fixes
In reply to Michael Tokarev--- host/include/i386/host/cpuinfo.h | 2 +- hw/i386/acpi-build.c | 4 ++-- hw/i386/amd_iommu.c | 4 ++-- hw/i386/intel_iommu.c | 4 ++-- hw/i386/kvm/xen_xenstore.c | 2 +- hw/i386/kvm/xenstore_impl.c | 2 +- hw/i386/pc.c | 4 ++-- include/hw/i386/topology.h | 2 +- target/i386/cpu.c | 4 ++-- target/i386/cpu.h | 4 ++-- target/i386/hax/hax-interface.h | 4 ++-- target/i386/hax/hax-windows.c | 2 +- target/i386/kvm/kvm.c | 4 ++-- target/i386/kvm/xen-emu.c | 2 +- target/i386/machine.c | 4 ++-- target/i386/tcg/translate.c | 8 ++++---- tests/tcg/i386/system/boot.S | 2 +- tests/tcg/i386/x86.csv | 2 +- 18 files changed, 30 insertions(+), 30 deletions(-)
host/include/i386/host/cpuinfo.h +1 -1
@@ -1,5 +1,5 @@/* * SPDX-License-Identifier: GPL-2.0-or-later -* Host specific cpu indentification for x86. +* Host specific cpu identification for x86. */
hw/i386/acpi-build.c +2 -2
@@ -780,5 +780,5 @@ static Aml *initialize_route(Aml *route, const char *link_name,* Returns an array of 128 routes, one for each device, * based on device location. -* The main goal is to equaly distribute the interrupts +* The main goal is to equally distribute the interrupts * over the 4 existing ACPI links (works only for i440fx). * The hash function is (slot + pin) & 3 -> "LNK[D|A|B|C]".
@@ -2080,5 +2080,5 @@ build_srat(GArray *table_data, BIOSLinker *linker, MachineState *machine)/* -* Insert DMAR scope for PCI bridges and endpoint devcie +* Insert DMAR scope for PCI bridges and endpoint device */ static void
hw/i386/amd_iommu.c +2 -2
@@ -260,5 +260,5 @@ static void amdvi_log_command_error(AMDVIState *s, hwaddr addr) PCI_STATUS_SIG_TARGET_ABORT); } -/* log an illegal comand event +/* log an illegal command event * @addr : address of illegal command */
@@ -768,5 +768,5 @@ static void amdvi_mmio_write(void *opaque, hwaddr addr, uint64_t val,case AMDVI_MMIO_COMMAND_BASE :amdvi_mmio_reg_write (s, size, val, addr); -/* FIXME - make sure System Software has finished writing incase +/* FIXME - make sure System Software has finished writing in case * it writes in chucks less than 8 bytes in a robust way.As for * now, this hacks works for the linux driver
hw/i386/intel_iommu.c +2 -2
@@ -53,5 +53,5 @@/* * PCI bus number (or SID) is not reliable since the device is usaully -* initalized before guest can configure the PCI bridge +* initialized before guest can configure the PCI bridge * (SECONDARY_BUS_NUMBER). */
@@ -1695,5 +1695,5 @@ static bool vtd_switch_address_space(VTDAddressSpace *as)* * We enable per as memory region (iommu_ir_fault) for catching -* the tranlsation for interrupt range through PASID + PT. +* the translation for interrupt range through PASID + PT. */ if (pt && as->pasid !=PCI_NO_PASID ) {
hw/i386/kvm/xen_xenstore.c +1 -1
@@ -1157,5 +1157,5 @@ static unsigned int copy_to_ring(XenXenstoreState *s, uint8_t *ptr,/* * This matches the barrier in copy_to_ring() (or the guest's -* equivalent) betweem writing the data to the ring and updating +* equivalent) between writing the data to the ring and updating * rsp_prod. It protects against the pathological case (which * again I think never happened except on Alpha) where our
hw/i386/kvm/xenstore_impl.c +1 -1
@@ -1437,5 +1437,5 @@ static void save_node(gpointer key, gpointer value, gpointer opaque)* If we already wrote this node, refer to the previous copy. * There's no rename/move in XenStore, so all we need to find -* it is the tx_id of the transation in which it exists. Which +* it is the tx_id of the transaction in which it exists. Which * may be the root tx. */
hw/i386/pc.c +2 -2
@@ -434,5 +434,5 @@ static uint64_t ioport80_read(void *opaque, hwaddr addr, unsigned size) } -/* MSDOS compatibility mode FPU exception support */ +/* MS-DOS compatibility mode FPU exception support */ static void ioportF0_write (void *opaque,hwaddr addr,uint64_t data,unsigned size)
@@ -1753,5 +1753,5 @@ static void pc_machine_set_max_fw_size(Object *obj, Visitor *v, error_setg(errp, "User specified max allowed firmware size %" PRIu64 " is " - "greater than 16MiB. If combined firwmare size exceeds " + "greater than 16MiB. If combined firmware size exceeds " "16MiB the system may not boot, or experience intermittent" "stability issues.",
include/hw/i386/topology.h +1 -1
@@ -32,5 +32,5 @@* This code should be compatible with AMD's "Extended Method" described at: * AMD CPUID Specification (Publication #25481) -* Section 3: Multiple Core Calcuation +* Section 3: Multiple Core Calculation * as long as: * nr_threads is set to 1;
target/i386/cpu.c +2 -2
@@ -5337,5 +5337,5 @@ static const char *x86_cpu_feature_name(FeatureWord w, int bitnr) } -/* Compatibily hack to maintain legacy +-feat semantic, +/* Compatibility hack to maintain legacy +-feat semantic, * where +-feat overwrites any feature set by * feat=on|feat even if the later is parsed after +-feat
@@ -6301,5 +6301,5 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count,* commit 412a3c41(e.g., CentOS 6), the ebx's value always == 0 * even through guest update xcr0, this will crash some legacy guest -* (e.g., CentOS 6), So set ebx == ecx to workaroud it. +* (e.g., CentOS 6), So set ebx == ecx to workaround it. */ *ebx =kvm_enabled () ? *ecx :xsave_area_size (env->xcr0, false);
target/i386/cpu.h +2 -2
@@ -729,5 +729,5 @@ uint64_t x86_cpu_get_supported_feature_word(FeatureWord w,#define CPUID_EXT2_3DNOW (1U << 31) -/* CPUID[8000_0001].EDX bits that are aliase of CPUID[1].EDX bits on AMD CPUs */ +/* CPUID[8000_0001].EDX bits that are aliases of CPUID[1].EDX bits on AMD CPUs */ #define CPUID_EXT2_AMD_ALIASES (CPUID_EXT2_FPU | CPUID_EXT2_VME | \ CPUID_EXT2_DE | CPUID_EXT2_PSE | \
@@ -2069,5 +2069,5 @@ hwaddr x86_cpu_get_phys_page_attrs_debug(CPUState *cpu, vaddr addr,int cpu_get_pic_interrupt (CPUX86State *s); -/* MSDOS compatibility mode FPU exception support */ +/* MS-DOS compatibility mode FPU exception support */ void x86_register_ferr_irq (qemu_irq irq);void fpu_check_raise_ferr_irq (CPUX86State *s);
target/i386/hax/hax-interface.h +2 -2
@@ -239,5 +239,5 @@ enum exit_status {/* HALT from guest */ HAX_EXIT_HLT , -/* Reboot request, like because of tripple fault in guest */ +/* Reboot request, like because of triple fault in guest */ HAX_EXIT_STATECHANGE,/* the vcpu is now only paused when destroy, so simply return to hax */
@@ -296,5 +296,5 @@ struct hax_qemu_version { } __attribute__ ((__packed__)); -/* The mac specfic interface to qemu, mostly is ioctl related */ +/* The mac specific interface to qemu, mostly is ioctl related */ struct hax_tunnel_info {uint64_t va;
target/i386/hax/hax-windows.c +1 -1
@@ -175,5 +175,5 @@ int hax_mod_version(struct hax_state *hax, struct hax_module_version *version) err =GetLastError ();if (err ==ERROR_INSUFFICIENT_BUFFER || err ==ERROR_MORE_DATA ) { -fprintf (stderr,"hax module verion is too long to hold.\n" ); +fprintf (stderr,"hax module version is too long to hold.\n" ); }fprintf (stderr,"Failed to get Hax module version:%lu\n" , err);
target/i386/kvm/kvm.c +2 -2
@@ -4725,5 +4725,5 @@ int kvm_arch_put_registers(CPUState *cpu, int level)* Put MSR_IA32_FEATURE_CONTROL first, this ensures the VM gets out of VMX * root operation upon vCPU reset. kvm_put_msr_feature_control() should also -* preceed kvm_put_nested_state() when 'real' nested state is set. +* proceed kvm_put_nested_state() when 'real' nested state is set. */ if (level >=KVM_PUT_RESET_STATE ) {
@@ -5651,5 +5651,5 @@ int kvm_arch_fixup_msi_route(struct kvm_irq_routing_entry *route,/* -* Handled untranslated compatibilty format interrupt with +* Handled untranslated compatibility format interrupt with * extended destination ID in the low bits 11-5. */ dst.address =kvm_swizzle_msi_ext_dest_id (dst.address);
target/i386/kvm/xen-emu.c +1 -1
@@ -1034,5 +1034,5 @@ static int do_set_periodic_timer(CPUState *target, uint64_t period_ns)#define MICROSECS (_us) ((int64_t)((_us) * 1000ULL))#define STIME_MAX ((time_t)((int64_t)~0ull >> 1)) -/* Chosen so (NOW() + delta) wont overflow without an uptime of 200 years */ +/* Chosen so (NOW() + delta) won't overflow without an uptime of 200 years */ #define STIME_DELTA_MAX ((int64_t)((uint64_t)~0ull >> 2))
target/i386/machine.c +2 -2
@@ -283,10 +283,10 @@ static int cpu_pre_save(void *opaque)* should not be set yet in the respective vCPU register. * Thus, in case an exception is pending, it is -* important to save the exception payload seperately. +* important to save the exception payload separately. * * Therefore, if an exception is not in a pending state * or vCPU is not in guest-mode, it is not important to * distinguish between a pending and injected exception -* and we don't need to store seperately the exception payload. +* and we don't need to store separately the exception payload. * * In order to preserve better backwards-compatible migration,
target/i386/tcg/translate.c +4 -4
@@ -1070,5 +1070,5 @@ static CCPrepare gen_prepare_eflags_z(DisasContext *s, TCGv reg)/* perform a conditional store into register 'reg' according to jump opcode -value 'b'. In the fast case, T0 is guaranted not to be used. */ +value 'b'. In the fast case, T0 is guaranteed not to be used. */ static CCPrepare gen_prepare_cc (DisasContext *s,int b,TCGv reg) {
@@ -1203,5 +1203,5 @@ static inline void gen_compute_eflags_c(DisasContext *s, TCGv reg)/* generate a conditional jump to label 'l1' according to jump opcode -value 'b'. In the fast case, T0 is guaranted not to be used. */ +value 'b'. In the fast case, T0 is guaranteed not to be used. */ static inline void gen_jcc1_noeob (DisasContext *s,int b,TCGLabel *l1) {
@@ -1220,5 +1220,5 @@ static inline void gen_jcc1_noeob(DisasContext *s, int b, TCGLabel *l1)/* Generate a conditional jump to label 'l1' according to jump opcode -value 'b'. In the fast case, T0 is guaranted not to be used. +value 'b'. In the fast case, T0 is guaranteed not to be used. A translation block must end soon. */ static inline void gen_jcc1 (DisasContext *s,int b,TCGLabel *l1)
@@ -5352,5 +5352,5 @@ static bool disas_insn(DisasContext *s, CPUState *cpu)switch (op) {case 0 :/* bt */ -/* Needs no atomic ops; we surpressed the normal +/* Needs no atomic ops; we suppressed the normal memory load for LOCK above so do it now. */ gen_op_ld_v (s, ot, s->T0, s->A0);
tests/tcg/i386/system/boot.S +1 -1
@@ -72,5 +72,5 @@ _start: /* - * Don't worry about stack frame, assume everthing + * Don't worry about stack frame, assume everything * is garbage when we return, we won't need it. */
tests/tcg/i386/x86.csv +1 -1
@@ -20,5 +20,5 @@ # 4. The instruction encoding. For example, "C1 /4 ib". # -# 5. The validity of the instruction in 32-bit (aka compatiblity, legacy) mode. +# 5. The validity of the instruction in 32-bit (aka compatibility, legacy) mode. # # 6. The validity of the instruction in 64-bit mode.
Signature · 1 line
2.39.2
PATCH 8/24 mips: spelling fixes
In reply to Michael Tokarev--- hw/mips/malta.c | 2 +- target/mips/cpu-defs.c.inc | 2 +- target/mips/tcg/msa_helper.c | 12 ++++++------ target/mips/tcg/mxu_translate.c | 6 +++--- 4 files changed, 11 insertions(+), 11 deletions(-)
hw/mips/malta.c +1 -1
@@ -628,5 +628,5 @@ static void bl_setup_gt64120_jump_kernel(void **p, uint64_t run_addr, }; -/* Bus endianess is always reversed */ +/* Bus endianness is always reversed */ #if TARGET_BIG_ENDIAN #define cpu_to_gt32 (x) (x)
target/mips/cpu-defs.c.inc +1 -1
@@ -1046,5 +1046,5 @@ static void mvp_init(CPUMIPSState *env) } - /* MVPConf1 implemented, TLB sharable, no gating storage support, + /* MVPConf1 implemented, TLB shareable, no gating storage support, programmable cache partitioning implemented, number of allocatable and shareable TLB entries, MVP has allocatable TCs, 2 VPEs
target/mips/tcg/msa_helper.c +6 -6
@@ -803,7 +803,7 @@ void helper_msa_bset_d(CPUMIPSState *env, uint32_t wd, uint32_t ws, uint32_t wt)* | HADD_S.W | Vector Signed Horizontal Add (word) | * | HADD_S.D | Vector Signed Horizontal Add (doubleword) | -* | HADD_U.H | Vector Unigned Horizontal Add (halfword) | -* | HADD_U.W | Vector Unigned Horizontal Add (word) | -* | HADD_U.D | Vector Unigned Horizontal Add (doubleword) | +* | HADD_U.H | Vector Unsigned Horizontal Add (halfword) | +* | HADD_U.W | Vector Unsigned Horizontal Add (word) | +* | HADD_U.D | Vector Unsigned Horizontal Add (doubleword) | * +---------------+----------------------------------------------------------+ */
@@ -3452,7 +3452,7 @@ void helper_msa_mulv_d(CPUMIPSState *env,* | HSUB_S.W | Vector Signed Horizontal Subtract (word) | * | HSUB_S.D | Vector Signed Horizontal Subtract (doubleword) | -* | HSUB_U.H | Vector Unigned Horizontal Subtract (halfword) | -* | HSUB_U.W | Vector Unigned Horizontal Subtract (word) | -* | HSUB_U.D | Vector Unigned Horizontal Subtract (doubleword) | +* | HSUB_U.H | Vector Unsigned Horizontal Subtract (halfword) | +* | HSUB_U.W | Vector Unsigned Horizontal Subtract (word) | +* | HSUB_U.D | Vector Unsigned Horizontal Subtract (doubleword) | * | SUBS_S.B | Vector Signed Saturated Subtract (of Signed) (byte) | * | SUBS_S.H | Vector Signed Saturated Subtract (of Signed) (halfword) |
target/mips/tcg/mxu_translate.c +3 -3
@@ -2978,5 +2978,5 @@ static void gen_mxu_Q8ADD(DisasContext *ctx)* to 16-bit and put results as packed 16-bit data * into XRa and XRd. -* aptn2 manages action add or subract of pairs of data. +* aptn2 manages action add or subtract of pairs of data. * * Q8ACCE XRa, XRb, XRc, XRd, aptn2
@@ -2985,5 +2985,5 @@ static void gen_mxu_Q8ADD(DisasContext *ctx)* to 16-bit and accumulate results as packed 16-bit data * into XRa and XRd. -* aptn2 manages action add or subract of pairs of data. +* aptn2 manages action add or subtract of pairs of data. */ static void gen_mxu_q8adde (DisasContext *ctx,bool accumulate)
@@ -4057,5 +4057,5 @@ static void gen_mxu_s32sfl(DisasContext *ctx)/* * Q8SAD XRa, XRd, XRb, XRc -* Typical SAD opration for motion estimation. +* Typical SAD operation for motion estimation. */ static void gen_mxu_q8sad (DisasContext *ctx)
Signature · 1 line
2.39.2
PATCH 9/24 ppc: spelling fixes
In reply to Michael Tokarev--- host/include/ppc/host/cpuinfo.h | 2 +- hw/ppc/ppc.c | 2 +- hw/ppc/prep_systemio.c | 2 +- hw/ppc/spapr.c | 8 ++++---- hw/ppc/spapr_hcall.c | 2 +- hw/ppc/spapr_nvdimm.c | 4 ++-- hw/ppc/spapr_pci_vfio.c | 2 +- include/hw/ppc/openpic.h | 2 +- include/hw/ppc/spapr.h | 2 +- target/ppc/cpu-models.h | 4 ++-- target/ppc/cpu.h | 2 +- target/ppc/cpu_init.c | 4 ++-- target/ppc/excp_helper.c | 14 +++++++------- target/ppc/power8-pmu-regs.c.inc | 4 ++-- target/ppc/translate/vmx-impl.c.inc | 6 +++--- 15 files changed, 30 insertions(+), 30 deletions(-)
host/include/ppc/host/cpuinfo.h +1 -1
@@ -1,5 +1,5 @@/* * SPDX-License-Identifier: GPL-2.0-or-later -* Host specific cpu indentification for ppc. +* Host specific cpu identification for ppc. */
hw/ppc/ppc.c +1 -1
@@ -714,5 +714,5 @@ target_ulong cpu_ppc_load_decr(CPUPPCState *env)/* -* If large decrementer is enabled then the decrementer is signed extened +* If large decrementer is enabled then the decrementer is signed extended * to 64 bits, otherwise it is a 32 bit value. */
hw/ppc/prep_systemio.c +1 -1
@@ -40,5 +40,5 @@OBJECT_DECLARE_SIMPLE_TYPE (PrepSystemIoState,PREP_SYSTEMIO ) -/* Bit as defined in PowerPC Reference Plaform v1.1, sect. 6.1.5, p. 132 */ +/* Bit as defined in PowerPC Reference Platform v1.1, sect. 6.1.5, p. 132 */#define PREP_BIT (n) (1 << (7 - (n)))
hw/ppc/spapr.c +4 -4
@@ -2552,5 +2552,5 @@ static void spapr_set_vsmt_mode(SpaprMachineState *spapr, Error **errp) } -/* Detemine the VSMT mode to use: */ +/* Determine the VSMT mode to use: */ if (vsmt_user) {if (spapr->vsmt < smp_threads) {
@@ -3088,5 +3088,5 @@ static int spapr_kvm_type(MachineState *machine, const char *vm_type)/* * The use of g_ascii_strcasecmp() for 'hv' and 'pr' is to -* accomodate the 'HV' and 'PV' formats that exists in the +* accommodate the 'HV' and 'PV' formats that exists in the * wild. The 'auto' mode is being introduced already as * lower-case, thus we don't need to bother checking for
@@ -4322,5 +4322,5 @@ spapr_cpu_index_to_props(MachineState *machine, unsigned cpu_index)MachineClass *mc =MACHINE_GET_CLASS (machine); -/* make sure possible_cpu are intialized */ +/* make sure possible_cpu are initialized */ mc->possible_cpu_arch_ids (machine);/* get CPU core slot containing thread that matches cpu_index */
@@ -5013,5 +5013,5 @@ static void spapr_machine_2_12_class_options(MachineClass *mc)/* We depend on kvm_enabled() to choose a default value for the * hpt-max-page-size capability. Of course we can't do it here -* because this is too early and the HW accelerator isn't initialzed +* because this is too early and the HW accelerator isn't initialized * yet. Postpone this to machine init (see default_caps_with_cpu()). */
hw/ppc/spapr_hcall.c +1 -1
@@ -1559,5 +1559,5 @@ static void hypercall_register_types(void) h_get_cpu_characteristics); -/* "debugger" hcalls (also used by SLOF). Note: We do -not- differenciate +/* "debugger" hcalls (also used by SLOF). Note: We do -not- differentiate * here between the "CI" and the "CACHE" variants, they will use whatever * mapping attributes qemu is using. When using KVM, the kernel will
hw/ppc/spapr_nvdimm.c +2 -2
@@ -378,5 +378,5 @@ static target_ulong h_scm_bind_mem(PowerPCCPU *cpu, SpaprMachineState *spapr,/* * Currently continue token should be zero qemu has already bound -* everything and this hcall doesnt return H_BUSY. +* everything and this hcall doesn't return H_BUSY. */ if (continue_token >0 ) {
@@ -589,5 +589,5 @@ void spapr_nvdimm_finish_flushes(void)* the pending BHs has gotten out running in the reset path, * finally reaching here. Other code path being guest -* h_client_architecture_support, thats early boot up. +* h_client_architecture_support, that's early boot up. */ nvdimms =nvdimm_get_device_list ();
hw/ppc/spapr_pci_vfio.c +1 -1
@@ -79,5 +79,5 @@ int spapr_phb_vfio_eeh_set_option(SpaprPhbState *sphb,* pass-through devices (vfio-pci) under this sphb bus. * We have already validated that all the devices under this sphb -* are from same iommu group (within same PE) before comming here. +* are from same iommu group (within same PE) before coming here. * * Prior to linux commit 98ba956f6a389 ("powerpc/pseries/eeh:
include/hw/ppc/openpic.h +1 -1
@@ -15,5 +15,5 @@ enum {OPENPIC_OUTPUT_CINT ,/* critical IRQ */ OPENPIC_OUTPUT_MCK ,/* Machine check event */ -OPENPIC_OUTPUT_DEBUG ,/* Inconditional debug event */ +OPENPIC_OUTPUT_DEBUG ,/* Unconditional debug event */ OPENPIC_OUTPUT_RESET ,/* Core reset event */ OPENPIC_OUTPUT_NB,
include/hw/ppc/spapr.h +1 -1
@@ -198,5 +198,5 @@ struct SpaprMachineState {void *htab;uint32_t htab_shift; -uint64_t patb_entry;/* Process tbl registed in H_REGISTER_PROC_TBL */ +uint64_t patb_entry;/* Process tbl registered in H_REGISTER_PROC_TBL */ SpaprPendingHpt *pending_hpt;/* in-progress resize */
target/ppc/cpu-models.h +2 -2
@@ -45,5 +45,5 @@ enum {CPU_POWERPC_405D2 =0x20010000 ,CPU_POWERPC_405D4 =0x41810000 , -/* PowerPC 405 microcontrolers */ +/* PowerPC 405 microcontrollers */ /* XXX: missing 0x200108a0 */ CPU_POWERPC_405CRa = 0x40110041,
@@ -75,5 +75,5 @@ enum {/* PowerPC 440 cores */ CPU_POWERPC_440_XILINX =0x7ff21910 , -/* PowerPC 440 microcontrolers */ +/* PowerPC 440 microcontrollers */ CPU_POWERPC_440EPa =0x42221850 , CPU_POWERPC_440EPb = 0x422218D3,
target/ppc/cpu.h +1 -1
@@ -429,5 +429,5 @@ FIELD(MSR, LE, MSR_LE, 1)/* PMU bits */ #define MMCR0_FC PPC_BIT(32)/* Freeze Counters */ -#define MMCR0_PMAO PPC_BIT(56)/* Perf Monitor Alert Ocurred */ +#define MMCR0_PMAO PPC_BIT(56)/* Perf Monitor Alert Occurred */ #define MMCR0_PMAE PPC_BIT(37)/* Perf Monitor Alert Enable */ #define MMCR0_EBE PPC_BIT(43)/* Perf Monitor EBB Enable */
target/ppc/cpu_init.c +2 -2
@@ -5348,5 +5348,5 @@ static void register_power5p_lpar_sprs(CPUPPCState *env) {#if !defined(CONFIG_USER_ONLY ) -/* Logical partitionning */ +/* Logical partitioning */ spr_register_kvm_hv(env, SPR_LPCR, "LPCR", SPR_NOACCESS, SPR_NOACCESS,
@@ -5751,5 +5751,5 @@ static void register_power10_hash_sprs(CPUPPCState *env) {/* -* it's the OS responsability to generate a random value for the registers +* it's the OS responsibility to generate a random value for the registers * in each process' context. So, initialize it with 0 here. */
target/ppc/excp_helper.c +7 -7
@@ -456,5 +456,5 @@ static void powerpc_excp_40x(PowerPCCPU *cpu, int excp)/* * new interrupt handler msr preserves existing ME unless -* explicitly overriden. +* explicitly overridden. */ new_msr = env->msr & (((target_ulong )1 <<MSR_ME ));
@@ -579,5 +579,5 @@ static void powerpc_excp_6xx(PowerPCCPU *cpu, int excp)/* * new interrupt handler msr preserves existing ME unless -* explicitly overriden +* explicitly overridden */ new_msr = env->msr & ((target_ulong )1 <<MSR_ME );
@@ -740,5 +740,5 @@ static void powerpc_excp_7xx(PowerPCCPU *cpu, int excp)/* * new interrupt handler msr preserves existing ME unless -* explicitly overriden +* explicitly overridden */ new_msr = env->msr & ((target_ulong )1 <<MSR_ME );
@@ -911,5 +911,5 @@ static void powerpc_excp_74xx(PowerPCCPU *cpu, int excp)/* * new interrupt handler msr preserves existing ME unless -* explicitly overriden +* explicitly overridden */ new_msr = env->msr & ((target_ulong )1 <<MSR_ME );
@@ -1074,5 +1074,5 @@ static void powerpc_excp_booke(PowerPCCPU *cpu, int excp)/* * new interrupt handler msr preserves existing ME unless -* explicitly overriden +* explicitly overridden */ new_msr = env->msr & ((target_ulong )1 <<MSR_ME );
@@ -1287,5 +1287,5 @@ static bool books_vhyp_handles_hcall(PowerPCCPU *cpu)* When running a nested KVM HV guest under vhyp, HV exceptions are not * delivered to the guest (because there is no concept of HV support), but -* rather they are sent tothe vhyp to exit from the L2 back to the L1 and +* rather they are sent to the vhyp to exit from the L2 back to the L1 and * return from the H_ENTER_NESTED hypercall. */
@@ -1376,5 +1376,5 @@ static void powerpc_excp_books(PowerPCCPU *cpu, int excp)/* * new interrupt handler msr preserves existing HV and ME unless -* explicitly overriden +* explicitly overridden */ new_msr = env->msr & (((target_ulong )1 <<MSR_ME ) |MSR_HVB );
target/ppc/power8-pmu-regs.c.inc +2 -2
@@ -17,5 +17,5 @@ * PMCs) has problem state read access. * - * Read acccess is granted for all PMCC values but 0b01, where a + * Read access is granted for all PMCC values but 0b01, where a * Facility Unavailable Interrupt will occur. */
@@ -34,5 +34,5 @@ static bool spr_groupA_read_allowed(DisasContext *ctx) * PMCs) has problem state write access. * - * Write acccess is granted for PMCC values 0b10 and 0b11. Userspace + * Write access is granted for PMCC values 0b10 and 0b11. Userspace * writing with PMCC 0b00 will generate a Hypervisor Emulation * Assistance Interrupt. Userspace writing with PMCC 0b01 will
target/ppc/translate/vmx-impl.c.inc +3 -3
@@ -120,5 +120,5 @@ static void gen_stve##name(DisasContext *ctx) \ GEN_VR_LDX(lvx, 0x07, 0x03); -/* As we don't emulate the cache, lvxl is stricly equivalent to lvx */ +/* As we don't emulate the cache, lvxl is strictly equivalent to lvx */ GEN_VR_LDX(lvxl, 0x07, 0x0B);
@@ -128,5 +128,5 @@ GEN_VR_LVE(wx, 0x07, 0x02, 4); GEN_VR_STX(svx, 0x07, 0x07); -/* As we don't emulate the cache, stvxl is stricly equivalent to stvx */ +/* As we don't emulate the cache, stvxl is strictly equivalent to stvx */ GEN_VR_STX(svxl, 0x07, 0x0F);
@@ -1529,5 +1529,5 @@ static void gen_vprtyb_vec(unsigned vece, TCGv_vec t, TCGv_vec b) int i; TCGv_vec tmp = tcg_temp_new_vec_matching(b); - /* MO_32 is 2, so 2 iteractions for MO_32 and 3 for MO_64 */ + /* MO_32 is 2, so 2 iterations for MO_32 and 3 for MO_64 */ for (i = 0; i < vece; i++) { tcg_gen_shri_vec(vece, tmp, b, (4 << (vece - i)));
Signature · 1 line
2.39.2
PATCH 10/24 riscv: spelling fixes
In reply to Michael Tokarev--- hw/riscv/microchip_pfsoc.c | 2 +- hw/riscv/virt.c | 4 ++-- include/hw/riscv/riscv_hart.h | 2 +- target/riscv/cpu.h | 2 +- target/riscv/cpu_bits.h | 4 ++-- target/riscv/csr.c | 4 ++-- target/riscv/debug.c | 10 +++++----- target/riscv/insn_trans/trans_rvf.c.inc | 4 ++-- target/riscv/insn_trans/trans_rvv.c.inc | 4 ++-- target/riscv/insn_trans/trans_rvzfh.c.inc | 4 ++-- target/riscv/monitor.c | 2 +- 11 files changed, 21 insertions(+), 21 deletions(-)
hw/riscv/microchip_pfsoc.c +1 -1
@@ -660,5 +660,5 @@ static void microchip_icicle_kit_machine_class_init(ObjectClass *oc, void *data)/* -* Map 513 MiB high memory, the mimimum required high memory size, because +* Map 513 MiB high memory, the minimum required high memory size, because * HSS will do memory test against the high memory address range regardless * of physical memory installed.
hw/riscv/virt.c +2 -2
@@ -67,5 +67,5 @@#if VIRT_IMSIC_GROUP_MAX_SIZE < \IMSIC_GROUP_SIZE (VIRT_CPUS_MAX_BITS ,VIRT_IRQCHIP_MAX_GUESTS_BITS ) -#error "Can't accomodate single IMSIC group in address space" +#error "Can't accommodate single IMSIC group in address space"#endif
@@ -73,5 +73,5 @@ VIRT_IMSIC_GROUP_MAX_SIZE)#if 0x4000000 <VIRT_IMSIC_MAX_SIZE -#error "Can't accomodate all IMSIC groups in address space" +#error "Can't accommodate all IMSIC groups in address space"#endif
include/hw/riscv/riscv_hart.h +1 -1
@@ -4,5 +4,5 @@* Copyright (c) 2017 SiFive, Inc. * -* Holds the state of a heterogenous array of RISC-V harts +* Holds the state of a heterogeneous array of RISC-V harts * * This program is free software; you can redistribute it and/or modify it
target/riscv/cpu.h +1 -1
@@ -350,5 +350,5 @@ struct CPUArchState {target_ulong upmbase; -/* CSRs for execution enviornment configuration */ +/* CSRs for execution environment configuration */ uint64_t menvcfg;uint64_t mstateen[SMSTATEEN_MAX_COUNT ];
target/riscv/cpu_bits.h +2 -2
@@ -657,5 +657,5 @@ typedef enum {#define PGSHIFT 12 -/* Default Reset Vector adress */ +/* Default Reset Vector address */ #define DEFAULT_RSTVEC 0x1000
@@ -741,5 +741,5 @@ typedef enum RISCVException {#define PM_INSN 0x00000004ULL -/* Execution enviornment configuration bits */ +/* Execution environment configuration bits */ #define MENVCFG_FIOM BIT(0)#define MENVCFG_CBIE (3UL << 4)
target/riscv/csr.c +2 -2
@@ -3217,5 +3217,5 @@ static int write_hvipriox(CPURISCVState *env, int first_index, } -/* Fill-up priority arrary */ +/* Fill-up priority array */ for (i =0 ; i < num_irqs; i++) {if (riscv_cpu_hviprio_index2irq (first_index + i, &irq, &rdzero)) {
@@ -3886,5 +3886,5 @@ static inline RISCVException riscv_csrrw_check(CPURISCVState *env, !env->virt_enabled) {/* -* We are in HS mode. Add 1 to the effective privledge level to +* We are in HS mode. Add 1 to the effective privilege level to * allow us to access the Hypervisor CSRs. */
target/riscv/debug.c +5 -5
@@ -575,5 +575,5 @@ static void riscv_itrigger_update_count(CPURISCVState *env)/* * Record last icount, so that we can evaluate the executed instructions -* since last priviledge mode change or timer expire. +* since last privilege mode change or timer expire. */ int64_t last_icount = env->last_icount, current_icount;
@@ -589,5 +589,5 @@ static void riscv_itrigger_update_count(CPURISCVState *env) }/* -* Only when priviledge is changed or itrigger timer expires, +* Only when privilege is changed or itrigger timer expires, * the count field in itrigger tdata1 register is updated. * And the count field in itrigger only contains remaining value.
@@ -595,6 +595,6 @@ static void riscv_itrigger_update_count(CPURISCVState *env)if (check_itrigger_priv (env, i)) {/* -* If itrigger enabled in this priviledge mode, the number of -* executed instructions since last priviledge change +* If itrigger enabled in this privilege mode, the number of +* executed instructions since last privilege change * should be reduced from current itrigger count. */
@@ -606,5 +606,5 @@ static void riscv_itrigger_update_count(CPURISCVState *env) }else {/* -* If itrigger is not enabled in this priviledge mode, +* If itrigger is not enabled in this privilege mode, * the number of executed instructions will be discard and * the count field in itrigger will not change.
target/riscv/insn_trans/trans_rvf.c.inc +2 -2
@@ -301,5 +301,5 @@ static bool trans_fsgnjn_s(DisasContext *ctx, arg_fsgnjn_s *a) tcg_gen_or_i64(dest, dest, rs2); } - /* signed-extended intead of nanboxing for result if enable zfinx */ + /* signed-extended instead of nanboxing for result if enable zfinx */ if (ctx->cfg_ptr->ext_zfinx) { tcg_gen_ext32s_i64(dest, dest);
@@ -346,5 +346,5 @@ static bool trans_fsgnjx_s(DisasContext *ctx, arg_fsgnjx_s *a) tcg_gen_xor_i64(dest, rs1, dest); } - /* signed-extended intead of nanboxing for result if enable zfinx */ + /* signed-extended instead of nanboxing for result if enable zfinx */ if (ctx->cfg_ptr->ext_zfinx) { tcg_gen_ext32s_i64(dest, dest);
target/riscv/insn_trans/trans_rvv.c.inc +2 -2
@@ -2241,5 +2241,5 @@ GEN_OPIWI_NARROW_TRANS(vnclip_wi, IMM_ZX, vnclip_wx) * If SEW < FLEN, check whether input fp register is a valid * NaN-boxed value, in which case the least-significant SEW bits - * of the f regsiter are used, else the canonical NaN value is used. + * of the f register are used, else the canonical NaN value is used. */ static void do_nanbox(DisasContext *s, TCGv_i64 out, TCGv_i64 in)
@@ -3283,5 +3283,5 @@ static void load_element(TCGv_i64 dest, TCGv_ptr base, } -/* offset of the idx element with base regsiter r */ +/* offset of the idx element with base register r */ static uint32_t endian_ofs(DisasContext *s, int r, int idx) {
target/riscv/insn_trans/trans_rvzfh.c.inc +2 -2
@@ -306,5 +306,5 @@ static bool trans_fsgnjn_h(DisasContext *ctx, arg_fsgnjn_h *a) tcg_gen_or_i64(dest, dest, rs2); } - /* signed-extended intead of nanboxing for result if enable zfinx */ + /* signed-extended instead of nanboxing for result if enable zfinx */ if (ctx->cfg_ptr->ext_zfinx) { tcg_gen_ext16s_i64(dest, dest);
@@ -350,5 +350,5 @@ static bool trans_fsgnjx_h(DisasContext *ctx, arg_fsgnjx_h *a) tcg_gen_xor_i64(dest, rs1, dest); } - /* signed-extended intead of nanboxing for result if enable zfinx */ + /* signed-extended instead of nanboxing for result if enable zfinx */ if (ctx->cfg_ptr->ext_zfinx) { tcg_gen_ext16s_i64(dest, dest);
target/riscv/monitor.c +1 -1
@@ -56,5 +56,5 @@ static void print_pte(Monitor *mon, int va_bits, target_ulong vaddr, hwaddr paddr, target_ulong size, int attr) { - /* santity check on vaddr */ + /* sanity check on vaddr */ if (vaddr >= (1UL << va_bits)) { return;
Signature · 1 line
2.39.2
Re: [PATCH 10/24] riscv: spelling fixes
Quoted 2 lines · Michael Tokarev
Signed-off-by Michael Tokarev <[email protected]>
Alistair
Quoted 204 lines
--- hw/riscv/microchip_pfsoc.c | 2 +- hw/riscv/virt.c | 4 ++-- include/hw/riscv/riscv_hart.h | 2 +- target/riscv/cpu.h | 2 +- target/riscv/cpu_bits.h | 4 ++-- target/riscv/csr.c | 4 ++-- target/riscv/debug.c | 10 +++++----- target/riscv/insn_trans/trans_rvf.c.inc | 4 ++-- target/riscv/insn_trans/trans_rvv.c.inc | 4 ++-- target/riscv/insn_trans/trans_rvzfh.c.inc | 4 ++-- target/riscv/monitor.c | 2 +- 11 files changed, 21 insertions(+), 21 deletions(-)hw/riscv/microchip_pfsoc.c +1
-1@@ -660,5 +660,5 @@ static void microchip_icicle_kit_machine_class_init(ObjectClass *oc, void *data)/* -* Map 513 MiB high memory, the mimimum required high memory size, because +* Map 513 MiB high memory, the minimum required high memory size, because * HSS will do memory test against the high memory address range regardless * of physical memory installed. hw/riscv/virt.c +2
-2@@ -67,5 +67,5 @@#if VIRT_IMSIC_GROUP_MAX_SIZE < \IMSIC_GROUP_SIZE (VIRT_CPUS_MAX_BITS ,VIRT_IRQCHIP_MAX_GUESTS_BITS ) -#error "Can't accomodate single IMSIC group in address space" +#error "Can't accommodate single IMSIC group in address space"#endif @@ -73,5 +73,5 @@ VIRT_IMSIC_GROUP_MAX_SIZE)#if 0x4000000 <VIRT_IMSIC_MAX_SIZE -#error "Can't accomodate all IMSIC groups in address space" +#error "Can't accommodate all IMSIC groups in address space"#endif include/hw/riscv/riscv_hart.h +1
-1@@ -4,5 +4,5 @@* Copyright (c) 2017 SiFive, Inc. * -* Holds the state of a heterogenous array of RISC-V harts +* Holds the state of a heterogeneous array of RISC-V harts * * This program is free software; you can redistribute it and/or modify it target/riscv/cpu.h +1
-1@@ -350,5 +350,5 @@ struct CPUArchState {target_ulong upmbase; -/* CSRs for execution enviornment configuration */ +/* CSRs for execution environment configuration */ uint64_t menvcfg;uint64_t mstateen[SMSTATEEN_MAX_COUNT ];target/riscv/cpu_bits.h +2
-2@@ -657,5 +657,5 @@ typedef enum {#define PGSHIFT 12 -/* Default Reset Vector adress */ +/* Default Reset Vector address */ #define DEFAULT_RSTVEC 0x1000@@ -741,5 +741,5 @@ typedef enum RISCVException {#define PM_INSN 0x00000004ULL -/* Execution enviornment configuration bits */ +/* Execution environment configuration bits */ #define MENVCFG_FIOM BIT(0)#define MENVCFG_CBIE (3UL << 4)target/riscv/csr.c +2
-2@@ -3217,5 +3217,5 @@ static int write_hvipriox(CPURISCVState *env, int first_index, } -/* Fill-up priority arrary */ +/* Fill-up priority array */ for (i =0 ; i < num_irqs; i++) {if (riscv_cpu_hviprio_index2irq (first_index + i, &irq, &rdzero)) {@@ -3886,5 +3886,5 @@ static inline RISCVException riscv_csrrw_check(CPURISCVState *env, !env->virt_enabled) {/* -* We are in HS mode. Add 1 to the effective privledge level to +* We are in HS mode. Add 1 to the effective privilege level to * allow us to access the Hypervisor CSRs. */ target/riscv/debug.c +5
-5@@ -575,5 +575,5 @@ static void riscv_itrigger_update_count(CPURISCVState *env)/* * Record last icount, so that we can evaluate the executed instructions -* since last priviledge mode change or timer expire. +* since last privilege mode change or timer expire. */ int64_t last_icount = env->last_icount, current_icount;@@ -589,5 +589,5 @@ static void riscv_itrigger_update_count(CPURISCVState *env) }/* -* Only when priviledge is changed or itrigger timer expires, +* Only when privilege is changed or itrigger timer expires, * the count field in itrigger tdata1 register is updated. * And the count field in itrigger only contains remaining value. @@ -595,6 +595,6 @@ static void riscv_itrigger_update_count(CPURISCVState *env)if (check_itrigger_priv (env, i)) {/* -* If itrigger enabled in this priviledge mode, the number of -* executed instructions since last priviledge change +* If itrigger enabled in this privilege mode, the number of +* executed instructions since last privilege change * should be reduced from current itrigger count. */ @@ -606,5 +606,5 @@ static void riscv_itrigger_update_count(CPURISCVState *env) }else {/* -* If itrigger is not enabled in this priviledge mode, +* If itrigger is not enabled in this privilege mode, * the number of executed instructions will be discard and * the count field in itrigger will not change. target/riscv/insn_trans/trans_rvf.c.inc +2
-2@@ -301,5 +301,5 @@ static bool trans_fsgnjn_s(DisasContext *ctx, arg_fsgnjn_s *a) tcg_gen_or_i64(dest, dest, rs2); } - /* signed-extended intead of nanboxing for result if enable zfinx */ + /* signed-extended instead of nanboxing for result if enable zfinx */ if (ctx->cfg_ptr->ext_zfinx) { tcg_gen_ext32s_i64(dest, dest);@@ -346,5 +346,5 @@ static bool trans_fsgnjx_s(DisasContext *ctx, arg_fsgnjx_s *a) tcg_gen_xor_i64(dest, rs1, dest); } - /* signed-extended intead of nanboxing for result if enable zfinx */ + /* signed-extended instead of nanboxing for result if enable zfinx */ if (ctx->cfg_ptr->ext_zfinx) { tcg_gen_ext32s_i64(dest, dest);target/riscv/insn_trans/trans_rvv.c.inc +2
-2@@ -2241,5 +2241,5 @@ GEN_OPIWI_NARROW_TRANS(vnclip_wi, IMM_ZX, vnclip_wx) * If SEW < FLEN, check whether input fp register is a valid * NaN-boxed value, in which case the least-significant SEW bits - * of the f regsiter are used, else the canonical NaN value is used. + * of the f register are used, else the canonical NaN value is used. */ static void do_nanbox(DisasContext *s, TCGv_i64 out, TCGv_i64 in)@@ -3283,5 +3283,5 @@ static void load_element(TCGv_i64 dest, TCGv_ptr base, } -/* offset of the idx element with base regsiter r */ +/* offset of the idx element with base register r */ static uint32_t endian_ofs(DisasContext *s, int r, int idx) {target/riscv/insn_trans/trans_rvzfh.c.inc +2
-2@@ -306,5 +306,5 @@ static bool trans_fsgnjn_h(DisasContext *ctx, arg_fsgnjn_h *a) tcg_gen_or_i64(dest, dest, rs2); } - /* signed-extended intead of nanboxing for result if enable zfinx */ + /* signed-extended instead of nanboxing for result if enable zfinx */ if (ctx->cfg_ptr->ext_zfinx) { tcg_gen_ext16s_i64(dest, dest);@@ -350,5 +350,5 @@ static bool trans_fsgnjx_h(DisasContext *ctx, arg_fsgnjx_h *a) tcg_gen_xor_i64(dest, rs1, dest); } - /* signed-extended intead of nanboxing for result if enable zfinx */ + /* signed-extended instead of nanboxing for result if enable zfinx */ if (ctx->cfg_ptr->ext_zfinx) { tcg_gen_ext16s_i64(dest, dest);target/riscv/monitor.c +1
-2@@ -56,5 +56,5 @@ static void print_pte(Monitor *mon, int va_bits, target_ulong vaddr, hwaddr paddr, target_ulong size, int attr) { - /* santity check on vaddr */ + /* sanity check on vaddr */ if (vaddr >= (1UL << va_bits)) { return; --2.39.2
PATCH 11/24 hexagon: spelling fixes
In reply to Michael Tokarev--- target/hexagon/README | 2 +- target/hexagon/fma_emu.c | 2 +- target/hexagon/idef-parser/README.rst | 2 +- target/hexagon/idef-parser/idef-parser.h | 2 +- target/hexagon/idef-parser/parser-helpers.c | 6 +++--- target/hexagon/imported/alu.idef | 8 ++++---- target/hexagon/imported/macros.def | 2 +- target/hexagon/imported/mmvec/ext.idef | 10 +++++----- tests/tcg/hexagon/fpstuff.c | 2 +- tests/tcg/hexagon/test_clobber.S | 2 +- 10 files changed, 19 insertions(+), 19 deletions(-)
target/hexagon/README +1 -1
@@ -240,5 +240,5 @@ helper_funcs_generated.c.inc. There are also several helpers used for debugging VLIW packet semantics differ from serial semantics in that all input operands are read, then the operations are performed, then all the results are written. -For exmaple, this packet performs a swap of registers r0 and r1 +For example, this packet performs a swap of registers r0 and r1 { r0 = r1; r1 = r0 } Note that the result is different if the instructions are executed serially.
target/hexagon/fma_emu.c +1 -1
@@ -416,5 +416,5 @@ static SUFFIX accum_round_##SUFFIX(Accum a, float_status * fp_status) \* Theoretically, we only need to shift a maximum of one to the left if we \ * shifted out lots of bits from B, or if we had no shift / 1 shift sticky \ -* shoudl be 0 \ +* should be 0 \ */ \while ((int128_getlo (a.mant) & (1ULL <<MANTBITS )) ==0 ) { \
target/hexagon/idef-parser/README.rst +1 -1
@@ -441,5 +441,5 @@ interested part of the grammar. Run-time errors can be divided between lexing and parsing errors, lexing errors are hard to detect, since the ``var`` token will catch everything which is not -catched by other tokens, but easy to fix, because most of the time a simple +caught by other tokens, but easy to fix, because most of the time a simple regex editing will be enough.
target/hexagon/idef-parser/idef-parser.h +1 -1
@@ -74,5 +74,5 @@ typedef struct HexTmp {/** -* Enum of the possible immediated, an immediate is a value which is known +* Enum of the possible immediate, an immediate is a value which is known * at tinycode generation time, e.g. an integer value, not a TCGv */
target/hexagon/idef-parser/parser-helpers.c +3 -3
@@ -460,5 +460,5 @@ static bool try_find_variable(Context *c, YYLTYPE *locp, } -/* Calls `try_find_variable` and asserts succcess. */ +/* Calls `try_find_variable` and asserts success. */ static void find_variable(Context *c, YYLTYPE *locp, HexValue *dst,
@@ -550,5 +550,5 @@ HexValue gen_bin_cmp(Context *c,break ;default : -fprintf (stderr,"Error in evalutating immediateness!" ); +fprintf (stderr,"Error in evaluating immediateness!" );abort (); }
@@ -1165,5 +1165,5 @@ void gen_rdeposit_op(Context *c,/* * Otherwise if the width is not known, we fallback on reimplementing -* desposit in TCG. +* deposit in TCG. */ HexValue begin_m = *begin;
target/hexagon/imported/alu.idef +4 -4
@@ -293,14 +293,14 @@ Q6INSN(A4_combineii,"Rdd32=combine(#s8,#U6)",ATTRIBS(),"Set two small immediates Q6INSN(A2_combine_hh,"Rd32=combine(Rt.H32,Rs.H32)",ATTRIBS(), -"Combine two halfs into a register", {RdV = (fGETUHALF(1,RtV)<<16) | fGETUHALF(1,RsV);}) +"Combine two halves into a register", {RdV = (fGETUHALF(1,RtV)<<16) | fGETUHALF(1,RsV);}) Q6INSN(A2_combine_hl,"Rd32=combine(Rt.H32,Rs.L32)",ATTRIBS(), -"Combine two halfs into a register", {RdV = (fGETUHALF(1,RtV)<<16) | fGETUHALF(0,RsV);}) +"Combine two halves into a register", {RdV = (fGETUHALF(1,RtV)<<16) | fGETUHALF(0,RsV);}) Q6INSN(A2_combine_lh,"Rd32=combine(Rt.L32,Rs.H32)",ATTRIBS(), -"Combine two halfs into a register", {RdV = (fGETUHALF(0,RtV)<<16) | fGETUHALF(1,RsV);}) +"Combine two halves into a register", {RdV = (fGETUHALF(0,RtV)<<16) | fGETUHALF(1,RsV);}) Q6INSN(A2_combine_ll,"Rd32=combine(Rt.L32,Rs.L32)",ATTRIBS(), -"Combine two halfs into a register", {RdV = (fGETUHALF(0,RtV)<<16) | fGETUHALF(0,RsV);}) +"Combine two halves into a register", {RdV = (fGETUHALF(0,RtV)<<16) | fGETUHALF(0,RsV);}) Q6INSN(A2_tfril,"Rx.L32=#u16",ATTRIBS(),
target/hexagon/imported/macros.def +1 -1
@@ -903,5 +903,5 @@ DEF_MACRO( DEF_MACRO( - fEA_GPI, /* Calculate EA with Global Poitner + Immediate */ + fEA_GPI, /* Calculate EA with Global Pointer + Immediate */ do { EA=fREAD_GP()+IMM; fGP_DOCHKPAGECROSS(fREAD_GP(),EA); } while (0), ()
target/hexagon/imported/mmvec/ext.idef +5 -5
@@ -18,5 +18,5 @@ /****************************************************************************** * - * HOYA: MULTI MEDIA INSTRUCITONS + * HOYA: MULTI MEDIA INSTRUCTIONS * ******************************************************************************/
@@ -296,5 +296,5 @@ MMVEC_COND_EACH_EA(vS32Ub,"Unaligned Vector Store",ATTRIBS(ATTR_VMEMU,A_STORE,A_ MMVEC_EACH_EA(vS32b_new,"Aligned Vector Store New",ATTRIBS(ATTR_VMEM,A_STORE,A_CVI_NEW,A_DOTNEWVALUE,A_RESTRICT_SLOT0ONLY),,"vmem","=Os8.new",fSTOREMMV(EA,fNEWVREG(OsN))) -// V65 store relase, zero byte store +// V65 store release, zero byte store MMVEC_EACH_EA(vS32b_srls,"Aligned Vector Scatter Release",ATTRIBS(ATTR_VMEM,A_STORE,A_CVI_SCATTER_RELEASE,A_CVI_NEW,A_RESTRICT_SLOT0ONLY),,"vmem",":scatter_release",fSTORERELEASE(EA,0))
@@ -2046,9 +2046,9 @@ VxV.uw[0] = RtV;) -ITERATOR_INSN_MPY_SLOT_LATE(32,lvsplatw, "Vd32=vsplat(Rt32)", "Replicates scalar accross words in vector", VdV.uw[i] = RtV) +ITERATOR_INSN_MPY_SLOT_LATE(32,lvsplatw, "Vd32=vsplat(Rt32)", "Replicates scalar across words in vector", VdV.uw[i] = RtV) -ITERATOR_INSN_MPY_SLOT_LATE(16,lvsplath, "Vd32.h=vsplat(Rt32)", "Replicates scalar accross halves in vector", VdV.uh[i] = RtV) +ITERATOR_INSN_MPY_SLOT_LATE(16,lvsplath, "Vd32.h=vsplat(Rt32)", "Replicates scalar across halves in vector", VdV.uh[i] = RtV) -ITERATOR_INSN_MPY_SLOT_LATE(8,lvsplatb, "Vd32.b=vsplat(Rt32)", "Replicates scalar accross bytes in vector", VdV.ub[i] = RtV) +ITERATOR_INSN_MPY_SLOT_LATE(8,lvsplatb, "Vd32.b=vsplat(Rt32)", "Replicates scalar across bytes in vector", VdV.ub[i] = RtV)
tests/tcg/hexagon/fpstuff.c +1 -1
@@ -53,5 +53,5 @@ static void check_compare_exception(void)uint32_t usr; -/* Check that FP compares are quiet (don't raise any execptions) */ +/* Check that FP compares are quiet (don't raise any exceptions) */ asm (CLEAR_FPSTATUS "p0 = sfcmp.eq(%2, %3)\n\t"
tests/tcg/hexagon/test_clobber.S +1 -1
@@ -1,4 +1,4 @@ /* - * Purpose: demonstrate the succesful operation of the register save mechanism, + * Purpose: demonstrate the successful operation of the register save mechanism, * in which the caller saves the registers that will be clobbered, and restores * them after the call.
Signature · 1 line
2.39.2
PATCH 12/24 hw/net: spelling fixes
In reply to Michael Tokarev--- hw/net/cadence_gem.c | 10 +++++----- hw/net/dp8393x.c | 2 +- hw/net/e1000_regs.h | 2 +- hw/net/e1000x_regs.h | 2 +- hw/net/fsl_etsec/rings.c | 2 +- hw/net/igb_regs.h | 4 ++-- hw/net/mcf_fec.c | 2 +- hw/net/rocker/rocker_fp.c | 2 +- hw/net/rtl8139.c | 2 +- hw/net/smc91c111.c | 2 +- hw/net/sungem.c | 2 +- hw/net/sunhme.c | 2 +- hw/net/virtio-net.c | 6 +++--- hw/net/vmxnet3.c | 2 +- hw/net/vmxnet3.h | 2 +- 15 files changed, 22 insertions(+), 22 deletions(-)
hw/net/cadence_gem.c +5 -5
@@ -82,6 +82,6 @@#define GEM_SVLAN (0x000000C0 / 4)/* Stacked VLAN reg */ #define GEM_MODID (0x000000FC / 4)/* Module ID reg */ -#define GEM_OCTTXLO (0x00000100 / 4)/* Octects transmitted Low reg */ -#define GEM_OCTTXHI (0x00000104 / 4)/* Octects transmitted High reg */ +#define GEM_OCTTXLO (0x00000100 / 4)/* Octets transmitted Low reg */ +#define GEM_OCTTXHI (0x00000104 / 4)/* Octets transmitted High reg */ #define GEM_TXCNT (0x00000108 / 4)/* Error-free Frames transmitted */ #define GEM_TXBCNT (0x0000010C / 4)/* Error-free Broadcast Frames */
@@ -102,6 +102,6 @@#define GEM_DEFERTXCNT (0x00000148 / 4)/* Deferred Transmission Frames */ #define GEM_CSENSECNT (0x0000014C / 4)/* Carrier Sense Error Counter */ -#define GEM_OCTRXLO (0x00000150 / 4)/* Octects Received register Low */ -#define GEM_OCTRXHI (0x00000154 / 4)/* Octects Received register High */ +#define GEM_OCTRXLO (0x00000150 / 4)/* Octets Received register Low */ +#define GEM_OCTRXHI (0x00000154 / 4)/* Octets Received register High */ #define GEM_RXCNT (0x00000158 / 4)/* Error-free Frames Received */ #define GEM_RXBROADCNT (0x0000015C / 4)/* Error-free Broadcast Frames RX */
@@ -955,5 +955,5 @@ static ssize_t gem_receive(NetClientState *nc, const uint8_t *buf, size_t size) maf =gem_mac_address_filter (s, buf);if (maf ==GEM_RX_REJECT ) { -return size;/* no, drop siliently b/c it's not an error */ +return size;/* no, drop silently b/c it's not an error */ }
hw/net/dp8393x.c +1 -1
@@ -552,5 +552,5 @@ static uint64_t dp8393x_read(void *opaque, hwaddr addr, unsigned int size) }break ; -/* All other registers have no special contraints */ +/* All other registers have no special constraints */ default : val = s->regs[reg];
hw/net/e1000_regs.h +1 -1
@@ -131,5 +131,5 @@#define E1000_GCR2 0x05B64/* 3GIO Control Register 2 */ #define E1000_FFLT_DBG 0x05F04/* Debug Register */ -#define E1000_HICR 0x08F00/* Host Inteface Control */ +#define E1000_HICR 0x08F00/* Host Interface Control */ #define E1000_RXMTRL 0x0B634/* Time sync Rx EtherType and Msg Type - RW */
hw/net/e1000x_regs.h +1 -1
@@ -840,5 +840,5 @@ union e1000_rx_desc_packet_split {#define E1000_RXD_STAT_IXSM 0x04/* Ignore checksum */ #define E1000_RXD_STAT_VP 0x08/* IEEE VLAN Packet */ -#define E1000_RXD_STAT_UDPCS 0x10/* UDP xsum caculated */ +#define E1000_RXD_STAT_UDPCS 0x10/* UDP xsum calculated */ #define E1000_RXD_STAT_TCPCS 0x20/* TCP xsum calculated */ #define E1000_RXD_STAT_IPCS 0x40/* IP xsum calculated */
hw/net/fsl_etsec/rings.c +1 -1
@@ -366,5 +366,5 @@ void etsec_walk_tx_ring(eTSEC *etsec, int ring_nbr)/* Save the Buffer Descriptor Pointers to last bd that was not -* succesfully closed */ +* successfully closed */ etsec->regs[TBPTR0 + ring_nbr].value = bd_addr;
hw/net/igb_regs.h +2 -2
@@ -365,5 +365,5 @@ union e1000_adv_rx_desc {#define E1000_VT_MSGTYPE_CTS 0x20000000#define E1000_VT_MSGINFO_SHIFT 16 -/* bits 23:16 are used for exra info for certain messages */ +/* bits 23:16 are used for extra info for certain messages */ #define E1000_VT_MSGINFO_MASK (0xFF << E1000_VT_MSGINFO_SHIFT)
@@ -491,5 +491,5 @@ union e1000_adv_rx_desc {#define E1000_VT_MSGINFO_SHIFT 16 -/* bits 23:16 are used for exra info for certain messages */ +/* bits 23:16 are used for extra info for certain messages */ #define E1000_VT_MSGINFO_MASK (0xFF << E1000_VT_MSGINFO_SHIFT)
hw/net/mcf_fec.c +1 -1
@@ -572,5 +572,5 @@ static ssize_t mcf_fec_receive(NetClientState *nc, const uint8_t *buf, size_t si crc =cpu_to_be32 (crc32 (~0 , buf, size)); crc_ptr = (uint8_t *)&crc; -/* Huge frames are truncted. */ +/* Huge frames are truncated. */ if (size >FEC_MAX_FRAME_SIZE ) { size =FEC_MAX_FRAME_SIZE ;
hw/net/rocker/rocker_fp.c +1 -1
@@ -135,5 +135,5 @@ static ssize_t fp_port_receive_iov(NetClientState *nc, const struct iovec *iov,/* If the port is disabled, we want to drop this pkt -* now rather than queing it for later. We don't want +* now rather than queueing it for later. We don't want * any stale pkts getting into the device when the port * transitions to enabled.
hw/net/rtl8139.c +1 -1
@@ -101,5 +101,5 @@ enum RTL8139_registers {MAR0 =8 ,/* Multicast filter. */ TxStatus0 =0x10 ,/* Transmit status (Four 32bit registers). C mode only */ -/* Dump Tally Conter control register(64bit). C+ mode only */ +/* Dump Tally Counter control register(64bit). C+ mode only */ TxAddr0 =0x20 ,/* Tx descriptors (also four 32bit). */ RxBuf = 0x30,
hw/net/smc91c111.c +1 -1
@@ -362,5 +362,5 @@ static void smc91c111_writeb(void *opaque, hwaddr offset,/* Not implemented. */ return ; -case 10 :/* Genral Purpose */ +case 10 :/* General Purpose */ SET_LOW (gpr, value);return ;
hw/net/sungem.c +1 -1
@@ -1229,5 +1229,5 @@ static void sungem_mmio_mif_write(void *opaque, hwaddr addr, uint64_t val,return ;/* No actual write */ case MIF_CFG : -/* Maintain the RO MDI bits to advertize an MDIO PHY on MDI0 */ +/* Maintain the RO MDI bits to advertise an MDIO PHY on MDI0 */ val &= ~MIF_CFG_MDI1 ; val |=MIF_CFG_MDI0 ;
hw/net/sunhme.c +1 -1
@@ -902,5 +902,5 @@ static void sunhme_reset(DeviceState *ds) s->mifregs[HME_MIFI_CFG >>2 ] |=HME_MIF_CFG_MDI0 ; -/* Advetise auto, 100Mbps FD */ +/* Advertise auto, 100Mbps FD */ s->miiregs[MII_ANAR ] =MII_ANAR_TXFD ; s->miiregs[MII_BMSR] = MII_BMSR_AUTONEG | MII_BMSR_100TX_FD |
hw/net/virtio-net.c +3 -3
@@ -1308,5 +1308,5 @@ static bool virtio_net_load_ebpf(VirtIONet *n) {if (!virtio_net_attach_ebpf_to_backend (n->nic,-1 )) { -/* backend does't support steering ebpf */ +/* backend doesn't support steering ebpf */ return false; }
@@ -2047,5 +2047,5 @@ static void virtio_net_rsc_extract_unit6(VirtioNetRscChain *chain, unit->tcp_hdrlen = (htons (unit->tcp->th_offset_flags) &0xF000 ) >>10 ; -/* There is a difference between payload lenght in ipv4 and v6, +/* There is a difference between payload length in ipv4 and v6, ip header is excluded in ipv6 */ unit->payload =htons (*unit->ip_plen) - unit->tcp_hdrlen;
@@ -3796,5 +3796,5 @@ static void virtio_net_instance_init(Object *obj)/* * The default config_size is sizeof(struct virtio_net_config). -* Can be overriden with virtio_net_set_config_size. +* Can be overridden with virtio_net_set_config_size. */ n->config_size =sizeof (struct virtio_net_config );
hw/net/vmxnet3.c +1 -1
@@ -1885,5 +1885,5 @@ vmxnet3_io_bar1_read(void *opaque, hwaddr addr, unsigned size)default : -VMW_CBPRN ("Unknow read BAR1[%" PRIx64"], %d bytes" , addr, size); +VMW_CBPRN ("Unknown read BAR1[%" PRIx64"], %d bytes" , addr, size);break ; }
hw/net/vmxnet3.h +1 -1
@@ -734,5 +734,5 @@ struct Vmxnet3_RxQueueDesc {struct Vmxnet3_RxQueueCtrl ctrl;struct Vmxnet3_RxQueueConf conf; -/* Driver read after a GET commad */ +/* Driver read after a GET command */ struct Vmxnet3_QueueStatus status;struct UPT1_RxStats stats;
Signature · 1 line
2.39.2
PATCH 13/24 hw/pci: spelling fixes
In reply to Michael Tokarev--- hw/pci-bridge/cxl_downstream.c | 2 +- hw/pci-bridge/pci_expander_bridge.c | 2 +- hw/pci-host/bonito.c | 2 +- hw/pci-host/designware.c | 4 ++-- hw/pci-host/dino.c | 2 +- hw/pci-host/gpex-acpi.c | 2 +- hw/pci-host/gt64120.c | 4 ++-- hw/pci-host/pnv_phb.c | 2 +- hw/pci-host/pnv_phb3.c | 2 +- hw/pci-host/pnv_phb3_msi.c | 2 +- hw/pci-host/pnv_phb4.c | 6 +++--- hw/pci/pcie_aer.c | 2 +- hw/pci/shpc.c | 2 +- 13 files changed, 17 insertions(+), 17 deletions(-)
hw/pci-bridge/cxl_downstream.c +1 -1
@@ -43,5 +43,5 @@ static void latch_registers(CXLDownstreamPort *dsp) } -/* TODO: Look at sharing this code acorss all CXL port types */ +/* TODO: Look at sharing this code across all CXL port types */ static void cxl_dsp_dvsec_write_config (PCIDevice *dev,uint32_t addr,uint32_t val,int len)
hw/pci-bridge/pci_expander_bridge.c +1 -1
@@ -264,5 +264,5 @@ static int pxb_map_irq_fn(PCIDevice *pci_dev, int pin)/* * First carry out normal swizzle to handle -* multple root ports on a pxb instance. +* multiple root ports on a pxb instance. */ pin =pci_swizzle_map_irq_fn (pci_dev, pin);
hw/pci-host/bonito.c +1 -1
@@ -63,5 +63,5 @@#endif -/* from linux soure code. include/asm-mips/mips-boards/bonito64.h*/ +/* from linux source code. include/asm-mips/mips-boards/bonito64.h*/ #define BONITO_BOOT_BASE 0x1fc00000#define BONITO_BOOT_SIZE 0x00100000
hw/pci-host/designware.c +2 -2
@@ -489,5 +489,5 @@ static void designware_pcie_root_realize(PCIDevice *dev, Error **errp)/* * If no inbound iATU windows are configured, HW defaults to -* letting inbound TLPs to pass in. We emulate that by exlicitly +* letting inbound TLPs to pass in. We emulate that by explicitly * configuring first inbound window to cover all of target's * address space.
@@ -504,5 +504,5 @@ static void designware_pcie_root_realize(PCIDevice *dev, Error **errp) root, "pcie-msi", 0x4);/* -* We initially place MSI interrupt I/O region a adress 0 and +* We initially place MSI interrupt I/O region a address 0 and * disable it. It'll be later moved to correct offset and enabled * in designware_pcie_root_update_msi_mapping() as a part of
hw/pci-host/dino.c +1 -1
@@ -1,4 +1,4 @@/* -* HP-PARISC Dino PCI chipset emulation, as in B160L and similiar machines +* HP-PARISC Dino PCI chipset emulation, as in B160L and similar machines * * (C) 2017-2019 by Helge Deller <[email protected]>
hw/pci-host/gpex-acpi.c +1 -1
@@ -178,5 +178,5 @@ void acpi_dsdt_add_gpex(Aml *scope, struct GPEXConfig *cfg)/* -* Resources defined for PXBs are composed by the folling parts: +* Resources defined for PXBs are composed by the following parts: * 1. The resources the pci-brige/pcie-root-port need. * 2. The resources the devices behind pxb need.
hw/pci-host/gt64120.c +2 -2
@@ -332,7 +332,7 @@ static void gt64120_update_pci_cfgdata_mapping(GT64120State *s)* The setting of the MByteSwap bit and MWordSwap bit in the PCI Internal * Command Register determines how data transactions from the CPU to/from -* PCI are handled along with the setting of the Endianess bit in the CPU +* PCI are handled along with the setting of the Endianness bit in the CPU * Configuration Register. See: -* - Table 16: 32-bit PCI Transaction Endianess +* - Table 16: 32-bit PCI Transaction Endianness * - Table 158: PCI_0 Command, Offset: 0xc00 */
hw/pci-host/pnv_phb.c +1 -1
@@ -26,5 +26,5 @@* Otherwise use object_typename[index] as QOM id. * -* This helper does both operations at the same time because seting +* This helper does both operations at the same time because setting * a new QOM child will erase the bus parent of the device. This happens * because object_unparent() will call object_property_del_child(),
hw/pci-host/pnv_phb3.c +1 -1
@@ -758,5 +758,5 @@ static void pnv_phb3_translate_tve(PnvPhb3DMASpace *ds, hwaddr addr,* * TODO: Venice/Murano support it on bottom window above 4G and -* Naples suports it on everything +* Naples supports it on everything */ if (!(tve &PPC_BIT (51 ))) {
hw/pci-host/pnv_phb3_msi.c +1 -1
@@ -282,5 +282,5 @@ static void phb3_msi_instance_init(Object *obj) OBJ_PROP_LINK_STRONG); -/* Will be overriden later */ +/* Will be overridden later */ ics->offset =0 ; }
hw/pci-host/pnv_phb4.c +3 -3
@@ -208,5 +208,5 @@ static void pnv_phb4_check_mbt(PnvPHB4 *phb, uint32_t index) } -/* TODO: Figure out how to implemet/decode AOMASK */ +/* TODO: Figure out how to implement/decode AOMASK */ /* Check if it matches an enabled MMIO region in the PEC stack */
@@ -392,5 +392,5 @@ static void pnv_phb4_ioda_write(PnvPHB4 *phb, uint64_t val) *tptr = val; -/* Copy accross the valid bit to the other half */ +/* Copy across the valid bit to the other half */ phb->ioda_MBT[idx ^1 ] &=0x7fffffffffffffffull ; phb->ioda_MBT[idx ^1 ] |=0x8000000000000000ull & val;
@@ -1409,5 +1409,5 @@ static void pnv_phb4_msi_write(void *opaque, hwaddr addr, } -/* TODO: check PE/MSI assignement */ +/* TODO: check PE/MSI assignment */ qemu_irq_pulse (phb->qirqs[src]);
hw/pci/pcie_aer.c +1 -1
@@ -325,5 +325,5 @@ static void pcie_aer_msg_root_port(PCIDevice *dev, const PCIEAERMsg *msg)* So just discard the error for now. * OS which cares of aer would receive errors via -* native aer mechanims, so this wouldn't matter. +* native aer mechanisms, so this wouldn't matter. */ }
hw/pci/shpc.c +1 -1
@@ -616,5 +616,5 @@ int shpc_init(PCIDevice *d, PCIBus *sec_bus, MemoryRegion *bar,if (nslots >SHPC_MAX_SLOTS ||SHPC_IDX_TO_PCI (nslots) >PCI_SLOT_MAX ) { -/* TODO: report an error mesage that makes sense. */ +/* TODO: report an error message that makes sense. */ return -EINVAL ; }
Signature · 1 line
2.39.2
PATCH 14/24 hw/tpm: spelling fixes
In reply to Michael Tokarev--- hw/tpm/tpm_tis.h | 2 +- hw/tpm/tpm_tis_common.c | 2 +- hw/tpm/tpm_tis_i2c.c | 4 ++-- hw/tpm/tpm_tis_isa.c | 2 +- hw/tpm/tpm_tis_sysbus.c | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-)
hw/tpm/tpm_tis.h +1 -1
@@ -20,5 +20,5 @@* * TPM TIS for TPM 2 implementation following TCG PC Client Platform -* TPM Profile (PTP) Specification, Familiy 2.0, Revision 00.43 +* TPM Profile (PTP) Specification, Family 2.0, Revision 00.43 */ #ifndef TPM_TPM_TIS_H
hw/tpm/tpm_tis_common.c +1 -1
@@ -21,5 +21,5 @@* * TPM TIS for TPM 2 implementation following TCG PC Client Platform -* TPM Profile (PTP) Specification, Familiy 2.0, Revision 00.43 +* TPM Profile (PTP) Specification, Family 2.0, Revision 00.43 */ #include "qemu/osdep.h"
hw/tpm/tpm_tis_i2c.c +2 -2
@@ -14,5 +14,5 @@* * TPM TIS for TPM 2 implementation following TCG PC Client Platform -* TPM Profile (PTP) Specification, Familiy 2.0, Revision 00.43 +* TPM Profile (PTP) Specification, Family 2.0, Revision 00.43 * */
@@ -508,5 +508,5 @@ static void tpm_tis_i2c_realizefn(DeviceState *dev, Error **errp)/* -* Get the backend pointer. It is not initialized propery during +* Get the backend pointer. It is not initialized properly during * device_class_set_props */
hw/tpm/tpm_tis_isa.c +1 -1
@@ -20,5 +20,5 @@* * TPM TIS for TPM 2 implementation following TCG PC Client Platform -* TPM Profile (PTP) Specification, Familiy 2.0, Revision 00.43 +* TPM Profile (PTP) Specification, Family 2.0, Revision 00.43 */
hw/tpm/tpm_tis_sysbus.c +1 -1
@@ -20,5 +20,5 @@* * TPM TIS for TPM 2 implementation following TCG PC Client Platform -* TPM Profile (PTP) Specification, Familiy 2.0, Revision 00.43 +* TPM Profile (PTP) Specification, Family 2.0, Revision 00.43 */
Signature · 1 line
2.39.2
PATCH 15/24 hw/usb hw/ide hw/i2c: spelling fixes
In reply to Michael Tokarev--- hw/i2c/pm_smbus.c | 2 +- hw/i2c/pmbus_device.c | 2 +- hw/i2c/smbus_slave.c | 2 +- hw/ide/ahci_internal.h | 4 ++-- hw/ide/cmd646.c | 2 +- hw/ide/core.c | 2 +- hw/usb/ccid-card-emulated.c | 2 +- hw/usb/hcd-ehci.c | 6 +++--- hw/usb/hcd-ohci.c | 2 +- hw/usb/quirks.h | 2 +- hw/usb/redirect.c | 2 +- hw/usb/trace-events | 2 +- hw/usb/xen-usb.c | 2 +- 13 files changed, 16 insertions(+), 16 deletions(-)
hw/i2c/pm_smbus.c +1 -1
@@ -1,5 +1,5 @@/* * PC SMBus implementation -* splitted from acpi.c +* split from acpi.c * * Copyright (c) 2006 Fabrice Bellard
hw/i2c/pmbus_device.c +1 -1
@@ -1624,5 +1624,5 @@ static int pmbus_write_data(SMBusDevice *smd, uint8_t *buf, uint8_t len) passthrough: -/* Unimplimented registers get passed to the device */ +/* Unimplemented registers get passed to the device */ default :if (pmdc->write_data) {
hw/i2c/smbus_slave.c +1 -1
@@ -3,5 +3,5 @@* * This code is a helper for SMBus device emulation. It implements an -* I2C device inteface and runs the SMBus protocol from the device +* I2C device interface and runs the SMBus protocol from the device * point of view and maps those to simple calls to emulate. *
hw/ide/ahci_internal.h +2 -2
@@ -62,5 +62,5 @@ enum AHCIHostReg {AHCI_HOST_REG_IRQ_STAT =2 ,/* IS: interrupt status */ AHCI_HOST_REG_PORTS_IMPL =3 ,/* PI: bitmap of implemented ports */ -AHCI_HOST_REG_VERSION =4 ,/* VS: AHCI spec. version compliancy */ +AHCI_HOST_REG_VERSION =4 ,/* VS: AHCI spec. version compliance */ AHCI_HOST_REG_CCC_CTL =5 ,/* CCC_CTL: CCC Control */ AHCI_HOST_REG_CCC_PORTS = 6, /* CCC_PORTS: CCC Ports */
@@ -68,5 +68,5 @@ enum AHCIHostReg {AHCI_HOST_REG_EM_CTL =8 ,/* EM_CTL: Enclosure Mgmt Control */ AHCI_HOST_REG_CAP2 =9 ,/* CAP2: host capabilities, extended */ -AHCI_HOST_REG_BOHC =10 ,/* BOHC: firmare/os handoff ctrl & status */ +AHCI_HOST_REG_BOHC =10 ,/* BOHC: firmware/os handoff ctrl & status */ AHCI_HOST_REG__COUNT = 11 };
hw/ide/cmd646.c +1 -1
@@ -258,5 +258,5 @@ static void pci_cmd646_ide_realize(PCIDevice *dev, Error **errp) pci_conf[CNTRL ] =CNTRL_EN_CH0 ;// enable IDE0 if (d->secondary) { -/* XXX: if not enabled, really disable the seconday IDE controller */ +/* XXX: if not enabled, really disable the secondary IDE controller */ pci_conf[CNTRL ] |=CNTRL_EN_CH1 ;/* enable IDE1 */ }
hw/ide/core.c +1 -1
@@ -1699,5 +1699,5 @@ static bool cmd_set_features(IDEState *s, uint8_t cmd)put_le16 (identify_data +88 ,0x3f );break ; -case 0x02 :/* sigle word dma mode*/ +case 0x02 :/* single word dma mode */ put_le16 (identify_data +62 ,0x07 | (1 << (val +8 )));put_le16 (identify_data +63 ,0x07 );
hw/usb/ccid-card-emulated.c +1 -1
@@ -519,5 +519,5 @@ static void emulated_realize(CCIDCardState *base, Error **errp) } -/* TODO: a passthru backened that works on local machine. third card type?*/ +/* TODO: a passthru backend that works on local machine. third card type?*/ if (card->backend ==BACKEND_CERTIFICATES ) {if (card->cert1 !=NULL && card->cert2 !=NULL && card->cert3 !=NULL ) {
hw/usb/hcd-ehci.c +3 -3
@@ -1465,5 +1465,5 @@ static int ehci_process_itd(EHCIState *ehci,usb_packet_unmap (&ehci->ipacket, &ehci->isgl); }else { -DPRINTF ("ISOCH: attempt to addess non-iso endpoint\n" ); +DPRINTF ("ISOCH: attempt to address non-iso endpoint\n" ); ehci->ipacket.status =USB_RET_NAK ; ehci->ipacket.actual_length =0 ;
@@ -1514,5 +1514,5 @@ static int ehci_process_itd(EHCIState *ehci,/* This state is the entry point for asynchronous schedule -* processing. Entry here consitutes a EHCI start event state (4.8.5) +* processing. Entry here constitutes a EHCI start event state (4.8.5) */ static int ehci_state_waitlisthead (EHCIState *ehci,int async)
@@ -2459,5 +2459,5 @@ static void usb_ehci_vm_state_change(void *opaque, bool running, RunState state)* The schedule rebuilt from guest memory could cause the migration dest * to miss a QH unlink, and fail to cancel packets, since the unlinked QH -* will never have existed on the destination. Therefor we must flush the +* will never have existed on the destination. Therefore we must flush the * async schedule on savevm to catch any not yet noticed unlinks. */
hw/usb/hcd-ohci.c +1 -1
@@ -1356,5 +1356,5 @@ static uint32_t ohci_get_frame_remaining(OHCIState *ohci)return ohci->frt <<31 ; } -/* Being in USB operational state guarnatees sof_time was set already. */ +/* Being in USB operational state guarantees sof_time was set already. */ tks =qemu_clock_get_ns (QEMU_CLOCK_VIRTUAL ) - ohci->sof_time;if (tks <0 ) {
hw/usb/quirks.h +1 -1
@@ -68,5 +68,5 @@ static const struct usb_device_id usbredir_raw_serial_ids[] = { { USB_DEVICE(0x10C4, 0x803B) }, /* Pololu USB-serial converter */ { USB_DEVICE(0x10C4, 0x8044) }, /* Cygnal Debug Adapter */ - { USB_DEVICE(0x10C4, 0x804E) }, /* Software Bisque Paramount ME build-in converter */ + { USB_DEVICE(0x10C4, 0x804E) }, /* Software Bisque Paramount ME built-in converter */ { USB_DEVICE(0x10C4, 0x8053) }, /* Enfora EDG1228 */ { USB_DEVICE(0x10C4, 0x8054) }, /* Enfora GSM2228 */
hw/usb/redirect.c +1 -1
@@ -472,5 +472,5 @@ static int bufp_alloc(USBRedirDevice *dev, uint8_t *data, uint16_t len, dev->endpoint[EP2I (ep)].bufpq_dropping_packets =1 ; } -/* Since we're interupting the stream anyways, drop enough packets to get +/* Since we're interrupting the stream anyways, drop enough packets to get back to our target buffer size */ if (dev->endpoint[EP2I (ep)].bufpq_dropping_packets) {
hw/usb/trace-events +1 -1
@@ -249,5 +249,5 @@ usb_set_device_feature(int addr, int feature, int ret) "dev %d, feature %d, ret # dev-hub.c usb_hub_reset(int addr) "dev %d" -usb_hub_control(int addr, int request, int value, int index, int length) "dev %d, req 0x%x, value %d, index %d, langth %d" +usb_hub_control(int addr, int request, int value, int index, int length) "dev %d, req 0x%x, value %d, index %d, length %d" usb_hub_get_port_status(int addr, int nr, int status, int changed) "dev %d, port %d, status 0x%x, changed 0x%x" usb_hub_set_port_feature(int addr, int nr, const char *f) "dev %d, port %d, feature %s"
hw/usb/xen-usb.c +1 -1
@@ -452,5 +452,5 @@ static int usbback_check_and_submit(struct usbback_req *usbback_req)/* -* When the device is first connected or resetted, USB device has no +* When the device is first connected or reset, USB device has no * address. In this initial state, following requests are sent to device * address (#0),
Signature · 1 line
2.39.2
PATCH 16/24 hw/display: spelling fixes
In reply to Michael Tokarev--- hw/display/bochs-display.c | 2 +- hw/display/qxl.c | 2 +- hw/display/ssd0303.c | 2 +- hw/display/ssd0323.c | 2 +- hw/display/xlnx_dp.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-)
hw/display/bochs-display.c +1 -1
@@ -165,5 +165,5 @@ static int bochs_display_get_mode(BochsDisplayState *s,switch (vbe[VBE_DISPI_INDEX_BPP ]) {case 16 : -/* best effort: support native endianess only */ +/* best effort: support native endianness only */ mode->format = PIXMAN_r5g6b5; mode->bytepp =2 ;
hw/display/qxl.c +1 -1
@@ -1545,5 +1545,5 @@ static void qxl_create_guest_primary(PCIQXLDevice *qxl, int loadvm, } -/* return 1 if surface destoy was initiated (in QXL_ASYNC case) or +/* return 1 if surface destroy was initiated (in QXL_ASYNC case) or * done (in QXL_SYNC case), 0 otherwise. */ static int qxl_destroy_primary (PCIQXLDevice *d,qxl_async_io async)
hw/display/ssd0303.c +1 -1
@@ -9,5 +9,5 @@/* The controller can support a variety of different displays, but we only -implement one. Most of the commends relating to brightness and geometry +implement one. Most of the commands relating to brightness and geometry setup are ignored. */
hw/display/ssd0323.c +1 -1
@@ -9,5 +9,5 @@/* The controller can support a variety of different displays, but we only -implement one. Most of the commends relating to brightness and geometry +implement one. Most of the commands relating to brightness and geometry setup are ignored. */
hw/display/xlnx_dp.c +1 -1
@@ -381,5 +381,5 @@ static void xlnx_dp_audio_callback(void *opaque, int avail) {/* -* Get some data from the DPDMA and compute these datas. +* Get some data from the DPDMA and compute these data. * Then wait for QEMU's audio subsystem to call this callback. */
Signature · 1 line
2.39.2
PATCH 17/24 xen: spelling fixes
In reply to Michael Tokarev--- hw/xen/xen_pvdev.c | 2 +- include/hw/xen/interface/arch-x86/xen-x86_64.h | 2 +- include/hw/xen/interface/arch-x86/xen.h | 2 +- include/hw/xen/interface/event_channel.h | 2 +- include/hw/xen/interface/grant_table.h | 2 +- include/hw/xen/interface/hvm/hvm_op.h | 2 +- include/hw/xen/interface/io/blkif.h | 6 +++--- include/hw/xen/interface/io/fbif.h | 2 +- include/hw/xen/interface/io/kbdif.h | 2 +- include/hw/xen/interface/memory.h | 2 +- include/hw/xen/interface/physdev.h | 4 ++-- include/hw/xen/interface/xen.h | 4 ++-- 12 files changed, 16 insertions(+), 16 deletions(-)
hw/xen/xen_pvdev.c +1 -1
@@ -90,5 +90,5 @@ char *xenstore_read_str(const char *base, const char *node)if (str !=NULL ) {/* move to qemu-allocated memory to make sure -* callers can savely g_free() stuff. */ +* callers can safely g_free() stuff. */ ret =g_strdup (str);free (str);
include/hw/xen/interface/arch-x86/xen-x86_64.h +1 -1
@@ -107,5 +107,5 @@* RING2 -> RING3 kernel mode. * RING3 -> RING3 user mode. -* However RING0 indicates that the guest kernel should return to iteself +* However RING0 indicates that the guest kernel should return to itself * directly with * orb $3,1*8(%rsp)
include/hw/xen/interface/arch-x86/xen.h +1 -1
@@ -140,5 +140,5 @@ typedef unsigned long xen_ulong_t;* interrupt. On x86/64, since rings 1 and 2 are unavailable, we allocate * privilege levels as follows: -* Level == 0: Noone may enter +* Level == 0: No one may enter * Level == 1: Kernel may enter * Level == 2: Kernel may enter
include/hw/xen/interface/event_channel.h +1 -1
@@ -320,5 +320,5 @@ typedef struct evtchn_set_priority evtchn_set_priority_t;* ` HYPERVISOR_event_channel_op_compat(struct evtchn_op *op) * ` -* Superceded by new event_channel_op() hypercall since 0x00030202. +* Superseded by new event_channel_op() hypercall since 0x00030202. */ struct evtchn_op {
include/hw/xen/interface/grant_table.h +1 -1
@@ -625,5 +625,5 @@ DEFINE_XEN_GUEST_HANDLE(gnttab_cache_flush_t);* GNTMAP_contains_pte subflag: * 0 => This map request contains a host virtual address. -* 1 => This map request contains the machine addess of the PTE to update. +* 1 => This map request contains the machine address of the PTE to update. */ #define _GNTMAP_contains_pte (4)
include/hw/xen/interface/hvm/hvm_op.h +1 -1
@@ -355,5 +355,5 @@ struct xen_hvm_altp2m_op {/* Get the active vcpu p2m index */ #define HVMOP_altp2m_get_p2m_idx 14 -/* Set the "Supress #VE" bit for a range of pages */ +/* Set the "Suppress #VE" bit for a range of pages */ #define HVMOP_altp2m_set_suppress_ve_multi 15/* Set visibility for a given altp2m view */
include/hw/xen/interface/io/blkif.h +3 -3
@@ -60,5 +60,5 @@* values are encoded in decimal. Integer value ranges listed below are * expressed as fixed sized integer types capable of storing the conversion -* of a properly formated node string, without loss of information. +* of a properly formatted node string, without loss of information. * * Any specified default value is in effect if the corresponding XenBus node
@@ -259,5 +259,5 @@* * NOTE: Because of implementation bugs in some frontends this must be -* set to 512, unless the frontend advertizes a non-zero value +* set to 512, unless the frontend advertises a non-zero value * in its "feature-large-sector-size" xenbus node. (See below). *
@@ -416,5 +416,5 @@* (9) Linux implementation doesn't have a limit on the maximum number of * grants that can be persistently mapped in the frontend driver, but -* due to the frontent driver implementation it should never be bigger +* due to the frontend driver implementation it should never be bigger * than RING_SIZE * BLKIF_MAX_SEGMENTS_PER_REQUEST. *(10) The discard-secure property may be present and will be set to 1 if the
include/hw/xen/interface/io/fbif.h +1 -1
@@ -90,5 +90,5 @@ union xenfb_out_event* refresh the framebuffer (and send an update notification event if * those have been requested), then use the update frequency to guide -* their periodical refreshs. +* their periodical refreshes. */ #define XENFB_TYPE_REFRESH_PERIOD 1
include/hw/xen/interface/io/kbdif.h +1 -1
@@ -40,5 +40,5 @@* values are encoded in decimal. Integer value ranges listed below are * expressed as fixed sized integer types capable of storing the conversion -* of a properly formated node string, without loss of information. +* of a properly formatted node string, without loss of information. * *****************************************************************************
include/hw/xen/interface/memory.h +1 -1
@@ -185,5 +185,5 @@ struct xen_machphys_mfn_list {/* * Pointer to buffer to fill with list of extent starts. If there are -* any large discontiguities in the machine address space, 2MB gaps in +* any large discontinuities in the machine address space, 2MB gaps in * the machphys table will be represented by an MFN base of zero. */
include/hw/xen/interface/physdev.h +2 -2
@@ -224,5 +224,5 @@ DEFINE_XEN_GUEST_HANDLE(physdev_manage_pci_ext_t);/* -* Argument to physdev_op_compat() hypercall. Superceded by new physdev_op() +* Argument to physdev_op_compat() hypercall. Superseded by new physdev_op() * hypercall since 0x00030202. */
@@ -350,5 +350,5 @@ DEFINE_XEN_GUEST_HANDLE(physdev_dbgp_op_t);#if __XEN_INTERFACE_VERSION__ <0x00040600 /* -* These all-capitals physdev operation names are superceded by the new names +* These all-capitals physdev operation names are superseded by the new names * (defined above) since interface version 0x00030202. The guard above was * added post-4.5 only though and hence shouldn't check for 0x00030202.
include/hw/xen/interface/xen.h +2 -2
@@ -607,5 +607,5 @@ DEFINE_XEN_GUEST_HANDLE(mmuext_op_t);/* -* DOMID_COW is used as the owner of sharable pages */ +* DOMID_COW is used as the owner of shareable pages */ #define DOMID_COW xen_mk_uint(0x7FF3)
@@ -751,5 +751,5 @@ struct shared_info {* 1. Bi-directional inter- and intra-domain connections. Domains must * arrange out-of-band to set up a connection (usually by allocating -* an unbound 'listener' port and avertising that via a storage service +* an unbound 'listener' port and advertising that via a storage service * such as xenstore). * 2. Physical interrupts. A domain with suitable hardware-access
Signature · 1 line
2.39.2
PATCH 18/24 audio: spelling fixes
In reply to Michael Tokarev--- audio/mixeng.h | 2 +- hw/audio/fmopl.c | 8 ++++---- hw/audio/fmopl.h | 2 +- hw/audio/gusemu_hal.c | 4 ++-- hw/audio/intel-hda-defs.h | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-)
audio/mixeng.h +1 -1
@@ -39,5 +39,5 @@ typedef void (t_sample) (struct st_sample *dst, const void *src, int samples);typedef void (f_sample ) (void *dst,const struct st_sample *src,int samples); -/* indices: [stereo][signed][swap endiannes][8, 16 or 32-bits] */ +/* indices: [stereo][signed][swap endianness][8, 16 or 32-bits] */ extern t_sample *mixeng_conv[2 ][2 ][2 ][3 ];extern f_sample *mixeng_clip[2 ][2 ][2 ][3 ];
hw/audio/fmopl.c +4 -4
@@ -356,5 +356,5 @@ static void set_algorithm( OPL_CH *CH) } -/* ---------- frequency counter for operater update ---------- */ +/* ---------- frequency counter for operator update ---------- */ static inline void CALC_FCSLOT (OPL_CH *CH ,OPL_SLOT *SLOT ) {
@@ -641,5 +641,5 @@ static int OPLOpenTable( void ) } -/* make sinwave table (total level offet) */ +/* make sinwave table (total level offset) */ /* degree 0 = degree 180 = off */ SIN_TABLE [0 ] =SIN_TABLE [SIN_ENT /2 ] = &TL_TABLE [EG_ENT -1 ];
@@ -1076,5 +1076,5 @@ FM_OPL *OPLCreate(int clock, int rate)FM_OPL *OPL ;int state_size; -int max_ch =9 ;/* normaly 9 channels */ +int max_ch =9 ;/* normally 9 channels */ if (OPL_LockTable () ==-1 )return NULL ;
@@ -1093,5 +1093,5 @@ FM_OPL *OPLCreate(int clock, int rate)OPL ->rate = rate;OPL ->max_ch = max_ch; -/* init grobal tables */ +/* init global tables */ OPL_initialize (OPL );/* reset chip */
hw/audio/fmopl.h +1 -1
@@ -70,5 +70,5 @@ typedef struct fm_opl_f {OPL_CH *P_CH ;/* pointer of CH */ int max_ch;/* maximum channel */ -/* Rhythm sention */ +/* Rhythm section */ uint8_t rhythm;/* Rhythm mode , key flag */ /* time tables */
hw/audio/gusemu_hal.c +2 -2
@@ -155,5 +155,5 @@ unsigned int gus_read(GUSEmuState * state, int port, int size) {int offset =2 * (GUSregb (FunkSelReg3x3) &0x0f ); - offset += ((int )GUSregb (VoiceSelReg3x2) &0x1f ) <<5 ;/* = Voice*32 + Funktion*2 */ + offset += ((int )GUSregb (VoiceSelReg3x2) &0x1f ) <<5 ;/* = Voice*32 + Function*2 */ value_read =GUSregw (offset); }
@@ -354,5 +354,5 @@ void gus_write(GUSEmuState * state, int port, int size, unsigned int data)break ;/* reset flag active? */ offset =2 * (GUSregb (FunkSelReg3x3) &0x0f ); - offset += (GUSregb (VoiceSelReg3x2) &0x1f ) <<5 ;/* = Voice*32 + Funktion*2 */ + offset += (GUSregb (VoiceSelReg3x2) &0x1f ) <<5 ;/* = Voice*32 + Function*2 */ GUSregw (offset) = (uint16_t ) ((GUSregw (offset) & readmask) | writedata); }
hw/audio/intel-hda-defs.h +2 -2
@@ -419,5 +419,5 @@ enum {#define AC_UNSOL_RES_CP_READY (1<<0)/* content protection */ -/* Pin widget capabilies */ +/* Pin widget capabilities */ #define AC_PINCAP_IMP_SENSE (1<<0)/* impedance sense capable */ #define AC_PINCAP_TRIG_REQ (1<<1)/* trigger required */
@@ -484,5 +484,5 @@ enum {#define AC_PWRST_D3 0x03 -/* Processing capabilies */ +/* Processing capabilities */ #define AC_PCAP_BENIGN (1<<0)#define AC_PCAP_NUM_COEF (0xff<<8)
Signature · 1 line
2.39.2
PATCH 19/24 hw/other: spelling fixes
In reply to Michael Tokarev--- hw/acpi/aml-build.c | 6 +++--- hw/acpi/hmat.c | 2 +- hw/acpi/nvdimm.c | 2 +- hw/block/hd-geometry.c | 4 ++-- hw/block/pflash_cfi01.c | 2 +- hw/char/cadence_uart.c | 2 +- hw/char/imx_serial.c | 2 +- hw/char/serial.c | 2 +- hw/core/generic-loader.c | 4 ++-- hw/core/machine.c | 2 +- hw/core/qdev-properties-system.c | 2 +- hw/cpu/a15mpcore.c | 2 +- hw/cxl/cxl-events.c | 2 +- hw/cxl/cxl-mailbox-utils.c | 4 ++-- hw/dma/omap_dma.c | 4 ++-- hw/input/hid.c | 2 +- hw/input/tsc2005.c | 16 ++++++++-------- hw/intc/loongarch_extioi.c | 2 +- hw/intc/loongson_liointc.c | 2 +- hw/intc/omap_intc.c | 2 +- hw/intc/pnv_xive.c | 2 +- hw/intc/spapr_xive.c | 2 +- hw/intc/spapr_xive_kvm.c | 6 +++--- hw/intc/xive.c | 2 +- hw/intc/xive2.c | 6 +++--- hw/ipmi/ipmi_bmc_extern.c | 2 +- hw/mem/cxl_type3.c | 6 +++--- hw/misc/imx7_ccm.c | 2 +- hw/misc/mac_via.c | 2 +- hw/misc/stm32f2xx_syscfg.c | 4 ++-- hw/misc/trace-events | 2 +- hw/misc/zynq_slcr.c | 2 +- hw/nvme/ctrl.c | 6 +++--- hw/nvram/eeprom_at24c.c | 2 +- hw/nvram/fw_cfg.c | 2 +- hw/rtc/exynos4210_rtc.c | 2 +- hw/rx/rx62n.c | 2 +- hw/scsi/lsi53c895a.c | 2 +- hw/scsi/mfi.h | 2 +- hw/sd/sd.c | 2 +- hw/sd/sdhci.c | 2 +- hw/sensor/isl_pmbus_vr.c | 2 +- hw/sensor/max34451.c | 2 +- hw/sh4/sh7750_regs.h | 26 +++++++++++++------------- hw/smbios/smbios.c | 2 +- hw/ssi/xilinx_spips.c | 6 +++--- hw/ssi/xlnx-versal-ospi.c | 2 +- hw/timer/etraxfs_timer.c | 2 +- hw/timer/renesas_tmr.c | 2 +- hw/virtio/virtio-crypto.c | 4 ++-- hw/virtio/virtio-mem.c | 2 +- hw/virtio/virtio.c | 2 +- 52 files changed, 89 insertions(+), 89 deletions(-)
hw/acpi/aml-build.c +3 -3
@@ -313,5 +313,5 @@ build_prepend_package_length(GArray *package, unsigned length, bool incl_self)* PkgLength is the length of the inclusive length of the data * and PkgLength's length itself when used for terms with -* explitit length. +* explicit length. */ length += length_bytes;
@@ -681,5 +681,5 @@ Aml *aml_store(Aml *val, Aml *target)* pattern. * -* Returns: The newly allocated and composed according to patter Aml object. +* Returns: The newly allocated and composed according to pattern Aml object. */ static Aml *
@@ -2160,5 +2160,5 @@ void build_fadt(GArray *tbl, BIOSLinker *linker, const AcpiFadtData *f,build_append_int_noprefix (tbl, f->minor_ver,1 ); }else { -build_append_int_noprefix (tbl,0 ,3 );/* Reserved upto ACPI 5.0 */ +build_append_int_noprefix (tbl,0 ,3 );/* Reserved up to ACPI 5.0 */ }build_append_int_noprefix (tbl,0 ,8 );/* X_FIRMWARE_CTRL */
hw/acpi/hmat.c +1 -1
@@ -83,5 +83,5 @@ static void build_hmat_lb(GArray *table_data, HMAT_LB_Info *hmat_lb,/* Length in bytes for entire structure */ uint32_t lb_length - =32 /* Table length upto and including Entry Base Unit */ + =32 /* Table length up to and including Entry Base Unit */ +4 * num_initiator/* Initiator Proximity Domain List */ +4 * num_target/* Target Proximity Domain List */
hw/acpi/nvdimm.c +1 -1
@@ -1098,5 +1098,5 @@ static void nvdimm_build_common_dsm(Aml *dev,* DSDT tables revision number. If revision number is < 2, integer * size is 32 bits, otherwise it is 64 bits. -* Because of this CreateField() canot be used if RLEN < Integer Size. +* Because of this CreateField() cannot be used if RLEN < Integer Size. * * Also please note that APCI ASL operator SizeOf() doesn't support
hw/block/hd-geometry.c +2 -2
@@ -51,5 +51,5 @@ struct partition { }QEMU_PACKED ; -/* try to guess the disk logical geometry from the MSDOS partition table. +/* try to guess the disk logical geometry from the MS-DOS partition table. Return 0 if OK, -1 if could not guess */ static int guess_disk_lchs(BlockBackend *blk,
@@ -67,5 +67,5 @@ static int guess_disk_lchs(BlockBackend *blk,return -1 ; } -/* test msdos magic */ +/* test MS-DOS magic */ if (buf[510 ] !=0x55 || buf[511 ] !=0xaa ) {return -1 ;
hw/block/pflash_cfi01.c +1 -1
@@ -892,5 +892,5 @@ static Property pflash_cfi01_properties[] = {* ie the total size of the device divided by the sector length. * If we're emulating flash devices wired in parallel the actual -* number of blocks per indvidual device will differ. +* number of blocks per individual device will differ. */ DEFINE_PROP_UINT32("num-blocks", PFlashCFI01, nb_blocs, 0),
hw/char/cadence_uart.c +1 -1
@@ -576,5 +576,5 @@ static int cadence_uart_pre_load(void *opaque)CadenceUARTState *s = opaque; -/* the frequency will be overriden if the refclk field is present */ +/* the frequency will be overridden if the refclk field is present */ clock_set_hz (s->refclk,UART_DEFAULT_REF_CLK );return 0 ;
hw/char/imx_serial.c +1 -1
@@ -113,5 +113,5 @@ static void imx_serial_reset_at_boot(DeviceState *dev)/* -* enable the uart on boot, so messages from the linux decompresser +* enable the uart on boot, so messages from the linux decompressor * are visible. On real hardware this is done by the boot rom * before anything else is loaded.
hw/char/serial.c +1 -1
@@ -55,5 +55,5 @@#define UART_IIR_CTI 0x0C/* Character Timeout Indication */ -#define UART_IIR_FENF 0x80/* Fifo enabled, but not functionning */ +#define UART_IIR_FENF 0x80/* Fifo enabled, but not functioning */ #define UART_IIR_FE 0xC0/* Fifo enabled */
hw/core/generic-loader.c +2 -2
@@ -25,5 +25,5 @@* This device allows the user to monkey patch memory. To be able to do -* this it needs a backend to manage the datas, the same as other +* this it needs a backend to manage the data, the same as other * memory-related devices. In this case as the backend is so trivial we * have merged it with the frontend instead of creating and maintaining a
@@ -167,5 +167,5 @@ static void generic_loader_realize(DeviceState *dev, Error **errp) } -/* Convert the data endiannes */ +/* Convert the data endianness */ if (s->data_be) { s->data =cpu_to_be64 (s->data);
hw/core/machine.c +1 -1
@@ -1415,5 +1415,5 @@ void machine_run_board_init(MachineState *machine, const char *mem_path, Error *if (object_class_dynamic_cast (oc, machine_class->valid_cpu_types[i])) { -/* The user specificed CPU is in the valid field, we are +/* The user specified CPU is in the valid field, we are * good to go. */
hw/core/qdev-properties-system.c +1 -1
@@ -108,5 +108,5 @@ static void set_drive_helper(Object *obj, Visitor *v, const char *name,if (*ptr) { -/* BlockBackend alread exists. So, we want to change attached node */ +/* BlockBackend already exists. So, we want to change attached node */ blk = *ptr; ctx =blk_get_aio_context (blk);
hw/cpu/a15mpcore.c +1 -1
@@ -162,5 +162,5 @@ static void a15mp_priv_class_init(ObjectClass *klass, void *data) dc->realize = a15mp_priv_realize;device_class_set_props (dc, a15mp_priv_properties); -/* We currently have no savable state */ +/* We currently have no saveable state */ }
hw/cxl/cxl-events.c +1 -1
@@ -198,5 +198,5 @@ CXLRetCode cxl_event_clear_records(CXLDeviceState *cxlds, CXLClearEventPayload *QEMU_LOCK_GUARD (&log->lock);/* -* Must itterate the queue twice. +* Must iterate the queue twice. * "The device shall verify the event record handles specified in the input * payload are in temporal order. If the device detects an older event
hw/cxl/cxl-mailbox-utils.c +2 -2
@@ -40,5 +40,5 @@* setting the length, and returning a valid return code. * -* XXX: The handler need not worry about endianess. The payload is read out of +* XXX: The handler need not worry about endianness. The payload is read out of * a register interface that already deals with it. */
@@ -502,5 +502,5 @@ static CXLRetCode cmd_media_get_poison_list(struct cxl_cmd *cmd, query_start =ldq_le_p (&in->pa); -/* 64 byte alignemnt required */ +/* 64 byte alignment required */ if (query_start &0x3f ) {return CXL_MBOX_INVALID_INPUT ;
hw/dma/omap_dma.c +2 -2
@@ -248,5 +248,5 @@ static void omap_dma_deactivate_channel(struct omap_dma_s *s, } -/* Don't deactive the channel if it is synchronized and the DMA request is +/* Don't deactivate the channel if it is synchronized and the DMA request is active */ if (ch->sync && ch->enable && (s->dma->drqbmp & (1ULL << ch->sync)))
@@ -423,5 +423,5 @@ static void omap_dma_transfer_generic(struct soc_dma_ch_s *dma)if (ch->fs && ch->bs) { a->pck_element ++; -/* Check if a full packet has beed transferred. */ +/* Check if a full packet has been transferred. */ if (a->pck_element == a->pck_elements) { a->pck_element =0 ;
hw/input/hid.c +1 -1
@@ -210,5 +210,5 @@ static void hid_pointer_sync(DeviceState *dev) curr->dz =0 ; }else { -/* prepate next (clear rel, copy abs + btns) */ +/* prepare next (clear rel, copy abs + btns) */ if (hs->kind ==HID_MOUSE ) { next->xdx =0 ;
hw/input/tsc2005.c +8 -8
@@ -158,12 +158,12 @@ static uint16_t tsc2005_read(TSC2005State *s, int reg)return ret; -case 0x8 :/* AUX high treshold */ +case 0x8 :/* AUX high threshold */ return s->aux_thr[1 ]; -case 0x9 :/* AUX low treshold */ +case 0x9 :/* AUX low threshold */ return s->aux_thr[0 ]; -case 0xa :/* TEMP high treshold */ +case 0xa :/* TEMP high threshold */ return s->temp_thr[1 ]; -case 0xb :/* TEMP low treshold */ +case 0xb :/* TEMP low threshold */ return s->temp_thr[0 ];
@@ -187,15 +187,15 @@ static void tsc2005_write(TSC2005State *s, int reg, uint16_t data) {switch (reg) { -case 0x8 :/* AUX high treshold */ +case 0x8 :/* AUX high threshold */ s->aux_thr[1 ] = data;break ; -case 0x9 :/* AUX low treshold */ +case 0x9 :/* AUX low threshold */ s->aux_thr[0 ] = data;break ; -case 0xa :/* TEMP high treshold */ +case 0xa :/* TEMP high threshold */ s->temp_thr[1 ] = data;break ; -case 0xb :/* TEMP low treshold */ +case 0xb :/* TEMP low threshold */ s->temp_thr[0 ] = data;break ;
hw/intc/loongarch_extioi.c +1 -1
@@ -192,5 +192,5 @@ static MemTxResult extioi_writew(void *opaque, hwaddr addr, old_data = s->coreisr[cpu][index]; s->coreisr[cpu][index] = old_data & ~val; -/* write 1 to clear interrrupt */ +/* write 1 to clear interrupt */ old_data &= val; irq =ctz32 (old_data);
hw/intc/loongson_liointc.c +1 -1
@@ -1,4 +1,4 @@/* -* QEMU Loongson Local I/O interrupt controler. +* QEMU Loongson Local I/O interrupt controller. * * Copyright (c) 2020 Huacai Chen <[email protected]>
hw/intc/omap_intc.c +1 -1
@@ -69,5 +69,5 @@ static void omap_inth_sir_update(OMAPIntcState *s, int is_fiq)/* Find the interrupt line with the highest dynamic priority. -* Note: 0 denotes the hightest priority. +* Note: 0 denotes the highest priority. * If all interrupts have the same priority, the default order is IRQ_N, * IRQ_N-1,...,IRQ_0. */
hw/intc/pnv_xive.c +1 -1
@@ -944,5 +944,5 @@ static void pnv_xive_ic_reg_write(void *opaque, hwaddr offset,case VC_SBC_CONFIG :/* Store EOI configuration */ /* -* Configure store EOI if required by firwmare (skiboot has removed +* Configure store EOI if required by firmware (skiboot has removed * support recently though) */
hw/intc/spapr_xive.c +1 -1
@@ -28,5 +28,5 @@/* -* XIVE Virtualization Controller BAR and Thread Managment BAR that we +* XIVE Virtualization Controller BAR and Thread Management BAR that we * use for the ESB pages and the TIMA pages */
hw/intc/spapr_xive_kvm.c +3 -3
@@ -486,5 +486,5 @@ static int kvmppc_xive_get_queues(SpaprXive *xive, Error **errp)* Whenever the VM is stopped, the VM change handler sets the source * PQs to PENDING to stop the flow of events and to possibly catch a -* triggered interrupt occuring while the VM is stopped. The previous +* triggered interrupt occurring while the VM is stopped. The previous * state is saved in anticipation of a migration. The XIVE controller * is then synced through KVM to flush any in-flight event
@@ -552,5 +552,5 @@ static void kvmppc_xive_change_state_handler(void *opaque, bool running,/* * PQ is set to PENDING to possibly catch a triggered -* interrupt occuring while the VM is stopped (hotplug event +* interrupt occurring while the VM is stopped (hotplug event * for instance) . */
@@ -634,5 +634,5 @@ int kvmppc_xive_post_load(SpaprXive *xive, int version_id)assert (xive->fd !=-1 ); -/* Restore the ENDT first. The targetting depends on it. */ +/* Restore the ENDT first. The targeting depends on it. */ for (i =0 ; i < xive->nr_ends; i++) {if (!xive_end_is_valid (&xive->endt[i])) {
hw/intc/xive.c +1 -1
@@ -1602,5 +1602,5 @@ int xive_presenter_tctx_match(XivePresenter *xptr, XiveTCTX *tctx,* It receives notification requests sent by the IVRE to find one * matching NVT (or more) dispatched on the processor threads. In case -* of a single NVT notification, the process is abreviated and the +* of a single NVT notification, the process is abbreviated and the * thread is signaled if a match is found. In case of a logical server * notification (bits ignored at the end of the NVT identifier), the
hw/intc/xive2.c +3 -3
@@ -543,5 +543,5 @@ static void xive2_router_realize(DeviceState *dev, Error **errp)/* * Notification using the END ESe/ESn bit (Event State Buffer for -* escalation and notification). Profide futher coalescing in the +* escalation and notification). Profide further coalescing in the * Router. */
@@ -622,5 +622,5 @@ static void xive2_router_end_notify(Xive2Router *xrtr, uint8_t end_blk,/* * Check the END ESn (Event State Buffer for notification) for -* even futher coalescing in the Router +* even further coalescing in the Router */ if (!xive2_end_is_notify (&end)) {
@@ -703,5 +703,5 @@ do_escalation:/* * Check the END ESe (Event State Buffer for escalation) for even -* futher coalescing in the Router +* further coalescing in the Router */ if (!xive2_end_is_uncond_escalation (&end)) {
hw/ipmi/ipmi_bmc_extern.c +1 -1
@@ -302,5 +302,5 @@ static void handle_msg(IPMIBmcExtern *ibe)return ; }else { - ibe->inpos--;/* Remove checkum */ + ibe->inpos--;/* Remove checksum */ }
hw/mem/cxl_type3.c +3 -3
@@ -539,5 +539,5 @@ static void ct3d_reg_write(void *opaque, hwaddr offset, uint64_t value, }else {/* -* If no more errors, then follow recomendation of PCI spec +* If no more errors, then follow recommendation of PCI spec * r6.0 6.2.4.2 to set the first error pointer to a status * bit that will never be used.
@@ -698,5 +698,5 @@ static void ct3_realize(PCIDevice *pci_dev, Error **errp) &ct3d->cxl_dstate.device_registers); -/* MSI(-X) Initailization */ +/* MSI(-X) Initialization */ rc =msix_init_exclusive_bar (pci_dev, msix_num,4 ,NULL );if (rc) {
@@ -707,5 +707,5 @@ static void ct3_realize(PCIDevice *pci_dev, Error **errp) } -/* DOE Initailization */ +/* DOE Initialization */ pcie_doe_init (pci_dev, &ct3d->doe_cdat,0x190 , doe_cdat_prot, true,0 );
hw/misc/imx7_ccm.c +1 -1
@@ -228,5 +228,5 @@ static uint32_t imx7_ccm_get_clock_frequency(IMXCCMState *dev, IMXClk clock)* easily. However for CCM provided clocks (like IPG) each GPT * timer can have its own clock root. -* This means we need additionnal information when calling this +* This means we need additional information when calling this * function to know the requester's identity. */
hw/misc/mac_via.c +1 -1
@@ -247,5 +247,5 @@#define vT2CH 0x1200/* [VIA only] Timer two counter high. */ #define vSR 0x1400/* [VIA only] Shift register. */ -#define vACR 0x1600/* [VIA only] Auxilary control register. */ +#define vACR 0x1600/* [VIA only] Auxiliary control register. */ #define vPCR 0x1800/* [VIA only] Peripheral control register. */ /*
hw/misc/stm32f2xx_syscfg.c +2 -2
@@ -95,10 +95,10 @@ static void stm32f2xx_syscfg_write(void *opaque, hwaddr addr,case SYSCFG_MEMRMP :qemu_log_mask (LOG_UNIMP , -"%s: Changeing the memory mapping isn't supported " \ +"%s: Changing the memory mapping isn't supported " \"in QEMU\n" , __func__);return ;case SYSCFG_PMC :qemu_log_mask (LOG_UNIMP , -"%s: Changeing the memory mapping isn't supported " \ +"%s: Changing the memory mapping isn't supported " \"in QEMU\n" , __func__);return ;
hw/misc/trace-events +1 -1
@@ -156,5 +156,5 @@ stm32f4xx_syscfg_write(uint64_t addr, uint64_t data) "reg write: addr: 0x%" PRIx # stm32f4xx_exti.c -stm32f4xx_exti_set_irq(int irq, int leve) "Set EXTI: %d to %d" +stm32f4xx_exti_set_irq(int irq, int level) "Set EXTI: %d to %d" stm32f4xx_exti_read(uint64_t addr) "reg read: addr: 0x%" PRIx64 " " stm32f4xx_exti_write(uint64_t addr, uint64_t data) "reg write: addr: 0x%" PRIx64 " val: 0x%" PRIx64 ""
hw/misc/zynq_slcr.c +1 -1
@@ -286,5 +286,5 @@ static void zynq_slcr_compute_clocks_internal(ZynqSLCRState *s, uint64_t ps_clk)/** -* Compute and set the ouputs clocks periods. +* Compute and set the outputs clocks periods. * But do not propagate them further. Connected clocks * will not receive any updates (See zynq_slcr_compute_clocks())
hw/nvme/ctrl.c +3 -3
@@ -18,5 +18,5 @@* --------------------- * While QEMU coding style prefers lowercase hexadecimals in constants, the -* NVMe subsystem use thes format from the NVMe specifications in the comments +* NVMe subsystem use this format from the NVMe specifications in the comments * (i.e. 'h' suffix instead of '0x' prefix). *
@@ -731,5 +731,5 @@ static inline void nvme_sg_unmap(NvmeSg *sg)/* -* When metadata is transfered as extended LBAs, the DPTR mapped into `sg` +* When metadata is transferred as extended LBAs, the DPTR mapped into `sg` * holds both data and metadata. This function splits the data and metadata * into two separate QSG/IOVs.
@@ -7595,5 +7595,5 @@ static void nvme_process_db(NvmeCtrl *n, hwaddr addr, int val)* NVM Express v1.3d, Section 4.1 state: "If host software writes * an invalid value to the Submission Queue Tail Doorbell or -* Completion Queue Head Doorbell regiter and an Asynchronous Event +* Completion Queue Head Doorbell register and an Asynchronous Event * Request command is outstanding, then an asynchronous event is * posted to the Admin Completion Queue with a status code of
hw/nvram/eeprom_at24c.c +1 -1
@@ -52,5 +52,5 @@ struct EEPROMState {/* cells changed since last START? */ bool changed; -/* during WRITE, # of address bytes transfered */ +/* during WRITE, # of address bytes transferred */ uint8_t haveaddr;
hw/nvram/fw_cfg.c +1 -1
@@ -878,5 +878,5 @@ static struct {* Any sub-page size update to these table MRs will be lost during migration, * as we use aligned size in ram_load_precopy() -> qemu_ram_resize() path. -* In order to avoid the inconsistency in sizes save them seperately and +* In order to avoid the inconsistency in sizes save them separately and * migrate over in vmstate post_load(). */
hw/rtc/exynos4210_rtc.c +1 -1
@@ -203,5 +203,5 @@ static void exynos4210_rtc_update_freq(Exynos4210RTCState *s, freq = s->freq; -/* set frequncy for time generator */ +/* set frequency for time generator */ s->freq =RTC_BASE_FREQ / (1 <<TICCKSEL (reg_value));
hw/rx/rx62n.c +1 -1
@@ -115,5 +115,5 @@ static const uint8_t ipr_table[NR_IRQS] = {/* -* Level triggerd IRQ list +* Level triggered IRQ list * Not listed IRQ is Edge trigger. * See "11.3.1 Interrupt Vector Table" in hardware manual.
hw/scsi/lsi53c895a.c +1 -1
@@ -1322,5 +1322,5 @@ again:trace_lsi_execute_script_io_selected (id, insn & (1 <<3 ) ?" ATN" :"" ); -/* ??? Linux drivers compain when this is set. Maybe +/* ??? Linux drivers complain when this is set. Maybe it only applies in low-level mode (unimplemented). lsi_script_scsi_interrupt(s, LSI_SIST0_CMP, 0); */
hw/scsi/mfi.h +1 -1
@@ -66,5 +66,5 @@#define MFI_DIAG 0xf8/* Host diag */ #define MFI_SEQ 0xfc/* Sequencer offset */ -#define MFI_1078_EIM 0x80000004/* 1078 enable intrrupt mask */ +#define MFI_1078_EIM 0x80000004/* 1078 enable interrupt mask */ #define MFI_RMI 0x2/* reply message interrupt */ #define MFI_1078_RM 0x80000000/* reply 1078 message interrupt */
hw/sd/sd.c +1 -1
@@ -1225,5 +1225,5 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req)break ; -/* Block read commands (Classs 2) */ +/* Block read commands (Class 2) */ case 16 :/* CMD16: SET_BLOCKLEN */ switch (sd->state) {
hw/sd/sdhci.c +1 -1
@@ -1812,5 +1812,5 @@ usdhc_write(void *opaque, hwaddr offset, uint64_t val, unsigned size)* * We don't want to call sdhci_write(.., SDHC_TRNMOD, ...) -* here becuase it will result in a call to +* here because it will result in a call to * sdhci_send_command(s) which we don't want. *
hw/sensor/isl_pmbus_vr.c +1 -1
@@ -102,5 +102,5 @@ static void isl_pmbus_vr_exit_reset(Object *obj) } -/* The raa228000 uses different direct mode coefficents from most isl devices */ +/* The raa228000 uses different direct mode coefficients from most isl devices */ static void raa228000_exit_reset (Object *obj) {
hw/sensor/max34451.c +1 -1
@@ -735,5 +735,5 @@ static void max34451_init(Object *obj)/* * get and set the temperature of the internal temperature sensor in -* centidegrees Celcius i.e.: 2500 -> 25.00 C, max is 327.67 C +* centidegrees Celsius i.e.: 2500 -> 25.00 C, max is 327.67 C */ for (int i =0 ; i <MAX34451_NUM_TEMP_DEVICES ; i++) {
hw/sh4/sh7750_regs.h +13 -13
@@ -114,5 +114,5 @@#define SH7750_TTB_A7 SH7750_A7_REG32(SH7750_TTB_REGOFS) -/* TLB exeption address register - TEA */ +/* TLB exception address register - TEA */ #define SH7750_TEA_REGOFS 0x00000c/* offset */ #define SH7750_TEA SH7750_P4_REG32(SH7750_TEA_REGOFS)
@@ -184,10 +184,10 @@#define SH7750_TRA_IMM_S 2 -/* Exeption event register - EXPEVT */ +/* Exception event register - EXPEVT */ #define SH7750_EXPEVT_REGOFS 0x000024#define SH7750_EXPEVT SH7750_P4_REG32(SH7750_EXPEVT_REGOFS)#define SH7750_EXPEVT_A7 SH7750_A7_REG32(SH7750_EXPEVT_REGOFS) -#define SH7750_EXPEVT_EX 0x00000fff/* Exeption code */ +#define SH7750_EXPEVT_EX 0x00000fff/* Exception code */ #define SH7750_EXPEVT_EX_S 0
@@ -196,5 +196,5 @@#define SH7750_INTEVT SH7750_P4_REG32(SH7750_INTEVT_REGOFS)#define SH7750_INTEVT_A7 SH7750_A7_REG32(SH7750_INTEVT_REGOFS) -#define SH7750_INTEVT_EX 0x00000fff/* Exeption code */ +#define SH7750_INTEVT_EX 0x00000fff/* Exception code */ #define SH7750_INTEVT_EX_S 0
@@ -1275,13 +1275,13 @@* User Break Controller registers */ -#define SH7750_BARA 0x200000/* Break address regiser A */ -#define SH7750_BAMRA 0x200004/* Break address mask regiser A */ -#define SH7750_BBRA 0x200008/* Break bus cycle regiser A */ -#define SH7750_BARB 0x20000c/* Break address regiser B */ -#define SH7750_BAMRB 0x200010/* Break address mask regiser B */ -#define SH7750_BBRB 0x200014/* Break bus cycle regiser B */ -#define SH7750_BASRB 0x000018/* Break ASID regiser B */ -#define SH7750_BDRB 0x200018/* Break data regiser B */ -#define SH7750_BDMRB 0x20001c/* Break data mask regiser B */ +#define SH7750_BARA 0x200000/* Break address register A */ +#define SH7750_BAMRA 0x200004/* Break address mask register A */ +#define SH7750_BBRA 0x200008/* Break bus cycle register A */ +#define SH7750_BARB 0x20000c/* Break address register B */ +#define SH7750_BAMRB 0x200010/* Break address mask register B */ +#define SH7750_BBRB 0x200014/* Break bus cycle register B */ +#define SH7750_BASRB 0x000018/* Break ASID register B */ +#define SH7750_BDRB 0x200018/* Break data register B */ +#define SH7750_BDMRB 0x20001c/* Break data mask register B */ #define SH7750_BRCR 0x200020/* Break control register */
hw/smbios/smbios.c +1 -1
@@ -1111,5 +1111,5 @@ void smbios_get_tables(MachineState *ms,/* -* The offset determines if we need to keep additional space betweeen +* The offset determines if we need to keep additional space between * table 17 and table 19 header handle numbers so that they do * not overlap. For example, for a VM with larger than 8 TB guest
hw/ssi/xilinx_spips.c +3 -3
@@ -164,5 +164,5 @@/* Poll timeout not implemented */ FIELD (GQSPI_CNFG ,EN_POLL_TIMEOUT ,20 ,1 ) - /* QEMU doesnt care about any of these last three */ + /* QEMU doesn't care about any of these last three */ FIELD(GQSPI_CNFG, BR, 3, 3)FIELD (GQSPI_CNFG ,CPH ,2 ,1 )
@@ -470,5 +470,5 @@ static void xlnx_zynqmp_qspips_flush_fifo_g(XlnxZynqMPQSPIPS *s) imm =ARRAY_FIELD_EX32 (s->regs,GQSPI_GF_SNAPSHOT ,IMMEDIATE_DATA );if (!ARRAY_FIELD_EX32 (s->regs,GQSPI_GF_SNAPSHOT ,DATA_XFER )) { -/* immedate transfer */ +/* immediate transfer */ if (ARRAY_FIELD_EX32 (s->regs,GQSPI_GF_SNAPSHOT ,TRANSMIT ) ||ARRAY_FIELD_EX32 (s->regs,GQSPI_GF_SNAPSHOT ,RECIEVE )) {
@@ -769,5 +769,5 @@ static void xilinx_spips_check_zero_pump(XilinxSPIPS *s)while (s->regs[R_TRANSFER_SIZE ] && s->rx_fifo.num + s->tx_fifo.num <RXFF_A_Q -3 ) { -/* endianess just doesn't matter when zero pumping */ +/* endianness just doesn't matter when zero pumping */ tx_data_bytes (&s->tx_fifo,0 ,4 , false); s->regs[R_TRANSFER_SIZE ] &= ~0x03ull ;
hw/ssi/xlnx-versal-ospi.c +1 -1
@@ -838,5 +838,5 @@ static void ospi_do_ind_read(XlnxVersalOspi *s)while (!ospi_ind_op_completed (op) && !fifo8_is_full (&s->rx_sram)) { -/* Read reqested number of bytes, max bytes limited to size of sram */ +/* Read requested number of bytes, max bytes limited to size of sram */ next_b =ind_op_next_byte (op); end_b = next_b +fifo8_num_free (&s->rx_sram);
hw/timer/etraxfs_timer.c +1 -1
@@ -237,5 +237,5 @@ static void watchdog_hit(void *opaque)ETRAXTimerState *t = opaque;if (t->wd_hits ==0 ) { -/* real hw gives a single tick before reseting but we are +/* real hw gives a single tick before resetting but we are a bit friendlier to compensate for our slower execution. */ ptimer_set_count (t->ptimer_wd,10 );
hw/timer/renesas_tmr.c +1 -1
@@ -116,5 +116,5 @@ static int elapsed_time(RTMRState *tmr, int ch, int64_t delta) tmr->div_round[ch] %= divrate; }else { -/* disble clock. so no update */ +/* disable clock. so no update */ et =0 ; }
hw/virtio/virtio-crypto.c +2 -2
@@ -656,5 +656,5 @@ virtio_crypto_sym_op_helper(VirtIODevice *vdev, op_info->cipher_start_src_offset = cipher_start_src_offset; op_info->len_to_cipher = len_to_cipher; -/* Handle the initilization vector */ +/* Handle the initialization vector */ if (op_info->iv_len >0 ) {DPRINTF ("iv_len=%" PRIu32"\n" , op_info->iv_len);
@@ -1279,5 +1279,5 @@ static void virtio_crypto_instance_init(Object *obj)/* * The default config_size is sizeof(struct virtio_crypto_config). -* Can be overriden with virtio_crypto_set_config_size. +* Can be overridden with virtio_crypto_set_config_size. */ vcrypto->config_size =sizeof (struct virtio_crypto_config );
hw/virtio/virtio-mem.c +1 -1
@@ -1120,5 +1120,5 @@ static int virtio_mem_mig_sanity_checks_post_load(void *opaque, int version_id) }/* -* Note: Preparation for resizeable memory regions. The maximum size +* Note: Preparation for resizable memory regions. The maximum size * of the memory region must not change during migration. */
hw/virtio/virtio.c +1 -1
@@ -2097,5 +2097,5 @@ void virtio_queue_enable(VirtIODevice *vdev, uint32_t queue_index) * if (!virtio_vdev_has_feature(vdev, VIRTIO_F_VERSION_1)) { -error_report ("queue_enable is only suppported in devices of virtio " +error_report ("queue_enable is only supported in devices of virtio " "1.0 or later." ); }
Signature · 1 line
2.39.2
PATCH 20/24 include/: spelling fixes
In reply to Michael Tokarev--- include/block/block_int-common.h | 2 +- include/chardev/char-fe.h | 4 ++-- include/crypto/akcipher.h | 2 +- include/crypto/ivgen.h | 4 ++-- include/elf.h | 4 ++-- include/hw/acpi/aml-build.h | 2 +- include/hw/acpi/pc-hotplug.h | 2 +- include/hw/acpi/vmgenid.h | 2 +- include/hw/boards.h | 6 +++--- include/hw/char/avr_usart.h | 2 +- include/hw/clock.h | 2 +- include/hw/core/tcg-cpu-ops.h | 2 +- include/hw/cxl/cxl_device.h | 2 +- include/hw/hyperv/vmbus.h | 2 +- include/hw/i2c/npcm7xx_smbus.h | 2 +- include/hw/misc/auxbus.h | 2 +- include/hw/misc/macio/pmu.h | 2 +- include/hw/net/mii.h | 2 +- include/hw/pci-host/dino.h | 2 +- include/hw/pci/pcie_aer.h | 2 +- include/hw/ssi/xilinx_spips.h | 2 +- include/hw/virtio/virtio-net.h | 2 +- include/io/channel-socket.h | 4 ++-- include/io/task.h | 2 +- include/qemu/iova-tree.h | 4 ++-- include/qemu/yank.h | 2 +- include/sysemu/cryptodev-vhost.h | 2 +- include/sysemu/cryptodev.h | 6 +++--- include/sysemu/iothread.h | 2 +- include/sysemu/stats.h | 2 +- include/sysemu/tpm_backend.h | 2 +- include/tcg/helper-info.h | 2 +- include/tcg/tcg.h | 4 ++-- include/ui/kbd-state.h | 2 +- include/ui/spice-display.h | 2 +- include/user/safe-syscall.h | 2 +- 36 files changed, 46 insertions(+), 46 deletions(-)
include/block/block_int-common.h +1 -1
@@ -419,5 +419,5 @@ struct BlockDriver {/** * Called to inform the driver that the set of cumulative set of used -* permissions for @bs has changed to @perm, and the set of sharable +* permissions for @bs has changed to @perm, and the set of shareable * permission to @shared. The driver can use this to propagate changes to * its children (i.e. request permissions only if a parent actually needs
include/chardev/char-fe.h +2 -2
@@ -79,5 +79,5 @@ bool qemu_chr_fe_backend_open(CharBackend *be);* @opaque: an opaque pointer for the callbacks * @context: a main loop context or NULL for the default -* @set_open: whether to call qemu_chr_fe_set_open() implicitely when +* @set_open: whether to call qemu_chr_fe_set_open() implicitly when * any of the handler is non-NULL * @sync_state: whether to issue event callback with updated state
@@ -139,5 +139,5 @@ void qemu_chr_fe_disconnect(CharBackend *be);* qemu_chr_fe_wait_connected: * -* Wait for characted backend to be connected, return < 0 on error or +* Wait for character backend to be connected, return < 0 on error or * if no associated Chardev. */
include/crypto/akcipher.h +1 -1
@@ -31,5 +31,5 @@ typedef struct QCryptoAkCipher QCryptoAkCipher;* @opts: the asymmetric key algorithm and related options * -* Determine if asymmetric key cipher decribed with @opts is +* Determine if asymmetric key cipher described with @opts is * supported by the current configured build *
include/crypto/ivgen.h +2 -2
@@ -33,5 +33,5 @@* * <example> -* <title>Encrypting block data with initialiation vectors</title> +* <title>Encrypting block data with initialization vectors</title> * <programlisting> * uint8_t *data = ....data to encrypt...
@@ -148,5 +148,5 @@ QCryptoIVGen *qcrypto_ivgen_new(QCryptoIVGenAlgorithm alg,* @errp: pointer to a NULL-initialized error object * -* Calculate a new initialiation vector for the data +* Calculate a new initialization vector for the data * to be stored in sector @sector. The IV will be * written into the buffer @iv of size @niv.
include/elf.h +2 -2
@@ -1126,7 +1126,7 @@ typedef struct {#define EFA_PARISC_2_0 0x0214/* PA-RISC 2.0 big-endian. */ -/* Additional section indeces. */ +/* Additional section indices. */ -#define SHN_PARISC_ANSI_COMMON 0xff00/* Section for tenatively declared +#define SHN_PARISC_ANSI_COMMON 0xff00/* Section for tentatively declared symbols in ANSI C. */ #define SHN_PARISC_HUGE_COMMON 0xff01/* Common blocks in huge model. */
include/hw/acpi/aml-build.h +1 -1
@@ -278,5 +278,5 @@ void free_aml_allocator(void);* * Joins Aml elements together and helps to construct AML tables -* Examle of usage: +* Example of usage: * Aml *table = aml_def_block("SSDT", ...); * Aml *sb = aml_scope("\\_SB");
include/hw/acpi/pc-hotplug.h +1 -1
@@ -14,5 +14,5 @@/* -* ONLY DEFINEs are permited in this file since it's shared +* ONLY DEFINEs are permitted in this file since it's shared * between C and ASL code. */
include/hw/acpi/vmgenid.h +1 -1
@@ -14,5 +14,5 @@#define VMGENID_FW_CFG_SIZE 4096/* Occupy a page of memory */ #define VMGENID_GUID_OFFSET 40/* allow space for -* OVMF SDT Header Probe Supressor +* OVMF SDT Header Probe Suppressor */
include/hw/boards.h +3 -3
@@ -159,5 +159,5 @@ typedef struct {* @cpu_index_to_instance_props: * used to provide @cpu_index to socket/core/thread number mapping, allowing -* legacy code to perform maping from cpu_index to topology properties +* legacy code to perform mapping from cpu_index to topology properties * Returns: tuple of socket/core/thread ids given cpu_index belongs to. * used to provide @cpu_index to socket number mapping, allowing
@@ -212,8 +212,8 @@ typedef struct {* allowed. * @default_ram_id: -* Specifies inital RAM MemoryRegion name to be used for default backend +* Specifies initial RAM MemoryRegion name to be used for default backend * creation if user explicitly hasn't specified backend with "memory-backend" * property. -* It also will be used as a way to optin into "-m" option support. +* It also will be used as a way to option into "-m" option support. * If it's not set by board, '-m' will be ignored and generic code will * not create default RAM MemoryRegion.
include/hw/char/avr_usart.h +1 -1
@@ -35,5 +35,5 @@#define USART_BRRL 0x04 -/* Relevant bits in regiters. */ +/* Relevant bits in registers. */ #define USART_CSRA_RXC (1 << 7)#define USART_CSRA_TXC (1 << 6)
include/hw/clock.h +1 -1
@@ -205,5 +205,5 @@ static inline bool clock_set_ns(Clock *clk, unsigned ns)* @clock_set(). This will update recursively all connected clocks. * It is an error to call this function on a clock which has a source. -* Note: this function must not be called during device inititialization +* Note: this function must not be called during device initialization * or migration. */
include/hw/core/tcg-cpu-ops.h +1 -1
@@ -15,5 +15,5 @@struct TCGCPUOps {/** -* @initialize: Initalize TCG state +* @initialize: Initialize TCG state * * Called when the first CPU is realized.
include/hw/cxl/cxl_device.h +1 -1
@@ -209,5 +209,5 @@ void cxl_event_set_status(CXLDeviceState *cxl_dstate, CXLEventLogType log_type,* > followed, the behavior is undefined * -* CXL 2.0 Errata F4 states futher that the layouts in the specification are +* CXL 2.0 Errata F4 states further that the layouts in the specification are * shown as greater than 128 bits, but implementations are expected to * use any size of access up to 64 bits.
include/hw/hyperv/vmbus.h +1 -1
@@ -52,5 +52,5 @@ struct VMBusDeviceClass {uint16_t mmio_size_mb; -/* Extentions to standard device callbacks */ +/* Extensions to standard device callbacks */ void (*vmdev_realize)(VMBusDevice *vdev,Error **errp);void (*vmdev_unrealize)(VMBusDevice *vdev);
include/hw/i2c/npcm7xx_smbus.h +1 -1
@@ -59,5 +59,5 @@ typedef enum NPCM7xxSMBusStatus {* @fif_ctl: The FIFO control register. * @fif_cts: The FIFO control status register. -* @fair_per: The fair preriod register. +* @fair_per: The fair period register. * @txf_ctl: The transmit FIFO control register. * @t_out: The SMBus timeout register.
include/hw/misc/auxbus.h +1 -1
@@ -107,5 +107,5 @@ void aux_bus_realize(AUXBus *bus);* Returns the reply of the request. * -* @bus Ths bus where the request happen. +* @bus The bus where the request happen. * @cmd The command requested. * @address The 20bits address of the slave.
include/hw/misc/macio/pmu.h +1 -1
@@ -77,5 +77,5 @@#define PMU_INT_AUTO_SRQ_POLL 0x02/* ??? */ -/* Bits in the environement message (either obtained via PMU_GET_COVER, +/* Bits in the environment message (either obtained via PMU_GET_COVER, * or via PMU_INT_ENVIRONMENT on core99 */ #define PMU_ENV_LID_CLOSED 0x01/* The lid is closed */
include/hw/net/mii.h +1 -1
@@ -72,5 +72,5 @@#define MII_BMSR_EXTCAP (1 << 0)/* Ext-reg capability */ -#define MII_ANAR_PAUSE_ASYM (1 << 11)/* Try for asymetric pause */ +#define MII_ANAR_PAUSE_ASYM (1 << 11)/* Try for asymmetric pause */ #define MII_ANAR_PAUSE (1 << 10)/* Try for pause */ #define MII_ANAR_TXFD (1 << 8)
include/hw/pci-host/dino.h +1 -1
@@ -1,4 +1,4 @@/* -* HP-PARISC Dino PCI chipset emulation, as in B160L and similiar machines +* HP-PARISC Dino PCI chipset emulation, as in B160L and similar machines * * (C) 2017-2019 by Helge Deller <[email protected]>
include/hw/pci/pcie_aer.h +1 -1
@@ -41,5 +41,5 @@ struct PCIEAERLog {* to avoid unreasonable memory usage. * I bet that 128 log size would be big enough, otherwise too many errors -* for system to function normaly. But could consecutive errors occur? +* for system to function normally. But could consecutive errors occur? */ #define PCIE_AER_LOG_MAX_DEFAULT 8
include/hw/ssi/xilinx_spips.h +1 -1
@@ -105,5 +105,5 @@ struct XlnxZynqMPQSPIPS {uint32_t regs[XLNX_ZYNQMP_SPIPS_R_MAX ]; -/* GQSPI has seperate tx/rx fifos */ +/* GQSPI has separate tx/rx fifos */ Fifo8 rx_fifo_g;Fifo8 tx_fifo_g;
include/hw/virtio/virtio-net.h +1 -1
@@ -110,5 +110,5 @@ typedef struct VirtioNetRscSeg {uint16_t packets;uint16_t dup_ack; -bool is_coalesced;/* need recal ipv4 header checksum, mark here */ +bool is_coalesced;/* need recall ipv4 header checksum, mark here */ VirtioNetRscUnit unit;NetClientState *nc;
include/io/channel-socket.h +2 -2
@@ -125,5 +125,5 @@ void qio_channel_socket_connect_async(QIOChannelSocket *ioc,* @ioc: the socket channel object * @addr: the address to listen to -* @num: the expected ammount of connections +* @num: the expected amount of connections * @errp: pointer to a NULL-initialized error object *
@@ -142,5 +142,5 @@ int qio_channel_socket_listen_sync(QIOChannelSocket *ioc,* @ioc: the socket channel object * @addr: the address to listen to -* @num: the expected ammount of connections +* @num: the expected amount of connections * @callback: the function to invoke on completion * @opaque: user data to pass to @callback
include/io/task.h +1 -1
@@ -146,5 +146,5 @@ typedef void (*QIOTaskWorker)(QIOTask *task,* in a background thread context, while still reporting the * results in the main event thread. This allows code which -* cannot easily be rewritten to be asychronous (such as DNS +* cannot easily be rewritten to be asynchronous (such as DNS * lookups) to be easily run non-blocking. Reporting the * results in the main thread context means that the caller
include/qemu/iova-tree.h +2 -2
@@ -16,5 +16,5 @@* information, and no extra user data is allowed for each element. A * benefit is that we can merge adjacent ranges internally within the -* tree. It can save a lot of memory when the ranges are splitted but +* tree. It can save a lot of memory when the ranges are split but * mostly continuous. *
@@ -129,5 +129,5 @@ const DMAMap *iova_tree_find_address(const IOVATree *tree, hwaddr iova);* * @tree: the iova tree to iterate on -* @iterator: the interator for the mappings, return true to stop +* @iterator: the iterator for the mappings, return true to stop * * Iterate over the iova tree.
include/qemu/yank.h +1 -1
@@ -26,5 +26,5 @@ typedef void (YankFn)(void *opaque);* @errp: Error object. * -* Returns true on success or false if an error occured. +* Returns true on success or false if an error occurred. */ bool yank_register_instance (const YankInstance *instance,Error **errp);
include/sysemu/cryptodev-vhost.h +1 -1
@@ -80,5 +80,5 @@ cryptodev_vhost_init(* @crypto: the cryptodev backend common vhost object * -* Clean the resouce associated with @crypto that realizaed +* Clean the resource associated with @crypto that realizaed * by cryptodev_vhost_init() *
include/sysemu/cryptodev.h +3 -3
@@ -340,5 +340,5 @@ void cryptodev_backend_free_client(* @errp: pointer to a NULL-initialized error object * -* Clean the resouce associated with @backend that realizaed +* Clean the resource associated with @backend that realizaed * by the specific backend's init() callback */
@@ -408,5 +408,5 @@ int cryptodev_backend_crypto_operation(* cryptodev_backend_set_used: * @backend: the cryptodev backend object -* @used: ture or false +* @used: true or false * * Set the cryptodev backend is used by virtio-crypto or not
@@ -428,5 +428,5 @@ bool cryptodev_backend_is_used(CryptoDevBackend *backend);* cryptodev_backend_set_ready: * @backend: the cryptodev backend object -* @ready: ture or false +* @ready: true or false * * Set the cryptodev backend is ready or not, which is called
include/sysemu/iothread.h +1 -1
@@ -60,5 +60,5 @@ void iothread_destroy(IOThread *iothread);/* -* Returns true if executing withing IOThread context, +* Returns true if executing within IOThread context, * false otherwise. */
include/sysemu/stats.h +1 -1
@@ -35,5 +35,5 @@ void add_stats_schema(StatsSchemaList **, StatsProvider, StatsTarget,/* -* True if a string matches the filter passed to the stats_fn callabck, +* True if a string matches the filter passed to the stats_fn callback, * false otherwise. *
include/sysemu/tpm_backend.h +1 -1
@@ -116,5 +116,5 @@ int tpm_backend_startup_tpm(TPMBackend *s, size_t buffersize);/** * tpm_backend_had_startup_error: -* @s: the backend to query for a statup error +* @s: the backend to query for a startup error * * Check whether the backend had an error during startup. Returns
include/tcg/helper-info.h +1 -1
@@ -1,4 +1,4 @@/* -* TCG Helper Infomation Structure +* TCG Helper Information Structure * * Copyright (c) 2023 Linaro Ltd
include/tcg/tcg.h +2 -2
@@ -880,5 +880,5 @@ enum {TCG_OPF_64BIT =0x10 ,/* Instruction is optional and not implemented by the host, or insn -is generic and should not be implemened by the host. */ +is generic and should not be implemented by the host. */ TCG_OPF_NOT_PRESENT = 0x20,/* Instruction operands are vectors. */
@@ -1124,5 +1124,5 @@ static inline int tcg_can_emit_vec_op(TCGOpcode o, TCGType t, unsigned ve)void tcg_expand_vec_op (TCGOpcode ,TCGType ,unsigned ,TCGArg , ...); -/* Replicate a constant C accoring to the log2 of the element size. */ +/* Replicate a constant C according to the log2 of the element size. */ uint64_t dup_const (unsigned vece,uint64_t c);
include/ui/kbd-state.h +1 -1
@@ -66,5 +66,5 @@ void qkbd_state_key_event(QKbdState *kbd, QKeyCode qcode, bool down);* * @kbd: state tracker state. -* @delay_ms: the delay in miliseconds. +* @delay_ms: the delay in milliseconds. */ void qkbd_state_set_delay (QKbdState *kbd,int delay_ms);
include/ui/spice-display.h +1 -1
@@ -43,5 +43,5 @@/* -* Internal enum to differenciate between options for +* Internal enum to differentiate between options for * io calls that have a sync (old) version and an _async (new) * version:
include/user/safe-syscall.h +1 -1
@@ -92,5 +92,5 @@* The basic setup is that we make the host syscall via a known * section of host native assembly. If a signal occurs, our signal -* handler checks the interrupted host PC against the addresse of that +* handler checks the interrupted host PC against the address of that * known section. If the PC is before or at the address of the syscall * instruction then we change the PC to point at a "return
Signature · 1 line
2.39.2
PATCH 21/24 scripts/: spelling fixes
In reply to Michael Tokarev--- scripts/checkpatch.pl | 2 +- scripts/ci/gitlab-pipeline-status | 2 +- scripts/codeconverter/codeconverter/qom_macros.py | 2 +- scripts/oss-fuzz/minimize_qtest_trace.py | 8 ++++---- scripts/performance/topN_callgrind.py | 2 +- scripts/performance/topN_perf.py | 2 +- scripts/qapi/gen.py | 2 +- scripts/replay-dump.py | 2 +- scripts/simplebench/bench_block_job.py | 2 +- 9 files changed, 12 insertions(+), 12 deletions(-)
scripts/checkpatch.pl +1 -1
@@ -1622,5 +1622,5 @@ sub process { qr/%[-+ *.0-9]*([hljztL]|ll|hh)?(x|X|"\s*PRI[xX][^"]*"?)/; - # don't consider groups splitted by [.:/ ], like 2A.20:12ab + # don't consider groups split by [.:/ ], like 2A.20:12ab my $tmpline = $rawline; $tmpline =~ s/($hex[.:\/ ])+$hex//g;
scripts/ci/gitlab-pipeline-status +1 -1
@@ -29,5 +29,5 @@ class CommunicationFailure(Exception): class NoPipelineFound(Exception): - """Communication is successfull but pipeline is not found.""" + """Communication is successful but pipeline is not found."""
scripts/codeconverter/codeconverter/qom_macros.py +1 -1
@@ -143,5 +143,5 @@ def make_structname(self) -> str: def strip_typedef(self) -> Patch: - """generate patch that will strip typedef from the struct declartion + """generate patch that will strip typedef from the struct declaration The caller is responsible for readding the typedef somewhere else.
scripts/oss-fuzz/minimize_qtest_trace.py +4 -4
@@ -3,5 +3,5 @@ """ -This takes a crashing qtest trace and tries to remove superflous operations +This takes a crashing qtest trace and tries to remove superfluous operations """
@@ -39,5 +39,5 @@ def usage(): -M1: enable a loop around the remove minimizer, which may help decrease some - timing dependant instructions. Off by default. + timing dependent instructions. Off by default. -M2: try setting bits in operand of write/out to zero. Off by default.
@@ -178,5 +178,5 @@ def remove_lines(newtrace, outpath): # from length/2^n bytes to the left does not work, try to move the pivot # to the right side, then add one to n, until length/2^n == 0. The idea - # is to prune unneccessary bytes from long writes, while accommodating + # is to prune unnecessary bytes from long writes, while accommodating # arbitrary MemoryRegion access sizes and alignments.
@@ -293,5 +293,5 @@ def minimize_trace(inpath, outpath): while(old_len > len(newtrace)): old_len = len(newtrace) - print("trace lenth = ", old_len) + print("trace length = ", old_len) remove_lines(newtrace, outpath) if not M1 and not M2:
scripts/performance/topN_callgrind.py +1 -1
@@ -5,5 +5,5 @@ # topN_callgrind.py [-h] [-n] <number of displayed top functions> -- \ # <qemu executable> [<qemu executable options>] \ -# <target executable> [<target execurable options>] +# <target executable> [<target executable options>] # # [-h] - Print the script arguments help message.
scripts/performance/topN_perf.py +1 -1
@@ -5,5 +5,5 @@ # topN_perf.py [-h] [-n] <number of displayed top functions> -- \ # <qemu executable> [<qemu executable options>] \ -# <target executable> [<target execurable options>] +# <target executable> [<target executable options>] # # [-h] - Print the script arguments help message.
scripts/qapi/gen.py +1 -1
@@ -82,5 +82,5 @@ def write(self, output_dir: str) -> None: os.makedirs(odir, exist_ok=True) - # use os.open for O_CREAT to create and read a non-existant file + # use os.open for O_CREAT to create and read a non-existent file fd = os.open(pathname, os.O_RDWR | os.O_CREAT, 0o666) with os.fdopen(fd, 'r+', encoding='utf-8') as fp:
scripts/replay-dump.py +1 -1
@@ -112,5 +112,5 @@ def print_event(eid, name, string=None, event_count=None): def decode_unimp(eid, name, _unused_dumpfile): - "Unimplimented decoder, will trigger exit" + "Unimplemented decoder, will trigger exit" print("%s not handled - will now stop" % (name)) return False
scripts/simplebench/bench_block_job.py +1 -1
@@ -40,5 +40,5 @@ def bench_block_job(cmd, cmd_args, qemu_args): Returns {'seconds': int} on success and {'error': str} on failure, dict may - contain addional 'vm-log' field. Return value is compatible with + contain additional 'vm-log' field. Return value is compatible with simplebench lib. """
Signature · 1 line
2.39.2
PATCH 22/24 tests/: spelling fixes
In reply to Michael Tokarev--- tests/avocado/acpi-bits.py | 4 ++-- tests/avocado/acpi-bits/bits-tests/testacpi.py2 | 4 ++-- tests/decode/err_pattern_group_ident2.decode | 2 +- tests/docker/common.rc | 2 +- tests/migration/guestperf-batch.py | 2 +- tests/migration/guestperf.py | 2 +- tests/plugin/mem.c | 2 +- tests/qapi-schema/bad-if-not.json | 2 +- tests/qemu-iotests/029 | 2 +- tests/qemu-iotests/040 | 8 ++++---- tests/qemu-iotests/046 | 2 +- tests/qemu-iotests/059 | 2 +- tests/qemu-iotests/061 | 2 +- tests/qemu-iotests/071 | 2 +- tests/qemu-iotests/197 | 2 +- tests/qemu-iotests/215 | 2 +- tests/qemu-iotests/298 | 2 +- tests/qemu-iotests/pylintrc | 2 +- tests/qtest/ahci-test.c | 2 +- tests/qtest/bcm2835-dma-test.c | 2 +- tests/qtest/bios-tables-test.c | 2 +- tests/qtest/ds1338-test.c | 2 +- tests/qtest/fuzz/generic_fuzz.c | 4 ++-- tests/qtest/libqos/qgraph.c | 4 ++-- tests/qtest/libqos/qgraph_internal.h | 2 +- tests/qtest/libqos/virtio-gpio.c | 2 +- tests/qtest/libqtest.c | 4 ++-- tests/qtest/migration-test.c | 6 +++--- tests/qtest/npcm7xx_timer-test.c | 2 +- tests/qtest/tpm-emu.c | 2 +- tests/qtest/tpm-tests.c | 2 +- tests/qtest/tpm-tests.h | 2 +- tests/qtest/tpm-tis-i2c-test.c | 2 +- tests/qtest/tpm-tis-util.c | 2 +- tests/qtest/vhost-user-blk-test.c | 2 +- tests/qtest/virtio-net-test.c | 2 +- tests/qtest/vmgenid-test.c | 2 +- tests/tsan/suppressions.tsan | 2 +- tests/uefi-test-tools/Makefile | 2 +- tests/unit/check-qjson.c | 2 +- tests/unit/test-aio.c | 2 +- tests/unit/test-bdrv-graph-mod.c | 12 ++++++------ tests/unit/test-crypto-secret.c | 2 +- tests/unit/test-qobject-input-visitor.c | 2 +- tests/unit/test-throttle.c | 4 ++-- tests/unit/test-util-filemonitor.c | 2 +- tests/unit/test-xs-node.c | 2 +- tests/vm/Makefile.include | 2 +- tests/vm/ubuntuvm.py | 2 +- 49 files changed, 65 insertions(+), 65 deletions(-)
tests/avocado/acpi-bits.py +2 -2
@@ -1,5 +1,5 @@ #!/usr/bin/env python3 # group: rw quick -# Exercize QEMU generated ACPI/SMBIOS tables using biosbits, +# Exercise QEMU generated ACPI/SMBIOS tables using biosbits, # https://biosbits.org/ #
@@ -367,5 +367,5 @@ def tearDown(self): def test_acpi_smbios_bits(self): - """The main test case implementaion.""" + """The main test case implementation.""" iso_file = os.path.join(self._workDir,
tests/avocado/acpi-bits/bits-tests/testacpi.py2 +2 -2
@@ -274,6 +274,6 @@ def test_rsdp(): # Checksum the first 20 bytes per ACPI 1.0 csum = sum(ord(c) for c in data[:20]) % 0x100 - testsuite.test('ACPI 1.0 table first 20 bytes cummulative checksum must equal 0', csum == 0) - testsuite.print_detail("Cummulative checksum = {} (Expected 0)".format(csum)) + testsuite.test('ACPI 1.0 table first 20 bytes cumulative checksum must equal 0', csum == 0) + testsuite.print_detail("Cumulative checksum = {} (Expected 0)".format(csum)) test_table_checksum(data)
tests/decode/err_pattern_group_ident2.decode +1 -1
@@ -8,4 +8,4 @@ top 00000000 00000000 00000000 00000000 sub1 00000000 00000000 00000000 ........ %sub1 -# comments are suposed to be indented +# comments are supposed to be indented }
tests/docker/common.rc +1 -1
@@ -13,5 +13,5 @@ # This might be set by ENV of a docker container... it is always -# overriden by TARGET_LIST if the user sets it. We special case +# overridden by TARGET_LIST if the user sets it. We special case # "none" to allow for other options like --disable-tcg to restrict the # builds we eventually do.
tests/migration/guestperf-batch.py +1 -1
@@ -1,5 +1,5 @@ #!/usr/bin/env python3 # -# Migration test batch comparison invokation +# Migration test batch comparison invocation # # Copyright (c) 2016 Red Hat, Inc.
tests/migration/guestperf.py +1 -1
@@ -1,5 +1,5 @@ #!/usr/bin/env python3 # -# Migration test direct invokation command +# Migration test direct invocation command # # Copyright (c) 2016 Red Hat, Inc.
tests/plugin/mem.c +1 -1
@@ -99,5 +99,5 @@ QEMU_PLUGIN_EXPORT int qemu_plugin_install(qemu_plugin_id_t id, rw =QEMU_PLUGIN_MEM_RW ; }else { -fprintf (stderr,"invaild value for argument track: %s\n" , opt); +fprintf (stderr,"invalid value for argument track: %s\n" , opt);return -1 ; }
tests/qapi-schema/bad-if-not.json +1 -1
@@ -1,3 +1,3 @@ -# check 'if not' with empy argument +# check 'if not' with empty argument { 'struct': 'TestIfStruct', 'data': { 'foo': 'int' }, 'if': { 'not': '' } }
tests/qemu-iotests/029 +1 -1
@@ -40,5 +40,5 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 . ./common.pattern -# Any format supporting intenal snapshots +# Any format supporting internal snapshots _supported_fmt qcow2 _supported_proto generic
tests/qemu-iotests/040 +4 -4
@@ -846,5 +846,5 @@ class TestCommitWithFilters(iotests.QMPTestCase): self.assertIsNotNone(self.vm.node_info('cow-1')) - # 2 has been comitted into 1 + # 2 has been committed into 1 self.pattern_files[2] = self.img1
@@ -864,5 +864,5 @@ class TestCommitWithFilters(iotests.QMPTestCase): self.assertIsNotNone(self.vm.node_info('cow-0')) - # 1 has been comitted into 0 + # 1 has been committed into 0 self.pattern_files[1] = self.img0
@@ -901,5 +901,5 @@ class TestCommitWithFilters(iotests.QMPTestCase): self.assertEqual(drv0['inserted']['node-name'], 'cow-2') - # 3 has been comitted into 2 + # 3 has been committed into 2 self.pattern_files[3] = self.img2
@@ -917,5 +917,5 @@ class TestCommitWithFilters(iotests.QMPTestCase): self.assertIsNotNone(self.vm.node_info('cow-2')) - # 3 has been comitted into 2 + # 3 has been committed into 2 self.pattern_files[3] = self.img2
tests/qemu-iotests/046 +1 -1
@@ -126,5 +126,5 @@ EOF # Sequential write, but the next cluster is already allocated -# and phyiscally in the right position +# and physically in the right position cat <<EOF write -P 89 0x80000 0x1000
tests/qemu-iotests/059 +1 -1
@@ -183,5 +183,5 @@ echo echo "=== Testing afl image with a very large capacity ===" _use_sample_img afl9.vmdk.bz2 -_img_info | grep -q 'Cannot allocate memory' && _notrun "Insufficent memory, skipped test" +_img_info | grep -q 'Cannot allocate memory' && _notrun "Insufficient memory, skipped test" _img_info _cleanup_test_img
tests/qemu-iotests/061 +1 -1
@@ -50,5 +50,5 @@ _supported_os Linux # require the default 64k cluster # we don't have explicit tests for zstd qcow2 compression type, as zstd may be -# not compiled in. And we can't create compat images with comression type +# not compiled in. And we can't create compat images with compression type # extension _unsupported_imgopts 'refcount_bits=\([^1]\|.\([^6]\|$\)\)' data_file \
tests/qemu-iotests/071 +1 -1
@@ -42,5 +42,5 @@ _supported_proto file fuse _require_drivers blkdebug blkverify # blkdebug can only inject errors on bs->file, not on the data_file, -# so thie test does not work with external data files +# so this test does not work with external data files _unsupported_imgopts data_file
tests/qemu-iotests/197 +1 -1
@@ -94,5 +94,5 @@ output=$($QEMU_IO -f qcow2 -C -c "read -P 0 1k $((2*1024*1024*1024 - 512))" \ case $output in *allocate*) - _notrun "Insufficent memory to run test" ;; + _notrun "Insufficient memory to run test" ;; *) printf '%s\n' "$output" ;; esac
tests/qemu-iotests/215 +1 -1
@@ -96,5 +96,5 @@ output=$($QEMU_IO \ case $output in *allocate*) - _notrun "Insufficent memory to run test" ;; + _notrun "Insufficient memory to run test" ;; *) printf '%s\n' "$output" ;; esac
tests/qemu-iotests/298 +1 -1
@@ -142,5 +142,5 @@ class TestTruncate(iotests.QMPTestCase): # Probably we'll want preallocate filter to keep align to cluster when - # shrink preallocation, so, ignore small differece + # shrink preallocation, so, ignore small difference self.assertLess(abs(stat.st_size - refstat.st_size), 64 * 1024)
tests/qemu-iotests/pylintrc +1 -1
@@ -20,5 +20,5 @@ disable=invalid-name, # pylint warns about Optional[] etc. as unsubscriptable in 3.9 unsubscriptable-object, - # pylint's static analysis causes false positivies for file_path(); + # pylint's static analysis causes false positives for file_path(); # If we really care to make it statically knowable, we'll use mypy. unbalanced-tuple-unpacking,
tests/qtest/ahci-test.c +1 -1
@@ -331,5 +331,5 @@ static void ahci_test_pci_spec(AHCIQState *ahci) g_assert_cmphex(datal, !=, 0); -/* Check specification adherence for capability extenstions. */ +/* Check specification adherence for capability extensions. */ data =qpci_config_readw (ahci->dev, datal);
tests/qtest/bcm2835-dma-test.c +1 -1
@@ -26,5 +26,5 @@#define BCM2708_DMA_INT_STATUS 0xfe0 -/* DMA Trasfer Info fields: */ +/* DMA Transfer Info fields: */ #define BCM2708_DMA_INT_EN (1 << 0)#define BCM2708_DMA_D_INC (1 << 4)
tests/qtest/bios-tables-test.c +1 -1
@@ -27,5 +27,5 @@* make check V=2 * this will produce a bunch of warnings about differences -* beween actual and expected ACPI tables. If you have IASL installed, +* between actual and expected ACPI tables. If you have IASL installed, * they will also be disassembled so you can look at the disassembled * output. If not - disassemble them yourself in any way you like.
tests/qtest/ds1338-test.c +1 -1
@@ -39,5 +39,5 @@ static void send_and_receive(void *obj, void *data, QGuestAllocator *alloc)i2c_read_block (i2cdev,0 , resp,sizeof (resp)); -/* check retrieved time againt local time */ +/* check retrieved time against local time */ g_assert_cmpuint(bcd2bin(resp[4]), == , tm_ptr->tm_mday); g_assert_cmpuint(bcd2bin(resp[5]), == , 1 + tm_ptr->tm_mon);
tests/qtest/fuzz/generic_fuzz.c +2 -2
@@ -847,7 +847,7 @@ static void generic_pre_fuzz(QTestState *s)* * This function attempts to produce an input that: -* Ouptut: maps a device's BARs, set up three DMA patterns, triggers +* Output: maps a device's BARs, set up three DMA patterns, triggers * functionality A device, replaces the DMA patterns with a single -* patten, and triggers device functionality B. +* pattern, and triggers device functionality B. */ static size_t generic_fuzz_crossover(const uint8_t *data1, size_t size1, const
tests/qtest/libqos/qgraph.c +2 -2
@@ -55,5 +55,5 @@ struct QOSStackElement { }; -/* Each enty in these hash table will consist of <string, node/edge> pair. */ +/* Each entry in these hash table will consist of <string, node/edge> pair. */ static GHashTable *edge_table;static GHashTable *node_table;
@@ -215,5 +215,5 @@ static QOSGraphEdge *search_list_edges(QOSGraphEdgeList *edgelist,* search_machine(): search for a machine @name in the node hash * table. A machine is the child of the root node. -* This function forces the research in the childs of the root, +* This function forces the research in the children of the root, * to check the node is a proper machine *
tests/qtest/libqos/qgraph_internal.h +1 -1
@@ -198,5 +198,5 @@ char *qos_graph_edge_get_name(QOSGraphEdge *edge);* to that @node name. * -* It performs a search only trough the list of machines +* It performs a search only through the list of machines * (i.e. the QOS_ROOT child). *
tests/qtest/libqos/virtio-gpio.c +1 -1
@@ -29,5 +29,5 @@ static void virtio_gpio_cleanup(QVhostUserGPIO *gpio)/* * This handles the VirtIO setup from the point of view of the driver -* frontend and therefor doesn't present any vhost specific features +* frontend and therefore doesn't present any vhost specific features * and in fact masks of the re-used bit. */
tests/qtest/libqtest.c +2 -2
@@ -113,5 +113,5 @@ static int socket_accept(int sock)int ret;/* -* timeout unit of blocking receive calls is different among platfoms. +* timeout unit of blocking receive calls is different among platforms. * It's in seconds on non-Windows platforms but milliseconds on Windows. */
@@ -1692,5 +1692,5 @@ QTestState *qtest_inproc_init(QTestState **s, bool log, const char* arch,qtest_client_set_rx_handler (qts, qtest_client_inproc_recv_line); -/* send() may not have a matching protoype, so use a type-safe wrapper */ +/* send() may not have a matching prototype, so use a type-safe wrapper */ qts->ops.external_send = send;qtest_client_set_tx_handler (qts, send_wrapper);
tests/qtest/migration-test.c +3 -3
@@ -487,5 +487,5 @@ static void migrate_ensure_converge(QTestState *who)* * Finally we go back to the source and read a byte just -* before the marker untill we see it flip in value. This +* before the marker until we see it flip in value. This * is proof that start_address -> MAGIC_OFFSET_BASE * is now dirty again.
@@ -827,5 +827,5 @@ static int test_migrate_start(QTestState **from, QTestState **to,/* * Remove shmem file immediately to avoid memory leak in test failed case. -* It's valid becase QEMU has already opened this file +* It's valid because QEMU has already opened this file */ if (args->use_shmem) {
@@ -2104,5 +2104,5 @@ static void test_migrate_auto_converge(void)/* * We want the test to be stable and as fast as possible. -* E.g., with 1Gb/s bandwith migration may pass without throttling, +* E.g., with 1Gb/s bandwidth migration may pass without throttling, * so we need to decrease a bandwidth. */
tests/qtest/npcm7xx_timer-test.c +1 -1
@@ -385,5 +385,5 @@ static void test_pause_resume(gconstpointer test_data) } -/* Verifies that the prescaler can be changed while the timer is runnin. */ +/* Verifies that the prescaler can be changed while the timer is running. */ static void test_prescaler_change (gconstpointer test_data) {
tests/qtest/tpm-emu.c +1 -1
@@ -78,5 +78,5 @@ static void *tpm_emu_tpm_thread(void *data)break ;default : -g_debug ("unsupport TPM version %u" , s->tpm_version); +g_debug ("unsupported TPM version %u" , s->tpm_version);g_assert_not_reached (); }
tests/qtest/tpm-tests.c +1 -1
@@ -1,4 +1,4 @@/* -* QTest TPM commont test code +* QTest TPM common test code * * Copyright (c) 2018 IBM Corporation
tests/qtest/tpm-tests.h +1 -1
@@ -1,4 +1,4 @@/* -* QTest TPM commont test code +* QTest TPM common test code * * Copyright (c) 2018 IBM Corporation
tests/qtest/tpm-tis-i2c-test.c +1 -1
@@ -469,5 +469,5 @@ static void tpm_tis_i2c_test_check_access_reg_release(const void *data)/* * highest locality should now be active; release it and make sure the -* next higest locality is active afterwards +* next highest locality is active afterwards */ for (l =TPM_TIS_NUM_LOCALITIES -2 ; l >=0 ; l--) {
tests/qtest/tpm-tis-util.c +1 -1
@@ -341,5 +341,5 @@ void tpm_tis_test_check_access_reg_release(const void *data)/* * highest locality should now be active; release it and make sure the -* next higest locality is active afterwards +* next highest locality is active afterwards */ for (l =TPM_TIS_NUM_LOCALITIES -2 ; l >=0 ; l--) {
tests/qtest/vhost-user-blk-test.c +1 -1
@@ -962,5 +962,5 @@ static void *vhost_user_blk_test_setup(GString *cmd_line, void *arg)* * Since vhost-user server only serves one vhost-user client one time, -* another exprot +* another export * */
tests/qtest/virtio-net-test.c +1 -1
@@ -213,5 +213,5 @@ static void announce_self(void *obj, void *data, QGuestAllocator *t_alloc)/* -* Stop the announcment by settings rounds to 0 on the +* Stop the announcement by settings rounds to 0 on the * existing timer. */
tests/qtest/vmgenid-test.c +1 -1
@@ -20,5 +20,5 @@#define VGID_GUID "324e6eaf-d1d1-4bf6-bf41-b9bb6c91fb87"#define VMGENID_GUID_OFFSET 40/* allow space for -* OVMF SDT Header Probe Supressor +* OVMF SDT Header Probe Suppressor */ #define RSDP_ADDR_INVALID 0x100000/* RSDP must be below this address */
tests/tsan/suppressions.tsan +1 -1
@@ -8,5 +8,5 @@ mutex:aio_context_acquire mutex:pthread_mutex_lock -# TSan reports a race betwen pthread_mutex_init() and +# TSan reports a race between pthread_mutex_init() and # pthread_mutex_lock(). Since this is outside of QEMU, # we choose to ignore it.
tests/uefi-test-tools/Makefile +1 -1
@@ -88,5 +88,5 @@ Build/%.fat: Build/%.efi # In turn, the "build" utility of edk2 BaseTools invokes another "make". -# Although the outer "make" process advertizes its job server to all child +# Although the outer "make" process advertises its job server to all child # processes via MAKEFLAGS in the environment, the outer "make" closes the job # server file descriptors (exposed in MAKEFLAGS) before executing a recipe --
tests/unit/check-qjson.c +1 -1
@@ -1487,5 +1487,5 @@ int main(int argc, char **argv)g_test_add_func ("/literals/interpolation/valid" , interpolation_valid); -g_test_add_func ("/literals/interpolation/unkown" , interpolation_unknown); +g_test_add_func ("/literals/interpolation/unknown" , interpolation_unknown);g_test_add_func ("/literals/interpolation/string" , interpolation_string);
tests/unit/test-aio.c +1 -1
@@ -455,5 +455,5 @@ static void test_timer_schedule(void) g_assert_cmpint(data.n, ==, 0); -/* timer_mod may well cause an event notifer to have gone off, +/* timer_mod may well cause an event notifier to have gone off, * so clear that */
tests/unit/test-bdrv-graph-mod.c +6 -6
@@ -99,7 +99,7 @@ static BlockDriverState *exclusive_writer_node(const char *name)* | shared: except write * v -* +-------------------+ +----------------+ -* | passtrough filter |---------->| null-co node | -* +-------------------+ +----------------+ +* +--------------------+ +----------------+ +* | passthrough filter |--------->| null-co node | +* +--------------------+ +----------------+ * *
@@ -115,7 +115,7 @@ static BlockDriverState *exclusive_writer_node(const char *name)* | shared: except write * v -* +-------------------+ -* | passtrough filter | -* +-------------------+ +* +--------------------+ +* | passthrough filter | +* +--------------------+ * | | * perm: write, read | | perm: write, read
tests/unit/test-crypto-secret.c +1 -1
@@ -245,5 +245,5 @@ static void test_secret_keyring_bad_key_access_right(void)Object *sec; -g_test_skip ("TODO: Need responce from Linux kernel maintainers" ); +g_test_skip ("TODO: Need response from Linux kernel maintainers" );return ;
tests/unit/test-qobject-input-visitor.c +1 -1
@@ -95,5 +95,5 @@ Visitor *visitor_input_test_init(TestInputVisitorData *data,/* similar to visitor_input_test_init(), but does not expect a string * literal/format json_string argument and so can be used for -* programatically generated strings (and we can't pass in programatically +* programmatically generated strings (and we can't pass in programmatically * generated strings via %s format parameters since qobject_from_jsonv() * will wrap those in double-quotes and treat the entire object as a
tests/unit/test-throttle.c +2 -2
@@ -136,5 +136,5 @@ static void test_compute_wait(void)g_assert (double_cmp (bkt.level, (i +1 ) * (bkt.max - bkt.avg) /10 ));/* We can do bursts for the 2 seconds we have configured in -* burst_length. We have 100 extra miliseconds of burst +* burst_length. We have 100 extra milliseconds of burst * because bkt.level has been leaking during this time. * After that, we have to wait. */
@@ -380,5 +380,5 @@ static void test_is_valid(void)/* zero are valids */ test_is_valid_for_value (0 , true); -/* positives numers are valids */ +/* positives numbers are valids */ test_is_valid_for_value (1 , true); }
tests/unit/test-util-filemonitor.c +1 -1
@@ -133,5 +133,5 @@ qemu_file_monitor_test_record_free(QFileMonitorTestRecord *rec)* emitted in the background thread running the event * loop, we can't assume there is a record available -* immediately. Thus we will sleep for upto 5 seconds +* immediately. Thus we will sleep for up to 5 seconds * to wait for the event to be queued for us. */
tests/unit/test-xs-node.c +1 -1
@@ -363,5 +363,5 @@ static void test_xs_node_simple(void)g_assert (!memcmp (data->data,"something" , data->len)); -/* Even if we use an abolute path */ +/* Even if we use an absolute path */ g_byte_array_set_size (data,0 ); err = xs_impl_read(s, DOMID_GUEST, XBT_NULL,
tests/vm/Makefile.include +1 -1
@@ -82,5 +82,5 @@ endif @echo " QEMU_LOCAL=1 - Use QEMU binary local to this build." @echo " TARGET_LIST=a,b,c - Override target list in builds" - @echo " V=1 - Enable verbose ouput on host and guest commands" + @echo " V=1 - Enable verbose output on host and guest commands" vm-build-all: $(addprefix vm-build-, $(IMAGES))
tests/vm/ubuntuvm.py +1 -1
@@ -52,5 +52,5 @@ def build_image(self, img): if self._config['install_cmds'] != "": # Issue the install commands. - # This can be overriden by the user in the config .yml. + # This can be overridden by the user in the config .yml. install_cmds = self._config['install_cmds'].split(',') for cmd in install_cmds:
Signature · 1 line
2.39.2
Re: [PATCH 22/24] tests/: spelling fixes
tests/qemu-iotests/298 class TestTruncate(iotests.QMPTestCase): · line 144
Quoted 9 lines · Michael Tokarev
Signed-off-by Michael Tokarev <[email protected]>---
+++ b/tests/qemu-iotests/298
tests/qemu-iotests/298 +1
-1@@ -142,5 +142,5 @@ class TestTruncate(iotests.QMPTestCase): # Probably we'll want preallocate filter to keep align to cluster when - # shrink preallocation, so, ignore small differece + # shrink preallocation, so, ignore small difference
The sentence as a whole still comes across awkwardly; maybe shorten and reword to:
The preallocate filter may keep cluster alignment when shrinking, so ignore small differences
tests/qtest/fuzz/generic_fuzz.c static void generic_pre_fuzz(QTestState *s) · line 851
Quoted 9 lines
tests/qtest/fuzz/generic_fuzz.c +3
-2+++ b/tests/qtest/fuzz/generic_fuzz.c@@ -847,7 +847,7 @@ static void generic_pre_fuzz(QTestState *s)* * This function attempts to produce an input that: -* Ouptut: maps a device's BARs, set up three DMA patterns, triggers +* Output: maps a device's BARs, set up three DMA patterns, triggers * functionality A device, replaces the DMA patterns with a single -* patten, and triggers device functionality B. +* pattern, and triggers device functionality B.
As long as you're touching neighboring lines,
s/functionality A device/device functionality A/
tests/unit/test-throttle.c static void test_is_valid(void) · line 382
Quoted 13 lines
tests/unit/test-throttle.c +3
-2+++ b/tests/unit/test-throttle.c@@ -136,5 +136,5 @@ static void test_compute_wait(void)g_assert (double_cmp (bkt.level, (i +1 ) * (bkt.max - bkt.avg) /10 ));/* We can do bursts for the 2 seconds we have configured in -* burst_length. We have 100 extra miliseconds of burst +* burst_length. We have 100 extra milliseconds of burst * because bkt.level has been leaking during this time. * After that, we have to wait. */ @@ -380,5 +380,5 @@ static void test_is_valid(void)/* zero are valids */ test_is_valid_for_value (0 , true); -/* positives numers are valids */ +/* positives numbers are valids */
Multiple grammar errors in this function. Should be:
/* negative numbers are invalid */
/* zero is valid */
/* positive numbers are valid */
All other changes in this patch look good. With additional tweaks,
Signature · 3 lines
Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org
Re: [PATCH 22/24] tests/: spelling fixes
Quoted 4 lines · Eric Blake
Quoted 2 lines · Michael Tokarev
Signed-off-by Michael Tokarev <[email protected]>---
Quoted 8 lines
tests/qemu-iotests/298 class TestTruncate(iotests.QMPTestCase): · line 144
Quoted 6 lines
+++ b/tests/qemu-iotests/298
tests/qemu-iotests/298 +1
-1@@ -142,5 +142,5 @@ class TestTruncate(iotests.QMPTestCase): # Probably we'll want preallocate filter to keep align to cluster when - # shrink preallocation, so, ignore small differece + # shrink preallocation, so, ignore small differenceThe sentence as a whole still comes across awkwardly; maybe shorten and reword to:
Yeah. I especially didn't tweak wording, - there are a LOT of places which needs additional tweaking, and the patch set is already way too large... It was tempting to tweak some of these but I decided to draw the line somewhere.
Quoted 2 lines
The preallocate filter may keep cluster alignment when shrinking, so ignore small differences
Hwell :)
Quoted 16 lines
tests/unit/test-throttle.c static void test_is_valid(void) · line 382
Quoted 13 lines
tests/unit/test-throttle.c +3
-2+++ b/tests/unit/test-throttle.c@@ -136,5 +136,5 @@ static void test_compute_wait(void)g_assert (double_cmp (bkt.level, (i +1 ) * (bkt.max - bkt.avg) /10 ));/* We can do bursts for the 2 seconds we have configured in -* burst_length. We have 100 extra miliseconds of burst +* burst_length. We have 100 extra milliseconds of burst * because bkt.level has been leaking during this time. * After that, we have to wait. */ @@ -380,5 +380,5 @@ static void test_is_valid(void)/* zero are valids */ test_is_valid_for_value (0 , true); -/* positives numers are valids */ +/* positives numbers are valids */ Multiple grammar errors in this function. Should be:
Quoted 3 lines
/* negative numbers are invalid */
/* zero is valid */
/* positive numbers are valid */
Actually I missed this "valids" somehow, even after additional re-reading of the changes.
Still, these are *grammar* errors, not spelling errors, so the subject line does not fit anymore :)
Quoted 3 lines
All other changes in this patch look good. With additional tweaks,
Reviewed-by Eric Blake <[email protected]>
Adding extra comment about the grammar changes to the commit message :)
Thank you!
/mjt
Quoted 1 line · Michael Tokarev
https://gitlab.com/mjt0k/qemu.git tags/trivial-patches-pull
This is what happens when one does development in ENOCOFFEE mode.. :)
Obviously these 3 patches together with the cover letter should not have been sent to the mailing list, it's an old stuff already applied.
Please excuse me for the noize.
/mjt
PATCH 23/24 qga/: spelling fixes
In reply to Michael Tokarev--- qga/channel-posix.c | 2 +- qga/commands-posix-ssh.c | 2 +- qga/commands-posix.c | 2 +- qga/commands-win32.c | 4 ++-- qga/main.c | 2 +- qga/vss-win32/install.cpp | 4 ++-- 6 files changed, 8 insertions(+), 8 deletions(-)
qga/channel-posix.c +1 -1
@@ -153,5 +153,5 @@ static gboolean ga_channel_open(GAChannel *c, const gchar *path,/* * In the default state channel sends echo of every command to a -* client. The client programm doesn't expect this and raises an +* client. The client program doesn't expect this and raises an * error. Suppress echo by resetting ECHO terminal flag. */
qga/commands-posix-ssh.c +1 -1
@@ -383,5 +383,5 @@ test_add_keys(void)g_assert (err ==NULL ); -/* key2 came first, and should'nt be duplicated */ +/* key2 came first, and shouldn't be duplicated */ test_authorized_keys_equal ("algo key2 comments\n" "algo key1 comments" );
qga/commands-posix.c +1 -1
@@ -3250,5 +3250,5 @@ GuestUserList *qmp_guest_get_users(Error **errp)#endif -/* Replace escaped special characters with theire real values. The replacement +/* Replace escaped special characters with their real values. The replacement * is done in place -- returned value is in the original string. */
qga/commands-win32.c +2 -2
@@ -488,5 +488,5 @@ static GuestDiskBusType win2qemu[] = { [BusTypeFileBackedVirtual] = GUEST_DISK_BUS_TYPE_FILE_BACKED_VIRTUAL,/* -* BusTypeSpaces currently is not suported +* BusTypeSpaces currently is not supported */ [BusTypeSpaces] = GUEST_DISK_BUS_TYPE_UNKNOWN,
@@ -2260,5 +2260,5 @@ static char *ga_get_win_product_name(Error **errp) }if (err !=ERROR_SUCCESS ) { -error_setg_win32 (errp, err,"failed to retrive ProductName" ); +error_setg_win32 (errp, err,"failed to retrieve ProductName" ); goto fail; }
qga/main.c +1 -1
@@ -1334,5 +1334,5 @@ static bool check_is_frozen(GAState *s)* marked as frozen. this could be a stale value (a non-qemu-ga process * or reboot may have since unfrozen them), but better to require an -* uneeded unfreeze than to risk hanging on start-up +* unneeded unfreeze than to risk hanging on start-up */ struct stat st;
qga/vss-win32/install.cpp +2 -2
@@ -344,5 +344,5 @@ STDAPI COMRegister(void) _bstr_t(""))); - /* Setup roles of the applicaion */ + /* Setup roles of the application */ chk(getNameByStringSID(administratorsGroupSID, buffer, &bufferLen));
@@ -440,5 +440,5 @@ STDAPI DllRegisterServer(void) } - /* Add this module to registery */ + /* Add this module to registry */ sprintf(key, "CLSID\\%s", g_szClsid);
Signature · 1 line
2.39.2
Re: [PATCH 23/24] qga/: spelling fixes
Quoted 9 lines · Michael Tokarev
Signed-off-by Michael Tokarev <[email protected]>--- qga/channel-posix.c | 2 +- qga/commands-posix-ssh.c | 2 +- qga/commands-posix.c | 2 +- qga/commands-win32.c | 4 ++-- qga/main.c | 2 +- qga/vss-win32/install.cpp | 4 ++-- 6 files changed, 8 insertions(+), 8 deletions(-)
Signature · 3 lines
Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org
PATCH 24/24 misc/other: spelling fixes
In reply to Michael Tokarev--- accel/tcg/tb-maint.c | 2 +- backends/tpm/tpm_ioctl.h | 2 +- chardev/char-socket.c | 6 +++--- chardev/char.c | 2 +- contrib/plugins/cache.c | 2 +- contrib/plugins/lockstep.c | 2 +- crypto/afalg.c | 2 +- crypto/block-luks.c | 6 +++--- crypto/der.c | 2 +- crypto/der.h | 6 +++--- linux-user/flatload.c | 2 +- linux-user/syscall.c | 4 ++-- nbd/client-connection.c | 2 +- net/checksum.c | 4 ++-- net/filter.c | 4 ++-- net/vhost-vdpa.c | 8 ++++---- semihosting/config.c | 2 +- semihosting/syscalls.c | 4 ++-- softmmu/icount.c | 2 +- softmmu/ioport.c | 2 +- 20 files changed, 33 insertions(+), 33 deletions(-)
accel/tcg/tb-maint.c +1 -1
@@ -1,4 +1,4 @@/* -* Translation Block Maintaince +* Translation Block Maintenance * * Copyright (c) 2003 Fabrice Bellard
backends/tpm/tpm_ioctl.h +1 -1
@@ -239,5 +239,5 @@ struct ptm_lockstorage {struct {ptm_res tpm_result; - } resp;/* reponse */ + } resp;/* response */ } u; };
chardev/char-socket.c +3 -3
@@ -711,5 +711,5 @@ static void tcp_chr_telnet_init(Chardev *chr)if (!s->is_tn3270) { init->buflen =12 ; -/* Prep the telnet negotion to put telnet in binary, +/* Prep the telnet negotiation to put telnet in binary, * no echo, single char mode */ IACSET (init->buf,0xff ,0xfb ,0x01 );/* IAC WILL ECHO */
@@ -719,5 +719,5 @@ static void tcp_chr_telnet_init(Chardev *chr) }else { init->buflen =21 ; -/* Prep the TN3270 negotion based on RFC1576 */ +/* Prep the TN3270 negotiation based on RFC1576 */ IACSET (init->buf,0xff ,0xfd ,0x19 );/* IAC DO EOR */ IACSET (init->buf,0xff ,0xfb ,0x19 );/* IAC WILL EOR */
@@ -1299,5 +1299,5 @@ static bool qmp_chardev_validate_socket(ChardevSocket *sock, } -/* Validate any options which have a dependancy on client vs server */ +/* Validate any options which have a dependency on client vs server */ if (!sock->has_server || sock->server) {if (sock->has_reconnect) {
chardev/char.c +1 -1
@@ -1116,5 +1116,5 @@ ChardevReturn *qmp_chardev_change(const char *id, ChardevBackend *backend, } -/* change successfull, clean up */ +/* change successful, clean up */ chr_new->handover_yank_instance = false;
contrib/plugins/cache.c +1 -1
@@ -351,5 +351,5 @@ static int in_cache(Cache *cache, uint64_t addr)* @addr: The address of the requested memory location * -* Returns true if the requsted data is hit in the cache and false when missed. +* Returns true if the requested data is hit in the cache and false when missed. * The cache is updated on miss for the next access. */
contrib/plugins/lockstep.c +1 -1
@@ -109,5 +109,5 @@ static void report_divergance(ExecState *us, ExecState *them)/* * If we have diverged before did we get back on track or are we -* totally loosing it? +* totally losing it? */ if (divergence_log) {
crypto/afalg.c +1 -1
@@ -74,5 +74,5 @@ qcrypto_afalg_comm_alloc(const char *type, const char *name, afalg =g_new0 (QCryptoAFAlg,1 ); -/* initilize crypto API socket */ +/* initialize crypto API socket */ afalg->opfd =-1 ; afalg->tfmfd =qcrypto_afalg_socket_bind (type, name, errp);
crypto/block-luks.c +3 -3
@@ -245,5 +245,5 @@ qcrypto_block_luks_has_format(const uint8_t *buf,* When calculating ESSIV IVs, the cipher length used by ESSIV * may be different from the cipher length used for the block -* encryption, becauses dm-crypt uses the hash digest length +* encryption, because dm-crypt uses the hash digest length * as the key size. ie, if you have AES 128 as the block cipher * and SHA 256 as ESSIV hash, then ESSIV will use AES 256 as
@@ -394,5 +394,5 @@ qcrypto_block_luks_from_disk_endian(QCryptoBlockLUKSHeader *hdr)/* -* Stores the main LUKS header, taking care of endianess +* Stores the main LUKS header, taking care of endianness */ static int
@@ -424,5 +424,5 @@ qcrypto_block_luks_store_header(QCryptoBlock *block,/* -* Loads the main LUKS header,and byteswaps it to native endianess +* Loads the main LUKS header,and byteswaps it to native endianness * And run basic sanity checks on it */
crypto/der.c +1 -1
@@ -77,5 +77,5 @@ enum QCryptoDERTagEnc {* qcrypto_der_encode_length: * @src_len: the length of source data -* @dst: distination to save the encoded 'length', if dst is NULL, only compute +* @dst: destination to save the encoded 'length', if dst is NULL, only compute * the expected buffer size in bytes. * @dst_len: output parameter, indicates how many bytes wrote.
crypto/der.h +3 -3
@@ -250,5 +250,5 @@ void qcrypto_der_encode_octet_str(QCryptoEncodeContext *ctx,* qcrypto_der_encode_octet_str_begin and qcrypto_der_encode_octet_str_end * are encoded as an octet string. This is useful when we need to encode a -* encoded SEQUNCE as OCTET STRING. +* encoded SEQUENCE as OCTET STRING. */ void qcrypto_der_encode_octet_str_begin (QCryptoEncodeContext *ctx);
@@ -261,5 +261,5 @@ void qcrypto_der_encode_octet_str_begin(QCryptoEncodeContext *ctx);* qcrypto_der_encode_octet_str_begin and qcrypto_der_encode_octet_str_end * are encoded as an octet string. This is useful when we need to encode a -* encoded SEQUNCE as OCTET STRING. +* encoded SEQUENCE as OCTET STRING. */ void qcrypto_der_encode_octet_str_end (QCryptoEncodeContext *ctx);
@@ -276,5 +276,5 @@ size_t qcrypto_der_encode_ctx_buffer_len(QCryptoEncodeContext *ctx);* qcrypto_der_encode_ctx_flush_and_free: * @ctx: the encode context. -* @dst: the distination to save the encoded data, the length of dst should +* @dst: the destination to save the encoded data, the length of dst should * not less than qcrypto_der_encode_cxt_buffer_len *
linux-user/flatload.c +1 -1
@@ -781,5 +781,5 @@ int load_flt_binary(struct linux_binprm *bprm, struct image_info *info)for all current targets, and excess alignment is harmless. */ stack_len = bprm->envc + bprm->argc +2 ; - stack_len +=flat_argvp_envp_on_stack () ?2 :0 ;/* arvg, argp */ + stack_len +=flat_argvp_envp_on_stack () ?2 :0 ;/* argv, argp */ stack_len +=1 ;/* argc */ stack_len *=sizeof (abi_ulong);
linux-user/syscall.c +2 -2
@@ -1810,5 +1810,5 @@ static inline abi_long target_to_host_cmsg(struct msghdr *msgh,memcpy (dst, target_data, len); -/* fix endianess of first 32-bit word */ +/* fix endianness of first 32-bit word */ if (len >=sizeof (uint32_t )) { *dst =tswap32 (*dst);
@@ -2921,5 +2921,5 @@ get_timeout:return ret; } -/* swap host endianess to target endianess. */ +/* swap host endianness to target endianness. */ for (i =0 ; i < (len /sizeof (uint32_t )); i++) { results[i] =tswap32 (results[i]);
nbd/client-connection.c +1 -1
@@ -198,5 +198,5 @@ static void *connect_thread_func(void *opaque)* pointers to our internally allocated strings, which are IN parameters * of nbd_receive_negotiate() and therefore nbd_connect(). Caller -* shoudn't be interested in these fields. +* shouldn't be interested in these fields. */ conn->updated_info.x_dirty_bitmap =NULL ;
net/checksum.c +2 -2
@@ -75,5 +75,5 @@ void net_checksum_calculate(uint8_t *data, int length, int csum_flag) } -/* Handle the optionnal VLAN headers */ +/* Handle the optional VLAN headers */ switch (lduw_be_p (&PKT_GET_ETH_HDR (data)->h_proto)) {case ETH_P_VLAN :
@@ -97,5 +97,5 @@ void net_checksum_calculate(uint8_t *data, int length, int csum_flag) length -= mac_hdr_len; -/* Now check we have an IP header (with an optionnal VLAN header) */ +/* Now check we have an IP header (with an optional VLAN header) */ if (length <sizeof (struct ip_header )) {return ;
net/filter.c +2 -2
@@ -93,5 +93,5 @@ ssize_t qemu_netfilter_pass_to_next(NetClientState *sender,/* * if qemu_netfilter_pass_to_next been called, means that -* the packet has been hold by filter and has already retured size +* the packet has been hold by filter and has already returned size * to the sender, so sent_cb shouldn't be called later, just * pass NULL to next.
@@ -107,5 +107,5 @@ ssize_t qemu_netfilter_pass_to_next(NetClientState *sender,/* * We have gone through all filters, pass it to receiver. -* Do the valid check again incase sender or receiver been +* Do the valid check again in case sender or receiver been * deleted while we go through filters. */
net/vhost-vdpa.c +4 -4
@@ -822,5 +822,5 @@ static int vhost_vdpa_net_load_rx(VhostVDPAState *s,* on by default. * -* Addtionally, according to VirtIO standard, "Since there are +* Additionally, according to VirtIO standard, "Since there are * no guarantees, it can use a hash filter or silently switch to * allmulti or promiscuous mode if it is given too many addresses.".
@@ -1131,5 +1131,5 @@ static int vhost_vdpa_net_excessive_mac_filter_cvq_add(VhostVDPAState *s,* * According to virtio_net_handle_mac(), QEMU doesn't verify the MAC -* addresses provieded in CVQ command. Therefore, only the entries +* addresses provided in CVQ command. Therefore, only the entries * field need to be prepared in the CVQ command. */
@@ -1142,5 +1142,5 @@ static int vhost_vdpa_net_excessive_mac_filter_cvq_add(VhostVDPAState *s,* * According to virtio_net_handle_mac(), QEMU doesn't verify the MAC -* addresses provieded in CVQ command. Therefore, only the entries +* addresses provided in CVQ command. Therefore, only the entries * field need to be prepared in the CVQ command. */
@@ -1203,5 +1203,5 @@ static int vhost_vdpa_net_handle_ctrl_avail(VhostShadowVirtqueue *svq,* * Therefore, QEMU must handle this situation instead of sending -* the CVQ command direclty. +* the CVQ command directly. */ dev_written = vhost_vdpa_net_excessive_mac_filter_cvq_add(s, elem,
semihosting/config.c +1 -1
@@ -9,5 +9,5 @@* in target/HW/HW-semi.c * -* Semihosting is sightly strange in that it is also supported by some +* Semihosting is slightly strange in that it is also supported by some * linux-user targets. However in that use case no configuration of * the outputs and command lines is supported.
semihosting/syscalls.c +2 -2
@@ -721,5 +721,5 @@ void semihost_sys_read_gf(CPUState *cs, gdb_syscall_complete_cb complete, {/* -* Bound length for 64-bit guests on 32-bit hosts, not overlowing ssize_t. +* Bound length for 64-bit guests on 32-bit hosts, not overflowing ssize_t. * Note the Linux kernel does this with MAX_RW_COUNT, so it's not a bad * idea to do this unconditionally.
@@ -762,5 +762,5 @@ void semihost_sys_write_gf(CPUState *cs, gdb_syscall_complete_cb complete, {/* -* Bound length for 64-bit guests on 32-bit hosts, not overlowing ssize_t. +* Bound length for 64-bit guests on 32-bit hosts, not overflowing ssize_t. * Note the Linux kernel does this with MAX_RW_COUNT, so it's not a bad * idea to do this unconditionally.
softmmu/icount.c +1 -1
@@ -326,5 +326,5 @@ void icount_start_warp_timer(void)* It is probably a race condition: notification sent * to vCPU was processed in advance and vCPU went to sleep. -* Therefore we have to wake it up for doing someting. +* Therefore we have to wake it up for doing something. */ if (replay_has_event ()) {
softmmu/ioport.c +1 -1
@@ -23,5 +23,5 @@*/ /* -* splitted out ioport related stuffs from vl.c. +* split out ioport related stuffs from vl.c. */
Signature · 1 line
2.39.2