Skip to contentSkip to conversation

Add ADI MAX77503 regulator driver and bindings

PATCH Superseded Gokhan Celik 3 participants 7 messages Oct 3, 2023 – Oct 23, 2023

Subsystems (2)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v3 cover Add ADI MAX77503 regulator driver and bindings

Add MAX77503 buck converter driver and devicetree bindings. Apply patches in sequence.

Gokhan Celik (2):
regulator: max77503: Add ADI MAX77503 support
regulator: dt-bindings: Add ADI MAX77503 support

 .../regulator/adi,max77503-regulator.yaml     |  51 +++++++
 drivers/regulator/Kconfig                     |  10 ++
 drivers/regulator/Makefile                    |   1 +
 drivers/regulator/max77503-regulator.c        | 137 ++++++++++++++++++
 4 files changed, 199 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/regulator/adi,max77503-regulator.yaml
 create mode 100644 drivers/regulator/max77503-regulator.c
Signature · 1 line
2.34.1
#1 lore raw

PATCH v3 1/2 regulator: max77503: Add ADI MAX77503 support

Add ADI MAX77503 buck converter driver support.

---
 drivers/regulator/Kconfig              |  10 ++
 drivers/regulator/Makefile             |   1 +
 drivers/regulator/max77503-regulator.c | 137 +++++++++++++++++++++++++
 3 files changed, 148 insertions(+)
 create mode 100644 drivers/regulator/max77503-regulator.c
drivers/regulator/Kconfig +10 -0
index 823f8e6e4801..dbd2053774e9 100644
@@ -556,6 +556,16 @@ config REGULATOR_MAX597X
 	  The MAX5970/5978 is a smart switch with no output regulation, but
 	  fault protection and voltage and current monitoring capabilities.
 
+config REGULATOR_MAX77503
+	tristate "Analog Devices MAX77503 Regulator"
+	depends on I2C
+	select REGMAP_I2C
+	help
+	  This driver controls a Analog Devices MAX77503 14V input, 1.5A
+	  high-efficiency buck converter via I2C bus.
+	  Say M here if you want to include support for the regulator as a
+	  module.
+
 config REGULATOR_MAX77541
 	tristate "Analog Devices MAX77541/77540 Regulator"
 	depends on MFD_MAX77541
drivers/regulator/Makefile +1 -0
index 15e0d614ff66..b5b724699b51 100644
@@ -68,6 +68,7 @@ obj-$(CONFIG_REGULATOR_LTC3676) += ltc3676.o
 obj-$(CONFIG_REGULATOR_MAX14577) += max14577-regulator.o
 obj-$(CONFIG_REGULATOR_MAX1586) += max1586.o
 obj-$(CONFIG_REGULATOR_MAX597X) += max597x-regulator.o
+obj-$(CONFIG_REGULATOR_MAX77503) += max77503-regulator.o
 obj-$(CONFIG_REGULATOR_MAX77541) += max77541-regulator.o
 obj-$(CONFIG_REGULATOR_MAX77620) += max77620-regulator.o
 obj-$(CONFIG_REGULATOR_MAX77650) += max77650-regulator.o
drivers/regulator/max77503-regulator.c new file +137 -0

137 lines not on this page · raw message

Signature · 1 line
2.34.1
maintainer
#2 lore raw

Re: [PATCH v3 1/2] regulator: max77503: Add ADI MAX77503 support

Quoted 1 line · Gokhan Celik

Add ADI MAX77503 buck converter driver support.

This doesn't apply against current code, please check and resend.

maintainer
#3 lore raw

Re: [PATCH v3 1/2] regulator: max77503: Add ADI MAX77503 support

In reply to Gokhan Celik
Quoted 3 lines · Gokhan Celik

Add ADI MAX77503 buck converter driver support.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/2] regulator: max77503: Add ADI MAX77503 support

      commit: a0c543bdf4ba4f10d21fb2d44a9abc5715184966
[2/2] regulator: dt-bindings: Add ADI MAX77503 support
      commit: ff5f76b820a95957df0420bba4c67b02978e6c52

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

#4 lore raw

PATCH v3 2/2 regulator: dt-bindings: Add ADI MAX77503 support

In reply to Gokhan Celik

Add ADI MAX77503 buck converter devicetree document.

---
Changelog:
V2 -> V3: Addressed the review comments

 .../regulator/adi,max77503-regulator.yaml     | 51 +++++++++++++++++++
 1 file changed, 51 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/regulator/adi,max77503-regulator.yaml
Documentation/devicetree/bindings/regulator/adi,max77503-regulator.yaml new file +51 -0
new file mode 100644
index 000000000000..554df8e2b0b6
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+# Copyright (c) 2023 Analog Devices, Inc.
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/adi,max77503-regulator.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices MAX77503 Buck Converter
+
+maintainers:
+  - Gokhan Celik <[email protected]>
+
+description: |
+  The Analog Devices MAX77503 is a single channel 14V input, 1.5A 
+  high-efficiency buck converter. This converter has 94% efficiency
+  for 2-Cell/3-Cell battery applications.
+
+allOf:
+  - $ref: regulator.yaml#
+
+properties:
+  compatible:
+    enum:
+      - adi,max77503
+
+  reg:
+    description: I2C address of the device
+    items:
+      - enum: [0x1e, 0x24, 0x37]
+
+required:
+  - compatible
+  - reg
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        regulator@1e {
+            compatible = "adi,max77503";
+            reg = <0x1e>;
+
+            regulator-min-microvolt = <800000>;
+            regulator-max-microvolt = <5000000>;
+        };
+    };
+
Signature · 1 line
2.34.1
#5 lore raw

Re: [PATCH v3 2/2] regulator: dt-bindings: Add ADI MAX77503 support

Quoted 4 lines · Gokhan Celik

Add ADI MAX77503 buck converter devicetree document.

Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.

You missed at least devicetree list (maybe more), so this won't be tested by automated tooling.

Please kindly resend and include all necessary To/Cc entries.

...

Quoted 6 lines
Documentation/devicetree/bindings/regulator/adi,max77503-regulator.yaml new file +6 -0
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;

Documentation/devicetree/bindings/regulator/adi,max77503-regulator.yaml line 51

Quoted 10 lines
Documentation/devicetree/bindings/regulator/adi,max77503-regulator.yaml new file +10 -0
+
+        regulator@1e {
+            compatible = "adi,max77503";
+            reg = <0x1e>;
+
+            regulator-min-microvolt = <800000>;
+            regulator-max-microvolt = <5000000>;
+        };
+    };
+

Looks like extra blank line here.

Best regards,
Krzysztof

#6 lore raw

Re: [PATCH v3 2/2] regulator: dt-bindings: Add ADI MAX77503 support

Quoted 11 lines · Krzysztof Kozlowski
Quoted 4 lines · Gokhan Celik

Add ADI MAX77503 buck converter devicetree document.

Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.

Quoted 4 lines

You missed at least devicetree list (maybe more), so this won't be tested by automated tooling.

Please kindly resend and include all necessary To/Cc entries.

Update: this missed all mailing lists, in fact. :/

Best regards,
Krzysztof