staging: sm750fb: Renaming camelcase to snakecase
cover staging: sm750fb: Renaming camelcase to snakecase
Renames various function names and variable names that were previously in camelcase to snakecase to ensure consistent naming styles.This issues were highlighted by checkpatch.
Dorcas AnonoLitunya (5):
Staging: sm750fb: Rename displayControlAdjust_SM750E
Staging: sm750fb: Rename pModeParam
Staging: sm750fb: Rename displayControl
Staging: sm750fb: Rename programModeRegisters
Staging: sm750fb: Rename ddk750_setModeTiming
drivers/staging/sm750fb/ddk750_mode.c | 90 +++++++++++++-------------- drivers/staging/sm750fb/ddk750_mode.h | 2 +- drivers/staging/sm750fb/sm750_hw.c | 2 +- 3 files changed, 47 insertions(+), 47 deletions(-)
Signature · 1 line
2.42.0.345.gaab89be2eb
PATCH 1/5 Staging: sm750fb: Rename displayControlAdjust_SM750E
Rename function displayControlAdjust_SM750E to display_control_adjust_SM750E.This follows snakecase naming convention and ensures consistent naming style throughout the file.Issue by checkpatch.
Mutes the following error:
CHECK:Avoid CamelCase: <displayControlAdjust_SM750E>
--- drivers/staging/sm750fb/ddk750_mode.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/sm750fb/ddk750_mode.c +3 -3
@@ -14,8 +14,8 @@* in bit 29:27 of Display Control register. */ static unsigned long -displayControlAdjust_SM750LE (struct mode_parameter *pModeParam, -unsigned long dispControl) +display_control_adjust_SM750LE (struct mode_parameter *pModeParam, +unsigned long dispControl) {unsigned long x, y;
@@ -125,7 +125,7 @@ static int programModeRegisters(struct mode_parameter *pModeParam, tmp |=DISPLAY_CTRL_HSYNC_PHASE ;if (sm750_get_chip_type () ==SM750LE ) { -displayControlAdjust_SM750LE (pModeParam, tmp); +display_control_adjust_SM750LE (pModeParam, tmp); }else { reg = peek32(CRT_DISPLAY_CTRL) & ~(DISPLAY_CTRL_VSYNC_PHASE |
Signature · 1 line
2.42.0.345.gaab89be2eb
Re: [PATCH 1/5] Staging: sm750fb: Rename displayControlAdjust_SM750E
Quoted 4 lines · Dorcas AnonoLitunya
Rename function
displayControlAdjust_SM750Eto display_control_adjust_SM750E.This follows snakecase naming convention and ensures consistent naming style throughout the file.Issue by checkpatch.
The period at the end of a sentence should have a space after it.
ensures -> ensures a
Issue -> Issue found
julia
Quoted 38 lines
Mutes the following error:
CHECK:Avoid CamelCase: <displayControlAdjust_SM750E>Signed-off-by Dorcas AnonoLitunya <[email protected]>--- drivers/staging/sm750fb/ddk750_mode.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/staging/sm750fb/ddk750_mode.c +3
-4@@ -14,8 +14,8 @@* in bit 29:27 of Display Control register. */ static unsigned long -displayControlAdjust_SM750LE (struct mode_parameter *pModeParam, -unsigned long dispControl) +display_control_adjust_SM750LE (struct mode_parameter *pModeParam, +unsigned long dispControl) {unsigned long x, y;@@ -125,7 +125,7 @@ static int programModeRegisters(struct mode_parameter *pModeParam, tmp |=DISPLAY_CTRL_HSYNC_PHASE ;if (sm750_get_chip_type () ==SM750LE ) { -displayControlAdjust_SM750LE (pModeParam, tmp); +display_control_adjust_SM750LE (pModeParam, tmp); }else { reg = peek32(CRT_DISPLAY_CTRL) & ~(DISPLAY_CTRL_VSYNC_PHASE | --2.42.0.345.gaab89be2eb
Re: [PATCH 1/5] Staging: sm750fb: Rename displayControlAdjust_SM750E
Quoted 9 lines · Julia Lawall
Quoted 4 lines · Dorcas AnonoLitunya
Rename function
displayControlAdjust_SM750Eto display_control_adjust_SM750E.This follows snakecase naming convention and ensures consistent naming style throughout the file.Issue by checkpatch.
Quoted 6 lines
The period at the end of a sentence should have a space after it.
ensures -> ensures a
Issue -> Issue found
This is corrected. Thanks Julia!
Quoted 40 lines
julia
Quoted 38 lines
Mutes the following error:
CHECK:Avoid CamelCase: <displayControlAdjust_SM750E>Signed-off-by Dorcas AnonoLitunya <[email protected]>--- drivers/staging/sm750fb/ddk750_mode.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/staging/sm750fb/ddk750_mode.c +3
-4@@ -14,8 +14,8 @@* in bit 29:27 of Display Control register. */ static unsigned long -displayControlAdjust_SM750LE (struct mode_parameter *pModeParam, -unsigned long dispControl) +display_control_adjust_SM750LE (struct mode_parameter *pModeParam, +unsigned long dispControl) {unsigned long x, y;@@ -125,7 +125,7 @@ static int programModeRegisters(struct mode_parameter *pModeParam, tmp |=DISPLAY_CTRL_HSYNC_PHASE ;if (sm750_get_chip_type () ==SM750LE ) { -displayControlAdjust_SM750LE (pModeParam, tmp); +display_control_adjust_SM750LE (pModeParam, tmp); }else { reg = peek32(CRT_DISPLAY_CTRL) & ~(DISPLAY_CTRL_VSYNC_PHASE | --2.42.0.345.gaab89be2eb
PATCH 2/5 Staging: sm750fb: Rename pModeParam
In reply to Dorcas AnonoLitunyaRename variable pModeParam to mode_param.This follows snakecase naming convention and ensures consistent naming style throughout the file.Issue by checkpatch.
Mutes the following checkpatch error:
CHECK: Avoid CamelCase: <pModeParam>
--- drivers/staging/sm750fb/ddk750_mode.c | 52 +++++++++++++-------------- 1 file changed, 26 insertions(+), 26 deletions(-)
drivers/staging/sm750fb/ddk750_mode.c +26 -26
@@ -14,13 +14,13 @@* in bit 29:27 of Display Control register. */ static unsigned long -display_control_adjust_SM750LE (struct mode_parameter *pModeParam, +display_control_adjust_SM750LE (struct mode_parameter *mode_param,unsigned long dispControl) {unsigned long x, y; - x = pModeParam->horizontal_display_end; - y = pModeParam->vertical_display_end; + x = mode_param->horizontal_display_end; + y = mode_param->vertical_display_end;/* * SM750LE has to set up the top-left and bottom-right
@@ -75,7 +75,7 @@ display_control_adjust_SM750LE(struct mode_parameter *pModeParam, }/* only timing related registers will be programed */ -static int programModeRegisters (struct mode_parameter *pModeParam, +static int programModeRegisters (struct mode_parameter *mode_param,struct pll_value *pll) {int ret =0 ;
@@ -86,46 +86,46 @@ static int programModeRegisters(struct mode_parameter *pModeParam,/* programe secondary pixel clock */ poke32 (CRT_PLL_CTRL ,sm750_format_pll_reg (pll)); - tmp = ((pModeParam->horizontal_total -1 ) << + tmp = ((mode_param->horizontal_total -1 ) <<CRT_HORIZONTAL_TOTAL_TOTAL_SHIFT ) &CRT_HORIZONTAL_TOTAL_TOTAL_MASK ; - tmp |= (pModeParam->horizontal_display_end -1 ) & + tmp |= (mode_param->horizontal_display_end -1 ) &CRT_HORIZONTAL_TOTAL_DISPLAY_END_MASK ;poke32 (CRT_HORIZONTAL_TOTAL , tmp); - tmp = (pModeParam->horizontal_sync_width << + tmp = (mode_param->horizontal_sync_width <<CRT_HORIZONTAL_SYNC_WIDTH_SHIFT ) &CRT_HORIZONTAL_SYNC_WIDTH_MASK ; - tmp |= (pModeParam->horizontal_sync_start -1 ) & + tmp |= (mode_param->horizontal_sync_start -1 ) &CRT_HORIZONTAL_SYNC_START_MASK ;poke32 (CRT_HORIZONTAL_SYNC , tmp); - tmp = ((pModeParam->vertical_total -1 ) << + tmp = ((mode_param->vertical_total -1 ) <<CRT_VERTICAL_TOTAL_TOTAL_SHIFT ) &CRT_VERTICAL_TOTAL_TOTAL_MASK ; - tmp |= (pModeParam->vertical_display_end -1 ) & + tmp |= (mode_param->vertical_display_end -1 ) &CRT_VERTICAL_TOTAL_DISPLAY_END_MASK ;poke32 (CRT_VERTICAL_TOTAL , tmp); - tmp = ((pModeParam->vertical_sync_height << + tmp = ((mode_param->vertical_sync_height <<CRT_VERTICAL_SYNC_HEIGHT_SHIFT )) &CRT_VERTICAL_SYNC_HEIGHT_MASK ; - tmp |= (pModeParam->vertical_sync_start -1 ) & + tmp |= (mode_param->vertical_sync_start -1 ) &CRT_VERTICAL_SYNC_START_MASK ;poke32 (CRT_VERTICAL_SYNC , tmp); tmp =DISPLAY_CTRL_TIMING |DISPLAY_CTRL_PLANE ; -if (pModeParam->vertical_sync_polarity) +if (mode_param->vertical_sync_polarity) tmp |=DISPLAY_CTRL_VSYNC_PHASE ; -if (pModeParam->horizontal_sync_polarity) +if (mode_param->horizontal_sync_polarity) tmp |=DISPLAY_CTRL_HSYNC_PHASE ;if (sm750_get_chip_type () ==SM750LE ) { -display_control_adjust_SM750LE (pModeParam, tmp); +display_control_adjust_SM750LE (mode_param, tmp); }else { reg = peek32(CRT_DISPLAY_CTRL) & ~(DISPLAY_CTRL_VSYNC_PHASE |
@@ -140,40 +140,40 @@ static int programModeRegisters(struct mode_parameter *pModeParam,poke32 (PANEL_PLL_CTRL ,sm750_format_pll_reg (pll)); - reg = ((pModeParam->horizontal_total -1 ) << + reg = ((mode_param->horizontal_total -1 ) <<PANEL_HORIZONTAL_TOTAL_TOTAL_SHIFT ) &PANEL_HORIZONTAL_TOTAL_TOTAL_MASK ; - reg |= ((pModeParam->horizontal_display_end -1 ) & + reg |= ((mode_param->horizontal_display_end -1 ) &PANEL_HORIZONTAL_TOTAL_DISPLAY_END_MASK );poke32 (PANEL_HORIZONTAL_TOTAL , reg);poke32 (PANEL_HORIZONTAL_SYNC , - ((pModeParam->horizontal_sync_width << + ((mode_param->horizontal_sync_width <<PANEL_HORIZONTAL_SYNC_WIDTH_SHIFT ) &PANEL_HORIZONTAL_SYNC_WIDTH_MASK ) | - ((pModeParam->horizontal_sync_start -1 ) & + ((mode_param->horizontal_sync_start -1 ) &PANEL_HORIZONTAL_SYNC_START_MASK ));poke32 (PANEL_VERTICAL_TOTAL , - (((pModeParam->vertical_total -1 ) << + (((mode_param->vertical_total -1 ) <<PANEL_VERTICAL_TOTAL_TOTAL_SHIFT ) &PANEL_VERTICAL_TOTAL_TOTAL_MASK ) | - ((pModeParam->vertical_display_end -1 ) & + ((mode_param->vertical_display_end -1 ) &PANEL_VERTICAL_TOTAL_DISPLAY_END_MASK ));poke32 (PANEL_VERTICAL_SYNC , - ((pModeParam->vertical_sync_height << + ((mode_param->vertical_sync_height <<PANEL_VERTICAL_SYNC_HEIGHT_SHIFT ) &PANEL_VERTICAL_SYNC_HEIGHT_MASK ) | - ((pModeParam->vertical_sync_start -1 ) & + ((mode_param->vertical_sync_start -1 ) &PANEL_VERTICAL_SYNC_START_MASK )); tmp =DISPLAY_CTRL_TIMING |DISPLAY_CTRL_PLANE ; -if (pModeParam->vertical_sync_polarity) +if (mode_param->vertical_sync_polarity) tmp |=DISPLAY_CTRL_VSYNC_PHASE ; -if (pModeParam->horizontal_sync_polarity) +if (mode_param->horizontal_sync_polarity) tmp |=DISPLAY_CTRL_HSYNC_PHASE ; -if (pModeParam->clock_phase_polarity) +if (mode_param->clock_phase_polarity) tmp |=DISPLAY_CTRL_CLOCK_PHASE ; reserved = PANEL_DISPLAY_CTRL_RESERVED_MASK |
Signature · 1 line
2.42.0.345.gaab89be2eb
PATCH 3/5 Staging: sm750fb: Rename displayControl
In reply to Dorcas AnonoLitunyaRename variable displayControl to display_control. This follows snakecase naming convention and ensures consistent naming style throughout the file.Issue by checkpatch.
Mutes the following checkpatch error:
CHECK: Avoid CamelCase: <dispControl>
--- drivers/staging/sm750fb/ddk750_mode.c | 32 +++++++++++++-------------- 1 file changed, 16 insertions(+), 16 deletions(-)
drivers/staging/sm750fb/ddk750_mode.c +16 -16
@@ -15,7 +15,7 @@*/ static unsigned long display_control_adjust_SM750LE (struct mode_parameter *mode_param, -unsigned long dispControl) +unsigned long disp_control) {unsigned long x, y;
@@ -36,42 +36,42 @@ display_control_adjust_SM750LE(struct mode_parameter *mode_param, ((x - 1) & CRT_AUTO_CENTERING_BR_RIGHT_MASK));/* -* Assume common fields in dispControl have been properly set before +* Assume common fields in disp_control have been properly set before * calling this function. -* This function only sets the extra fields in dispControl. +* This function only sets the extra fields in disp_control. */ /* Clear bit 29:27 of display control register */ - dispControl &= ~CRT_DISPLAY_CTRL_CLK_MASK ; + disp_control &= ~CRT_DISPLAY_CTRL_CLK_MASK ;/* Set bit 29:27 of display control register for the right clock */ /* Note that SM750LE only need to supported 7 resolutions. */ if (x ==800 && y ==600 ) - dispControl |=CRT_DISPLAY_CTRL_CLK_PLL41 ; + disp_control |=CRT_DISPLAY_CTRL_CLK_PLL41 ;else if (x ==1024 && y ==768 ) - dispControl |=CRT_DISPLAY_CTRL_CLK_PLL65 ; + disp_control |=CRT_DISPLAY_CTRL_CLK_PLL65 ;else if (x ==1152 && y ==864 ) - dispControl |=CRT_DISPLAY_CTRL_CLK_PLL80 ; + disp_control |=CRT_DISPLAY_CTRL_CLK_PLL80 ;else if (x ==1280 && y ==768 ) - dispControl |=CRT_DISPLAY_CTRL_CLK_PLL80 ; + disp_control |=CRT_DISPLAY_CTRL_CLK_PLL80 ;else if (x ==1280 && y ==720 ) - dispControl |=CRT_DISPLAY_CTRL_CLK_PLL74 ; + disp_control |=CRT_DISPLAY_CTRL_CLK_PLL74 ;else if (x ==1280 && y ==960 ) - dispControl |=CRT_DISPLAY_CTRL_CLK_PLL108 ; + disp_control |=CRT_DISPLAY_CTRL_CLK_PLL108 ;else if (x ==1280 && y ==1024 ) - dispControl |=CRT_DISPLAY_CTRL_CLK_PLL108 ; + disp_control |=CRT_DISPLAY_CTRL_CLK_PLL108 ;else /* default to VGA clock */ - dispControl |=CRT_DISPLAY_CTRL_CLK_PLL25 ; + disp_control |=CRT_DISPLAY_CTRL_CLK_PLL25 ;/* Set bit 25:24 of display controller */ - dispControl |= (CRT_DISPLAY_CTRL_CRTSELECT |CRT_DISPLAY_CTRL_RGBBIT ); + disp_control |= (CRT_DISPLAY_CTRL_CRTSELECT |CRT_DISPLAY_CTRL_RGBBIT );/* Set bit 14 of display controller */ - dispControl |=DISPLAY_CTRL_CLOCK_PHASE ; + disp_control |=DISPLAY_CTRL_CLOCK_PHASE ; -poke32 (CRT_DISPLAY_CTRL , dispControl); +poke32 (CRT_DISPLAY_CTRL , disp_control); -return dispControl; +return disp_control; }/* only timing related registers will be programed */
Signature · 1 line
2.42.0.345.gaab89be2eb
Re: [PATCH 3/5] Staging: sm750fb: Rename displayControl
Quoted 3 lines · Dorcas AnonoLitunya
Rename variable displayControl to
display_control. This follows snakecase naming convention and ensures consistent naming style throughout the file.Issue by checkpatch.
Actually, the variable seems to be dispControl?
julia
Quoted 85 lines
Mutes the following checkpatch error:
CHECK: Avoid CamelCase: <dispControl>Signed-off-by Dorcas AnonoLitunya <[email protected]>--- drivers/staging/sm750fb/ddk750_mode.c | 32 +++++++++++++-------------- 1 file changed, 16 insertions(+), 16 deletions(-)drivers/staging/sm750fb/ddk750_mode.c +16
-17@@ -15,7 +15,7 @@*/ static unsigned long display_control_adjust_SM750LE (struct mode_parameter *mode_param, -unsigned long dispControl) +unsigned long disp_control) {unsigned long x, y;@@ -36,42 +36,42 @@ display_control_adjust_SM750LE(struct mode_parameter *mode_param, ((x - 1) & CRT_AUTO_CENTERING_BR_RIGHT_MASK));/* -* Assume common fields in dispControl have been properly set before +* Assume common fields in disp_control have been properly set before * calling this function. -* This function only sets the extra fields in dispControl. +* This function only sets the extra fields in disp_control. */ /* Clear bit 29:27 of display control register */ - dispControl &= ~CRT_DISPLAY_CTRL_CLK_MASK ; + disp_control &= ~CRT_DISPLAY_CTRL_CLK_MASK ;/* Set bit 29:27 of display control register for the right clock */ /* Note that SM750LE only need to supported 7 resolutions. */ if (x ==800 && y ==600 ) - dispControl |=CRT_DISPLAY_CTRL_CLK_PLL41 ; + disp_control |=CRT_DISPLAY_CTRL_CLK_PLL41 ;else if (x ==1024 && y ==768 ) - dispControl |=CRT_DISPLAY_CTRL_CLK_PLL65 ; + disp_control |=CRT_DISPLAY_CTRL_CLK_PLL65 ;else if (x ==1152 && y ==864 ) - dispControl |=CRT_DISPLAY_CTRL_CLK_PLL80 ; + disp_control |=CRT_DISPLAY_CTRL_CLK_PLL80 ;else if (x ==1280 && y ==768 ) - dispControl |=CRT_DISPLAY_CTRL_CLK_PLL80 ; + disp_control |=CRT_DISPLAY_CTRL_CLK_PLL80 ;else if (x ==1280 && y ==720 ) - dispControl |=CRT_DISPLAY_CTRL_CLK_PLL74 ; + disp_control |=CRT_DISPLAY_CTRL_CLK_PLL74 ;else if (x ==1280 && y ==960 ) - dispControl |=CRT_DISPLAY_CTRL_CLK_PLL108 ; + disp_control |=CRT_DISPLAY_CTRL_CLK_PLL108 ;else if (x ==1280 && y ==1024 ) - dispControl |=CRT_DISPLAY_CTRL_CLK_PLL108 ; + disp_control |=CRT_DISPLAY_CTRL_CLK_PLL108 ;else /* default to VGA clock */ - dispControl |=CRT_DISPLAY_CTRL_CLK_PLL25 ; + disp_control |=CRT_DISPLAY_CTRL_CLK_PLL25 ;/* Set bit 25:24 of display controller */ - dispControl |= (CRT_DISPLAY_CTRL_CRTSELECT |CRT_DISPLAY_CTRL_RGBBIT ); + disp_control |= (CRT_DISPLAY_CTRL_CRTSELECT |CRT_DISPLAY_CTRL_RGBBIT );/* Set bit 14 of display controller */ - dispControl |=DISPLAY_CTRL_CLOCK_PHASE ; + disp_control |=DISPLAY_CTRL_CLOCK_PHASE ; -poke32 (CRT_DISPLAY_CTRL , dispControl); +poke32 (CRT_DISPLAY_CTRL , disp_control); -return dispControl; +return disp_control; }/* only timing related registers will be programed */ --2.42.0.345.gaab89be2eb
Re: [PATCH 3/5] Staging: sm750fb: Rename displayControl
Quoted 10 lines · Julia Lawall
Quoted 3 lines · Dorcas AnonoLitunya
Rename variable displayControl to
display_control. This follows snakecase naming convention and ensures consistent naming style throughout the file.Issue by checkpatch.Actually, the variable seems to be dispControl?
I had actually missed this. Thanks for the correction. Its now corrected in v2.
Dorcas
Quoted 87 lines
julia
Quoted 85 lines
Mutes the following checkpatch error:
CHECK: Avoid CamelCase: <dispControl>Signed-off-by Dorcas AnonoLitunya <[email protected]>--- drivers/staging/sm750fb/ddk750_mode.c | 32 +++++++++++++-------------- 1 file changed, 16 insertions(+), 16 deletions(-)drivers/staging/sm750fb/ddk750_mode.c +16
-17@@ -15,7 +15,7 @@*/ static unsigned long display_control_adjust_SM750LE (struct mode_parameter *mode_param, -unsigned long dispControl) +unsigned long disp_control) {unsigned long x, y;@@ -36,42 +36,42 @@ display_control_adjust_SM750LE(struct mode_parameter *mode_param, ((x - 1) & CRT_AUTO_CENTERING_BR_RIGHT_MASK));/* -* Assume common fields in dispControl have been properly set before +* Assume common fields in disp_control have been properly set before * calling this function. -* This function only sets the extra fields in dispControl. +* This function only sets the extra fields in disp_control. */ /* Clear bit 29:27 of display control register */ - dispControl &= ~CRT_DISPLAY_CTRL_CLK_MASK ; + disp_control &= ~CRT_DISPLAY_CTRL_CLK_MASK ;/* Set bit 29:27 of display control register for the right clock */ /* Note that SM750LE only need to supported 7 resolutions. */ if (x ==800 && y ==600 ) - dispControl |=CRT_DISPLAY_CTRL_CLK_PLL41 ; + disp_control |=CRT_DISPLAY_CTRL_CLK_PLL41 ;else if (x ==1024 && y ==768 ) - dispControl |=CRT_DISPLAY_CTRL_CLK_PLL65 ; + disp_control |=CRT_DISPLAY_CTRL_CLK_PLL65 ;else if (x ==1152 && y ==864 ) - dispControl |=CRT_DISPLAY_CTRL_CLK_PLL80 ; + disp_control |=CRT_DISPLAY_CTRL_CLK_PLL80 ;else if (x ==1280 && y ==768 ) - dispControl |=CRT_DISPLAY_CTRL_CLK_PLL80 ; + disp_control |=CRT_DISPLAY_CTRL_CLK_PLL80 ;else if (x ==1280 && y ==720 ) - dispControl |=CRT_DISPLAY_CTRL_CLK_PLL74 ; + disp_control |=CRT_DISPLAY_CTRL_CLK_PLL74 ;else if (x ==1280 && y ==960 ) - dispControl |=CRT_DISPLAY_CTRL_CLK_PLL108 ; + disp_control |=CRT_DISPLAY_CTRL_CLK_PLL108 ;else if (x ==1280 && y ==1024 ) - dispControl |=CRT_DISPLAY_CTRL_CLK_PLL108 ; + disp_control |=CRT_DISPLAY_CTRL_CLK_PLL108 ;else /* default to VGA clock */ - dispControl |=CRT_DISPLAY_CTRL_CLK_PLL25 ; + disp_control |=CRT_DISPLAY_CTRL_CLK_PLL25 ;/* Set bit 25:24 of display controller */ - dispControl |= (CRT_DISPLAY_CTRL_CRTSELECT |CRT_DISPLAY_CTRL_RGBBIT ); + disp_control |= (CRT_DISPLAY_CTRL_CRTSELECT |CRT_DISPLAY_CTRL_RGBBIT );/* Set bit 14 of display controller */ - dispControl |=DISPLAY_CTRL_CLOCK_PHASE ; + disp_control |=DISPLAY_CTRL_CLOCK_PHASE ; -poke32 (CRT_DISPLAY_CTRL , dispControl); +poke32 (CRT_DISPLAY_CTRL , disp_control); -return dispControl; +return disp_control; }/* only timing related registers will be programed */ --2.42.0.345.gaab89be2eb
PATCH 4/5 Staging: sm750fb: Rename programModeRegisters
In reply to Dorcas AnonoLitunyaRename function programModeRegisters to program_mode_registers. This follows snakecase naming convention and ensures consistent naming style throughout the file.Issue by checkpatch.
Mutes the following checkpatch error:
CHECK: Avoid CamelCase: <programModeRegisters>
--- drivers/staging/sm750fb/ddk750_mode.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/sm750fb/ddk750_mode.c +3 -3
@@ -75,8 +75,8 @@ display_control_adjust_SM750LE(struct mode_parameter *mode_param, }/* only timing related registers will be programed */ -static int programModeRegisters (struct mode_parameter *mode_param, -struct pll_value *pll) +static int program_mode_registers (struct mode_parameter *mode_param, +struct pll_value *pll) {int ret =0 ;int cnt =0 ;
@@ -220,6 +220,6 @@ int ddk750_setModeTiming(struct mode_parameter *parm, enum clock_type clock)outb_p (0x88 ,0x3d4 );outb_p (0x06 ,0x3d5 ); } -programModeRegisters (parm, &pll); +program_mode_registers (parm, &pll);return 0 ; }
Signature · 1 line
2.42.0.345.gaab89be2eb
PATCH 5/5 Staging: sm750fb: Rename ddk750_setModeTiming
In reply to Dorcas AnonoLitunyaRename function ddk750_setModeTiming to ddk750_set_mode_timing.This patch affects three files as the function is imported to other external files.
Renaming the function ensures snakecase naming convention is followed thus enabling consistent naming style throughout.Issue by checkpatch.
Mutes the following checkpatch error:
CHECK:Avoid CamelCase: <ddk750_setModeTiming>
--- drivers/staging/sm750fb/ddk750_mode.c | 2 +- drivers/staging/sm750fb/ddk750_mode.h | 2 +- drivers/staging/sm750fb/sm750_hw.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/staging/sm750fb/ddk750_mode.c +1 -1
@@ -207,7 +207,7 @@ static int program_mode_registers(struct mode_parameter *mode_param,return ret; } -int ddk750_setModeTiming (struct mode_parameter *parm,enum clock_type clock) +int ddk750_set_mode_timing (struct mode_parameter *parm,enum clock_type clock) {struct pll_value pll;
drivers/staging/sm750fb/ddk750_mode.h +1 -1
@@ -33,5 +33,5 @@ struct mode_parameter { enum spolarity clock_phase_polarity; }; -int ddk750_setModeTiming (struct mode_parameter *parm,enum clock_type clock); +int ddk750_set_mode_timing (struct mode_parameter *parm,enum clock_type clock);#endif
drivers/staging/sm750fb/sm750_hw.c +1 -1
@@ -305,7 +305,7 @@ int hw_sm750_crtc_setMode(struct lynxfb_crtc *crtc, clock =SECONDARY_PLL ;pr_debug ("Request pixel clock = %lu\n" , modparm.pixel_clock); - ret =ddk750_setModeTiming (&modparm, clock); + ret =ddk750_set_mode_timing (&modparm, clock);if (ret) {pr_err ("Set mode timing failed\n" ); goto exit;
Signature · 1 line
2.42.0.345.gaab89be2eb