Type encoding info dropped from variable and function names in NIC driver part2
cover Type encoding info dropped from variable and function names in NIC driver part2
This patchset series consist of fixes to issues found by checkpatch
Pavan Bobba (11):
staging: vt6655: Type encoding info dropped from variable name
"qwBSSTimestamp"
staging: vt6655: Type encoding info dropped from variable name
"qwTSFOffset"
staging: vt6655: Type encoding info dropped from function name
"CARDqGetTSFOffset"
staging: vt6655: Type encoding info dropped from function name
"CARDbSetBeaconPeriod"
staging: vt6655: Type encoding info dropped from variable name
"wBeaconInterval"
staging: vt6655: Type encoding info dropped from variable name
"qwNextTBTT"
staging: vt6655: Type encoding info dropped from function name
"CARDqGetNextTBTT"
staging: vt6655: Type encoding info dropped from function name
"CARDbRadioPowerOff"
staging: vt6655: Type encoding info dropped from function name
"CARDvSafeResetTx"
staging: vt6655: Type encoding info dropped from variable name
"pCurrTD"
staging: vt6655: Type encoding info dropped from variable name
"apTailTD"
drivers/staging/vt6655/card.c | 90 ++++++++++++++-------------- drivers/staging/vt6655/card.h | 18 +++--- drivers/staging/vt6655/device.h | 4 +- drivers/staging/vt6655/device_main.c | 18 +++--- drivers/staging/vt6655/rxtx.c | 2 +- 5 files changed, 66 insertions(+), 66 deletions(-)
Signature · 1 line
2.34.1
PATCH 1/11 staging: vt6655: Type encoding info dropped from variable name "qwBSSTimestamp"
variable name "qwBSSTimestamp" updated like below:
a.type encoding info dropped from name
b.camelcase name replaced by snakecase
Issue found by checkpatch
--- drivers/staging/vt6655/card.c | 8 ++++---- drivers/staging/vt6655/card.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-)
drivers/staging/vt6655/card.c +4 -4
@@ -280,7 +280,7 @@ bool card_set_phy_parameter(struct vnt_private *priv, u8 bb_type)* In: * priv - The adapter to be sync. * rx_rate - data rate of receive beacon -* qwBSSTimestamp - Rx BCN's TSF +* bss_timestamp - Rx BCN's TSF * qwLocalTSF - Local TSF * Out: * none
@@ -288,15 +288,15 @@ bool card_set_phy_parameter(struct vnt_private *priv, u8 bb_type)* Return Value: none */ bool card_update_tsf (struct vnt_private *priv,unsigned char rx_rate, -u64 qwBSSTimestamp) +u64 bss_timestamp) {u64 local_tsf;u64 qwTSFOffset =0 ; local_tsf =vt6655_get_current_tsf (priv); -if (qwBSSTimestamp != local_tsf) { - qwTSFOffset =CARDqGetTSFOffset (rx_rate, qwBSSTimestamp, +if (bss_timestamp != local_tsf) { + qwTSFOffset =CARDqGetTSFOffset (rx_rate, bss_timestamp, local_tsf);/* adjust TSF, HW's TSF add TSF Offset reg */ qwTSFOffset =le64_to_cpu (qwTSFOffset);
drivers/staging/vt6655/card.h +1 -1
@@ -55,7 +55,7 @@ void CARDvSafeResetRx(struct vnt_private *priv);void CARDbRadioPowerOff (struct vnt_private *priv);bool card_set_phy_parameter (struct vnt_private *priv,u8 bb_type);bool card_update_tsf (struct vnt_private *priv,unsigned char rx_rate, -u64 qwBSSTimestamp); +u64 bss_timestamp);bool CARDbSetBeaconPeriod (struct vnt_private *priv,unsigned short wBeaconInterval);
Signature · 1 line
2.34.1
PATCH 2/11 staging: vt6655: Type encoding info dropped from variable name "qwTSFOffset"
In reply to Pavan Bobbavariable name "qwTSFOffset" updated like below:
a.type encoding info dropped from name
b.camelcase name replaced by snakecase
Issue found by checkpatch
--- drivers/staging/vt6655/card.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/staging/vt6655/card.c +5 -5
@@ -291,17 +291,17 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate, u64 bss_timestamp) {u64 local_tsf; -u64 qwTSFOffset =0 ; +u64 tsf_offset =0 ; local_tsf =vt6655_get_current_tsf (priv);if (bss_timestamp != local_tsf) { - qwTSFOffset =CARDqGetTSFOffset (rx_rate, bss_timestamp, + tsf_offset =CARDqGetTSFOffset (rx_rate, bss_timestamp, local_tsf);/* adjust TSF, HW's TSF add TSF Offset reg */ - qwTSFOffset =le64_to_cpu (qwTSFOffset); -iowrite32 ((u32 )qwTSFOffset, priv->port_offset +MAC_REG_TSFOFST ); -iowrite32 ((u32)(qwTSFOffset >>32 ), priv->port_offset +MAC_REG_TSFOFST +4 ); + tsf_offset =le64_to_cpu (tsf_offset); +iowrite32 ((u32 )tsf_offset, priv->port_offset +MAC_REG_TSFOFST ); +iowrite32 ((u32)(tsf_offset >>32 ), priv->port_offset +MAC_REG_TSFOFST +4 );vt6655_mac_reg_bits_on (priv->port_offset,MAC_REG_TFTCTL ,TFTCTL_TSFSYNCEN ); }return true;
Signature · 1 line
2.34.1
PATCH 3/11 staging: vt6655: Type encoding info dropped from function name "CARDqGetTSFOffset"
In reply to Pavan Bobbafunction name "CARDqGetTSFOffset" updated like below:
a.type encoding info dropped from name
b.camelcase name replaced by snakecase
Issue found by checkpatch
--- drivers/staging/vt6655/card.c | 6 +++--- drivers/staging/vt6655/card.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/staging/vt6655/card.c +3 -3
@@ -10,7 +10,7 @@* CARDvUpdateBasicTopRate - Update BasicTopRate * CARDbAddBasicRate - Add to BasicRateSet * CARDbIsOFDMinBasicRate - Check if any OFDM rate is in BasicRateSet -* CARDqGetTSFOffset - Calculate TSFOffset +* card_get_tsf_offset - Calculate TSFOffset * vt6655_get_current_tsf - Read Current NIC TSF counter * CARDqGetNextTBTT - Calculate Next Beacon TSF counter * CARDvSetFirstNextTBTT - Set NIC Beacon time
@@ -296,7 +296,7 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate, local_tsf =vt6655_get_current_tsf (priv);if (bss_timestamp != local_tsf) { - tsf_offset =CARDqGetTSFOffset (rx_rate, bss_timestamp, + tsf_offset =card_get_tsf_offset (rx_rate, bss_timestamp, local_tsf);/* adjust TSF, HW's TSF add TSF Offset reg */ tsf_offset =le64_to_cpu (tsf_offset);
@@ -708,7 +708,7 @@ unsigned char card_get_pkt_type(struct vnt_private *priv)* * Return Value: TSF Offset value */ -u64 CARDqGetTSFOffset (unsigned char rx_rate,u64 qwTSF1,u64 qwTSF2) +u64 card_get_tsf_offset (unsigned char rx_rate,u64 qwTSF1,u64 qwTSF2) {unsigned short wRxBcnTSFOffst;
drivers/staging/vt6655/card.h +1 -1
@@ -48,7 +48,7 @@ void CARDvUpdateNextTBTT(struct vnt_private *priv, u64 qwTSF, unsigned short wBeaconInterval);u64 vt6655_get_current_tsf (struct vnt_private *priv);u64 CARDqGetNextTBTT (u64 qwTSF,unsigned short wBeaconInterval); -u64 CARDqGetTSFOffset (unsigned char rx_rate,u64 qwTSF1,u64 qwTSF2); +u64 card_get_tsf_offset (unsigned char rx_rate,u64 qwTSF1,u64 qwTSF2);unsigned char card_get_pkt_type (struct vnt_private *priv);void CARDvSafeResetTx (struct vnt_private *priv);void CARDvSafeResetRx (struct vnt_private *priv);
Signature · 1 line
2.34.1
PATCH 4/11 staging: vt6655: Type encoding info dropped from function name "CARDbSetBeaconPeriod"
In reply to Pavan Bobbafunction name "CARDbSetBeaconPeriod" updated like below:
a.type encoding info dropped from name
b.camelcase name replaced by snakecase
Issue found by checkpatch
--- drivers/staging/vt6655/card.c | 2 +- drivers/staging/vt6655/card.h | 2 +- drivers/staging/vt6655/device_main.c | 2 +- drivers/staging/vt6655/rxtx.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
drivers/staging/vt6655/card.c +1 -1
@@ -320,7 +320,7 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,* * Return Value: true if succeed; otherwise false */ -bool CARDbSetBeaconPeriod (struct vnt_private *priv, +bool card_set_beacon_period (struct vnt_private *priv,unsigned short wBeaconInterval) {u64 qwNextTBTT;
drivers/staging/vt6655/card.h +1 -1
@@ -56,7 +56,7 @@ void CARDbRadioPowerOff(struct vnt_private *priv);bool card_set_phy_parameter (struct vnt_private *priv,u8 bb_type);bool card_update_tsf (struct vnt_private *priv,unsigned char rx_rate,u64 bss_timestamp); -bool CARDbSetBeaconPeriod (struct vnt_private *priv, +bool card_set_beacon_period (struct vnt_private *priv,unsigned short wBeaconInterval);#endif /* __CARD_H__ */
drivers/staging/vt6655/device_main.c +1 -1
@@ -1537,7 +1537,7 @@ static void vnt_bss_info_changed(struct ieee80211_hw *hw,card_update_tsf (priv, conf->beacon_rate->hw_value, conf->sync_tsf); -CARDbSetBeaconPeriod (priv, conf->beacon_int); +card_set_beacon_period (priv, conf->beacon_int);CARDvSetFirstNextTBTT (priv, conf->beacon_int); }else {
drivers/staging/vt6655/rxtx.c +1 -1
@@ -1456,7 +1456,7 @@ int vnt_beacon_enable(struct vnt_private *priv, struct ieee80211_vif *vif,CARDvSetFirstNextTBTT (priv, conf->beacon_int); -CARDbSetBeaconPeriod (priv, conf->beacon_int); +card_set_beacon_period (priv, conf->beacon_int);return vnt_beacon_make (priv, vif); }
Signature · 1 line
2.34.1
PATCH 5/11 staging: vt6655: Type encoding info dropped from variable name "wBeaconInterval"
In reply to Pavan Bobbavariable name "wBeaconInterval" updated like below:
a.type encoding info dropped from name
b.camelcase name replaced by snakecase
Issue found by checkpatch
--- drivers/staging/vt6655/card.c | 26 +++++++++++++------------- drivers/staging/vt6655/card.h | 8 ++++---- drivers/staging/vt6655/device.h | 2 +- 3 files changed, 18 insertions(+), 18 deletions(-)
drivers/staging/vt6655/card.c +13 -13
@@ -314,24 +314,24 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,* Parameters: * In: * priv - The adapter to be set. -* wBeaconInterval - Beacon Interval +* beacon_interval - Beacon Interval * Out: * none * * Return Value: true if succeed; otherwise false */ bool card_set_beacon_period (struct vnt_private *priv, -unsigned short wBeaconInterval) +unsigned short beacon_interval) {u64 qwNextTBTT; qwNextTBTT =vt6655_get_current_tsf (priv);/* Get Local TSF counter */ - qwNextTBTT =CARDqGetNextTBTT (qwNextTBTT, wBeaconInterval); + qwNextTBTT =CARDqGetNextTBTT (qwNextTBTT, beacon_interval);/* set HW beacon interval */ -iowrite16 (wBeaconInterval, priv->port_offset +MAC_REG_BI ); - priv->wBeaconInterval = wBeaconInterval; +iowrite16 (beacon_interval, priv->port_offset +MAC_REG_BI ); + priv->beacon_interval = beacon_interval;/* Set NextTBTT */ qwNextTBTT =le64_to_cpu (qwNextTBTT);iowrite32 ((u32 )qwNextTBTT, priv->port_offset +MAC_REG_NEXTTBTT );
@@ -764,11 +764,11 @@ u64 vt6655_get_current_tsf(struct vnt_private *priv)* * Return Value: TSF value of next Beacon */ -u64 CARDqGetNextTBTT (u64 qwTSF,unsigned short wBeaconInterval) +u64 CARDqGetNextTBTT (u64 qwTSF,unsigned short beacon_interval) {u32 beacon_int; - beacon_int = wBeaconInterval *1024 ; + beacon_int = beacon_interval *1024 ;if (beacon_int) {do_div (qwTSF, beacon_int); qwTSF +=1 ;
@@ -785,21 +785,21 @@ u64 CARDqGetNextTBTT(u64 qwTSF, unsigned short wBeaconInterval)* Parameters: * In: * iobase - IO Base -* wBeaconInterval - Beacon Interval +* beacon_interval - Beacon Interval * Out: * none * * Return Value: none */ void CARDvSetFirstNextTBTT (struct vnt_private *priv, -unsigned short wBeaconInterval) +unsigned short beacon_interval) {void __iomem *iobase = priv->port_offset;u64 qwNextTBTT; qwNextTBTT =vt6655_get_current_tsf (priv);/* Get Local TSF counter */ - qwNextTBTT =CARDqGetNextTBTT (qwNextTBTT, wBeaconInterval); + qwNextTBTT =CARDqGetNextTBTT (qwNextTBTT, beacon_interval);/* Set NextTBTT */ qwNextTBTT =le64_to_cpu (qwNextTBTT);iowrite32 ((u32 )qwNextTBTT, iobase +MAC_REG_NEXTTBTT );
@@ -815,18 +815,18 @@ void CARDvSetFirstNextTBTT(struct vnt_private *priv,* In: * priv - The adapter to be set * qwTSF - Current TSF counter -* wBeaconInterval - Beacon Interval +* beacon_interval - Beacon Interval * Out: * none * * Return Value: none */ void CARDvUpdateNextTBTT (struct vnt_private *priv,u64 qwTSF, -unsigned short wBeaconInterval) +unsigned short beacon_interval) {void __iomem *iobase = priv->port_offset; - qwTSF =CARDqGetNextTBTT (qwTSF, wBeaconInterval); + qwTSF =CARDqGetNextTBTT (qwTSF, beacon_interval);/* Set NextTBTT */ qwTSF =le64_to_cpu (qwTSF);iowrite32 ((u32 )qwTSF, iobase +MAC_REG_NEXTTBTT );
drivers/staging/vt6655/card.h +4 -4
@@ -43,11 +43,11 @@ void card_set_rspinf(struct vnt_private *priv, u8 bb_type);void CARDvUpdateBasicTopRate (struct vnt_private *priv);bool CARDbIsOFDMinBasicRate (struct vnt_private *priv);void CARDvSetFirstNextTBTT (struct vnt_private *priv, -unsigned short wBeaconInterval); +unsigned short beacon_interval);void CARDvUpdateNextTBTT (struct vnt_private *priv,u64 qwTSF, -unsigned short wBeaconInterval); +unsigned short beacon_interval);u64 vt6655_get_current_tsf (struct vnt_private *priv); -u64 CARDqGetNextTBTT (u64 qwTSF,unsigned short wBeaconInterval); +u64 CARDqGetNextTBTT (u64 qwTSF,unsigned short beacon_interval);u64 card_get_tsf_offset (unsigned char rx_rate,u64 qwTSF1,u64 qwTSF2);unsigned char card_get_pkt_type (struct vnt_private *priv);void CARDvSafeResetTx (struct vnt_private *priv);
@@ -57,6 +57,6 @@ bool card_set_phy_parameter(struct vnt_private *priv, u8 bb_type);bool card_update_tsf (struct vnt_private *priv,unsigned char rx_rate,u64 bss_timestamp);bool card_set_beacon_period (struct vnt_private *priv, -unsigned short wBeaconInterval); +unsigned short beacon_interval);#endif /* __CARD_H__ */
drivers/staging/vt6655/device.h +1 -1
@@ -281,7 +281,7 @@ struct vnt_private {unsigned char abyEEPROM[EEP_MAX_CONTEXT_SIZE ];/* unsigned long alignment */ -unsigned short wBeaconInterval; +unsigned short beacon_interval;u16 wake_up_count;struct work_struct interrupt_work;
Signature · 1 line
2.34.1
PATCH 6/11 staging: vt6655: Type encoding info dropped from variable name "qwNextTBTT"
In reply to Pavan Bobbavariable name "qwTSFOffset" updated like below:
a.type encoding info dropped from name
b.camelcase name replaced by snakecase
Issue found by checkpatch
--- drivers/staging/vt6655/card.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
drivers/staging/vt6655/card.c +12 -12
@@ -323,19 +323,19 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,bool card_set_beacon_period (struct vnt_private *priv,unsigned short beacon_interval) { -u64 qwNextTBTT; +u64 next_tbtt; - qwNextTBTT =vt6655_get_current_tsf (priv);/* Get Local TSF counter */ + next_tbtt =vt6655_get_current_tsf (priv);/* Get Local TSF counter */ - qwNextTBTT =CARDqGetNextTBTT (qwNextTBTT, beacon_interval); + next_tbtt =CARDqGetNextTBTT (next_tbtt, beacon_interval);/* set HW beacon interval */ iowrite16 (beacon_interval, priv->port_offset +MAC_REG_BI ); priv->beacon_interval = beacon_interval;/* Set NextTBTT */ - qwNextTBTT =le64_to_cpu (qwNextTBTT); -iowrite32 ((u32 )qwNextTBTT, priv->port_offset +MAC_REG_NEXTTBTT ); -iowrite32 ((u32)(qwNextTBTT >>32 ), priv->port_offset +MAC_REG_NEXTTBTT +4 ); + next_tbtt =le64_to_cpu (next_tbtt); +iowrite32 ((u32 )next_tbtt, priv->port_offset +MAC_REG_NEXTTBTT ); +iowrite32 ((u32)(next_tbtt >>32 ), priv->port_offset +MAC_REG_NEXTTBTT +4 );vt6655_mac_reg_bits_on (priv->port_offset,MAC_REG_TFTCTL ,TFTCTL_TBTTSYNCEN );return true;
@@ -795,15 +795,15 @@ void CARDvSetFirstNextTBTT(struct vnt_private *priv, unsigned short beacon_interval) {void __iomem *iobase = priv->port_offset; -u64 qwNextTBTT; +u64 next_tbtt; - qwNextTBTT =vt6655_get_current_tsf (priv);/* Get Local TSF counter */ + next_tbtt =vt6655_get_current_tsf (priv);/* Get Local TSF counter */ - qwNextTBTT =CARDqGetNextTBTT (qwNextTBTT, beacon_interval); + next_tbtt =CARDqGetNextTBTT (next_tbtt, beacon_interval);/* Set NextTBTT */ - qwNextTBTT =le64_to_cpu (qwNextTBTT); -iowrite32 ((u32 )qwNextTBTT, iobase +MAC_REG_NEXTTBTT ); -iowrite32 ((u32)(qwNextTBTT >>32 ), iobase +MAC_REG_NEXTTBTT +4 ); + next_tbtt =le64_to_cpu (next_tbtt); +iowrite32 ((u32 )next_tbtt, iobase +MAC_REG_NEXTTBTT ); +iowrite32 ((u32)(next_tbtt >>32 ), iobase +MAC_REG_NEXTTBTT +4 );vt6655_mac_reg_bits_on (iobase,MAC_REG_TFTCTL ,TFTCTL_TBTTSYNCEN ); }
Signature · 1 line
2.34.1
PATCH 7/11 staging: vt6655: Type encoding info dropped from function name "CARDqGetNextTBTT"
In reply to Pavan Bobbafunction name "CARDqGetNextTBTT" updated like below:
a.type encoding info dropped from name
b.camelcase name replaced by snakecase
Issue found by checkpatch
--- drivers/staging/vt6655/card.c | 10 +++++----- drivers/staging/vt6655/card.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-)
drivers/staging/vt6655/card.c +5 -5
@@ -12,7 +12,7 @@* CARDbIsOFDMinBasicRate - Check if any OFDM rate is in BasicRateSet * card_get_tsf_offset - Calculate TSFOffset * vt6655_get_current_tsf - Read Current NIC TSF counter -* CARDqGetNextTBTT - Calculate Next Beacon TSF counter +* card_get_next_tbtt - Calculate Next Beacon TSF counter * CARDvSetFirstNextTBTT - Set NIC Beacon time * CARDvUpdateNextTBTT - Sync. NIC Beacon time * CARDbRadioPowerOff - Turn Off NIC Radio Power
@@ -327,7 +327,7 @@ bool card_set_beacon_period(struct vnt_private *priv, next_tbtt =vt6655_get_current_tsf (priv);/* Get Local TSF counter */ - next_tbtt =CARDqGetNextTBTT (next_tbtt, beacon_interval); + next_tbtt =card_get_next_tbtt (next_tbtt, beacon_interval);/* set HW beacon interval */ iowrite16 (beacon_interval, priv->port_offset +MAC_REG_BI );
@@ -764,7 +764,7 @@ u64 vt6655_get_current_tsf(struct vnt_private *priv)* * Return Value: TSF value of next Beacon */ -u64 CARDqGetNextTBTT (u64 qwTSF,unsigned short beacon_interval) +u64 card_get_next_tbtt (u64 qwTSF,unsigned short beacon_interval) {u32 beacon_int;
@@ -799,7 +799,7 @@ void CARDvSetFirstNextTBTT(struct vnt_private *priv, next_tbtt =vt6655_get_current_tsf (priv);/* Get Local TSF counter */ - next_tbtt =CARDqGetNextTBTT (next_tbtt, beacon_interval); + next_tbtt =card_get_next_tbtt (next_tbtt, beacon_interval);/* Set NextTBTT */ next_tbtt =le64_to_cpu (next_tbtt);iowrite32 ((u32 )next_tbtt, iobase +MAC_REG_NEXTTBTT );
@@ -826,7 +826,7 @@ void CARDvUpdateNextTBTT(struct vnt_private *priv, u64 qwTSF, {void __iomem *iobase = priv->port_offset; - qwTSF =CARDqGetNextTBTT (qwTSF, beacon_interval); + qwTSF =card_get_next_tbtt (qwTSF, beacon_interval);/* Set NextTBTT */ qwTSF =le64_to_cpu (qwTSF);iowrite32 ((u32 )qwTSF, iobase +MAC_REG_NEXTTBTT );
drivers/staging/vt6655/card.h +1 -1
@@ -47,7 +47,7 @@ void CARDvSetFirstNextTBTT(struct vnt_private *priv,void CARDvUpdateNextTBTT (struct vnt_private *priv,u64 qwTSF,unsigned short beacon_interval);u64 vt6655_get_current_tsf (struct vnt_private *priv); -u64 CARDqGetNextTBTT (u64 qwTSF,unsigned short beacon_interval); +u64 card_get_next_tbtt (u64 qwTSF,unsigned short beacon_interval);u64 card_get_tsf_offset (unsigned char rx_rate,u64 qwTSF1,u64 qwTSF2);unsigned char card_get_pkt_type (struct vnt_private *priv);void CARDvSafeResetTx (struct vnt_private *priv);
Signature · 1 line
2.34.1
PATCH 8/11 staging: vt6655: Type encoding info dropped from function name "CARDbRadioPowerOff"
In reply to Pavan Bobbafunction name "CARDbRadioPowerOff" updated like below:
a.type encoding info dropped from name
b.camelcase name replaced by snakecase
Issue found by checkpatch
--- drivers/staging/vt6655/card.c | 4 ++-- drivers/staging/vt6655/card.h | 2 +- drivers/staging/vt6655/device_main.c | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-)
drivers/staging/vt6655/card.c +2 -2
@@ -15,7 +15,7 @@* card_get_next_tbtt - Calculate Next Beacon TSF counter * CARDvSetFirstNextTBTT - Set NIC Beacon time * CARDvUpdateNextTBTT - Sync. NIC Beacon time -* CARDbRadioPowerOff - Turn Off NIC Radio Power +* card_radio_power_off - Turn Off NIC Radio Power * * Revision History: * 06-10-2003 Bryan YC Fan: Re-write codes to support VT3253 spec.
@@ -351,7 +351,7 @@ bool card_set_beacon_period(struct vnt_private *priv,* none * */ -void CARDbRadioPowerOff (struct vnt_private *priv) +void card_radio_power_off (struct vnt_private *priv) {if (priv->radio_off)return ;
drivers/staging/vt6655/card.h +1 -1
@@ -52,7 +52,7 @@ u64 card_get_tsf_offset(unsigned char rx_rate, u64 qwTSF1, u64 qwTSF2);unsigned char card_get_pkt_type (struct vnt_private *priv);void CARDvSafeResetTx (struct vnt_private *priv);void CARDvSafeResetRx (struct vnt_private *priv); -void CARDbRadioPowerOff (struct vnt_private *priv); +void card_radio_power_off (struct vnt_private *priv);bool card_set_phy_parameter (struct vnt_private *priv,u8 bb_type);bool card_update_tsf (struct vnt_private *priv,unsigned char rx_rate,u64 bss_timestamp);
drivers/staging/vt6655/device_main.c +3 -3
@@ -454,7 +454,7 @@ static void device_init_registers(struct vnt_private *priv) }if (priv->hw_radio_off || priv->bRadioControlOff) -CARDbRadioPowerOff (priv); +card_radio_power_off (priv);/* get Permanent network address */ SROMvReadEtherAddress (priv->port_offset, priv->abyCurrentNetAddr);
@@ -1349,7 +1349,7 @@ static void vnt_stop(struct ieee80211_hw *hw)MACbShutdown (priv);MACbSoftwareReset (priv); -CARDbRadioPowerOff (priv); +card_radio_power_off (priv);device_free_td0_ring (priv);device_free_td1_ring (priv);
@@ -1712,7 +1712,7 @@ static int vnt_init(struct vnt_private *priv) priv->mac_hw = true; -CARDbRadioPowerOff (priv); +card_radio_power_off (priv);return 0 ; }
Signature · 1 line
2.34.1
PATCH 9/11 staging: vt6655: Type encoding info dropped from function name "CARDvSafeResetTx"
In reply to Pavan Bobbafunction name "CARDvSafeResetTx" updated like below:
a.type encoding info dropped from name
b.camelcase name replaced by snakecase
Issue found by checkpatch
--- drivers/staging/vt6655/card.c | 2 +- drivers/staging/vt6655/card.h | 2 +- drivers/staging/vt6655/device_main.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/staging/vt6655/card.c +1 -1
@@ -382,7 +382,7 @@ void card_radio_power_off(struct vnt_private *priv)vt6655_mac_reg_bits_on (priv->port_offset,MAC_REG_GPIOCTL0 ,LED_ACTSET );/* LED issue */ } -void CARDvSafeResetTx (struct vnt_private *priv) +void card_safe_reset_tx (struct vnt_private *priv) {unsigned int uu;struct vnt_tx_desc *pCurrTD;
drivers/staging/vt6655/card.h +1 -1
@@ -50,7 +50,7 @@ u64 vt6655_get_current_tsf(struct vnt_private *priv);u64 card_get_next_tbtt (u64 qwTSF,unsigned short beacon_interval);u64 card_get_tsf_offset (unsigned char rx_rate,u64 qwTSF1,u64 qwTSF2);unsigned char card_get_pkt_type (struct vnt_private *priv); -void CARDvSafeResetTx (struct vnt_private *priv); +void card_safe_reset_tx (struct vnt_private *priv);void CARDvSafeResetRx (struct vnt_private *priv);void card_radio_power_off (struct vnt_private *priv);bool card_set_phy_parameter (struct vnt_private *priv,u8 bb_type);
drivers/staging/vt6655/device_main.c +1 -1
@@ -463,7 +463,7 @@ static void device_init_registers(struct vnt_private *priv)/* reset Tx pointer */ CARDvSafeResetRx (priv);/* reset Rx pointer */ -CARDvSafeResetTx (priv); +card_safe_reset_tx (priv);if (priv->local_id <=REV_ID_VT3253_A1 )vt6655_mac_reg_bits_on (priv->port_offset,MAC_REG_RCR ,RCR_WPAERR );
Signature · 1 line
2.34.1
PATCH 10/11 staging: vt6655: Type encoding info dropped from variable name "pCurrTD"
In reply to Pavan Bobbavariable name "pCurrTD" updated like below:
a.type encoding info dropped from name
b.camelcase name replaced by snakecase
Issue found by checkpatch
--- drivers/staging/vt6655/card.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/staging/vt6655/card.c +5 -5
@@ -385,7 +385,7 @@ void card_radio_power_off(struct vnt_private *priv)void card_safe_reset_tx (struct vnt_private *priv) {unsigned int uu; -struct vnt_tx_desc *pCurrTD; +struct vnt_tx_desc *curr_td;/* initialize TD index */ priv->apTailTD[0 ] = &priv->apTD0Rings[0 ];
@@ -398,13 +398,13 @@ void card_safe_reset_tx(struct vnt_private *priv) priv->iTDUsed[uu] =0 ;for (uu =0 ; uu < priv->opts.tx_descs[0 ]; uu++) { - pCurrTD = &priv->apTD0Rings[uu]; - pCurrTD->td0.owner =OWNED_BY_HOST ; + curr_td = &priv->apTD0Rings[uu]; + curr_td->td0.owner =OWNED_BY_HOST ;/* init all Tx Packet pointer to NULL */ }for (uu =0 ; uu < priv->opts.tx_descs[1 ]; uu++) { - pCurrTD = &priv->apTD1Rings[uu]; - pCurrTD->td0.owner =OWNED_BY_HOST ; + curr_td = &priv->apTD1Rings[uu]; + curr_td->td0.owner =OWNED_BY_HOST ;/* init all Tx Packet pointer to NULL */ }
Signature · 1 line
2.34.1
PATCH 11/11 staging: vt6655: Type encoding info dropped from variable name "apTailTD"
In reply to Pavan Bobbavariable name "apTailTD" updated like below:
a.type encoding info dropped from name
b.camelcase name replaced by snakecase
Issue found by checkpatch
--- drivers/staging/vt6655/card.c | 4 ++-- drivers/staging/vt6655/device.h | 2 +- drivers/staging/vt6655/device_main.c | 8 ++++---- 3 files changed, 7 insertions(+), 7 deletions(-)
drivers/staging/vt6655/card.c +2 -2
@@ -388,10 +388,10 @@ void card_safe_reset_tx(struct vnt_private *priv)struct vnt_tx_desc *curr_td;/* initialize TD index */ - priv->apTailTD[0 ] = &priv->apTD0Rings[0 ]; + priv->tail_td[0 ] = &priv->apTD0Rings[0 ]; priv->apCurrTD[0 ] = &priv->apTD0Rings[0 ]; - priv->apTailTD[1 ] = &priv->apTD1Rings[0 ]; + priv->tail_td[1 ] = &priv->apTD1Rings[0 ]; priv->apCurrTD[1 ] = &priv->apTD1Rings[0 ];for (uu =0 ; uu <TYPE_MAXTD ; uu++)
drivers/staging/vt6655/device.h +1 -1
@@ -133,7 +133,7 @@ struct vnt_private {volatile int iTDUsed[TYPE_MAXTD ];struct vnt_tx_desc *apCurrTD[TYPE_MAXTD ]; -struct vnt_tx_desc *apTailTD[TYPE_MAXTD ]; +struct vnt_tx_desc *tail_td[TYPE_MAXTD ];struct vnt_tx_desc *apTD0Rings;struct vnt_tx_desc *apTD1Rings;
drivers/staging/vt6655/device_main.c +4 -4
@@ -737,7 +737,7 @@ static int device_init_td0_ring(struct vnt_private *priv)if (i >0 ) priv->apTD0Rings[i -1 ].next_desc =cpu_to_le32 (priv->td0_pool_dma); - priv->apTailTD[0 ] = priv->apCurrTD[0 ] = &priv->apTD0Rings[0 ]; + priv->tail_td[0 ] = priv->apCurrTD[0 ] = &priv->apTD0Rings[0 ];return 0 ;
@@ -777,7 +777,7 @@ static int device_init_td1_ring(struct vnt_private *priv)if (i >0 ) priv->apTD1Rings[i -1 ].next_desc =cpu_to_le32 (priv->td1_pool_dma); - priv->apTailTD[1 ] = priv->apCurrTD[1 ] = &priv->apTD1Rings[0 ]; + priv->tail_td[1 ] = priv->apCurrTD[1 ] = &priv->apTD1Rings[0 ];return 0 ;
@@ -969,7 +969,7 @@ static int device_tx_srv(struct vnt_private *priv, unsigned int idx)unsigned char byTsr0;unsigned char byTsr1; -for (desc = priv->apTailTD[idx]; priv->iTDUsed[idx] >0 ; desc = desc->next) { +for (desc = priv->tail_td[idx]; priv->iTDUsed[idx] >0 ; desc = desc->next) {if (desc->td0.owner ==OWNED_BY_NIC )break ;if (works++ >15 )
@@ -1007,7 +1007,7 @@ static int device_tx_srv(struct vnt_private *priv, unsigned int idx) } } - priv->apTailTD[idx] = desc; + priv->tail_td[idx] = desc;return works; }
Signature · 1 line
2.34.1
Quoted 26 lines · Pavan Bobba
This patchset series consist of fixes to issues found by checkpatch
Pavan Bobba (11):
staging: vt6655: Type encoding info dropped from variable name
"qwBSSTimestamp"
staging: vt6655: Type encoding info dropped from variable name
"qwTSFOffset"
staging: vt6655: Type encoding info dropped from function name
"CARDqGetTSFOffset"
staging: vt6655: Type encoding info dropped from function name
"CARDbSetBeaconPeriod"
staging: vt6655: Type encoding info dropped from variable name
"wBeaconInterval"
staging: vt6655: Type encoding info dropped from variable name
"qwNextTBTT"
staging: vt6655: Type encoding info dropped from function name
"CARDqGetNextTBTT"
staging: vt6655: Type encoding info dropped from function name
"CARDbRadioPowerOff"
staging: vt6655: Type encoding info dropped from function name
"CARDvSafeResetTx"
staging: vt6655: Type encoding info dropped from variable name
"pCurrTD"
staging: vt6655: Type encoding info dropped from variable name
"apTailTD"
Quoted 7 lines
drivers/staging/vt6655/card.c | 90 ++++++++++++++-------------- drivers/staging/vt6655/card.h | 18 +++--- drivers/staging/vt6655/device.h | 4 +- drivers/staging/vt6655/device_main.c | 18 +++--- drivers/staging/vt6655/rxtx.c | 2 +- 5 files changed, 66 insertions(+), 66 deletions(-)