Skip to contentSkip to conversation

fstests: add some missing groups to some btrfs tests

PATCH Superseded [email protected] 2 participants 5 messages Dec 4, 2023 Btrfs file system

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover fstests: add some missing groups to some btrfs tests

From: Filipe Manana <[email protected]>

Some btrfs tests exercise some features but are not listed in the corresponding groups, so add them to those groups.

Filipe Manana (2):
btrfs: add some tests to the 'compress' group btrfs/048: add missing groups 'subvol', 'snapshot' and 'send'

 tests/btrfs/004 | 2 +-
 tests/btrfs/005 | 2 +-
 tests/btrfs/048 | 2 +-
 tests/btrfs/052 | 2 +-
 tests/btrfs/056 | 2 +-
 tests/btrfs/059 | 2 +-
 tests/btrfs/094 | 2 +-
 tests/btrfs/112 | 2 +-
 tests/btrfs/150 | 2 +-
 tests/btrfs/167 | 2 +-
 tests/btrfs/173 | 2 +-
 tests/btrfs/174 | 2 +-
 tests/btrfs/259 | 2 +-
 13 files changed, 13 insertions(+), 13 deletions(-)
Signature · 1 line
2.40.1
#1 lore raw

PATCH 1/2 btrfs: add some tests to the 'compress' group

From: Filipe Manana <[email protected]>

There are several btrfs test that exercise compression in one way or another but are not listed as part of the 'compress' group, so add them to that group.

---
 tests/btrfs/004 | 2 +-
 tests/btrfs/005 | 2 +-
 tests/btrfs/048 | 2 +-
 tests/btrfs/052 | 2 +-
 tests/btrfs/056 | 2 +-
 tests/btrfs/059 | 2 +-
 tests/btrfs/094 | 2 +-
 tests/btrfs/112 | 2 +-
 tests/btrfs/150 | 2 +-
 tests/btrfs/167 | 2 +-
 tests/btrfs/173 | 2 +-
 tests/btrfs/174 | 2 +-
 tests/btrfs/259 | 2 +-
 13 files changed, 13 insertions(+), 13 deletions(-)
tests/btrfs/004 +1 -1
index 78df6a3a..381ad072 100755
@@ -10,7 +10,7 @@
 # We check to end up back at the original file with the correct offset.
 #
 . ./common/preamble
-_begin_fstest auto rw metadata fiemap logical_resolve
+_begin_fstest auto rw metadata fiemap logical_resolve compress
 
 noise_pid=0
 
tests/btrfs/005 +1 -1
index 878a8c7c..84634770 100755
@@ -7,7 +7,7 @@
 # Btrfs Online defragmentation tests
 #
 . ./common/preamble
-_begin_fstest auto defrag
+_begin_fstest auto defrag compress
 cnt=119
 filesize=48000
 
tests/btrfs/048 +1 -1
index 93d4a171..7816a997 100755
@@ -11,7 +11,7 @@
 #  btrfs: fix zstd compression parameter
 #
 . ./common/preamble
-_begin_fstest auto quick
+_begin_fstest auto quick compress
 
 # Override the default cleanup function.
 _cleanup()
tests/btrfs/052 +1 -1
index 4408de21..0d60d413 100755
@@ -9,7 +9,7 @@
 # file.
 #
 . ./common/preamble
-_begin_fstest auto quick clone
+_begin_fstest auto quick clone compress
 
 # Override the default cleanup function.
 _cleanup()
tests/btrfs/056 +1 -1
index e5ac516d..e1263983 100755
@@ -15,7 +15,7 @@
 #    Btrfs: make fsync work after cloning into a file
 #
 . ./common/preamble
-_begin_fstest auto quick clone log
+_begin_fstest auto quick clone log compress
 
 # Override the default cleanup function.
 _cleanup()
tests/btrfs/059 +1 -1
index d2ced0ae..76a1e76e 100755
@@ -11,7 +11,7 @@
 #     Btrfs: add missing compression property remove in btrfs_ioctl_setflags
 #
 . ./common/preamble
-_begin_fstest auto quick
+_begin_fstest auto quick compress
 
 # Override the default cleanup function.
 _cleanup()
tests/btrfs/094 +1 -1
index e94cf17b..75804465 100755
@@ -18,7 +18,7 @@
 #   Btrfs: incremental send, fix clone operations for compressed extents
 #
 . ./common/preamble
-_begin_fstest auto quick send
+_begin_fstest auto quick send compress
 
 # Override the default cleanup function.
 _cleanup()
tests/btrfs/112 +1 -1
index c3f7fe5c..fd7aaad4 100755
@@ -8,7 +8,7 @@
 # corruption or data loss.
 #
 . ./common/preamble
-_begin_fstest auto quick clone prealloc
+_begin_fstest auto quick clone prealloc compress
 
 # Import common functions.
 . ./common/filter
tests/btrfs/150 +1 -1
index a7d7d9cc..c21e0a66 100755
@@ -11,7 +11,7 @@
 #	Btrfs: fix kernel oops while reading compressed data
 #
 . ./common/preamble
-_begin_fstest auto quick dangerous read_repair
+_begin_fstest auto quick dangerous read_repair compress
 
 # Import common functions.
 . ./common/filter
tests/btrfs/167 +1 -1
index fb271cfa..2cfcf100 100755
@@ -11,7 +11,7 @@
 # ac0b4145d662 ("btrfs: scrub: Don't use inode pages for device replace")
 #
 . ./common/preamble
-_begin_fstest auto quick replace volume
+_begin_fstest auto quick replace volume compress
 
 # Import common functions.
 . ./common/filter
tests/btrfs/173 +1 -1
index 4972a5a7..6e78a826 100755
@@ -8,7 +8,7 @@
 # CoW file nor compressed file.
 #
 . ./common/preamble
-_begin_fstest auto quick swap
+_begin_fstest auto quick swap compress
 
 . ./common/filter
 
tests/btrfs/174 +1 -1
index 0acd65f0..16305c18 100755
@@ -8,7 +8,7 @@
 # specific to Btrfs.
 #
 . ./common/preamble
-_begin_fstest auto quick swap
+_begin_fstest auto quick swap compress
 
 . ./common/filter
 
tests/btrfs/259 +1 -1
index 358a4550..7f053ac9 100755
@@ -8,7 +8,7 @@
 # at their max capacity.
 #
 . ./common/preamble
-_begin_fstest auto quick defrag fiemap
+_begin_fstest auto quick defrag fiemap compress
 
 # Import common functions.
 . ./common/filter
Signature · 1 line
2.40.1
Reviewed-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] btrfs: add some tests to the 'compress' group

Quoted 8 lines · On Mon, Dec 04, 2023 at 03:45:10PM +0000, [email protected] wrote:

From: Filipe Manana <[email protected]>

There are several btrfs test that exercise compression in one way or another but are not listed as part of the 'compress' group, so add them to that group.

---

Test groups update is warm welcome :) This patch makes sense to me.

Quoted 188 lines
 tests/btrfs/004 | 2 +-
 tests/btrfs/005 | 2 +-
 tests/btrfs/048 | 2 +-
 tests/btrfs/052 | 2 +-
 tests/btrfs/056 | 2 +-
 tests/btrfs/059 | 2 +-
 tests/btrfs/094 | 2 +-
 tests/btrfs/112 | 2 +-
 tests/btrfs/150 | 2 +-
 tests/btrfs/167 | 2 +-
 tests/btrfs/173 | 2 +-
 tests/btrfs/174 | 2 +-
 tests/btrfs/259 | 2 +-
 13 files changed, 13 insertions(+), 13 deletions(-)
tests/btrfs/004 +1 -1
index 78df6a3a..381ad072 100755
@@ -10,7 +10,7 @@
 # We check to end up back at the original file with the correct offset.
 #
 . ./common/preamble
-_begin_fstest auto rw metadata fiemap logical_resolve
+_begin_fstest auto rw metadata fiemap logical_resolve compress
 
 noise_pid=0
 
tests/btrfs/005 +1 -1
index 878a8c7c..84634770 100755
@@ -7,7 +7,7 @@
 # Btrfs Online defragmentation tests
 #
 . ./common/preamble
-_begin_fstest auto defrag
+_begin_fstest auto defrag compress
 cnt=119
 filesize=48000
 
tests/btrfs/048 +1 -1
index 93d4a171..7816a997 100755
@@ -11,7 +11,7 @@
 #  btrfs: fix zstd compression parameter
 #
 . ./common/preamble
-_begin_fstest auto quick
+_begin_fstest auto quick compress
 
 # Override the default cleanup function.
 _cleanup()
tests/btrfs/052 +1 -1
index 4408de21..0d60d413 100755
@@ -9,7 +9,7 @@
 # file.
 #
 . ./common/preamble
-_begin_fstest auto quick clone
+_begin_fstest auto quick clone compress
 
 # Override the default cleanup function.
 _cleanup()
tests/btrfs/056 +1 -1
index e5ac516d..e1263983 100755
@@ -15,7 +15,7 @@
 #    Btrfs: make fsync work after cloning into a file
 #
 . ./common/preamble
-_begin_fstest auto quick clone log
+_begin_fstest auto quick clone log compress
 
 # Override the default cleanup function.
 _cleanup()
tests/btrfs/059 +1 -1
index d2ced0ae..76a1e76e 100755
@@ -11,7 +11,7 @@
 #     Btrfs: add missing compression property remove in btrfs_ioctl_setflags
 #
 . ./common/preamble
-_begin_fstest auto quick
+_begin_fstest auto quick compress
 
 # Override the default cleanup function.
 _cleanup()
tests/btrfs/094 +1 -1
index e94cf17b..75804465 100755
@@ -18,7 +18,7 @@
 #   Btrfs: incremental send, fix clone operations for compressed extents
 #
 . ./common/preamble
-_begin_fstest auto quick send
+_begin_fstest auto quick send compress
 
 # Override the default cleanup function.
 _cleanup()
tests/btrfs/112 +1 -1
index c3f7fe5c..fd7aaad4 100755
@@ -8,7 +8,7 @@
 # corruption or data loss.
 #
 . ./common/preamble
-_begin_fstest auto quick clone prealloc
+_begin_fstest auto quick clone prealloc compress
 
 # Import common functions.
 . ./common/filter
tests/btrfs/150 +1 -1
index a7d7d9cc..c21e0a66 100755
@@ -11,7 +11,7 @@
 #	Btrfs: fix kernel oops while reading compressed data
 #
 . ./common/preamble
-_begin_fstest auto quick dangerous read_repair
+_begin_fstest auto quick dangerous read_repair compress
 
 # Import common functions.
 . ./common/filter
tests/btrfs/167 +1 -1
index fb271cfa..2cfcf100 100755
@@ -11,7 +11,7 @@
 # ac0b4145d662 ("btrfs: scrub: Don't use inode pages for device replace")
 #
 . ./common/preamble
-_begin_fstest auto quick replace volume
+_begin_fstest auto quick replace volume compress
 
 # Import common functions.
 . ./common/filter
tests/btrfs/173 +1 -1
index 4972a5a7..6e78a826 100755
@@ -8,7 +8,7 @@
 # CoW file nor compressed file.
 #
 . ./common/preamble
-_begin_fstest auto quick swap
+_begin_fstest auto quick swap compress
 
 . ./common/filter
 
tests/btrfs/174 +1 -1
index 0acd65f0..16305c18 100755
@@ -8,7 +8,7 @@
 # specific to Btrfs.
 #
 . ./common/preamble
-_begin_fstest auto quick swap
+_begin_fstest auto quick swap compress
 
 . ./common/filter
 
tests/btrfs/259 +1 -1
index 358a4550..7f053ac9 100755
@@ -8,7 +8,7 @@
 # at their max capacity.
 #
 . ./common/preamble
-_begin_fstest auto quick defrag fiemap
+_begin_fstest auto quick defrag fiemap compress
 
 # Import common functions.
 . ./common/filter
Signature · 1 line
2.40.1
#3 lore raw

PATCH 2/2 btrfs/048: add missing groups 'subvol', 'snapshot' and 'send'

In reply to [email protected]

From: Filipe Manana <[email protected]>

This test case exercises subvolumes, snapshot and send/receive, so add the corresponding groups to the test.

---
 tests/btrfs/048 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/btrfs/048 +1 -1
index 7816a997..8a88b8cc 100755
@@ -11,7 +11,7 @@
 #  btrfs: fix zstd compression parameter
 #
 . ./common/preamble
-_begin_fstest auto quick compress
+_begin_fstest auto quick compress subvol snapshot send
 
 # Override the default cleanup function.
 _cleanup()
Signature · 1 line
2.40.1
Reviewed-by on v1 2/2
#4 lore raw

Re: [PATCH 2/2] btrfs/048: add missing groups 'subvol', 'snapshot' and 'send'

Quoted 7 lines · On Mon, Dec 04, 2023 at 03:45:11PM +0000, [email protected] wrote:

From: Filipe Manana <[email protected]>

This test case exercises subvolumes, snapshot and send/receive, so add the corresponding groups to the test.

---

Good to me,

Quoted 20 lines
 tests/btrfs/048 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/btrfs/048 +1 -1
index 7816a997..8a88b8cc 100755
@@ -11,7 +11,7 @@
 #  btrfs: fix zstd compression parameter
 #
 . ./common/preamble
-_begin_fstest auto quick compress
+_begin_fstest auto quick compress subvol snapshot send
 
 # Override the default cleanup function.
 _cleanup()
Signature · 1 line
2.40.1