Skip to contentSkip to conversation

Add LDO5 MP5496 regulator

PATCH In review Varadarajan Narayanan 2 participants 4 messages Dec 15, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

cover Add LDO5 MP5496 regulator

Splitting the earlier patchset https://lore.kernel.org/linux-arm-msm/[email protected]/
and including the dt-bindings update (per https://lore.kernel.org/linux-arm-msm/[email protected]/).
Had to split since the regulator driver change and the USB driver
change were dependent. If the USB driver change gets merged before
the regulator driver change it could break the kernel boot up.

The earlier patch ec4f047679d5, incorrectly used 'l2' as the vdda-pll-supply. However, 'l5' is the correct ldo that supplies power to the USB PHY.

Following checks passed:
make W=1 ARCH=arm64 -j 16 CHECK_DTBS=y DT_SCHEMA_FILES=qcom dtbs_check make W=1 ARCH=arm64 -j 16 DT_CHECKER_FLAGS='-v -m' dt_binding_check DT_SCHEMA_FILES=qcom

Varadarajan Narayanan (2):
regulator: qcom_smd: Add l2, l5 sub-node to mp5496 regulator
regulator: qcom_smd: Add LDO5 MP5496 regulator

 .../devicetree/bindings/regulator/qcom,smd-rpm-regulator.yaml   | 2 +-
 drivers/regulator/qcom_smd-regulator.c                          | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
Signature · 1 line
2.34.1
#1 lore raw

PATCH 1/2 regulator: qcom_smd: Add l2, l5 sub-node to mp5496 regulator

Adding l2, l5 sub-node entry to mp5496 regulator node.

---
 .../devicetree/bindings/regulator/qcom,smd-rpm-regulator.yaml   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/regulator/qcom,smd-rpm-regulator.yaml +1 -1
index f2fd2df68a9e..b7241ce975b9 100644
@@ -22,7 +22,7 @@ description:
   Each sub-node is identified using the node's name, with valid values listed
   for each of the pmics below.
 
-  For mp5496, s1, s2
+  For mp5496, s1, s2, l2, l5
 
   For pm2250, s1, s2, s3, s4, l1, l2, l3, l4, l5, l6, l7, l8, l9, l10, l11,
   l12, l13, l14, l15, l16, l17, l18, l19, l20, l21, l22
Signature · 1 line
2.34.1
#3 lore raw

PATCH 2/2 regulator: qcom_smd: Add LDO5 MP5496 regulator

In reply to Varadarajan Narayanan

Add support for LDO5 regulator. This is used by IPQ9574 USB.

---
 drivers/regulator/qcom_smd-regulator.c | 1 +
 1 file changed, 1 insertion(+)
drivers/regulator/qcom_smd-regulator.c +1 -0
index 09c471a0ba2e..d1be9568025e 100644
@@ -796,6 +796,7 @@ static const struct rpm_regulator_data rpm_mp5496_regulators[] = {
 	{ "s1", QCOM_SMD_RPM_SMPA, 1, &mp5496_smps, "s1" },
 	{ "s2", QCOM_SMD_RPM_SMPA, 2, &mp5496_smps, "s2" },
 	{ "l2", QCOM_SMD_RPM_LDOA, 2, &mp5496_ldoa2, "l2" },
+	{ "l5", QCOM_SMD_RPM_LDOA, 5, &mp5496_ldoa2, "l5" },
 	{}
 };
 
Signature · 1 line
2.34.1