renesas: r8a779g0: Add missing SCIF_CLK2
Subsystems (5)
Geert Uytterhoeven
maintainercover renesas: r8a779g0: Add missing SCIF_CLK2
Hi all,
R-Car V4H actually has two SCIF_CLK pins.
The second pin provides the SCIF_CLK signal for HSCIF2 and SCIF4. The first pin provides the SCIF_CLK signal for the other (H)SCIF instances.
This patch series adds the missing SCIF_CLK2 pin group/function to the R-Car V4H pin control driver and to the R-Car V4H DTS file, and fixes the HSCIF2 and SCIF4 DT descriptions to refer to the proper clock.
As SCIF_CLK2 cannot be used on the White Hawk development board, I could not test proper operation of HSCIF2 and SCIF4. I did verify that HSCIF2 and SCIF4 do not operate properly when trying to use (the first and thus incorrect) SCIF_CLK as the clock source.
I plan to queue these in renesas-pinctrl resp. renesas-devel for v6.9.
Thanks for your comments!
Geert Uytterhoeven (2):
pinctrl: renesas: r8a779g0: Add missing SCIF_CLK2 pin group/function
arm64: dts: renesas: r8a779g0: Add missing SCIF_CLK2
arch/arm64/boot/dts/renesas/r8a779g0.dtsi | 12 +++++++++--- drivers/pinctrl/renesas/pfc-r8a779g0.c | 14 ++++++++++++++ 2 files changed, 23 insertions(+), 3 deletions(-)
Signature · 12 lines
2.34.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus TorvaldsGeert Uytterhoeven
maintainerPATCH 1/2 pinctrl: renesas: r8a779g0: Add missing SCIF_CLK2 pin group/function
R-Car V4H actually has two SCIF_CLK pins.
The second pin provides the SCIF_CLK signal for HSCIF2 and SCIF4.
--- drivers/pinctrl/renesas/pfc-r8a779g0.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
drivers/pinctrl/renesas/pfc-r8a779g0.c +14 -0
@@ -2468,6 +2468,14 @@ static const unsigned int scif_clk_mux[] = { SCIF_CLK_MARK, }; +static const unsigned int scif_clk2_pins[] = { +/* SCIF_CLK2 */ +RCAR_GP_PIN (8 ,11 ), +}; +static const unsigned int scif_clk2_mux[] = { +SCIF_CLK2_MARK , +}; +/* - SSI ------------------------------------------------- */ static const unsigned int ssi_data_pins[] = {/* SSI_SD */
@@ -2790,6 +2798,7 @@ static const struct sh_pfc_pin_group pinmux_groups[] = {SH_PFC_PIN_GROUP (scif4_clk),SH_PFC_PIN_GROUP (scif4_ctrl),SH_PFC_PIN_GROUP (scif_clk), +SH_PFC_PIN_GROUP (scif_clk2),SH_PFC_PIN_GROUP (ssi_data), SH_PFC_PIN_GROUP(ssi_ctrl),
@@ -3126,6 +3135,10 @@ static const char * const scif_clk_groups[] = { "scif_clk", }; +static const char *const scif_clk2_groups[] = { +"scif_clk2" , +}; +static const char *const ssi_groups[] = {"ssi_data" ,"ssi_ctrl" ,
@@ -3215,6 +3228,7 @@ static const struct sh_pfc_function pinmux_functions[] = {SH_PFC_FUNCTION (scif3),SH_PFC_FUNCTION (scif4),SH_PFC_FUNCTION (scif_clk), +SH_PFC_FUNCTION (scif_clk2), SH_PFC_FUNCTION(ssi),
Signature · 1 line
2.34.1
Geert Uytterhoeven
maintainerPATCH 2/2 arm64: dts: renesas: r8a779g0: Add missing SCIF_CLK2
In reply to Geert UytterhoevenR-Car V4H actually has two SCIF_CLK pins.
The second pin provides the SCIF_CLK signal for HSCIF2 and SCIF4.
--- arch/arm64/boot/dts/renesas/r8a779g0.dtsi | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/renesas/r8a779g0.dtsi +9 -3
@@ -185,13 +185,19 @@ psci { method = "smc"; }; - /* External SCIF clock - to be overridden by boards that provide it */ + /* External SCIF clocks - to be overridden by boards that provide them */ scif_clk: scif { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <0>; }; + scif_clk2: scif2 { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <0>; + }; + soc: soc { compatible = "simple-bus"; interrupt-parent = <&gic>;
@@ -690,7 +696,7 @@ hscif2: serial@e6560000 { interrupts = <GIC_SPI 248 IRQ_TYPE_LEVEL_HIGH>; clocks = <&cpg CPG_MOD 516>, <&cpg CPG_CORE R8A779G0_CLK_SASYNCPERD1>, - <&scif_clk>; + <&scif_clk2>; clock-names = "fck", "brg_int", "scif_clk"; dmas = <&dmac0 0x35>, <&dmac0 0x34>, <&dmac1 0x35>, <&dmac1 0x34>;
@@ -1066,7 +1072,7 @@ scif4: serial@e6c40000 { interrupts = <GIC_SPI 254 IRQ_TYPE_LEVEL_HIGH>; clocks = <&cpg CPG_MOD 705>, <&cpg CPG_CORE R8A779G0_CLK_SASYNCPERD1>, - <&scif_clk>; + <&scif_clk2>; clock-names = "fck", "brg_int", "scif_clk"; dmas = <&dmac0 0x59>, <&dmac0 0x58>, <&dmac1 0x59>, <&dmac1 0x58>;
Signature · 1 line
2.34.1